Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

On March 10, 2015, 1:26 p.m., Ed Hynan wrote: /trunk/res/res_timing_kqueue.c, line 240 https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240 Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. Justin T. Gibbs wrote

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

On March 10, 2015, 1:26 p.m., Ed Hynan wrote: /trunk/res/res_timing_kqueue.c, line 240 https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240 Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. Justin T. Gibbs wrote

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

On March 10, 2015, 1:26 p.m., Ed Hynan wrote: /trunk/res/res_timing_kqueue.c, line 240 https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240 Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. Justin T. Gibbs wrote

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

/#comment25182 See above. - Ed Hynan On March 9, 2015, 6:21 p.m., Justin T. Gibbs wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

-429b-aa0f-873bbd652a6f__patchtest.tgz Thanks, Ed Hynan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

developed test program that can run original or patched 11.7.0 code. File Attachments (updated) Test r3 https://reviewboard.asterisk.org/media/uploaded/files/2015/03/06/a29ea5c5-3253-429b-aa0f-873bbd652a6f__patchtest.tgz Thanks, Ed Hynan

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

Thanks, Ed Hynan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

that would necessarily be the case here. Ed Hynan wrote: I agree, no need for a message there. Re. stderr, it's used several other places in original code, so it seemed preferred in this context. BTW, don't the ast log functions use time formatting? Are they suitable within localtime.c

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14550 --- - Ed Hynan On March 3, 2015, 3:25 p.m., Ed Hynan wrote

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

program https://reviewboard.asterisk.org/media/uploaded/files/2015/02/25/f7a19f2a-4a8a-4aff-b7d6-44a4146c358c__patchtest.tgz Thanks, Ed Hynan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

[asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

or patched 11.7.0 code. File Attachments localtime.c (11.7.0) test program https://reviewboard.asterisk.org/media/uploaded/files/2015/02/25/f7a19f2a-4a8a-4aff-b7d6-44a4146c358c__patchtest.tgz Thanks, Ed Hynan

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14553 --- On Feb. 25, 2015, 4:37 p.m., Ed Hynan wrote