Re: Snapshot access to regular users of Ant

2018-03-17 Thread Gintautas Grigelionis
Thanks for pointing this out. To me, it means one thing: release more often.
The way I read it, publishing is not forbidden per se, but rather
advertising.
That's consistent with GitHub repo clones being available, but without
"clone me at GitHub" ribbons.

On the other hand, I rewrote the manual (which was still talking about CVS),
suggesting that the proper way to propose code changes would be a GitHub PR
rather than an archive uploaded to Bugzilla, so please correct me if I'm
wrong before
Ant 1.10.3 gets released...

Gintas

2018-03-17 13:07 GMT+01:00 Jaikiran Pai :

> I was about to send a mail to the user mailing list about the Ant nightly
> job which publishes the daily snapshots, so that they can test some bug
> fixes and new features (JUnit 5 in particular). However, I happened to read
> the Apache release policy[1] which states regular users aren't even meant
> to know about such snapshots.
>
> That seems a bit too restrictive, especially for open source projects. Is
> that documentation being followed and if it is, then I guess I shouldn't be
> letting the user@ mailing list know about these snapshots nor ask them to
> test out the new feature?
>
> After reading that policy, I'm starting to wonder if the Jenkins job
> should even publish these snapshots.
>
> [1] http://www.apache.org/legal/release-policy.html#publication
>
> -Jaikiran
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


Re: ant git commit: Add dependency description

2018-03-17 Thread Gintautas Grigelionis
Thanks for correcting the omission.

But, the task manual page states that junit.jar of JUnit 4 might still be
necessary
...

For junit-vintage engine:

   - junit-vintage-engine.jar
   - junit.jar (JUnit 4.x version)

...

so perhaps it's worth a note anyway.

I was wondering why junitlauncher task depended on all jars being present
in Ant classpath with no possibility to set a separate classpath for the
task?

Gintas

2018-03-17 15:05 GMT+01:00 Jaikiran Pai :

> The change noted in this commit isn't actually needed i.e. the
> junitlauncher task doesn't require the junit.jar to be available as noted
> in the junitlauncher task's manual.
>
> I however forgot to include the JUnit 5 platform API dependencies in this
> Library Dependencies table, which I'll add now.
>
> -Jaikiran
>
>
> On 17/03/18 7:22 PM, gin...@apache.org wrote:
>
>> Repository: ant
>> Updated Branches:
>>refs/heads/master 50b9be737 -> a312b6728
>>
>>
>> Add dependency description
>>
>> Project: http://git-wip-us.apache.org/repos/asf/ant/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/a312b672
>> Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/a312b672
>> Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/a312b672
>>
>> Branch: refs/heads/master
>> Commit: a312b6728acb7a8d1f8765899615205b3042cb7e
>> Parents: 50b9be7
>> Author: Gintas Grigelionis 
>> Authored: Sat Mar 17 14:52:06 2018 +0100
>> Committer: Gintas Grigelionis 
>> Committed: Sat Mar 17 14:52:06 2018 +0100
>>
>> --
>>   manual/install.html | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>> --
>>
>>
>> http://git-wip-us.apache.org/repos/asf/ant/blob/a312b672/man
>> ual/install.html
>> --
>> diff --git a/manual/install.html b/manual/install.html
>> index 191f3da..cfe9266 100644
>> --- a/manual/install.html
>> +++ b/manual/install.html
>> @@ -787,7 +787,9 @@ these tasks available. Please refer to the > href="#optionalTasks">Installing A
>> 
>> 
>>   junit.jar
>> -junit task (may be in classpath
>> passed to task rather than Ant's classpath)
>> +junit task (may be in classpath
>> passed to task rather than
>> +  Ant's classpath) and > href="Tasks/junitlauncher.html">junitlauncher
>> task (must be on
>> +  Ant's classpath)
>>   https://junit.org/; target="_top">https://junit.org/
>> 
>> 
>> 
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


Re: ant git commit: Add dependency description

2018-03-17 Thread Jaikiran Pai
The change noted in this commit isn't actually needed i.e. the 
junitlauncher task doesn't require the junit.jar to be available as 
noted in the junitlauncher task's manual.


I however forgot to include the JUnit 5 platform API dependencies in 
this Library Dependencies table, which I'll add now.


-Jaikiran


On 17/03/18 7:22 PM, gin...@apache.org wrote:

Repository: ant
Updated Branches:
   refs/heads/master 50b9be737 -> a312b6728


Add dependency description

Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/a312b672
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/a312b672
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/a312b672

Branch: refs/heads/master
Commit: a312b6728acb7a8d1f8765899615205b3042cb7e
Parents: 50b9be7
Author: Gintas Grigelionis 
Authored: Sat Mar 17 14:52:06 2018 +0100
Committer: Gintas Grigelionis 
Committed: Sat Mar 17 14:52:06 2018 +0100

--
  manual/install.html | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
--


http://git-wip-us.apache.org/repos/asf/ant/blob/a312b672/manual/install.html
--
diff --git a/manual/install.html b/manual/install.html
index 191f3da..cfe9266 100644
--- a/manual/install.html
+++ b/manual/install.html
@@ -787,7 +787,9 @@ these tasks available. Please refer to the Installing A


  junit.jar
-junit task (may be in classpath passed to 
task rather than Ant's classpath)
+junit task (may be in classpath passed 
to task rather than
+  Ant's classpath) and junitlauncher task (must be on
+  Ant's classpath)
  https://junit.org/; target="_top">https://junit.org/






-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-03-17 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/a312b6728acb7a8d1f8765899615205b3042cb7e#commitcomment-28138020
  
@jaikiran would it be possible to add a `classpath` attribute?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Snapshot access to regular users of Ant

2018-03-17 Thread Jaikiran Pai
I was about to send a mail to the user mailing list about the Ant 
nightly job which publishes the daily snapshots, so that they can test 
some bug fixes and new features (JUnit 5 in particular). However, I 
happened to read the Apache release policy[1] which states regular users 
aren't even meant to know about such snapshots.


That seems a bit too restrictive, especially for open source projects. 
Is that documentation being followed and if it is, then I guess I 
shouldn't be letting the user@ mailing list know about these snapshots 
nor ask them to test out the new feature?


After reading that policy, I'm starting to wonder if the Jenkins job 
should even publish these snapshots.


[1] http://www.apache.org/legal/release-policy.html#publication

-Jaikiran


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: AW: Ant nightly Jenkins job

2018-03-17 Thread Jaikiran Pai
This is now done. The Ant_Nightly job now generates the Ant distribution 
which can be used for testing the bug fixes/features that go into the 
"master" branch. The distribution is available at 
https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/


-Jaikiran


On 01/03/18 6:54 PM, Jan Matèrne (jhm) wrote:

sure
Jan


-Ursprüngliche Nachricht-
Von: Jaikiran Pai [mailto:jai.forums2...@gmail.com]
Gesendet: Donnerstag, 1. März 2018 12:50
An: Ant Developers List
Betreff: Ant nightly Jenkins job

Would it be OK if I redo the Ant nightly jenkins job[1] to be a bit
more useful and publish an actual nightly binary, for users to try out
if they wish to?

[1] https://builds.apache.org/job/Ant_Nightly/

-Jaikiran


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: When is Ant 1.10.3 release expected?

2018-03-17 Thread Jaikiran Pai
I (finally) merged the JUnit 5 work to master. Rest of the fork related 
work for this task is something that I don't plan to make available in 
this release (the work is going to take some time). So I guess, we can 
make a new release.


-Jaikiran


On 12/03/18 4:53 PM, Stefan Bodewig wrote:

On 2018-03-12, Sarika Sinha wrote:


After 1.10.2 release and the regression bug, do we see 1.10.3 getting
released early?

Whatever early means :-)

https://lists.apache.org/thread.html/169de63328f60269e88a37446f27549733f9f57e8de6778276c581a1@%3Cdev.ant.apache.org%3E

We informally decided to cut two new releases (1.10.3 and 1.9.11)
soon. To me it looks we are currently waiting for the initial JUnit5
support to get merged. No firm date for the release but it could happen
within a few days/weeks.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

2018-03-17 Thread jaikiran
Github user jaikiran closed the pull request at:

https://github.com/apache/ant/pull/60


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

2018-03-17 Thread jaikiran
Github user jaikiran commented on the issue:

https://github.com/apache/ant/pull/60
  
This is now merged upstream. Closing this PR. Thanks Stefan for the 
extensive review.



---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: User implementations of custom interfaces can have access to Task instance?

2018-03-17 Thread Jaikiran Pai
Thanks for the input, Stefan. I took your suggestion and exposed a API 
to get the Project on that custom interface. It doesn't/can't directly 
use the IntrospectionHelper support available to project components, 
since unlike nested elements of a task, this custom class can be plugged 
in something like:


classname="some.custom.class.implementing.an.task.specific.interface"/>


plus the fact that this custom class can reside in a classloader defined 
by nested  elements of this task.


-Jaikiran


On 13/03/18 3:36 PM, Stefan Bodewig wrote:

On 2018-03-13, Jaikiran Pai wrote:


I'm looking for some suggestion on whether it's a good/bad idea to
expose a method to custom user defined classes which takes a "Task"
object. This is in context of the JUnitLauncher task that I recently
added. It allows custom report formatters/listeners to be implemented
and the expectation is that such classes will implement the
TestResultFormatter interface that is (newly) part of Ant. This
interface exposes:
void setTask(Task currentExecutingTask)
so the implementations of this class have access to the current task
that's running. Right now, the only reason I exposed that Task
instance was to allow such implementation to issue log messages from
within the implementation like:

In that case I'd prefer the formatter implementation to extend
ProjectConponent or just provide a setProject(Project) method.

When your formatter is created by Ant - for example as a nested element
- something like

 public void addConfiguredFormatter(TestFormatter f)

then IntrospectionHelper will see the setProject method and invoke it
with a reference to the current project.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-03-17 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/64
  
@AurelienLourot we moved the discussion to 
[JIRA](https://issues.apache.org/jira/browse/IVY-1280)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org