At the moment APR penalizes Linux[1] compared to FreeBSD by never
passing SOCK_NONBLOCK in apr_socket_accept()'s accept4() calls. This is
annoying for httpd, which always sets O_NONBLOCK for the accepted socket
anyway - at the cost of two extra system calls.
Thanks to r1551659 [2] if you build
On Tue, Apr 23, 2024 at 10:43:15AM +0200, Ivan Zhakov wrote:
> On Mon, 22 Apr 2024 at 17:01, Joe Orton wrote:
> > Open
> > questions on where to draw the line, as to what goes in a separate
> > library, and much more I'm sure.
> >
> Well, it's a good question. I was
On Sat, Apr 20, 2024 at 12:38:20PM +0200, Ivan Zhakov wrote:
> I would suggest separating APR in different libraries, while keeping them
> in one project/source tree.
>
> Something like that:
> - apr-2
> - apr-dbd-2
> - apr-dbm-2
> - apr-xlate-2 (?)
> - apr-crypto-2
> - apr-xml-2
> - apr-ldap-2
>
On Fri, Mar 15, 2024 at 10:26:27AM -, yla...@apache.org wrote:
> Author: ylavic
> Date: Fri Mar 15 10:26:27 2024
> New Revision: 1916332
>
> URL: http://svn.apache.org/viewvc?rev=1916332=rev
> Log:
> testescape: missing ';' in entity escaping.
The test now fails... did you intend to commit
On Thu, Feb 08, 2024 at 04:56:47PM +0100, Ruediger Pluem wrote:
> On 2/8/24 4:49 PM, jor...@apache.org wrote:
> > Author: jorton
> > Date: Thu Feb 8 15:49:14 2024
> > New Revision: 1915658
...
> Did you miss to commit the changes to buckets/apr_brigade.c?
Ooops! Yup, fixed in r1915661 - thanks a
On Thu, Feb 01, 2024 at 04:50:31PM +0100, Yann Ylavic wrote:
> dev@ team,
>
> I'm wondering if we could/should remove APR_POOL_DEBUG specifics in
> apr-util 1.6.x and 1.7.x, otherwise it's not possible run
> non-pool-debug apr-util with pool-debug apr.
>
> Fortunately the only dependency on
On Tue, Dec 26, 2023 at 07:11:00PM +0100, Daniel Sahlberg wrote:
> Hi,
>
> The web page Mailing Lists [1] has links to mail-archives.apache.org. That
> site was decommissioned by ASF Infra a while back. The addresses still work
> but redirect to the new Ponymail archive (same as the first link).
On Tue, Jan 02, 2024 at 02:00:00PM +0100, Daniel Sahlberg wrote:
> My idea was to incrementally improve the code but maybe a better way
> is to switch to access() completely. access() seems to be widely
> available but I will have to read up on the setuid properties to make
> sure we don't
On Tue, Dec 26, 2023 at 07:17:51PM +0100, Daniel Sahlberg wrote:
> Hi,
>
> apr_uid_current() can retur the user id and primary group id of a user. Is
> there a way to find out if a user also has secondary groups (something
> similar to getgrouplist(3)?
>
> The Subversion project has some bug
On Mon, Dec 18, 2023 at 04:09:36PM +0100, Ruediger Pluem wrote:
>
>
> On 12/18/23 12:09 PM, Joe Orton wrote:
> > On Thu, Dec 14, 2023 at 04:44:47PM -0500, Ben Kallus wrote:
> >> memcpy to or from NULL is undefined behavior, even for copies of
> >> length 0. See
On Thu, Dec 14, 2023 at 04:44:47PM -0500, Ben Kallus wrote:
> memcpy to or from NULL is undefined behavior, even for copies of
> length 0. See this godbolt link for an example of how this can cause
> problems: https://gcc.godbolt.org/z/zfvnMMsds
>
> This patch avoids calling memcpy for 0-length
On Thu, Nov 23, 2023 at 05:42:10PM +, Emmanuel Dreyfus wrote:
> On Thu, Nov 23, 2023 at 05:36:06PM +0000, Joe Orton wrote:
> > 3) in the mean time I worked up a PR for mod_dav_fs which adds a global
> > mutex around the dbm lockdb use. This passes my stress tests for the
Adding dev@httpd to a dev@apr thread about apr_dbm locking being broken.
On Sun, Nov 12, 2023 at 07:43:13AM -0600, Greg Stein wrote:
> Or, apps can stick to an older APR. ... we don't have to carry this forward
> into future versions of APR (IMO).
>
> To your point, it is probably a single page
On Mon, Sep 25, 2023 at 03:58:18PM +0100, Joe Orton wrote:
> It is unspecified whether the apr_dbm.h interface is safe to use for
> multiple processes/threads having r/w access to a single database.
> Results appear to be:
>
> - sdbm, gdbm are safe
> - bdb, ndbm are not
On Mon, Sep 25, 2023 at 05:37:00PM +0200, Branko Čibej wrote:
> IIRC, Berkeley DB multi-process concurrency is managed through an on-disk
> "register" file external to the actual key/value store. The key/value store
> format is not affected by the presence of this file. The DB_REGISTER
> mechanism
It is unspecified whether the apr_dbm.h interface is safe to use for
multiple processes/threads having r/w access to a single database.
Results appear to be:
- sdbm, gdbm are safe
- bdb, ndbm are not safe
(Berkeley DB obviously can be used in a way which is safe for multiple
r/w users but it
On Tue, Jan 31, 2023 at 04:22:56PM -0500, Eric Covener wrote:
> I hosed 1.7.1/1.6.2 and the archives have -rcX in them at the top
> level. I would like to call for an expedited vote to replace them
> with version bumps. I will proceed once we get 3 binding +1.
>
> I have re-tagged because I
The DBD code assumes long == int in SQL_INTEGER parameter handling. Does
anybody know what is right, or if it matters? I can't work it out from
10 minutes of googling. GCC 12.1 is warning for the current code which
is clearly heap corruption for 64-bit builds:
dbd/apr_dbd_odbc.c: In function
On Fri, Jan 14, 2022 at 11:37:35AM +0100, Ruediger Pluem wrote:
>
>
> On 1/14/22 6:47 AM, William A Rowe Jr wrote:
> > In addition to a broken release of brotli (where enc/dec don't specify
> > -lbrotlicommon,
> > even on trunk, for openssl and other consumers to ferret out that binding),
> >
On Fri, Sep 10, 2021 at 12:51:53AM -, yla...@apache.org wrote:
> Author: ylavic
> Date: Fri Sep 10 00:51:53 2021
> New Revision: 1893204
>
> URL: http://svn.apache.org/viewvc?rev=1893204=rev
> Log:
> apr_file_setaside: don't blindly kill the old cleanup and file descriptor.
>
> There is no
Description:
An out-of-bounds array read in the apr_time_exp*() functions was fixed
in the Apache Portable Runtime 1.6.3 release (CVE-2017-12613). The fix
for this issue was not carried forward to the APR 1.7.x branch, and
hence version 1.7.0 regressed compared to 1.6.3 and is vulnerable to
Description:
An out-of-bounds array read in the apr_time_exp*() functions was fixed in the
Apache Portable Runtime 1.6.3 release (CVE-2017-12613). The fix for this issue
was not carried forward to the APR 1.7.x branch, and hence version 1.7.0
regressed compared to 1.6.3 and is vulnerable to
On Fri, Jul 02, 2021 at 04:10:08PM +0200, Yann Ylavic wrote:
> On Fri, Jul 2, 2021 at 3:51 PM Yann Ylavic wrote:
> >
> > On Fri, Jul 2, 2021 at 3:19 PM Joe Orton wrote:
> > >
> > > If pthread_mutex_timedlock() is not supported, apr_thread_mutex_unlock
If pthread_mutex_timedlock() is not supported, apr_thread_mutex_unlock()
will take a locked mutex and immediately lock it again:
https://github.com/apache/apr/blob/trunk/locks/unix/thread_mutex.c#L297
APR_DECLARE(apr_status_t) apr_thread_mutex_unlock(apr_thread_mutex_t *mutex)
{
On Wed, Mar 24, 2021 at 04:07:32PM +0100, Yann Ylavic wrote:
> On Wed, Mar 24, 2021 at 3:40 PM Yann Ylavic wrote:
> >
> > On Wed, Mar 24, 2021 at 3:24 PM Joe Orton wrote:
> > >
> > > This now fails for me in exactly the same way when using ./configure
> >
On Sat, Mar 06, 2021 at 10:20:59PM -, yla...@apache.org wrote:
> Author: ylavic
> Date: Sat Mar 6 22:20:59 2021
> New Revision: 1887279
>
> URL: http://svn.apache.org/viewvc?rev=1887279=rev
> Log:
> build/apr_common.m4: avoid explicit inclusion of "confdefs.h"
>
> The failure is observed on
I assume all these functions should be declared static but haven't
looked at the code. branches/1.7.x as at r1875766 -
jose/apr_jose_decode.c:21:14: warning: no previous prototype for
‘apr_jose_flatten’ [-Wmissing-prototypes]
21 | apr_status_t apr_jose_flatten(apr_bucket_brigade *bb,
On Sat, Aug 24, 2019 at 05:39:17PM +0300, Ivan Zhakov wrote:
> For what it's worth, I'm -1 on the changes done in r1862071 and
> r1862435 for the reasons listed above.
>
> PS: No idea if I can actually veto changes, because while I'm a
> committer on the APR project, I am not in its PMC. But "-1"
On Wed, Jul 03, 2019 at 02:43:02PM +0300, Ivan Zhakov wrote:
> They also make the existing old API unusable for many cases thus
> making a switch to the new API mandatory, even though it doesn't have
> to be so (see below).
>
> APR 1.x did not specify that the result of apr_dir_read() has to be
On Tue, Jul 02, 2019 at 02:47:48PM +, build...@apache.org wrote:
> The Buildbot has detected a build exception on builder apr-trunk while
> building . Full details are available at:
> https://ci.apache.org/builders/apr-trunk/builds/434
>
> Buildbot URL: https://ci.apache.org/
Does
On Tue, Jul 02, 2019 at 08:22:47AM -0500, Greg Stein wrote:
> On Tue, Jul 2, 2019 at 8:04 AM Branko Čibej wrote:
> > Perhaps this is the right time to note (again) that over in Subversion
> > land, we found that functions should take _two_ pool parameters: one for
> > allocating the returned
On Tue, Jul 02, 2019 at 11:18:31AM +0100, Joe Orton wrote:
> Reading the win32 code a bit more, it is not constant-memory even with
> the buffer in apr_dir_t, because it can allocate from dir->pool (and
> even create cleanups!) in the more_finfo() call, so I think the current
On Tue, Jul 02, 2019 at 09:59:20AM +0200, Branko Čibej wrote:
> On 02.07.2019 08:49, Joe Orton wrote:
> > On Thu, Jun 27, 2019 at 05:01:56PM +0300, Ivan Zhakov wrote:
> >> On Tue, 25 Jun 2019 at 17:21, wrote:
> >>
> >>> Author: jorton
> >>>
On Thu, Jun 27, 2019 at 05:01:56PM +0300, Ivan Zhakov wrote:
> On Tue, 25 Jun 2019 at 17:21, wrote:
>
> > Author: jorton
> > Date: Tue Jun 25 14:21:56 2019
> > New Revision: 1862071
> >
> > URL: http://svn.apache.org/viewvc?rev=1862071=rev
> > Log:
> > Add apr_dir_pread(), a variant of
6608=1816607=1816608=diff
> >
> > ==========
> > --- apr/apr/branches/1.7.x/CHANGES [utf-8] (original)
> > +++ apr/apr/branches/1.7.x/CHANGES [utf-8] Wed Nov 29 08:53:28 2017
> > @@ -1,6 +
On Thu, Feb 21, 2019 at 07:11:35PM +0100, Yann Ylavic wrote:
> Hi,
>
> can we stop preventing APR users (e.g. httpd) from using SIGUSR2
> because of the way a tool worked 16 years ago (and probably doesn't
> anymore)? No sarcasm here, just a question...
>
> IOW, may I:
+1 definitely, it's a bit
On Tue, Jul 24, 2018 at 02:25:57PM +0200, Yann Ylavic wrote:
> On Tue, Jul 24, 2018 at 11:43 AM, Graham Leggett wrote:
> > Throughout APR we have a long established convention where
> > “expensive” libraries are bound to APR through DSOs. All the SQL
> > database drivers are like this, LDAP is
On Tue, Jun 05, 2018 at 12:07:31PM +, Plüm, Rüdiger, Vodafone Group wrote:
> The usual approach in many locations is to store the created bucket brigade
> and reuse it. How about the following (untested):
Yes, that works too, thanks! Passes test suite and fixes the leak,
though I we need to
In 2.4's http_request.c there are two places doing:
bb = apr_brigade_create(c->pool, c->bucket_alloc);
to handle sending a FLUSH between requests and an EOR bucket which both
can't be done off r->pool. Because the brigade structure itself is
allocated out of c->pool this means we leak
On Wed, Dec 06, 2017 at 10:06:22AM -0600, William A Rowe Jr wrote:
> They trust the compiler to do the right things, so there is no special
> sauce added to apr-config. Respective build flags land in
> /usr/lib/apr-1/build/
> /usr/lib64/apr-1/build/
We do have to hack /usr/bin/apr-1-config to do:
On Fri, Dec 08, 2017 at 07:49:29AM +0100, Ruediger Pluem wrote:
> Why do we do the above test twice?
Over-zealous copy and pasting I think! Removed now, thanks for
spotting it! r1817485
Regards, Joe
On Tue, Nov 28, 2017 at 12:22:27AM +0100, Yann Ylavic wrote:
> On Mon, Nov 27, 2017 at 5:54 PM, Joe Orton <jor...@redhat.com> wrote:
> > Version #2.
> >
> > Adds both apr_sockaddr_zone_set() and apr_sockaddr_zone_get() to set and
> > retrieve the zone id/name.
&g
On Wed, Nov 22, 2017 at 09:01:55AM -0500, Philip M. Gollucci wrote:
> Does it make sense to pull magic number 10 out into a #define ?
Sorry, I missed this. Could do, but sure why really, it's pretty common
to call strtol-like functions with hard-coded base?
Regards, Joe
Version #2.
Adds both apr_sockaddr_zone_set() and apr_sockaddr_zone_get() to set and
retrieve the zone id/name.
Also now changes apr_sockaddr_equal() to compare different scopes as not
equal, which I think is the only sensible way to do it, although that
function is a bit odd in ignoring port
This adds support for mapping scope/zone names to interface IDs for IPv6
link-local addresses. Not sure if scope or zone is the better term to
use here, any opinions? Could s/_zone_/_scope_/g easily enough.
Google suggests Windows supports if_nametoindex too, so the API should
be portable,
On Wed, Oct 25, 2017 at 10:22:46AM +0200, Rainer Jung wrote:
> Before the change, copying starts at "scope_delim + 1", after the change at
> "scope_delim". The log says "Simplify to use apr_pstrmemdup, no functional
> change.", so it seems that was not an intentional change. Shouldn't we
> correct
On Fri, Oct 13, 2017 at 11:51:54AM -0400, Jim Jagielski wrote:
> The long and short is that under maintainer mode, we cannot
> expect AC_CHECK_LIB to being correct any longer, because
> the combination of -Werror and -Wstrict-prototypes means
> that any and all functions looked for/checked for
On Thu, Mar 03, 2016 at 09:41:17AM -0600, William A Rowe Jr wrote:
> >From http://apr.apache.org/versioning.html...
>
> "Versions are denoted using a standard triplet of integers:
> *MAJOR.MINOR.PATCH*. The basic intent is that *MAJOR* versions are
> incompatible, large-scale upgrades of the API.
On Thu, Mar 03, 2016 at 04:24:07PM +0100, Yann Ylavic wrote:
> Don't we want to return APR_ENOTIMPL here until the FreeBSD implementation?
Good point. Done in r1733594 & r1733595
On Thu, Feb 25, 2016 at 01:12:52PM +0100, Jan Kaluza wrote:
>
> This is useful, for example, for daemons integration with systemd [1]. When
> daemon wants to bind to particular IP address during system start, there is
> no way how to determine that the network interface is really configured and
>
On Fri, Jul 31, 2015 at 03:50:08PM -0500, William Rowe wrote:
Thanks Daniel, sharing this with the dev@ list, as the problem and the fix
are both public.
Folks, what are your thoughts? Our expat is already quite old, and
the current release was 2.10, while we were still shipping 1.95.7,
On Thu, Jul 17, 2014 at 09:51:55PM +0200, Ruediger Pluem wrote:
ap_rflush creates a new brigade each time from the r-pool. So if you call it
often this can sum up.
In this case you better do the code of ap_rflush in your code and reuse the
brigade instead of creating it again
each time.
On Thu, Oct 24, 2013 at 01:39:09AM +0200, Rainer Jung wrote:
On 23.10.2013 22:22, jor...@apache.org wrote:
--- apr/apr/trunk/configure.in (original)
+++ apr/apr/trunk/configure.in Wed Oct 23 20:22:57 2013
@@ -681,7 +681,7 @@ case $host in
;;
*linux*)
On Mon, Jun 17, 2013 at 10:57:15AM -0400, Jeff Trawick wrote:
Tarballs/zipfiles are at http://apr.apache.org/dev/dist/
Sigs good, tests fine on F18, +1 for release and thanks for RMing.
[+1] Release APR 1.4.8 as GA
Regards, Joe
On Sun, May 05, 2013 at 03:12:20PM -0400, Eric Covener wrote:
On Sun, May 5, 2013 at 11:51 AM, Eric Covener cove...@gmail.com wrote:
I've got an issue AIX where the test added prior to
http://svn.apache.org/viewvc?view=revisionrevision=1309386
Works before r1309386 but not after
On Tue, Dec 11, 2012 at 11:35:10AM +0100, Jan Kaluza wrote:
the first attached patch fixes following gcc warning:
warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
Second patch removes unused SHA384 and SHA512 code from
sha2.c/sha2.h. If you
On Thu, Jan 05, 2012 at 01:35:50PM -0500, Jeff Trawick wrote:
We don't want to say go fish to APR applications if our hash plus
their vector results in an exploit.
I'll bite.
1) Chained hash tables have quadratic worst case insertion time,
O(n**2). The APR hash table (apr_hash_*)
On Fri, Jun 17, 2011 at 08:29:38PM +, Philip M. Gollucci wrote:
...
# apachectl -t
[Wed May 25 17:18:18 2011] [crit] (OS 1)Unknown host: alloc_listener:
failed to set up sockaddr for [2001:x:x:x:x::1]
Syntax error on line 41 of /usr/local/etc/apache22/httpd.conf:
Listen setup failed
On Wed, Jun 01, 2011 at 07:27:20PM -0400, Greg Stein wrote:
You're just talking about bringing back apr-util.
The motivation for combining the apr and apr-util projects (separate
tarball distributions) was that there we never had enough churn in
either to justify the additional overhead of a
On Thu, May 19, 2011 at 12:56:23PM -0500, William Rowe wrote:
[moving from embargoed to open discussion]
On 5/19/2011 9:53 AM, Joe Orton wrote:
On Wed, May 18, 2011 at 04:11:19PM -0500, William Rowe wrote:
On 5/18/2011 3:55 PM, Joe Orton wrote:
b) glibc does not match the pattern
On Wed, May 11, 2011 at 10:46:54AM -0500, William Rowe wrote:
On 5/11/2011 9:51 AM, jor...@apache.org wrote:
Author: jorton
Date: Wed May 11 14:51:33 2011
New Revision: 1101905
URL: http://svn.apache.org/viewvc?rev=1101905view=rev
Log:
* test/testfnmatch.c: Add a few more
On Wed, Mar 02, 2011 at 01:27:47AM +0200, Graham Leggett wrote:
Hi all,
I am currently struggling to get DNSServiceGetAddrInfo() from
zeroconf to work nicely with apr_portable.h, and need to clarify
whether I am missing anything.
DNSServiceGetAddrInfo() returns the DNS lookup in a
On Tue, Oct 05, 2010 at 01:17:19PM -0500, William Rowe wrote:
On 10/5/2010 2:40 AM, Joe Orton wrote:
Any objection to renaming the apr-util 1.5.x branch to trunk? It is
the trunk for that tree now.
Let us know if Nick's suggested change satisfies, I've drafted a trunk
which explains
Any objection to renaming the apr-util 1.5.x branch to trunk? It is
the trunk for that tree now.
Regards, Joe
On Fri, Oct 01, 2010 at 09:22:29AM -0400, Jeff Trawick wrote:
+/-1
[+1] Release apr-util 1.3.10 as GA
* signature is fine
* CHANGES is good
* builds, make check pass Fedora/x86_64
* installs, can build 2.2.x against w/apr-1.5.x
- config.guess/sub seem to have been replaced by 2006 variants
On Wed, Sep 29, 2010 at 06:59:58PM +0200, Rainer Jung wrote:
On 29.09.2010 18:32, Rainer Jung wrote:
On 29.09.2010 13:52, jor...@apache.org wrote:
--- apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh (original)
+++ apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh Wed Sep 29
11:52:55 2010
On Tue, Sep 28, 2010 at 07:05:09AM -0400, Jeff Trawick wrote:
any concerns about the timing?
any additional fixes people would like to see in that release?
1.3.x branch looks good to me; I've had a trawl through bugzilla and
can't find any low-hanging fruit there either.
Regards, Joe
On Tue, Sep 28, 2010 at 12:04:59PM -0500, William A. Rowe Jr. wrote:
On 9/28/2010 10:22 AM, Joe Orton wrote:
On Tue, Sep 28, 2010 at 07:05:09AM -0400, Jeff Trawick wrote:
any concerns about the timing?
any additional fixes people would like to see in that release?
I have been trying
On Wed, Sep 29, 2010 at 05:10:07AM -0500, William Rowe wrote:
On 9/29/2010 3:11 AM, Joe Orton wrote:
Bumping to a later 1.95.x+patches seems feasible actually, yeah, nice
idea. I'm going to try to get this done today; I'll probably break the
Win32 build (at least!) so help might
On Tue, Sep 28, 2010 at 07:05:09AM -0400, Jeff Trawick wrote:
any concerns about the timing?
any additional fixes people would like to see in that release?
I have been trying to backport security fixes for CVE-2009-3720 and
CVE-2009-3560 to the bundled copy of expat but am getting nowhere.
On Fri, May 28, 2010 at 03:54:40PM -, William Rowe wrote:
Author: wrowe
Date: Fri May 28 15:54:40 2010
New Revision: 949211
URL: http://svn.apache.org/viewvc?rev=949211view=rev
Log:
Solve ELF-32 builds on ia64-hpux
Did you mean to include the configure changes in that commit?
---
On Wed, May 12, 2010 at 03:30:29PM -0400, Jeff Trawick wrote:
The multiple-calls-to-pool_clear solution is definitely safer.
OK, so now I reviewed that too ;) The only difference between:
apr_pool_clear(ptrans);
apr_pool_destroy(pchild);
and simply:
apr_pool_destroy(pchild);
(given
On Tue, May 18, 2010 at 09:18:23AM +0200, Stefan Fritsch wrote:
On Tue, 18 May 2010, Ruediger Pluem wrote:
So if you want to close this fd you IMHO would need to do some refcounting
and only close it if no other filebucket still references it.
The filebuckets already do refcounting.
On Sun, Apr 25, 2010 at 10:56:04AM -0500, William Rowe wrote:
Going over the blockers to 2.0, here seem to be our choices since nobody
appears
to have the time or interest in ensuring apr_ldap becomes fully modular;
[X] Abandon apr_ldap_* API's to httpd 2.3 ldap, including required
On Tue, Mar 09, 2010 at 12:26:08PM +0200, Graham Leggett wrote:
On 08 Mar 2010, at 11:26 PM, Joe Orton wrote:
APR_FOPEN_LARGEFILE is intended to be (and is documented as)
advisory
rather than mandatory.
Exposing a NONBLOCK flag without attaching *any* semantics to it
w.r.t.
subsequent
On Mon, Mar 08, 2010 at 03:53:42PM -0500, Jeff Trawick wrote:
On Mon, Mar 8, 2010 at 9:59 AM, Graham Leggett minf...@sharp.fm wrote:
...
#if APR_HAS_LARGE_FILES defined(_LARGEFILE64_SOURCE)
oflags |= O_LARGEFILE;
#elif defined(O_LARGEFILE)
if (flag APR_FOPEN_LARGEFILE) {
On Wed, Feb 03, 2010 at 10:18:04AM -, Paul Querna wrote:
Author: pquerna
Date: Wed Feb 3 10:17:57 2010
New Revision: 905970
URL: http://svn.apache.org/viewvc?rev=905970view=rev
Log:
Add two new features to APR Files:
- When opened with normal rotating flag, every 60 seconds the file
On Sun, Jan 31, 2010 at 10:21:30AM -0500, Jeff Trawick wrote:
On Sun, Jan 31, 2010 at 8:46 AM, jor...@apache.org wrote:
Author: jorton
Date: Sun Jan 31 13:46:16 2010
New Revision: 905040
URL: http://svn.apache.org/viewvc?rev=905040view=rev
Log:
* file_io/unix/open.c
Snapshots of the APR and APR-util 1.4.x trees have been distributed by
as part of the httpd 2.3.4 alpha release. Should the APR project treat
those snapshots as releases for versioning purposes? In other words,
should we ensure future APR/APR-util releases maintain source and binary
On Tue, Dec 15, 2009 at 01:48:33AM -0500, William Rowe wrote:
Paul Querna wrote:
its an alpha release with a -dev copy of APR and APR-Util. Frankly,
Screw the user, because there aren't any. If someone bitches about an
alpha release breaking thier shit, tough shit, its alpha.
That's
On Tue, Dec 15, 2009 at 03:05:29PM +, Joe Orton wrote:
[ ] Yes
[X] No
I vote no: what other ASF projects ship has no bearing on API
commitments made by the APR project.
Regards, Joe
On Fri, Dec 04, 2009 at 07:48:02PM -0600, William Rowe wrote:
Joe Orton wrote:
1) the httpd project cannot force the APR project to commit to API
stability by distributing a snapshot of the APR 1.4 branch. Why on
earth would that be the case? The only time the APR project commits
On Tue, Dec 01, 2009 at 03:01:34AM -0600, William Rowe wrote:
Please review the attached delta of apr 1.3 to 1.4 changes and
chime in if you believe we are ready to tag 1.4. I suspect we are.
Looks good here!
Regards, Joe
On Fri, Oct 16, 2009 at 03:26:31PM +0700, Yuri V. Vishnevskiy wrote:
Dear developers,
For some reason in my program I need two file handlers of stdout stream.
When I close these handlers I obtain an error on the second close: Bad
file descriptor
It seems like reasonable behaviour that the
On Fri, Oct 16, 2009 at 10:54:13AM +0200, Mladen Turk wrote:
On 16/10/09 10:39, Joe Orton wrote:
It seems like reasonable behaviour that the second apr_file_close() call
should fail, though it certainly isn't obvious from reading the docs.
How else do you expect it to behave? You cannot
On Fri, Oct 16, 2009 at 11:17:17AM +0200, Mladen Turk wrote:
each invocation to apr_file_open_stdout creates a new apr_file_t so
each fd-filedes has a value of STDOUT_FILENO.
This is the same as calling:
close(1);
close(1);
Oh, good point. This is rather horrible :(. I'm not sure what can
Since there is no specific reference to the fix for CVE-2009-2699 in the
APR change history or elsewhere, can someone (hello Jeff) confirm that
the patch referenced here:
https://issues.apache.org/bugzilla/show_bug.cgi?id=47645#c13
is a sufficient fix for the vulnerability?
Regards, Joe
Sorry I haven't sent out this review sooner.
Broader issues:
** Having both apr_crypto_init() and apr_crypto_get_driver() seems to be
redundant (unnecessary complexity in API and code). The lowest common
denominator in initialization is NSS, which requires process-global
configuration when
On Fri, Oct 16, 2009 at 09:56:50AM -0500, William Rowe wrote:
Mladen Turk wrote:
What 99% users would need is apr_file_attach_std* set of functions
giving the apr_file_t capable API without destroying the system
std streams.
And we should probably protect the sigleton
On Tue, Oct 13, 2009 at 07:24:55PM -0500, William Rowe wrote:
Joe; what you fail to realize is that your definition of 'nuts' is precisely
Apple's definition of an ABI (parallel, multiple platform architectures).
Eh? The Reality Distortion Field does not extend to the definition of
ABI.
On Wed, Oct 14, 2009 at 08:00:20AM -0400, Jim Jagielski wrote:
On Oct 14, 2009, at 7:00 AM, Joe Orton wrote:
Reducing half of our configure-time tests to build-time compiler macro
tests for one platform is not going to be maintainable. Why is it
useful for Joe Random APR User to be building
On Tue, Oct 13, 2009 at 09:14:54AM -0400, Jeff Trawick wrote:
Including these details in CHANGES is unsustainable. CHANGES would be
completely unusable if these iterative fixes for new features were
included. The few people who need to know this kind of information
will have to get it from
On Fri, Oct 09, 2009 at 10:16:45PM +0200, Ruediger Pluem wrote:
Thanks. General looks fine to me. Just one comment in the code.
Do you commit?
Thanks for catching the TIMEUP thing - fixed that and committed:
http://svn.apache.org/viewvc?rev=824500view=rev
with otherwise only minor wording
On Thu, Oct 08, 2009 at 09:10:12PM +0200, Ruediger Pluem wrote:
Sorry for being impatient here, but Joe any comment on the above?
I would like to fix this.
Sorry for the delay.
The closest parallel to this function in APR is apr_socket_atmark(). So
I suggest this function should mirror that
On Fri, Oct 02, 2009 at 11:51:10AM -0400, Jeff Trawick wrote:
IMO the pre-release commentary for a new feature isn't needed and detracts
from a user's ability to see what is fixed or added with 1.4.
+1
On Sun, Oct 04, 2009 at 12:09:58PM -, rpl...@apache.org wrote:
Author: rpluem
Date: Sun Oct 4 12:09:57 2009
New Revision: 821524
URL: http://svn.apache.org/viewvc?rev=821524view=rev
Log:
* Add apr_socket_is_connected to detect whether the remote side of a socket
is still open. The
On Mon, Jul 20, 2009 at 05:21:32PM -0400, Jim Jagielski wrote:
Release candidate tarballs in usual location
(http://apr.apache.org/dev/dist/)
[not for distribution]. Vote starts as we speak and will run for
48 hours.
+1, thanks for RMing.
Tests and general sanity check pass on Fedora
On Thu, Jul 16, 2009 at 11:42:52AM +1000, Bojan Smojver wrote:
On Thu, 2009-07-16 at 01:39 +, bo...@apache.org wrote:
Use more elaborate checks for epoll_create1, dup3 and accept4.
This requires review folks. There is code in the tests that can
potentially hang the configure process. It
On Thu, Jul 16, 2009 at 07:05:46PM +1000, Bojan Smojver wrote:
On Thu, 2009-07-16 at 09:27 +0100, Joe Orton wrote:
In the past I have argued we should never do runtime platform feature
detection, i.e., if accept4() works at build-time, we can presume it
works at run-time. I think I need
On Tue, Jun 09, 2009 at 09:03:16AM -0500, William Rowe wrote:
As a packager, I can see how you might view 1.3.4- as a minor version rev,
but from the perspective of any user deploying a package linked against
1.3.4 and migrating to 1.3.7, no packages need to be recompiled. That is
binary
1 - 100 of 892 matches
Mail list logo
