Re: [ALL] Updates to commons-parent and commons-skin

Sounds good to me, +1 And thanks for the detailed report on your investigation Alex! Bruno On Monday, 18 November 2019, 3:08:49 am NZDT, Alex Herbert wrote: > On 15 Nov 2019, at 14:40, Alex Herbert wrote: > > […] I have finished testing different solutions to the site rendering

Re: [ALL] Updates to commons-parent and commons-skin

> On 15 Nov 2019, at 14:40, Alex Herbert wrote: > > […] I have finished testing different solutions to the site rendering of RNG to included MathJax and render the code using prettyprint. I tried a full upgrade to commons-skin to base it on Fluido 1.8. This changed a lot of element class

Re: [ALL] Updates to commons-parent and commons-skin

On 15/11/2019 05:02, Bruno P. Kinoshita wrote: Hi Alex, This cannot be included in the site descriptor for the project as the entry for each page is generated by commons-skin. This adds javascript to allow pretty print of code inside tags. I would like to add a javascript tag to allow

Re: [ALL] Updates to commons-parent and commons-skin

Hi Alex, >This cannot be included in the site descriptor for the project as the > entry for each page is generated by commons-skin. This adds >javascript to allow pretty print of code inside >tags. I would like to add a javascript tag to allow inclusion of MathJax. What about loading per page

Re: [ALL] Updates to commons-parent and commons-skin

> On 14 Nov 2019, at 23:14, sebb wrote: > > On Wed, 13 Nov 2019 at 22:59, Alex Herbert > wrote: > >> >>> >> […] >> >> I had a bit more time to investigate why I could not inject MathJax into >> the header of commons-skin using the site descriptor. >>

Re: [ALL] Updates to commons-parent and commons-skin

On Wed, 13 Nov 2019 at 22:59, Alex Herbert wrote: > > > > […] > > I had a bit more time to investigate why I could not inject MathJax into > the header of commons-skin using the site descriptor. > > As of maven site plugin 3.5 any injected XHTML has to be escaped using > CDATA XML notation

Re: [ALL] Updates to commons-parent and commons-skin

> […] I had a bit more time to investigate why I could not inject MathJax into the header of commons-skin using the site descriptor. As of maven site plugin 3.5 any injected XHTML has to be escaped using CDATA XML notation [1]. Commons-skin is based on a version of Apache Maven Fluido

Re: [ALL] Updates to commons-parent and commons-skin

Le mer. 13 nov. 2019 à 17:03, sebb a écrit : > > On Wed, 13 Nov 2019 at 15:12, Gilles Sadowski wrote: > > > Le mer. 13 nov. 2019 à 15:52, sebb a écrit : > > > > > > On Wed, 13 Nov 2019 at 14:38, Gilles Sadowski > > wrote: > > > > > > > Hello. > > > > > > > > Le mer. 13 nov. 2019 à 14:49, sebb

Re: [ALL] Updates to commons-parent and commons-skin

On Wed, 13 Nov 2019 at 15:12, Gilles Sadowski wrote: > Le mer. 13 nov. 2019 à 15:52, sebb a écrit : > > > > On Wed, 13 Nov 2019 at 14:38, Gilles Sadowski > wrote: > > > > > Hello. > > > > > > Le mer. 13 nov. 2019 à 14:49, sebb a écrit : > > > > > > > > +1 for CP > > > > > > > > CP versions

Re: [ALL] Updates to commons-parent and commons-skin

Le mer. 13 nov. 2019 à 15:52, sebb a écrit : > > On Wed, 13 Nov 2019 at 14:38, Gilles Sadowski wrote: > > > Hello. > > > > Le mer. 13 nov. 2019 à 14:49, sebb a écrit : > > > > > > +1 for CP > > > > > > CP versions are entirely optional; > > > > Not "entirely". [We already had this discussion.]

Re: [ALL] Updates to commons-parent and commons-skin

On Wed, 13 Nov 2019 at 14:38, Gilles Sadowski wrote: > Hello. > > Le mer. 13 nov. 2019 à 14:49, sebb a écrit : > > > > +1 for CP > > > > CP versions are entirely optional; > > Not "entirely". [We already had this discussion.] > It happened that a fix for was available in a newer CP but > that

Re: [ALL] Updates to commons-parent and commons-skin

On Wed, 13 Nov 2019 at 14:02, Alex Herbert wrote: > > On 13/11/2019 13:49, sebb wrote: > > +1 for CP > > > > CP versions are entirely optional; a new version is only used if a > > component chooses to use it. > > > > Is this also true of commons-skin? > > If so, then +1 > > cp bundles this site

Re: [ALL] Updates to commons-parent and commons-skin

Hello. Le mer. 13 nov. 2019 à 14:49, sebb a écrit : > > +1 for CP > > CP versions are entirely optional; Not "entirely". [We already had this discussion.] It happened that a fix for was available in a newer CP but that in CP broke some components (e.g. when CP functionality is "enhanced"

Re: [ALL] Updates to commons-parent and commons-skin

On 13/11/2019 13:49, sebb wrote: +1 for CP CP versions are entirely optional; a new version is only used if a component chooses to use it. Is this also true of commons-skin? If so, then +1 cp bundles this site descriptor: src/site.xml which contains:       org.apache.commons    

Re: [ALL] Updates to commons-parent and commons-skin

+1 for CP CP versions are entirely optional; a new version is only used if a component chooses to use it. Is this also true of commons-skin? If so, then +1 If not, then extra care needs to be taken to ensure backwards compatibilty. There should probably be a formal vote on the actual changes in

[ALL] Updates to commons-parent and commons-skin

The recent release of RNG has highlighted some issues with the commons parent configuration for multi-module builds and a desirable change to commons skin. 1. [parent] JaCoCo aggregate reports are included. Aggregate reports show coverage of dependencies. Since most commons components are