Re: Linking mod_ssl with a specific OpenSSL version

2012-09-19 Thread Kaspar Brand
On 18.09.2012 15:05, Joe Orton wrote: one minor nit/bikeshed-colour-review: - APR_ADDTO(MOD_SSL_LDADD, [-export-symbols-regex ssl_module]) + APR_ADDTO(MOD_LDFLAGS, [-export-symbols-regex ssl_module]) this is currently equivalent but keeping _LDADD seems better. No

Re: Linking mod_ssl with a specific OpenSSL version

2012-09-19 Thread Kaspar Brand
On 18.09.2012 17:55, Ben Laurie wrote: though I still have to actually install openssl somewhere, which would be irritating if I had to do any serious development. That said, I could probably figure out how to work around that if I needed to... Something like the following will make your

Re: Linking mod_ssl with a specific OpenSSL version

2012-09-18 Thread Joe Orton
On Sun, Sep 16, 2012 at 08:00:00AM +0200, Kaspar Brand wrote: I have committed an improved version in r1385214 (in particular, more tweaking was required to properly handle support/ab, which can't make use of MOD_CFLAGS etc.). Reviews, further testing and feedback welcome. Looks good to me,

Re: Linking mod_ssl with a specific OpenSSL version

2012-09-18 Thread Ben Laurie
On Sun, Sep 16, 2012 at 7:24 AM, Kaspar Brand httpd-dev.2...@velox.ch wrote: On 16.09.2012 08:00, Kaspar Brand wrote: I have committed an improved version in r1385214 Um, make that read r1385216. I left out the acinclude.m4 changes in the first attempt, unfortunately. OK, I just checked it

Re: Linking mod_ssl with a specific OpenSSL version

2012-09-16 Thread Kaspar Brand
On 23.08.2012 09:22, Kaspar Brand wrote: On 17.08.2012 10:11, Joe Orton wrote: On Thu, Aug 16, 2012 at 08:36:31PM +0200, Kaspar Brand wrote: I wonder if we should add support for module-specific CFLAGS etc., which would always appear before the EXTRA_XXX stuff in the compile and link

Re: Linking mod_ssl with a specific OpenSSL version

2012-09-16 Thread Kaspar Brand
On 16.09.2012 08:00, Kaspar Brand wrote: I have committed an improved version in r1385214 Um, make that read r1385216. I left out the acinclude.m4 changes in the first attempt, unfortunately. Kaspar

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-23 Thread Kaspar Brand
On 17.08.2012 10:11, Joe Orton wrote: On Thu, Aug 16, 2012 at 08:36:31PM +0200, Kaspar Brand wrote: I wonder if we should add support for module-specific CFLAGS etc., which would always appear before the EXTRA_XXX stuff in the compile and link commands, i.e. in rules.mk we would have:

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-20 Thread Ben Laurie
On Thu, Aug 16, 2012 at 7:36 PM, Kaspar Brand httpd-dev.2...@velox.ch wrote: On 12.8.12 20:01, Ben Laurie wrote: On Sun, Aug 12, 2012 at 5:23 PM, Kaspar Brand httpd-dev.2...@velox.ch wrote: a workaround is to call configure with suitable {CPP,LD}FLAGS, i.e.

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-17 Thread Joe Orton
On Thu, Aug 16, 2012 at 08:36:31PM +0200, Kaspar Brand wrote: I wonder if we should add support for module-specific CFLAGS etc., which would always appear before the EXTRA_XXX stuff in the compile and link commands, i.e. in rules.mk we would have: ALL_CFLAGS = $(MOD_CFLAGS) $(EXTRA_CFLAGS)

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-16 Thread Kaspar Brand
On 12.8.12 20:01, Ben Laurie wrote: On Sun, Aug 12, 2012 at 5:23 PM, Kaspar Brand httpd-dev.2...@velox.ch wrote: a workaround is to call configure with suitable {CPP,LD}FLAGS, i.e. CPPFLAGS=-I${openssl_build_dir}/include \ LDFLAGS=-L${openssl_build_dir} \ ./configure ... (when using

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-12 Thread Kaspar Brand
On 10.08.2012 01:55, William A. Rowe Jr. wrote: An openssl 'make localinstall' could trivially create the lib, include trees consisting entirely of symlinks to the origin files in the same build tree, and create an appropriate openssl.pc file describing the link steps required to

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-12 Thread Ben Laurie
On Sun, Aug 12, 2012 at 5:23 PM, Kaspar Brand httpd-dev.2...@velox.ch wrote: On 10.08.2012 01:55, William A. Rowe Jr. wrote: An openssl 'make localinstall' could trivially create the lib, include trees consisting entirely of symlinks to the origin files in the same build tree, and create an

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-09 Thread William A. Rowe Jr.
On 8/8/2012 9:03 AM, Joe Orton wrote: On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so that they don't accidentally use a directory which might only

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-09 Thread William A. Rowe Jr.
On 8/8/2012 8:56 PM, Ben Laurie wrote: On Wed, Aug 8, 2012 at 5:03 PM, Joe Orton jor...@redhat.com wrote: On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-09 Thread William A. Rowe Jr.
On 8/8/2012 4:45 AM, Ben Laurie wrote: On Wed, Aug 8, 2012 at 2:47 AM, Guenter Knauf fua...@apache.org wrote: Am 08.08.2012 07:39, schrieb Kaspar Brand: On 06.08.2012 22:08, William A. Rowe Jr. wrote: On 8/5/2012 10:10 PM, Kaspar Brand wrote: On 05.08.2012 14:38, Guenter Knauf wrote: Am

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-08 Thread Kaspar Brand
On 06.08.2012 23:36, Rainer Jung wrote: On 05.08.2012 10:10, Kaspar Brand wrote: It's a useful enhancement if mod_ssl can be linked with a specific OpenSSL version in a non-default location, but the current approach has at least one problem, AFAICT: it will only work if the directory pointed

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-08 Thread Guenter Knauf
Am 08.08.2012 07:39, schrieb Kaspar Brand: On 06.08.2012 22:08, William A. Rowe Jr. wrote: On 8/5/2012 10:10 PM, Kaspar Brand wrote: On 05.08.2012 14:38, Guenter Knauf wrote: Am 05.08.2012 10:10, schrieb Kaspar Brand: 1) use --with-ssl-builddir for linking with the static OpenSSL libraries

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-08 Thread Ben Laurie
On Wed, Aug 8, 2012 at 2:47 AM, Guenter Knauf fua...@apache.org wrote: Am 08.08.2012 07:39, schrieb Kaspar Brand: On 06.08.2012 22:08, William A. Rowe Jr. wrote: On 8/5/2012 10:10 PM, Kaspar Brand wrote: On 05.08.2012 14:38, Guenter Knauf wrote: Am 05.08.2012 10:10, schrieb Kaspar Brand:

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-08 Thread Joe Orton
On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so that they don't accidentally use a directory which might only temporarily exist - that's also the primary

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-08 Thread Noel Butler
On Wed, 2012-08-08 at 17:03 +0100, Joe Orton wrote: On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so that they don't accidentally use a directory which

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-08 Thread Ben Laurie
On Wed, Aug 8, 2012 at 5:03 PM, Joe Orton jor...@redhat.com wrote: On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so that they don't accidentally use a

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-07 Thread Kaspar Brand
On 06.08.2012 22:08, William A. Rowe Jr. wrote: On 8/5/2012 10:10 PM, Kaspar Brand wrote: On 05.08.2012 14:38, Guenter Knauf wrote: Am 05.08.2012 10:10, schrieb Kaspar Brand: 1) use --with-ssl-builddir for linking with the static OpenSSL libraries in that directory (and ignore --with-ssl in

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-06 Thread William A. Rowe Jr.
On 8/5/2012 10:10 PM, Kaspar Brand wrote: On 05.08.2012 14:38, Guenter Knauf wrote: Am 05.08.2012 10:10, schrieb Kaspar Brand: 1) use --with-ssl-builddir for linking with the static OpenSSL libraries in that directory (and ignore --with-ssl in this case) what about splitting into two

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-06 Thread Rainer Jung
On 05.08.2012 10:10, Kaspar Brand wrote: On 08.07.2012 10:30, Kaspar Brand wrote: On 06.07.2012 14:41, b...@apache.org wrote: Author: ben Date: Fri Jul 6 12:41:10 2012 New Revision: 1358167 URL: http://svn.apache.org/viewvc?rev=1358167view=rev Log: Work correctly with a development version

Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-05 Thread Kaspar Brand
On 08.07.2012 10:30, Kaspar Brand wrote: On 06.07.2012 14:41, b...@apache.org wrote: Author: ben Date: Fri Jul 6 12:41:10 2012 New Revision: 1358167 URL: http://svn.apache.org/viewvc?rev=1358167view=rev Log: Work correctly with a development version of OpenSSL. I suspect something

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-05 Thread Kaspar Brand
On 05.08.2012 10:10, Kaspar Brand wrote: test feedback would be much appreciated (remember to run buildconf after applying the patch to acinclude.m4, and before calling configure). The patch attached to the previous message was missing an important line, unfortunately (sorry to anybody who

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-05 Thread Guenter Knauf
Hi Kaspar, Am 05.08.2012 10:10, schrieb Kaspar Brand: My suggestion would be to handle OpenSSL paths in configure arguments like this, instead: 1) use --with-ssl-builddir for linking with the static OpenSSL libraries in that directory (and ignore --with-ssl in this case) what about splitting

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-05 Thread Kaspar Brand
On 05.08.2012 14:38, Guenter Knauf wrote: Am 05.08.2012 10:10, schrieb Kaspar Brand: 1) use --with-ssl-builddir for linking with the static OpenSSL libraries in that directory (and ignore --with-ssl in this case) what about splitting into two arguments: --with-ssl-include= --with-ssl-lib=