Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-30 Thread Tibor Digana
] < ml-node+s40175n587945...@n5.nabble.com> wrote: > Hello Tibor, > > Tibor Digana <[hidden email] > <http:///user/SendEmail.jtp?type=node=5879457=0>> schrieb am Mo., > 29. Aug. 2016 um > 12:56 Uhr: > > > Hi Benedikt, > > > > I found

Re: JUnit categories in surefire/failsafe

2016-08-31 Thread Tibor Digana
since they will be in 3.0: ${surefire.groups} ${failsafe.groups} Do you still need "_ALL_, _NONE_, _UNCATEGORIZED_"? On Wed, Aug 31, 2016 at 10:23 AM, Tibor Digana <tibordig...@apache.org> wrote: > Hi Christopher, > > Some offtopic. I will answer your email but

Re: JUnit categories in surefire/failsafe

2016-08-31 Thread Tibor Digana
Hi Christopher, Some offtopic. I will answer your email but first I have a question for you and Accumulo project. I visited Accumulo cca one week ago. Why the build [1] hangs on IT test executed by maven-failsafe-plugin:2.19.1? I asked INFRA team to display Thread Dump button. Do you see this

Re: Code Style for IntelliJ 2016.2

2016-09-09 Thread Tibor Digana
Sorry I did not get notice this email. You need to configure your IDE for you pending PR in GitHub, right? :) I use IntelliJ IDEA 14.1.7. The code style for IDEA: https://maven.apache.org/developers/maven-idea-codestyle.xml https://maven.apache.org/developers/conventions/code.html On Wed, Sep 7,

Re: [SUREFIRE] Branch for JUnit 5 integration?

2016-09-11 Thread Tibor Digana
ok, go on with the branch but then please create CI job in https://builds.apache.org/job/maven-surefire/. We will nicely see how the branch is still in green. I want to be brief. I understand that this work takes private time, I was idle for cca 5 months in Surefire and recovered recently. Many

Re: colored console

2016-09-12 Thread Tibor Digana
rve.bout...@free.fr> a écrit : > > > > Le vendredi 9 septembre 2016 10:49:54 Tibor Digana a écrit : > > > @Herve What do you think about Romain's concept: --color-info=blue > > > --color-error=red --color-warning=yellow-bold > > > @Romain In MVN 3.4 you can override

Re: colored console

2016-09-08 Thread Tibor Digana
.xml: current > or > > > no color for test result line or single color for level and result or > > only > > > start of the line? > > > > > > Le 8 sept. 2016 23:36, "Tibor Digana" <tibordig...@apache.org> a > écrit : > > > >

Re: colored console

2016-09-08 Thread Tibor Digana
-rmannibucau.rhcloud.com> | Old Wordpress Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber > <http://www.tomitribe.com> | JavaEE Factory > <https://javaeefactory-r

colored console

2016-09-08 Thread Tibor Digana
Currently the colored console looks like in the picture. Please let me know what other highlighting you prefer. I do not prefer using bold text in color, and use colors only in the begin of line: "Tests run: 12, Failure: 0, Errors: 0, Skipped: 0" WDYT? I will not change the text. [image:

Re: colored console

2016-09-08 Thread Tibor Digana
e? > > Le 8 sept. 2016 23:36, "Tibor Digana" <tibordig...@apache.org> a écrit : > > > sending the picture in attachment.. > > > > On Thu, Sep 8, 2016 at 11:32 PM, Romain Manni-Bucau [via Maven] < > > ml-node+s40175n5880220...@n5.nabble.com> wrote

Re: [SUREFIRE] How does Junit4VersionsIT work?

2016-09-08 Thread Tibor Digana
This is obviously a bug and junit.version should be used. If you type "unpack().debugLogging()." in the IT you will see that the classpath contains junit-4.4 instead of the providing one. There are several such cases but not all ITs alter the version. On Wed, Sep 7, 2016 at 9:10 PM, Benedikt

Re: colored console

2016-09-08 Thread Tibor Digana
> > > > > > > I agree fwiw. > > > > Gary > > > > > > > What about having the coloration configurable in settings.xml: current > or > > > no color for test result line or single color for level and result or > > only

Re: colored console

2016-09-09 Thread Tibor Digana
ld require to have the same principle. What if some users want to cover only some part of the text with colors and combine with multiple colors? On Fri, Sep 9, 2016 at 10:06 AM, Romain Manni-Bucau <rmannibu...@gmail.com> wrote: > 2016-09-09 7:45 GMT+02:00 Tibor Digana <tibor

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-04 Thread Tibor Digana
On Tue, Oct 4, 2016 at 7:47 PM, Benedikt Ritter <brit...@apache.org> wrote: > Hello Tibor, > > Tibor Digana <tibor.dig...@googlemail.com> schrieb am Di., 4. Okt. 2016 um > 02:29 Uhr: > > > Can you simplify and speed up writing integration test

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-04 Thread Tibor Digana
ork? Cheers Tibor On Tue, Oct 4, 2016 at 7:48 PM, Benedikt Ritter [via Maven] < ml-node+s40175n5882181...@n5.nabble.com> wrote: > Hello Tibor, > > Tibor Digana <[hidden email] > <http:///user/SendEmail.jtp?type=node=5882181=0>> schrieb am Di., > 4. Okt. 2016 um >

Further questions to "Add modulepath support" SUREFIRE-1262

2016-09-18 Thread Tibor Digana
I have executed examples from http://openjdk.java.net/projects/jigsaw/quick-start Now I have handson exps but still something is not clear. Did Jigsaw broke backwards compatibility? Running Main-Class from Manifest would not work like this? java -jar surefire.jar The problem is that it makes

Re: colored console

2016-09-18 Thread Tibor Digana
done, which I really doubt, it should > > be at Maven level, not at plugin level. > > Robert > > > > > Regards, > > > > Hervé > > > > > > [1] > > https://maven.apache.org/shared-archives/maven-shared- > utils-LATEST/apidocs/org/apache

Re: Help to submit fix in maven-changes-plugin

2016-08-28 Thread Tibor Digana
Mikael, your patch should appear in https://github.com/apache/maven-plugins/pulls Many people do this. Please read tutorial on GitHub to push a new pull request. On 8/28/16, Mikael Petterson [via Maven] wrote: > > > Hi, > > We are trying to use 2.12 of

Re: POM Model version 4.1.0 in 3.4.0-SNAPSHOTs

2016-08-28 Thread Tibor Digana
Hi Robert, as I am reading your comments, I see the situation is not be so tragic :) What about to let m-deploy-p and m-release-p to decide on modelVersion of consumer project as the minimum version. If for instance a new scope value is available in of your project POM, then the plugin would

Re: POM Model version 4.1.0 in 3.4.0-SNAPSHOTs

2016-08-28 Thread Tibor Digana
preferably chosen by our plugins. On 8/28/16, Tibor Digana <tibordig...@apache.org> wrote: > Hi Robert, as I am reading your comments, I see the situation is not > be so tragic :) > What about to let m-deploy-p and m-release-p to decide on modelVersion > of consumer project as t

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Tibor Digana
I won't ha ve much time for JUnit 5 provider because I am preparing Version 2.19.2 to release and next release with blocker and critical fix, then 3.0-RC1. Feel free to open pull request in GitHub for JUnit 5 provider. On 8/27/16, Kristian Rosenvold wrote: > Hi,

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Tibor Digana
hm, you know, I don't like new provider because it's a lot of work to support all the features we had in surefire-junit47. This may always go with bugs and finally more work for you, integration tests, ... On 8/27/16, Benedikt Ritter <brit...@apache.org> wrote: > Tibor Digana &

Re: POM Model version 4.1.0 in 3.4.0-SNAPSHOTs

2016-08-27 Thread Tibor Digana
I supposed to align Maven 4.x with model version 4.0, and then Maven 5.x with model version 5.0. I supposed to directly release Maven 4.0.0 instead of 3.4.0. Why we have to control model version and support it if the XSD schemaLocation is already defined:

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-27 Thread Tibor Digana
all features again. On 8/27/16, Tibor Digana <tibor.dig...@googlemail.com> wrote: > hm, you know, I don't like new provider because it's a lot of work to > support all the features we had in surefire-junit47. This may always > go with bugs and finally more work for you, in

Re: POM Model version 4.1.0 in 3.4.0-SNAPSHOTs

2016-08-26 Thread Tibor Digana
One or two years ago I watched mvn dev hangouts videos with Jason and Karl and others and there we mentioned the need for BOM. I understood that BOM is similar to dependencyManagement different from typical POM. In the video they wanted to solve some problem with dependencies resolutions. Do we

Re: Help to submit fix in maven-changes-plugin

2016-08-26 Thread Tibor Digana
>>How can I submit a patch Just push you commit and in the webpage https://github.com//maven-plugins you will see a hint to open pull request. Name it "[MCHANGES-373] ". Done. >>and integrate it The ASF PMC and committers will integrate it. >> and test it You should run : mvn -Prun-its verify

Re: obtain java spec version from Forked VM

2016-08-24 Thread Tibor Digana
e > maven-compiler-plugin will do too to decide if it should use classpath or > modulepath (or both). > > Robert > > > On Tue, 23 Aug 2016 12:14:46 +0200, Tibor Digana < > tibor.dig...@googlemail.com> wrote: > > I want to obtain java.specification.version from f

Re: [SUREFIRE] Surefire provider for JUnit 5?

2016-08-29 Thread Tibor Digana
Hi Benedikt, I found out that JUNit 5 was release with ALPHA version in Maven Central. I guess there is no need to rush in Surefire yet. The JUnit team should contribute in JUnit code line in the artifact project org.junit.surefire-junit5 and test that provider. AFter the it is stable with

obtain java spec version from Forked VM

2016-08-23 Thread Tibor Digana
I want to obtain java.specification.version from forked JVM started from Toolchain. I need to know if the JDK is Jigsaw 9 or lower. Robert gave me advise to run "java -version" and parse the string but the problem is that it is VM version and not the specification version of Java language, and

obtain java spec version from Forked VM

2016-08-23 Thread Tibor Digana
I want to obtain java.specification.version from forked JVM started from Toolchain. I need to know if the JDK is Jigsaw 9 or lower. Robert gave me advise to run "java -version" and parse the string but the problem is that it is VM version and not the specification version of Java language, and

Re: [VOTE] Release Apache Maven WAR Plugin version 3.0.0 (Take 2)

2016-08-24 Thread Tibor Digana
+1: here is my voice On 8/24/16, Karl Heinz Marbaise wrote: > Hi, > > We solved 33 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318121=12331760 > > There are still a couple of issues left in JIRA: >

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2016-08-29 Thread Tibor Digana
I am sure the code had a reason but currently sorry I have not answered since I have being preparing fixes for bugs and feature which are really big. I keep in mind that I should come back soon. On 8/29/16, Fuud wrote: > Github user Fuud commented on the issue: > >

Re: [SUREFIRE] JUnit 5 support - how to move things forward?

2016-10-03 Thread Tibor Digana
+1 to adopt JUnit 5 provider to Maven Surefire git branch. You would have to extend AbstractSurefireMojo.java with JUnit 5 provider in classpath builder. Do we have to keep using other license? Can we ask the JUnit team to continuously migrate stable changes to Surefire? On Mon, Oct 3, 2016 at

Re: [SUREFIRE] JUnit 5 support - how to move things forward?

2016-10-03 Thread Tibor Digana
Can you simplify and speed up writing integration tests in the way that you would parameterize the existing JUnit 4 testing by adding Maven profiles (one default profile and junit5 profile) having another dependencies and @RunWith(Parameterized.class)? This would be cool because we can have

Re: Would Commons Lang on Java 8 be a problem for the Apache Maven project?

2016-09-25 Thread Tibor Digana
What a new API is needed from commons-lang:3.7 in Maven? Do we need to have something from the latest commons-lang and latest JDK ? Benedikt, can you provide us with API changes on the web so that we would better understand. I understand that commons might be needed in the integration test classes

Re: ComparableVersionTest

2016-09-25 Thread Tibor Digana
If it just works, ok. But I am thinking of different topic related to Versions. Since Versions have been discussed in Jira even before I am thinking if it is more suitable to let the users write some script as versions-comparator.bsh in Bean Shell in folder ".mvn". On Sat, Sep 24, 2016 at 7:13

Re: ComparableVersionTest

2016-09-25 Thread Tibor Digana
t...? > > Kind regards > Karl Heinz > > On 25/09/16 11:17, Tibor Digana wrote: > >> If it just works, ok. >> But I am thinking of different topic related to Versions. Since Versions >> have been discussed in Jira even before I am thinking if it is more >&g

Re: Would Commons Lang on Java 8 be a problem for the Apache Maven project?

2016-09-26 Thread Tibor Digana
We do not have to rush however I can optimistically imaging the some colleagues like Kristian would enjoy their spare time on reworking Maven sources to Java 8 :-) On Mon, Sep 26, 2016 at 12:04 PM, stephenconnolly [via Maven] < ml-node+s40175n5881611...@n5.nabble.com> wrote: > Well another

Re: ComparableVersionTest

2016-09-25 Thread Tibor Digana
> > I think we could make a kind of an interface to delegate the real > comparison to an user implemented thing (via extensions)We could > make the api and use the current implementation as a default ? (For > version ranges I'm not sure how that would really work)... > > Ki

Re: annotation to prevent parallel surefire execution

2016-10-01 Thread Tibor Digana
javax.annotation.concurrent.NotThreadSafe cannot be used because it does not have RUNTIME RetentionPolicy. On Wed, Sep 28, 2016 at 1:27 AM, James Taylor [via Maven] < ml-node+s40175n5881707...@n5.nabble.com> wrote: > Hello, > I noticed in the documentation here[1] that you can use > the

Re: Maven 3.4.0 Release

2016-10-09 Thread Tibor Digana
I would add MNG-5889 to 3.4 after proper testing. On Sun, Oct 9, 2016 at 8:41 PM, Robert Scholte wrote: > Open issues bound to 3.4.0 > > * Introduction of model version 4.1.0. > https://issues.apache.org/jira/browse/MNG-6082 > assignee: Christian Schulte (reporter:

Re: [RESULT] [VOTE] Release Apache Maven Compiler Plugin version 3.6.0

2016-10-29 Thread Tibor Digana
+1 On Sat, Oct 29, 2016 at 10:36 PM, rfscholte [via Maven] < ml-node+s40175n5884430...@n5.nabble.com> wrote: > Hi, > > The vote has passed with the following result: > > +1 : Anders Hammar, Olivier Lamy, Karl Heinz Marbaise, Robert Scholte > > PMC quorum: reached > > I will promote the artifacts

Re: [VOTE] Release Apache Maven Changes Plugin version 2.12.1

2016-10-30 Thread Tibor Digana
+1 On Sat, Oct 29, 2016 at 8:46 PM, rfscholte [via Maven] < ml-node+s40175n5884422...@n5.nabble.com> wrote: > Hi, > > We solved 4 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12317222=12335850=Text > > There are still a couple of issues left in JIRA: >

Fwd: [jira] [Commented] (SUREFIRE-1298) surefire-junit4 contains commons-io 2.2 pom.xml

2016-11-12 Thread Tibor Digana
Hi , How can I remove pom.xml from shaded jar in elegant way? See https://issues.apache.org/jira/browse/SUREFIRE-1298 Cheers Tibor -- Forwarded message -- From: Thomas Mortagne (JIRA) Date: Fri, Nov 4, 2016 at 9:26 AM Subject: [jira] [Commented] (SUREFIRE-1298)

How can I remove dependencies pom.xml from shaded jar in elegant way?

2016-11-13 Thread Tibor Digana
Hi , How can I remove dependencies pom.xml from shaded jar in elegant way? See https://issues.apache.org/jira/browse/SUREFIRE-1298 Cheers Tibor

Re: [VOTE] Release Apache Maven Doxia Sitetools version 1.7.3

2016-10-31 Thread Tibor Digana
+1 On Sun, Oct 30, 2016 at 5:30 PM, Hervé BOUTEMY [via Maven] < ml-node+s40175n5884533...@n5.nabble.com> wrote: > Hi, > > We solved 2 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12317320=12338585=Text > > There are still a couple of issues left in JIRA: >

Re: [SUREFIRE] Hangout with Marc Philipp

2016-10-11 Thread Tibor Digana
Hi Benedikt, I do not have any problem with SNAPSHOT version in the branch junit5. Even this can be very easily accomplished. Let's put property, e.g. version.junit5, into [1] and reference to this POM via parent declaration in your root POM of particular IT having JUnit5 tests. [1]

Re: [SUREFIRE] Hangout with Marc Philipp

2016-10-11 Thread Tibor Digana
Sorry for my typos, again: *Maybe we should setup second trigger in Jenkins build for junir5 branch and run ASF build if any change is pushed to ASF or JUnit Git repository.* On Tue, Oct 11, 2016 at 7:48 PM, Tibor Digana <tibordig...@apache.org> wrote: > We can follow already existing

Re: [SUREFIRE] Hangout with Marc Philipp

2016-10-11 Thread Tibor Digana
project. Maybe we should setup second trigger in Jenkins build and run ASF build if any change in pushed to ASF of JUnit Git repository. On Tue, Oct 11, 2016 at 1:25 PM, Tibor Digana <tibordig...@apache.org> wrote: > Hi Benedikt, > > I do not have any problem with SNAPSHOT versio

Re: [SUREFIRE] Jenkins job for junit5 branch

2016-10-10 Thread Tibor Digana
Excellent! On Sun, Oct 9, 2016 at 2:16 PM, Benedikt Ritter [via Maven] < ml-node+s40175n5882475...@n5.nabble.com> wrote: > Hello, > > I've created a build job for the junit5 branch [1]. It's a copy of the > maven-surefire job with the only difference that it does not publish build > artifacts to

Re: [SUREFIRE] Parameterized Tests for Junit 4 and Junit 5? (Was: [SUREFIRE] JUnit 5 support - how to move things forward?)

2016-10-11 Thread Tibor Digana
wrote: > Hello again, > > Tibor Digana <[hidden email] > <http:///user/SendEmail.jtp?type=node=5882750=0>> schrieb am Mi., > 5. Okt. 2016 um > 00:05 Uhr: > > > >>Or do we want to even share the test projects and work with profiles > in > >

Re: [GitHub] maven-surefire issue #122: Specify surefire temp directory for run in multip...

2016-10-14 Thread Tibor Digana
> I know this is param but between my builds not save workspace. Yes this is we cannot store because Maven is not integrated with VCS. I want Surefire and Maven being intergared with VCS via some agent but that's a lot to do. >>Plus if usage -Dsurefire.includesFile arguments how it will work

Re: [SUREFIRE] Bring more order in the integration tests project?

2016-12-11 Thread Tibor Digana
I agree since it helps improving the code clarity but currently I cannot do it because I am preparing a new release and several commits are pending. On Sat, Dec 10, 2016 at 8:08 PM, Benedikt Ritter [via Maven] < ml-node+s40175n5888093...@n5.nabble.com> wrote: > Hello, > > at the moment the

Parent Version maybe not needed in child POM

2016-12-12 Thread Tibor Digana
Is it really necessary to specify version of parent artifact in ? Suppose we have multimodule reactor project and maven-release-plugin would inline the version in the section and remove it again in new development iteration. The plugin fails then if the parent version is not determined. WDYT?

Re: Parent Version maybe not needed in child POM

2016-12-12 Thread Tibor Digana
>>Something like an J2EE >>You can take a long walk >>until it finishes downloading sources, javadoc, dependencies >>I really only open the module(s) I need This is not Maven problem then. You architect must give you a freedom to move some modules apart and keep some in it which makes the

Re: Parent Version maybe not needed in child POM

2016-12-12 Thread Tibor Digana
that in the same manner but continuous Maven core should ask SCM for changes after last build time and build always only changed modules which would be perfect, would not it be? On Mon, Dec 12, 2016 at 8:22 PM, Christian Schulte <c...@schulte.it> wrote: > Am 12/12/16 um 10:16 schrieb Tib

Re: Taking Security Seriously

2016-12-06 Thread Tibor Digana
What real problem is behind your question? Are you running any tool which has a problem with signatures in Nexus or the development process in your company has a problem? The MD5 is not security nothing but verification of deployed artifact is identical binary you have downloaded from Nexus, and

Re: [DISCUSS] Resetting Master branch to 737de43e392fc15a0ce366db98d70aa18b3f6c03

2017-01-06 Thread Tibor Digana
Hi Stephen. In the Roadmap you have mentioned that all the discussion of particular Jira issue is discussed in ML. I cannot imaging how the code would be discussed here. Why not in pull request at github? In the repository with ASF rights INFRA can create labels like you have proposed "?" or "+1"

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-05 Thread Tibor Digana
will send you link in GitHub in a day. I see we will make good job together! On Mon, Jan 2, 2017 at 3:42 PM, Tibor Digana <tibordig...@apache.org> wrote: > I also have such feeling that Maven became a playground. > Last week I saw it in reality and after Robert told me we mad

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-06 Thread Tibor Digana
I have created a pull request https://github.com/apache/maven-surefire/pull/139 The build passed successfully. Christian, Benedikt please have a look and I will amend the HEAD revision in origin/master. Thx. On Fri, Jan 6, 2017 at 4:43 PM, Tibor Digana <tibordig...@apache.org> wrote: >

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
= (PrintWriter) out; return pw.checkError(); } else if (psOut != null) { return psOut.checkError(); } return trouble; } On Sun, Jan 8, 2017 at 12:47 AM, Christian Schulte <schu...@apache.org> wrote: > Am 01/07/17 um 04:00 schrieb Tibor Digana: > > I have created

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
ssible if you pull. > > This style fits with the Apache "just commit it" mentality, but relies on > individual developer discipline to work well. The task of "gate keeper" is > effectively distributed to each person wanting to push; they gate keep > themselves, or n

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
I did amend the commit to prevent from having two commits per one issue. The reason behind is that we agreed that I will open PR at GitHub and let you to agree or disagree. Nobody replied with yes or no after cca 9 hours which looked like nobody had objections. Usually I am doing fresh clone from

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
<c...@schulte.it> wrote: > Am 01/08/17 um 01:27 schrieb Tibor Digana: > > You committed right after me and you have reverted two Jira issue. > > This would not have been possible. What reverts are you talking about. I > am locking at > <https://git-wip-us.apache.org/

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
As an example flush() is missing in RunEntryStatisticsMap.java L130. Maybe I would find more but this is not the only case. There are 24 files changed. On Sun, Jan 8, 2017 at 3:19 AM, Tibor Digana-2 [via Maven] < ml-node+s40175n589188...@n5.nabble.com> wrote: > Currently I have tw

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
:28 AM, Tibor Digana <tibordig...@apache.org> wrote: > As an example flush() is missing in RunEntryStatisticsMap.java L130. > Maybe I would find more but this is not the only case. There are 24 files > changed. > > On Sun, Jan 8, 2017 at 3:19 AM, Tibor Digana-2 [via Maven] <

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
ian Schulte <c...@schulte.it> wrote: > Am 01/08/17 um 03:28 schrieb Tibor Digana: > > As an example flush() is missing in RunEntryStatisticsMap.java L130. > > Maybe I would find more but this is not the only case. There are 24 files > > changed. > > It's not missing t

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
8, 2017 at 3:49 AM, Christian Schulte [via Maven] < ml-node+s40175n5891905...@n5.nabble.com> wrote: > Am 01/08/17 um 03:28 schrieb Tibor Digana: > > As an example flush() is missing in RunEntryStatisticsMap.java L130. > > Maybe I would find more but this is not the only case.

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-07 Thread Tibor Digana
Java 7 feature "try-with-resources" compiles Java 7 code to using finally in bytecode however it does not exist in source code. On Sun, Jan 8, 2017 at 3:49 AM, Christian Schulte [via Maven] < ml-node+s40175n5891905...@n5.nabble.com> wrote: > Am 01/08/17 um 03:28 schrieb Tibor

Re: [VOTE] Reset Maven Core, Integration Tests and Resolver repository master branches

2017-01-07 Thread Tibor Digana
+1 On Wed, Jan 4, 2017 at 1:16 PM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We have collectively managed to mess up our ability to follow the original > release plan for 3.4.0 which was originally supposed to consist of an > effective no-op change of Eclipse's Aether

Re: [DISCUSS] Resetting Master branch to 737de43e392fc15a0ce366db98d70aa18b3f6c03

2016-12-31 Thread Tibor Digana
Stephen, Maybe we should add an icon (green/red) of build status on the page [1]. The same should appear on every pull request in GitHub Maven origin/master and branches. WDYT? [1] https://github.com/apache/maven-integration-testing T On Sat, Dec 31, 2016 at 1:07 PM, Stephen Connolly <

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-02 Thread Tibor Digana
I can fix it. With these usual suspects in > > the code, nothing of this makes any sense. That's like searching for an > > issue although you already know there is something wrong at various > places. > > > > What is not open about those changes? It could not be mo

Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-02 Thread Tibor Digana
I also have such feeling that Maven became a playground. Last week I saw it in reality and after Robert told me we made playground in our sources I could not believe this could happen in such professional project like Maven. I would appreciate it if the change [1]

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-06 Thread Tibor Digana
/Surefire1295AttributeJvmCrashesToTestsIT_crashInReusableFork surefire-integration-tests/target/Surefire1295AttributeJvmCrashesToTestsIT_crashInSingleUseFork Cheers Tibor On Fri, Jan 6, 2017 at 3:11 AM, Tibor Digana <tibordig...@apache.org> wrote: > Hello guys, > > Sorry for late reply.

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-10 Thread Tibor Digana
it suddenly freeze as well. So yesterday everything what could be broken was broken totally. I need a day to get everything to normal and then I will participate in ASF very soon. On Sun, Jan 8, 2017 at 9:31 AM, Christian Schulte <schu...@apache.org> wrote: > Am 01/08/17 um 06:48 schr

Re: maven-surefire git commit: [SUREFIRE-1315] Fix stylistic errors in DefaultReporterFactory

2016-12-26 Thread Tibor Digana
No objections to error( "Errors: " ), failure( "Failures: " What about having "Flakes: "? On Mon, Dec 26, 2016 at 2:14 PM, Michael Osipov-2 [via Maven] < ml-node+s40175n5890019...@n5.nabble.com> wrote: > Am 2016-12-26 um 14:02 schrieb Hervé BOUTEMY: > > I'm ok with "flacky tests" vs

Re: Lets talk about our changes openly. maven-surefire git commit: [SUREFIRE-1324] Surefire incorrectly suppresses exceptions when closing resources.

2017-01-15 Thread Tibor Digana
with your logs - I see the reason why it failed. And then we will start normal code review and we will enjoy it together. WDYT? Can we do it like this? [1] 66bc4c0839ba11af7a8915930f76abf3cd58ee53 On Tue, Jan 10, 2017 at 10:50 AM, Tibor Digana <tibordig...@apache.org> wrote: > Sorry I coul

Re: New Branch SUREFIRE-1342

2017-03-18 Thread Tibor Digana
t; It doesn't seem to be related to the branch though. They work fine in > 2.19.1 and also fail with current master. > > > > Le 18/03/2017 à 21:57, Tibor Digana a écrit : > >> Please send the dump files from >> surefire-integration-tests/target/Surefire141PluggableProvid >>

Re: [SUMMARY] [DISCUSS] Retrospective on Maven 3.5.0-alpha-1

2017-03-19 Thread Tibor Digana
What marketing can we do in order to hire new developers? In my experience employees are still asking the same question "How much do they pay" ;-) I am still trying to explain that you are improving Maven used in your daily work. I do not want this great project to see dying. It's being widely

Re: New Branch SUREFIRE-1342

2017-03-18 Thread Tibor Digana
to the Maven command. > > I will test with a JDK 6 right now. > > > Le 17/03/2017 à 06:12, Tibor Digana a écrit : > >> Yes, there are a lot of tests 1200 altogether. For instance I have 4 Cores >> of CPU and the build takes 45 minutes. In your case 1 Core of Virtual

Re: [DISCUSS] Planning process for 3.5.1

2017-03-21 Thread Tibor Digana
>>Question is: How to decide which commits/JIRA issues will be merged to master for the next release? Usually I respect the Jira priority, e.g. blocker or critical or I change the priority, and then those issues are preferable which necessarily must change the architecture first due to other Jira

Re: New Branch SUREFIRE-1342

2017-03-15 Thread Tibor Digana
nsively (on Ubuntu as well). Thanks > for the work! > > Guillaume > > > > Le 13/03/2017 à 10:46, Tibor Digana a écrit : > >> Hi All, >> >> The new branch SUREFIRE-1342 solves an issue when entire testset completed >> however the surefire's forked JV

Re: New Branch SUREFIRE-1342

2017-03-16 Thread Tibor Digana
and 8 over > the next few days. > > Guillaume > > > > Le 15/03/2017 à 21:40, Tibor Digana a écrit : > >> Hi Guillaume Boué, >> >> Have you found a spare time to test the branch? >> >> Cheers >> Tibor >> >> On Mon, Mar 13, 2017 at 1

[VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-04 Thread Tibor Digana
Hi, We solved 65 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12334636 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC Staging repo:

Re: [VOTE] Release Apache Maven 3.5.0

2017-04-04 Thread Tibor Digana
+1 (binding) On Tue, Apr 4, 2017 at 12:14 AM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Hi, > > We solved 86 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12316922=12336084=Text > > In there are 324 issues left in JIRA for Maven core: >

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Tibor Digana
h the main > Maven process and the surefire's ForkedBooter. > > I am running on Fedora 25 + JDK 8u121. Tried with Maven 3.2.5 and the > staged 3.5.0. > > Can someone confirm the above, or is just some quirk in my local env? > > Thanks, > Petr > > On Tue, Apr 4,

surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
Discussion to Release Vote of Surefire 2.20. Project to reproduce an issue https://github.com/psiroky/surefire-2_20-slowdown-reproducer Forked JVM is waiting 30 seconds to die. I guess the JVM does not exit due to non-daemon threads. Question is why we can see RMI Threads however no test is using

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
] [INFO] Total time: 6.595 s [INFO] Finished at: 2017-04-05T11:48:06+02:00 [INFO] Final Memory: 16M/212M [INFO] On Wed, Apr 5, 2017 at 11:26 AM, Tibor Digana-2 [via Maven] < ml-n

Re: Release Apache Maven Archetype Plugin version 3.0.1

2017-04-10 Thread Tibor Digana
+1 (binding) Good Job On Sat, Apr 8, 2017 at 3:26 PM, Robert Scholte wrote: > Hi, > > We solved 6 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > ctId=12317122=12339582=Text > > There are still a couple of issues left in JIRA: >

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 3

2017-04-10 Thread Tibor Digana
Feel free to participate in the vote and try to setup new version. On Sat, Apr 8, 2017 at 12:53 PM, Tibor Digana <tibordig...@apache.org> wrote: > Hi, > > We solved 70 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12317927=12334636 > &g

Want to cut release version today evening

2017-04-03 Thread Tibor Digana
We fixed 65 issues this year and going to cut a new release version of surefire project. Thanks to all developers and testers. The master will be intact. We will again continue development and testing branches until we reach the consensus which was found as good experience. We were facing quite

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-07 Thread Tibor Digana
properly saying > > goodbye. VM crash or System.exit called?" > > See the full build.log in the above git repo. I've also included the > > '.dumpstream' file. > > > > Petr > > > > > > On Thu, Apr 6, 2017 at 7:56 AM Tibor Digana <tibordig...@a

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-07 Thread Tibor Digana
_341-jvmRun2.dumpstream > > Also, once I disconnect the remote debugger, the build fails with > "ExecutionException The forked VM terminated without properly saying > goodbye. VM crash or System.exit called?" > See the full build.log in the above git repo. I've also included t

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
ing this in FreeBSD two months and found nothing. On Wed, Apr 5, 2017 at 2:16 PM, Petr Široký <siroky.p...@gmail.com> wrote: > On Wed, Apr 5, 2017 at 1:13 PM Tibor Digana <tibor.dig...@googlemail.com> > wrote: > > > What I see in the thread dump is > > that ForkedBoote

Re: Surefire and Java 9

2017-04-05 Thread Tibor Digana
Hi Joerg, We will continue on this issue after this release. Would you help us with your Java 9 knowhow? We have a ticket with Java9 issue in Jira. On Wed, Apr 5, 2017 at 11:32 AM, Jörg Schaible wrote: > Hi, > > does anyone already have a setup to execute surefire with

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
e on those > platforms, but it takes 10 or 15 tries. On Fedora 25 it happens almost > always (but I have seen it pass also there). > > On Wed, Apr 5, 2017 at 11:50 AM Tibor Digana <tibordig...@apache.org> > wrote: > > > On my side okay (Maven 3.5.0 Win7). > > I will che

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20

2017-04-05 Thread Tibor Digana
This Vote was canceled and a new TAKE 2 was sent to ML. On Tue, Apr 4, 2017 at 10:12 PM, Tibor Digana <tibordig...@apache.org> wrote: > Hi, > > We solved 65 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12317927=12334636 > > There are st

[VOTE] Release Apache Maven Surefire Plugin version 2.20 - TAKE 2

2017-04-05 Thread Tibor Digana
Hi, We solved 68 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927=12334636 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC Staging repo:

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
Yes, I will cancel it, and I will add few more fixes too. On Wed, Apr 5, 2017 at 7:01 PM, Michael Osipov <micha...@apache.org> wrote: > Am 2017-04-05 um 17:20 schrieb Tibor Digana: > >> I found the issue. >> In ForkedBooter we call >> >> encodeAndWriteToOut

Re: surefire-2_20-slowdown-reproducer

2017-04-05 Thread Tibor Digana
<micha...@apache.org> wrote: > Am 2017-04-05 um 19:02 schrieb Tibor Digana: > >> Yes, I will cancel it, and I will add few more fixes too. >> > > Good, tell me when you are ready. I will retest trunk before you prepare > the release. > > On Wed, Apr 5,

<    1   2   3   4   5   6   7   8   9   10   >