Hi,
currently i'm trying to upgrade the maven-filtering component from
xdoclet to annotation based usage...
For example:
- * @plexus.component
role="org.apache.maven.shared.filtering.MavenResourcesFiltering"
role-hint="default"
*/
+@org.codehaus.plexus.component.a
mx.de> wrote:
>
> Hi,
> currently i'm trying to upgrade the maven-filtering component from xdoclet to
> annotation based usage...
>
> For example:
>
> - * @plexus.component
> role="org.apache.maven.shared.
Hi,
On 11/5/15 6:00 AM, Uwe Barthel wrote:
-/**
- * @plexus.requirement
- */
+@Component
private BuildContext buildContext;
Use @Requirement instead of @Component.
Good catch...but unfortunately not enough...
Your hint brought to lookup more in detail and found one
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi there,
so far so good.
I have the following suggestions:
1. Also specify that the pom.filters are
in the order of their declaration in
the XML.
They are not used (as they are not used in resources plugin 2.2 and
adding filters as a
2008/10/7 Joerg Hohwiller [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi there,
so far so good.
I have the following suggestions:
1. Also specify that the pom.filters are
in the order of their declaration in
the XML.
They are not used (as they are not used
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Hi there,
as often I a little late on some threads ;)
I have start a proposal [1]
so far so good.
I have the following suggestions:
1. Also specify that the pom.filters are in the order of their declaration in
the XML.
2. Resolve variables
2008/9/24 Joerg Hohwiller [EMAIL PROTECTED]:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Hi there,
as often I a little late on some threads ;)
I have start a proposal [1]
so far so good.
I have the following suggestions:
1. Also specify that the pom.filters are in the order of
Hi,
I have start a proposal [1]
Thanks for comments,
--
Olivier
[1]
http://docs.codehaus.org/display/MAVEN/Resources+Handling+(common+component+maven-filtering)
2008/3/1, Jason van Zyl [EMAIL PROTECTED]:
I'll write something up about the ordering of processing in the wiki
so that we don't
Jason,
Have you found some time to look ?
I have created a resources plugin branch [1] which use the new component.
Thanks,
--
Olivier
[1] https://svn.apache.org/repos/asf/maven/plugins/branches/MRESOURCES-56/
2008/2/28, Jason van Zyl [EMAIL PROTECTED]:
You just have to make sure that the
I'll write something up about the ordering of processing in the wiki
so that we don't lose it in the ether. Probably won't happen today but
later Sunday night.
On 1-Mar-08, at 5:52 AM, Olivier Lamy wrote:
Jason,
Have you found some time to look ?
I have created a resources plugin branch
I agree with you Olivier. Now I don't know the internals of the
embedder. Jason, what do you think?
Stéphane
On Mon, Feb 25, 2008 at 11:06 PM, Olivier Lamy [EMAIL PROTECTED] wrote:
2008/2/24, Jason van Zyl [EMAIL PROTECTED]:
On 24-Feb-08, at 10:35 AM, Olivier Lamy wrote:
Hi,
You just have to make sure that the processing order that happens in
the resource plugin matches what would happen with processing of only
execution properties in the CLI/Embedder. I can take a look tomorrow
or grab me on IRC or I'll forget. I'm in one of my lose track of time
modes.
On
2008/2/24, Jason van Zyl [EMAIL PROTECTED]:
On 24-Feb-08, at 10:35 AM, Olivier Lamy wrote:
Hi,
Just to be sure mavenSession.getExecutionProperties() should be use.
Yes, system properties are turned into execution properties in the CLI
and pushed into the session. So that from the
I just hit the problem today with one of my colleague. Yes, System
props should definitely win.
Thanks,
Stéphane
On Sat, Feb 23, 2008 at 11:28 PM, Olivier Lamy [EMAIL PROTECTED] wrote:
Now the question is do we have to change this order ?.
Have a look at MRESOURCES-39 [1].
Users complains
On 24-Feb-08, at 12:36 AM, Stephane Nicoll wrote:
I just hit the problem today with one of my colleague. Yes, System
props should definitely win.
You also must start thinking about how system properties make it into
the execution environment. System properties wreak havoc in the
Hi,
Just to be sure mavenSession.getExecutionProperties() should be use.
Right ?
Thanks,
--
Olivier
2008/2/24, Jason van Zyl [EMAIL PROTECTED]:
On 24-Feb-08, at 12:36 AM, Stephane Nicoll wrote:
I just hit the problem today with one of my colleague. Yes, System
props should definitely
On 24-Feb-08, at 10:35 AM, Olivier Lamy wrote:
Hi,
Just to be sure mavenSession.getExecutionProperties() should be use.
Yes, system properties are turned into execution properties in the CLI
and pushed into the session. So that from the embedder each invocation
can have it's own session
Now the question is do we have to change this order ?.
Have a look at MRESOURCES-39 [1].
Users complains about system properties (-D in the mvn cli) doesn't win.
IMHO, system props should wins.
This was the case with maven1 [2].
Thougths ?
Thanks,
--
Olivier
[1]
Hi Olivier,
Sounds good!
I'll try to look into that this w-e, to see how to use it in the assembly
plugin, which suffers from lots of filtering issues.
Fabrice
On Tue, Feb 19, 2008 at 10:17 AM, Olivier Lamy [EMAIL PROTECTED] wrote:
Hi,
As you know some plugins made some filtering base on the
Hi,
As you know some plugins made some filtering base on the code coming
from the maven-resources-plugin.
This means there are some copy and paste from the resources plugin
source to other plugins.
To prevent this, the code from the resources plugin has been put in a
plexus component (currently
This one was very much expected, thanks for doing this.
However, I think that we should use a first-win strategy, otherwise
there is no way to control the actual value of a property. First-win
strategy is mainly used everywhere in the war plugin and ease a lot of
stuff
Is there any reason you
Sure, could be better.
But we have to agree on the order :
* System Properties
* pom.properties
* List of properties ( the method has a parameter which accept a List
of String - path properties files ) (war plugin use it to pass a list
of properties file).
* pom.filters
* pom.build.filters
?
--
I guess we should have a look to the way this is done currently to
avoid breaking the backward compat.
On Feb 19, 2008 11:30 AM, Olivier Lamy [EMAIL PROTECTED] wrote:
Sure, could be better.
But we have to agree on the order :
* System Properties
* pom.properties
* List of properties ( the
Yep sure.
Currently, the new component use the same strategy as the
maven-resources-plugin.
--
Olivier
2008/2/19, Stephane Nicoll [EMAIL PROTECTED]:
I guess we should have a look to the way this is done currently to
avoid breaking the backward compat.
On Feb 19, 2008 11:30 AM, Olivier Lamy
I also know that in terms of pom specified property files, it's last wins
currently.
-Original Message-
From: Stephane Nicoll [mailto:[EMAIL PROTECTED]
Sent: Tuesday, February 19, 2008 5:37 AM
To: Maven Developers List
Subject: Re: Maven Filtering component
I guess we should have
25 matches
Mail list logo
