://reviews.apache.org/r/32742/#review78591
---
On April 1, 2015, 10:39 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742
0f70ebafb0f5b16c560decc66e22a43a52732d09
Diff: https://reviews.apache.org/r/32742/diff/
Testing
---
make check
Thanks,
Jie Yu
On April 1, 2015, 10:22 p.m., Jie Yu wrote:
src/tests/port_mapping_tests.cpp, lines 405-406
https://reviews.apache.org/r/32653/diff/3/?file=911841#file911841line405
Please include stout/stopwatch.hpp
Has this been resolved?
- Jie
/containerizer/isolators/posix/disk.cpp
6e41e2a72cdcf914f2c922fdcb3d267b938e456e
Diff: https://reviews.apache.org/r/32694/diff/
Testing
---
make check
Thanks,
Jie Yu
://reviews.apache.org/r/32694/diff/
Testing
---
make check
Thanks,
Jie Yu
/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
Diff: https://reviews.apache.org/r/32698/diff/
Testing
---
Thanks,
Jie Yu
message in
the caller and then print them?
- Jie Yu
On March 31, 2015, 9:55 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32658
://reviews.apache.org/r/32658/#comment127069
`pid` is passed from the parent process. Why do you want to report it back?
- Jie Yu
On March 31, 2015, 9:55 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply
/
Testing
---
Thanks,
Jie Yu
/linux/perf.cpp 863aa4a972289a59f57e93cd06ba2bf9df949fe2
Diff: https://reviews.apache.org/r/32698/diff/
Testing (updated)
---
sudo make check
Thanks,
Jie Yu
check
Thanks,
Jie Yu
/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546/#review78456
---
Ship it!
Ship It!
- Jie Yu
On March 31, 2015, 10:01 p.m., Chi
`?
This function tries to decode the content received from the socket. Using
the name `internal::decode` seems to be more appropriate.
- Jie Yu
On March 23, 2015, 11 p.m., Ben Mahler wrote:
---
This is an automatically generated e-mail
I am a +1 on this too. We had a similar bug long time ago when we changed
the return value of Try::get() to be const ref.
On Mon, Mar 30, 2015 at 11:52 AM, Niklas Nielsen nik...@mesosphere.io
wrote:
Big +1; You could also mention the recent bug in the Two fold
authentication patch that you
://reviews.apache.org/r/30546/#comment126780
What it `!info-pressureCounters.contains(level)`?
- Jie Yu
On March 27, 2015, 3:24 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
for
5 seconds?
- Jie Yu
On March 31, 2015, 12:02 a.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30546
, you probabaly want to
initilize it to INADDR_ANY.
src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/32654/#comment126815
This fits in one line. Please do a sweep to fix similar issues.
- Jie Yu
On March 30, 2015, 11:29 p.m., Paul Brett wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276/#review78101
---
Ship it!
Ship It!
- Jie Yu
On March 27, 2015, 3:20 a.m., Chi
after the
container is destroyed.
Will add a compatibility test tomorrow.
Thanks,
Jie Yu
://reviews.apache.org/r/32347/#comment126372
Do you want to move this up right after
```
decoder.decode(body.data(), body.length());
```
?
- Jie Yu
On March 20, 2015, 11:51 p.m., Ben Mahler wrote
26, 2015, 10:56 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/
---
(Updated March 26, 2015, 10:56 p.m
the
container is destroyed.
Will add a compatibility test tomorrow.
Thanks,
Jie Yu
is empty after the
container is destroyed.
Will add a compatibility test tomorrow.
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/#review77780
---
On March 25, 2015, 6:43 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/#review77962
---
BTW, the new patch also fixed MESOS-2547
- Jie Yu
On March 26
-2547).
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/#review77596
---
On March 24, 2015, 2:44 a.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/#review77563
---
On March 25, 2015, 6:43 p.m., Jie Yu wrote
://reviews.apache.org/r/32426/#review77596
---
On March 24, 2015, 2:44 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426
the
container is destroyed.
Will add a compatibility test tomorrow.
Thanks,
Jie Yu
---
sudo make check
Thanks,
Jie Yu
/tests/memory_test_helper.cpp
https://reviews.apache.org/r/31276/#comment126070
Again, sizeof(DONE)
- Jie Yu
On March 24, 2015, 10:15 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/fs/cgroup/cpu,'.
Diffs
-
src/tests/mesos.cpp dc2a906a57b9abace4713aea8b0a47fec1c1a8a4
Diff: https://reviews.apache.org/r/32495/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
---
On March 25, 2015, 9:12 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32495
://reviews.apache.org/r/32346/#comment126081
Indent.
3rdparty/libprocess/src/http.cpp
https://reviews.apache.org/r/32346/#comment126097
either end of the pipe is closed or failed!
- Jie Yu
On March 20, 2015, 11:51 p.m., Ben Mahler wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32466/#review77824
---
On March 25, 2015, 12:04 a.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32466/#review77692
---
On March 25, 2015, 12:04 a.m., Jie Yu wrote
: mesos
Description
---
Cleaned up and simplified PortMappingMesosTest.
Diffs
-
src/tests/port_mapping_tests.cpp 623840e71938791a562a32989775818275e6d37e
Diff: https://reviews.apache.org/r/32466/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
Description
---
Allowed MesosContainerizer to take empty isolation flag.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
Diff: https://reviews.apache.org/r/32467/diff/
Testing
---
make check
Thanks,
Jie Yu
11e88330dd50913ab00da79054225d113541e83e
Diff: https://reviews.apache.org/r/32452/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
:
commit 46f80f270bc335172e919343f6f14e007216823f
Author: Jie Yu yujie@gmail.com
Date: Tue Mar 24 11:06:08 2015 -0700
Fixed a regression caused by the slave checkpoint flag removal.
diff --git a/src/tests/port_mapping_tests.cpp b/src/tests/port_mapping_tests.cpp
index 8192dea..623840e 100644
/containerizer/isolators/network/port_mapping.cpp
7b4aac88d40e4e5dc3331cb19b647a1d872ef7e2
src/tests/port_mapping_tests.cpp 82f98a47fa374fda13b0be76b07ccc03174a7b96
Diff: https://reviews.apache.org/r/32405/diff/
Testing
---
sudo make check
Thanks,
Jie Yu
On March 21, 2015, 6:26 a.m., Jie Yu wrote:
Jie Yu wrote:
Also, when fq_codel starts to be available? Do we need to add a check
during startup, or you think it's not necessary?
OK, the availability of fq_codel qdisc will be checked in
https://reviews.apache.org/r/31505. So I guess
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32419/#review77499
---
Ship it!
LGTM!
- Jie Yu
On March 24, 2015, 12:27 a.m., Ben
: https://reviews.apache.org/r/32426/diff/
Testing
---
sudo make check
Many existing tests should already capture the regression. For example,
ROOT_CleanUpOrphanTest checks if the bind mount dir is empty after the
container is destroyed.
Will add a compatibility test tomorrow.
Thanks,
Jie Yu
fq_codel because it has a better flow management and a larger default
buffer than pfifo_fast.
- Jie Yu
On March 18, 2015, 9:38 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 21, 2015, 6:26 a.m., Jie Yu wrote:
Also, when fq_codel starts to be available? Do we need to add a check during
startup, or you think it's not necessary?
- Jie
---
This is an automatically generated e-mail. To reply, visit
On March 18, 2015, 7:09 p.m., Jie Yu wrote:
src/slave/containerizer/mesos/launch.cpp, lines 268-270
https://reviews.apache.org/r/31444/diff/2/?file=898403#file898403line268
In fact, the chroot target needs to be 'recursively shared' (i.e.,
mount --make-rshared). Do we have a way
Buffington, Jie Yu,
and James Peach.
Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350
Repository: mesos
Description
---
Optionally take a path that the launch helper should chroot to before
exec'ing the executor. It is assumed that the work directory
On March 18, 2015, 7:09 p.m., Jie Yu wrote:
src/slave/containerizer/mesos/launch.cpp, lines 332-340
https://reviews.apache.org/r/31444/diff/2/?file=898403#file898403line332
Do you still need this?
Are you worried about the case that newRoot is readonly? If that's the case,
how do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28485/#review77255
---
Ship it!
Ship It!
- Jie Yu
On March 20, 2015, 6:24 p.m., Joris
for the C++ api and Java api?
We usually keep those comments in sync.
include/mesos/scheduler.hpp +234
src/java/src/org/apache/mesos/SchedulerDriver.java +138
- Jie Yu
On March 20, 2015, 2:51 p.m., Itamar Ostricher wrote
during
teardown in a multi-threaded enviornment because it'll be destructed while some
thread might still be using it.
So please return a copy or use a pointer for the static local variable.
- Jie Yu
On March 19, 2015, 7:23 p.m., Joris Van Remoortere wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review77123
---
Ship it!
- Jie Yu
On March 7, 2015, 6:56 a.m., Michael Park
as well in this case?
- Jie Yu
On March 18, 2015, 6:32 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31276
());
}
return await(futures)
.then(defer(...,
_usage,
containerId,
levels,
lambda::_1));
```
- Jie Yu
On March 18, 2015, 6:32 p.m., Chi Zhang wrote
On March 18, 2015, 11:49 p.m., Jie Yu wrote:
3rdparty/libprocess/src/process.cpp, lines 1149-1151
https://reviews.apache.org/r/31930/diff/2/?file=896916#file896916line1149
Does this comment still apply? Looks like we cannot write empty string.
Maybe a CHECK?
Ben Mahler wrote
.
Maybe add a TODO to remove ?
src/slave/containerizer/mesos/launch.cpp
https://reviews.apache.org/r/31444/#comment124637
Do you still need this?
- Jie Yu
On March 17, 2015, 10:44 p.m., Ian Downes wrote
:)
3rdparty/libprocess/src/process.cpp
https://reviews.apache.org/r/31930/#comment124728
Does this comment still apply? Looks like we cannot write empty string.
Maybe a CHECK?
- Jie Yu
On March 16, 2015, 11:49 p.m., Ben Mahler wrote
:
https://reviews.apache.org/r/32140/
---
(Updated March 18, 2015, 7:44 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu.
Bugs: MESOS-2476
https://issues.apache.org/jira/browse/MESOS-2476
On Feb. 27, 2015, 6:27 p.m., Jie Yu wrote:
src/slave/containerizer/mesos/launch.cpp, lines 437-444
https://reviews.apache.org/r/31444/diff/1/?file=876502#file876502line437
Is the `directory` here the path in the host file system or the path in
the chroot. Please add some comments
readable.
- Jie Yu
On March 17, 2015, 6:56 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32133/
---
(Updated
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31677/
---
(Updated March 10, 2015, 8:35 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31894/#review75937
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 5:22 p.m., Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31473/#review75913
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 8:36 a.m
On March 12, 2015, 4:09 a.m., Adam B wrote:
CHANGELOG, line 177
https://reviews.apache.org/r/31324/diff/9/?file=891845#file891845line177
Similarly, do we want to call out the new Accept(offerIds, Operation)
API, or wait until DiskInfo/DynamicReservations are ready before we try
On March 11, 2015, 9:59 p.m., Jie Yu wrote:
src/tests/memory_test_helper_child.hpp, line 42
https://reviews.apache.org/r/31276/diff/4/?file=890585#file890585line42
Do you really need this extra file? Can you move this subcommand
definition to memory_test_helper.hpp?
Chi Zhang
On March 11, 2015, 9:59 p.m., Jie Yu wrote:
src/tests/memory_test_helper.cpp, line 96
https://reviews.apache.org/r/31276/diff/4/?file=890584#file890584line96
Hum, this makes the page cache increasing depend on the memory
allocation. Can we simply construct a 4K buffer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31905/#review76321
---
Ship it!
Ship It!
- Jie Yu
On March 12, 2015, 11:20 p.m., Vinod
://reviews.apache.org/r/31276/#comment123546
Why do you need these two fields? Can they be local variable in 'execute()'?
- Jie Yu
On March 10, 2015, 7:26 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
{
if (left.size() != right.size()) {
return false;
}
for (int i = 0; i left.size(); i++) {
...
}
...
}
```
- Jie Yu
On March 11, 2015, 12:37 a.m., Vinod Kone wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31904/#review76082
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 6:21 p.m., Vinod
---
On March 10, 2015, 6:09 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31903/#review76110
---
On March 10, 2015, 6:09 p.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31873/#review76106
---
On March 10, 2015, 12:07 a.m., Jie Yu wrote
, 2015, 12:07 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31873/
---
(Updated March 10, 2015, 12:07 a.m
like
rtnl_u32_get_classid is not in libnl-3.2.25. That means we need a newer version
of libnl for this to work!
- Jie Yu
On March 10, 2015, 11:26 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit
://reviews.apache.org/r/31903/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31472/#review75912
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 8:36 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31884/#review75935
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 8:38 a.m
://reviews.apache.org/r/31897/#comment123289
```
return Error(Device minor is not a number);
```
src/linux/fs.cpp
https://reviews.apache.org/r/31897/#comment123291
Can you verify it by checking the kernel source code?
- Jie Yu
On March 10, 2015, 5:22 p.m., Ian Downes wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31895/#review75938
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 5:22 p.m., Ian
/stout/bits.hpp
https://reviews.apache.org/r/31677/#comment123264
s/value/count/
- Jie Yu
On March 10, 2015, 8:35 a.m., Evelina Dumitrescu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31896/#review75939
---
Ship it!
Ship It!
- Jie Yu
On March 10, 2015, 5:22 p.m., Ian
/#comment123355
Can you add a TODO here to move these to stout?
src/linux/fs.hpp
https://reviews.apache.org/r/31897/#comment123356
include sys/types.h for pid_t?
src/linux/fs.cpp
https://reviews.apache.org/r/31897/#comment123357
Fit in one line?
- Jie Yu
On March 10, 2015, 8:49
/#comment123372
Just do a
```
ASSERT_LE(waited, Seconds(5));
```
src/tests/slave_recovery_tests.cpp
https://reviews.apache.org/r/30546/#comment123374
Can you test the slave recovery in a separate test?
- Jie Yu
On Feb. 28, 2015, 1:43 a.m., Chi Zhang wrote
/#comment123391
Please add a comment about this function. It's not quite obvious what this
constructor is doing.
- Jie Yu
On March 10, 2015, 11:26 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
```
rtnl_cls_set_protocol(cls.get(), classifier.protocol());
```
src/linux/routing/filter/basic.cpp
https://reviews.apache.org/r/31504/#comment123402
Oops, do yo still need this check?
- Jie Yu
On March 10, 2015, 11:27 p.m., Cong Wang wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31501/#review75718
---
Still cannot view the diff.
- Jie Yu
On March 4, 2015, 8:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504/#review75717
---
The diff still has issues.
- Jie Yu
On March 6, 2015, 12:19 a.m
Can you keep the old name to reflect the fact that the method returns a
constant (more easy to understand at the callsites).
3rdparty/libprocess/include/process/profiler.hpp
https://reviews.apache.org/r/30841/#comment122944
Ditto here. Please keep the current names.
- Jie Yu
On March 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30841/#review75750
---
Ship it!
Ship It!
- Jie Yu
On March 9, 2015, 7:16 p.m., Dominic
On March 9, 2015, 7:37 p.m., Jie Yu wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1528-1533
https://reviews.apache.org/r/31505/diff/2/?file=884517#file884517line1528
I agree with Chi that the API is a little confusing and the code is
hard to read
9d8639b744e6f54cabaa9c866c02fec83dbcdbfa
Diff: https://reviews.apache.org/r/31870/diff/
Testing
---
make check
Thanks,
Jie Yu
== (const Classifier that) const;
private:
uint16_t protocol_;
};
```
- Jie Yu
On March 9, 2015, 6:32 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31504
// ...
return Nothing();
```
- Jie Yu
On March 9, 2015, 6:28 p.m., Cong Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31502
059ad6e091a2846e7d33ff61e3a611efec7d6462
src/linux/routing/link/link.hpp c2ddd6c24412568b6ce6cdc993e8abceacc78f60
src/linux/routing/route.hpp ec3046b144679f80e417d6df573f6d2612cbf61a
Diff: https://reviews.apache.org/r/31867/diff/
Testing
---
make check
Thanks,
Jie Yu
there in
the internal namesapce, we just need to expose it).
We can get the action attached to the filter and then we can get the flow
id from the action.
Let's chat about this.
- Jie Yu
On March 9, 2015, 6:57 p.m., Cong Wang wrote
d5b100a4c371bd9c496b9127767c14047185e5f9
Diff: https://reviews.apache.org/r/31873/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31870/#review75802
---
On March 9, 2015, 8:54 p.m., Jie Yu wrote
301 - 400 of 2138 matches
Mail list logo
