a6938d09851898dd5853d86231c9f9d9db15729b
src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3
src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3
Diff: https://reviews.apache.org/r/31016/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
8faf6850aafcebda7e9f0d1b735d61f7effa842d
src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b
src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3
Diff: https://reviews.apache.org/r/30962/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
this (massive) patch
to the internal change only :)
- Niklas Nielsen
On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30295
On Feb. 4, 2015, 4:07 p.m., Niklas Nielsen wrote:
src/slave/containerizer/containerizer.cpp, line 237
https://reviews.apache.org/r/30583/diff/2/?file=849006#file849006line237
Wouldn't it simplify executorEnvironment() if we set the default grace
period in getExecutorInfo
/#comment111068
This also needs to be in order. Will go ahead an do it for you.
- Niklas Nielsen
On Jan. 8, 2015, 2:34 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/#comment111067
Headers need to be sorted. I'll go ahead and fix it before committing.
- Niklas Nielsen
On Jan. 8, 2015, 3:53 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 8, 2015, 5:36 a.m., Niklas Nielsen wrote:
Another comment: let's create an issue for adding a 3rd test which verifies (by
measurement) that the timeouts are honored.
- Niklas
---
This is an automatically generated e-mail
* notified upfront with the
initial list and subsequently, if new peers are loaded from the whitelist file.
It that correctly understood and is this what your new logic does?
- Niklas Nielsen
On Jan. 8, 2015, 7:28 a.m., Alexander Rukletsov wrote
On Jan. 6, 2015, 5:26 a.m., Niklas Nielsen wrote:
Hi Kapil,
One high-level observation is that hooks are wired up with function
pointers. Can't we use an abstract class with virtual methods instead?
Kapil Arya wrote:
It can be done either way. One of the reasons for using
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29597/#review67027
---
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 6, 2015, 2:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28069/#review67031
---
Hi Alex, can you rebase this patch please :)
- Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28065/#review67032
---
Needs rebasing too :)
- Niklas Nielsen
On Dec. 10, 2014, 5:38
/#comment110529
s/ //
src/tests/slave_recovery_tests.cpp
https://reviews.apache.org/r/29507/#comment110528
s/ //
- Niklas Nielsen
On Dec. 31, 2014, 1:38 a.m., Adam B wrote:
---
This is an automatically generated e-mail. To reply
.)
Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Till Toenshoff,
and Vinod Kone.
Bugs: MESOS-2371
https://issues.apache.org/jira/browse/MESOS-2371
Repository: mesos
Description
---
This changeset puts the internal protos back into mesos::internal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31218/#review73314
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 19, 2015, 8:31 p.m
https://issues.apache.org/jira/browse/MESOS-2378
On 20 February 2015 at 14:30, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See https://builds.apache.org/job/mesos-reviewbot/4181/
--
[...truncated 12280 lines...]
warning: failed to remove
() factories. Try to
take a look at master detector and contender :)
- Niklas Nielsen
On March 13, 2015, 2:50 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31265
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32130/#review76694
---
Ship it!
Ship It!
- Niklas Nielsen
On March 16, 2015, 4:06 p.m
4.4.7 [cgroups tests disabled]
On Wed, Mar 18, 2015 at 4:04 PM, Brenden Matthews bren...@diddyinc.com
wrote:
+1
Tested with internal testing cluster.
On Wed, Mar 18, 2015 at 1:25 PM, craig w codecr...@gmail.com wrote:
+1
On Wed, Mar 18, 2015 at 3:52 PM, Niklas Nielsen nik
/#comment124494
s/adjusted/modified to contain source (from slave or executor)/
src/slave/slave.cpp
https://reviews.apache.org/r/32130/#comment124493
Insert newline
- Niklas Nielsen
On March 17, 2015, 2:54 p.m., Alexander Rukletsov wrote
,
Niklas Nielsen
://reviews.apache.org/r/32163/#comment125171
Seems like a bit overuse of value1, how about creating new JSON::Values so
we can tell the 'sub' test cases apart?
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
https://reviews.apache.org/r/32163/#comment125181
s/'//
- Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32306/#review77238
---
Ship it!
Ship It!
- Niklas Nielsen
On March 20, 2015, 7:51 a.m
Sounds like you are on the right track; let us know if you have any
problems developing/running modules.
We created a modules mailing list too where we can go into more details -
modu...@mesos.apache.org
Cheers,
Niklas
On 20 March 2015 at 12:47, Anshuman Goswami goswami.anshu...@gmail.com
wrote:
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Niklas Nielsen
On March 13, 2015, 12:55 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008
://reviews.apache.org/r/31324/diff/
Testing
---
Thanks,
Niklas Nielsen
o.e.j.s.ServletContextHandler{/,null}
(org.eclipse.jetty.server.handler.ContextHandler:843)
[2015-03-07 00:05:40,894] INFO Setting framework ID to
20150304-234928-16777343-5050-8149-
(mesosphere.marathon.MarathonSchedulerService:72)
Thanks,
Niklas Nielsen
(mesosphere.marathon.MarathonSchedulerService:72)
Thanks,
Niklas Nielsen
://reviews.apache.org/r/31775/#comment123220
Let's move to JIRA
- Niklas Nielsen
On March 5, 2015, 1:04 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775
ExecutorInfo:
executor_id {
value: default
}
command {
value: exit 1
}
framework_id {
value: 20150311-114156-3758096394-50894-29122-
}
Thanks,
Niklas Nielsen
://reviews.apache.org/r/31889/#comment123570
const Environment?
src/tests/hook_tests.cpp
https://reviews.apache.org/r/31889/#comment123535
Why not launch this as a regular task?
src/tests/hook_tests.cpp
https://reviews.apache.org/r/31889/#comment123534
const string
- Niklas Nielsen
: 20150311-114156-3758096394-50894-29122-
}
Thanks,
Niklas Nielsen
://reviews.apache.org/r/31889/#comment123487
Can you expand a bit on how it tests the hook?
src/tests/hook_tests.cpp
https://reviews.apache.org/r/31889/#comment123486
A newline here
- Niklas Nielsen
On March 10, 2015, 7:15 p.m., Kapil Arya wrote
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/
---
(Updated March 11, 2015, 3:27 p.m.)
Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Till
Toenshoff.
Bugs: MESOS-2463
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/#review76142
---
Ship it!
Ship It!
- Niklas Nielsen
On March 11, 2015, 2:54 p.m
---
Thanks,
Niklas Nielsen
, Ben Mahler, and Vinod Kone.
Repository: mesos
Description
---
Updated changelog for Mesos 0.22.0
Diffs (updated)
-
CHANGELOG 2a54f08b7bb9cc6983631268eafec8cb7d166d97
Diff: https://reviews.apache.org/r/31324/diff/
Testing
---
Thanks,
Niklas Nielsen
Still the python clean up issue (
https://issues.apache.org/jira/browse/MESOS-2362)
Niklas
On 6 March 2015 at 09:24, Apache Jenkins Server jenk...@builds.apache.org
wrote:
See https://builds.apache.org/job/mesos-reviewbot/4464/
--
[...truncated 5644
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32008/#review76398
---
LGTM
- Niklas Nielsen
On March 12, 2015, 5:10 p.m., Cody Maloney
/#comment123964
Want to keep comments line lengths as in our C++ files? If so, let's wrap
at 70 chars :)
- Niklas Nielsen
On March 13, 2015, 12:55 p.m., Cody Maloney wrote:
---
This is an automatically generated e-mail. To reply, visit
/31028/diff/
Testing
---
make check (with newly added VerifySlaveRunTaskHook test)
Thanks,
Niklas Nielsen
7a4cb09bc221af502e867cfb7fff2900b599ff1f
Diff: https://reviews.apache.org/r/30962/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
.
Changes
---
Rebased
Repository: mesos
Description
---
See summary.
Diffs (updated)
-
include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d
Diff: https://reviews.apache.org/r/31017/diff/
Testing
---
make check
Thanks,
Niklas Nielsen
---
make check (with modified VerifyMasterLaunchTaskHook test)
Thanks,
Niklas Nielsen
a975305430097a8295b4b155e8448572c12bde22
Diff: https://reviews.apache.org/r/31324/diff/
Testing
---
Thanks,
Niklas Nielsen
,
Niklas Nielsen
if we can merge the two constructors
src/tests/mesos.hpp
https://reviews.apache.org/r/31263/#comment123336
With one constructor, we could get rid of this helper.
src/tests/mesos.hpp
https://reviews.apache.org/r/31263/#comment123334
Can you reintroduce this destructor?
- Niklas Nielsen
and insert a newline below
src/master/master.hpp
https://reviews.apache.org/r/31776/#comment123228
Why do you need this forward declaration when you have the allocator
include?
- Niklas Nielsen
On March 5, 2015, 1:11 p.m., Alexander Rukletsov wrote
the
compatible function as NULL below.
- Niklas Nielsen
On March 5, 2015, 1:05 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31266/#review75962
---
Ship it!
- Niklas Nielsen
On March 5, 2015, 1:05 p.m., Alexander
following
refactorings will break if you don't do it)
- Niklas Nielsen
On March 5, 2015, 1:05 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31262
-like method
(Containerizer::create)? That would be a bit more consistent
- Niklas Nielsen
On March 5, 2015, 1:07 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31818/#review75581
---
On March 6, 2015, 5:08 p.m., Niklas Nielsen wrote
!
- Niklas Nielsen
On March 12, 2015, 1:42 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32002/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31479/#review76252
---
Tim, is this still relevant?
- Niklas Nielsen
On Feb. 26, 2015
-mail. To reply, visit:
https://reviews.apache.org/r/31324/#review76203
---
On March 11, 2015, 5:28 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply
---
On March 11, 2015, 5:28 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324
the comment :) Ship-it after
that move.
- Niklas Nielsen
On March 23, 2015, 11:32 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31977
Hi all,
The vote for Mesos 0.22.0 (rc4) has passed with the
following votes.
+1 (Binding)
--
Ben Mahler
Tim St Clair
Adam Bordelon
Brenden Matthews
+1 (Non-binding)
--
Alex Rukletsov
Craig W
Ben Whitehead
Elizabeth Lingg
Dario Rexin
Jeff
Hey Dave,
Thanks for reaching out! I wrote a draft post immediately after releasing
and getting some proof reading done:
https://docs.google.com/a/mesosphere.io/document/d/1GHbdu9A22UuN2UHIjQXheJ7oNaO84W-p2lbriAHo8FI/edit
Think I have things setup correctly, but I'd be happy to share a patch
Big +1; You could also mention the recent bug in the Two fold
authentication patch that you guys discovered with this bug.
Niklas
On 30 March 2015 at 10:49, Joris Van Remoortere jo...@mesosphere.io wrote:
I would like to propose we disallow capturing temporaries using a constant
reference:
Hi all,
Joris and Ben H recently located and fixed a resident bug in the state
abstraction which caused many crashes in the JVM (mostly in conjunction
with Marathon) at scale (https://issues.apache.org/jira/browse/MESOS-1795)
We therefore wanted to suggest doing a point release with this fix
Hi Henning,
It does sound suspicious.
Would you mind capturing this in a JIRA ticket (targeted 0.22.1) so we can
track progress and assign an owner?
Thanks,
Niklas
On 31 March 2015 at 10:00, Henning Schmiedehausen
hschmiedehau...@groupon.com wrote:
Ok, so here is my log file from the slave:
, Brenden Matthews wrote:
+1 for stability.
On Mar 30, 2015 6:26 PM, Benjamin Hindman b...@eecs.berkeley.edu
wrote:
Obviously a +1, this is a stability fix we should get to our users as
soon
as possible.
On Mon, Mar 30, 2015 at 9:01 PM, Niklas Nielsen nik...@mesosphere.io
/w04yjljd5gbcvbvxvd5bhmp4gn/T/tmpCVjtu3
Thanks,
Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31518/#review74773
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 26, 2015, 5:12 p.m
Same build issue as here: https://issues.apache.org/jira/browse/MESOS-2362
It's a bug in the cleanup stage of the python artifacts - wonder if it is a
make+parallelism bug
Niklas
On 3 March 2015 at 09:49, Apache Jenkins Server jenk...@builds.apache.org
wrote:
See
/slave/slave.cpp
https://reviews.apache.org/r/30074/#comment121926
No need for your else clause when you end the previous block with a return
src/tests/slave_tests.cpp
https://reviews.apache.org/r/30074/#comment121923
Why this change?
- Niklas Nielsen
On Feb. 19, 2015, 1:03 a.m
/#comment120962
Mind throwing in a comment on the three different scenarios and how it
translates to your code?
src/tests/master_tests.cpp
https://reviews.apache.org/r/30612/#comment118948
Needs to be 4 indent for argument wrapping
- Niklas Nielsen
On Feb. 16, 2015, 6:49 a.m., Alexander Rojas
TL;DR Yep; let's bring a bit more systematic process to this.
On 26 February 2015 at 16:05, Dave Lester d...@davelester.org wrote:
Earlier today, Niklas Nielsen created an initial document to catalog
previous and future Mesos releases:
https://cwiki.apache.org/confluence/display/MESOS/Mesos
https://issues.apache.org/jira/browse/MESOS-2407
On Tue, Feb 24, 2015 at 10:05 AM, Niklas Nielsen nik...@mesosphere.io
wrote:
Sure can.
How have you tracked them previously?
I created a doc where we can track the commits (taken there isn't a
template or git magic
description? :)
- Niklas Nielsen
On March 4, 2015, 10:15 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31734
/#comment122176
You need one more space in front here to get sub items, no? :)
docs/release-guide.md
https://reviews.apache.org/r/31720/#comment122083
Kill trailing whitespace
- Niklas Nielsen
On March 3, 2015, 6:20 p.m., Aaron Bell wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31720/#review75255
---
Ship it!
Ship It!
- Niklas Nielsen
On March 4, 2015, 12:06 p.m
On March 4, 2015, 10:49 a.m., Niklas Nielsen wrote:
docs/release-guide.md, lines 149-151
https://reviews.apache.org/r/31720/diff/1/?file=884188#file884188line149
You need one more space in front here to get sub items, no? :)
Aaron Bell wrote:
Two spaces is fine for sub items
src/tests/hook_tests.cpp
https://reviews.apache.org/r/30339/#comment122233
Where does this constant come from? Should we perhaps move this into
CreateMasterFlags()?
src/tests/hook_tests.cpp
https://reviews.apache.org/r/30339/#comment122234
Same here.
- Niklas Nielsen
On Jan. 27
, Ben Mahler, and Vinod Kone.
Repository: mesos
Description
---
Updated changelog for Mesos 0.22.0
Diffs (updated)
-
CHANGELOG 2a54f08b7bb9cc6983631268eafec8cb7d166d97
Diff: https://reviews.apache.org/r/31324/diff/
Testing
---
Thanks,
Niklas Nielsen
.
Repository: mesos
Description
---
Updated changelog for Mesos 0.22.0
Diffs
-
CHANGELOG 2a54f08b7bb9cc6983631268eafec8cb7d166d97
Diff: https://reviews.apache.org/r/31324/diff/
Testing
---
Thanks,
Niklas Nielsen
-
docs/upgrades.md 07d19f91127d60656086ddbb9a1e0357c3410764
Diff: https://reviews.apache.org/r/31325/diff/
Testing
---
Thanks,
Niklas Nielsen
/#comment120019
s/the 0.22 release/From Mesos 0.22.0/
Any reason not to make this a quotation as well?
docs/slave-recovery.md
https://reviews.apache.org/r/31300/#comment120020
Same here.
s/the 0.22 release/From Mesos 0.22.0/
- Niklas Nielsen
On Feb. 23, 2015, 5:26 a.m
and
especially for picking up and reporting bugs upfront!
There were a few commits this morning which caused issues with the network
isolator tests. We are working on getting these sorted out asap.
Thanks,
Niklas
On 17 February 2015 at 11:56, Niklas Nielsen nik...@mesosphere.io wrote:
Hi Dave
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31300/#review73631
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 23, 2015, 11:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31308/#review73638
---
Ship it!
Modulo Kapil's suggestion on reordering
- Niklas Nielsen
s/custon/custom/ - I'll get that in for you
- Niklas Nielsen
On Feb. 23, 2015, 10:51 a.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31310
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31310/#review73630
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 23, 2015, 10:51 a.m
Dominic, are you on top of this?
Niklas
On 23 February 2015 at 10:08, Apache Jenkins Server
jenk...@builds.apache.org wrote:
See https://builds.apache.org/job/mesos-reviewbot/4245/changes
Changes:
[dma] stout: Moved MAC and IP classes to stout/mac.hpp and stout/ip.hpp
[dma] mesos: Moved
of the other sections does use 'us' or
'we'.
I would love to see an example or two mentioned here (like you do in the
authentication section)
- Niklas Nielsen
On Feb. 23, 2015, 10:04 a.m., Kapil Arya wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31336/#review73882
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 23, 2015, 5:13 p.m
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
---
(Updated Feb. 24, 2015, 9:38 p.m.)
Review request for mesos, Connor Doyle and Niklas Nielsen.
Bugs: MESOS-2396
https://issues.apache.org/jira
Arya, and Vinod Kone.
Repository: mesos
Description
---
Added new flags and removed checkpoint slave flag
Diffs (updated)
-
docs/configuration.md 47d8ccb6a1f318b153a3509be10b8dac9a24130c
Diff: https://reviews.apache.org/r/31327/diff/
Testing
---
Thanks,
Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31327/#review73994
---
On Feb. 25, 2015, 1:56 p.m., Niklas Nielsen wrote
/diff/
Testing
---
Thanks,
Niklas Nielsen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31288/#review73480
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 22, 2015, 3:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31287/#review73486
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 22, 2015, 3:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31331/#review73723
---
Ship it!
Ship It!
- Niklas Nielsen
On Feb. 23, 2015, 4:13 p.m
/31331/
---
(Updated Feb. 23, 2015, 4:13 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, Till
Toenshoff, and Vinod Kone.
Bugs: MESOS-2381
https://issues.apache.org/jira/browse/MESOS-2381
/#review73708
---
On Feb. 23, 2015, 3:14 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324
: mesos
Description
---
Added new flags and removed checkpoint slave flag
Diffs
-
docs/configuration.md 47d8ccb6a1f318b153a3509be10b8dac9a24130c
Diff: https://reviews.apache.org/r/31327/diff/
Testing
---
Thanks,
Niklas Nielsen
: mesos
Description
---
configuration.md had very long lines. This patch brings those to 80 cols.
Diffs
-
docs/configuration.md 47d8ccb6a1f318b153a3509be10b8dac9a24130c
Diff: https://reviews.apache.org/r/31328/diff/
Testing
---
Thanks,
Niklas Nielsen
---
configuration.md had very long lines. This patch brings those to 80 cols.
Diffs
-
docs/configuration.md 47d8ccb6a1f318b153a3509be10b8dac9a24130c
Diff: https://reviews.apache.org/r/31328/diff/
Testing
---
Thanks,
Niklas Nielsen
901 - 1000 of 1166 matches
Mail list logo
