Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Jakob Korherr
Hi, right - there are no entries in the manifest. they will be generated for the separated osgi bundle/s during the build (based on the build config). Jep! That was the idea in the first place (look at the branch and you'll see no bundle plugin in myfaces-api or myfaces-impl, but in

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Gerhard Petracek
great! thx jakob mark! +1! regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/11 Jakob Korherr jakob.korh...@gmail.com Hi, right - there are no entries in the

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Werner Punz
+1 Am 11.07.11 11:39, schrieb Gerhard Petracek: great! thx jakob mark! +1! regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/11 Jakob Korherr jakob.korh...@gmail.com

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Jakob Korherr
Hi, 1. All classes in org.apache.myfaces.spi. I did not change anything here, just internal imports (from *.spi.impl to *.spi.util)! 2. All classes that has to be with LifecycleProvider (@PostConstruct annotation). Such classes should be on spi package, but note spi work started after 2.0

[jira] [Commented] (TOBAGO-1013) The Progressbar is not rendered properly with a value of 0. The right border is not displayed.

2011-07-11 Thread Bernd Bohmann (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063327#comment-13063327 ] Bernd Bohmann commented on TOBAGO-1013: --- Thanks, for the feedback. I expect the

[jira] [Created] (TRINIDAD-2113) Dialog duplicate id

2011-07-11 Thread Chamber (JIRA)
Dialog duplicate id --- Key: TRINIDAD-2113 URL: https://issues.apache.org/jira/browse/TRINIDAD-2113 Project: MyFaces Trinidad Issue Type: Bug Components: Build Affects Versions: 2.0.0 Environment:

Re: [VOTE] Release Tobago 1.0.37

2011-07-11 Thread Udo Schnurpfeil
+1 I've deployed the demo to http://irian.biz/tobago-example-demo/ Regards Udo Am 10.07.11 15:42, schrieb Mark Struberg: +1 Btw, you could upgrade to the newest myfaces-parent. LieGrue, strub --- On Sat, 7/9/11, Bernd Bohmannbernd.bohm...@atanion.com wrote: From: Bernd

Re: [VOTE] Release Tobago 1.5.0-beta-1

2011-07-11 Thread Udo Schnurpfeil
+1 I've deployed the demo to http://irian.biz/tobago-example-demo-trunk/ Regards Udo Am 10.07.11 15:54, schrieb Mark Struberg: +1 LieGrue, strub --- On Sun, 7/10/11, Bernd Bohmannbernd.bohm...@atanion.com wrote: From: Bernd Bohmannbernd.bohm...@atanion.com Subject: [VOTE] Release Tobago

Re: [core] Improve error reporting and logging / General ErrorPage improvements (MYFACES-3213)

2011-07-11 Thread Martin Koci
Summary of proposed changes for ErrorPage: In header: - viewId, - location of facelet in filesystem - PhaseId In body: - info about component (that triggered the problem) - EL expression being evaluated, it's location, name of attribute/value pair - caused by: output first line of StackTrace

Re: GSOC 2011: MyFaces webapp tests

2011-07-11 Thread Jan Zarnikov
Hi, in the last few weeks I've been working on the GSOC project for Apache Myfaces (see http://wiki.apache.org/myfaces/GSoC2011_AutomatedTests) If you are curious you can check out the current source from http://subversion.assembla.com/svn/manila/ What's working: * starting tests in different

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Leonardo Uribe
Hi 2011/7/11 Jakob Korherr jakob.korh...@gmail.com: Hi, 1. All classes in org.apache.myfaces.spi. I did not change anything here, just internal imports (from *.spi.impl to *.spi.util)! It is questionable to create .spi.util. After all, it is not supposed that package be consumed by

Re: GSOC 2011: MyFaces webapp tests

2011-07-11 Thread Gerhard Petracek
hi jan, sounds great - thx for the update! regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/11 Jan Zarnikov jan.zarni...@gmail.com Hi, in the last few weeks I've been

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Jakob Korherr
Hi, No, sorry Leo, they are not enough. Frankly, I don't understand why you are blocking this solution. It is easy, it does not break anything (if we do not change the package names), it is a lot more clean and we can get rid of the shaded-impl module. If we don't do this now, we will maybe have

Re: GSOC 2011: MyFaces webapp tests

2011-07-11 Thread Jakob Korherr
Hi Jan, Yes, thanks a lot for the update on your project! Regards, Jakob 2011/7/11 Gerhard Petracek gerhard.petra...@gmail.com: hi jan, sounds great - thx for the update! regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Leonardo Uribe
Hi I'll be clear and direct. What makes statements true or false are the reasons behind it. Until this moment, you are not question the reasons behind the reasoning proposed. To be short, my argumentation is we can't change for now: 1. Everything inside org.apache.myfaces.spi 2.

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Leonardo Uribe
Hi Please don't commit the changes until I do a final review. That will take some time, so please be patient, there are other issues on core right now that we need to solve too. Anyway we can't commit the code without a release of javadoc plugin. regards, Leonardo Uribe 2011/7/11 Jakob Korherr

Re: [VOTE] Release Tobago 1.0.37

2011-07-11 Thread Volker Weber
Hi, +1 Regards, Volker 2011/7/11 Udo Schnurpfeil u...@schnurpfeil.de: +1 I've deployed the demo to http://irian.biz/tobago-example-demo/ Regards Udo Am 10.07.11 15:42, schrieb Mark Struberg: +1 Btw, you could upgrade to the newest myfaces-parent. LieGrue, strub --- On

Re: [VOTE] Release Tobago 1.5.0-beta-1

2011-07-11 Thread Volker Weber
Hi, +1 Regards, Volker 2011/7/11 Udo Schnurpfeil u...@schnurpfeil.de: +1 I've deployed the demo to http://irian.biz/tobago-example-demo-trunk/ Regards Udo Am 10.07.11 15:54, schrieb Mark Struberg: +1 LieGrue, strub --- On Sun, 7/10/11, Bernd

Result (was: [VOTE] how myfaces-commons-resourcehandler should work with suffix mapping enabled )

2011-07-11 Thread Leonardo Uribe
Hi Thanks to all community members who vote. Here are the results 1. No votes 2. 5 votes (Martin Marinschek, Jakob Korherr, Gerhard Petracek, Rudy de Busscher, Jan Kees Van Andel) 3. 7 votes (Leonardo Uribe, Martin Marinschek, Jakob Korherr, Gerhard Petracek, Rudy de Busscher, Jan Kees Van

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Gerhard Petracek
hi leo, right now i don't see a reason why it should take a lot of time. in the end you just have to look at the resulting artifacts. the javadoc plugin is no blocker (if there is no official release, we can do an external release. as soon as there is an official release of it, we can switch

[jira] [Created] (MYFACES-3216) check concurrency problems over static maps holding class metadata information (_ComponentAttributesMap and MetaRulesetImpl)

2011-07-11 Thread Leonardo Uribe (JIRA)
check concurrency problems over static maps holding class metadata information (_ComponentAttributesMap and MetaRulesetImpl) Key: MYFACES-3216

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Leonardo Uribe
Hi Gerhard Does somebody reviewed if the site documentation is generated correctly? Isn't any problem with @JSFWebConfigParam? has anybody debugged something with the proposed code?. That's the unresolved questions I want to solve before apply it (I already mention that without response, right?),

Re: [core] Purpose and usage of AbortProcessingException (MYFACES-3199)

2011-07-11 Thread Martin Koci
Here is my opinion: the purpose of AbortProcessingException is similar as ValidatorException or ConverterException. These are thrown as a result of normal lifecycle processing. With AbortProcessingExpcetion it is (or should be) possible to achieve this: h:commandButton f:actionListener

[jira] [Resolved] (MYFACES-3216) check concurrency problems over static maps holding class metadata information (_ComponentAttributesMap and MetaRulesetImpl)

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-3216. - Resolution: Fixed Fix Version/s: 2.1.2 2.0.8

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Jakob Korherr
Hi, I agree with Gerhard. Unfortunately I did not try a whole release + site build with the new configuration since you always do that, Leo. So please check on that as soon as possible for you. Regards, Jakob 2011/7/11 Gerhard Petracek gerhard.petra...@gmail.com: hi leo, actually we should

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Jakob Korherr
Hi, Leo, I really get your point that we can't change this stuff. Changing SPI stuff (even just renaming packages) will break application server integation code, we all got it now.. That's why I suggested (a few mails ago, but unfortunately too vague) keeping the package names *.spi, *.spi.impl

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Gerhard Petracek
hi jakob, i suggest the same approach like before. last time leo requested some changes and had to start the vote (with a short description) and this time it's your turn. if you feel that we need a vote about it, please feel free to start one. regards, gerhard http://www.irian.at Your JSF

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Jakob Korherr
Hi Gerhard, OK, thx. Will do so! Regards, Jakob 2011/7/11 Gerhard Petracek gerhard.petra...@gmail.com: hi jakob, i suggest the same approach like before. last time leo requested some changes and had to start the vote (with a short description) and this time it's your turn. if you feel that

Re: [core] Purpose and usage of AbortProcessingException (MYFACES-3199)

2011-07-11 Thread Leonardo Uribe
Hi 2011/7/11 Martin Koci martin.kocicak.k...@gmail.com: Here is my opinion: the purpose of AbortProcessingException is similar as ValidatorException or ConverterException. These are thrown as a result of normal lifecycle processing. I agree with you. With AbortProcessingExpcetion it is

Using multiple triggers with autosubmit

2011-07-11 Thread Pablo Caselas
Hi, I am using trinidad components such as selectOneChoice with the attribute autosubmit=true and then listening to the events triggered by these components in a panelGroupLayout. Somehow, if I have them all in one form they get changed even if I didn't change them. I think would be able to

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Leonardo Uribe
Hi 2011/7/11 Jakob Korherr jakob.korh...@gmail.com: Hi, Leo, I really get your point that we can't change this stuff. Changing SPI stuff (even just renaming packages) will break application server integation code, we all got it now.. That's why I suggested (a few mails ago, but

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Leonardo Uribe
Hi 2011/7/11 Gerhard Petracek gerhard.petra...@gmail.com: hi jakob, i suggest the same approach like before. last time leo requested some changes and had to start the vote (with a short description) and this time it's your turn. if you feel that we need a vote about it, please feel free to

Re: Proposal: Get rid of shaded-impl module in core 2.1.x

2011-07-11 Thread Gerhard Petracek
hi leo, if both of you agree on the rest, we won't need a vote - that's right. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/12 Leonardo Uribe lu4...@gmail.com Hi

[jira] [Updated] (MYFACES-3209) Implement f:setPropertyActionListener according specification

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe updated MYFACES-3209: Resolution: Fixed Fix Version/s: 2.1.2 2.0.8 Assignee:

[jira] [Commented] (MYFACES-3190) Annoying SEVERE: View State cannot be reconstructed + stacktrace with ViewExpiredException

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063581#comment-13063581 ] Leonardo Uribe commented on MYFACES-3190: - That log is deliberately there,

[jira] [Updated] (MYFACES-3194) trivial improvements to procedural commentary in FacesServlet.service()

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe updated MYFACES-3194: Resolution: Fixed Fix Version/s: 2.1.2 2.0.8 Assignee:

[jira] [Issue Comment Edited] (MYFACES-3207) ErrorPageWriter: provide info about component(s) that triggered the problem

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063636#comment-13063636 ] Leonardo Uribe edited comment on MYFACES-3207 at 7/12/11 1:09 AM:

[jira] [Commented] (MYFACES-3207) ErrorPageWriter: provide info about component(s) that triggered the problem

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063639#comment-13063639 ] Leonardo Uribe commented on MYFACES-3207: - The patch proposed is nice stuff. I

[jira] [Commented] (MYFACES-3202) Improve EL Exceptions wrapping

2011-07-11 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063643#comment-13063643 ] Leonardo Uribe commented on MYFACES-3202: - I think in this case it could be