Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-08 Thread Chetan Mehrotra
Hi Oliver, On Fri, Jan 8, 2016 at 5:22 PM, Oliver Lietz wrote: > +1 (though I would have preferred increment and decrement instead of inc and > dec on Counter) As I am redoing the release I would make the change in method names. Do you have any other suggestion wrt API?

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-08 Thread Oliver Lietz
On Friday 08 January 2016 11:15:13 Chetan Mehrotra wrote: > On Thu, Jan 7, 2016 at 8:39 PM, Daniel Klco wrote: > > If this is a "beta" piece of software I'm not sure we'd need the > > dependency > > yet. > > Looks like my use of version as 0.0.2 caused confusion. To

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-08 Thread Carsten Ziegeler
Oliver Lietz wrote > On Friday 08 January 2016 11:15:13 Chetan Mehrotra wrote: >> On Thu, Jan 7, 2016 at 8:39 PM, Daniel Klco wrote: >>> If this is a "beta" piece of software I'm not sure we'd need the >>> dependency >>> yet. >> >> Looks like my use of version as 0.0.2

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-08 Thread Oliver Lietz
On Thursday 07 January 2016 19:43:18 Chetan Mehrotra wrote: > Hi, > > This is the first release of the new Sling Commons Metrics component > with 1 issue fixed > > https://issues.apache.org/jira/browse/SLING/fixforversion/12334625 +1 (though I would have preferred increment and decrement

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-08 Thread Chetan Mehrotra
On Fri, Jan 8, 2016 at 5:42 PM, Carsten Ziegeler wrote: > But releasing a 0.0.2 version with a final 1.0.0 package, doesn't sound > right to me. Fine would cancel this vote then and cut a new release with bundle version set to 1.0 Chetan Mehrotra

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-07 Thread Chetan Mehrotra
Hi Daniel, On Thu, Jan 7, 2016 at 8:00 PM, Daniel Klco wrote: > This is a core bundle right? Not contrib? It looks like it's missing a > dependency com.codahale.metrics, which is not included in the Sling > Launchpad. Yes Metrics bundle is a required dependency. I planned to

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-07 Thread Chetan Mehrotra
On Thu, Jan 7, 2016 at 8:10 PM, Carsten Ziegeler wrote: > If you plan updates on the api, then we can go with 0.0.2 for now as > there will be a 1.1.0 or 1.0.2 anyways. > However of course all api changes must follow semantic versioning I plan to add some new feature like

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-07 Thread Carsten Ziegeler
Why is this version 0.0.2? The api version is 1.0.0 so I think we should call it 1.0.0 as well. (I know that these versions don't have to be the same) Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-07 Thread Chetan Mehrotra
On Thu, Jan 7, 2016 at 8:39 PM, Daniel Klco wrote: > If this is a "beta" piece of software I'm not sure we'd need the dependency > yet. Looks like my use of version as 0.0.2 caused confusion. To clarify this is not a "beta" piece of software. Current feature set done is

Re: [VOTE] Release Apache Sling Commons Metrics 0.0.2

2016-01-07 Thread Chetan Mehrotra
[ ] +1 Approve the release Chetan Mehrotra On Fri, Jan 8, 2016 at 11:15 AM, Chetan Mehrotra wrote: > On Thu, Jan 7, 2016 at 8:39 PM, Daniel Klco wrote: >> If this is a "beta" piece of software I'm not sure we'd need the dependency >> yet. > >