Re: [s2] Pluggable URL building proposal

2007-02-11 Thread Tom Schneider
Ok, I've decided to prototype the urlbuilder in tabletags. (Getting s2 all converted over would've taken too much time) So I've checked in the basic servlet/portlet url builders here: http://tabletags.googlecode.com/svn/trunk/tags/src/main/java/com/googlecode/tabletags/urlbuilder/ I'd

Re: [s2] Pluggable URL building proposal

2007-02-05 Thread Nils-Helge Garli
I like the JSR168 approach to URLs, where URLs are objects. So if URL was an interface, with two concrete implementations (one for servlet and one for portlet), URL manipulation would be very flexible and easy (e.g. addParameter, setAttribute etc), and rendering the URL as a String would be

Re: [s2] Pluggable URL building proposal

2007-02-05 Thread Tom Schneider
Yes, I've already implemented that piece of it. The UrlBuilder implementation can automatically be injected via the @Inject annotation, just like the actionmapper. Right now my ServletUrlBuilder and PortletUrlBuilder use the static UrlHelper and PortletUrlHelper under the hood, but

Re: [s2] Pluggable URL building proposal

2007-02-04 Thread Don Brown
Cool, but please, please, please find some way to avoid a static helper class :) BTW, it would be cool if the urlbuilder would be able to automatically discover any other objects that want a shot at the URL building process. See how the TagLibrary or TemplateEngine classes are discovered for

Re: [s2] Pluggable URL building proposal

2007-02-01 Thread Tom Schneider
Ok, I had a little time tonight to put together a preliminary design for the URLBuilder. Here's what I have so far for the interface: URLBuilder +buildURL(CustomAttributes, ActionMapping) // this method is for when an action, namespace, method, etc. is supplied +buildURL(CustomAttributes,

Re: [s2] Pluggable URL building proposal

2007-01-31 Thread Patrick Lightbody
Tom, How is this coming along? I imagine that some of this work would also relate to the ActionMapper interface, since it does have some responsibilities for rendering out URLs. Keep us posted. - Posted via Jive Forums

Re: [s2] Pluggable URL building proposal

2007-01-31 Thread Tom Schneider
Hey Patrick, Haven't had time to look at this any further. Yes, I definitely would build on top of the ActionMapper stuff--that's already abstracted out so nicely I didn't even mention it. :) I might have some time this weekend to dig into this further. (I was too busy releasing the first

Re: [s2] Pluggable URL building proposal

2007-01-23 Thread Don Brown
I _love_ this idea as it is been something I've wanted to tackle myself for a while now. I'm very interested in your progress, so let us know what you find. Don Tom Schneider wrote: Based on the portlet plugin proposal and some work I've been doing with the table tags, I thought I would

Re: [s2] Pluggable URL building proposal

2007-01-23 Thread Tom Schneider
I am very ashamed to report that I didn't get very far. (too much snow to shovel last weekend) I was able to analyze what each type of url would need, i.e. portlet vs. normal url. I think our best best is to have a data bean that encapsulates non-stardard stuff for each url type along with

[s2] Pluggable URL building proposal

2007-01-21 Thread Tom Schneider
Based on the portlet plugin proposal and some work I've been doing with the table tags, I thought I would propose a refactor of the URL building for struts2. Right now, struts2 has great support for taking on incoming request and mapping it to the core elements of the framework (i.e.