[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-21 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-133562903 Haven't heard any inputs on the mailing list nor here. Not sure how active the project is. --- If your project is set up for it, you can reply to this email and have

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/8 IVY-1522 Windows OS file path resolution fix The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This commit includes a new test method to verify

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/8#issuecomment-136174686 Thanks for testing this. I'll see if I can borrow a Windows OS to come up with a proper fix and test for this. Closing this for now. --- If your project is set up

[GitHub] ant-ivy pull request: IVY-1522 Windows OS file path resolution fix

2015-08-30 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/pull/7#issuecomment-136157678 Thanks @nlalevee for merging this. Glad to see the contribution being accepted. Will send out PRs for other issues that I have started looking into. --- If your

[GitHub] ant-ivy pull request: IVY-1526 Use parent pom's license (if any) i...

2015-08-30 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #10: Fix for IVY-1531

2016-12-07 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/10 Fix for IVY-1531 The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1531. Maven pom.xml allows dependency exclusion to include

[GitHub] ant-ivy pull request #12: IVY-1482 Fix potential NPE in XmlReportOutputter

2016-12-11 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/12 IVY-1482 Fix potential NPE in XmlReportOutputter The commit here adds a null check to prevent potential NPE reported in JIRA https://issues.apache.org/jira/browse/IVY-1482 You can merge

[GitHub] ant-ivy pull request #11: IVY-1499 Prevent potential NPE during retrieve

2016-12-11 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/11 IVY-1499 Prevent potential NPE during retrieve The commit here adds a null check to prevent a potential NPE that is reported in JIRA https://issues.apache.org/jira/browse/IVY-1499 You can merge

[GitHub] ant-ivy pull request #12: IVY-1482 Fix potential NPE in XmlReportOutputter

2016-12-12 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #12: IVY-1482 Fix potential NPE in XmlReportOutputter

2016-12-12 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/12 Closing this PR, since the commit here https://github.com/apache/ant-ivy/commit/c4bb60046de9ffdd1cf07cfcdba201df06b194dd handles it in a better way. --- If your project is set up for it, you can

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/57 Overall, this looks fine to me. I just need some inputs from the rest of the team on one specific change, for which I have raised a dev list thread https://www.mail-archive.com/dev@ant.apache.org

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-02 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/57 Hi Gintas, To be clear - what I meant/proposed in the dev list was: - It's fine to have all the changes related to introducing that new method with Java generics

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398802 --- Diff: src/java/org/apache/ivy/util/url/HttpClientHandler.java --- @@ -177,7 +177,7 @@ public URLInfo getURLInfo(URL url, int timeout

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395633 --- Diff: src/java/org/apache/ivy/osgi/p2/XMLInputParser.java --- @@ -19,12 +19,11 @@ import java.io.IOException; import java.io.InputStream

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 I've reviewed this PR and apart from the review comments noted, the rest of the changes look fine. Please only include any review comments related changes to this PR, from now on. Else it's going

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395788 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127395825 --- Diff: src/java/org/apache/ivy/osgi/repo/AbstractFSManifestIterable.java --- @@ -44,9 +44,9 @@ public AbstractFSManifestIterable(T root

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396320 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396341 --- Diff: src/java/org/apache/ivy/osgi/repo/RepositoryManifestIterable.java --- @@ -59,11 +59,11 @@ protected InputStream getInputStream(String f) throws

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127396424 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397389 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127397658 --- Diff: src/java/org/apache/ivy/plugins/repository/ssh/SshCache.java --- @@ -263,9 +263,8 @@ public void clearSession(Session session

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127398451 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127475255 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy issue #51: Fix some string comparisons with ==

2017-07-09 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/51 Thanks for the PR. This has now been merged. I had to fix the `ModuleDescriptorMemoryCacheTest` which got exposed by (valid) changes in this PR. --- If your project is set up for it, you can

[GitHub] ant-ivy issue #52: Generics in core

2017-07-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/52 It looks like this PR has been updated with additional unrelated changes. Except for these 2 commits in this PR: https://github.com/apache/ant-ivy/pull/52/commits

[GitHub] ant-ivy pull request #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/54 IVY-735 Support timeouts on resolvers The commit in this PR adds support for specifying connection and read timeouts for resolvers, so that users have control over how the resolvers behave when

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant/pull/35 [1.9.x branch] Fix for BZ-43271 BZ-59648 The commit here fixes the issue reported in: https://bz.apache.org/bugzilla/show_bug.cgi?id=43271#c6 https://bz.apache.org/bugzilla/show_bug.cgi?id

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> The PR contains additional changes to HttpClientHandler, introducing HttpConnectionManagerParams, which is not available in Commons HTTP Client version 2 (over 10 years old and virtuall

[GitHub] ant-ivy pull request #:

2017-07-25 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286798 Sure, I'll do a find/replace in one of my upcoming doc fixes commit. --- If your project is set up for it, you can reply

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Hi Gintas, Given the amount of commits and the changes involved in this PR, it's a bit difficult to review it. I think this PR even includes some of the changes that have already been

[GitHub] ant issue #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/35 All done - applied this commit to 1.9.x branch and then merged to master branch. The pushed commit also includes updates to the WHATSNEW and contributor files. --- If your project is set up

[GitHub] ant pull request #35: [1.9.x branch] Fix for BZ-43271 BZ-59648

2017-07-22 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 Gintas, thanks for pointing me to that code. I now understand what you meant. So essentially, Ivy internally tries to support both 2.x and 3.x version of HTTP client library at runtime

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> So it's not going to work out supporting 2.x version since we will end up using 3.x APIs at compile time. But that's a different topic altogether and something that I will raise a de

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/54 >> VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT; would that require an additional timeout attribute? I had a look at this. Given that there's currently

[GitHub] ant-ivy pull request #:

2017-07-27 Thread jaikiran
Github user jaikiran commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334838 Do you mean for the `symlinkmass` deprecation? In this release, I just wanted it to be deprecated with a log message showing up

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/53 Commit https://github.com/apache/ant-ivy/pull/53/commits/414651c8841a09a9d9d4b0365ee8e7227fba8429 in this PR has now been merged to upstream https://github.com/apache/ant-ivy/commit

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129757849 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129593699 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- This file has a large

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129587968 --- Diff: src/java/org/apache/ivy/plugins/conflict/LatestCompatibleConflictManager.java --- @@ -85,14 +85,12 @@ public LatestCompatibleConflictManager

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125161935 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-01 Thread jaikiran
Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/48#discussion_r125162592 --- Diff: src/java/org/apache/ivy/plugins/signer/bouncycastle/OpenPGPSignatureGenerator.java --- @@ -161,7 +159,7 @@ private PGPSecretKey readSecretKey

[GitHub] ant-ivy issue #48: Generics and Java 7 syntax in osgi and plugins packages

2017-07-01 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/48 >> https://stackoverflow.com/questions/30454635/when-using-for-a-primitive-and-a-boxed-value-is-autoboxing-done-or-is-unbox Thanks - the JLS sections[1][2] mentioned in there answ

[GitHub] ant-ivy pull request #16: Fix download URL for findbugs task

2017-05-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/16 Fix download URL for findbugs task The commit here fixes the download URL used in the `init-findbugs` task, that has been failing[1] for a while due to reference to an URL that no longer works

[GitHub] ant-ivy pull request #17: Fix IVY-1478

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/17 Fix IVY-1478 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1478 and also includes a test case to verify the changes. The fix involves setting

[GitHub] ant-ivy pull request #13: Dummy PR - Do not merge

2017-05-18 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #18: Fix IVY-1448

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/18 Fix IVY-1448 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1448 and also includes a test case to verify the fix. **Note that this issue isn't

[GitHub] ant-ivy pull request #19: IVY-1554 - Add (conditional) support for SHA-256 S...

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/19 IVY-1554 - Add (conditional) support for SHA-256 SHA-512 and SHA-384 checksum algorithms The commit here adds support for SHA-256, SHA-512 and SHA-384 algorithms as requested in https

[GitHub] ant-ivy pull request #13: Dummy PR - Do not merge

2017-05-17 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/13 Dummy PR - Do not merge This is just a dummy PR to test the PR integration with Jenkins jobs on Apache infra You can merge this pull request into a Git repository by running: $ git pull

[GitHub] ant-ivy issue #13: Dummy PR - Do not merge

2017-05-17 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/13 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy issue #11: IVY-1499 Prevent potential NPE during retrieve

2017-05-16 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/11 Closing for now, since I need to revisit this to see if this is still valid --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant-ivy pull request #11: IVY-1499 Prevent potential NPE during retrieve

2017-05-16 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 Looking at the logs, the BasicURLHandler seems to have crashed because the Jenkins process was killed due to: ``` [junit] Running org.apache.ivy.util.url.BasicURLHandlerTest

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 The latest build completed successfully https://builds.apache.org/job/Ivy-GithubPR/15/console. Coming to the question: > Why not sticking only to well-known versioning sche

[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-19 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/21 Fix IVY-1495 The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the `ivysettings.xml` is being parsed

[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/21 >> That WarnCircularDependencyStrategyTest testcase though probably needs to be looked into separately, since it keeps failing once in a while on Jenkins. I think this https://gith

[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/21 FWIW - the test failures don't look related. That specific testcase though probably needs to be looked into separately though, since it keeps failing once in a while on Jenkins. --- If your

[GitHub] ant-ivy pull request #22: Fix transient test failures

2017-05-19 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/22 Fix transient test failures The `WarnCircularDependencyStrategyTest` fails once in a while on Jenkins. Looking at the testcase, it resets/updates a shared JVM level logger instance (via

[GitHub] ant-ivy pull request #22: Fix transient test failures

2017-05-19 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #22: Fix transient test failures

2017-05-19 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/22 Looks like this didn't help. It failed again (passes locally): >> [junit] Running org.apache.ivy.plugins.circular.WarnCircularDependencyStrategyTest [junit] Tests run: 3, Fa

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/27 Fix IVY-1540 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies

[GitHub] ant-ivyde pull request #3: Update the year in copyright messages

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivyde/pull/3 Update the year in copyright messages The commit here updates the year in copyright messages. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] ant-ivyde pull request #2: Minor change to update the year in the NOTICE fil...

2017-05-23 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivyde/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivyde issue #4: Update the year in copyright messages

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivyde/pull/4 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-24 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/27 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-24 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/27 Fix IVY-1540 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies

[GitHub] ant-ivy pull request #30: Fix transient test failures

2017-05-24 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/30 Fix transient test failures The commit here fixes the transient test failures that we keep seeing in `WarnCircularDependencyStrategyTest`. More details about the fix are in this previous PR https

[GitHub] ant-ivy issue #22: Fix transient test failures

2017-05-24 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/22 That's a good find. Looking at that testcase now again, with this additional detail that you noted, I think the problem here is that the `AbstractLogCircularDependencyStrategy` ends up using

[GitHub] ant-ivyde pull request #3: Update the year in copyright messages

2017-05-23 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivyde/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivyde issue #3: Update the year in copyright messages

2017-05-23 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivyde/pull/3 Updating this PR didn't trigger it now. Will recreate a new PR and try --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant-ivyde pull request #4: Update the year in copyright messages

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivyde/pull/4 Update the year in copyright messages Updates the year in copyright messages. This PR is an attempt to get the Jenkins PR builds going and can be merged once that works. You can merge

[GitHub] ant-ivy pull request #23: Use the specified timeout for connections in Basic...

2017-05-20 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/23 Use the specified timeout for connections in BasicURLHandler The commit here fixes the `BasicURLHandler` to use the specified timeout for connection timeout. It also updates

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-22 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 I've now updated this PR to not focus on the usage of `:` in versions and instead test the FileUtil's method itself. --- If your project is set up for it, you can reply to this email and have

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-20 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 I think both me and Nicolas agree that this "fix" isn't going to solve the case where this and other similar characters can't be fully supported as long as we are using the module

[GitHub] ant-ivy pull request #24: Fix IVY-1555

2017-05-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/24 Fix IVY-1555 The commit here includes a fix and test case for the issue reported in https://issues.apache.org/jira/browse/IVY-1555 where the absence of a `optional` settings file included

[GitHub] ant-ivy pull request #25: Upgrade to latest Ant release (non-Java 8 one)

2017-05-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/25 Upgrade to latest Ant release (non-Java 8 one) The commit here upgrades the Ant dependencies to the latest released ones. A few notes about the dependencies: - `org.apache.ant:ant

[GitHub] ant-ivy pull request #26: Upgrade to latest JSCH versions

2017-05-21 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/26 Upgrade to latest JSCH versions The commit here upgrades the `jsch` library dependencies to the latest released versions. You can merge this pull request into a Git repository by running

[GitHub] ant-ivy issue #20: Fix IVY-1522

2017-05-21 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/20 >> So @jaikiran, would you consider rewrite the unit test to just test FileUtil.dissect ? Yes, certainly. I will update this PR with the testcase tomorrow. --- If your project is

[GitHub] ant-ivy pull request #34: Fix IVY-1528

2017-05-27 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/34 Fix IVY-1528 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1528 and includes a test case to verify the fix. With this fix, the `classifier` extra attribute

[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-28 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/27 I forgot to include a sample of how the circular dependency is now going to be reported in the dependency tree output. Here's a sample of it: ``` [ivy:dependencytree

[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/20 Fix IVY-1522 The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This PR also contains a test case to verify the fix

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/27 Fix IVY-1540 The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies

[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/27 Now that the transient failure fixes have been merged and the Jenkins PR jobs are working, going to reopen this to trigger a new run of Jenkins. --- If your project is set up for it, you can reply

[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request: https://github.com/apache/ant-ivy/pull/21 Fix IVY-1495 The commit here is a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the `ivysettings.xml` is being parsed

[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-25 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/21 Reopening this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at: https://github.com/apache/ant-ivy/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-18 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/20 Fix IVY-1522 The commit here contains a potential fix for the issue reported in https://issues.apache.org/jira/browse/IVY-1522. This PR also contains a test case to verify the fix

[GitHub] ant-ivyde pull request #2: Minor change to update the year in the NOTICE fil...

2017-05-23 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivyde/pull/2 Minor change to update the year in the NOTICE file Just a minor change to the NOTICE file to update the year. This is an attempt to get the Jenkins autmoated PR builds going. You can

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

2017-05-29 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/35 Use Java 7 as the minimum required Java version Now that the vote to upgrade the minimal required Java version has been passed[1], the commit here upgrades the version to Java 7. [1

[GitHub] ant-ivy issue #34: Fix IVY-1528

2017-05-29 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/34 >> we dont use @author Fixed - removed that tag. I will setup my IDE accordingly. >> TestXmlHelper -- if xPathExpression would be a String and the met

[GitHub] ant-ivy issue #34: Fix IVY-1528

2017-05-30 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/34 I used >> git fetch github pull/34/head:PR-34 >> git checkout PR-34 >> Some ideas? What does the output of: ```git status``` and then

[GitHub] ant-ivy pull request #37: Don't pollute the source lib folder during ivy ret...

2017-05-31 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/37 Don't pollute the source lib folder during ivy retrieval in test The `IvyRetrieveBuildFileTest` triggers a Ant project build during the test case and issues a `ivy:retrieve` through the build file

[GitHub] ant-ivy issue #36: Replace emma with jacoco

2017-05-31 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/36 >> I found out that JUnit tests polute run.classpath by placing an empty jar in /lib, which breaks eg javadoc. Any ideas which test may do that? I believe this PR https://github.com/

[GitHub] ant-ivy pull request #38: IVY-1475 Throw an explicit BuildException if cache...

2017-06-02 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/38 IVY-1475 Throw an explicit BuildException if cachefileset cannot determine a common base directory The commit here enhances the implementation of `cachefileset` task to throw an explicit

[GitHub] ant-ivy pull request #40: Fix regression in tutorials

2017-06-02 Thread jaikiran
GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/40 Fix regression in tutorials The commit here fixes some issues in tutorials, that went unnoticed in some of our recent changes. You can merge this pull request into a Git repository by running

  1   2   3   4   5   6   7   8   >