[ANNOUNCE] Apache Commons DBCP 2.12.0

2024-03-04 Thread Gary Gregory
The Apache Commons DBCP team is pleased to announce the release of Apache Commons DBCP 2.12.0. Apache Commons DBCP software implements Database Connection Pooling. This is a minor release, including bug fixes and enhancements. Commons DBCP requires Java 8 or above. The list of changes is here

Re: [VOTE] Release Apache Commons DBCP 2.12.0 based on RC1

2024-03-03 Thread Gary Gregory
s good, signatures look good. > > > On Feb 29, 2024, at 5:46 PM, Gary Gregory wrote: > > > > Hi All, > > > > We have fixed a few bugs and added some enhancements since Apache > > Commons DBCP 2.11.0 was released, so I would like to release Apache > > Commons

Re: [VOTE] Release Apache Commons DBCP 2.12.0 based on RC1

2024-03-02 Thread Rob Tompkins
+1 ran tests, site looks good, signatures look good. > On Feb 29, 2024, at 5:46 PM, Gary Gregory wrote: > > Hi All, > > We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.11.0 was released, so I would like to release Apache > Commons DBC

Re: [VOTE] Release Apache Commons DBCP 2.12.0 based on RC1

2024-03-02 Thread Phil Steitz
> We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.11.0 was released, so I would like to release Apache > Commons DBCP 2.12.0. > > Apache Commons DBCP 2.12.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/dbc

Re: [VOTE] Release Apache Commons DBCP 2.12.0 based on RC1

2024-03-01 Thread Gary Gregory
My +1 Gary On Thu, Feb 29, 2024 at 5:46 PM Gary Gregory wrote: > > Hi All, > > We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.11.0 was released, so I would like to release Apache > Commons DBCP 2.12.0. > > Apache Commons DBCP

Re: [VOTE] Release Apache Commons DBCP 2.12.0 based on RC1

2024-02-29 Thread Bruno Kinoshita
"5.15.0-97-generic", arch: "amd64", family: "unix" Release notes OK, dist area archive sigs OK, site reports OK. Thanks! On Thu, 29 Feb 2024 at 23:48, Gary Gregory wrote: > Hi All, > > We have fixed a few bugs and added some enhancements since Apache &g

[VOTE] Release Apache Commons DBCP 2.12.0 based on RC1

2024-02-29 Thread Gary Gregory
Hi All, We have fixed a few bugs and added some enhancements since Apache Commons DBCP 2.11.0 was released, so I would like to release Apache Commons DBCP 2.12.0. Apache Commons DBCP 2.12.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.12.0-RC1 (svn

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-13 Thread Phil Steitz
On Tue, Feb 13, 2024 at 1:03 PM Bernd Eckenfels wrote: > Phil Steitz wrote on 13. Feb 2024 20:46 (GMT +01:00): > > Thanks, Gary. I agree with everything below. I think it's best to just > > leave things as they are. > > If it’s plugable the project might not have to care, > But then how to fix

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-13 Thread Bernd Eckenfels
Phil Steitz wrote on 13. Feb 2024 20:46 (GMT +01:00): > Thanks, Gary. I agree with everything below. I think it's best to just > leave things as they are. If it’s plugable the project might not have to care, But then how to fix the reported problem? Do we have an idea what’s causing it? And a

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-13 Thread Phil Steitz
ause for whatever reason, is > reusable, but we throw it away. > > HTH, > Gary > > On Mon, Feb 12, 2024 at 2:42 PM Phil Steitz wrote: > > > > In DBCP-595, a change is suggested to force close connections when a > fatal > > SQL exception has occurred. As of

Re: [dbcp] Force close connections on fatal SQL Exceptions

2024-02-12 Thread Gary Gregory
r whatever reason, is reusable, but we throw it away. HTH, Gary On Mon, Feb 12, 2024 at 2:42 PM Phil Steitz wrote: > > In DBCP-595, a change is suggested to force close connections when a fatal > SQL exception has occurred. As of Version 2.2 of DBCP, fatal exceptions > are tracked and

Re: [DBCP] Support request boundaries

2024-02-12 Thread Phil Steitz
and not too > difficult to me. > > a) do nothing > b) add a configuration property that makes dbcp send the messages on > activate/passivate or borrow/return (need to decide which) > After more research and listening to comments, I think this is the best approach, with beginReques

[dbcp] Force close connections on fatal SQL Exceptions

2024-02-12 Thread Phil Steitz
In DBCP-595, a change is suggested to force close connections when a fatal SQL exception has occurred. As of Version 2.2 of DBCP, fatal exceptions are tracked and the fastFailValidation property can be set to fast fail validations when a fatal exception has occurred on a connection. This change

[DBCP] Support request boundaries

2024-01-23 Thread Phil Steitz
is safe for all implementations may be tricky. Based on above, the following options seem reasonable and not too difficult to me. a) do nothing b) add a configuration property that makes dbcp send the messages on activate/passivate or borrow/return (need to decide which) c) add another configuration

[RESULT][VOTE] Release Apache Commons DBCP 2.11.0 based on RC1

2023-10-28 Thread Gary Gregory
n: "5.15.0-87-generic", arch: "amd64", family: > >> "unix" > >> > >>> On Mon, 23 Oct 2023 at 19:55, Gary Gregory wrote: > >>> > >>> We have fixed a few bugs and added some enhancements since Apache > >>&

Re: [VOTE] Release Apache Commons DBCP 2.11.0 based on RC1

2023-10-28 Thread Rob Tompkins
ot;linux", version: "5.15.0-87-generic", arch: "amd64", family: >> "unix" >> >>> On Mon, 23 Oct 2023 at 19:55, Gary Gregory wrote: >>> >>> We have fixed a few bugs and added some enhancements since Apache >>> Commons

Re: [VOTE] Release Apache Commons DBCP 2.11.0 based on RC1

2023-10-27 Thread Gary Gregory
y Gregory wrote: > > > We have fixed a few bugs and added some enhancements since Apache > > Commons DBCP 2.9.0 was released, so I would like to release Apache > > Commons DBCP 2.11.0. > > > > Apache Commons DBCP 2.11.0 RC1 is available for review here: > >

Re: [VOTE] Release Apache Commons DBCP 2.11.0 based on RC1

2023-10-25 Thread Bruno Kinoshita
encoding: UTF-8 OS name: "linux", version: "5.15.0-87-generic", arch: "amd64", family: "unix" On Mon, 23 Oct 2023 at 19:55, Gary Gregory wrote: > We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.9.0 was released, so I woul

[VOTE] Release Apache Commons DBCP 2.11.0 based on RC1

2023-10-23 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons DBCP 2.9.0 was released, so I would like to release Apache Commons DBCP 2.11.0. Apache Commons DBCP 2.11.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.11.0-RC1 (svn revision

[ANNOUNCEMENT] Apache Commons DBCP 2.10.0

2023-09-03 Thread Gary Gregory
The Apache Commons DBCP team is pleased to announce the release of Apache Commons DBCP 2.10.0. Apache Commons DBCP software implements Database Connection Pooling. This is a minor release, including bug fixes and enhancements: https://commons.apache.org/proper/commons-dbcp/changes-report.html

[RESULT][VOTE] Release Apache Commons DBCP 2.10.0 based on RC1

2023-09-03 Thread Gary Gregory
ixed a few bugs and added some enhancements since Apache >> Commons DBCP 2.9.0 was released, so I would like to release Apache >> Commons DBCP 2.10.0. >> >> Apache Commons DBCP 2.10.0 RC1 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/dbcp/

Re: [VOTE] Release Apache Commons DBCP 2.10.0 based on RC1

2023-09-03 Thread Gary Gregory
My +1 Gary On Mon, Aug 28, 2023 at 9:34 AM Gary Gregory wrote: > We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.9.0 was released, so I would like to release Apache > Commons DBCP 2.10.0. > > Apache Commons DBCP 2.10.0 RC1 is available

Re: [VOTE] Release Apache Commons DBCP 2.10.0 based on RC1

2023-09-02 Thread Rob Tompkins
+1 signatures good, reports good mvn clean test package install works nit mvn site doesn’t work for me on my machine > On Aug 28, 2023, at 9:34 AM, Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.9.0 was released, so

Re: [VOTE] Release Apache Commons DBCP 2.10.0 based on RC1

2023-09-01 Thread Rob Tompkins
will look at this, this evening. -Rob > On Sep 1, 2023, at 10:59 AM, Henri Biestro wrote: > >  > [ +1] Release these artifacts > > Built on: > 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; > root:xnu-8796.121.3~7/RELEASE_ARM64_T6000 arm64 > > With: > openjdk version

Re: [VOTE] Release Apache Commons DBCP 2.10.0 based on RC1

2023-09-01 Thread Henri Biestro
[ +1] Release these artifacts Built on: 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000 arm64 With: openjdk version "1.8.0_352" OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build 1.8.0_352-b08) OpenJDK 64-Bit

[VOTE] Release Apache Commons DBCP 2.10.0 based on RC1

2023-08-28 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons DBCP 2.9.0 was released, so I would like to release Apache Commons DBCP 2.10.0. Apache Commons DBCP 2.10.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.10.0-RC1 (svn revision

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-06-19 Thread Romain Manni-Bucau
@Emmanuel: tomee does not use tomcat-dbcp, it facade any JDBC pool library with its own code so any managed package usage is really legacy since ~10 years. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-06-19 Thread Richard Zowalla
ain Manni-Bucau wrote: > > > TomEE can drop managed package legacy dependency now, was kept > > while the > > replacement was in test in 1.x version but makes years it is no > > more > > relevant and no more the default (since we switched to tomcat- > > jdbc)

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-06-19 Thread Emmanuel Bourg
On 26/05/2023 12:20, Romain Manni-Bucau wrote: TomEE can drop managed package legacy dependency now, was kept while the replacement was in test in 1.x version but makes years it is no more relevant and no more the default (since we switched to tomcat-jdbc). So no big deal if dbcp wants to drop

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-05-26 Thread Richard Zowalla
dency now, was kept while > the > replacement was in test in 1.x version but makes years it is no more > relevant and no more the default (since we switched to tomcat-jdbc). > So no big deal if dbcp wants to drop it on TomEE side IMHO. > > Romain Manni-Bucau > @rmannibucau <https:/

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-05-26 Thread Romain Manni-Bucau
Hi Richard, TomEE can drop managed package legacy dependency now, was kept while the replacement was in test in 1.x version but makes years it is no more relevant and no more the default (since we switched to tomcat-jdbc). So no big deal if dbcp wants to drop it on TomEE side IMHO. Romain Manni

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-05-26 Thread Richard Zowalla
heoretical issue. Gruß Richard Am Freitag, dem 26.05.2023 um 12:08 +0200 schrieb Emmanuel Bourg: > Le 11/05/2023 à 15:56, Richard Zowalla a écrit : > > Hi, > > > > do we have any updates? > > > > How can I help to get a dbcp version supporting Jakarta names

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-05-26 Thread Emmanuel Bourg
Le 11/05/2023 à 15:56, Richard Zowalla a écrit : Hi, do we have any updates? How can I help to get a dbcp version supporting Jakarta namespace? Emmanuel outlined a possible appraoch. How can we move forward with it? I'm tempted to merge the dual-javax-jakarta branch, but Romain's comment

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-05-11 Thread Richard Zowalla
Hi, do we have any updates? How can I help to get a dbcp version supporting Jakarta namespace? Emmanuel outlined a possible appraoch. How can we move forward with it? Thanks & Gruß Richard On 2022/12/30 12:52:45 Richard Zowalla wrote: > Thanks a lot, Emmanuel!  > > It loo

Re: [commons-dbcp] branch master updated: Correct a regression introduced in d69e6a5

2023-03-08 Thread Gary Gregory
Shouldn't we have a unit test that validates the expected names to avoid this type of issue? Gary On Wed, Mar 8, 2023 at 8:18 AM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-01-19 Thread Richard Zowalla
t; > > > > > Thanks, > > > Regards > > > JB > > > > > > On Sat, Dec 31, 2022 at 12:15 PM Emmanuel Bourg < > > > ebo...@apache.org> > > > wrote: > > > > I've experimented with another approach, a single ver

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-01-19 Thread Gary Gregory
gle version > > > supporting both javax.transaction and jakarta.transaction: > > > > > > https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta > > > > > > The only classes using javax.transaction are in the > > > org.apache.commons.dbcp2.m

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-01-19 Thread Richard Zowalla
I've experimented with another approach, a single version > > supporting both javax.transaction and jakarta.transaction: > > > > https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta > > > > The only classes using javax.transaction are in the > > or

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2023-01-01 Thread Jean-Baptiste Onofré
It looks good to me. Thanks, Regards JB On Sat, Dec 31, 2022 at 12:15 PM Emmanuel Bourg wrote: > > I've experimented with another approach, a single version > supporting both javax.transaction and jakarta.transaction: > > https://github.com/ebourg/commons-dbcp/tree/dua

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-31 Thread Romain Manni-Bucau
I've experimented with another approach, a single version > > supporting both javax.transaction and jakarta.transaction: > > > > https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta > > > > The only classes using javax.transaction are in the > > or

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-31 Thread Richard Zowalla
Emmanuel Bourg: > I've experimented with another approach, a single version > supporting both javax.transaction and jakarta.transaction: > > https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta > > The only classes using javax.transaction are in the > org.apache.

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-31 Thread Emmanuel Bourg
I've experimented with another approach, a single version supporting both javax.transaction and jakarta.transaction: https://github.com/ebourg/commons-dbcp/tree/dual-javax-jakarta The only classes using javax.transaction are in the org.apache.commons.dbcp2.managed package. This package

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-30 Thread Richard Zowalla
Thanks a lot, Emmanuel!  It looks good to me! Gruß Richard Am Donnerstag, dem 29.12.2022 um 22:02 +0100 schrieb Emmanuel Bourg: > Thank you, it works perfectly now. > > I've pushed the changes to: > > https://github.com/ebourg/commons-dbcp/tree/jakarta > >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-30 Thread Romain Manni-Bucau
Le jeu. 29 déc. 2022 à 22:02, Emmanuel Bourg a écrit : > Thank you, it works perfectly now. > > I've pushed the changes to: > > https://github.com/ebourg/commons-dbcp/tree/jakarta  > > Comments are welcome before I create a dbcp3 branch on the ASF repository. >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-29 Thread Emmanuel Bourg
Thank you, it works perfectly now. I've pushed the changes to: https://github.com/ebourg/commons-dbcp/tree/jakarta Comments are welcome before I create a dbcp3 branch on the ASF repository. I think the API should be kept identical to dbcp2 to ease porting changes and facilitate

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-28 Thread Romain Manni-Bucau
Hi Emmanuel, You have https://repo1.maven.org/maven2/org/apache/geronimo/components/geronimo-transaction/3.1.5/geronimo-transaction-3.1.5-jakarta.jar which is usable if you exclude transitive deps. Romain Manni-Bucau @rmannibucau | Blog

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-28 Thread Emmanuel Bourg
Thank you for the pointers, the Narayana and JBoss artifacts look good, but I haven't found a replacement for geronimo-transaction. I tried replacing the Geronimo Transaction implementation with the one from Narayana but got 4 test failures. I'll try to process the geronimo-transaction jar at

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-27 Thread Romain Manni-Bucau
t; > > Am 27. Dezember 2022 22:54:40 MEZ schrieb Romain Manni-Bucau < > rmannibu...@gmail.com>: >> >> @Emmanuel Bourg you can use jakarta artifacts directly >> for dbcp or tomee ones which provides jakarta namespace. >> >> Le mar. 27 déc. 2022 à 22:2

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-27 Thread Richard Zowalla
artifact. Gruß Richard Am 27. Dezember 2022 22:54:40 MEZ schrieb Romain Manni-Bucau : >@Emmanuel Bourg you can use jakarta artifacts directly >for dbcp or tomee ones which provides jakarta namespace. > >Le mar. 27 déc. 2022 à 22:28, Emmanuel Bourg a écrit : > >> I t

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-27 Thread Gary Gregory
replace javax with jakarta in DBCP, the less trivial part is > to find a replacement for the test dependencies: > - org.apache.geronimo.modules:geronimo-transaction > - org.jboss.narayana.jta:narayana-jta > - and maybe org.jboss:jboss-transaction-spi > > Or we disable the transacti

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-27 Thread Romain Manni-Bucau
@Emmanuel Bourg you can use jakarta artifacts directly for dbcp or tomee ones which provides jakarta namespace. Le mar. 27 déc. 2022 à 22:28, Emmanuel Bourg a écrit : > I tried to replace javax with jakarta in DBCP, the less trivial part is > to find a replacement for the test depend

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-27 Thread Emmanuel Bourg
I tried to replace javax with jakarta in DBCP, the less trivial part is to find a replacement for the test dependencies: - org.apache.geronimo.modules:geronimo-transaction - org.jboss.narayana.jta:narayana-jta - and maybe org.jboss:jboss-transaction-spi Or we disable the transaction tests

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-19 Thread Richard Zowalla
of adoption and I guess we would be closer to my point > that > dbcp will never met jakarta as of today where hikaricp and tomcat- > jdbc are > used by default when upgrading stacks since jakarta adoption will > accelerate next year with spring 6 hard move and related migrations. > If it

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-19 Thread Romain Manni-Bucau
to get 2 out, 3-4 months to get 3 out it means we loose one more year in terms of adoption and I guess we would be closer to my point that dbcp will never met jakarta as of today where hikaricp and tomcat-jdbc are used by default when upgrading stacks since jakarta adoption will accelerate next year

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-19 Thread Gary Gregory
08:57 Romain Manni-Bucau wrote: > > Le dim. 18 déc. 2022 à 12:04, Gary Gregory a > > écrit : > > > > > What's the rush? Commons has never been on the bleeding edge of anything. > > > > > > > > > Java and EE release rates changed - as well as spring

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-19 Thread Richard Zowalla
ommons > sticks to the old one it is harder (impossible) to use directly. > Today dbcp is either forked/relocated or abandonned for that reason so > guess we should either adapt the release rate and testing coverage to these > changes or freeze the project if it is no more matching end users

Re: Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-19 Thread Romain Manni-Bucau
m)> wrote: > > Sure. Sounds like a plan :) > > > > Am 17. Dezember 2022 22:06:48 MEZ schrieb Gary Gregory < > garydgreg...@gmail.com (mailto:garydgreg...@gmail.com)>: > > > I think we should wait for a little while: I'd want to release current > code > > &g

Re: Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-19 Thread Eric Bresie
> Sure. Sounds like a plan :) > > Am 17. Dezember 2022 22:06:48 MEZ schrieb Gary Gregory > mailto:garydgreg...@gmail.com)>: > > I think we should wait for a little while: I'd want to release current code > > from git for Commons Pool, then DBCP (which sits on top of

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-18 Thread Romain Manni-Bucau
Le dim. 18 déc. 2022 à 12:04, Gary Gregory a écrit : > What's the rush? Commons has never been on the bleeding edge of anything. > Java and EE release rates changed - as well as spring baseline. If commons sticks to the old one it is harder (impossible) to use directly. Today dbcp is

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-18 Thread Gary Gregory
ng to pick up for a while ;-) > > > > Gary > > > > On Sat, Dec 17, 2022, 18:06 Arun Avanathan > > wrote: > > > > > Gary - if we have a ticket to upgrade DBCP to java 11, I can take it > up. > > > > > > > On Dec 17, 2022, at 1:09

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-18 Thread Romain Manni-Bucau
Gregory a écrit : > Hi Arun, > > There's not going to be anything to pick up for a while ;-) > > Gary > > On Sat, Dec 17, 2022, 18:06 Arun Avanathan > wrote: > > > Gary - if we have a ticket to upgrade DBCP to java 11, I can take it up. > > > > > On Dec

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-17 Thread Gary Gregory
Hi Arun, There's not going to be anything to pick up for a while ;-) Gary On Sat, Dec 17, 2022, 18:06 Arun Avanathan wrote: > Gary - if we have a ticket to upgrade DBCP to java 11, I can take it up. > > > On Dec 17, 2022, at 1:09 PM, Richard Zowalla > wrote: > > > >

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-17 Thread Arun Avanathan
Gary - if we have a ticket to upgrade DBCP to java 11, I can take it up. > On Dec 17, 2022, at 1:09 PM, Richard Zowalla wrote: > > Sure. Sounds like a plan :) > > Am 17. Dezember 2022 22:06:48 MEZ schrieb Gary Gregory > : >> I think we should wait for a little wh

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-17 Thread Richard Zowalla
Sure. Sounds like a plan :) Am 17. Dezember 2022 22:06:48 MEZ schrieb Gary Gregory : >I think we should wait for a little while: I'd want to release current code >from git for Commons Pool, then DBCP (which sits on top of Pool), make sure >all is well, then see about going to DBCP 3,

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-17 Thread Gary Gregory
I think we should wait for a little while: I'd want to release current code from git for Commons Pool, then DBCP (which sits on top of Pool), make sure all is well, then see about going to DBCP 3, on Java 8 for now but considering Java 11 maybe. Do consider that the Commons community is small

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-17 Thread Richard Zowalla
For DBCP, it basically boils down to BasicManagedDataSource.java DataSourceXAConnectionFactory.java LocalXAConnectionFactory.java SynchronizationAdapter.java TransactionContext.java TransactionRegistry.java Looking at these classes, the move to jakarta definitley affects binary compatibility

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-16 Thread Romain Manni-Bucau
If not done in new classes (both can live in the same lib technically), sadly yes. Le ven. 16 déc. 2022 à 20:14, Richard Zowalla a écrit : > Thanks for your replies. > > I guess, that switching the namespace leads to binary incompatibility (If > I take the definition from [1]). I cannot drop it

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-16 Thread Richard Zowalla
Thanks for your replies. I guess, that switching the namespace leads to binary incompatibility (If I take the definition from [1]). I cannot drop it in a running JVM / app and expect no issues with it as the related APIs are breaking namespace changes (at least at runtime if they aren't

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-16 Thread Mark Thomas
On 16/12/2022 13:24, Gary Gregory wrote: Thank you Richard for starting this thread. My view is simpler perhaps: I would not make this about the javax vs Jakarta namespaces. I don't want to double the numbers of jars we produce from the same branch for affected components as one of the scheme

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-16 Thread Gary Gregory
and making any other changes with seem reasonable. Gary On Fri, Dec 16, 2022, 04:35 Richard Zowalla wrote: > Hi all, > > based on the discussion [1] for DBCP, I wanted to start a discussion > whether and how the Apache Commons project might/want to support the > Jakarta namespace chan

Re: Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-16 Thread Romain Manni-Bucau
ithub.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le ven. 16 déc. 2022 à 10:35, Richard Zowalla a écrit : > Hi all, > > based on the discussion [1] for DBCP, I w

Jakarta namespace in commons like dbcp - thoughts / ideas?

2022-12-16 Thread Richard Zowalla
Hi all, based on the discussion [1] for DBCP, I wanted to start a discussion whether and how the Apache Commons project might/want to support the Jakarta namespace changes. I know, that not all commons projects are impacted by the namespaces change, but we should make sure, that users can use

Re: [commons-dbcp] branch master updated: org.apache.commons.dbcp2.datasources.UserPassKey should be Serializable (SpotBugs)

2022-07-04 Thread Gary Gregory
Could be, I see that my git autocrlf setting is false for that repo on my Windows box. Gary On Mon, Jul 4, 2022, 05:32 Mark Thomas wrote: > Gary, > > A couple of your DBCP commits seem to be much bigger than they should > be. Is there some sort of line ending issue going

Re: [commons-dbcp] branch master updated: LifetimeExceededException should extend SQLException.

2022-07-04 Thread Gary Gregory
Fixed, TY! Gary On Mon, Jul 4, 2022, 06:05 Mark Thomas wrote: > On 03/07/2022 15:37, ggreg...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregory pushed a commit to branch master > > in repository

Re: [DBCP] archive versions prior to Java 7

2022-03-15 Thread Bruno Kinoshita
+1 to archiving <7 versions. Thanks On Wed, 16 Mar 2022, 00:33 Gary Gregory, wrote: > Hi Sebb, > > I don't plan on supporting pre-Java 8 versions, others may feel different > of course. I say: go for it. > > Gary > > On Tue, Mar 15, 2022, 07:06 sebb wrote: > &g

Re: [DBCP] archive versions prior to Java 7

2022-03-15 Thread Gary Gregory
Hi Sebb, I don't plan on supporting pre-Java 8 versions, others may feel different of course. I say: go for it. Gary On Tue, Mar 15, 2022, 07:06 sebb wrote: > The DBCP versions for Java 6 and earlier are still published via the > mirrors. > > Do we still support them? > &g

[DBCP] archive versions prior to Java 7

2022-03-15 Thread sebb
The DBCP versions for Java 6 and earlier are still published via the mirrors. Do we still support them? If not, I think they should be archived and documented as such. That would leave versions for JDBC 4.1 (Java 7) and JDBC 4.2 (Java 8). [The web page needs tidying anyway to remove references

Re: [commons-dbcp] branch master updated: Update MXBean for use of Duration with BasicDataSource

2022-01-05 Thread Mark Thomas
XxxxMXBean interfaces are (arguably) a special case since they exist to expose methods via JMX. I wouldn't expect any users of DBCP to be implementing this interface. If we think there is a real risk that users have implemented this interface (for what use case?) then I can add default

Re: [commons-dbcp] branch master updated: Update MXBean for use of Duration with BasicDataSource

2022-01-05 Thread Gary Gregory
If you add methods to an existing interface, this will break binary compatibility unless you add them as default methods. Or am i missing something? Gary On Wed, Jan 5, 2022, 14:10 wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch

Re: [commons-dbcp] branch master updated: Trivial format fix. Use consistent formatting for all classes.

2021-09-02 Thread Mark Thomas
for DBCP although it wasn't far off a 50/50 split (maybe 55/45). I made the same change to Pool where only 1 file had the (arguably unnecessary) space. Mark - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[ANNOUNCE] Apache Commons DBCP 2.9.0

2021-08-21 Thread Gary Gregory
The Apache Commons DBCP team is pleased to announce the release of Apache Apache Commons DBCP 2.9.0. Apache Commons DBCP software implements Database Connection Pooling. This is a minor release, including bug fixes and enhancements. For complete information on Apache Commons DBCP, including

[ANNOUNCE] Apache Commons DBCP 2.9.0

2021-08-04 Thread Gary Gregory
The Apache Commons DBCP team is pleased to announce the release of Apache Commons DBCP 2.9.0. Apache Commons DBCP software implements Database Connection Pooling. This is a minor release, including bug fixes and enhancements. Changes in this version: https://commons.apache.org/proper/commons

Re: [VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-08-03 Thread Gary Gregory
gt;> -Rob >> >> >> >> > On Jul 31, 2021, at 11:19 AM, Gary Gregory >> wrote: >> > >> > We have fixed a few bugs and added some enhancements since Apache >> > Commons DBCP 2.8.0 was released, so I would like to release Apache >> >

Re: [VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-08-03 Thread Gary Gregory
> On Jul 31, 2021, at 11:19 AM, Gary Gregory > wrote: > > > > We have fixed a few bugs and added some enhancements since Apache > > Commons DBCP 2.8.0 was released, so I would like to release Apache > > Commons DBCP 2.9.0. > > > > Apache Commons DBCP 2.9.0 R

Re: [VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-08-03 Thread Rob Tompkins
nts since Apache > Commons DBCP 2.8.0 was released, so I would like to release Apache > Commons DBCP 2.9.0. > > Apache Commons DBCP 2.9.0 RC1 is available for review here: >https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1 (svn > revision 49104) > > The Git

Re: [VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-08-01 Thread Bruno P. Kinoshita
rch: "amd64", family: "unix" Site reports look good. Thanks! Bruno On Sunday, 1 August 2021, 3:19:42 am NZST, Gary Gregory wrote: We have fixed a few bugs and added some enhancements since Apache Commons DBCP 2.8.0 was released, so I would like to release Apache

Re: [VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-08-01 Thread Arturo Bernal
5c21c65bdfed0f71a2f2ada8b84da59348c4c5d) > Maven home: /usr/local/Cellar/maven/3.8.1/libexec > Java version: 17-ea, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac o

Re: [VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-07-31 Thread Matt Sicker
86_64", family: "mac" On Sat, Jul 31, 2021 at 10:19 AM Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons DBCP 2.8.0 was released, so I would like to release Apache > Commons DBCP 2.9.0. > > Apache Commons DBCP 2.9.

[VOTE] Release Apache Commons DBCP 2.9.0 based on RC1

2021-07-31 Thread Gary Gregory
We have fixed a few bugs and added some enhancements since Apache Commons DBCP 2.8.0 was released, so I would like to release Apache Commons DBCP 2.9.0. Apache Commons DBCP 2.9.0 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp/2.9.0-RC1 (svn revision

Re: [DBCP] TestSynchronizationOrder failure, random or bug

2021-01-03 Thread Florent Guillaume
Here it is: https://github.com/apache/commons-dbcp/pull/84 associated to ticket: https://issues.apache.org/jira/browse/DBCP-569 Florent On Mon, Jan 4, 2021 at 12:24 AM Gary Gregory wrote: > On Sat, Jan 2, 2021 at 2:39 PM Florent Guillaume > wrote: > > > Hi Gary, > > &

Re: [DBCP] TestSynchronizationOrder failure, random or bug

2021-01-03 Thread Gary Gregory
Gary Gregory > wrote: > > > Hi All: > > > > I just saw on > > > > > https://github.com/apache/commons-dbcp/runs/1622526568?check_suite_focus=true > > > > [INFO] Running org.apache.commons.dbcp2.managed.TestSynchronizationOrd

Re: [DBCP] TestSynchronizationOrder failure, random or bug

2021-01-02 Thread Florent Guillaume
. Florent On Tue, Dec 29, 2020 at 7:56 PM Gary Gregory wrote: > Hi All: > > I just saw on > > https://github.com/apache/commons-dbcp/runs/1622526568?check_suite_focus=true > > [INFO] Running org.apache.commons.dbcp2.managed.TestSynchronizationOrder > Error: Tests run: 2

[DBCP] TestSynchronizationOrder failure, random or bug

2020-12-29 Thread Gary Gregory
Hi All: I just saw on https://github.com/apache/commons-dbcp/runs/1622526568?check_suite_focus=true [INFO] Running org.apache.commons.dbcp2.managed.TestSynchronizationOrder Error: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.088 s <<< FAILURE! - in org.apache.comm

Re: [DBCP] ManagedConnection must clear its cached state after transaction completes

2020-12-26 Thread Florent Guillaume
ng to happen. > > Gary > > On Tue, Dec 8, 2020 at 7:19 PM Florent Guillaume > wrote: > > > Hi, > > > > A few weeks ago I opened the ticket > > https://issues.apache.org/jira/browse/DBCP-568 (ManagedConnection must > > clear its cached state after transaction

Re: [DBCP] ManagedConnection must clear its cached state after transaction completes

2020-12-10 Thread Gary Gregory
s.apache.org/jira/browse/DBCP-568 (ManagedConnection must > clear its cached state after transaction completes) > with an associated proposed fix at > https://github.com/apache/commons-dbcp/pull/75. > Would anyone be interested in reviewing this? > > Thanks, > Florent &g

[DBCP] ManagedConnection must clear its cached state after transaction completes

2020-12-08 Thread Florent Guillaume
Hi, A few weeks ago I opened the ticket https://issues.apache.org/jira/browse/DBCP-568 (ManagedConnection must clear its cached state after transaction completes) with an associated proposed fix at https://github.com/apache/commons-dbcp/pull/75. Would anyone be interested in reviewing

Re: [commons-dbcp] 03/09: Use for-each loops

2020-12-04 Thread Phil Steitz
First, many thanks for the cleanup work. One thing to bear in mind for the loop changes is that in some cases the underlying collections may be changing as the loops progress. In theory, unit tests should pick up any problems introduced, but we should look carefully at this. Phil On

Re: [dbcp][pool] Use abort instead of close for abandoned connections?

2020-10-04 Thread Gary Gregory
Reusing this thread to note FTR that a new version of POOL is out and that a DBCP PR based of the new POOL is in progress... Gary On Wed, Sep 23, 2020, 19:28 Gary Gregory wrote: > On Wed, Sep 23, 2020 at 6:31 PM Phil Steitz wrote: > >> >> On 9/23/20 2:57 PM, Gary Gregory wr

Re: [ANNOUNCE] Apache Commons DBCP 2.8.0

2020-09-28 Thread sebb
since md5 and sha1 are frowned upon anyway these days. > > > > The existing hashes are sha256 - no point replacing these with sha512. > > > > > Gary > > > > > > > > > > > > > > On Fri, 25 Sep 2020 at 17:02, sebb wrote: >

Re: [ANNOUNCE] Apache Commons DBCP 2.8.0

2020-09-28 Thread Gary Gregory
1 are frowned upon anyway these days. > > The existing hashes are sha256 - no point replacing these with sha512. > > > Gary > > > > > > > > > > On Fri, 25 Sep 2020 at 17:02, sebb wrote: > > > > > > > > There's an issue with https://commo

  1   2   3   4   5   6   7   8   9   10   >