GitHub user khmarbaise opened a pull request:
https://github.com/apache/maven-3/pull/5
[MNG-5245] Update maven plugin versions
- components.xml
- maven-clean-plugin up to 2.5
- maven-site-plugin up to 3.1
- default-bindings.xml
- maven-install-plugin up to 2.4
Github user khmarbaise closed the pull request at:
https://github.com/apache/maven-3/pull/5
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
GitHub user khmarbaise opened a pull request:
https://github.com/apache/maven-enforcer/pull/7
[MENFORCER-169]
- Added unit test for RequireActiveProfile
- Support of all option reactivated based on unit test.
- Added documentation part and fixed link in index.apt.vm
GitHub user khmarbaise opened a pull request:
https://github.com/apache/maven-enforcer/pull/8
[MENFORCER-170|
- Refactored test code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khmarbaise/maven-enforcer menforcer-170
GitHub user khmarbaise opened a pull request:
https://github.com/apache/maven-enforcer/pull/9
[MENFORCER-171]
- Added doc for requireEnvironmentVariable and link
from index.apt page.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user khmarbaise closed the pull request at:
https://github.com/apache/maven-enforcer/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khmarbaise closed the pull request at:
https://github.com/apache/maven-enforcer/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khmarbaise closed the pull request at:
https://github.com/apache/maven-enforcer/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/37#issuecomment-75376033
I would vote +1 for this ...;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/41#issuecomment-99639382
Thanks for the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/48#issuecomment-99632511
Thanks for the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/47#issuecomment-118945749
Integrated. Thanks for fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/75#issuecomment-168306169
First i see your setup as wrong..cause you use modules multiple times
within the reactor (Apart from using `..` which is
simply not needed`). What i don't understand
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/60#issuecomment-167972348
The problem is simply related to using the version `0.0.2-SNAPSHOT` in
foo-business instead of `0.0.3-SNASPHOT` as parent version which will never
work
Github user khmarbaise commented on the pull request:
https://github.com/apache/maven/pull/60#issuecomment-167975254
So we are talking about something completely different. I have cloned the
given repository `https://github.com/kilokahn/maven-testers/` and i can't find
a definition
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/89
Ok If you remove them and compiled Maven you tried to build a simple
project with that compiled Maven version?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user khmarbaise commented on a diff in the pull request:
https://github.com/apache/maven/pull/88#discussion_r71406374
--- Diff:
maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java
---
@@ -56,5 +56,26 @@ public void
Github user khmarbaise commented on a diff in the pull request:
https://github.com/apache/maven/pull/88#discussion_r71401238
--- Diff:
maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java
---
@@ -56,5 +56,26 @@ public void
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/88
The @Test (expected =...) approach has one drawback, cause you can't check
the message of the exceptionWould be great...
---
If your project is set up for it, you can reply to this email
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/89
I meant that you should try to compile an example project with the created
Maven Core version? I don't meant you should build Maven core itself...
---
If your project is set up for it, you can
Github user khmarbaise commented on a diff in the pull request:
https://github.com/apache/maven/pull/88#discussion_r71971452
--- Diff:
maven-model-builder/src/test/resources/poms/factory/complexEmptyAndMissing.xml
---
@@ -31,21 +31,5 @@
activated-1
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/109
Please mention the JIRA issue in your commit message like this:
```
[MNG-6196]Â ...
```
otherwise it's hard to follow changes in history...also updating the JIRA
issue title would
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/106
Hi,
has been fixed in the meantime. Thanks for your PR...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/111
This pull request has been integrated into maven core. Thanks for your
support. Please close this pull request.
---
If your project is set up for it, you can reply to this email and have your
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/112
If you will take some time it's not a problem...the PR will be kept here
for a long time until you will close it yourself ..so you can be patient and
take the time you need...no hurry needed
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/112
It would be great if you could do that, cause it should be honoured to
those who found the bug(s)...If I can support you please ask how?
---
If your project is set up for it, you can reply
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/106
Can you please close that pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/111
If you add the JIRA ticket this PR is automatically added to the JIRA
ticket...Thanks for this..
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/112
First thanks for your pull request but it is really needed that you open a
[JIRA ticket ](issues.apache.org/jira/browse/MNG) and furthermore it would be
great if you could offer some unit tests
Github user khmarbaise commented on a diff in the pull request:
https://github.com/apache/maven/pull/119#discussion_r117611970
--- Diff:
maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java
---
@@ -411,14 +411,19 @@ public void
Github user khmarbaise commented on a diff in the pull request:
https://github.com/apache/maven/pull/119#discussion_r117611940
--- Diff:
maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java
---
@@ -604,17 +609,21 @@ public void
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/121
I have merged the pull request to Maven master. So you can close the pull
request here on GitHub. Thanks for our help.
---
If your project is set up for it, you can reply to this email and have
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/119
Sorry...Can please make the PR new based on the current master of the
apache-maven, cause I didn't realized that this PR must be done before the
other...Thanks in advance...
---
If your project
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/121
Please make a complete commit message with reference to the appropriate
ticket.
```
[MNG-6206] display deprecation build warning in case when dependencies use
metaversions (LATEST
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/119
Could you make a real commit log message like:
```
[MNG-6207] Create WARNINGs in case of using system scope
If needed more description/explanations here.
```
Otherwise I need
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/123
First build has failed based on [violated checkstyle
rules](https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6207/1/console).
So best is before you open a pull
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/123
Second build after fixing the checkstyle issues has worked. Integration
into master done. You can close the pull request. Thank for your help to make
Maven better.
---
If your project is set up
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/112
If you like to get your pull request being integrated it is required to
open an [issue on jira](https://issues.apache.org/jira/browse/MNG) and change
your commit message accordingly. Something
38 matches
Mail list logo
