Re: bug in smsc_smpp.c login failure

2003-02-27 Thread Stipe Tolj
Alan McNatty wrote: On Thu, 2003-02-27 at 18:54, Nisan Bloch wrote: Hi At 03:46 PM 2/27/03 +1300, Alan McNatty wrote: Hello, found that if I type in the smpp password incorrectly kannel loops forever trying to reconnect. ie: -1 from me In the current form this path will not

Re: bug in smsc_smpp.c login failure

2003-02-27 Thread Alexander Malysh
Hi, what about attached patch ? Am Donnerstag, 27. Februar 2003 10:30 schrieb Stipe Tolj: Alan McNatty wrote: On Thu, 2003-02-27 at 18:54, Nisan Bloch wrote: Hi At 03:46 PM 2/27/03 +1300, Alan McNatty wrote: Hello, found that if I type in the smpp password incorrectly

Re: bug in smsc_smpp.c login failure

2003-02-27 Thread Nisan Bloch
hi yeah.. great +1 nisan At 11:27 AM 2/27/03 +0100, Alexander Malysh wrote: Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline X-MIME-Autoconverted: from 8bit to quoted-printable by mail-in-01.piro.net id LAA28081 Hi, what about attached patch ? Am Donnerstag, 27.

bug in smsc_smpp.c login failure

2003-02-26 Thread Alan McNatty
Hello, found that if I type in the smpp password incorrectly kannel loops forever trying to reconnect. ie: [6] DEBUG: SMPP PDU 0x80f3a18 dump: [6] DEBUG: type_name: bind_receiver_resp [6] DEBUG: command_id: 2147483649 = 0x8001 [6] DEBUG: command_status: 14 = 0x000e [6] DEBUG:

Re: bug in smsc_smpp.c login failure

2003-02-26 Thread Nisan Bloch
Hi At 03:46 PM 2/27/03 +1300, Alan McNatty wrote: Hello, found that if I type in the smpp password incorrectly kannel loops forever trying to reconnect. ie: -1 from me In the current form this path will not allow any retries for any sort of bind error. eg what happens if there is a temporary

Re: bug in smsc_smpp.c login failure

2003-02-26 Thread Alan McNatty
On Thu, 2003-02-27 at 18:54, Nisan Bloch wrote: Hi At 03:46 PM 2/27/03 +1300, Alan McNatty wrote: Hello, found that if I type in the smpp password incorrectly kannel loops forever trying to reconnect. ie: -1 from me In the current form this path will not allow any retries for any sort

RE: Bug in smsc_smpp.c

2002-11-25 Thread Paul Keogh
waiting for that. Is it coming in the near future?! Should be done very simple I guess. Here is a patch for the infinite loop problem I reported in the SMPP driver for review. I also added in a reconnect-attempts configuration variable for control. This is mandated by a number of operators

Bug in smsc_smpp.c

2002-11-21 Thread Paul Keogh
The handling of errors returned by the read_pdu() is inadequate. When read_pdu() fails due to a conn error, the io_thread() function goes into a hard CPU loop and never exits. read_pdu() can fail for a malformed SMPP PDU or a conn error. The same return code is returned for both conditions. I

Re: Bug in smsc_smpp.c

2002-11-21 Thread Stipe Tolj
Paul Keogh wrote: The handling of errors returned by the read_pdu() is inadequate. When read_pdu() fails due to a conn error, the io_thread() function goes into a hard CPU loop and never exits. read_pdu() can fail for a malformed SMPP PDU or a conn error. The same return code is