Re: newforms-admin fieldsets classes question

2007-11-12 Thread Matthias Urlichs
The problem is that the intent is a test like "bar" in "foo bar baz" which is true; unfortunately, so is "bar" in "disbarment" which shouldn't be (in this context anyway). Thus you should test "bar" in ("foo","bar","baz") instead, which seems to be the intent behind this change

Re: newforms-admin fieldsets classes question

2007-11-11 Thread Karen Tracey
On 11/11/07, Matthias Urlichs <[EMAIL PROTECTED]> wrote: > > IMHo it makes sense to usee a tuple there. I'd go so far as to > recommend *not* to concatenate that (three lines down...); the > subsequent test in line 81 will cause false positives otherwise. ? I don't see how false positives will

Re: newforms-admin fieldsets classes question

2007-11-11 Thread Karen Tracey
On 11/11/07, Joseph Kocherhans <[EMAIL PROTECTED]> wrote: > > > On 11/10/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > > Was it intended to change the type of the 'classes' value in an Admin > field > > (now fieldset in newforms-admin) specification from string to tuple? > > > > Yes, it was

Re: newforms-admin fieldsets classes question

2007-11-11 Thread Matthias Urlichs
IMHo it makes sense to usee a tuple there. I'd go so far as to recommend *not* to concatenate that (three lines down...); the subsequent test in line 81 will cause false positives otherwise. --~--~-~--~~~---~--~~ You received this message because you are

Re: newforms-admin fieldsets classes question

2007-11-10 Thread Joseph Kocherhans
On 11/10/07, Karen Tracey <[EMAIL PROTECTED]> wrote: > Was it intended to change the type of the 'classes' value in an Admin field > (now fieldset in newforms-admin) specification from string to tuple? The > old doc here: > > http://www.djangoproject.com/documentation/model-api/#classes > >

newforms-admin fieldsets classes question

2007-11-10 Thread Karen Tracey
Was it intended to change the type of the 'classes' value in an Admin field (now fieldset in newforms-admin) specification from string to tuple? The old doc here: http://www.djangoproject.com/documentation/model-api/#classes states the value should be a string and if you want to specify more