[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-22 Thread David Lechner
On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote: > Add the nodes for the MSTPRI configuration and DDR2/mDDR memory > controller drivers to da850.dtsi. > > Signed-off-by: Bartosz Golaszewski > --- > v1 -> v2: > - moved the priority controller node above the cfgchip node > - renamed added nodes

[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-23 Thread David Lechner
On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote: > 2016-11-22 23:23 GMT+01:00 David Lechner : >> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote: >>> >>> Add the nodes for the MSTPRI configuration and DDR2/mDDR memory >>> controller drivers to da850.

[PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

2016-11-23 Thread David Lechner
On 11/23/2016 04:32 PM, Kevin Hilman wrote: > David Lechner writes: > >> On 11/23/2016 04:27 AM, Bartosz Golaszewski wrote: >>> 2016-11-22 23:23 GMT+01:00 David Lechner : >>>> On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote: >>>>> >>>&g

[PATCH v2] drm/fb-helper: pass physical dimensions to fbdev

2017-08-02 Thread David Lechner
The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev device. Signed-off-by: David Lechner <da...@lechnology.com> --- v1 changes (from RFC): * Use loop to ge

Re: [PATCH] drm/fb-helper: pass physical dimensions to fbdev

2017-08-02 Thread David Lechner
On 08/02/2017 06:28 PM, Daniel Vetter wrote: On Wed, Aug 2, 2017 at 6:37 PM, David Lechner <da...@lechnology.com> wrote: On 08/02/2017 04:46 AM, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 10:26:41AM -0500, David Lechner wrote: The fbdev subsystem has a place for physical dimensions

[PATCH v3 2/2] drm/fb-helper: pass physical dimensions to fbdev

2017-08-03 Thread David Lechner
may be NULL in drm_setup_crtcs(). Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/drm_fb_helper.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 24a721a..a98bf

[PATCH v3 0/2] drm/fb-helper: pass physical dimensions to fbdev

2017-08-03 Thread David Lechner
drm_setup_crtcs_fb() function from new patch to avoid duplication of code. David Lechner (2): drm/fb-helper: add new drm_setup_crtcs_fb() function drm/fb-helper: pass physical dimensions to fbdev drivers/gpu/drm/drm_fb_helper.c | 45 - 1 file changed, 31

[PATCH v3 1/2] drm/fb-helper: add new drm_setup_crtcs_fb() function

2017-08-03 Thread David Lechner
he end of drm_fb_helper_single_fb_probe() that sets fb_helper->fb, so it is moved to the new drm_setup_crtcs_fb() function. This is also done in preparation for addition setup that requires access to fb_helper->fbdev. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/dr

Re: Monochrome/greyscale and software dithering in the kernel

2017-08-03 Thread David Lechner
On 08/03/2017 09:58 AM, Noralf Trønnes wrote: Hi, The tinydrm/repaper driver is monochrome, but I have just used an emulation format XRGB, since monochrome support is scarce in userspace. I'm using ITU BT.601 to convert from rgb to greyscale and then use the msb for monochrome. Now I'm

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread David Lechner
On 08/03/2017 09:07 AM, Noralf Trønnes wrote: Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner

[PATCH v2 3/4] ARM: dts: da850-lego-ev3: Add node for LCD display

2017-08-01 Thread David Lechner
This adds a new node for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <da...@lechnology.com> --- arch/arm/boot/dts/da850-lego-ev3.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/da850-lego-ev3.dts b/arch/arm/boot/dts

[PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-01 Thread David Lechner
LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the EV3 LCD display. Signed-off-by: David Lechner <da...@lechnology.com> --- .../devicetree/bindings/display/st7586.txt | 26 + drivers/gpu/drm/tinydrm/K

[PATCH v2 0/4] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-01 Thread David Lechner
The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working. v2 changes: * Wrote a new driver for ST7586 instead of combining it with existing drivers * Don't touch MIPI DBI code (other than the patch suggested by Noralf) * New defconfig patch David Lechner (4): drm

[PATCH v2 4/4] ARM: davinci_all_defconfig: enable tinydrm and ST7586

2017-08-01 Thread David Lechner
This enables the tinydrm and ST7586 panel modules used by the display on LEGO MINDSTORMS EV3. Signed-off-by: David Lechner <da...@lechnology.com> --- arch/arm/configs/davinci_all_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/davinci_all_defconfig b/ar

[PATCH v2 1/4] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

2017-08-01 Thread David Lechner
This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Also fixed order of @dc parameter in the doc comment. Suggested-by: Noralf Trønnes <nor...@tronnes.org> Signed-off-by: David Lechner <da...@lechn

[PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-01 Thread David Lechner
If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 3 ++- 1 file chan

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-01 Thread David Lechner
On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote: The goal of this series is to get the built

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-03 Thread David Lechner
On 08/01/2017 03:14 PM, David Lechner wrote: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead of returning. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/g

[PATCH v3 6/6] ARM: davinci_all_defconfig: enable tinydrm and ST7586

2017-08-03 Thread David Lechner
This enables the tinydrm and ST7586 panel modules used by the display on LEGO MINDSTORMS EV3. Signed-off-by: David Lechner <da...@lechnology.com> --- arch/arm/configs/davinci_all_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/davinci_all_defconfig b/ar

[PATCH v3 2/6] drm/tinydrm: generalize tinydrm_xrgb8888_to_gray8()

2017-08-03 Thread David Lechner
This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.

[PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-03 Thread David Lechner
This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working with is an integral part of the LEGO MINDSTORMS EV3. Signed-off-by: David Lechner <da...@lechnology.com> --- .../bindings/display/si

[PATCH v3 5/6] ARM: dts: da850-lego-ev3: Add node for LCD display

2017-08-03 Thread David Lechner
This adds a new node for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <da...@lechnology.com> --- arch/arm/boot/dts/da850-lego-ev3.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/da850-lego-ev3.dts b/arch/arm/boot/dts

[PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-03 Thread David Lechner
LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <da...@lechnology.com> --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/K

[PATCH v3 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread David Lechner
Moved init and fini to pipe_enable and pipe_disable ops. * Dropped RGB565 format. * Made adjustments for the fact the controller cannot be read via SPI. * Dropped st7586.h - values moved into st7586.c. David Lechner (6): drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init() d

[PATCH v3 1/6] drm/tinydrm: remove call to mipi_dbi_init() from mipi_dbi_spi_init()

2017-08-03 Thread David Lechner
This removes the call to mipi_dbi_init() from mipi_dbi_spi_init() so that drivers can have a driver-specific implementation if needed. Suggested-by: Noralf Trønnes <nor...@tronnes.org> Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Noralf Trønnes <nor

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread David Lechner
On 08/03/2017 03:11 PM, Noralf Trønnes wrote: Den 03.08.2017 19.11, skrev Andy Shevchenko: On Thu, Aug 3, 2017 at 8:09 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: On Thu, Aug 3, 2017 at 6:18 PM, David Lechner <da...@lechnology.com> wrote: The particular di

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-03 Thread David Lechner
On 08/03/2017 08:08 PM, David Lechner wrote: On 08/03/2017 03:11 PM, Noralf Trønnes wrote: Den 03.08.2017 19.11, skrev Andy Shevchenko: On Thu, Aug 3, 2017 at 8:09 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: On Thu, Aug 3, 2017 at 6:18 PM, David Lechner <da...@lechn

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-05 Thread David Lechner
On 08/04/2017 02:39 PM, Laurent Pinchart wrote: Hi David, On Friday 04 Aug 2017 10:51:37 David Lechner wrote: On 08/04/2017 09:54 AM, Laurent Pinchart wrote: On Thursday 03 Aug 2017 17:33:47 David Lechner wrote: This adds a new binding for Sitronix ST7586 display panels. Using lego

[RFC] drm/fb: Propagate physical display dimensions to fbdev

2017-07-30 Thread David Lechner
fbdev has a place for the physical width and height of a display. I would like to have this information available to userspace. This patch works for me, but I have a strong suspicion that this is not the "right way". Any suggestions on how to get the proper struct drm_display_info here rather

[PATCH] drm/fb-helper: pass physical dimensions to fbdev

2017-08-01 Thread David Lechner
The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev device. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/gpu/drm/drm_fb_helper.

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-01 Thread David Lechner
On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner: On 07/29/2017 02:17 PM, David Lechner wrote: The goal of this series is to get the built-in LCD of the LEGO MINDSTORMS EV3 working. But, most of the content here is building up the infrastructure to do

Re: [PATCH] drm/fb-helper: pass physical dimensions to fbdev

2017-08-02 Thread David Lechner
On 08/02/2017 04:46 AM, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 10:26:41AM -0500, David Lechner wrote: The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev

Re: [PATCH v2 2/4] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-02 Thread David Lechner
On 08/02/2017 08:03 AM, Noralf Trønnes wrote: Please use tinydrm_xrgb_to_gray8(). I considered this, but is seems excessive to loop through the entire fb twice just to make a 4x6 cursor blink. You should use this function to enable the regulator and init the controller. Don't look at

Re: [PATCH 0/6] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-02 Thread David Lechner
On 08/02/2017 03:05 AM, Noralf Trønnes wrote: Den 02.08.2017 00.26, skrev David Lechner: On 08/01/2017 01:08 PM, Noralf Trønnes wrote: (cc: Daniel Vetter) Den 01.08.2017 18.51, skrev David Lechner: On 07/30/2017 12:14 PM, Noralf Trønnes wrote: Den 29.07.2017 21.40, skrev David Lechner

[PATCH] drm/fb: Fix pointer dereference before null check.

2017-08-02 Thread David Lechner
fb_crtc is used before a null check, so move the use after the null check. This was just identified by inspection. I haven't actually observed a crash here, so it is possible that the null check could be unnecessary. Signed-off-by: David Lechner <da...@lechnology.com> --- drivers/g

Re: [PATCH v1 1/2] uapi: drm: Add fourcc codes needed by Xilinx Video IP

2017-08-07 Thread David Lechner
On 08/07/2017 10:13 AM, Philipp Zabel wrote: Hi Jeffrey, On Fri, 2017-08-04 at 11:49 -0700, Jeffrey Mouroux wrote: The Xilinx Video Mixer andn Xilinx Video Framebuffer DMA IP support video memory formats that are not represented in the current DRM fourcc library. This patch adds those missing

Re: [PATCH v5] drm/fb-helper: pass physical dimensions to fbdev

2017-08-07 Thread David Lechner
On 08/04/2017 11:25 AM, David Lechner wrote: The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev device. This has to be done in drm_setup_crtcs_fb() instead

Re: [PATCH v5] drm/fb-helper: pass physical dimensions to fbdev

2017-08-05 Thread David Lechner
On 08/04/2017 04:53 PM, Laurent Pinchart wrote: Hi David, Thank you for the patch. On Friday 04 Aug 2017 11:25:24 David Lechner wrote: The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-04 Thread David Lechner
On 08/04/2017 09:54 AM, Laurent Pinchart wrote: Hi David, Thank you for the patch. On Thursday 03 Aug 2017 17:33:47 David Lechner wrote: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working

Re: [PATCH v4] drm/fb-helper: pass physical dimensions to fbdev

2017-08-04 Thread David Lechner
On 08/04/2017 11:22 AM, David Lechner wrote: The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev device. This has to be done in drm_setup_crtcs_fb() instead

Re: [PATCH v3 3/6] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-04 Thread David Lechner
On 08/04/2017 04:48 AM, Noralf Trønnes wrote: Den 04.08.2017 00.33, skrev David Lechner: This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working with is an integral part of the LEGO

[PATCH v4] drm/fb-helper: pass physical dimensions to fbdev

2017-08-04 Thread David Lechner
The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev device. This has to be done in drm_setup_crtcs_fb() instead of drm_setup_crtcs() because fb_helper->fbdev may

[PATCH v5] drm/fb-helper: pass physical dimensions to fbdev

2017-08-04 Thread David Lechner
The fbdev subsystem has a place for physical dimensions (width and height in mm) that is readable by userspace. Since DRM also knows these dimensions, pass this information to the fbdev device. This has to be done in drm_setup_crtcs_fb() instead of drm_setup_crtcs() because fb_helper->fbdev may

Re: [PATCH v3 4/6] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-07 Thread David Lechner
On 08/05/2017 01:19 PM, Noralf Trønnes wrote: Den 04.08.2017 00.33, skrev David Lechner: + +buf = kmalloc(len, GFP_KERNEL); +if (!buf) +return; + +tinydrm_xrgb_to_gray8(buf, vaddr, fb, clip); +src = buf; + +for (y = clip->y1; y < clip->y2; y++) { +

[PATCH v4 2/5] dt-bindings: add binding for Sitronix ST7586 display panels

2017-08-07 Thread David Lechner
This adds a new binding for Sitronix ST7586 display panels. Using lego as the vendor prefix in the compatible string because the display panel I am working with is an integral part of the LEGO MINDSTORMS EV3. Signed-off-by: David Lechner <da...@lechnology.com> --- v4 changes: * Dropped op

[PATCH v4 1/5] drm/tinydrm: Generalize tinydrm_xrgb8888_to_gray8()

2017-08-07 Thread David Lechner
This adds parameters for vaddr and clip to tinydrm_xrgb_to_gray8() to make it more generic. dma_buf_{begin,end}_cpu_access() are moved out to the repaper driver. Return type is change to void to simplify error handling by callers. Signed-off-by: David Lechner <da...@lechnology.com> -

[PATCH v4 0/5] Support for LEGO MINDSTORMS EV3 LCD display

2017-08-07 Thread David Lechner
0 since that is what is on the datasheet/LEGO schematic. David Lechner (5): drm/tinydrm: Generalize tinydrm_xrgb_to_gray8() dt-bindings: add binding for Sitronix ST7586 display panels drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD ARM: dts: da850-lego-ev3: Add node for LCD display ARM: d

[PATCH v4 3/5] drm/tinydrm: add support for LEGO MINDSTORMS EV3 LCD

2017-08-07 Thread David Lechner
LEGO MINDSTORMS EV3 has an LCD with a ST7586 controller. This adds a new module for the ST7586 controller with parameters for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <da...@lechnology.com> --- v4 changes: * correct order for MAINTAINERS entry * Drop code no

[PATCH v4 4/5] ARM: dts: da850-lego-ev3: Add node for LCD display

2017-08-07 Thread David Lechner
This adds a new node for the LEGO MINDSTORMS EV3 LCD display. Signed-off-by: David Lechner <da...@lechnology.com> --- v4 changes: * changed dc to a0 arch/arm/boot/dts/da850-lego-ev3.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/da85

[PATCH v4 5/5] ARM: davinci_all_defconfig: enable tinydrm and ST7586

2017-08-07 Thread David Lechner
This enables the tinydrm and ST7586 panel modules used by the display on LEGO MINDSTORMS EV3. Signed-off-by: David Lechner <da...@lechnology.com> --- arch/arm/configs/davinci_all_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/davinci_all_defconfig b/ar

Re: [PATCH] drm/tinydrm: mipi-dbi: Fix unbalanced DMA access

2017-08-07 Thread David Lechner
On 08/04/2017 01:49 AM, Noralf Trønnes wrote: Den 04.08.2017 00.41, skrev David Lechner: On 08/01/2017 03:14 PM, David Lechner wrote: If we return here and import_attach is true, then dma_buf_end_cpu_access() will not be called balance dma_buf_begin_cpu_access(). Fix by setting ret instead

Re: [PATCH 4/6] drm/tinydrm: Embed drm_device in tinydrm_device

2017-08-29 Thread David Lechner
On 08/28/2017 12:17 PM, Noralf Trønnes wrote: Might as well embed drm_device since tinydrm_device (embeds pipe struct and fbdev pointer) needs to stick around after driver-device unbind to handle open fd's after device removal. Cc: David Lechner <da...@lechnology.com> Signed-off-by:

Re: [PATCH v2 07/11] drm/tinydrm: Drop driver registered message

2017-09-09 Thread David Lechner
On 09/08/2017 10:07 AM, Noralf Trønnes wrote: No need to put out a driver registered message since drm_dev_register() does that now. SPI speed is an important metric when dealing with display problems, so retain that info. Cc: David Lechner <da...@lechnology.com> Signed-off-by: Noralf T

[PATCH v1 0/2] DRM driver for Sitronix ST7735R display panels

2017-11-28 Thread David Lechner
ix is important, so I am including it in the driver name and device tree bindings. [1]: https://github.com/notro/tinydrm/wiki/Development David Lechner (2): dt-bindings: Add binding for Sitronix ST7735R display panels drm/tinydrm: add driver for ST7735R panels .../bindings/display/sitro

[PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

2017-11-28 Thread David Lechner
This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- .../bindings/display/sitronix,st7735r.txt | 35 ++ 1 file changed, 35 insertions(+) create

[PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-11-28 Thread David Lechner
This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++ drivers/gpu/drm/tinydrm/Make

Re: tinydrm: page allocation failure

2017-12-14 Thread David Lechner
On 12/11/2017 06:45 AM, Noralf Trønnes wrote: Den 11.12.2017 04.28, skrev David Lechner: I'm using drm-misc/drm-misc-next and occasionally getting errors as seen in the stack traces below. I'm not really sure what to make of it. Any ideas? I'm starting to wonder if there is some sort

[PATCH v2 4/4] drm/tinydrm: add driver for ILI9225 panels

2017-11-19 Thread David Lechner
This adds a new driver for display panels based on the Ilitek ILI9225 controller. This was developed for a no-name panel with a red PCB that is commonly marketed for Arduino. See <https://github.com/Nkawu/TFT_22_ILI9225>. Signed-off-by: David Lechner <da...@lechnology.com> --- v2 ch

[PATCH v2 1/4] dt-bindings: Add vendor prefix for ilitek

2017-11-19 Thread David Lechner
This adds the vendor prefix ilitek for ILI Technology Corporation (ILITEK). This prefix is already used several places and I will be adding more. Signed-off-by: David Lechner <da...@lechnology.com> --- v2 changes: * New patch in v2 Documentation/devicetree/bindings/vendor-prefixes.t

[PATCH v2 0/4] DRM driver for ILI9225 display panels

2017-11-19 Thread David Lechner
This is a new driver for ILI9225 based display panels. v2 changes: * New patch for ilitek vendor prefix. * Use "ilitek" instead of "generic" in dt-bindings * New patch to export 2 mipi_dbi_* functions * Clean up ILI9225 driver based on feedback David Lechner (4): dt-binding

[PATCH v2 3/4] drm/tinydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed

2017-11-19 Thread David Lechner
This exports the mipi_dbi_buf_copy() and mipi_dbi_spi_cmd_max_speed() functions so that they can be shared with other drivers. Signed-off-by: David Lechner <da...@lechnology.com> --- v2 changes: * new patch in v2 drivers/gpu/drm/tinydrm/mipi-dbi.c | 24 inclu

[PATCH v2 2/4] dt-bindings: Add binding for Ilitek ILI9225 display panels

2017-11-19 Thread David Lechner
model name. An example of this nameless device can be found at: https://github.com/Nkawu/TFT_22_ILI9225 Signed-off-by: David Lechner <da...@lechnology.com> --- v2 changes: * renamed compatible string based on feedback .../devicetree/bindings/display/ilitek,ili9225.txt | 25 ++

Re: [PATCH 21/22] drm/tinydrm: Use drm_fb_cma_fbdev_init_with_funcs/fini()

2017-11-06 Thread David Lechner
functions directly. Remove todo entry. Cc: David Lechner <da...@lechnology.com> Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Acked-by: David Lechner <da...@lechnology.com> ___ dri-devel mailing list dri-devel@lists.fre

[PATCH v1 0/2] DRM driver for ILI9225 display panels

2017-11-07 Thread David Lechner
50% (3 bytes per pixel instead of 2). Implementing this would have a side effect of making the one-off shared code (described above) more than one-off though. [1]: https://github.com/Nkawu/TFT_22_ILI9225 [2]: http://www.hotmcu.com/22-176x220-tft-lcd-with-spi-interface-p-316.html David Lech

[PATCH v1 2/2] drm/tinydrm: add driver for ILI9225 panels

2017-11-07 Thread David Lechner
panel, but there doesn't seem to be one, so the best I can do is offer the picture in the link above for identification. Signed-off-by: David Lechner <da...@lechnology.com> --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 + drivers/gpu/drm/tinydrm/Mak

[PATCH v1 1/2] dt-bindings: Add binding for Ilitek ILI9225 display panels

2017-11-07 Thread David Lechner
device can be found at: https://github.com/Nkawu/TFT_22_ILI9225 Signed-off-by: David Lechner <da...@lechnology.com> --- .../devicetree/bindings/display/ilitek,ili9225.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/

Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-08 Thread David Lechner
On 12/06/2017 12:27 PM, Noralf Trønnes wrote: Den 29.11.2017 04.01, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> ---  

Re: [PATCH v3 10/11] drm/tinydrm: Use drm_fb_cma_fbdev_init_with_funcs/fini()

2017-12-08 Thread David Lechner
functions directly. Remove todo entry. Cc: David Lechner <da...@lechnology.com> Signed-off-by: Noralf Trønnes <nor...@tronnes.org> Acked-by: David Lechner <da...@lechnology.com> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> --- Documentation/gpu/todo.rst

tinydrm: page allocation failure

2017-12-10 Thread David Lechner
I'm using drm-misc/drm-misc-next and occasionally getting errors as seen in the stack traces below. I'm not really sure what to make of it. Any ideas? [ 1727.253743] kworker/0:2: page allocation failure: order:4, mode:0x14040c1(GFP_KERNEL|GFP_DMA|__GFP_COMP), nodemask=(null) [ 1727.298438]

Re: tinydrm: page allocation failure

2017-12-11 Thread David Lechner
On 12/11/2017 07:37 AM, Noralf Trønnes wrote: Den 11.12.2017 13.45, skrev Noralf Trønnes: Den 11.12.2017 04.28, skrev David Lechner: I'm using drm-misc/drm-misc-next and occasionally getting errors as seen in the stack traces below. I'm not really sure what to make of it. Any ideas

Re: [PATCH v1 1/2] dt-bindings: Add binding for Sitronix ST7735R display panels

2017-12-10 Thread David Lechner
On 12/08/2017 03:41 PM, Noralf Trønnes wrote: Den 29.11.2017 04.01, skrev David Lechner: This adds a new device tree binding for Sitronix ST7735R display panels, such as the Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> ---   .../bindings/display/sitronix,

[PATCH v2 0/2] DRM driver for Sitronix ST7735R display panels

2017-12-10 Thread David Lechner
This series adds a new DRM/TinyDRM driver for Sitronix ST7735R, specifically the Adafruit 1.8" TFT. Nothing fancy here. Just mostly TinyDRM boilerplate with the init sequence from the fbtft driver for the same panel. Please see new discussion on device tree bindings in patch 1/2. David Le

[PATCH v2 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-10 Thread David Lechner
This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- v2 changes: * Change delay from 10ms to 20ms to avoid checkpatch warning * Use mipi_dbi_pipe_enable()/mipi_dbi_p

Re: [PATCH v2 2/2] drm/tinydrm: add driver for ST7735R panels

2017-12-11 Thread David Lechner
On 12/11/2017 03:18 PM, Noralf Trønnes wrote: Den 10.12.2017 23.10, skrev David Lechner: This adds a new driver for Sitronix ST7735R display panels. This has been tested using an Adafruit 1.8" TFT. Signed-off-by: David Lechner <da...@lechnology.com> --- +static void st7735r_

[PATCH 3/3] drm/tinydrm: new driver for ILI9341 display panels

2018-05-14 Thread David Lechner
fruit/Adafruit_Python_ILI9341 Signed-off-by: David Lechner <da...@lechnology.com> --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++ drivers/gpu/drm/tinydrm/Makefile | 1 + drivers/gpu/drm/tinydrm/ili9341.c | 239 ++ 4 files c

[PATCH 2/3] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-14 Thread David Lechner
Signed-off-by: David Lechner <da...@lechnology.com> --- .../bindings/display/ilitek,ili9341.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt diff --git a/Documentation/devicetree/bindings/displa

[PATCH 0/3] drm/tinydrm: new dirver for ILI9341 displays

2018-05-14 Thread David Lechner
with these two drivers (it's not much)? * The MAINTAINERS patch for ili9225 is included so we don't end up with a merge conflict later on. [1]: https://cdn-learn.adafruit.com/assets/assets/000/046/879/original/SPEC-YX240QV29-T_Rev.A__1_.pdf David Lechner (3): MAINTAINERS: fix path to ilitek,ili9

[PATCH 1/3] MAINTAINERS: fix path to ilitek, ili9225 device tree bindings

2018-05-14 Thread David Lechner
This fixes the path to the ilitek,ili9225 device tree binding file. Signed-off-by: David Lechner <da...@lechnology.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 334a00350922..bc219de9cbee 100644 --- a/MAINTAINERS

Re: [PATCH] drm/tilcdc: Fix setting clock divider for omap-l138

2018-05-09 Thread David Lechner
On 03/19/2018 04:05 AM, Jyri Sarha wrote: Thanks, I'll pick this for v4.18. Ping. I don't see this in drm-misc-next yet. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/3] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-19 Thread David Lechner
On 05/19/2018 08:37 AM, Noralf Trønnes wrote: Den 15.05.2018 03.43, skrev David Lechner: This adds a new binding for Ilitek ILI9341 display panels. It includes a compatible string for one display (more can be added in the future). The vendor prefix "noname" is used because

[PATCH v2 2/4] dt-bindings: Add vendor prefix for Adafruit

2018-05-25 Thread David Lechner
This adds a device tree vendor prefix for Adafruit Industries, LLC. Signed-off-by: David Lechner <da...@lechnology.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.

[PATCH v2 4/4] drm/tinydrm: new driver for ILI9341 display panels

2018-05-25 Thread David Lechner
fruit/Adafruit_Python_ILI9341 Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- MAINTAINERS | 6 + drivers/gpu/drm/tinydrm/Kconfig | 10 ++ drivers/g

[PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-05-25 Thread David Lechner
or style changes * drop regulator from driver (instead of adding to DT bindings) [1]: https://cdn-learn.adafruit.com/assets/assets/000/046/879/original/SPEC-YX240QV29-T_Rev.A__1_.pdf David Lechner (4): MAINTAINERS: fix path to ilitek,ili9225 device tree bindings dt-bindings: Add vendor p

[PATCH v2 1/4] MAINTAINERS: fix path to ilitek, ili9225 device tree bindings

2018-05-25 Thread David Lechner
This fixes the path to the ilitek,ili9225 device tree binding file. Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Noralf Trønnes <nor...@tronnes.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINT

[PATCH v2 3/4] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-25 Thread David Lechner
Signed-off-by: David Lechner <da...@lechnology.com> --- .../bindings/display/ilitek,ili9341.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt diff --git a/Documentation/devicetree/bindings/displa

Re: [PATCH v2 3/4] dt-bindings: new binding for Ilitek ILI9341 display panels

2018-05-25 Thread David Lechner
On 05/25/2018 02:36 PM, David Lechner wrote: This adds a new binding for Ilitek ILI9341 display panels. It includes a compatible string for one display (more can be added in the future). The vendor prefix "noname" is used because the vendor is not known. Looks like I forgot to upda

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-06-03 Thread David Lechner
On 6/3/18 5:00 PM, Noralf Trønnes wrote: Den 25.05.2018 21.36, skrev David Lechner: This series adds a new tinydrm driver for the Ilitek ILI9341 controller and a 2.4" display panel that uses this controller. David, do you have commit rights now? No. Opened a bug a while back to re

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-06-26 Thread David Lechner
On 06/20/2018 04:07 AM, Daniel Vetter wrote: I acked and forwarded the account request, sorry for the delay. Next time around, poking maintainers on irc helps if this stuff is stuck. -Daniel The account was supposedly setup, but I am not able to use it for some reason. Are there any

Re: [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays

2018-06-27 Thread David Lechner
On 06/27/2018 01:58 AM, Daniel Vetter wrote: On Tue, Jun 26, 2018 at 8:16 PM, David Lechner wrote: On 06/20/2018 04:07 AM, Daniel Vetter wrote: I acked and forwarded the account request, sorry for the delay. Next time around, poking maintainers on irc helps if this stuff is stuck. -Daniel

Re: [PATCH v4 9/9] drm/cma-helper: Remove drm_fb_cma_fbdev_init_with_funcs()

2018-07-02 Thread David Lechner
On 07/02/2018 08:54 AM, Noralf Trønnes wrote: Remove drm_fb_cma_fbdev_init_with_funcs(), its only user tinydrm has moved to drm_fbdev_generic_setup(). Cc: Laurent Pinchart Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner ___ dri

Re: [PATCH v4 8/9] drm/tinydrm: Use drm_fbdev_generic_setup()

2018-07-02 Thread David Lechner
On 07/02/2018 08:54 AM, Noralf Trønnes wrote: Make full use of the generic fbdev client. Cc: David Lechner Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

Re: [PATCH 5/5] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-05 Thread David Lechner
On 01/05/2018 10:56 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes ---

Re: [PATCH 3/5] drm/tinydrm/mi0283qt: Clarify error message

2018-01-05 Thread David Lechner
, MIPI_DCS_SOFT_RESET); if (ret) { - DRM_DEV_ERROR(dev, "Error sending command %d\n", ret); + DRM_DEV_ERROR(dev, "Error sending command: %d\n", ret); ditto regulator_disable(mipi->regulator); return ret; } With

Re: [PATCH 2/5] drm/tinydrm/mi0283qt: Remove ili9341.h

2018-01-05 Thread David Lechner
On 01/05/2018 10:55 AM, Noralf Trønnes wrote: No need for a public header file for the command macros. Just include the necessary ones in the driver. Also use the MIPI_DCS_PIXEL_FMT_16BIT macro. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> --- Reviewed-by: David Lechn

Re: [PATCH 4/5] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-05 Thread David Lechner
On 01/05/2018 10:55 AM, Noralf Trønnes wrote: It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mi0283qt.c | 51

Re: [PATCH 1/5] drm/tinydrm/mi0283qt: Use common include order

2018-01-05 Thread David Lechner
nclude -#include #include #include #include #include #include #include + +#include +#include +#include +#include +#include #include static int mi0283qt_init(struct mipi_dbi *mipi) Reviewed-by: David Lechner <da...@lechn

Re: [PATCH 5/5] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-06 Thread David Lechner
On 01/06/2018 06:49 AM, Noralf Trønnes wrote: Den 05.01.2018 20.14, skrev David Lechner: On 01/05/2018 10:56 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init

Re: [PATCH 4/5] drm/tinydrm/mi0283qt: Let the display pipe handle power

2018-01-06 Thread David Lechner
On 01/06/2018 06:45 AM, Noralf Trønnes wrote: Den 05.01.2018 19.59, skrev David Lechner: On 01/05/2018 10:55 AM, Noralf Trønnes wrote: It's better to leave power handling and controller init to the modesetting machinery using the simple pipe .enable and .disable callbacks. Signed-off

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-08 Thread David Lechner
On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++-- drivers/gpu/drm/tinydrm/mipi-dbi.c | 63 ++

Re: [PATCH v2 4/6] drm/tinydrm/mipi-dbi: Add poweron-reset functions

2018-01-09 Thread David Lechner
On 01/09/2018 09:01 AM, Noralf Trønnes wrote: Den 09.01.2018 02.38, skrev David Lechner: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Split out common poweron-reset functionality. Signed-off-by: Noralf Trønnes <nor...@tronnes.org> ---   drivers/gpu/drm/tinydrm/mi0283qt.

  1   2   3   >