Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation (), Patch

2007-01-30 Thread Frederic Bouvier
Nick, Selon Nick Warne : Fred, Mathias I got this again tonight :-((( Chat [mpserve] GFS is now online, using Chat [mpserve] Aircraft/B-2/Models/b2-spirit.xml Chat [mpserve] GFS is now online, using Chat [mpserve] Aircraft/B-2/Models/b2-spirit.xml Segmentation fault Another

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-26 Thread Frederic Bouvier
Hi Maik, Selon Maik Justus : Hi, the same thing with _condition. It's systematically done wrong. _textureData could be done correctly :-) _condition, _effectTexture and _textureData are not SGShaderAnimation members in the OSG code. In the PLIB branch, _contition is not shared but

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-26 Thread Maik Justus
Hi Fred, Frederic Bouvier schrieb am 26.01.2007 10:02: Hi Maik, Selon Maik Justus : _condition, _effectTexture and _textureData are not SGShaderAnimation members in the OSG code. In the PLIB branch, _contition is not shared but initialized with new in sgReadCondition, so unless

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-26 Thread Nick Warne
On Friday 26 January 2007 09:02, Frederic Bouvier wrote: Hi Maik, Selon Maik Justus : Hi, the same thing with _condition. It's systematically done wrong. _textureData could be done correctly :-) _condition, _effectTexture and _textureData are not SGShaderAnimation members in the

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-26 Thread Maik Justus
Hi all, here is a workaround for osg. It disables the chrome shader, but as long as this causes the fatal crashes we need to commit. Unfortunately I am not compiling osg myself; I am using Olafs precompiled library. Therefore I can not dig into the code :-( Maik Maik Justus schrieb am

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-26 Thread Frederic Bouvier
Selon Nick Warne : Reports from IRC say this is fixed in plib, but I can still get a 100% reliable crash with OSG build. Enter MP server using Harrier. Get someone to join/leave/join with the dhc2F. Immediate segfault on the second join. Below is my earlier mail with trace etc. Are you

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-26 Thread Maik Justus
Hi Fred, your patch works fine for me. Big thanks! Maik Frederic Bouvier schrieb am 26.01.2007 20:41: Selon Nick Warne : Reports from IRC say this is fixed in plib, but I can still get a 100% reliable crash with OSG build. Enter MP server using Harrier. Get someone to

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-25 Thread Maik Justus
Hi all, I am not sure, but maybe we have the cause for the segfaults/failed assert (big thanks at Joacim for finding the point). The _effectTexture is loaded by ssgTexture* ssgLoaderOptions::createTexture. If the texture is already loaded, a pointer to this texture is returned. But

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-25 Thread Maik Justus
Hi, the same thing with _condition. It's systematically done wrong. _textureData could be done correctly :-) Maik Maik Justus schrieb am 25.01.2007 22:58: Hi all, I am not sure, but maybe we have the cause for the segfaults/failed assert (big thanks at Joacim for finding the point).

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-24 Thread Joacim Persson
On Fri, 5 Jan 2007, Maik Justus wrote: Hello, sometimes I get a segfault in function SGShaderAnimation::~SGShaderAnimation(), file simgear/scene/model/shadanim.cxx. I never get a SIGSEGV from there, but rather a SIGABORT due to a failed assert. (This with plib, nota bene) And from the

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-24 Thread Nick Warne
On Wednesday 24 January 2007 17:05, Joacim Persson wrote: On Fri, 5 Jan 2007, Maik Justus wrote: Hello, sometimes I get a segfault in function SGShaderAnimation::~SGShaderAnimation(), file simgear/scene/model/shadanim.cxx. I never get a SIGSEGV from there, but rather a SIGABORT due to

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-15 Thread Mathias Fröhlich
Hi Maik, On Friday 05 January 2007 11:16, Maik Justus wrote: sometimes I get a segfault in function SGShaderAnimation::~SGShaderAnimation(), file simgear/scene/model/shadanim.cxx. Please commit the attached patch. The patch you have attached is a noop. you can safely delete a zero pointer

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-15 Thread Maik Justus
Hi Mathias, you are right. The problem were not zero pointers, but invalid pointers. I have commented out the delete statements and got no further crash of flightgear up to now (of course this is not the way to go, but to check if my local crashes are to this delete statement). But I am not

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-15 Thread Maik Justus
Hi Fred, no, it only helped to comment out the whole delete statement. I have to check, if it was due to a local bug. Maik Frederic Bouvier schrieb am 15.01.2007 20:40: Mathias Fröhlich a écrit : Hi Maik, On Friday 05 January 2007 11:16, Maik Justus wrote: sometimes I get a

Re: [Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-12 Thread Curtis Olson
When I first looked at your patch, my first thought was that the original code should have worked fine and your patch shouldn't really make any difference. Maybe something else is corrupting the some structures ... an out of bounds array write or something??? These are tough to track down, but

[Flightgear-devel] segfaults in SGShaderAnimation::~SGShaderAnimation(), Patch

2007-01-05 Thread Maik Justus
Hello, sometimes I get a segfault in function SGShaderAnimation::~SGShaderAnimation(), file simgear/scene/model/shadanim.cxx. Please commit the attached patch. Maik Index: simgear/scene/model/shadanim.cxx === RCS file: