Re: Menu Title patch
On Tue, Feb 14, 2006 at 07:27:55PM +0100, Viktor Griph wrote: On Thu, 9 Feb 2006, Dominik Vogt wrote: I have applied the patch with some changes and bugfixes: * The text of the menuitem is always drawn in the given colour set (this required a bugfix in the text drawing library). I don't think this should be done if no colorset is specified for the title. In that case I belive it should use the color of the normal items, or old configs using other color than black will get a black title color. That's exactly what I said (or maybe wanted to say). Currently: * No TitleColorset given - normal item colours are used. * TitleColorset given - foreground of cs is used. * TitleColorset and HilightTitleBack given - foreground and background of cs ase used. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: Menu Title patch
On Wed, 15 Feb 2006, Dominik Vogt wrote: On Wed, Feb 15, 2006 at 09:25:11AM +0100, Viktor Griph wrote: On Wed, 15 Feb 2006, Dominik Vogt wrote: On Tue, Feb 14, 2006 at 07:27:55PM +0100, Viktor Griph wrote: On Thu, 9 Feb 2006, Dominik Vogt wrote: I have applied the patch with some changes and bugfixes: * The text of the menuitem is always drawn in the given colour set (this required a bugfix in the text drawing library). I don't think this should be done if no colorset is specified for the title. In that case I belive it should use the color of the normal items, or old configs using other color than black will get a black title color. That's exactly what I said (or maybe wanted to say). Currently: * No TitleColorset given - normal item colours are used. * TitleColorset given - foreground of cs is used. * TitleColorset and HilightTitleBack given - foreground and background of cs ase used. In that case it's not working, because I don't have a TitleColorset, and my menu title is black, while the rest of the items are khaki. Works perfectly for me. Can you post an example config that shows the problem? Just the following is ennough: Colorset 0 fg khaki,bg rgb:dd/00/00 MenuStyle * MenuColorset 0 /Viktor
Re: Menu Title patch
On Wed, Feb 15, 2006 at 09:46:45AM +0100, Viktor Griph wrote: On Wed, 15 Feb 2006, Dominik Vogt wrote: On Wed, Feb 15, 2006 at 09:25:11AM +0100, Viktor Griph wrote: On Wed, 15 Feb 2006, Dominik Vogt wrote: On Tue, Feb 14, 2006 at 07:27:55PM +0100, Viktor Griph wrote: On Thu, 9 Feb 2006, Dominik Vogt wrote: I have applied the patch with some changes and bugfixes: * The text of the menuitem is always drawn in the given colour set (this required a bugfix in the text drawing library). I don't think this should be done if no colorset is specified for the title. In that case I belive it should use the color of the normal items, or old configs using other color than black will get a black title color. That's exactly what I said (or maybe wanted to say). Currently: * No TitleColorset given - normal item colours are used. * TitleColorset given - foreground of cs is used. * TitleColorset and HilightTitleBack given - foreground and background of cs ase used. In that case it's not working, because I don't have a TitleColorset, and my menu title is black, while the rest of the items are khaki. Works perfectly for me. Can you post an example config that shows the problem? Just the following is ennough: Colorset 0 fg khaki,bg rgb:dd/00/00 MenuStyle * MenuColorset 0 Fixed. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: Menu Title patch
On Thu, 9 Feb 2006, Dominik Vogt wrote: I have applied the patch with some changes and bugfixes: * The text of the menuitem is always drawn in the given colour set (this required a bugfix in the text drawing library). I don't think this should be done if no colorset is specified for the title. In that case I belive it should use the color of the normal items, or old configs using other color than black will get a black title color. /Viktor
Re: Menu Title patch
On Sat, Feb 04, 2006 at 08:51:33PM +, David Maciver wrote: On Sat, 21 Jan 2006 04:17:43 +, David Maciver wrote: Hello, I've written a patch that lets you configure the menu title and colorset separately from the rest of the menu. I've added menustyle options HilightTitle, TitleColorset and TitleFont. Here is an example of what it looks like: http://metawire.org/~frogb/menu2.png Patch against CVS: http://metawire.org/~frogb/menutitle.patch Could this be included in fvwm? This sort of configuration seems quite popular in other window managers. It was originally posted on the fvwm forum[1] where people seem to want it. It seems to work ok for me but is there anything that should be changed/fixed in the code, or any reason this cannot be accepted? [1] http://fvwm.lair.be/viewtopic.php?t=1141 I have applied the patch with some changes and bugfixes: * The text of the menuitem is always drawn in the given colour set (this required a bugfix in the text drawing library). * Renamed the HilightTitle option to HilightTitleBack. It just controls whether the background of the title is hilighted. * Corrected the calculations of the area to hilight. Now it always hilights the whole title, not just the area with the relief on menu items (which can be smaller if the ItemFormat style is used). For future patches, please include * NEWS entries for new features and bugfixes. * Documentation in the man page (fvwm.1.in). * ChangeLog entries including the names of all files and functions changed and a short comment. * Optionally an entry for the AUTHORS file. This cuts down the time I spend to handle patches a lot because if you don't write it, I have to do it (which is much more work because I have to learn everything from the code first). Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: Menu Title patch
On Sat, 21 Jan 2006 04:17:43 +, David Maciver wrote: Hello, I've written a patch that lets you configure the menu title and colorset separately from the rest of the menu. I've added menustyle options HilightTitle, TitleColorset and TitleFont. Here is an example of what it looks like: http://metawire.org/~frogb/menu2.png Patch against CVS: http://metawire.org/~frogb/menutitle.patch Could this be included in fvwm? This sort of configuration seems quite popular in other window managers. It was originally posted on the fvwm forum[1] where people seem to want it. It seems to work ok for me but is there anything that should be changed/fixed in the code, or any reason this cannot be accepted? [1] http://fvwm.lair.be/viewtopic.php?t=1141
Menu Title patch
Hello, I've written a patch that lets you configure the menu title and colorset separately from the rest of the menu. I've added menustyle options HilightTitle, TitleColorset and TitleFont. Here is an example of what it looks like: http://metawire.org/~frogb/menu2.png Patch against CVS: http://metawire.org/~frogb/menutitle.patch I can write the documentation and changelog if you accept this. I am new to fvwm development so advice on anything I should change would be helpful. Thanks David
