Re: FVWM: pull requests

Hi, Ensure master is up to date in your checkout, then on you topic branch: git rebase master If there were changes on master which weren't on your branch you'll have to force push your topic branch out again to build in Travis. Then: git checkout master git merge topic-branch git push It's

Re: FVWM: pull requests

On Sat, Oct 22, 2016 at 05:11:46PM +0100, Dominik Vogt wrote: > Yes, but that's actually not the part I was asking about. How the > "git pull-request" should look like is not in the docs. OK. For that, you'd have to use their web interface. See:

Re: FVWM: problems with png support

On Fri, Oct 21, 2016 at 10:12:01AM +0200, Volker wrote: > I updated (from cvs) to the latest version in git, but > unfortunately lost png support under the transition. This should be fixed now on master; please check. -- Thomas Adam

Re: FVWM: pull requests

On 23/10/16 02:54, Thomas Adam wrote: > On Sat, Oct 22, 2016 at 05:11:46PM +0100, Dominik Vogt wrote: >> > Yes, but that's actually not the part I was asking about. How the >> > "git pull-request" should look like is not in the docs. > OK. For that, you'd have to use their web interface. See: >

Re: FVWM: pull requests

On Sun, Oct 23, 2016 at 06:52:46AM +1000, Stuart Longland wrote: > On 23/10/16 02:54, Thomas Adam wrote: > > On Sat, Oct 22, 2016 at 05:11:46PM +0100, Dominik Vogt wrote: > >> > Yes, but that's actually not the part I was asking about. How the > >> > "git pull-request" should look like is not in

Re: FVWM: pull requests

On Sun, Oct 23, 2016 at 07:21:55AM +1000, Stuart Longland wrote: > On Git flow projects, master branch is always the latest stable release. I'm aware of git-flow, and it sucks. A solution to a problem which for most project won't exist. If you were to do: % git checkout master && git pull

Re: FVWM: [dominik.v...@gmx.de: Removing libstroke support?]

On Mon, 17 Oct 2016 23:01:00 tho...@fvwm.org wrote: > On Mon, Oct 17, 2016 at 10:57:58PM +0100, Dominik Vogt wrote: > > On Mon, 17 Oct 2016 22:55:56 wrote: > > > > Does anybody really use libstroke support? It's resonsible for > > quite some hardly readably code, and I

[fvwmorg/fvwm] 6afa5b: PNG support: complain if --disable-png missing

Branch: refs/heads/master Home: https://github.com/fvwmorg/fvwm Commit: 6afa5b34640eba525e3586f0735c0ddab78487d7 https://github.com/fvwmorg/fvwm/commit/6afa5b34640eba525e3586f0735c0ddab78487d7 Author: Thomas Adam Date: 2016-10-22 (Sat, 22 Oct 2016)

Re: [fvwmorg/fvwm] 5b3250: Fix gettext write to read only string; fix warning...

On Sat, Oct 22, 2016 at 03:42:13PM +0100, Dominik Vogt wrote: > Proof reading this patch would also be helpful. I've taken a look. It's fine. I can't say I like the void casts all over the place -- what's wrong with giving a default value? However, since I'm using FreeBSD and hence clang,

Re: Final long term stable version

On Sat, Oct 22, 2016 at 01:19:57PM +0100, Thomas Adam wrote: > On Mon, Oct 17, 2016 at 11:20:25PM +0100, Dominik Vogt wrote: > > * From version X+1 onwards, no guarantees are made about > >continued support of obscure features, until there's an > >official fvwm-3.0. > > I am looking at

[fvwmorg/fvwm] 5b3250: Fix gettext write to read only string; fix warning...

Branch: refs/heads/dv-gcc-warning-fixes Home: https://github.com/fvwmorg/fvwm Commit: 5b325057dc569621230a2326d1640dcb07cacdb1 https://github.com/fvwmorg/fvwm/commit/5b325057dc569621230a2326d1640dcb07cacdb1 Author: Dominik Vogt Date: 2016-10-22 (Sat, 22

Re: [fvwmorg/fvwm] 5b3250: Fix gettext write to read only string; fix warning...

On Sat, Oct 22, 2016 at 06:19:46PM +0100, Thomas Adam wrote: > On Sat, Oct 22, 2016 at 03:42:13PM +0100, Dominik Vogt wrote: > > Proof reading this patch would also be helpful. > > I've taken a look. It's fine. I can't say I like the void casts all over the > place -- what's wrong with giving a

Re: [fvwmorg/fvwm] 5b3250: Fix gettext write to read only string; fix warning...

Proof reading this patch would also be helpful. On Sat, Oct 22, 2016 at 07:36:12AM -0700, GitHub wrote: > Branch: refs/heads/dv-gcc-warning-fixes > Home: https://github.com/fvwmorg/fvwm > Commit: 5b325057dc569621230a2326d1640dcb07cacdb1 > >

[fvwmorg/fvwm] 6afa5b: PNG support: complain if --disable-png missing

Branch: refs/heads/ta/revamp-png-support Home: https://github.com/fvwmorg/fvwm Commit: 6afa5b34640eba525e3586f0735c0ddab78487d7 https://github.com/fvwmorg/fvwm/commit/6afa5b34640eba525e3586f0735c0ddab78487d7 Author: Thomas Adam Date: 2016-10-22 (Sat, 22 Oct

Re: Final long term stable version

On Mon, Oct 17, 2016 at 11:20:25PM +0100, Dominik Vogt wrote: > While the enthusiasm to remove outdated stuff (strokes, Xinerama, > colourmaps, old parser etc.) is an important step towards a > maintainable and nice future fvwm3, there are certainly some old > systems still running that use some

Re: Make output

On Sat, Oct 22, 2016 at 02:42:06PM +0100, Dominik Vogt wrote: > What has happened to the make output, and how do I get it back. Either: ./configure --disable-silent-rules or: make V=1 -- Thomas Adam

Re: Final long term stable version

On Sat, Oct 22, 2016 at 02:25:53PM +0100, Dominik Vogt wrote: > On Sat, Oct 22, 2016 at 01:19:57PM +0100, Thomas Adam wrote: > > On Mon, Oct 17, 2016 at 11:20:25PM +0100, Dominik Vogt wrote: > > > * From version X+1 onwards, no guarantees are made about > > >continued support of obscure

Broken code spans in DEVELOPERS.md

With markdown-1.0.1 the code spans in DEVELOPERS.md come out all broken when converting the file to html, and I don't get how to do it right. Viewed with seamonkey they looks like this. -- git checkout topic/branch git rebase origin/master git checkout master git merge topic/branch git push --

Re: [fvwmorg/fvwm] b753a0: Remove stale files

On Thu, Aug 11, 2016 at 04:23:47PM -0700, GitHub wrote: > Branch: refs/heads/ta/install > Home: https://github.com/fvwmorg/fvwm > Commit: b753a06d2eb0325fd682563fcc127acbd6cf7813 > > https://github.com/fvwmorg/fvwm/commit/b753a06d2eb0325fd682563fcc127acbd6cf7813 > Author: Thomas

[fvwmorg/fvwm] 3e33ca: FVWM.md: WIP for ideas...

Branch: refs/heads/ta/next Home: https://github.com/fvwmorg/fvwm Commit: 3e33ca238ecf4a42dbf45238a0575db2b2399326 https://github.com/fvwmorg/fvwm/commit/3e33ca238ecf4a42dbf45238a0575db2b2399326 Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct 2016)

Re: regression from 2.6.5 to 2.6.6 ?

On Sat, Oct 22, 2016 at 07:26:50PM -0300, zli...@ns.sympatico.ca wrote: > On Sun, Jul 17, 2016 at 15:08 (+0100), Thomas Adam wrote: > > > On Sun, Jul 17, 2016 at 08:38:10AM -0300, zli...@ns.sympatico.ca wrote: > >> On Sat, Jul 16, 2016 at 23:27 (+0100), Thomas Adam wrote: > > >>> On Sat, Jul 16,

Re: regression from 2.6.5 to 2.6.6 ?

On Sat, Oct 22, 2016 at 08:36:10PM -0300, zli...@ns.sympatico.ca wrote: > On Sun, Oct 23, 2016 at 00:20 (+0100), Thomas Adam wrote: > > > On Sat, Oct 22, 2016 at 07:56:31PM -0300, zli...@ns.sympatico.ca wrote: > >> I cloned the git version about 15 minutes ago and compiled it, and > >> acroread

[fvwmorg/fvwm] 58d1a6: NEWS: formatting tweaks

Branch: refs/heads/master Home: https://github.com/fvwmorg/fvwm Commit: 58d1a64671c12e93554dd48e6112f6c6e0d921ed https://github.com/fvwmorg/fvwm/commit/58d1a64671c12e93554dd48e6112f6c6e0d921ed Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct 2016)

Re: [fvwmorg/fvwm] 58d1a6: NEWS: formatting tweaks

On Sat, Oct 22, 2016 at 06:42:08PM -0700, GitHub wrote: > Branch: refs/heads/ta/reluctant-news > Home: https://github.com/fvwmorg/fvwm > Commit: 58d1a64671c12e93554dd48e6112f6c6e0d921ed > > https://github.com/fvwmorg/fvwm/commit/58d1a64671c12e93554dd48e6112f6c6e0d921ed > Author:

Re: [fvwmorg/fvwm] 5b3250: Fix gettext write to read only string; fix warning...

On Sat, Oct 22, 2016 at 10:04:39PM +0100, Thomas Adam wrote: > On Sat, Oct 22, 2016 at 07:55:01PM +0100, Dominik Vogt wrote: > > Yes, but that does not fix the warning. "x" is unused because of > > the dummy replacement of the function call. The compiler does not > > see that if "x = 0" is ever

[fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

Branch: refs/heads/master Home: https://github.com/fvwmorg/fvwm Commit: c0ae18064466425f3864bd1e3baf03815cae4a44 https://github.com/fvwmorg/fvwm/commit/c0ae18064466425f3864bd1e3baf03815cae4a44 Author: Dominik Vogt Date: 2016-10-22 (Sat, 22 Oct 2016)

Need of a "devel" branch?

In the times of CVS we've pushed every dirty commit to the one CVS branch we had, undoing things if need be. Nowadays using Git I feel really unconfortable doing this, not everything should be pushed to the stable branch right away. Although we do have topic branches with proposed changes now

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

On Sat, Oct 22, 2016 at 10:53:10PM +0100, Dominik Vogt wrote: > Different approach at fixing the warning. Hopefully this one > works without removing any "uninitialised variable" warnings. The > macro SUPPRESS_UNUSED_VAR_WARNING(var) from config.h is used to > remove the "set but not used"

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

On Sat, Oct 22, 2016 at 11:02:16PM +0100, Dominik Vogt wrote: > On Sat, Oct 22, 2016 at 10:55:39PM +0100, Thomas Adam wrote: > > OK, this looks better. Thanks! > > > > GCC/Clang don't moan at these changes, which is good. The changes built via > > travis-ci just fine. > > > > I say you're good

Re: Need of a "devel" branch?

On Sat, Oct 22, 2016 at 11:12:58PM +0100, Dominik Vogt wrote: > A "devel" branch could come in handy. When a feature is complete > or ready for reviews, the patches are placed on the devel branch > and then every ambitious user can try them out and report > problems. The "devel" branch would

[fvwmorg/fvwm] f160e7: Reinstate NEWS file

Branch: refs/heads/master Home: https://github.com/fvwmorg/fvwm Commit: f160e7806648e7a1cc5b7f42eba393ed30913d4a https://github.com/fvwmorg/fvwm/commit/f160e7806648e7a1cc5b7f42eba393ed30913d4a Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct 2016)

Re: [fvwmorg/fvwm] b753a0: Remove stale files

On Sun, Oct 23, 2016 at 01:55:38AM +0100, Dominik Vogt wrote: > On Sun, Oct 23, 2016 at 01:32:17AM +0100, Thomas Adam wrote: > > On Sun, Oct 23, 2016 at 01:28:17AM +0100, Dominik Vogt wrote: > > > On Thu, Aug 11, 2016 at 04:23:47PM -0700, GitHub wrote: > > > > Branch: refs/heads/ta/install > > >

Re: regression from 2.6.5 to 2.6.6 ?

On Sat, Oct 22, 2016 at 10:00:16PM -0300, zli...@ns.sympatico.ca wrote: > On Sun, Oct 23, 2016 at 01:21 (+0100), Dominik Vogt wrote: > > > On Sat, Oct 22, 2016 at 08:36:10PM -0300, zli...@ns.sympatico.ca wrote: > >> On Sun, Oct 23, 2016 at 00:20 (+0100), Thomas Adam wrote: > > >>> On Sat, Oct

[zli...@ns.sympatico.ca: Re: regression from 2.6.5 to 2.6.6 ?]

- Forwarded message from zli...@ns.sympatico.ca - Date: Sat, 22 Oct 2016 22:00:16 -0300 From: zli...@ns.sympatico.ca To: Dominik Vogt Subject: Re: regression from 2.6.5 to 2.6.6 ? User-Agent: Mutt/1.6.1 (2016-04-27) On Sun, Oct 23, 2016 at 01:21 (+0100), Dominik

Re: regression from 2.6.5 to 2.6.6 ?

On Sun, Jul 17, 2016 at 15:08 (+0100), Thomas Adam wrote: > On Sun, Jul 17, 2016 at 08:38:10AM -0300, zli...@ns.sympatico.ca wrote: >> On Sat, Jul 16, 2016 at 23:27 (+0100), Thomas Adam wrote: >>> On Sat, Jul 16, 2016 at 07:10:24PM -0300, zli...@ns.sympatico.ca wrote: I recently upgraded a

Re: Need of a "devel" branch?

On Sat, Oct 22, 2016 at 11:41:54PM +0100, Dominik Vogt wrote: > Unless we're doing lots of disruptive stuff I'd prefer to > propagate completed patchsets into master early so they get more > testing. Yup. Well, that's what we have enforced right now, so I think it's working as intended. Of

Re: Final long term stable version

On Sat, Oct 22, 2016 at 01:19:57PM +0100, Thomas Adam wrote: > On the back of the current TODO.md file, I'll draft a list of key-features as > I see them and send it out for review/discussion here. I've tentatively started a skeleton file to collate ideas. See the 'ta/next' branch in git, hence:

[fvwmorg/fvwm] abed4e: NEWS: changes since 2.6.6

Branch: refs/heads/ta/reluctant-news Home: https://github.com/fvwmorg/fvwm Commit: abed4eae18d0852f3a1b5a943221bb2147328417 https://github.com/fvwmorg/fvwm/commit/abed4eae18d0852f3a1b5a943221bb2147328417 Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct

Re: [fvwmorg/fvwm] 64d424: DEVELOPERS: mention NEWS file

On Sat, Oct 22, 2016 at 06:32:12PM -0700, GitHub wrote: > Branch: refs/heads/ta/reluctant-news > Home: https://github.com/fvwmorg/fvwm > Commit: 64d4244746754610a64ed35de9ca69e557d3e25a > > https://github.com/fvwmorg/fvwm/commit/64d4244746754610a64ed35de9ca69e557d3e25a > Author:

Re: Need of a "devel" branch?

On Sat, Oct 22, 2016 at 11:23:17PM +0100, Thomas Adam wrote: > On Sat, Oct 22, 2016 at 11:12:58PM +0100, Dominik Vogt wrote: > > A "devel" branch could come in handy. When a feature is complete > > or ready for reviews, the patches are placed on the devel branch > > and then every ambitious user

Re: [fvwmorg/fvwm] b753a0: Remove stale files

On Sun, Oct 23, 2016 at 01:28:17AM +0100, Dominik Vogt wrote: > On Thu, Aug 11, 2016 at 04:23:47PM -0700, GitHub wrote: > > Branch: refs/heads/ta/install > > Home: https://github.com/fvwmorg/fvwm > > Commit: b753a06d2eb0325fd682563fcc127acbd6cf7813 > > > >

Re: [fvwmorg/fvwm] b753a0: Remove stale files

On Sun, Oct 23, 2016 at 01:32:17AM +0100, Thomas Adam wrote: > On Sun, Oct 23, 2016 at 01:28:17AM +0100, Dominik Vogt wrote: > > On Thu, Aug 11, 2016 at 04:23:47PM -0700, GitHub wrote: > > > Branch: refs/heads/ta/install > > > Home: https://github.com/fvwmorg/fvwm > > > Commit:

[fvwmorg/fvwm] f160e7: Reinstate NEWS file

Branch: refs/heads/ta/reluctant-news Home: https://github.com/fvwmorg/fvwm Commit: f160e7806648e7a1cc5b7f42eba393ed30913d4a https://github.com/fvwmorg/fvwm/commit/f160e7806648e7a1cc5b7f42eba393ed30913d4a Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct

Re: [fvwmorg/fvwm] b753a0: Remove stale files

On Sun, Oct 23, 2016 at 01:55:38AM +0100, Dominik Vogt wrote: > The NEWS file has been a readable summary of user visible changes. > I don't see how this could be generated from commit information > and diffs in git. It's back. -- Thomas Adam

[fvwmorg/fvwm] 64d424: DEVELOPERS: mention NEWS file

Branch: refs/heads/ta/reluctant-news Home: https://github.com/fvwmorg/fvwm Commit: 64d4244746754610a64ed35de9ca69e557d3e25a https://github.com/fvwmorg/fvwm/commit/64d4244746754610a64ed35de9ca69e557d3e25a Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct

[fvwmorg/fvwm] abed4e: NEWS: changes since 2.6.6

Branch: refs/heads/master Home: https://github.com/fvwmorg/fvwm Commit: abed4eae18d0852f3a1b5a943221bb2147328417 https://github.com/fvwmorg/fvwm/commit/abed4eae18d0852f3a1b5a943221bb2147328417 Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct 2016)

Re: Final long term stable version

On Sat, Oct 22, 2016 at 01:19:57PM +0100, Thomas Adam wrote: > On Mon, Oct 17, 2016 at 11:20:25PM +0100, Dominik Vogt wrote: > I am looking at releasing 2.6.7 this weekend. AFAIAC, this release will be > the last stable/supported version. Up to this point I've installed all > optional libraries

[fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

Branch: refs/heads/dv-gcc-warning-fixes Home: https://github.com/fvwmorg/fvwm Commit: c0ae18064466425f3864bd1e3baf03815cae4a44 https://github.com/fvwmorg/fvwm/commit/c0ae18064466425f3864bd1e3baf03815cae4a44 Author: Dominik Vogt Date: 2016-10-22 (Sat, 22

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

Different approach at fixing the warning. Hopefully this one works without removing any "uninitialised variable" warnings. The macro SUPPRESS_UNUSED_VAR_WARNING(var) from config.h is used to remove the "set but not used" warning in the discussed case. I've forced a new version of the branch

Re: regression from 2.6.5 to 2.6.6 ?

On Sat, Oct 22, 2016 at 23:29 (+0100), Thomas Adam wrote: > On Sat, Oct 22, 2016 at 07:26:50PM -0300, zli...@ns.sympatico.ca wrote: >> On Sun, Jul 17, 2016 at 15:08 (+0100), Thomas Adam wrote: >>> On Sun, Jul 17, 2016 at 08:38:10AM -0300, zli...@ns.sympatico.ca wrote: On Sat, Jul 16, 2016

Re: regression from 2.6.5 to 2.6.6 ?

On Sat, Oct 22, 2016 at 07:56:31PM -0300, zli...@ns.sympatico.ca wrote: > I cloned the git version about 15 minutes ago and compiled it, and > acroread still does not go full-screen correctly. Can you reproduce this using a more accessible program, please? I'm using FreeBSD. -- Thomas Adam

Re: regression from 2.6.5 to 2.6.6 ?

On Sun, Oct 23, 2016 at 00:20 (+0100), Thomas Adam wrote: > On Sat, Oct 22, 2016 at 07:56:31PM -0300, zli...@ns.sympatico.ca wrote: >> I cloned the git version about 15 minutes ago and compiled it, and >> acroread still does not go full-screen correctly. > Can you reproduce this using a more

Re: regression from 2.6.5 to 2.6.6 ?

As a little bit of explanation how to read this output: On Sat, Oct 22, 2016 at 10:00:16PM -0300, zli...@ns.sympatico.ca wrote: > cre: 935(1) 0(2) 985(0)x1080(0) fw 0x00401005 w 0x06200031 ew 0x06200031 > 'Adobe Reader' ^^^ ^^^ ^^^ ^^ X Y Width

[fvwmorg/fvwm] 58d1a6: NEWS: formatting tweaks

Branch: refs/heads/ta/reluctant-news Home: https://github.com/fvwmorg/fvwm Commit: 58d1a64671c12e93554dd48e6112f6c6e0d921ed https://github.com/fvwmorg/fvwm/commit/58d1a64671c12e93554dd48e6112f6c6e0d921ed Author: Thomas Adam Date: 2016-10-23 (Sun, 23 Oct

Re: [fvwmorg/fvwm] 5b3250: Fix gettext write to read only string; fix warning...

On Sat, Oct 22, 2016 at 07:55:01PM +0100, Dominik Vogt wrote: > Yes, but that does not fix the warning. "x" is unused because of > the dummy replacement of the function call. The compiler does not > see that if "x = 0" is ever executed, Fxyz_some_func always has a > non-empty definition. > >

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

On Sat, Oct 22, 2016 at 10:55:39PM +0100, Thomas Adam wrote: > OK, this looks better. Thanks! > > GCC/Clang don't moan at these changes, which is good. The changes built via > travis-ci just fine. > > I say you're good to merge to master. Good. I think I've also figured out how these safety

Re: regression from 2.6.5 to 2.6.6 ?

On Sun, Oct 23, 2016 at 02:23 (+0100), Dominik Vogt wrote: > On Sat, Oct 22, 2016 at 10:00:16PM -0300, zli...@ns.sympatico.ca wrote: >> On Sun, Oct 23, 2016 at 01:21 (+0100), Dominik Vogt wrote: >>> On Sat, Oct 22, 2016 at 08:36:10PM -0300, zli...@ns.sympatico.ca wrote: On Sun, Oct 23, 2016

Re: Final long term stable version

On Sun, Oct 23, 2016 at 03:12:19AM +0100, Dominik Vogt wrote: > On Sat, Oct 22, 2016 at 01:19:57PM +0100, Thomas Adam wrote: > > On Mon, Oct 17, 2016 at 11:20:25PM +0100, Dominik Vogt wrote: > > I am looking at releasing 2.6.7 this weekend. AFAIAC, this release will be > > the last