confirm, it is a crash during the allocation of s->unique_id. The
commit 451c5a88 fixes this bug.
--
Christopher Faulet
rch.
Hi,
Just for the record. I worked on this issue with Marco off-list. And a
fix was merged and backported to 1.9. For details, see
git.haproxy.org/?p=haproxy.git;a=commit;h=6cdaf2ad
--
Christopher Faulet
Le 09/02/2019 à 10:47, Aleksandar Lazic a écrit :
Hi Christopher.
Am 07-02-2019 22:09, schrieb Christopher Faulet:
Hi,
This patch adds a new component in contrib. It is a Prometheus
exporter for HAProxy.
[snipp]
More details in the README.
I'm not especially a Prometheus expert. And I
ion before investigating. Could you provide more
information on the way you perform your benchmark. I also need to take a
look on your HAProxy and spoe configurations. And finally, let me known
how you start the agent.
Regards,
--
Christopher Faulet
isable the HTX by setting the directive "no option
http-use-htx" in your default section.
It could also be helpful to have the request headers as sent from IE and from FF
and the response headers as sent from your server.
--
Christopher Faulet
or ? Do you have any logs that could help to understand what's happening ?
--
Christopher Faulet
goto out;
Thanks, merged now.
--
Christopher Faulet
we want to try to fix before. But if we don't have any
fix by Wednesday, we will do the 2.0.1 as is.
--
Christopher Faulet
}
For other patches, it seems to be good.
--
Christopher Faulet
=haproxy-1.8.git
Changelog: http://www.haproxy.org/download/1.8/src/CHANGELOG
Cyril's HTML doc : http://cbonte.github.io/haproxy-dconv/
---
Complete changelog :
Christopher Faulet (9):
BUG/MAJOR: spoe: Fix initialization of thread-dependent fields
BUG/MAJOR: stats: Fix how
failed and waste resources.
Good catch. The fix was merged in upstream and backported to 1.9 and 1.8.
Thanks,
--
Christopher Faulet
e commit messages to follow CONTRIBUTING guidelines.
Please, try to follow them as far as possible the next time.
Regards,
--
Christopher Faulet
/haproxy.c:2648
#8 run_thread_poll_loop (data=) at src/haproxy.c:2713
#9 0x7f73bbae6dd5 in start_thread () from /lib64/libpthread.so.0
#10 0x7f73ba81fead in clone () from /lib64/libc.so.6
It seems related to the last commits from Christopher Faulet, maybe
around this commit:
http
Le 19/04/2019 à 11:40, William Dauchy a écrit :
Hi,
On Fri, Apr 19, 2019 at 6:26 AM Willy Tarreau wrote:
Good catch but in my opinion we should instead fix the called function
(h1_skip_chunk_crlf). h1_skip_chunk_size() properly deals with the case
where start==stop, but h1_skip_chunk_crlf()
Hi Maksim,
The bug should now be fixed. See commit 6c7e96a3e for details. The commit was
backported to 2.0 and 1.9.
Thanks !
--
Christopher Faulet
to 1.0.
--
Christopher Faulet
>From 955c47ce6e8bf8a1ed644ffd353b52b54516c2fa Mon Sep 17 00:00:00 2001
From: Christopher Faulet
Date: Fri, 5 Jul 2019 16:25:34 +0200
Subject: [PATCH] WIP: spoa_server: Downgrade SPOP version to 1.0
---
contrib/spoa_server/spoa.c | 6 +++---
contrib/spoa_ser
...).
--
Christopher Faulet
Le 03/07/2019 à 10:24, Aleksandar Lazic a écrit :
Hi.
I have added some hints into the spoa_server.
Thanks Thierry for the nice server ;-)
Thanks, merged now.
--
Christopher Faulet
ir positions.
Hope it helps :)
--
Christopher Faulet
_IP' => '217.73.20.190',
'HTTP_X_SERVER_PORT' => '22696',
'HTTP_X_SERVER_IP' => '217.73.20.190’,
Hi,
For the record, I closed the issue on Github. I guess it is a problem with the
server. I've made some tests, and the HTTP request's headers are set to the
right values.
Regards,
--
side, you can remove the header "Cache-Control" before using the
cache. But, IMHO, it is a really bad idea. If the client set this header, it is
on purpose (or it should be).
--
Christopher Faulet
figuration to reproduce the bug.
--
Christopher Faulet
given");
+ goto error;
+ }
+
beg = smp_sz_str;
end = beg + strlen(beg);
new_smp_sz = read_uint((const char **), end);
Thanks, merged now.
--
Christopher Faulet
/git/haproxy-2.0.git/
Git Web browsing : http://git.haproxy.org/?p=haproxy-2.0.git
Changelog: http://www.haproxy.org/download/2.0/src/CHANGELOG
Cyril's HTML doc : http://cbonte.github.io/haproxy-dconv/
---
Complete changelog :
Christopher Faulet (14):
BUG/MEDIUM: h2/htx: Update da
ontent-length) -m found }
http-response del-header content-length
As said, it is ugly. But it does the trick for now. I will probably try to work
on a solution for the 2.1. Even more so the legacy HTTP will be removed for
this release.
--
Christopher Faulet
email" ?
--
Christopher Faulet
Le 12/07/2019 à 15:56, David Pirotte a écrit :
Sure thing, Christopher. Patch is attached. Thanks!
Thanks ! merged now.
--
Christopher Faulet
Le 12/07/2019 à 16:20, Christopher Faulet a écrit :
Le 12/07/2019 à 15:56, David Pirotte a écrit :
Sure thing, Christopher. Patch is attached. Thanks!
Thanks ! merged now.
Sorry, forgot to mention. I slightly amended you patch to also set t_handshake
to 0 to have the right Th time
this topic?
Hi Aleks,
Could you check with the latest 2.0 snapshot ? An issue about Prometheus was
fixed (#151 on GitHub). And some others about connections.
--
Christopher Faulet
your FDs issue on HAProxy
1.9.
--
Christopher Faulet
, it has not been backported yet in HAProxy 1.8.
Thanks,
--
Christopher Faulet
Le 10/04/2019 à 08:44, Kevin Zhu a écrit :
-- Forwarded message -
From: *Kevin Zhu* mailto:ip0...@gmail.com>>
Date: Wed, 10 Apr 2019 at 14:25
Subject: Re: haproxy1.9, SPOA: too many open files
To: Christopher Faulet mailto:cfau...@haproxy.com>>
Thinks reply.
OS:
ol to call it from the dummy library,
in wurfl_lookup(). This way, we will be able to test this part.
Regards,
--
Christopher Faulet
da_haproxy_fetch().
Regards,
--
Christopher Faulet
oxy.org/git/haproxy-1.9.git/
Git Web browsing : http://git.haproxy.org/?p=haproxy-1.9.git
Changelog: http://www.haproxy.org/download/1.9/src/CHANGELOG
Cyril's HTML doc : http://cbonte.github.io/haproxy-dconv/
---
Complete changelog :
Christopher Faulet (28):
BUG
a bug in all HTTP sample fetches. So, your segfault is
not related to the cache but to the way HTTP sample fetches work. I
pushed fixes in the upstream and backported them in HAProxy-1.9. It
should be ok now.
Thanks !
--
Christopher Faulet
in 1.9. The compilation
doesn't fail because the EXTRA_OBJS variable only exists since the
version 2.0-dev1 :)
--
Christopher Faulet
est body.
[1] http://git.haproxy.org/?p=haproxy-1.9.git;a=commit;h=3f829a4b7
--
Christopher Faulet
istcat(out, types[appctx->st2], max) == -1 ||
Thanks, merged now.
--
Christopher Faulet
rted to 2.0. For details, see the commit
bd9e8428 (git.haproxy.org/?p=haproxy.git;a=commit;h=bd9e8428).
Thanks
--
Christopher Faulet
Cyril's HTML doc : http://cbonte.github.io/haproxy-dconv/
---
Complete changelog :
Adis Nezirovic (1):
BUG/MINOR: Missing stat_field_names (since f21d17bb)
Christopher Faulet (14):
BUG/MEDIUM: proto-http: Always start the parsing if there is no outgoing
data
BUG/MINOR: http-
sync mode.
--
Christopher Faulet
Le 17/09/2019 à 09:48, Илья Шипицин a écrit :
Willy, can you apply this ?
boringssl builds are bloody murder
пн, 16 сент. 2019 г. в 16:14, Илья Шипицин <mailto:chipits...@gmail.com>>:
please see attached patch
Merged.
--
Christopher Faulet
e hurt... or at
least, not more than before :)
Thanks Richard !
--
Christopher Faulet
Le 01/08/2019 à 11:17, Christopher Faulet a écrit :
Le 01/08/2019 à 06:17, Willy Tarreau a écrit :
Hi Richard,
On Wed, Jul 31, 2019 at 02:03:26PM -0700, Richard Russo wrote:
I've attached a patch to fix a bug in http sampling on raw connections. This
fixes crashes experienced with a frontend
section and
then my problems went away. Seems like a bug in HTX. Any info needed for
this one?
Hi,
Could you share your configuration please ?
And if possible, it could be good to check if you have same errors with HTTP/1
requests.
--
Christopher Faulet
mmit/03627245). It was backported to 2.0.
Could you check if it fixes your issue about 502 errors ?
For 504 errors, I have no idea for now.
--
Christopher Faulet
git.haproxy.org/?p=haproxy-2.0.git
Changelog: http://www.haproxy.org/download/2.0/src/CHANGELOG
Cyril's HTML doc : http://cbonte.github.io/haproxy-dconv/
---
Complete changelog :
Christopher Faulet (12):
BUG/MINOR: http_fetch: Fix http_auth/http_auth_group when called from TCP
r
ds
("option h1-case-adjust-bogus-client") and the other one for the backends
("option h1-case-adjust-bogus-server").
Best,
--
Christopher Faulet
don't know if your HAProxy already includes it or not. If not, please give it
a try. If your tests were made with this last commit, it means there is a bug
somewhere else.
--
Christopher Faulet
upgrade. But if you are using
HTTP/2, you must upgrade as soon as possible.
---
Complete changelog :
Christopher Faulet (13):
BUG/MEDIUM: stick-table: Properly handle "show table" with a data type
argument
BUG/MINOR: mux-h2: Be sure to have a connection to unsubcribe
BUG
configuration limit. And so on.
As said about the release 2.0.7, if you are using the HTTP/2, you must upgrade
as soon as possible. For others, please give 1.9.11 a try as it fixes many
issues.
---
Complete changelog :
Adis Nezirovic (1):
BUG/MINOR: Missing stat_field_names (since f21d17bb)
C
Le 17/09/2019 à 11:11, Christopher Faulet a écrit :
Le 16/09/2019 à 03:40, Kevin Zhu a écrit :
Sorry Crhistopher, have you look at this mail ?
On Mon, 2 Sep 2019 at 16:11, Kevin Zhu mailto:ip0...@gmail.com>> wrote:
Hi Christopher
SPOE engine-id is all same when nbproc is mor
AProxy. We are rather reluctant to do a quick patch.
Once said, the problem remains on your server side, because it aborts the
response transfer. I noticed the last WINDOW_UPDATE before the GOAWAY has a
length of 1. This may be related.
--
Christopher Faulet
s. What do you think about it ? If you said me
your way to select metrics is better from the Prometheus point of view, I'm ok
with that.
--
Christopher Faulet
>From 413eedf7814660218d2207e7be5e203433c399a7 Mon Sep 17 00:00:00 2001
From: Christopher Faulet
Date: Mon, 18 Nov 2019 14:47:0
Le 20/11/2019 à 21:23, William Dauchy a écrit :
Hi Christopher,
On Wed, Nov 20, 2019 at 02:56:28PM +0100, Christopher Faulet wrote:
Nice, Thanks for your feedback. It is merged now. And I'm on the backports
for the 2.0.
You apparently forgot to backport
commit 0d1c2a65e8370a770d01 (MINOR
?
If possible, could you try disabling the h2 on the frontend side ? It could help
to identify where the problem is.
Finally, have you already tested other 2.X versions without encountering the
problem?
Thanks,
--
Christopher Faulet
't have an error 403 because the variable txn.modsec.code is
negative, so the deny http-request rule is never triggered. So, I guess your
error 400 comes from your webserver. You can enabled HTTP log to have more
information.
Finally, I notice some requests to the SPOA agent seems to have failed. The
variable is not set (- in the logs). You can try to enable SPOE logs in your
SPOE engine configuration. Take a look at the SPOE documentation (doc/SPOE.txt)
for more information.
--
Christopher Faulet
time_average_seconds
- haproxy_server_response_time_average_seconds
--
Christopher Faulet
Le 15/10/2019 à 13:19, Andrew Heberle a écrit :
On Tue, 15 Oct 2019 at 4:45 pm, Christopher Faulet <mailto:cfau...@haproxy.com>> wrote:
Le 14/10/2019 à 05:25, Andrew Heberle a écrit :
> Hi All,
>
> We have a virtual desktop deployment under V
e response is truncated.
Thanks,
--
Christopher Faulet
!
--
Christopher Faulet
to be
backported to 2.0.
Thanks,
Vedran
Merged now. Thanks Vedran ! Just note it must not be backported. The bug was
introduced by the commit da29fe2360 in the upstream. This commit was never
backported to 2.0 or below.
--
Christopher Faulet
is wrong or not. But with your patch, the weight is
now between 0 and 256. The function server_parse_weight_change_request() is ok
with that. So I can amend your comment if you want. I just want to have a
confirmation.
--
Christopher Faulet
that 0x4f is not a constant and would vary from run to run)
- To my understanding, the payload is chunk-encoded.
Hi,
Thanks to confirm. So it is indeed a problem of chunking fixed by the commit
e0f8dc576. The patch was backported to 2.0 and 1.9.
Thanks for your help,
--
Christopher Faulet
this client is able to handle HTTP headers in a case-insensitive manner ? In
HAProxy 2.0, HTTP headers names are sent in lower case when the HTX is enabled.
It may be a problem for bogus applications.
--
Christopher Faulet
corruption did you observe and how did you observe it ?
Finally, could you share your configuration please ?
Thanks,
--
Christopher Faulet
le's WURFL. (as far as 1.7)
Merged, thank you Miroslav !
--
Christopher Faulet
. Thus, this absolute URI will be reported in the logs.
It is independent on the platform. Note that most of time, H2 clients use the
absolute form for their requests.
--
Christopher Faulet
issue. You just requested haproxy.org in clear HTTP. Try in
HTTPS :)
--
Christopher Faulet
this part to avoid thinking default data.sint is set to ms
while reading the code.
Hi William,
You're right. I merged your patch. Thanks.
--
Christopher Faulet
eems you have
a configuration problem that which disturbs you in your tests.
--
Christopher Faulet
Le 29/10/2019 à 09:54, Ing. Andrea Vettori a écrit :
On 29 Oct 2019, at 09:39, Christopher Faulet <mailto:cfau...@haproxy.com>> wrote:
Le 28/10/2019 à 22:00, Christopher Faulet a écrit :
macbookpro:~ andreavettori$ curl --http2 -v http://g.testhost
[SNIP]
Here, it is the expected
Le 28/10/2019 à 22:00, Christopher Faulet a écrit :
macbookpro:~ andreavettori$ curl --http2 -v http://g.testhost
[SNIP]
Here, it is the expected behavior. HAProxy does not support explicit H2 upgrade.
In Fact, for this one, I was wrong. The result should be more or less the same
Le 29/10/2019 à 15:33, Ing. Andrea Vettori a écrit :
On 29 Oct 2019, at 10:20, Christopher Faulet <mailto:cfau...@haproxy.com>> wrote:
Please consider to use nghttp if possible. Curl does not give enough details
at the protocol layer. Also enable HTTP logs (option httplog in your
Le 22/10/2019 à 13:42, Baptiste a écrit :
My comment is wrong.
A server weight can have a value of 256.
Please update the comment :)
Ok, thanks. Merged now.
--
Christopher Faulet
Le 19/11/2019 à 16:48, William Dauchy a écrit :
On Tue, Nov 19, 2019 at 03:31:28PM +0100, Christopher Faulet wrote:
* also for `check_status`, there is the case of L7STS and its associated
values that are present in another field. Most probably it could benefit
from a better representation
Le 20/11/2019 à 13:03, William Dauchy a écrit :
On Tue, Nov 19, 2019 at 04:35:47PM +0100, Christopher Faulet wrote:
Here is updated patches with the support for "scope" and "no-maint"
parameters. If this solution is good enough for you (and if it works :), I
will push
some cases. If not we will do the backport on
our wide while waiting for the v2.1.
It can safely be backported to 2.0. It is not a critical component and it is
independent of other parts.
I will push a test based on your patch tomorrow on our side.
Ok, let me know if you encounter any issues.
Thanks,
--
Christopher Faulet
s exported.
--
Christopher Faulet
Le 19/11/2019 à 16:32, Tim Düsterhus a écrit :
Christopher,
Am 19.11.19 um 16:23 schrieb Christopher Faulet:
As mentioned in the documentation, HTTP processing is delayed waiting
the whole body is received or the request buffer is full. The condition
about the first chunk of a chunked request
Le 19/11/2019 à 14:51, Christopher Faulet a écrit :
Regarding the problem of servers in maintenance, since we parse the
query-string, it is possible to add more filters. I may add a parameter to
filter out servers in maintenance. For instance, by passing "no-maint" in the
query-s
ackend level, which was
not previously done with the CSV output.
It is feasible. But only counters may be aggregated. It may be enabled using a
parameter in the query-string. However, it is probably pertinent only when the
server metrics are filtered out. Because otherwise, Prometheus can handle the
aggregation itself.
--
Christopher Faulet
allocated to store the entire body.
About the buffers allocation, as for most of other objects dynamically allocated
in HAProxy, it uses memory pools to do so. The buffer size if 16k by default and
may be tuned via the "tune.bufsize" global directive.
Hope it helps,
--
Christopher Faulet
t is a bug. The host header must only by checked for the
requests. I will push a fix.
--
Christopher Faulet
Le 27/11/2019 à 11:59, Christopher Faulet a écrit :
Le 27/11/2019 à 04:03, Willy Tarreau a écrit :
On Wed, Nov 27, 2019 at 12:31:48AM +0100, Lukas Tribus wrote:
That said, I'm not sure this was really the intention of the change in
question (commit 531b83e03 "MINOR: h1: Reject req
ined to not dereference a null pointer. For
instance, the URI "/metric?scope" throws an error now. The second issue was
about the detection of the number sign (#).
Thanks,
--
Christopher Faulet
ue ("?a=").
The equal sign should probably be forbidden in a value (before decoding). For
instance, "/metrics?k1=val=ue" or "/metrics?k1==v1".
Finally, it could be good to stop the parsing on the number sign (#). To not
parse the fragment part of the uri, if any. The current version is also affected
by this issue.
--
Christopher Faulet
is a patch to add haproxy_server_check_status (ST_F_CHECK_STATUS) and
haproxy_server_check_code (ST_F_CHECK_CODE) metrics for each server. Does this
meet your needs ?
--
Christopher Faulet
>From 8bf04539cb3113769fce9ae1cc87e2b26868f966 Mon Sep 17 00:00:00 2001
From: Christopher Faulet
Date
mpty while it should not. This bug should be fixed
now in all HTX versions (2.2-dev, 2.1, 2.0 and 1.9).
Thanks,
--
Christopher Faulet
on http://g.testhost.com:82. It
could be also usefull to have the capture of a successfull request.
Sorry to bother you with all these stuff. But for now, I don't know where to
start my investigation.
Thanks,
--
Christopher Faulet
Le 21/11/2019 à 16:54, William Dauchy a écrit :
Hi Christopher,
On Tue, Nov 19, 2019 at 04:35:47PM +0100, Christopher Faulet wrote:
+/* Parse the query stirng of request URI to filter the metrics. It returns 1 on
+ * success and -1 on error. */
+static int promex_parse_uri(struct appctx
d the cache are two orthogonal feature.
You may use a dedicated cache for fcgi response, with specifics max-age and
max-object-size. About the "best" way to cache fcgi responses, it really depends
on your application. IMHO, it is your scripts responsibility to set the right
"Cache-Control" header.
Regards,
--
Christopher Faulet
old. Try to
upgrade them if possible. This way, we will be sure it is not a side effect of
an already fixed bug.
--
Christopher Faulet
uot; output
* haproxy configuration
* spoa-mirror version
* spoa-mirror configuration
* If possible, info about the mirror requests
--
Christopher Faulet
would be
haproxy_server_check_duration_seconds. About new_session_rate, I guess you mean
current_session_rate. This one was removed on purpose. It can be deduced from
sessions_total metric using Prometheus rate() function.
--
Christopher Faulet
runs ? (as far as I understand, each
test run generates unique id, so it should be ok)
Yes, it is safe to keep temp directories between 2 runs.
--
Christopher Faulet
-request del-header begin-with
http-request del-header end-with
http-request del-header match
It could be also extended to replace-header and replace-value actions.
Just my 2 cents,
--
Christopher Faulet
Le 24/01/2020 à 09:17, Willy Tarreau a écrit :
On Fri, Jan 24, 2020 at 08:28:33AM +0100, Christopher Faulet wrote:
Le 23/01/2020 à 19:59, James Brown a écrit :
I spent a couple of minutes and made the attached (pretty bad) patch to
add a del-header-by-prefix.
Just an idea. Instead of adding
backported the feature as far as 1.8. And for now, there is no release
planned.
Regards,
--
Christopher Faulet
201 - 300 of 729 matches
Mail list logo
