Re: [PHP-DEV] HYBRID VM

Hi Dmitry, - Original Message - From: "Dmitry Stogov" Sent: Wednesday, May 03, 2017 Hi, I propose a new VM instruction dispatch technique, that provides great speed up on small benchmarks (1.5 times on bench.php) Interesting. :-) How does this compare to pure GOTO dispatch...?

Re: [PHP-DEV] UGLY Benchmark Results for PHP Master 2016-08-05

Hi all, - Original Message - From: Sent: Friday, August 05, 2016 Results for project PHP master, build date 2016-08-05 06:26:56+03:00 commit: 65b6f20 previous commit: 69a72df revision date: 2016-08-04 22:27:42+02:00 environment: Haswell-EP cpu: Intel(R)

Re: [PHP-DEV] New HashTable implementation?

Now, after seeing Bogdan's hash optimization idea last month [2], and reading Nikita's blog post [3] again, I had some ideas I'd like to try -- assuming nobody else is planning major changes. :-) Besides Nikita, I'm addressing Dmitry and Xinchen because your names are on some minor hash items on

[PHP-DEV] New HashTable implementation?

Hi all, Last June, it was briefly mentioned about changing PHP's string hash function [1] (DJB33 *seems* pretty horrible, after all, as far as collisions...). So 8 months ago I tried almost, if not, a half-dozen of them (including Murmur3) that were simple enough to quickly toss in. The

Re: [PHP-DEV] Lazy keys comparison during hash lookups

Hi Bogdan, all, - Original Message - From: "Andone, Bogdan" Sent: Monday, April 25, 2016 -Original Message- From: Andone, Bogdan [mailto:bogdan.and...@intel.com] Sent: Friday, March 18, 2016 11:58 AM To: 'Nikita Popov' Cc: internals@lists.php.net Subject:

Re: [PHP-DEV] Safe timeout handling

Hi Bob, all, - Original Message From: "Bob Weinand" Sent: Wednesday, April 20, 2016 > Am 20.04.2016 um 18:22 schrieb Dmitry Stogov <dmi...@zend.com>: > > > > On 04/20/2016 06:24 PM, Matt Wilmas wrote: >> Hi Dmitry, >> >> - Origin

Re: [PHP-DEV] Safe timeout handling

Hi Dmitry, - Original Message - From: "Dmitry Stogov" Sent: Wednesday, April 20, 2016 Hi, It's a well known PHP problem, that exceeding of execution time-out (max_execution_time) may lead to unexpected crashes. They occur because PHP may be interrupted in inconsistent state, and

Re: [PHP-DEV] GOOD Benchmark Results for PHP Master 2016-03-18

Hi Yasuo, - Original Message - From: "Yasuo Ohgaki" Sent: Tuesday, March 22, 2016 Hi all, On Fri, Mar 18, 2016 at 9:30 PM, wrote: ---

[PHP-DEV] Re: [PHP-CVS] com php-src: Convert ASSIGN_ADD $a, $b into $a = ADD $a, $b, if possible.: ext/opcache/Optimizer/dfa_pass.c

Hi Dmitry, - Original Message - From: "Dmitry Stogov" Sent: Tuesday, March 22, 2016 Commit:d8b75b0807a5d94bd7b6b175d56aba8bc5be8d7a Author:Dmitry Stogov Tue, 22 Mar 2016 23:57:26 +0300 Parents: 76d612129bb6b67171308f43c19d7e4791d7919e Branches:

Re: [PHP-DEV] Re: Mysterious crashes (WAS: Re: Pear fetch script problem on PHP 7.0)

Hi Dmitry! - Original Message - From: "Dmitry Stogov" Sent: Tuesday, December 22, 2015 Hi Matt, On Tue, Dec 22, 2015 at 8:36 PM, Matt Wilmas <php_li...@realplain.com> wrote: Hi all, Lior, which compiler are you using? You can still reproduce the problem? Can yo

[PHP-DEV] Mysterious crashes (WAS: Re: Pear fetch script problem on PHP 7.0)

Hi all, Lior, which compiler are you using? You can still reproduce the problem? Can you run it through Valgrind? I'm getting random crashes I can't figure out on 64-bit Linux after just making a very trivial change. :-/ The backtrace is the same up to compile_file() (although maybe that

[PHP-DEV] Re: [INTERNALS-WIN] Re: [PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Anatol, - Original Message - From: "Anatol Belski" Sent: Wednesday, November 25, 2015 Hi Matt, -Original Message----- From: Matt Wilmas [mailto:php_li...@realplain.com] Sent: Monday, November 23, 2015 8:15 AM To: Anatol Belski <anatol@belski.net>; interna

Re: [PHP-DEV] Windows (Visual Studio) compiler stuff

tuff while doing other things, otherwise maybe I would have discovered this sooner! -Original Message----- From: Matt Wilmas [mailto:php_li...@realplain.com] Sent: Monday, November 23, 2015 2:28 AM To: internals@lists.php.net; internals-...@lists.php.net Cc: Dmitry Stogov <dmi...@zend

Re: [PHP-DEV] Re: Compilation fails without FAST_ZPP

Hi, - Original Message From: "Andrea Faulds" Sent: Monday, December 07, 2015 Hi Matt, Matt Wilmas wrote: Hi Bob, all, After this commit: http://git.php.net/?p=php-src.git;a=commitdiff;h=509712c7d9056b4ceb50134bfeea1a1115720744 In streamsfuncs.c, line 996 has an e

[PHP-DEV] Compilation fails without FAST_ZPP

Hi Bob, all, After this commit: http://git.php.net/?p=php-src.git;a=commitdiff;h=509712c7d9056b4ceb50134bfeea1a1115720744 In streamsfuncs.c, line 996 has an extra comma; and line 1511 has #ifdef instead of #ifndef ... BTW, maybe with the changes I'll propose, all this extra FAST_ZPP stuff

Re: [PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Anatol, Dmitry, all, Will reply about the original subject issues soon, but this is about new stuff I noticed the other day... Adding Matt Tait and Nikita because of PR #1418 and comments. Anyway, the new Control Flow Guard (/guard:cf) is causing a big slowdown on bench.php. :-( 14% on

Re: [PHP-DEV] Re: Windows (Visual Studio) compiler stuff

Hi Dmitry, - Original Message - From: "Dmitry Stogov" Sent: Monday, November 16, 2015 Hi Matt, On Mon, Nov 16, 2015 at 1:30 AM, Matt Wilmas <php_li...@realplain.com> wrote: Hi Dmitry, Anatol, Pierre (etc.), and all, I'm back now, I think, after a much longer (unin

[PHP-DEV] Re: [INTERNALS-WIN] Re: [PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Anatol, all, - Original Message - From: "Anatol Belski" Sent: Monday, November 16, 2015 Hi Matt, -Original Message----- From: Matt Wilmas [mailto:php_li...@realplain.com] Sent: Monday, November 16, 2015 2:59 PM To: Anatol Belski <anatol@belski.net>; interna

Re: [PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Anatol, - Original Message - From: "Anatol Belski" Sent: Monday, November 16, 2015 Hello Matt, -Original Message----- From: Matt Wilmas [mailto:php_li...@realplain.com] Sent: Sunday, November 15, 2015 11:31 PM To: internals@lists.php.net; internals-...@lists.php.net

[PHP-DEV] Windows (Visual Studio) compiler stuff

Hi Dmitry, Anatol, Pierre (etc.), and all, I'm back now, I think, after a much longer (unintentional) break than I expected. Be coming very soon with what I was doing in the summer (param parsing stuff) -- *now* it works with MSVC too, barring any fragility, as I accidentally discovered last

Re: [PHP-DEV] Re: Benchmark Results for PHP Master 2015-11-12

Hi, - Original Message - From: "Andrea Faulds" Sent: Friday, November 13, 2015 Hi, lp_benchmark_ro...@intel.com wrote: --- benchmark relative change since change

[PHP-DEV] Re: [PHP-CVS] com php-src: Allow an experimental VM with tail call dispatch technique (disabled by default). This VM may work only if all tail calls are optimized, otherwaise it will crach b

Hi Dmitry, Just curious about this. :-) For dispatching next opcode, isn't a tail call an indirect jmp instruction, just like a computed goto? So how is it different than GOTO executor...? Debugging/compatibility? (Unless it can work with MSVC -- oh nevermind, looks like it's only with

Re: [PHP-DEV] Re: [RFC] [DISCUSSION] More precise float value

Hi Yasuo, - Original Message - From: "Yasuo Ohgaki" Sent: Friday, September 18, 2015 Hi all, On Fri, Sep 4, 2015 at 9:41 AM, Yasuo Ohgaki wrote: IEEE 754 double cannot express exact float values. That said, float values expressed by

[PHP-DEV] Re: [PHP-CVS] com php-src: fix typo: Zend/zend_range_check.h

Hi Anatol :-), Just wanted to point out that those conditions (non-0 macros, of course) should use UNEXPECTED(), so their code block can be moved out of the way. (May already be happening with a return involved.) Although now, IF php_error_docref is involved, that *should* implicitly happen

Re: [PHP-DEV] Overflow checks and integral vars comparison

Hi Anatol, Dmitry, all, - Original Message - From: Anatol Belski Sent: Friday, August 21, 2015 Hi, Resending this as missed internals at the start. I was lately rethinking some part of the 64-bit RFC, and also seeing now Jakub's work on catching overflows in ext/openssl and Matt

Re: [PHP-DEV] Overflow checks and integral vars comparison

: Matt Wilmas [mailto:php_li...@realplain.com] Sent: Tuesday, August 25, 2015 12:06 PM To: Anatol Belski anatol@belski.net; 'Dmitry Stogov' dmi...@php.net; 'Xinchen Hui' xinche...@zend.com; 'Nikita Popov' nikita@gmail.com; 'Pierre Joye' pierre@gmail.com; 'Bob Weinand' bobw...@hotmail.com

Re: [PHP-DEV] Move to Fast ZPP?

/smallest parameter parsing we could imagine, across all of PHP! I guess that means start looking for it next week...? :-) I may just send a patch sooner without even writing up an explanation about parts first like I planned. More below... - Original Message - From: Matt Wilmas Sent

Re: [PHP-DEV] Re: Marking error, etc. functions as cold?

/Function-Attributes.html Thanks. Dmitry. Thanks, Matt On Mon, Aug 17, 2015 at 1:26 PM, Matt Wilmas php_li...@realplain.com wrote: Hi Dmitry, all, Has it been considered to use __attribute__((cold)) on, for example, error-type functions? I happened to notice this part about it in the GCC docs

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix possible overflow in openssl_pbkdf2: ext/openssl/openssl.c

Hi Anatol, Jakub, - Original Message - From: Jakub Zelenka Sent: Tuesday, August 18, 2015 On Tue, Aug 18, 2015 at 8:23 PM, Anatol Belski anatol@belski.net wrote: Hi Jakub, -Original Message- From: Jakub Zelenka [mailto:bu...@php.net] Sent: Tuesday, August 18, 2015

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix possible overflow in openssl_pbkdf2: ext/openssl/openssl.c

Hi Anatol, - Original Message - From: Anatol Belski Sent: Tuesday, August 18, 2015 Hi Matt, [...] The checks with zend_long vars like key_length and iterations are impossible when ZEND_LONG_MAX == INT_MAX (most if not all 32-bit, I guess). So those checks should already be

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix possible overflow in openssl_pbkdf2: ext/openssl/openssl.c

Hi Anatol, - Original Message - From: Anatol Belski Sent: Tuesday, August 18, 2015 Ok, got the idea now. But sizeof(size_t) is always sizeof(zend_long). And for signed, still it is simpler and safer to just use an #ifdef around. No, == like I said. :-) OK, just saw your correction

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix possible overflow in openssl_pbkdf2: ext/openssl/openssl.c

Hi Jakub, - Original Message - From: Jakub Zelenka Sent: Tuesday, August 18, 2015 On Tue, Aug 18, 2015 at 9:48 PM, Matt Wilmas php_li...@realplain.com wrote: Hi Anatol, Jakub, [...] The checks with zend_long vars like key_length and iterations are impossible when ZEND_LONG_MAX

[PHP-DEV] Marking error, etc. functions as cold?

Hi Dmitry, all, Has it been considered to use __attribute__((cold)) on, for example, error-type functions? I happened to notice this part about it in the GCC docs [1] a couple days ago: The paths leading to calls of cold functions within code are marked as unlikely by the branch prediction

Re: [PHP-DEV] Parameter parsing for zval type?

H Dmitry, - Original Message - From: Dmitry Stogov Sent: Tuesday, August 11, 2015 On Tue, Aug 11, 2015 at 11:10 PM, Matt Wilmas php_li...@realplain.com wrote: [...] Look at e.g. is_numeric() or strpos() (needle). Plain zval param parsing, so NO ZVAL_DEREF() occurs (FAST_ZPP

Re: [PHP-DEV] Parameter parsing for zval type?

Hi Nikita, - Original Message - From: Nikita Popov Sent: Tuesday, August 11, 2015 On Tue, Aug 11, 2015 at 10:10 PM, Matt Wilmas php_li...@realplain.com wrote: [...] Look at e.g. is_numeric() or strpos() (needle). Plain zval param parsing, so NO ZVAL_DEREF() occurs (FAST_ZPP

[PHP-DEV] Parameter parsing for zval type?

Hi Dmitry, all, Help me understand this. :-) It's been more puzzling to me recently since just coming to the part of optimizing traditional ZPP (sharing part with FAST_ZPP...). With the FAST_ZPP inline macros, why is there a Z_PARAM_ZVAL and Z_PARAM_ZVAL_DEREF? It seems the zpp 'z'

Re: [PHP-DEV] Parameter parsing for zval type?

Hi again, - Original Message - From: Matt Wilmas Sent: Tuesday, August 11, 2015 Hi Dmitry, all, Help me understand this. :-) It's been more puzzling to me recently since just coming to the part of optimizing traditional ZPP (sharing part with FAST_ZPP...). With the FAST_ZPP

Re: [PHP-DEV] Parameter parsing for zval type?

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Tuesday, August 11, 2015 Hi Matt, On Tue, Aug 11, 2015 at 9:00 PM, Matt Wilmas php_li...@realplain.com wrote: Hi again, - Original Message - From: Matt Wilmas Sent: Tuesday, August 11, 2015 Hi Dmitry, all, Help

Re: [PHP-DEV] Move to Fast ZPP?

Hi Levi, - Original Message - From: Levi Morrison Sent: Thursday, August 06, 2015 Don't know about Windows now... Visual Studio 2008 and 2012 (not much difference) are NOT optimizing away the code (other times it was GCC with issues). :-/ Not sure why. Of course they don't support

Re: [PHP-DEV] Move to Fast ZPP?

Hi Pierre, - Original Message - From: Pierre Joye Sent: Thursday, August 06, 2015 On Aug 6, 2015 1:49 PM, Matt Wilmas php_li...@realplain.com wrote: Hi Levi, - Original Message - From: Levi Morrison Sent: Thursday, August 06, 2015 Don't know about Windows now... Visual

Re: [PHP-DEV] Move to Fast ZPP?

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Monday, August 03, 2015 Hi Matt, On Wed, Jul 22, 2015 at 11:16 PM, Matt Wilmas php_li...@realplain.com wrote: Hi again Dmitry, all, Hopefully the final update on this, before all is revealed... :-) [...] I tried to rush

[PHP-DEV] Re: [PHP-CVS] com php-src: avoid unnecessary scoping: main/php_variables.c

Hi Anatol, - Original Message - From: Anatol Belski Sent: Friday, July 31, 2015 Commit:3a66a23679487f4feda699ada109ab2b675e9474 Author:Anatol Belski a...@php.net Fri, 31 Jul 2015 14:02:03 +0200 Parents: 7be9e69eafdb1828d09daecde5cd39112db3f581 Branches: master

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

Hi all, - Original Message - From: Matt Wilmas Sent: Wednesday, July 08, 2015 Hi Kalle, - Original Message - From: Kalle Sommer Nielsen Sent: Wednesday, July 08, 2015 Hi Matt 2015-07-08 17:00 GMT+02:00 Matt Wilmas php_li...@realplain.com: Hi all, - Original Message

Re: [PHP-DEV] Introduction and some opcache SSE related stuff

Hi Dmitry, Bogdan, - Original Message - From: Dmitry Stogov Sent: Thursday, July 30, 2015 Hi Bogdan, On Wed, Jul 29, 2015 at 5:22 PM, Andone, Bogdan bogdan.and...@intel.com wrote: Hi Guys, My name is Bogdan Andone and I work for Intel in the area of SW performance analysis and

Re: [PHP-DEV] Move to Fast ZPP?

Hi again Dmitry, all, Hopefully the final update on this, before all is revealed... :-) - Original Message - From: Matt Wilmas Sent: Tuesday, July 07, 2015 Hi again Dmitry, all, [...] Just an update... I didn't abandon this; quite the opposite! I thought I'd just put

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

Hi Kalle, - Original Message - From: Kalle Sommer Nielsen Sent: Wednesday, July 08, 2015 Hi Matt 2015-07-08 17:00 GMT+02:00 Matt Wilmas php_li...@realplain.com: Hi all, - Original Message - From: Levi Morrison Sent: Sunday, May 10, 2015 Again, this is a C11 feature

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

Hi all, - Original Message - From: Levi Morrison Sent: Sunday, May 10, 2015 Again, this is a C11 feature. It is supported by clang, gcc and MSVC. To clarify this a bit: they permit anonymous unions in C89 and C99 code (meaning you do not need to pass flags like -std=c11 to enable

Re: [PHP-DEV] Move to Fast ZPP?

Hi again Dmitry, all, - Original Message - From: Dmitry Stogov Sent: Monday, June 29, 2015 On Sat, Jun 27, 2015 at 12:36 AM, Matt Wilmas php_li...@realplain.com wrote: Hi Dmitry, all, [...] Yeah, I knew how the traditional ZPP worked, just wondered about any certain problem area

Re: [PHP-DEV] Headsup: PHP7 feature freeze

Hi Anatol, - Original Message - From: Anatol Belski Sent: Monday, July 07, 2015 Hi Matt, -Original Message- From: Matt Wilmas [mailto:php_li...@realplain.com] Sent: Tuesday, July 7, 2015 4:10 AM To: Internals; Kalle Sommer Nielsen Cc: Anatoliy Belsky; Dmitry Stogov; Nikita

Re: [PHP-DEV] Headsup: PHP7 feature freeze

Hello RMs, all! - Original Message - From: Kalle Sommer Nielsen Sent: Thursday, June 25, 2015 Howdy This is a quick heads up that we plan to have the next release of 7.0.0 be Beta 1, this marks a feature freeze and from there on, we will switch focus on to stabilization, regressions

Re: [PHP-DEV] Move to Fast ZPP?

Hi Dmitry, all, - Original Message - From: Dmitry Stogov Sent: Thursday, June 25, 2015 On Wed, Jun 24, 2015 at 1:35 PM, Matt Wilmas php_li...@realplain.com wrote: Hi Dmitry, all, - Original Message - From: Dmitry Stogov Sent: Wednesday, June 24, 2015 We should NOT use

Re: [PHP-DEV] Move to Fast ZPP?

Hi Levi, - Original Message - From: Levi Morrison Sent: Wednesday, June 24, 2015 On Wed, Jun 24, 2015 at 3:21 AM, Ferenc Kovacs tyr...@gmail.com wrote: On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi all, I'm wondering the state of Fast ZPP.

Re: [PHP-DEV] Move to Fast ZPP?

Hi Dmitry, all, - Original Message - From: Dmitry Stogov Sent: Wednesday, June 24, 2015 We should NOT use it everywhere. It'll lead to code bloat. Thanks. Dmitry. On Wed, Jun 24, 2015 at 12:21 PM, Ferenc Kovacs tyr...@gmail.com wrote: On Wed, Jun 24, 2015 at 3:42 AM, Yasuo Ohgaki

[PHP-DEV] Re: [PHP-CVS] com php-src: Make CALL VM with FP and IP in global registers not to return anything from opcode handlers. Set OPLINE to NULL to terminate VM loop instead. This saves 1 CPU inst

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Tuesday, June 16, 2015 Commit:48ed660cdf6fe94ac2cd8eac217ea97340766e75 Author:Dmitry Stogov dmi...@zend.com Tue, 16 Jun 2015 14:11:16 +0300 Parents: 3180b8e100285e5bd9088e9981608dfd14f6ff27 Branches: master

Re: [PHP-DEV] Undefined variables undefined order

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Wednesday, June 10, 2015 Hi Sara, https://gist.github.com/dstogov/6a90601872b538d2ddd6 I see no problems committing this (running tests now). Cool. :-) Just FYI, I noticed you didn't update ZEND_BOOL_XOR, at least...

Re: [PHP-DEV] Undefined variables undefined order

Hi Sara, - Original Message - From: Sara Golemon Sent: Wednesday, June 10, 2015 On Tue, Jun 9, 2015 at 6:05 AM, Matt Wilmas php_li...@realplain.com wrote: Hah, looks like this just changed last week after barely 3 weeks. :-P I didn't verify, just noticed the code change: http

Re: [PHP-DEV] Array dereferencing of scalars

Hi all, - Original Message - From: Yasuo Ohgaki Sent: Tuesday, June 09, 2015 Hi all, On Tue, Jun 9, 2015 at 6:21 AM, Stanislav Malyshev smalys...@gmail.com wrote: Would throwing a notice or a warning on array deferencing scalars be acceptable for PHP 7.0, or does this need an RFC?

Re: [PHP-DEV] Array dereferencing of scalars

Hi all, - Original Message - From: Christoph Becker Sent: Tuesday, June 09, 2015 Yasuo Ohgaki wrote: I fully agree that current behavior could be used meaningful ways. However, ?php $foo = 42; $foo['bar']; // = NULL $v = NULL; $v[0][1][2][3][4][5][6][7][8][9]; // NULL this

Re: [PHP-DEV] Undefined variables undefined order

Hi all, - Original Message - From: Sara Golemon Sent: Monday, May 11, 2015 On Mon, May 11, 2015 at 5:12 PM, Matt Wilmas php_li...@realplain.com wrote: - Original Message - From: Stanislav Malyshev smalys...@gmail.com Sent: Monday, May 11, 2015 argument. I'd like to propose

Re: [PHP-DEV] Undefined variables undefined order

Hi! - Original Message - From: Stanislav Malyshev smalys...@gmail.com Sent: Monday, May 11, 2015 Hi! argument. I'd like to propose making the order of evaluation defined by splitting this into separate statements: What is the purpose of this? I.e. why is it important that these

Re: [PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

Hi Anatol, all, Sorry for top post... Stas must be getting confused with all these details! :-) Is Pierre going to weigh in? Are there any other Windows people? While I don't think I'd disagree with much of what you've said, I don't see that using my patch is *causing* or *creating* new

[PHP-DEV] zend_mm_small_size_to_bit

Hi Dmitry, all, I was looking through a few parts of the new MM last week (cool, thanks! I will try soon on my Windows XP), and wasn't sure about the function in the subject... This: /* higher set bit number (0-0, 1-1, 2-2, 4-3, 8-4, 127-7, 128-8 etc) */ static zend_always_inline int

[PHP-DEV] Re: [PATCH] Microsecond resolution and accuracy on Windows

Hi Anatol! - Original Message - From: Anatol Belski Sent: Tuesday, September 02, 2014 Hi Matt, On Mon, September 1, 2014 20:36, Matt Wilmas wrote: Hi all! I'm back after several years, and will have a few more changes for Windows, at least. (It was CVS back then, so I still have

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

Hi Anatol, Stas, - Original Message - From: Anatol Belski Sent: Tuesday, September 02, 2014 On Mon, September 1, 2014 22:49, Stas Malyshev wrote: Hi! It's much more optimized than what's there now, and slightly over the old implementation. Not sure if I should give the saved patch

Re: [PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

Hi Anatol, - Original Message - From: Anatol Belski Sent: Tuesday, September 02, 2014 Unfortunately that's not a PR so I cannot comment there directly, so I'd leave a couple of the comments to the code here: It looks like there can be commit comments? *shrug* In the future, should

[PHP-DEV] [PATCH] Microsecond resolution and accuracy on Windows

Hi all! I'm back after several years, and will have a few more changes for Windows, at least. (It was CVS back then, so I still have to figure some things out... Just had to edit files on Github site. :-/) Anyway, this patch is for microtime, etc. on Windows XP-7. In March 2013, the fix

Re: [PHP-DEV] 5.4 non-security issues - last call

Hi Stas! - Original Message - From: Matt Wilmas Sent: Friday, August 29 Hi Stas, all! - Original Message - From: Stas Malyshev Sent: Thursday, August 28, 2014 Hi! 5.6.0 has been released, and first thing I'd like to congratulate all who participated in it with this great

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

Hi Stas, - Original Message - From: Stas Malyshev Sent: Monday, September 01, 2014 Hi! It's much more optimized than what's there now, and slightly over the old implementation. Not sure if I should give the saved patch link, or the live compare (?) on Github, so I'll do both for

[PHP-DEV] Re: [INTERNALS-WIN] [PATCH] Microsecond resolution and accuracy on Windows

Hi Stas, - Original Message - From: Stas Malyshev Sent: Monday, September 01, 2014 Hi! I'm also not sure how important it is how have it for 5.4. Does the problem that this patch fixes exist only in older versions of Windows or on all versions? What are the actual effects of this

Re: [PHP-DEV] 5.4 non-security issues - last call

Hi Stas, all! - Original Message - From: Stas Malyshev Sent: Thursday, August 28, 2014 Hi! 5.6.0 has been released, and first thing I'd like to congratulate all who participated in it with this great milestone. Second thing, that means 5.4.33 would be the last release including

Re: [PHP-DEV] zend_hash_update question

Hi David, - Original Message - From: David Zülke Sent: Monday, June 15, 2009 Hi folks, while fixing http://bugs.php.net/bug.php?id=48557 I was wondering why zend_hash_update doesn't automatically convert numeric strings to integers. Doing $foo = array('1' = 'bar'); actually

[PHP-DEV] Re: [PHP-CVS] cvs: php-src / README.PARAMETER_PARSING_API /win32/build config.w32 ZendEngine2 Zend.m4 zend_API.c zend_compile.c zend_execute.c zend_execute_API.c zend_operators.c zend_oper

didn't know if it would even be used -- just thinking more of it's there if someone wants the option... -Andrei - Matt Matt Wilmas wrote: mattwil Thu Jun 4 18:18:47 2009 UTC Modified files: /php-src README.PARAMETER_PARSING_API /ZendEngine2 Zend.m4 zend_API.c zend_compile.c

Re: [PHP-DEV] 5.3.0RC3

Hi Lukas, - Original Message - From: Lukas Kahwe Smith Sent: Wednesday, June 03, 2009 Aloha, Well we have waited long enough for a fix for re2c, but Johannes and I (based on Scott's advice) have now decided that we can live with the current hack that simply reverts to PHP 5.2

Re: [PHP-DEV] Re: [PATCH] double to long conversion change

Hi again, OK, I will go ahead and commit the patch + test updates in about 24 hours... - Matt - Original Message - From: Matt Wilmas Sent: Friday, May 29, 2009 Hi all, - Original Message - From: Matt Wilmas Sent: Friday, April 10, 2009 Hi Dmitry, I finally updated

[PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

Hi all, I first noticed this with preg_replace()'s /e modifier (SO many other issues with that...), but it also happens with create_function() and a few other places where zend_eval_string() is used. Other code evaluation in PHP is binary-safe, so it seems like these areas should be as well?

Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

Hi Andrei, all, - Original Message - From: Andrei Zmievski Sent: Wednesday, June 03, 2009 Matt Wilmas wrote: [...] Patches: http://realplain.com/php/binary_eval_string.diff http://realplain.com/php/binary_eval_string_5_3.diff Can they be applied? (Also a small optimization

Re: [PHP-DEV] [PATCH] create_function/zend_eval_string aren't binary-safe

Hi Johannes, - Original Message - From: Johannes Schlüter Sent: Wednesday, June 03, 2009 Hi, On Wed, 2009-06-03 at 13:45 -0500, Matt Wilmas wrote: I noticed there are several zend_eval_string() references in PECL sources [1], which would be a problem after adding a string length

Re: [PHP-DEV] Re: [PATCH] double to long conversion change

Hi all, - Original Message - From: Matt Wilmas Sent: Friday, April 10, 2009 Hi Dmitry, I finally updated the patches: http://realplain.com/php/dval_to_lval.diff http://realplain.com/php/dval_to_lval_5_3.diff The patches were updated again, against current CVS (no changes by me

Re: [PHP-DEV] Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int

Hi Rasmus, - Original Message - From: Rasmus Lerdorf Sent: Thursday, March 19, 2009 So, what is the final conclusion on this one? Are we at a combination of Matt's and Dmitry's patches here? I think we definitely need to fix this even in the 5.2 branch and get it back to 5.1.x and

Re: [PHP-DEV] PHP 5.3.0RC3

Hi Lukas, all, - Original Message - From: Lukas Kahwe Smith Sent: Thursday, May 28, 2009 On 12.05.2009, at 04:20, Matt Wilmas wrote: Hi Lukas, - Original Message - From: Lukas Kahwe Smith Sent: Monday, May 11, 2009 [...] Critical issues: 1) I assume the issues

Re: [PHP-DEV] PHP 5.3.0RC3

Hi Lukas, - Original Message - From: Lukas Kahwe Smith Sent: Monday, May 11, 2009 [...] Critical issues: 1) I assume the issues with rounding are resolved. If any issues pop up again, please let the list know. @Matt/Dmitry: Can you just give us the quick nod that all is well

Re: [PHP-DEV] PHP 5.3.0RC3

learn to do stuff correctly; you'd probably agree. [1] http://realplain.com/php/is_numeric.diff --Jani - Matt Matt Wilmas kirjoitti: Hi Lukas, - Original Message - From: Lukas Kahwe Smith Sent: Monday, May 11, 2009 [...] Critical issues: 1) I assume the issues with rounding

Re: [PHP-DEV] [PATCH] Scanner diet with fixes, etc.

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Monday, May 04, 2009 Hi Matt, I wasn't able to look into all details of the patch, but in general I like it, as it fixes bugs and makes scanner smaller. I think you can commit it. OK, you mean before the freeze for RC2...?

Re: [PHP-DEV] [PATCH] Scanner diet with fixes, etc.

Hi Brian, - Original Message - From: shire Sent: Monday, May 04, 2009 Hey Matt, Matt Wilmas wrote: +/* To save initial string length after scanning to first variable, CG(doc_comment_len) can be reused */ +#define double_quotes_scanned_len CG(doc_comment_len) + (minor) Maybe we

Re: [PHP-DEV] [PATCH] Scanner diet with fixes, etc.

Hi Brian, - Original Message - From: shire Sent: Monday, May 04, 2009 Matt Wilmas wrote: [...] How about this? #define SET_DOUBLE_QUOTES_SCANNED_LENGTH(len) CG(doc_comment_len) = (len) #define GET_DOUBLE_QUOTES_SCANNED_LENGTH() CG(doc_comment_len) Sure, works for me ;-) Cool

Re: [PHP-DEV] Re: [PATCH] Scanner diet with fixes, etc.

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Thursday, April 30, 2009 Hi Matt, Does this patch fix EOF handling issues related to mmap()? (e.g. parsing of files with size 4096, 8192, ...). Now we have two dirty fixes to handle them correctly. I'm not really sure about

Re: [PHP-DEV] [PATCH] Scanner diet with fixes, etc.

Hi guys, - Original Message - From: Nuno Lopes Sent: Thursday, April 30, 2009 The patch looks generally ok. However I'll need a few more days to review it carefully and throughly. (you can merge it in the meantime if you want). I'm just slighty concern with the amount of parsing we

[PHP-DEV] [PATCH] Scanner diet with fixes, etc.

Hi Dmitry, Brian, all, Here's a scanner patch that I mentioned awhile ago, with a possible way to work around the re2c EOF handling issues. The primary change is to do a manual scan like I talked about in areas that match large amounts and can contain NULL bytes (strings/comments, which are

[PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard mail.c

Hi Ilia, - Original Message - From: Ilia Alshanetsky Sent: Wednesday, April 15, 2009 iliaa Wed Apr 15 14:24:38 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard mail.c Log: Fixed bug #47969 (ezmlm_hash() returns different values depend on OS)

[PHP-DEV] Re: [PATCH] double to long conversion change

Hi Dmitry, I finally updated the patches: http://realplain.com/php/dval_to_lval.diff http://realplain.com/php/dval_to_lval_5_3.diff After seeing how things work on Windows and [new for me] 32- and 64-bit Linux, there's no longer all that magic stuff I had before. :-) Now the conversion

Re: [PHP-DEV] RC2 and integer/float handling in 5.3

Hi Lukas, (I see you CC'd Christian, but I don't think he's involved with this...) - Original Message - From: Lukas Kahwe Smith Sent: Saturday, April 04, 2009 On 31.03.2009, at 00:32, Lukas Kahwe Smith wrote: On 31.03.2009, at 00:27, Pierre Joye wrote: On Tue, Mar 31, 2009 at

Re: [PHP-DEV] RC2 and integer/float handling in 5.3

Hi Brian, - Original Message - From: shire Sent: Monday, April 06, 2009 Matt Wilmas wrote: Oh, other than that about the RC2 subject, I was also going to propose some scanner changes like I mentioned to Brian on the 26th. Assuming it works like in my head, it would basically be a big

Re: [PHP-DEV] [PATCH] double to long conversion change

Hi Dan, - Original Message - From: Daniel Convissor Sent: Thursday, April 02, 2009 Hi Matt: On Sat, Mar 14, 2009 at 09:30:42AM -0500, Matt Wilmas wrote: But of course with doubles, precision has been lost long before 2^63 anyway, as far as increments of 1 (it's 1024 at 2^63). I

Re: [PHP-DEV] RC2 and integer/float handling in 5.3

Hi again Brian, - Original Message - From: shire Sent: Monday, April 06, 2009 Hey Matt, Matt Wilmas wrote: Yep, 5.3's snapshot self-compiled from a couple days ago on Windows (not that that should matter). (I'm not regenerating it with re2c, which also shouldn't matter; using

[PHP-DEV] Re: [PATCH] double to long conversion change

if ((d) 0) { \ (l) = 0; \ } else {\ (l) = (unsigned long) (d); \ } It also possible to add notices in case of overflow detection. Thanks. Dmitry. Matt Wilmas wrote: Hi all, Since noticing and reporting last year [1] different behavior when casting out-of-range doubles to int after

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_language_parser.y zend_language_scanner.l

Hi Dmitry, I had looked at this Bug and wondering whether it should be fixed (I guess the answer is yes :-)) and how to do so. I was only thinking along the lines of adding a stack to keep track of multiple heredocs in the scanner. Then I saw your fix and thought it was a cool method and

Re: [PHP-DEV] array kindex overflow issue Re: [PHP-DEV] Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int

Hi Lukas, - Original Message - From: Lukas Kahwe Smith Sent: Monday, March 23, 2009 On 19.03.2009, at 20:37, Rasmus Lerdorf wrote: So, what is the final conclusion on this one? Are we at a combination of Matt's and Dmitry's patches here? I think we definitely need to fix this even

[PHP-DEV] Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int

Hi Dmitry, - Original Message - From: Dmitry Stogov Sent: Thursday, March 19, 2009 Hi Matt, Matt Wilmas wrote: Hi again Dmitry, Just wanted to say that I think I can make your code a bit smaller after looking at it closer. It would be great, but keep in mind that performance

Re: [PHP-DEV] Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int

Hi Rasmus, - Original Message - From: Rasmus Lerdorf Sent: Thursday, March 19, 2009 So, what is the final conclusion on this one? Are we at a combination of Matt's and Dmitry's patches here? I think we definitely need to fix this even in the 5.2 branch and get it back to 5.1.x and

[PHP-DEV] Re: [PATCH] Bug #45877: LONG_MAX/MIN array key as string/int

numeric, e.g. 123a [1] http://news.php.net/php.zend-engine.cvs/7465 Dmitry. - Matt Matt Wilmas wrote: Hi all, Assuming there are no objections, I'll commit this fix in a few hours... Besides the bug report(s), I had also found awhile ago that currently an array key can be LONG_MAX

  1   2   3   >