Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments

2022-11-15 Thread Rowan Tommins
On 15 November 2022 19:23:44 GMT, "Máté Kocsis" wrote: >I didn't bother to add a separate example for explicit readonly properties, >because I mainly regard >readonly classes as a shorthand for adding the readonly modifier for all >properties My two cents: examples are cheap, misunderstandings

Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments

2022-11-15 Thread Máté Kocsis
Hi Rowan and Alexandru, I'm not totally clear what this sentence is saying: > > > Reinitialization can only take place /during/ the |__clone()| magic > method call, no matter if the actual assignment happens in a different > method or function invoked inside |__clone()|. > > Are you saying that

Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments

2022-11-15 Thread Alexandru Pătrănescu
Hi Mate, On Tue, Nov 15, 2022 at 8:30 AM Máté Kocsis wrote: > Hi Everyone, > > Following Nicolas' thread about "Issues with readonly classes" ( > https://externals.io/message/118554), we created an RFC to fix two issues > with the readonly behavior: https://wiki.php.net/rfc/readonly_amendments

Re: [PHP-DEV] [RFC] Asymmetric Visibility, with readonly

2022-11-15 Thread Derick Rethans
On Mon, 14 Nov 2022, Ilija Tovilo wrote: > Hi Derick > > > > As I understand it, you’re suggesting that a property declared as > > > `public protected(set)` would never trigger __set(). > > > > I would think that that would be against our current practice, which is > > easy enough to explain as

Re: [PHP-DEV] Removing OS2 specific code

2022-11-15 Thread Kalle Sommer Nielsen
Hi Den tir. 15. nov. 2022 kl. 10.08 skrev G. P. B. : > > Hello internal, > > While working on a bug, I've encountered some compatibility code for OS2, > which I've planned to remove, as the last release of OS2 was in December > 2001. > > This is to ask if anyone has any objections to removing

Re: [PHP-DEV] [RFC] [Discussion] Readonly class amendments

2022-11-15 Thread Rowan Tommins
On 15/11/2022 06:30, Máté Kocsis wrote: Hi Everyone, Following Nicolas' thread about "Issues with readonly classes" ( https://externals.io/message/118554), we created an RFC to fix two issues with the readonly behavior:https://wiki.php.net/rfc/readonly_amendments Please let us know your

[PHP-DEV] Removing OS2 specific code

2022-11-15 Thread G. P. B.
Hello internal, While working on a bug, I've encountered some compatibility code for OS2, which I've planned to remove, as the last release of OS2 was in December 2001. This is to ask if anyone has any objections to removing compatibility for OS2. Best regards, George P. Banyard