kinow commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053757300
> I don't know eactly the policy is on the `changes.xml`, but I just noticed
that there seems to be no entry for the initial `ExifRewriterRoundtripTest`.
>
> So to give
StefanOltmann commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053700501
I don't know eactly the policy is on the `changes.xml`, but I just noticed
that there seems to be no entry for the initial `ExifRewriterRoundtripTest`.
So to give
StefanOltmann commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053697017
@kinow Thanks for merging it. :)
> The changes.xml has the due-to field set to Stefan and to Gary Lucas (as I
believe Stefan used Gary's suggestion from JIRA ).
StefanOltmann commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053695842
@kinow Thanks for merging it! :)
> The `changes.xml` has the due-to field set to Stefan and to Gary Lucas (as
I believe Stefan used Gary's suggestion from JIRA ).
kinow merged PR #366:
URL: https://github.com/apache/commons-imaging/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kinow commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053691613
Rebased, added `changes.xml` entry, and squashed commits. The `changes.xml`
has the due-to field set to Stefan and to Gary Lucas (as I believe Stefan used
Gary's suggestion from JIRA
garydgregory commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2028077804
@kinow
Thank you for your work here. I'll merge this once 1.0.0-alpha4 is out (in 3
days).
--
This is an automated message from the Apache Git Service.
To respond to the
kinow commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027412302
And tests passed after re-running the failed jobs on GitHub Actions
:man_shrugging:
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kinow commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027349014
Build errors are on macos (works on macos + java 8, fails for java 11).
>Error: Java heap space
I will spend some minutes checking if there's any Maven setting that we
kinow commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027097242
- Replaced test code from `TiffOutputField` by a public getter/setter for
the bytes data (the getter is a copy, like in other formats)
- Updated tests to use `assertArrayEquals`
10 matches
Mail list logo
