[PR] Bump org.eclipse.jetty:jetty-bom from 10.0.20 to 12.0.8 [maven-resolver]
dependabot[bot] opened a new pull request, #457:
URL: https://github.com/apache/maven-resolver/pull/457
Bumps [org.eclipse.jetty:jetty-bom](https://github.com/jetty/jetty.project)
from 10.0.20 to 12.0.8.
Release notes
Sourced from https://github.com/jetty/jetty.project/releases;>org.eclipse.jetty:jetty-bom's
releases.
12.0.8
Special Thanks to the following Eclipse Jetty community members
https://github.com/dhs3000;>@dhs3000 (Dennis
Hoersch)
Changelog
https://redirect.github.com/jetty/jetty.project/issues/11587;>#11587
- Allow configuring showCause in ErrorHandler
https://redirect.github.com/jetty/jetty.project/issues/11583;>#11583
- Broken HTTP/3 tests
https://redirect.github.com/jetty/jetty.project/issues/11577;>#11577
- Remove usages of URIUtil.toURI and URIUtil.split
https://redirect.github.com/jetty/jetty.project/issues/11574;>#11574
- shibboleth idp webapp under jetty 12.0.7
https://redirect.github.com/jetty/jetty.project/issues/11572;>#11572
- Deploy behaves differently when both WAR and XML exist in
${jetty.base}/webapps/ and you update the XML vs updating the WAR.
https://redirect.github.com/jetty/jetty.project/issues/11558;>#11558
- New tmp directory should be created on every WebAppContext
start, if not explicitly configured
https://redirect.github.com/jetty/jetty.project/issues/11556;>#11556
- Improvements and cleanups to ErrorHandler.
https://redirect.github.com/jetty/jetty.project/issues/11553;>#11553
- Restore startWebapp() to WebAppContext
https://redirect.github.com/jetty/jetty.project/issues/11548;>#11548
- java.nio.file.ClosedFileSystemException on hot redeploy
https://redirect.github.com/jetty/jetty.project/issues/11539;>#11539
- Resource.copyTo(Resource) has different behavior from Jetty
9/10/11
https://redirect.github.com/jetty/jetty.project/issues/11522;>#11522
- Allows to change the default ErrorHandler response type (https://github.com/dhs3000;>@dhs3000)
https://redirect.github.com/jetty/jetty.project/issues/11518;>#11518
- Ensure request is set for ContextScopeListener in EE10
https://redirect.github.com/jetty/jetty.project/issues/11513;>#11513
- Perf regression in the HTTP parser caused by long look-ahead
https://redirect.github.com/jetty/jetty.project/issues/11510;>#11510
- Occasional NPE in ClassMatcher.match() from WebAppClassLoader.loadClass()
usage
https://redirect.github.com/jetty/jetty.project/issues/11509;>#11509
- Removing constructor in CookieCache on minor version Change of artifact
https://redirect.github.com/jetty/jetty.project/issues/11498;>#11498
- Optimized ReservedThreadExecutor with ThreadIdPool
https://redirect.github.com/jetty/jetty.project/issues/11495;>#11495
- Add UriCompliance rules that follow the HTTP / URI / Servlet specs for
illegal suspicious characters
https://redirect.github.com/jetty/jetty.project/issues/11486;>#11486
- Improve HTTP parsing long look-ahead
https://redirect.github.com/jetty/jetty.project/issues/11482;>#11482
- The StatisticsHandler doesn't count 2xx codes
https://redirect.github.com/jetty/jetty.project/issues/11451;>#11451
- Reintroduce Cross Context Dispatch in Jetty 12
https://redirect.github.com/jetty/jetty.project/issues/11411;>#11411
- Allow non existant resources to be obtained from Resource.resolve()
https://redirect.github.com/jetty/jetty.project/issues/11364;>#11364
- Cleanup Resource IO
https://redirect.github.com/jetty/jetty.project/issues/11319;>#11319
- Implemented addBeanFromConstructor
https://redirect.github.com/jetty/jetty.project/issues/10870;>#10870
- How to set HttpConfiguration.securePort when the HTTPS port is dynamic?
https://redirect.github.com/jetty/jetty.project/issues/10387;>#10387
- Fix or suppress javadoc warnings
https://redirect.github.com/jetty/jetty.project/issues/7647;>#7647 -
Document org.eclipse.jetty.client.Socks4Proxy secure parameter
https://redirect.github.com/jetty/jetty.project/issues/5857;>#5857 -
Deprecate AbstractConnectionPool callback methods
12.0.7
Special Thanks to the following Eclipse Jetty community members
https://github.com/hboutemy;>@hboutemy (Hervé
Boutemy)
https://github.com/danishnawab;>@danishnawab
(Danish Nawab)
Changelog
https://redirect.github.com/jetty/jetty.project/issues/11465;>#11465
- HttpURI.toURI() sets userInfo to null
https://redirect.github.com/jetty/jetty.project/issues/11455;>#11455
- Improve DEBUG during WebInfConfiguration.unpack
https://redirect.github.com/jetty/jetty.project/issues/11448;>#11448
- UriCompliance.Violation ignored despite being set
https://redirect.github.com/jetty/jetty.project/issues/11443;>#11443
- Fix NPE in HttpReceiverOverHTTP2.read() when the channel's stream is null
https://redirect.github.com/jetty/jetty.project/issues/11435;>#11435
- Add suppressed failures in Callback failed
[PR] Bump mavenVersion from 3.6.3 to 3.8.8 [maven-scripting-plugin]
dependabot[bot] opened a new pull request, #29: URL: https://github.com/apache/maven-scripting-plugin/pull/29 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump wagonVersion from 2.4 to 3.5.3 [maven-javadoc-plugin]
dependabot[bot] opened a new pull request, #275: URL: https://github.com/apache/maven-javadoc-plugin/pull/275 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump slf4jVersion from 1.7.36 to 2.0.12 [maven-javadoc-plugin]
dependabot[bot] opened a new pull request, #274: URL: https://github.com/apache/maven-javadoc-plugin/pull/274 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump slf4jVersion from 1.7.36 to 2.0.12 [maven-jarsigner]
dependabot[bot] opened a new pull request, #22: URL: https://github.com/apache/maven-jarsigner/pull/22 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MPOM-473) Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.10 to 2.7.11
[ https://issues.apache.org/jira/browse/MPOM-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-473: Assignee: Slawomir Jaranowski > Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.10 to 2.7.11 > --- > > Key: MPOM-473 > URL: https://issues.apache.org/jira/browse/MPOM-473 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: maven >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-42 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-473] Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.11 to 2.8.0 [maven-parent]
slawekjaranowski merged PR #167: URL: https://github.com/apache/maven-parent/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-476) Bump version.maven-plugin-tools from 3.10.2 to 3.12.0
[ https://issues.apache.org/jira/browse/MPOM-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-476. Resolution: Fixed > Bump version.maven-plugin-tools from 3.10.2 to 3.12.0 > - > > Key: MPOM-476 > URL: https://issues.apache.org/jira/browse/MPOM-476 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-476] Bump version.maven-plugin-tools from 3.10.2 to 3.12.0 [maven-apache-parent]
slawekjaranowski merged PR #204: URL: https://github.com/apache/maven-apache-parent/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-476) Bump version.maven-plugin-tools from 3.10.2 to 3.12.0
Slawomir Jaranowski created MPOM-476: Summary: Bump version.maven-plugin-tools from 3.10.2 to 3.12.0 Key: MPOM-476 URL: https://issues.apache.org/jira/browse/MPOM-476 Project: Maven POMs Issue Type: Dependency upgrade Components: asf Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: ASF-32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPOM-475) Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1
[ https://issues.apache.org/jira/browse/MPOM-475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-475. Resolution: Fixed > Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 > -- > > Key: MPOM-475 > URL: https://issues.apache.org/jira/browse/MPOM-475 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-475] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 [maven-apache-parent]
slawekjaranowski merged PR #203: URL: https://github.com/apache/maven-apache-parent/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-475) Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1
Slawomir Jaranowski created MPOM-475: Summary: Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 Key: MPOM-475 URL: https://issues.apache.org/jira/browse/MPOM-475 Project: Maven POMs Issue Type: Dependency upgrade Components: asf Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: ASF-32 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAR-296) No way to suppress default excludes in maven-jar-plugin
[
https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833755#comment-17833755
]
ASF GitHub Bot commented on MJAR-296:
-
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550563632
##
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
-archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
Maybe we can simple add next method `addDirectory` to Archiver with
`addDefaultExcludes`?
> No way to suppress default excludes in maven-jar-plugin
> ---
>
> Key: MJAR-296
> URL: https://issues.apache.org/jira/browse/MJAR-296
> Project: Maven JAR Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: G.Vaysman
>Priority: Major
> Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see
> org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource
> directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow
> suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the
> JarMojo -> DirectoryScanner call path confirms that there is no way to affect
> the FileSet configuration.
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion,
> is quite detrimental, and due to backward compatibility, changing
> resource/package path (say, to ChangeSet2) is not an option.
> I am attaching a very simple project that shows two things:
> # The jar plugin skips adding the **/ChangeSet/** files
> # The resources plugin is configured not to skip (addDefaultExcludes) and
> behaves properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAR-296] Allow including files excluded by default. [maven-jar-plugin]
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550563632
##
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
-archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
Maybe we can simple add next method `addDirectory` to Archiver with
`addDefaultExcludes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MJAR-296) No way to suppress default excludes in maven-jar-plugin
[
https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833754#comment-17833754
]
ASF GitHub Bot commented on MJAR-296:
-
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550560439
##
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
-archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
Ok, it looks a more complicated `org.codehaus.plexus.archiver.FileSet` is
only a configuration class which is used in plexus archiver
> No way to suppress default excludes in maven-jar-plugin
> ---
>
> Key: MJAR-296
> URL: https://issues.apache.org/jira/browse/MJAR-296
> Project: Maven JAR Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: G.Vaysman
>Priority: Major
> Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see
> org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource
> directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow
> suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the
> JarMojo -> DirectoryScanner call path confirms that there is no way to affect
> the FileSet configuration.
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion,
> is quite detrimental, and due to backward compatibility, changing
> resource/package path (say, to ChangeSet2) is not an option.
> I am attaching a very simple project that shows two things:
> # The jar plugin skips adding the **/ChangeSet/** files
> # The resources plugin is configured not to skip (addDefaultExcludes) and
> behaves properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAR-296] Allow including files excluded by default. [maven-jar-plugin]
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550560439
##
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
-archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
Ok, it looks a more complicated `org.codehaus.plexus.archiver.FileSet` is
only a configuration class which is used in plexus archiver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MJAR-296) No way to suppress default excludes in maven-jar-plugin
[
https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833747#comment-17833747
]
ASF GitHub Bot commented on MJAR-296:
-
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550519016
##
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
-archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
I would like to use only `org.codehaus.plexus.archiver.FileSet`, there is a
method: `getIncludes` so we can drop a using of
`rg.apache.maven.shared.model.fileset.FileSet` at all.
Also dependency to `file-management` can be removed.
> No way to suppress default excludes in maven-jar-plugin
> ---
>
> Key: MJAR-296
> URL: https://issues.apache.org/jira/browse/MJAR-296
> Project: Maven JAR Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: G.Vaysman
>Priority: Major
> Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see
> org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource
> directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow
> suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the
> JarMojo -> DirectoryScanner call path confirms that there is no way to affect
> the FileSet configuration.
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion,
> is quite detrimental, and due to backward compatibility, changing
> resource/package path (say, to ChangeSet2) is not an option.
> I am attaching a very simple project that shows two things:
> # The jar plugin skips adding the **/ChangeSet/** files
> # The resources plugin is configured not to skip (addDefaultExcludes) and
> behaves properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAR-296] Allow including files excluded by default. [maven-jar-plugin]
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550519016
##
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##
@@ -262,7 +294,7 @@ public File createArchive() throws MojoExecutionException {
getLog().warn("JAR will be empty - no content was marked
for inclusion!");
}
} else {
-archiver.getArchiver().addDirectory(contentDirectory,
getIncludes(), getExcludes());
+
archiver.getArchiver().addFileSet(getFileSet(contentDirectory));
Review Comment:
I would like to use only `org.codehaus.plexus.archiver.FileSet`, there is a
method: `getIncludes` so we can drop a using of
`rg.apache.maven.shared.model.fileset.FileSet` at all.
Also dependency to `file-management` can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump version.maven-plugin-tools from 3.10.2 to 3.11.0 [maven-apache-parent]
dependabot[bot] commented on PR #187: URL: https://github.com/apache/maven-apache-parent/pull/187#issuecomment-2035610600 Superseded by #204. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump version.maven-plugin-tools from 3.10.2 to 3.11.0 [maven-apache-parent]
dependabot[bot] closed pull request #187: Bump version.maven-plugin-tools from 3.10.2 to 3.11.0 URL: https://github.com/apache/maven-apache-parent/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump version.maven-plugin-tools from 3.10.2 to 3.12.0 [maven-apache-parent]
dependabot[bot] opened a new pull request, #204: URL: https://github.com/apache/maven-apache-parent/pull/204 Bumps `version.maven-plugin-tools` from 3.10.2 to 3.12.0. Updates `org.apache.maven.plugin-tools:maven-plugin-annotations` from 3.10.2 to 3.12.0 Release notes Sourced from https://github.com/apache/maven-plugin-tools/releases;>org.apache.maven.plugin-tools:maven-plugin-annotations's releases. 3.12.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820version=12354176;>Release Notes - Maven Plugin Tools - Version 3.12.0 3.11.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820version=12353824;>Release Notes - Maven Plugin Tools - Version 3.11.0 Bug [https://issues.apache.org/jira/browse/MPLUGIN-496;>MPLUGIN-496] - Translation for keys report.plugin.goal.yes,no are missing [https://issues.apache.org/jira/browse/MPLUGIN-499;>MPLUGIN-499] - Deprecate descriptions are missing in description table Improvement [https://issues.apache.org/jira/browse/MPLUGIN-450;>MPLUGIN-450] - Make goal prefix mandatory by default [https://issues.apache.org/jira/browse/MPLUGIN-474;>MPLUGIN-474] - Improve descriptor docs for requiredJavaVersion [https://issues.apache.org/jira/browse/MPLUGIN-492;>MPLUGIN-492] - Documentation for plugins in general: Goals comprises more than that [https://issues.apache.org/jira/browse/MPLUGIN-495;>MPLUGIN-495] - WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter Task [https://issues.apache.org/jira/browse/MPLUGIN-493;>MPLUGIN-493] - Consistently evaluate skip parameter in MavenReport#canGenerateReport() [https://issues.apache.org/jira/browse/MPLUGIN-498;>MPLUGIN-498] - Move section rendering to separate methods Dependency upgrade [https://issues.apache.org/jira/browse/MPLUGIN-494;>MPLUGIN-494] - Upgrade to Parent 41 [https://issues.apache.org/jira/browse/MPLUGIN-497;>MPLUGIN-497] - Upgrade components Commits https://github.com/apache/maven-plugin-tools/commit/0b69acc43ead6efb336c78895e59749f463cc899;>0b69acc [maven-release-plugin] prepare release maven-plugin-tools-3.12.0 https://github.com/apache/maven-plugin-tools/commit/e5e3dd235d572956d49ea461346466d54aec7195;>e5e3dd2 code simplifications https://github.com/apache/maven-plugin-tools/commit/e97ba772405c20849f5e47aa9b4971ddcbc9826b;>e97ba77 [MPLUGIN-510] group history per common requirements https://github.com/apache/maven-plugin-tools/commit/6f9c3d9371155f6a826f8052e099adb716163689;>6f9c3d9 use https://github.com/Component;>@Component instead of https://github.com/Parameter;>@Parameter when possible https://github.com/apache/maven-plugin-tools/commit/d8fecbc1f8b83e9f38b20bd41bac907a9fa0bef4;>d8fecbc Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 https://github.com/apache/maven-plugin-tools/commit/a9dd57dbdd83e3bb295b9c1bf39c128b4eefc0d3;>a9dd57d rename mavenVersion to maven3Version https://github.com/apache/maven-plugin-tools/commit/1aad21414b8ad92a880d22ffb2b935b3fefa85d8;>1aad214 [MPLUGIN-514] switch from png+imagemap to svg https://github.com/apache/maven-plugin-tools/commit/ddbaa5b46aff5581af5b16ab6ffec2ba3c466705;>ddbaa5b Bump apache/maven-gh-actions-shared from 3 to 4 https://github.com/apache/maven-plugin-tools/commit/cd747611b768031b57fda87bb8e19845d2dc69fa;>cd74761 [MPLUGIN-511] add versions history requirements detection https://github.com/apache/maven-plugin-tools/commit/d9f8d8941d6996ad39b6f4c427f8e126c1176154;>d9f8d89 [MPLUGIN-511] prepare method to list releases history Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.10.2...maven-plugin-tools-3.12.0;>compare view Updates `org.apache.maven.plugins:maven-plugin-plugin` from 3.10.2 to 3.12.0 Release notes Sourced from https://github.com/apache/maven-plugin-tools/releases;>org.apache.maven.plugins:maven-plugin-plugin's releases. 3.12.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820version=12354176;>Release Notes - Maven Plugin Tools - Version 3.12.0 3.11.0 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820version=12353824;>Release Notes - Maven Plugin Tools - Version 3.11.0 Bug [https://issues.apache.org/jira/browse/MPLUGIN-496;>MPLUGIN-496] - Translation for keys report.plugin.goal.yes,no are missing [https://issues.apache.org/jira/browse/MPLUGIN-499;>MPLUGIN-499] - Deprecate descriptions are missing in description table Improvement [https://issues.apache.org/jira/browse/MPLUGIN-450;>MPLUGIN-450] - Make goal prefix mandatory by default [https://issues.apache.org/jira/browse/MPLUGIN-474;>MPLUGIN-474] - Improve descriptor docs for requiredJavaVersion
[jira] [Commented] (MJAR-296) No way to suppress default excludes in maven-jar-plugin
[
https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833736#comment-17833736
]
ASF GitHub Bot commented on MJAR-296:
-
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550416370
##
src/it/MJAR-296/verify.groovy:
##
@@ -0,0 +1,58 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.jar.*;
+
+boolean result = false;
+
+try
+{
+File target = new File( basedir, "target" )
+if ( !target.exists() || !target.isDirectory() ) {
+System.err.println( "target file is missing or not a directory." )
+return result
+}
+
+File artifact = new File( target,
"mjar-296-suppress-default-excludes-1.0-SNAPSHOT.jar" )
+if ( !artifact.exists() || artifact.isDirectory() ) {
+System.err.println( "artifact file is missing or a directory." )
+return result
+}
+
+String expectedFileName = ".gitignore"
+
+JarFile jar = new JarFile( artifact )
+Enumeration jarEntries = jar.entries()
+while ( jarEntries.hasMoreElements() ) {
+JarEntry entry = (JarEntry) jarEntries.nextElement();
+if ( !entry.isDirectory() && expectedFileName.equals(entry.getName())
) {
+result = true
+}
+}
Review Comment:
can be:
```
assert jar.getEntry('.gitignore') != null
```
> No way to suppress default excludes in maven-jar-plugin
> ---
>
> Key: MJAR-296
> URL: https://issues.apache.org/jira/browse/MJAR-296
> Project: Maven JAR Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: G.Vaysman
>Priority: Major
> Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see
> org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource
> directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow
> suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the
> JarMojo -> DirectoryScanner call path confirms that there is no way to affect
> the FileSet configuration.
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion,
> is quite detrimental, and due to backward compatibility, changing
> resource/package path (say, to ChangeSet2) is not an option.
> I am attaching a very simple project that shows two things:
> # The jar plugin skips adding the **/ChangeSet/** files
> # The resources plugin is configured not to skip (addDefaultExcludes) and
> behaves properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAR-296] Allow including files excluded by default. [maven-jar-plugin]
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550416370
##
src/it/MJAR-296/verify.groovy:
##
@@ -0,0 +1,58 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.jar.*;
+
+boolean result = false;
+
+try
+{
+File target = new File( basedir, "target" )
+if ( !target.exists() || !target.isDirectory() ) {
+System.err.println( "target file is missing or not a directory." )
+return result
+}
+
+File artifact = new File( target,
"mjar-296-suppress-default-excludes-1.0-SNAPSHOT.jar" )
+if ( !artifact.exists() || artifact.isDirectory() ) {
+System.err.println( "artifact file is missing or a directory." )
+return result
+}
+
+String expectedFileName = ".gitignore"
+
+JarFile jar = new JarFile( artifact )
+Enumeration jarEntries = jar.entries()
+while ( jarEntries.hasMoreElements() ) {
+JarEntry entry = (JarEntry) jarEntries.nextElement();
+if ( !entry.isDirectory() && expectedFileName.equals(entry.getName())
) {
+result = true
+}
+}
Review Comment:
can be:
```
assert jar.getEntry('.gitignore') != null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MJAR-296] Allow including files excluded by default. [maven-jar-plugin]
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550413950
##
src/it/MJAR-296/verify.groovy:
##
@@ -0,0 +1,58 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.jar.*;
+
+boolean result = false;
+
+try
+{
+File target = new File( basedir, "target" )
+if ( !target.exists() || !target.isDirectory() ) {
+System.err.println( "target file is missing or not a directory." )
+return result
+}
Review Comment:
We can simply use:
```
assert target.isDirectory()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MJAR-296) No way to suppress default excludes in maven-jar-plugin
[
https://issues.apache.org/jira/browse/MJAR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833735#comment-17833735
]
ASF GitHub Bot commented on MJAR-296:
-
slawekjaranowski commented on code in PR #67:
URL: https://github.com/apache/maven-jar-plugin/pull/67#discussion_r1550413950
##
src/it/MJAR-296/verify.groovy:
##
@@ -0,0 +1,58 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.jar.*;
+
+boolean result = false;
+
+try
+{
+File target = new File( basedir, "target" )
+if ( !target.exists() || !target.isDirectory() ) {
+System.err.println( "target file is missing or not a directory." )
+return result
+}
Review Comment:
We can simply use:
```
assert target.isDirectory()
```
> No way to suppress default excludes in maven-jar-plugin
> ---
>
> Key: MJAR-296
> URL: https://issues.apache.org/jira/browse/MJAR-296
> Project: Maven JAR Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: G.Vaysman
>Priority: Major
> Attachments: jar-default-excludes.zip
>
>
> With the default excludes being expanded further (see
> org.codehaus.plexus.util.AbstractScanner.{*}_DEFAULTEXCLUDES_{*}), a resource
> directory **/ChangeSet/** will never be included in the JAR artifact.
> Some plugins (maven-resources-plugin, maven-assembly-plugin) already allow
> suppressing the exclusion, but not the maven-jar-plugin. Code analysis of the
> JarMojo -> DirectoryScanner call path confirms that there is no way to affect
> the FileSet configuration.
> Again, with ever expanding list of *_DEFAULTEXCLUDES,_* this, on our opinion,
> is quite detrimental, and due to backward compatibility, changing
> resource/package path (say, to ChangeSet2) is not an option.
> I am attaching a very simple project that shows two things:
> # The jar plugin skips adding the **/ChangeSet/** files
> # The resources plugin is configured not to skip (addDefaultExcludes) and
> behaves properly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPOM-472) Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.2
[ https://issues.apache.org/jira/browse/MPOM-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-472: - Summary: Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.2 (was: Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.1) > Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.2 > -- > > Key: MPOM-472 > URL: https://issues.apache.org/jira/browse/MPOM-472 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-472] Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.1 to 3.2.2 [maven-apache-parent]
slawekjaranowski merged PR #202: URL: https://github.com/apache/maven-apache-parent/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MPOM-472) Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.1
[ https://issues.apache.org/jira/browse/MPOM-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-472: Assignee: Slawomir Jaranowski > Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.1 > -- > > Key: MPOM-472 > URL: https://issues.apache.org/jira/browse/MPOM-472 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: asf >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: ASF-32 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPOM-467) Remove old property maven.plugin.tools.version
[
https://issues.apache.org/jira/browse/MPOM-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MPOM-467.
Resolution: Fixed
> Remove old property maven.plugin.tools.version
> --
>
> Key: MPOM-467
> URL: https://issues.apache.org/jira/browse/MPOM-467
> Project: Maven POMs
> Issue Type: Task
> Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-32
>
>
> We have a new one properties {{version.maven-plugin-tools}}, old is used in a
> few places
> https://github.com/search?q=org%3Aapache%20maven.plugin.tools.version=code
> and can be removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump version.maven-plugin-tools from 3.10.2 to 3.11.0 [maven-apache-parent]
slawekjaranowski commented on PR #187: URL: https://github.com/apache/maven-apache-parent/pull/187#issuecomment-2035308414 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump version.maven-plugin-tools from 3.10.2 to 3.11.0 [maven-apache-parent]
slawekjaranowski commented on PR #187: URL: https://github.com/apache/maven-apache-parent/pull/187#issuecomment-2035306038 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPOM-467] Remove old property maven.plugin.tools.version [maven-apache-parent]
slawekjaranowski merged PR #201: URL: https://github.com/apache/maven-apache-parent/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve maven startup time [maven]
gnodet merged PR #1464: URL: https://github.com/apache/maven/pull/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MGPG-120) Add new mojo: sign-deployed
[ https://issues.apache.org/jira/browse/MGPG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833616#comment-17833616 ] ASF GitHub Bot commented on MGPG-120: - cstamas merged PR #88: URL: https://github.com/apache/maven-gpg-plugin/pull/88 > Add new mojo: sign-deployed > --- > > Key: MGPG-120 > URL: https://issues.apache.org/jira/browse/MGPG-120 > Project: Maven GPG Plugin > Issue Type: New Feature >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.2.3 > > > This mojo should be pointed at some remote repo (writable is assumed), and > should sign deployed artifacts and upload signatures. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MGPG-120) Add new mojo: sign-deployed
[ https://issues.apache.org/jira/browse/MGPG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MGPG-120. Resolution: Fixed > Add new mojo: sign-deployed > --- > > Key: MGPG-120 > URL: https://issues.apache.org/jira/browse/MGPG-120 > Project: Maven GPG Plugin > Issue Type: New Feature >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.2.3 > > > This mojo should be pointed at some remote repo (writable is assumed), and > should sign deployed artifacts and upload signatures. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MGPG-120] New mojo sign-deployed [maven-gpg-plugin]
cstamas merged PR #88: URL: https://github.com/apache/maven-gpg-plugin/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8091) Update Resolver to 2.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MNG-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833613#comment-17833613 ] ASF GitHub Bot commented on MNG-8091: - cstamas commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549896095 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: List GA uses _maven metadata_, that is on other synced somehow... ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: List GA uses _maven metadata_, that is on other hand synced somehow... > Update Resolver to 2.0.0-alpha-10 > - > > Key: MNG-8091 > URL: https://issues.apache.org/jira/browse/MNG-8091 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8091] Update Resolver to 2.0.0-alpha-10 [maven]
cstamas commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549896095 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: List GA uses _maven metadata_, that is on other synced somehow... ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: List GA uses _maven metadata_, that is on other hand synced somehow... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8091) Update Resolver to 2.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MNG-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833612#comment-17833612 ] ASF GitHub Bot commented on MNG-8091: - cstamas commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549894577 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: ``` [cstamas@angeleyes ~]$ jbang mima@maveniverse exists org.apache.maven.resolver:maven-resolver-api:2.0.0-alpha-10 Artifact org.apache.maven.resolver:maven-resolver-api:jar:2.0.0-alpha-10 NOT EXISTS Checked TOTAL of 1 (existing: 0 not existing: 1) [cstamas@angeleyes ~]$ ``` > Update Resolver to 2.0.0-alpha-10 > - > > Key: MNG-8091 > URL: https://issues.apache.org/jira/browse/MNG-8091 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8091] Update Resolver to 2.0.0-alpha-10 [maven]
cstamas commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549894577 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: ``` [cstamas@angeleyes ~]$ jbang mima@maveniverse exists org.apache.maven.resolver:maven-resolver-api:2.0.0-alpha-10 Artifact org.apache.maven.resolver:maven-resolver-api:jar:2.0.0-alpha-10 NOT EXISTS Checked TOTAL of 1 (existing: 0 not existing: 1) [cstamas@angeleyes ~]$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] The raw model is not supposed to be profile activated [maven]
gnodet closed pull request #1450: The raw model is not supposed to be profile activated URL: https://github.com/apache/maven/pull/1450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPMD-379) Support PMD 7.0.0
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833601#comment-17833601
]
Gary D. Gregory commented on MPMD-379:
--
Any release plans you can share?
> Support PMD 7.0.0
> -
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7
> most likely means, that only PMD 7 will be supported onwards (no backwards
> compatibility supported).
> wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
>
> A snapshot version that is compatible with the current 7.0.0 release
> candidates is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
> {code:java}
>
> apache.snapshots
> Apache Snapshot Repository
> https://repository.apache.org/snapshots
>
> false
>
>
> true
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRESOLVER-217) Allow extra "sources" for Artifact decoration
[ https://issues.apache.org/jira/browse/MRESOLVER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-217: -- Issue Type: New Feature (was: Task) > Allow extra "sources" for Artifact decoration > - > > Key: MRESOLVER-217 > URL: https://issues.apache.org/jira/browse/MRESOLVER-217 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > For start, a simple API that would "enhance" Artifact instances from it (like > populating artifact properties). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default
[
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833558#comment-17833558
]
Michael Osipov commented on MARTIFACT-60:
-
Makes sense. [~hboutemy], WDYT?
> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Components: artifact:check-buildplan
>Affects Versions: 3.5.0
> Environment: Apache Maven 3.9.6
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Priority: Major
>
> Running the plugin is too chatty by default, for example, I don't need
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>=
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a
> capital letter.
> The current info would be fine at the debug logging level IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833557#comment-17833557
]
Michael Osipov commented on SCM-1022:
-
A PR would be appreciated, best with a test proving it.
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default
[
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated MARTIFACT-60:
-
Description:
Running the plugin is too chatty by default, for example, I don't need
everything that's NOT wrong. Just tell me what's wrong or nothing:
{noformat}
[INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
[INFO] no known issue with org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
[INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
[INFO] no known issue with org.apache.maven.plugins:maven-artifact-plugin:3.5.0
[INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
[INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
[INFO] no known issue with
org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
[INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
[INFO] no known issue with org.apache.maven.plugins:maven-resources-plugin:3.3.1
[INFO] no known issue with org.apache.maven.plugins:maven-compiler-plugin:3.13.0
[INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 5.1.9)
[INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
[INFO] no known issue with org.apache.maven.plugins:maven-surefire-plugin:3.2.5
[INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 (>=
3.2.0)
[INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
[INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
(>= 3.2.1)
[INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
[INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
[INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
1.0.0.Final)
[INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
[INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
{noformat}
Either say nothing or, if you must, perhaps a single log event:
"No issues found in 16 plugins." Note that sentences should start with a
capital letter.
The current info would be fine at the debug logging level IMO.
was:
Running the plugin is too chatty by default, for example, I don't need
everything that's NOT wrong. Just tell me what's wrong or nothing:
{noformat}
[INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
[INFO] no known issue with org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
[INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
[INFO] no known issue with org.apache.maven.plugins:maven-artifact-plugin:3.5.0
[INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
[INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
[INFO] no known issue with
org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
[INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
[INFO] no known issue with org.apache.maven.plugins:maven-resources-plugin:3.3.1
[INFO] no known issue with org.apache.maven.plugins:maven-compiler-plugin:3.13.0
[INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 5.1.9)
[INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
[INFO] no known issue with org.apache.maven.plugins:maven-surefire-plugin:3.2.5
[INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 (>=
3.2.0)
[INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
[INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
(>= 3.2.1)
[INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
[INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
[INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
1.0.0.Final)
[INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
[INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
{noformat}
Either say nothing or, if you must, perhaps a single log event:
"No issues found in 16 plugins." Note that sentences should start with a
capital letter
The current info would be fine at the debug logging level IMO.
> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Components: artifact:check-buildplan
>Affects Versions: 3.5.0
> Environment: Apache Maven 3.9.6
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows
[jira] [Created] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default
Gary D. Gregory created MARTIFACT-60:
Summary: artifact:3.5.0:check-buildplan is too chatty by default
Key: MARTIFACT-60
URL: https://issues.apache.org/jira/browse/MARTIFACT-60
Project: Maven Artifact Plugin
Issue Type: Improvement
Components: artifact:check-buildplan
Affects Versions: 3.5.0
Environment: Apache Maven 3.9.6
(bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: C:\java\apache-maven-3.9.6
Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
Reporter: Gary D. Gregory
Running the plugin is too chatty by default, for example, I don't need
everything that's NOT wrong. Just tell me what's wrong or nothing:
{noformat}
[INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
[INFO] no known issue with org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
[INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
[INFO] no known issue with org.apache.maven.plugins:maven-artifact-plugin:3.5.0
[INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
[INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
[INFO] no known issue with
org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
[INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
[INFO] no known issue with org.apache.maven.plugins:maven-resources-plugin:3.3.1
[INFO] no known issue with org.apache.maven.plugins:maven-compiler-plugin:3.13.0
[INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>= 5.1.9)
[INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
[INFO] no known issue with org.apache.maven.plugins:maven-surefire-plugin:3.2.5
[INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0 (>=
3.2.0)
[INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
[INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
(>= 3.2.1)
[INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
[INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
[INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
1.0.0.Final)
[INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
[INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
{noformat}
Either say nothing or, if you must, perhaps a single log event:
"No issues found in 16 plugins." Note that sentences should start with a
capital letter
The current info would be fine at the debug logging level IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-520] Collapse repeated code blocks [maven-resolver]
cstamas merged PR #456: URL: https://github.com/apache/maven-resolver/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MARTIFACT-59) artifact plugin should tolerate injected project.build.outputTimestamp
[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833545#comment-17833545
]
ASF GitHub Bot commented on MARTIFACT-59:
-
rmannibucau commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034442739
> there are 2 runs, look at the first one: no problem with 3.5.1, same
problem with 3.5.0
Hmm, not sure what which artifact you used built but got back the plugin
from asf repo and still getting the same error:
https://gist.github.com/rmannibucau/816c07cd6277e602584d0bb2b4497c5a#file-output-txt-L29
If it helps:
> $ shasum
~/.m2/repository/org/apache/maven/plugins/maven-artifact-plugin/3.5.1/maven-artifact-plugin-3.5.1.jar
> c24f8609c90af05fd1fd56c4ad238dacd7fbd791
/home/rmannibucau/.m2/repository/org/apache/maven/plugins/maven-artifact-plugin/3.5.1/maven-artifact-plugin-3.5.1.jar
> the unit test does not have any pom.xml: it's hard to guess what the code
tries to represent from an end-user point of view
assuming it is ambiguous:
```xml
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.github.rmannibucau.test
foo
1.0.0-SNAPSHOT
artifact plugin should tolerate injected project.build.outputTimestamp
> --
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
>Reporter: Romain Manni-Bucau
>Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MARTIFACT-59] tolerate injected timestamp value [maven-artifact-plugin]
rmannibucau commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034442739
> there are 2 runs, look at the first one: no problem with 3.5.1, same
problem with 3.5.0
Hmm, not sure what which artifact you used built but got back the plugin
from asf repo and still getting the same error:
https://gist.github.com/rmannibucau/816c07cd6277e602584d0bb2b4497c5a#file-output-txt-L29
If it helps:
> $ shasum
~/.m2/repository/org/apache/maven/plugins/maven-artifact-plugin/3.5.1/maven-artifact-plugin-3.5.1.jar
> c24f8609c90af05fd1fd56c4ad238dacd7fbd791
/home/rmannibucau/.m2/repository/org/apache/maven/plugins/maven-artifact-plugin/3.5.1/maven-artifact-plugin-3.5.1.jar
> the unit test does not have any pom.xml: it's hard to guess what the code
tries to represent from an end-user point of view
assuming it is ambiguous:
```xml
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.github.rmannibucau.test
foo
1.0.0-SNAPSHOT
${git.commit.time}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (MRESOLVER-217) Allow extra "sources" for Artifact decoration
[ https://issues.apache.org/jira/browse/MRESOLVER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-217. - Resolution: Fixed > Allow extra "sources" for Artifact decoration > - > > Key: MRESOLVER-217 > URL: https://issues.apache.org/jira/browse/MRESOLVER-217 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > For start, a simple API that would "enhance" Artifact instances from it (like > populating artifact properties). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-217) Allow extra "sources" for Artifact decoration
[ https://issues.apache.org/jira/browse/MRESOLVER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833535#comment-17833535 ] ASF GitHub Bot commented on MRESOLVER-217: -- cstamas merged PR #453: URL: https://github.com/apache/maven-resolver/pull/453 > Allow extra "sources" for Artifact decoration > - > > Key: MRESOLVER-217 > URL: https://issues.apache.org/jira/browse/MRESOLVER-217 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > For start, a simple API that would "enhance" Artifact instances from it (like > populating artifact properties). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-217] Extra sources for Artifact decoration [maven-resolver]
cstamas merged PR #453: URL: https://github.com/apache/maven-resolver/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833532#comment-17833532
]
Mattias Andersson commented on SCM-1022:
The problem seems to be that the return value from JGitUtils.push is ignored in:
{noformat}
org.apache.maven.scm.provider.git.jgit.command.checkin.JGitCheckInCommand#executeCheckInCommand{noformat}
We could try to provide a PR if that would be interesting?
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SCM-1022) jgit push failure is not failing the build
Mattias Andersson created SCM-1022:
--
Summary: jgit push failure is not failing the build
Key: SCM-1022
URL: https://issues.apache.org/jira/browse/SCM-1022
Project: Maven SCM
Issue Type: Bug
Components: maven-scm-provider-jgit
Affects Versions: 2.0.1
Reporter: Mattias Andersson
If the push command fails, the maven build does not fail. This means binaries
are deployed, but the remote repo is not updated. The issue seems related to
SCM-854.
We use Gerrit and have the merge strategy set to "fast forward only". If
someone pushes a commit during the release job, only an INFO message is logged,
but the maven build is successful.
The same use case with the maven-scm-provider-gitexe (the default) fails the
build as expected (git push returns a non-zero exit code)
{code:java}
10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
10:28:03 [INFO] fetch url: ssh://xxx@xxx
10:28:03 [INFO] push url: ssh://xxx@xxx
10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
net.i2p.crypto.eddsa.EdDSASecurityProvider
10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
Nio2ServiceFactoryFactory
10:28:04 [INFO] REJECTED_NONFASTFORWARD -
RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
srcRef=refs/heads/master, message=null]
10:28:04 [INFO] 12/17 prepare:scm-tag
10:28:04 [INFO] Tagging release with the label 2.15.0...
10:28:04 [INFO] push tag [2.15.0] to remote...
10:28:04 [INFO] fetch url: ssh://xxx@xxx
10:28:04 [INFO] push url: ssh://xxx@xxx
10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
...968d97de8331ce19d43c719e870890def5ee65d9,
fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARTIFACT-59) artifact plugin should tolerate injected project.build.outputTimestamp
[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833524#comment-17833524
]
ASF GitHub Bot commented on MARTIFACT-59:
-
hboutemy commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034360845
> You have the same error than me.
there are 2 runs, look at the first one: no problem with 3.5.1, same problem
with 3.5.0
> The key point is that in the pom you have an interpolated value
the unit test does not have any pom.xml: it's hard to guess what the code
tries to represent from an end-user point of view
> artifact plugin should tolerate injected project.build.outputTimestamp
> --
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
>Reporter: Romain Manni-Bucau
>Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MARTIFACT-59] tolerate injected timestamp value [maven-artifact-plugin]
hboutemy commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034360845 > You have the same error than me. there are 2 runs, look at the first one: no problem with 3.5.1, same problem with 3.5.0 > The key point is that in the pom you have an interpolated value the unit test does not have any pom.xml: it's hard to guess what the code tries to represent from an end-user point of view -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-521) File locking threads not entering critical region were "oversleeping"
[ https://issues.apache.org/jira/browse/MRESOLVER-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-521. - Resolution: Fixed > File locking threads not entering critical region were "oversleeping" > - > > Key: MRESOLVER-521 > URL: https://issues.apache.org/jira/browse/MRESOLVER-521 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > Instead loser to immediately give up and sleep, should sit a while to enter > critical region. This is important for "hot" locks. > Explanation: currently a "loser" will _immediately give up_ and will go to > sleep 100ms, even if winner exits critical region within next 5ms (so lost > 95ms). The retry is needed to ensure that it is retried as much as given > time/unit takes, that was before consumed by constant retries+sleeps. The > logic still works, as if tryLock spends time/unit waiting on critical region > (which is possible only on VERY HIGHLY congested locks), there will be no > retry happening. Still, now it may sleep 5ms, and "win" once "original > winner" left the critical region. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-521) File locking threads not entering critical region were "oversleeping"
[ https://issues.apache.org/jira/browse/MRESOLVER-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833518#comment-17833518 ] ASF GitHub Bot commented on MRESOLVER-521: -- cstamas merged PR #455: URL: https://github.com/apache/maven-resolver/pull/455 > File locking threads not entering critical region were "oversleeping" > - > > Key: MRESOLVER-521 > URL: https://issues.apache.org/jira/browse/MRESOLVER-521 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > Instead loser to immediately give up and sleep, should sit a while to enter > critical region. This is important for "hot" locks. > Explanation: currently a "loser" will _immediately give up_ and will go to > sleep 100ms, even if winner exits critical region within next 5ms (so lost > 95ms). The retry is needed to ensure that it is retried as much as given > time/unit takes, that was before consumed by constant retries+sleeps. The > logic still works, as if tryLock spends time/unit waiting on critical region > (which is possible only on VERY HIGHLY congested locks), there will be no > retry happening. Still, now it may sleep 5ms, and "win" once "original > winner" left the critical region. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-521] Improve congested file locks behaviour [maven-resolver]
cstamas merged PR #455: URL: https://github.com/apache/maven-resolver/pull/455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MRESOLVER-518] Version selector improvements [maven-resolver]
cstamas commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549450171
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConfigurableVersionSelector.java:
##
@@ -0,0 +1,350 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.util.graph.transformer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.eclipse.aether.RepositoryException;
+import org.eclipse.aether.collection.UnsolvableVersionConflictException;
+import org.eclipse.aether.graph.DependencyFilter;
+import org.eclipse.aether.graph.DependencyNode;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictContext;
+import org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictItem;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.VersionSelector;
+import org.eclipse.aether.util.graph.visitor.PathRecordingDependencyVisitor;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A configurable version selector for use with {@link ConflictResolver} that
resolves version conflicts using a
+ * specified strategy. If there is no single node that satisfies all
encountered version ranges, the selector will fail.
+ * Based on configuration, this selector may fail for other reasons as well.
+ *
+ * @since 2.0.0
+ */
+public class ConfigurableVersionSelector extends VersionSelector {
+/**
+ * The strategy how "winner" is being selected.
+ */
+public enum SelectionStrategy {
+/**
+ * This is how Maven3 works, chooses "nearer" dependency for winner.
+ */
+NEARER,
+/**
+ * This is new mode, chooses "higher version" dependency for winner.
+ */
+HIGHER_VERSION;
+}
+/**
+ * The compatibility check strategy.
+ */
+public interface CompatibilityStrategy {
+/**
+ * This method should determine are versions of two items "compatible"
or not. This method is invoked whenever
+ * {@code candidate} is "considered" (does not have to be selected as
"winner").
+ */
+boolean isIncompatibleVersion(ConflictItem candidate, ConflictItem
winner)
+throws UnsolvableVersionConflictException;
+}
+/**
+ * If true, this version selector will fail if detects "dependency version
divergence" in graph.
+ */
+protected final boolean enforceVersionConvergence;
Review Comment:
Agreed, is a strategy now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[
https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833491#comment-17833491
]
ASF GitHub Bot commented on MRESOLVER-518:
--
cstamas commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549450171
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConfigurableVersionSelector.java:
##
@@ -0,0 +1,350 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.util.graph.transformer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.eclipse.aether.RepositoryException;
+import org.eclipse.aether.collection.UnsolvableVersionConflictException;
+import org.eclipse.aether.graph.DependencyFilter;
+import org.eclipse.aether.graph.DependencyNode;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictContext;
+import org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictItem;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.VersionSelector;
+import org.eclipse.aether.util.graph.visitor.PathRecordingDependencyVisitor;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A configurable version selector for use with {@link ConflictResolver} that
resolves version conflicts using a
+ * specified strategy. If there is no single node that satisfies all
encountered version ranges, the selector will fail.
+ * Based on configuration, this selector may fail for other reasons as well.
+ *
+ * @since 2.0.0
+ */
+public class ConfigurableVersionSelector extends VersionSelector {
+/**
+ * The strategy how "winner" is being selected.
+ */
+public enum SelectionStrategy {
+/**
+ * This is how Maven3 works, chooses "nearer" dependency for winner.
+ */
+NEARER,
+/**
+ * This is new mode, chooses "higher version" dependency for winner.
+ */
+HIGHER_VERSION;
+}
+/**
+ * The compatibility check strategy.
+ */
+public interface CompatibilityStrategy {
+/**
+ * This method should determine are versions of two items "compatible"
or not. This method is invoked whenever
+ * {@code candidate} is "considered" (does not have to be selected as
"winner").
+ */
+boolean isIncompatibleVersion(ConflictItem candidate, ConflictItem
winner)
+throws UnsolvableVersionConflictException;
+}
+/**
+ * If true, this version selector will fail if detects "dependency version
divergence" in graph.
+ */
+protected final boolean enforceVersionConvergence;
Review Comment:
Agreed, is a strategy now.
> Improvements for version selector
> -
>
> Key: MRESOLVER-518
> URL: https://issues.apache.org/jira/browse/MRESOLVER-518
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Currently Resolver "silently" resolves conflict based on "nearest" strategy,
> without any assumption about selected version (simply the fact it is "nearer
> to root" makes it win).
> Extend this logic by ability to fail collection in case of version conflict,
> version divergence and "version incompatibility" for start. As it may come
> handy, and user may want to fix the build differently than Maven would.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[ https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833483#comment-17833483 ] ASF GitHub Bot commented on MRESOLVER-518: -- cstamas commented on code in PR #450: URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549407294 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/NearestVersionSelector.java: ## @@ -126,7 +129,7 @@ private UnsolvableVersionConflictException newFailure(final ConflictContext cont }; PathRecordingDependencyVisitor visitor = new PathRecordingDependencyVisitor(filter); context.getRoot().accept(new TreeDependencyVisitor(visitor)); -return new UnsolvableVersionConflictException(visitor.getPaths()); +return new UnsolvableVersionConflictException(null, visitor.getPaths()); Review Comment: undone > Improvements for version selector > - > > Key: MRESOLVER-518 > URL: https://issues.apache.org/jira/browse/MRESOLVER-518 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > Currently Resolver "silently" resolves conflict based on "nearest" strategy, > without any assumption about selected version (simply the fact it is "nearer > to root" makes it win). > Extend this logic by ability to fail collection in case of version conflict, > version divergence and "version incompatibility" for start. As it may come > handy, and user may want to fix the build differently than Maven would. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-518] Version selector improvements [maven-resolver]
cstamas commented on code in PR #450: URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549407294 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/NearestVersionSelector.java: ## @@ -126,7 +129,7 @@ private UnsolvableVersionConflictException newFailure(final ConflictContext cont }; PathRecordingDependencyVisitor visitor = new PathRecordingDependencyVisitor(filter); context.getRoot().accept(new TreeDependencyVisitor(visitor)); -return new UnsolvableVersionConflictException(visitor.getPaths()); +return new UnsolvableVersionConflictException(null, visitor.getPaths()); Review Comment: undone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[
https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833477#comment-17833477
]
ASF GitHub Bot commented on MRESOLVER-518:
--
cstamas commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549387693
##
maven-resolver-api/src/main/java/org/eclipse/aether/collection/UnsolvableVersionConflictException.java:
##
@@ -42,9 +42,25 @@ public class UnsolvableVersionConflictException extends
RepositoryException {
* Creates a new exception with the specified paths to conflicting nodes
in the dependency graph.
*
* @param paths The paths to the dependency nodes that participate in the
version conflict, may be {@code null}.
+ * @deprecated Use {@link #UnsolvableVersionConflictException(String,
Collection)} instead.
Review Comment:
No existing code uses this deprecated ctor (not counting deprecated class),
or new one with `null` param, it is left merely for binary compatibility. In
fact, this exception is so special, that nothing else uses it.
> Improvements for version selector
> -
>
> Key: MRESOLVER-518
> URL: https://issues.apache.org/jira/browse/MRESOLVER-518
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Currently Resolver "silently" resolves conflict based on "nearest" strategy,
> without any assumption about selected version (simply the fact it is "nearer
> to root" makes it win).
> Extend this logic by ability to fail collection in case of version conflict,
> version divergence and "version incompatibility" for start. As it may come
> handy, and user may want to fix the build differently than Maven would.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-518] Version selector improvements [maven-resolver]
cstamas commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549387693
##
maven-resolver-api/src/main/java/org/eclipse/aether/collection/UnsolvableVersionConflictException.java:
##
@@ -42,9 +42,25 @@ public class UnsolvableVersionConflictException extends
RepositoryException {
* Creates a new exception with the specified paths to conflicting nodes
in the dependency graph.
*
* @param paths The paths to the dependency nodes that participate in the
version conflict, may be {@code null}.
+ * @deprecated Use {@link #UnsolvableVersionConflictException(String,
Collection)} instead.
Review Comment:
No existing code uses this deprecated ctor (not counting deprecated class),
or new one with `null` param, it is left merely for binary compatibility. In
fact, this exception is so special, that nothing else uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[
https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833476#comment-17833476
]
ASF GitHub Bot commented on MRESOLVER-518:
--
gnodet commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549385293
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConfigurableVersionSelector.java:
##
@@ -0,0 +1,350 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.util.graph.transformer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.eclipse.aether.RepositoryException;
+import org.eclipse.aether.collection.UnsolvableVersionConflictException;
+import org.eclipse.aether.graph.DependencyFilter;
+import org.eclipse.aether.graph.DependencyNode;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictContext;
+import org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictItem;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.VersionSelector;
+import org.eclipse.aether.util.graph.visitor.PathRecordingDependencyVisitor;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A configurable version selector for use with {@link ConflictResolver} that
resolves version conflicts using a
+ * specified strategy. If there is no single node that satisfies all
encountered version ranges, the selector will fail.
+ * Based on configuration, this selector may fail for other reasons as well.
+ *
+ * @since 2.0.0
+ */
+public class ConfigurableVersionSelector extends VersionSelector {
+/**
+ * The strategy how "winner" is being selected.
+ */
+public enum SelectionStrategy {
+/**
+ * This is how Maven3 works, chooses "nearer" dependency for winner.
+ */
+NEARER,
+/**
+ * This is new mode, chooses "higher version" dependency for winner.
+ */
+HIGHER_VERSION;
+}
+/**
+ * The compatibility check strategy.
+ */
+public interface CompatibilityStrategy {
+/**
+ * This method should determine are versions of two items "compatible"
or not. This method is invoked whenever
+ * {@code candidate} is "considered" (does not have to be selected as
"winner").
+ */
+boolean isIncompatibleVersion(ConflictItem candidate, ConflictItem
winner)
+throws UnsolvableVersionConflictException;
+}
+/**
+ * If true, this version selector will fail if detects "dependency version
divergence" in graph.
+ */
+protected final boolean enforceVersionConvergence;
Review Comment:
Should that be a specific selection strategy instead ?
We can't really enforce a single version and select the higher (or nearer)
at the same time, right ?
> Improvements for version selector
> -
>
> Key: MRESOLVER-518
> URL: https://issues.apache.org/jira/browse/MRESOLVER-518
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Currently Resolver "silently" resolves conflict based on "nearest" strategy,
> without any assumption about selected version (simply the fact it is "nearer
> to root" makes it win).
> Extend this logic by ability to fail collection in case of version conflict,
> version divergence and "version incompatibility" for start. As it may come
> handy, and user may want to fix the build differently than Maven would.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-518] Version selector improvements [maven-resolver]
gnodet commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549385293
##
maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConfigurableVersionSelector.java:
##
@@ -0,0 +1,350 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.eclipse.aether.util.graph.transformer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.Iterator;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.eclipse.aether.RepositoryException;
+import org.eclipse.aether.collection.UnsolvableVersionConflictException;
+import org.eclipse.aether.graph.DependencyFilter;
+import org.eclipse.aether.graph.DependencyNode;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictContext;
+import org.eclipse.aether.util.graph.transformer.ConflictResolver.ConflictItem;
+import
org.eclipse.aether.util.graph.transformer.ConflictResolver.VersionSelector;
+import org.eclipse.aether.util.graph.visitor.PathRecordingDependencyVisitor;
+import org.eclipse.aether.util.graph.visitor.TreeDependencyVisitor;
+import org.eclipse.aether.version.Version;
+import org.eclipse.aether.version.VersionConstraint;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A configurable version selector for use with {@link ConflictResolver} that
resolves version conflicts using a
+ * specified strategy. If there is no single node that satisfies all
encountered version ranges, the selector will fail.
+ * Based on configuration, this selector may fail for other reasons as well.
+ *
+ * @since 2.0.0
+ */
+public class ConfigurableVersionSelector extends VersionSelector {
+/**
+ * The strategy how "winner" is being selected.
+ */
+public enum SelectionStrategy {
+/**
+ * This is how Maven3 works, chooses "nearer" dependency for winner.
+ */
+NEARER,
+/**
+ * This is new mode, chooses "higher version" dependency for winner.
+ */
+HIGHER_VERSION;
+}
+/**
+ * The compatibility check strategy.
+ */
+public interface CompatibilityStrategy {
+/**
+ * This method should determine are versions of two items "compatible"
or not. This method is invoked whenever
+ * {@code candidate} is "considered" (does not have to be selected as
"winner").
+ */
+boolean isIncompatibleVersion(ConflictItem candidate, ConflictItem
winner)
+throws UnsolvableVersionConflictException;
+}
+/**
+ * If true, this version selector will fail if detects "dependency version
divergence" in graph.
+ */
+protected final boolean enforceVersionConvergence;
Review Comment:
Should that be a specific selection strategy instead ?
We can't really enforce a single version and select the higher (or nearer)
at the same time, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[ https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833474#comment-17833474 ] ASF GitHub Bot commented on MRESOLVER-518: -- gnodet commented on code in PR #450: URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549378256 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/NearestVersionSelector.java: ## @@ -126,7 +129,7 @@ private UnsolvableVersionConflictException newFailure(final ConflictContext cont }; PathRecordingDependencyVisitor visitor = new PathRecordingDependencyVisitor(filter); context.getRoot().accept(new TreeDependencyVisitor(visitor)); -return new UnsolvableVersionConflictException(visitor.getPaths()); +return new UnsolvableVersionConflictException(null, visitor.getPaths()); Review Comment: No need for this change imho > Improvements for version selector > - > > Key: MRESOLVER-518 > URL: https://issues.apache.org/jira/browse/MRESOLVER-518 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-11 > > > Currently Resolver "silently" resolves conflict based on "nearest" strategy, > without any assumption about selected version (simply the fact it is "nearer > to root" makes it win). > Extend this logic by ability to fail collection in case of version conflict, > version divergence and "version incompatibility" for start. As it may come > handy, and user may want to fix the build differently than Maven would. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-518] Version selector improvements [maven-resolver]
gnodet commented on code in PR #450: URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549378256 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/NearestVersionSelector.java: ## @@ -126,7 +129,7 @@ private UnsolvableVersionConflictException newFailure(final ConflictContext cont }; PathRecordingDependencyVisitor visitor = new PathRecordingDependencyVisitor(filter); context.getRoot().accept(new TreeDependencyVisitor(visitor)); -return new UnsolvableVersionConflictException(visitor.getPaths()); +return new UnsolvableVersionConflictException(null, visitor.getPaths()); Review Comment: No need for this change imho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-518) Improvements for version selector
[
https://issues.apache.org/jira/browse/MRESOLVER-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833473#comment-17833473
]
ASF GitHub Bot commented on MRESOLVER-518:
--
gnodet commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549377629
##
maven-resolver-api/src/main/java/org/eclipse/aether/collection/UnsolvableVersionConflictException.java:
##
@@ -42,9 +42,25 @@ public class UnsolvableVersionConflictException extends
RepositoryException {
* Creates a new exception with the specified paths to conflicting nodes
in the dependency graph.
*
* @param paths The paths to the dependency nodes that participate in the
version conflict, may be {@code null}.
+ * @deprecated Use {@link #UnsolvableVersionConflictException(String,
Collection)} instead.
Review Comment:
I don't see the point of deprecating this constructor, since it forces the
addition of a `null` parameter and lead the user to a change which is useless,
given the message has a default value.
> Improvements for version selector
> -
>
> Key: MRESOLVER-518
> URL: https://issues.apache.org/jira/browse/MRESOLVER-518
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Currently Resolver "silently" resolves conflict based on "nearest" strategy,
> without any assumption about selected version (simply the fact it is "nearer
> to root" makes it win).
> Extend this logic by ability to fail collection in case of version conflict,
> version divergence and "version incompatibility" for start. As it may come
> handy, and user may want to fix the build differently than Maven would.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-518] Version selector improvements [maven-resolver]
gnodet commented on code in PR #450:
URL: https://github.com/apache/maven-resolver/pull/450#discussion_r1549377629
##
maven-resolver-api/src/main/java/org/eclipse/aether/collection/UnsolvableVersionConflictException.java:
##
@@ -42,9 +42,25 @@ public class UnsolvableVersionConflictException extends
RepositoryException {
* Creates a new exception with the specified paths to conflicting nodes
in the dependency graph.
*
* @param paths The paths to the dependency nodes that participate in the
version conflict, may be {@code null}.
+ * @deprecated Use {@link #UnsolvableVersionConflictException(String,
Collection)} instead.
Review Comment:
I don't see the point of deprecating this constructor, since it forces the
addition of a `null` parameter and lead the user to a change which is useless,
given the message has a default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MARTIFACT-59) artifact plugin should tolerate injected project.build.outputTimestamp
[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833464#comment-17833464
]
ASF GitHub Bot commented on MARTIFACT-59:
-
rmannibucau commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034028188
> see https://gist.github.com/hboutemy/cca5a94c6f7a9bc65023a31c31d3308f
You have the same error than me.
> I don't get what CLI command it is related to: mvn
-Dproject.nuild.outputTimestamp=set
> I'm trying to guess the problem
`mvn ` no `-D`. The key point is that in the pom you have an
interpolated value. See
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2026810271
which explains it.
This kind of injected (=interpolated) value just fails exactly the same than
moditech in your example on both commands (first exit with status=0 but logs an
error which is wrong and second just fails).
> artifact plugin should tolerate injected project.build.outputTimestamp
> --
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
>Reporter: Romain Manni-Bucau
>Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MARTIFACT-59] tolerate injected timestamp value [maven-artifact-plugin]
rmannibucau commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2034028188 > see https://gist.github.com/hboutemy/cca5a94c6f7a9bc65023a31c31d3308f You have the same error than me. > I don't get what CLI command it is related to: mvn -Dproject.nuild.outputTimestamp=set > I'm trying to guess the problem `mvn ` no `-D`. The key point is that in the pom you have an interpolated value. See https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2026810271 which explains it. This kind of injected (=interpolated) value just fails exactly the same than moditech in your example on both commands (first exit with status=0 but logs an error which is wrong and second just fails). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRESOLVER-522) File locking threads not entering critical region were "oversleeping"
Tamas Cservenak created MRESOLVER-522: - Summary: File locking threads not entering critical region were "oversleeping" Key: MRESOLVER-522 URL: https://issues.apache.org/jira/browse/MRESOLVER-522 Project: Maven Resolver Issue Type: Bug Components: Resolver Reporter: Tamas Cservenak Assignee: Tamas Cservenak Fix For: 2.0.0, 2.0.0-alpha-11 Instead loser to immediately give up and sleep, should sit a while to enter critical region. This is important for "hot" locks. Explanation: currently a "loser" will _immediately give up_ and will go to sleep 100ms, even if winner exits critical region within next 5ms (so lost 95ms). The retry is needed to ensure that it is retried as much as given time/unit takes, that was before consumed by constant retries+sleeps. The logic still works, as if tryLock spends time/unit waiting on critical region (which is possible only on VERY HIGHLY congested locks), there will be no retry happening. Still, now it may sleep 5ms, and "win" once "original winner" left the critical region. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-522) File locking threads not entering critical region were "oversleeping"
[ https://issues.apache.org/jira/browse/MRESOLVER-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-522: -- Fix Version/s: 1.9.19 (was: 2.0.0) (was: 2.0.0-alpha-11) > File locking threads not entering critical region were "oversleeping" > - > > Key: MRESOLVER-522 > URL: https://issues.apache.org/jira/browse/MRESOLVER-522 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 1.9.19 > > > Instead loser to immediately give up and sleep, should sit a while to enter > critical region. This is important for "hot" locks. > Explanation: currently a "loser" will _immediately give up_ and will go to > sleep 100ms, even if winner exits critical region within next 5ms (so lost > 95ms). The retry is needed to ensure that it is retried as much as given > time/unit takes, that was before consumed by constant retries+sleeps. The > logic still works, as if tryLock spends time/unit waiting on critical region > (which is possible only on VERY HIGHLY congested locks), there will be no > retry happening. Still, now it may sleep 5ms, and "win" once "original > winner" left the critical region. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-498) Investigate possible solutions for build number diffs on deploy
[ https://issues.apache.org/jira/browse/MRESOLVER-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-498: -- Fix Version/s: (was: 1.9.19) > Investigate possible solutions for build number diffs on deploy > --- > > Key: MRESOLVER-498 > URL: https://issues.apache.org/jira/browse/MRESOLVER-498 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > > The "snapshot freeze" is a common practice during development: simply use a > timestamped snapshot as dependency version instead of "-SNAPSHOT" ending one > to "freeze" given snapshot deploy. > This works for simple cases (one dependency, or "aligned" reactor). > But take a look at Resolver itself: it has new-old and added-gone-readded > modules, and their build numbers are different. > Problem is, that while timestamp is _same_ (deduced from session start), the > build number is determined from remote repository (deploy target) state. > This makes "snapshot lock down" impossible on long(er) running projects, like > Resolver itself is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIASITETOOLS-334) Pass project relative source path to Parser.parse(...) as reference argument
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-334: -- Fix Version/s: 2.0.0 > Pass project relative source path to Parser.parse(...) as reference argument > > > Key: DOXIASITETOOLS-334 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Currently only the file name (without its path) is passed in > https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369. > In order to ease identifying the file the relative path should be passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Consistency log Doxia source path for Velocity actions [maven-doxia-sitetools]
michael-o merged PR #144: URL: https://github.com/apache/maven-doxia-sitetools/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (DOXIASITETOOLS-334) Pass project relative source path to Parser.parse(...) as reference argument
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned DOXIASITETOOLS-334: -- Assignee: Konrad Windszus > Pass project relative source path to Parser.parse(...) as reference argument > > > Key: DOXIASITETOOLS-334 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0-M18 > > > Currently only the file name (without its path) is passed in > https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369. > In order to ease identifying the file the relative path should be passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8091) Update Resolver to 2.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MNG-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833446#comment-17833446 ] ASF GitHub Bot commented on MNG-8091: - cstamas commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549211825 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: Resolver is still not synced, in fact, is "half synced" only :disappointed: > Update Resolver to 2.0.0-alpha-10 > - > > Key: MNG-8091 > URL: https://issues.apache.org/jira/browse/MNG-8091 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8091] Update Resolver to 2.0.0-alpha-10 [maven]
cstamas commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549211825 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: Resolver is still not synced, in fact, is "half synced" only :disappointed: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8091) Update Resolver to 2.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MNG-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833441#comment-17833441 ] ASF GitHub Bot commented on MNG-8091: - gnodet commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549193467 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: Should we get rid of this now ? ``` ➜ maven git:(model-buider-v4-b) ✗ mima list org.apache.maven.resolver:maven-resolver-connector-basic | grep 2.0.0-alpha-10 org.apache.maven.resolver:maven-resolver-connector-basic:2.0.0-alpha-10 ``` > Update Resolver to 2.0.0-alpha-10 > - > > Key: MNG-8091 > URL: https://issues.apache.org/jira/browse/MNG-8091 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8091] Update Resolver to 2.0.0-alpha-10 [maven]
gnodet commented on code in PR #1460: URL: https://github.com/apache/maven/pull/1460#discussion_r1549193467 ## pom.xml: ## @@ -641,6 +641,22 @@ under the License. + Review Comment: Should we get rid of this now ? ``` ➜ maven git:(model-buider-v4-b) ✗ mima list org.apache.maven.resolver:maven-resolver-connector-basic | grep 2.0.0-alpha-10 org.apache.maven.resolver:maven-resolver-connector-basic:2.0.0-alpha-10 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DOXIASITETOOLS-334) Pass project relative source path to Parser.parse(...) as reference argument
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIASITETOOLS-334. Resolution: Fixed Fixed in https://github.com/apache/maven-doxia-sitetools/commit/79086a0a3f4b256ff053bb771aefaa6387d2d7cb. > Pass project relative source path to Parser.parse(...) as reference argument > > > Key: DOXIASITETOOLS-334 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-334 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Reporter: Konrad Windszus >Priority: Major > Fix For: 2.0.0-M18 > > > Currently only the file name (without its path) is passed in > https://github.com/apache/maven-doxia-sitetools/blob/96e245055fa90689ab5464a39b2bea5d4477cedf/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L369. > In order to ease identifying the file the relative path should be passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOL-334] Pass project-relative file path as reference to [maven-doxia-sitetools]
kwin merged PR #142: URL: https://github.com/apache/maven-doxia-sitetools/pull/142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MGPG-122) Update build dependency m-invoker-p to 3.6.1
[ https://issues.apache.org/jira/browse/MGPG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MGPG-122. Resolution: Fixed > Update build dependency m-invoker-p to 3.6.1 > > > Key: MGPG-122 > URL: https://issues.apache.org/jira/browse/MGPG-122 > Project: Maven GPG Plugin > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.2.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 [maven-gpg-plugin]
cstamas merged PR #89: URL: https://github.com/apache/maven-gpg-plugin/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MGPG-122) Update build dependency m-invoker-p to 3.6.1
[ https://issues.apache.org/jira/browse/MGPG-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MGPG-122: Assignee: Tamas Cservenak > Update build dependency m-invoker-p to 3.6.1 > > > Key: MGPG-122 > URL: https://issues.apache.org/jira/browse/MGPG-122 > Project: Maven GPG Plugin > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.2.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MGPG-122) Update build dependency m-invoker-p to 3.6.1
Tamas Cservenak created MGPG-122: Summary: Update build dependency m-invoker-p to 3.6.1 Key: MGPG-122 URL: https://issues.apache.org/jira/browse/MGPG-122 Project: Maven GPG Plugin Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 3.2.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MGPG-121) Signing fails with 3.2.2: "/Users/stevenobelia/.settings-security.xml (No such file or directory)"
[
https://issues.apache.org/jira/browse/MGPG-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MGPG-121:
Assignee: Tamas Cservenak
> Signing fails with 3.2.2: "/Users/stevenobelia/.settings-security.xml (No
> such file or directory)"
> --
>
> Key: MGPG-121
> URL: https://issues.apache.org/jira/browse/MGPG-121
> Project: Maven GPG Plugin
> Issue Type: Bug
>Affects Versions: 3.2.0, 3.2.1, 3.2.2
> Environment: os: macOS Sonoma 14.3.1
> jdk: jdk1.8.0_231
> maven: 3.6.0
> maven-gpg-plugin: 3.2.2, 3.2.1,3.2.0 (not work), 3.1.0 (normal)
>Reporter: Wang Tangfu
>Assignee: Tamas Cservenak
>Priority: Minor
> Fix For: 3.2.3
>
>
> * Desc:
> According to *maven-gpg-plugin* ([Docs|
> [https://maven.apache.org/plugins/maven-gpg-plugin/usage.html#configure-passphrase-in-settings-xml]])
> configuration of the current project using GPG signatures.
> The encrypted passphrase configured in settings.xml is used. When
> decrypting, the master password file 'settings-security.xml' is found to be
> wrong, causing the signature to fail.
> * Possible cause:
> After 3.1.0 version due to remove '{*}/META-INF/plexus/components.xml{*}',
> cause 'DefaultSecDispatcher' use the default values
> [~/.settings-security.xml]， rather than [~/.m2/settings-security.xml]。
> * Expect:
> Even if it is not secure, do not report an error that causes the signature to
> fail. Or by forcing the use of environment variables to control user behavior.
> * pom.xml
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> site.wtfu.framework
> idea-debug
> 1.0-SNAPSHOT
>
> 1.8
> 1.8
> UTF-8
>
>
>
>
> org.apache.maven.plugins
> maven-gpg-plugin
> 3.2.2
>
>
> sign-artifacts
> verify
>
> sign
>
>
>
>
>
>
> {code}
> * settings.xml
> {code:java}
>
> http://maven.apache.org/SETTINGS/1.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
> http://maven.apache.org/xsd/settings-1.0.0.xsd;>
> ${user.home}/Documents/maven_repo
>
> com.haohuo.framework
>
>
>
>
>
> gpg.passphrase
>
> {AcPACqkxKm8H9FSK3OnqmM9+a1VQ7po8KQuQ+38pzjY=}
>
>
>
>
>
> father
> true
>
> 48E1F1185160B400
>
>
>
> ali
> ali maven lib
>
> http://maven.aliyun.com/nexus/content/groups/public/
> true
> false
>
>
>
>
> other-plugin
> other-plugin-name
>
> http://maven.aliyun.com/nexus/content/groups/public/
> true
> false
>
>
>
>
>
> {code}
> * log:
> {code:java}
> /Library/Java/JavaVirtualMachines/jdk1.8.0_231.jdk/Contents/Home/bin/java
> -Dmaven.multiModuleProjectDirectory=/Users/stevenobelia/Documents/project_idea_test/idea-debug
> -Djansi.passthrough=true
> -Dmaven.home=/Users/stevenobelia/software/apache-maven-3.6.0
> -Dclassworlds.conf=/Users/stevenobelia/software/apache-maven-3.6.0/bin/m2.conf
> -Dmaven.ext.class.path=/Applications/IntelliJ
> IDEA.app/Contents/plugins/maven/lib/maven-event-listener.jar
> -javaagent:/Applications/IntelliJ
> IDEA.app/Contents/lib/idea_rt.jar=51353:/Applications/IntelliJ
> IDEA.app/Contents/bin -Dfile.encoding=UTF-8 -classpath
> /Users/stevenobelia/software/apache-maven-3.6.0/boot/plexus-classworlds-2.5.2.jar
> org.codehaus.classworlds.Launcher -Didea.version=2023.2.3 verify
> [INFO] Scanning for projects...
> [INFO]
> [INFO] ---< site.wtfu.framework:idea-debug
> >---
> [INFO] Building idea-debug 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> idea-debug ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO]
>
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833411#comment-17833411 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy commented on PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-2033662072 > With m-compiler-p 3.13.0 we can add the release property and it will be ignored when compiling under Java 8. yes, that solution is much better, I'll drop this PR > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MARCHETYPES-82] generate comments for maven.compiler.release [maven-archetypes]
hboutemy commented on PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-2033662072 > With m-compiler-p 3.13.0 we can add the release property and it will be ignored when compiling under Java 8. yes, that solution is much better, I'll drop this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833412#comment-17833412 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy closed pull request #28: [MARCHETYPES-82] generate comments for maven.compiler.release URL: https://github.com/apache/maven-archetypes/pull/28 > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MARCHETYPES-82] generate comments for maven.compiler.release [maven-archetypes]
hboutemy closed pull request #28: [MARCHETYPES-82] generate comments for maven.compiler.release URL: https://github.com/apache/maven-archetypes/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
