[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833411#comment-17833411 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy commented on PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-2033662072 > With m-compiler-p 3.13.0 we can add the release property and it will be ignored when compiling under Java 8. yes, that solution is much better, I'll drop this PR > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833412#comment-17833412 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy closed pull request #28: [MARCHETYPES-82] generate comments for maven.compiler.release URL: https://github.com/apache/maven-archetypes/pull/28 > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832741#comment-17832741 ] ASF GitHub Bot commented on MARCHETYPES-82: --- judovana commented on code in PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1545998274 ## maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml: ## @@ -15,6 +15,7 @@ UTF-8 1.7 1.7 + Review Comment: ouch.ty! > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832589#comment-17832589 ] ASF GitHub Bot commented on MARCHETYPES-82: --- slachiewicz commented on PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-2028722977 With m-compiler-p 3.13.0 we can add the release property and it will be ignored when compiling under Java 8. > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807064#comment-17807064 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy commented on PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-1893138996 Many people seem not to know about ` 11` adding a comment is just an idea to spread the knowledge you're right that if people grep, they'll need to take care about the comment eager to see feedback from others: is such a comment a benefit or more a problem? > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[
https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807061#comment-17807061
]
ASF GitHub Bot commented on MARCHETYPES-82:
---
hboutemy commented on code in PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1452971420
##
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
##
@@ -6,6 +6,7 @@
#else
${javaCompilerVersionLocal}
${javaCompilerVersionLocal}
+
Review Comment:
this comment is best placed here because it is activated only when
javaCompilerVersionLocal <= 8, based on effective value at runtime
> generate maven.compiler.release property as comment
> ---
>
> Key: MARCHETYPES-82
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-82
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Affects Versions: 1.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 1.5
>
>
> if JDK 11+ is used to compile, it's better to define maven.compiler.release
> instead of maven.compiler.source/target
> we currently generate for Java 8, so we don't really know if the compiler
> used support release parameter
> adding a comment is a good first step to help discovery, before benefiting
> from MARCHETYPES-70 when generating against newer JDK
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807060#comment-17807060 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy commented on code in PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1452968733 ## maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml: ## @@ -15,6 +15,7 @@ UTF-8 1.7 1.7 + Review Comment: no, this one is a unit test with value defined in command line: user can decide to generate with forced 1.7 value, that's a good test to keep > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[
https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806684#comment-17806684
]
ASF GitHub Bot commented on MARCHETYPES-82:
---
judovana commented on PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-1891540458
I still think the
```
${javaCompilerVersionLocal}
${javaCompilerVersionLocal}
+
```
is misplaced, and should be at
https://github.com/apache/maven-archetypes/blob/master/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L49
Generally I think this commit is not helpful, as it will just confuse any
future grep/sed and generally any maven user/java developer should be able to
bump 8 to 11, or generally to anything they need.
I had missed reasoning why you actually proposed this changeset.
Thanx for merging #27 . As for this, I'm -1, but I do not have any
permissions of any weight :) Good luck!
> generate maven.compiler.release property as comment
> ---
>
> Key: MARCHETYPES-82
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-82
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Affects Versions: 1.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 1.5
>
>
> if JDK 11+ is used to compile, it's better to define maven.compiler.release
> instead of maven.compiler.source/target
> we currently generate for Java 8, so we don't really know if the compiler
> used support release parameter
> adding a comment is a good first step to help discovery, before benefiting
> from MARCHETYPES-70 when generating against newer JDK
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806681#comment-17806681 ] ASF GitHub Bot commented on MARCHETYPES-82: --- judovana commented on code in PR #28: URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1452039881 ## maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml: ## @@ -15,6 +15,7 @@ UTF-8 1.7 1.7 + Review Comment: Looks like forgotten 1.7? > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[
https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806498#comment-17806498
]
ASF GitHub Bot commented on MARCHETYPES-82:
---
hboutemy commented on code in PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1451770820
##
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
##
@@ -6,6 +6,7 @@
#else
${javaCompilerVersionLocal}
${javaCompilerVersionLocal}
+
Review Comment:
#27 merged, I'll rebase: this will ease understanding the scope of this
precise PR
> generate maven.compiler.release property as comment
> ---
>
> Key: MARCHETYPES-82
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-82
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Affects Versions: 1.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 1.5
>
>
> if JDK 11+ is used to compile, it's better to define maven.compiler.release
> instead of maven.compiler.source/target
> we currently generate for Java 8, so we don't really know if the compiler
> used support release parameter
> adding a comment is a good first step to help discovery, before benefiting
> from MARCHETYPES-70 when generating against newer JDK
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[
https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804181#comment-17804181
]
ASF GitHub Bot commented on MARCHETYPES-82:
---
judovana commented on code in PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1444310865
##
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
##
@@ -6,6 +6,7 @@
#else
${javaCompilerVersionLocal}
${javaCompilerVersionLocal}
+
Review Comment:
I think this comment belongst to:
https://github.com/apache/maven-archetypes/blob/master/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L49
> generate maven.compiler.release property as comment
> ---
>
> Key: MARCHETYPES-82
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-82
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Affects Versions: 1.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 1.5
>
>
> if JDK 11+ is used to compile, it's better to define maven.compiler.release
> instead of maven.compiler.source/target
> we currently generate for Java 8, so we don't really know if the compiler
> used support release parameter
> adding a comment is a good first step to help discovery, before benefiting
> from MARCHETYPES-70 when generating against newer JDK
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-82) generate maven.compiler.release property as comment
[ https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803985#comment-17803985 ] ASF GitHub Bot commented on MARCHETYPES-82: --- hboutemy opened a new pull request, #28: URL: https://github.com/apache/maven-archetypes/pull/28 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MARCHETYPES-82) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MARCHETYPES-XXX] SUMMARY`, where you replace `MARCHETYPES-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > generate maven.compiler.release property as comment > --- > > Key: MARCHETYPES-82 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-82 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > if JDK 11+ is used to compile, it's better to define maven.compiler.release > instead of maven.compiler.source/target > we currently generate for Java 8, so we don't really know if the compiler > used support release parameter > adding a comment is a good first step to help discovery, before benefiting > from MARCHETYPES-70 when generating against newer JDK -- This message was sent by Atlassian Jira (v8.20.10#820010)
