[jira] [Created] (CODEC-231) StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE

2017-03-26 Thread Sebb (JIRA)
Sebb created CODEC-231: -- Summary: StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE Key: CODEC-231 URL: https://issues.apache.org/jira/browse/CODEC-231 Project: Commons Codec

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (CODEC-231) StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CODEC-231: --- Affects Version/s: 1.10 > StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String > Index OBE >

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

2017-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942595#comment-15942595 ] ASF GitHub Bot commented on LANG-1317: -- Github user yasserzamani commented on the issue:

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

2017-03-26 Thread yasserzamani
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 Another bad thing is that `getMethodsWithAnnotation(cls, annotationCls, false, false)` will be a duplicate for `getMethodsWithAnnotation(cls, annotationCls)`. Another solution is

[jira] [Resolved] (CODEC-231) StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CODEC-231. Resolution: Fixed Fix Version/s: 1.11 URL: http://svn.apache.org/viewvc?rev=1788777=rev Log: CODEC-231

[jira] [Updated] (CODEC-231) StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String Index OBE

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CODEC-231: --- Issue Type: Bug (was: Improvement) > StringUtils.equals(CharSequence cs1, CharSequence cs2) can fail with String >

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (NET-629) NET-629 Added IP4Subnet and IP6Subnet classes

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-629: - Description: IP4Subnet and IP6Subnet classes which provide subnet summary information for each IP

[jira] [Closed] (NET-629) NET-629 Added IP4Subnet and IP6Subnet classes

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi closed NET-629. Resolution: Done > NET-629 Added IP4Subnet and IP6Subnet classes >

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Updated] (NET-630) NET-630 Changed SubnetUtils for NEW SubnetInfo subclass

2017-03-26 Thread Makoto Sakaguchi (JIRA)
[ https://issues.apache.org/jira/browse/NET-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Sakaguchi updated NET-630: - Description: The constructors of this class has been modified to create a object of subnet summary

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

2017-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942375#comment-15942375 ] ASF GitHub Bot commented on LANG-1317: -- Github user PascalSchumacher commented on the issue:

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

2017-03-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/261 Thanks for the pull request! It is really unfortunate that the existing method `getMethodsWithAnnotation` is not called `getAccessibleMethodsWithAnnotation` : (, because

[jira] [Updated] (EMAIL-171) buildMimeMessage() unconditionally encodes and folds header values

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated EMAIL-171: --- Description: The buildMimeMessage() method unconditionally calls MimeUtility#fold and MimeUtility#encodeText for all

[GitHub] commons-lang issue #231: Evaluate Architecure

2017-03-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/231 @sebbASF What do you think about the latest changes? Is this pull request ready for merging? Thanks, Pascal --- If your project is set up for it, you can reply to this email

[jira] [Created] (CODEC-230) URLCodec.WWW_FORM_URL should be private

2017-03-26 Thread Sebb (JIRA)
Sebb created CODEC-230: -- Summary: URLCodec.WWW_FORM_URL should be private Key: CODEC-230 URL: https://issues.apache.org/jira/browse/CODEC-230 Project: Commons Codec Issue Type: Bug Affects

[jira] [Updated] (CODEC-229) StringUtils.newStringxxx(null) should return null, not NPE

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CODEC-229: --- Affects Version/s: 1.10 > StringUtils.newStringxxx(null) should return null, not NPE >

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

2017-03-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/261 You are right. The method signature I suggested omits the important super part. I agree it should be something like `getMethodsWithAnnotation(Class cls, annotationCls, boolean

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

2017-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942402#comment-15942402 ] ASF GitHub Bot commented on LANG-1317: -- Github user PascalSchumacher commented on the issue:

[jira] [Comment Edited] (CODEC-91) Handling of embedded padding in base64 encoded data changed in 1.4

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=12875013#comment-12875013 ] Sebb edited comment on CODEC-91 at 3/26/17 6:59 PM: I'm clearly in favour of the current

[jira] [Created] (CODEC-229) StringUtils.newStringxxx(null) should return null, not NPE

2017-03-26 Thread Sebb (JIRA)
Sebb created CODEC-229: -- Summary: StringUtils.newStringxxx(null) should return null, not NPE Key: CODEC-229 URL: https://issues.apache.org/jira/browse/CODEC-229 Project: Commons Codec Issue Type: Bug

[jira] [Resolved] (CODEC-229) StringUtils.newStringxxx(null) should return null, not NPE

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CODEC-229. Resolution: Fixed Fix Version/s: 1.11 URL: http://svn.apache.org/viewvc?rev=1788755=rev Log: CODEC-229

[jira] [Resolved] (CODEC-230) URLCodec.WWW_FORM_URL should be private

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CODEC-230. Resolution: Fixed Fix Version/s: 1.11 URL: http://svn.apache.org/viewvc?rev=1788761=rev Log: CODEC-230

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

2017-03-26 Thread yasserzamani
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 @PascalSchumacher , thank you! I was overloaded by another job and forgot that I also can use method overloads. Yes, strongly I agree. Just I have some doubts about name

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

2017-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942390#comment-15942390 ] ASF GitHub Bot commented on LANG-1317: -- Github user yasserzamani commented on the issue:

[jira] [Updated] (CODEC-166) Base64 could be faster

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated CODEC-166: --- Issue Type: Wish (was: Bug) > Base64 could be faster > -- > > Key: CODEC-166 >

[jira] [Commented] (CONFIGURATION-655) Reading configuration from InputStream - improvement

2017-03-26 Thread Oliver Heger (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942427#comment-15942427 ] Oliver Heger commented on CONFIGURATION-655: Thanks for creating this ticket. There is

[jira] [Updated] (EMAIL-171) buildMimeMessage() unconditionally encodes and folds header values

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/EMAIL-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated EMAIL-171: --- Summary: buildMimeMessage() unconditionally encodes and folds header values (was: buildMimeMessage() unconditionally

[jira] [Commented] (CODEC-228) URLCodec.decode does not throw DecoderException with invalid UTF-8

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942341#comment-15942341 ] Sebb commented on CODEC-228: This is because the code uses new String(decoded_bytes, charset) to convert the

[jira] [Commented] (CODEC-126) Make org.apache.commons.codec.net.URLCodec charset field final

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942386#comment-15942386 ] Sebb commented on CODEC-126: Should also be converted to a Charset and made private > Make

[GitHub] commons-lang issue #231: Evaluate Architecure

2017-03-26 Thread sebbASF
Github user sebbASF commented on the issue: https://github.com/apache/commons-lang/pull/231 looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (CONFIGURATION-654) Add optionalConfigurationAt method to HierarchicalConfiguration

2017-03-26 Thread Oliver Heger (JIRA)
[ https://issues.apache.org/jira/browse/CONFIGURATION-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942338#comment-15942338 ] Oliver Heger commented on CONFIGURATION-654: Sounds like a reasonable enhancement. I

[jira] [Commented] (CODEC-136) Use Charset objects when possible, create Charsets class for required character encodings

2017-03-26 Thread Sebb (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942343#comment-15942343 ] Sebb commented on CODEC-136: URL: http://svn.apache.org/viewvc?rev=1306366=rev Log: [CODEC-136] Use Charset

[jira] [Commented] (LANG-1317) Add findAnnotation and findMethodsWithAnnotation to MethodUtils

2017-03-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942195#comment-15942195 ] ASF GitHub Bot commented on LANG-1317: -- Github user coveralls commented on the issue:

[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...

2017-03-26 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/261 [![Coverage Status](https://coveralls.io/builds/10775689/badge)](https://coveralls.io/builds/10775689) Coverage decreased (-0.002%) to 94.603% when pulling