[ 
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942402#comment-15942402
 ] 

ASF GitHub Bot commented on LANG-1317:
--------------------------------------

Github user PascalSchumacher commented on the issue:

    https://github.com/apache/commons-lang/pull/261
  
    You are right. The method signature I suggested omits the important super 
part. I agree it should be something like `getMethodsWithAnnotation(Class cls, 
annotationCls, boolean searchSupers, boolean ignoreAccess)`. (I'm not a fan of 
boolean parameters (especially multiple ones), so if somebody has an idea for a 
good method name, that is welcome.)


> Add findAnnotation and findMethodsWithAnnotation to MethodUtils
> ---------------------------------------------------------------
>
>                 Key: LANG-1317
>                 URL: https://issues.apache.org/jira/browse/LANG-1317
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>            Reporter: Yasser Zamani
>              Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to 
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also 
> searches interfaces and super classes while caching results with no memory 
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation 
> that also supports non public methods, super class and interface methods, 
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be 
> working on it :) 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to