KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 27 Apr 2020 03:53:37 + Build duration: 6 min 20 sec and counting JUnit Tests

D29219: [KFontChooser] Remove NoFixedCheckBox DisplayFlag, redundant

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This partially reverts 0004e5c89a248a508a

D28874: Taiwanese holidays

nhiga added a comment. By the way, the holiday file for People's Republic of China (i.e. mainland China) also needs update too because the dates of Lunar calendar based holidays are only available for 2009. The comment in the file says "these have to wait for lunar calendar support", but

Information regarding upcoming Gitlab Migration

[Please keep sysad...@kde.org list or bs...@kde.org in the CC for replies] Hello Community members, In view of upcoming Gitlab migration, we sysadmin team wants to share the recommended structuring for the repositories on Gitlab. We had multiple options, - Flat structure: In this option we

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH 2020_04_remove_dead_solid_code REVISION DETAIL https://phabricator.kde.org/D29216 To: dfaure, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29210: [NestedListHelper] Fix indentation of selection, add tests

dfaure added inline comments. INLINE COMMENTS > nestedlisthelper.cpp:225 > +if (delta > 0) { > +// No list, we're increasing indentation -> create a new one > +listFmt.setStyle(QTextListFormat::ListDisc); should the opposite happen? delete the list

Re: KF 5 & C++14?

On Sunday, April 26, 2020 5:30:37 PM CEST Friedrich W. H. Kossebau wrote: > Hi, > > I just saw that at least kimageformats, knewstuff & kquickcharts all set > this: set(CMAKE_CXX_STANDARD 14) > set(CMAKE_CXX_STANDARD_REQUIRED ON) > > Which ignores a bit that so far C++11 has been the minimum

D29198: filenamesearch:/ define a title for the query

elvisangelaccio accepted this revision. elvisangelaccio added a subscriber: iasensio. elvisangelaccio added a comment. This revision is now accepted and ready to land. LGTM but I'd like input from @iasensio too. INLINE COMMENTS > dolphinsearchbox.h:164 > private: > +QString

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 26 Apr 2020 21:52:51 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

D29216: Remove dead code since KF5.0: mount/umount devices in their contextmenu

dfaure created this revision. dfaure added reviewers: apol, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This code was disabled in preparation for KF 5.0 to remove kio's dependency on

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

ahmadsamir added a comment. I forgot to change the commit message about hiding the show only monospaced fonts checkbox when FixedFontsOnly is set... at least the API docs do mention it :/. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29065 To:

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob

dfaure updated this revision to Diff 81281. dfaure retitled this revision from "Move check for invalid service from KDesktopFileActions to ApplicationLauncherJobTest" to "Move check for invalid service from KDesktopFileActions to ApplicationLauncherJob". dfaure added a comment. fix wrong

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

dfaure added a reviewer: svuorela. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28760 To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81275. dfaure added a comment. Remove support for relative executables, as discussed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29170?vs=81228=81275 BRANCH 2020_04_findExecutable REVISION DETAIL

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday April 26 2020 20:16:33 René J.V. Bertin wrote: >I was referring to code that just rolls their own implementation of the code >in almost an given library. It's a bit of a pathological argument but I'd say >it's beyond argument that you can always do that, whereas even exhaustive

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday April 26 2020 18:19:28 David Faure wrote: >> The possibility to use precompiled headers is only an argument here when >> increased compilation times are brought up as an argument against such a >> header. But that's not really an argument if you can continue to use just >> the headers

D29210: [NestedListHelper] Fix indentation of selection, add tests

poboiko created this revision. poboiko added reviewers: Frameworks, dfaure, mlaurent. poboiko requested review of this revision. REVISION SUMMARY When we try to increase / decrease an indentation level of a selection, just change indentation level of each block in the selection, and then

D29170: Detect executables without +x permission in $PATH to improve error message

ahmadsamir added a comment. In D29170#657689 , @dfaure wrote: > In D29170#657450 , @ahmadsamir wrote: > > > I don't think you need to go out of your way to support custom setups, after all it's

D29199: honor the extractMetaData flag

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81258. astippich added a comment. - use continue REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81257=81258 BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199 AFFECTED FILES

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81257. astippich added a comment. - fix another stupid mistake REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81253=81257 BRANCH honorFlag REVISION DETAIL https://phabricator.kde.org/D29199

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday, April 26, 2020 5:50:40 PM CEST René J.V. Bertin wrote: > On Sunday April 26 2020 16:58:10 David Faure wrote: > >> As a side-note, I'd even argue that > >> it would make sense to provide an all-inclusive header per framework, > >> just > >> like Apple's frameworks do. > > > >It's said to

D29208: [NestedListHelper] Improve indentation code

poboiko created this revision. poboiko added reviewers: Frameworks, dfaure, mlaurent. Herald added a project: Frameworks. poboiko requested review of this revision. REVISION SUMMARY The patch includes following improvements: 1. `handleAfterKeyPressEvent` was only used to adjust margins. We

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday April 26 2020 16:58:10 David Faure wrote: >> As a side-note, I'd even argue that >> it would make sense to provide an all-inclusive header per framework, just >> like Apple's frameworks do. > >It's said to improve compilation times with precompiled headers, but in >practice nobody

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added a comment. In D29170#657450 , @ahmadsamir wrote: > I don't think you need to go out of your way to support custom setups, after all it's quite simple for the user to edit the .desktop file and specify the path to the executable.

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked 2 inline comments as done. marcingu added inline comments. INLINE COMMENTS > meven wrote in thumbnail.cpp:738 > Can't you move this out of the loop ? Since `m_thumbBasePath` does not change. I've moved this check into new method, so it should make more sense now. REPOSITORY

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela,

D28745: Skip caching thumbnails on encrypted filesystems

marcingu updated this revision to Diff 81255. marcingu added a comment. Moving check for sharing filesystem with thumbroot into new method. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=81167=81255 REVISION DETAIL

KF 5 & C++14?

Hi, I just saw that at least kimageformats, knewstuff & kquickcharts all set this: set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED ON) Which ignores a bit that so far C++11 has been the minimum standard officially supported in/by KDE Frameworks (by mainly following what Qt 5

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 26 Apr 2020 15:06:59 + Build duration: 7 min 55 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 26 Apr 2020 15:06:59 + Build duration: 5 min 28 sec and counting BUILD ARTIFACTS

D29199: honor the extractMetaData flag

astippich marked 2 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in xmlextractor.cpp:103 > skipped, `if (!) { continue; }` sorry, that went lost somehow REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To:

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81253. astippich marked an inline comment as done. astippich added a comment. - more fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81248=81253 BRANCH honorFlag REVISION DETAIL

D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The name based mime type is inaccurate, so it should not be used to decide

D28932: Store filename terms just once

bruns added a dependent revision: D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack,

D29199: honor the extractMetaData flag

bruns added inline comments. INLINE COMMENTS > exiv2extractor.cpp:172 > > -if (image->pixelHeight()) { > -result->add(Property::Height, image->pixelHeight()); > -} > +if (result->inputFlags() & ExtractionResult::ExtractMetaData) { > `if (!) return` > astippich wrote

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday, April 26, 2020 4:32:46 PM CEST René J.V. Bertin wrote: > On Sunday April 26 2020 15:46:35 David Faure wrote: > >Well, yeah, you can't have it all. > > I suppose that the appropriate ECM could provide a function that returns the > path to the "official" Qt headers (or an expression that

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJobTest

dfaure updated this revision to Diff 81250. dfaure added a comment. remove redundant line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29206?vs=81249=81250 BRANCH 2020_04_invalid_service REVISION DETAIL https://phabricator.kde.org/D29206 AFFECTED

D29206: Move check for invalid service from KDesktopFileActions to ApplicationLauncherJobTest

dfaure created this revision. dfaure added reviewers: ahmadsamir, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN New unittest passes REPOSITORY R241 KIO BRANCH 2020_04_invalid_service

D29199: honor the extractMetaData flag

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:99 > when you add the flag check here, you can avoid the extra indentation below. > Likewise in some other places. true, that was still written with D25517 and D25515

D29199: honor the extractMetaData flag

astippich updated this revision to Diff 81248. astippich marked 4 inline comments as done. astippich added a comment. - implement review REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29199?vs=81235=81248 BRANCH honorFlag REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 73 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/73/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 26 Apr 2020 14:34:05 + Build duration: 4 min 46 sec and counting JUnit Tests Name:

D29198: filenamesearch:/ define a title for the query

meven updated this revision to Diff 81246. meven added a comment. Cleanup after unwanted changes REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29198?vs=81244=81246 BRANCH arcpatch-D29198 REVISION DETAIL https://phabricator.kde.org/D29198 AFFECTED

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday April 26 2020 15:46:35 David Faure wrote: >Well, yeah, you can't have it all. I suppose that the appropriate ECM could provide a function that returns the path to the "official" Qt headers (or an expression that evaluates to that path) unless something like QT_HEADER_PATH is defined.

D29198: filenamesearch:/ define a title for the query

meven updated this revision to Diff 81244. meven added a comment. Information Panel: show early icons for folders REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29198?vs=81234=81244 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29198

D29191: [FileWatch] Fix watch updates on config changes

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c76397081d1e: [FileWatch] Fix watch updates on config changes (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29191?vs=81206=81243 REVISION

D29189: [KInotify] Fix path matching when removing watches

This revision was automatically updated to reflect the committed changes. Closed by commit R293:73183acf00a2: [KInotify] Fix path matching when removing watches (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29189?vs=81204=81242#toc REPOSITORY R293 Baloo CHANGES

D29201: KCMUtils: Add option to append service file to list of arguments

alex created this revision. alex added reviewers: Plasma, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY By setting the new variable to true the service path gets appended to the list of

Having $(framework)_global.h headers (was: Re: building KF5 projects against a different Qt5 version [...])

Am Sonntag, 26. April 2020, 15:46:35 CEST schrieb David Faure: > On Sunday, April 26, 2020 3:21:34 PM CEST René J.V. Bertin wrote: > > Talking about version test hacks (or not-so-hacks): why is it that > > KFOO_VERSION isn't defined systematically when you include any header of > > the FOO KF5

D24367: Some sanity verification

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24367 To: sandsmark, aacid, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28264: KIO: rename ProcessLauncherJob to ApplicationLauncherJob

dfaure added a task: T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28264 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28020: New class ProcessLauncherJob in KIOGui

dfaure added a task: T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28020 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: jbbgameich, kde-frameworks-devel,

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added a task: T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29153 To: dfaure, ahmadsamir, broulik, ngraham, mdlubakowski Cc: kde-frameworks-devel, LeGast00n, cblack,

D29171: Add 16px konversation icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:1d55fc5d7744: Add 16px konversation icon (authored by manueljlin). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29171?vs=81161=81238 REVISION DETAIL

D28745: Skip caching thumbnails on encrypted filesystems

meven added inline comments. INLINE COMMENTS > thumbnail.cpp:738 > +if (!m_thumbnailDirDeviceId) { > +struct stat baseStat; > +if (!lstat(QFile::encodeName(m_thumbBasePath).data(), > )) { Can't you move this out of the loop ? Since

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday, April 26, 2020 3:21:34 PM CEST René J.V. Bertin wrote: > On Sunday April 26 2020 14:12:01 David Faure wrote: > >> (and possibly LD_PRELOAD). > > > >I don't see why you would set LD_PRELOAD in this configuration. > > This may be necessary if even one of the multiple libraries that get

D29199: honor the extractMetaData flag

bruns added inline comments. INLINE COMMENTS > office2007extractor.cpp:79 > + > +if (docPropsEntries.contains(QStringLiteral("core.xml")) && > result->inputFlags() & ExtractionResult::ExtractMetaData) { > QDomDocument coreDoc(QStringLiteral("core")); Long line bool

D29199: honor the extractMetaData flag

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D29175: DBus Runner: Add service property to request actions once

alex added a comment. No, they are independent. I just mentioned this to avoid confusion when debugging. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29175: DBus Runner: Add service property to request actions once

meven added a comment. Is it a dependency or alternative to D29050 ? REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Sunday April 26 2020 14:12:01 David Faure wrote: >> (and possibly LD_PRELOAD). > >I don't see why you would set LD_PRELOAD in this configuration. This may be necessary if even one of the multiple libraries that get loaded has an old-style link to a Qt library which makes it ignore

D29189: [KInotify] Fix path matching when removing watches

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fwtest REVISION DETAIL https://phabricator.kde.org/D29189 To: bruns, #baloo, ngraham, meven Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D29200: test the extractNothing flag

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test that nothing is extracted when the corresponding

D29199: honor the extractMetaData flag

astippich added a dependent revision: D29200: test the extractNothing flag. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D29199 To: astippich, #baloo, bruns, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D29199: honor the extractMetaData flag

astippich created this revision. astippich added reviewers: Baloo, bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Metadata was extracted unconditionally before. Only do so

D29198: filenamesearch:/ define a title for the query

meven created this revision. meven added reviewers: ngraham, elvisangelaccio, Dolphin, Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 420354 REPOSITORY R318 Dolphin BRANCH master REVISION

D29198: filenamesearch:/ define a title for the query

meven added a comment. Relates (but does not depend) with D29197 REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D29198 To: meven, ngraham, elvisangelaccio, #dolphin, #frameworks Cc: kfm-devel, azyx, nikolaik, pberestov, iasensio,

D29197: filenamesearch: Implement stat to display metainfo

meven edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29197 To: meven, #dolphin, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas,

D29197: filenamesearch: Implement stat to display metainfo

meven updated this revision to Diff 81232. meven added a comment. Oops REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29197?vs=81231=81232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29197 AFFECTED FILES

D29197: filenamesearch: Implement stat to display metainfo

meven created this revision. meven added reviewers: Dolphin, Frameworks, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY filenamesearch ioslave needed a stat implementation

D28221: Don't write default value to configuration file when default value came from /etc/* file

dfaure added a comment. Ah! Now it actually makes sense to me. If we are changing what revertToDefault() does, then it makes sense to change the if() condition for calling it. Basically, now that it does the right thing in both cases (default from C++ and default from system file) it can be

D29189: [KInotify] Fix path matching when removing watches

bruns edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29189 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D28874: Taiwanese holidays

nhiga added a comment. Thank you for your attempt to add Taiwanese holidays to KDE. However, I am afraid that this patch has to be reviewed again. The dates for some holidays (including, but not limited to, Spring Festival (also known as "Lunar New Year") and the Mid-Autumn Festival)

D29189: [KInotify] Fix path matching when removing watches

bruns added a dependent revision: D29191: [FileWatch] Fix watch updates on config changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29189 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D29191: [FileWatch] Fix watch updates on config changes

bruns edited the summary of this revision. bruns added a dependency: D29189: [KInotify] Fix path matching when removing watches. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D29191 To: bruns, #baloo, ngraham, meven Cc: meven, kde-frameworks-devel,

D29190: [FileWatchTest] Extend coverage to config updates

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1a3c23f076d2: [FileWatchTest] Extend coverage to config updates (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29190?vs=81207=81229#toc REPOSITORY R293 Baloo CHANGES

D29190: [FileWatchTest] Extend coverage to config updates

bruns marked an inline comment as done. REPOSITORY R293 Baloo BRANCH fwtest REVISION DETAIL https://phabricator.kde.org/D29190 To: bruns, #baloo, ngraham, meven Cc: meven, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81228. dfaure added a comment. add missing braces REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29170?vs=81213=81228 BRANCH 2020_04_findExecutable REVISION DETAIL https://phabricator.kde.org/D29170 AFFECTED FILES

D29190: [FileWatchTest] Extend coverage to config updates

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > meven wrote in filewatchtest.cpp:223 > Maybe less, to keep the test reasonably fast. Does not really matter as soon as the code is fixed (review pending). Default would be 5000. REPOSITORY R293 Baloo

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure added a comment. Meanwhile I sent an email to kde-frameworks-devel to get more input on the question. Supporting custom setups is a great feature for a powerful desktop environment. E.g. I deploy custom self-built apps for my users, so I use some of those custom KDE features. Not

D29170: Detect executables without +x permission in $PATH to improve error message

ahmadsamir added a comment. In D29170#657334 , @dfaure wrote: > Resolve relative executables using the directory of the .desktop file referring to them > > Not useful for /usr/share/applications stuff, but useful for custom setups > where

Re: changing icon sizes no longer emits signal

On Saturday, April 25, 2020 4:54:43 PM CEST Friedrich W. H. Kossebau wrote: > Am Samstag, 25. April 2020, 15:10:37 CEST schrieb Martin Koller: > > Hi, > > > > in liquidshell I'm using > > > > connect(KIconLoader::global(), ::iconLoaderSettingsChanged, > > > > this, ::adjustIconSize); > > > >

Re: building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

On Saturday, April 25, 2020 2:23:34 PM CEST René J.V. Bertin wrote: > Hi, > > A priori Qt guarantees that you can run binaries against a different, newer > Qt version than they were built against, as long as no private APIs are > used. This also works if that newer Qt version is installed

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a reviewer: Frameworks. cullmann added a comment. I tried the current version. For me this looks OK now. Thought I would like to have more people trying this out before we merge. Some volunteers? Beside this: Thanks for working on this issue. REPOSITORY R39

D29191: [FileWatch] Fix watch updates on config changes

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Good to me REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D29191 To: bruns, #baloo, ngraham, meven Cc: meven, kde-frameworks-devel, hurikhan77,

D29190: [FileWatchTest] Extend coverage to config updates

meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > filewatchtest.cpp:223 > +QEXPECT_FAIL("", "Removal of excluded folders not deteced", Continue); > +QVERIFY(spyIndexNew.wait(500)); > +for (const QList& event

D29190: [FileWatchTest] Extend coverage to config updates

meven added inline comments. INLINE COMMENTS > filewatchtest.cpp:165 > + > +Test::writeIndexerConfig({d1, d2}, {d11, d21}); > +FileIndexerConfig config; Could you add a comment "d11, d21 are marked as excluded" REPOSITORY R293 Baloo REVISION DETAIL

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure closed this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28765 To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela Cc: svuorela, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

RFC: relative executables in desktop files

During the review of https://phabricator.kde.org/D29170 the following question surfaced again: should it be possible for a desktop file to refer to an executable that is in the "current directory", for some definition of that term. At least, outside of $PATH. In my opinion, in a GUI program

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. What do you think of this one? It's slightly less bright than before, but not as much as the first proposal. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham,

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns