Re: [PATCH v4 3/4] irqchip: GIC: Convert to EOImode == 1

2015-09-11 Thread Julien Grall
On 11/09/2015 11:54, Ian Campbell wrote: On Thu, 2015-09-10 at 17:23 +0100, Julien Grall wrote: I applied the two patches on top of linus/master and I'm able to boot correctly on X-gene. Thank you! Perhaps we should replicate this approach in Xen and get rid

Re: [PATCH v4 3/4] irqchip: GIC: Convert to EOImode == 1

2015-09-11 Thread Julien Grall
On 11/09/15 12:09, Marc Zyngier wrote: > On 11/09/15 11:59, Julien Grall wrote: >> >> >> On 11/09/2015 11:54, Ian Campbell wrote: >>> On Thu, 2015-09-10 at 17:23 +0100, Julien Grall wrote: >>>> I applied the two patches on top of linus/master and I'm ab

Re: [PATCH V1 0/7] Enable ACPI support for ARM KVM GIC

2016-02-08 Thread Julien Grall
drivers to get the necessary information to initialize the different KVM components (vGIC + vtimer). I think this achieves the goal you have in mind. I will post the series in a few minutes. Regards, -- Julien Grall ___ kvmarm mailing list kvmarm

[PATCH 4/5] irqchip/gic-v3: Parse and export virtual GIC information

2016-02-08 Thread Julien Grall
Fill up the recently introduced gic_kvm_info with the virtual GIC information. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> driv

[PATCH 1/5] KVM: arm/arm64: arch_timer: Gather KVM specific information in a structure

2016-02-08 Thread Julien Grall
, a stub for the new helper hasn't been introduced because KVM is requiring the arch timer for both ARM64 and ARM32. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Christoffer D

[PATCH 0/5] arm64: Add support of KVM with ACPI

2016-02-08 Thread Julien Grall
tables are duplicated which I think make more complex to support new firmware tables. Regards, [1] https://lists.cs.columbia.edu/pipermail/kvmarm/2016-February/018482.html [2] https://lists.cs.columbia.edu/pipermail/kvmarm/2016-February/018355.html Julien Grall (5): KVM: arm/arm64: arch_timer

Re: [PATCH 3/5] irqchip/gic-v2: Parse and export virtual GIC information

2016-02-10 Thread Julien Grall
, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 3/5] irqchip/gic-v2: Parse and export virtual GIC information

2016-02-10 Thread Julien Grall
Hi Marc, On 10/02/16 14:46, Marc Zyngier wrote: On 10/02/16 14:19, Julien Grall wrote: On 09/02/16 20:49, Christoffer Dall wrote: +static void __init gic_acpi_setup_kvm_info(void) +{ + gic_v2_kvm_info.type = GIC_V2; + + gic_v2_kvm_info.maint_irq = acpi_register_gsi(NULL

[PATCH v2 3/6] irqchip/gic-v2: Gather ACPI specific data in a single structure

2016-02-11 Thread Julien Grall
For now, there is only one member. More member will be added later. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v

[PATCH v2 2/6] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables

2016-02-11 Thread Julien Grall
timer code. With this changes, the support for ACPI is coming free. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc:

[PATCH v2 5/6] irqchip/gic-v3: Parse and export virtual GIC information

2016-02-11 Thread Julien Grall
Fill up the recently introduced gic_kvm_info with the virtual GIC information. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> Change

[PATCH v2 0/6] arm64: Add support of KVM with ACPI

2016-02-11 Thread Julien Grall
Julien Grall (6): KVM: arm/arm64: arch_timer: Gather KVM specific information in a structure KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables irqchip/gic-v2: Gather ACPI specific data in a single structure irqchip/gic-v2: Parse and export virtual GIC

[PATCH v2 1/6] KVM: arm/arm64: arch_timer: Gather KVM specific information in a structure

2016-02-11 Thread Julien Grall
, a stub for the new helper hasn't been introduced because KVM is requiring the arch timer for both ARM64 and ARM32. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Christoffer D

[PATCH v2 6/6] KVM: arm/arm64: vgic: Rely on the GIC driver to parse the firmware tables

2016-02-11 Thread Julien Grall
information about the virtual GIC. With this change, the virtual GIC becomes agnostic to the firmware table and KVM will be able to initialize the vGIC on ACPI. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Marc Zyngie

Re: [PATCH v2 1/6] KVM: arm/arm64: arch_timer: Gather KVM specific information in a structure

2016-02-19 Thread Julien Grall
On 19/02/16 10:53, Julien Grall wrote: -- Julien Grall IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person

Re: [PATCH v3 4/9] irqchip/gic-v2: Parse and export virtual GIC information

2016-03-14 Thread Julien Grall
Hi Christoffer, On 09/03/16 05:14, Christoffer Dall wrote: On Tue, Mar 08, 2016 at 11:29:28AM +, Julien Grall wrote: For now, the firmware tables are parsed 2 times: once in the GIC drivers, the other timer when initializing the vGIC. It means code duplication and make more tedious to add

Re: [PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure

2016-03-15 Thread Julien Grall
Hi Christoffer, On 09/03/16 05:39, Christoffer Dall wrote: On Tue, Mar 08, 2016 at 11:29:29AM +, Julien Grall wrote: Even though all the variables aren't marked with __initdata, they are only used during initialization. So the structure is marked with __initdata. Not sure I understand

Re: [PATCH v3 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure

2016-03-08 Thread Julien Grall
Hi Christoffer, On 09/03/2016 10:23, Christoffer Dall wrote: On Tue, Mar 08, 2016 at 11:29:25AM +, Julien Grall wrote: -static struct timecounter timecounter; +static struct arch_timer_kvm_info arch_timer_kvm_info; + +struct arch_timer_kvm_info *arch_timer_get_kvm_info(void) borderline

Re: [PATCH v3 2/9] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ

2016-03-08 Thread Julien Grall
Hi Christoffer, On 09/03/2016 10:27, Christoffer Dall wrote: On Tue, Mar 08, 2016 at 11:29:26AM +, Julien Grall wrote: diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c index b7ab588..d8887f3 100644 --- a/drivers/clocksource/arm_arch_timer.c +++ b

Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure

2016-03-08 Thread Julien Grall
Hi Christoffer, On 09/03/2016 12:47, Christoffer Dall wrote: On Tue, Mar 08, 2016 at 11:29:27AM +, Julien Grall wrote: For now, there is only one member. More member will be added later. questionable commit message What about: "The ACPI code requires to use global variables in

Re: [PATCH v4 9/9] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter

2016-03-29 Thread Julien Grall
On 29/03/16 15:39, Daniel Lezcano wrote: On 03/24/2016 06:53 PM, Julien Grall wrote: The only call of arch_timer_get_timecounter (in KVM) has been removed. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> Hi Julien, Hi

Re: [PATCH v5 0/9] arm64: Add support for KVM with ACPI

2016-04-06 Thread Julien Grall
Hi Christoffer, On 06/04/2016 18:28, Christoffer Dall wrote: On Mon, Apr 04, 2016 at 12:37:31PM +0100, Julien Grall wrote: Hello, This patch series allows KVM to work with ACPI on ARM64. Currently, the firmware tables are parsed by the the virtual timer and virtual GIC code in order

Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information

2016-04-06 Thread Julien Grall
Hi Christoffer, On 06/04/2016 18:04, Christoffer Dall wrote: On Mon, Apr 04, 2016 at 12:37:35PM +0100, Julien Grall wrote: diff --git a/include/linux/irqchip/arm-gic-common.h b/include/linux/irqchip/arm-gic-common.h new file mode 100644 index 000..ef34f6f --- /dev/null +++ b/include/linux

Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-04-06 Thread Julien Grall
Hi Christoffer, On 06/04/2016 18:22, Christoffer Dall wrote: On Mon, Apr 04, 2016 at 12:37:37PM +0100, Julien Grall wrote: +static void __init gic_acpi_setup_kvm_info(void) +{ + int irq; + + if (!gic_acpi_collect_virt_info()) { + pr_warn("Unable to get har

Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-04-11 Thread Julien Grall
Hello Hanjun, On 11/04/16 06:27, Hanjun Guo wrote: On 2016/4/4 19:37, Julien Grall wrote: +static void __init gic_acpi_setup_kvm_info(void) +{ +int irq; + +if (!gic_acpi_collect_virt_info()) { +pr_warn("Unable to get hardware information used for virtualizat

Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-04-11 Thread Julien Grall
On 09/04/16 03:29, Shanker Donthineni wrote: Hi Julien, Hello Shanker, On 04/04/2016 06:37 AM, Julien Grall wrote: +static int __init gic_acpi_parse_virt_madt_gicc(struct acpi_subtable_header *header, + const unsigned long end) +{ + struct

Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information

2016-04-11 Thread Julien Grall
On 11/04/16 04:17, Hanjun Guo wrote: Hi Julian, Hi Hanjun, On 2016/4/4 19:37, Julien Grall wrote: @@ -1302,6 +1339,41 @@ static bool __init gic_validate_dist(struct acpi_subtable_header *header, #define ACPI_GICV2_DIST_MEM_SIZE(SZ_4K) #define ACPI_GIC_CPU_IF_MEM_SIZE(SZ_8K

[PATCH v6 08/10] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables

2016-04-11 Thread Julien Grall
by the virtual timer code. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Marc Zyngier <marc.zyng...@arm.com> Cc: Gleb Natapov <g...@kernel.org> Cc: Paol

[PATCH v6 06/10] irqchip/gic-v3: Gather all ACPI specific data in a single structure

2016-04-11 Thread Julien Grall
the initialization. Therefore, the new variable, which hold the structure, can be marked with __initdata. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> Reviewed-by: Hanjun Guo <hanjun@linaro.org> --- Cc:

[PATCH v6 02/10] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ

2016-04-11 Thread Julien Grall
in a subsequent patch. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Marc Zyngier <marc.zyng...@arm.com>

[PATCH v6 03/10] irqchip/gic-v2: Gather ACPI specific data in a single structure

2016-04-11 Thread Julien Grall
The ACPI code requires to use global variables in order to collect information from the tables. For now, a single global variable is used, but more will be added in a subsequent patch. To make clear they are ACPI specific, gather all the information in a single structure. Signed-off-by: Julien

[PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: "

2016-04-11 Thread Julien Grall
Currently, most of the pr_* messages in the GICv3 driver don't have a prefix. Add one to make clear where the messages come from. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Changes in v6: - Patch added --- drivers/irqchip/irq-gic-v3.c | 2 ++ 1 file chan

[PATCH v6 04/10] irqchip/gic-v2: Parse and export virtual GIC information

2016-04-11 Thread Julien Grall
information. Also fill up the structure for GICv2. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v6: - Move the cod

[PATCH v6 09/10] KVM: arm/arm64: vgic: Rely on the GIC driver to parse the firmware tables

2016-04-11 Thread Julien Grall
information about the virtual GIC. With this change, the virtual GIC becomes agnostic to the firmware table and KVM will be able to initialize the vGIC on ACPI. Signed-off-by: Julien Grall <julien.gr...@arm.com> Reviewed-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Marc Zyngie

[PATCH v6 07/10] irqchip/gic-v3: Parse and export virtual GIC information

2016-04-11 Thread Julien Grall
Fill up the recently introduced gic_kvm_info with the hardware information used for virtualization. Signed-off-by: Julien Grall <julien.gr...@arm.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com>

[PATCH v6 00/10] arm64: Add support for KVM with ACPI

2016-04-11 Thread Julien Grall
are merged via the clocksource tree Patches #2-#7 are merged via the irqchip tree 2) Patches #8-#9 are merge via the KVM tree 3) Patch #10 is merged via the clocksource tree. For all the changes see in each patch. Regards, Julien Grall (10): clocksource: arm_arch_timer: Gather KVM specific

[PATCH v6 01/10] clocksource: arm_arch_timer: Gather KVM specific information in a structure

2016-04-11 Thread Julien Grall
and ARM32. The function arch_timer_get_timecounter is kept for the time being and will be dropped in a subsequent patch. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> C

[PATCH v6 10/10] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter

2016-04-11 Thread Julien Grall
The only call of arch_timer_get_timecounter (in KVM) has been removed. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.d

Re: [PATCH v3 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-03-22 Thread Julien Grall
Hi Graeme, On 22/03/16 11:27, Graeme Gregory wrote: On Tue, Mar 08, 2016 at 11:29:30AM +, Julien Grall wrote: @@ -1020,6 +1060,13 @@ gic_acpi_parse_madt_gicc(struct acpi_subtable_header *header, return -ENOMEM; gic_acpi_register_redist(gicc->gicr_base_addr

[PATCH v4 0/9] arm64: Add support for KVM with ACPI

2016-03-24 Thread Julien Grall
introduces new helpers to retrieve the information from the different drivers in order to avoid duplication of the parsing code. To make the merge easier via the different trees, each patch modifies a single subsystem. For all the changes see the different patches. Yours sincerely, Julien Grall (9

[PATCH v4 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure

2016-03-24 Thread Julien Grall
and ARM32. The function arch_timer_get_timecounter is kept for the time being and will be dropped in a subsequent patch. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Marc

[PATCH v4 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-03-24 Thread Julien Grall
Fill up the recently introduced gic_kvm_info with the hardware information used for virtualization. Signed-off-by: Julien Grall <julien.gr...@arm.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com>

[PATCH v4 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure

2016-03-24 Thread Julien Grall
the initialization. Therefore, the new variable, which hold the structure, can be marked with __initdata. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.co

[PATCH v4 4/9] irqchip/gic-v2: Parse and export virtual GIC information

2016-03-24 Thread Julien Grall
information. Also fill up the structure for GICv2. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v4: - Change the flow

[PATCH v4 9/9] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter

2016-03-24 Thread Julien Grall
The only call of arch_timer_get_timecounter (in KVM) has been removed. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.d

[PATCH v4 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables

2016-03-24 Thread Julien Grall
by the virtual timer code. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Marc Zyngier <marc.zyng...@arm.com> Cc: Gleb Natapov <g...@kernel.org> Cc: Paol

[PATCH v3 4/9] irqchip/gic-v2: Parse and export virtual GIC information

2016-03-08 Thread Julien Grall
information. Also fill up the structure for GICv2. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v2: - Use 0 rath

[PATCH v3 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-03-08 Thread Julien Grall
Fill up the recently introduced gic_kvm_info with the virtual GIC information. Signed-off-by: Julien Grall <julien.gr...@arm.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> --- Changes i

[PATCH v3 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables

2016-03-08 Thread Julien Grall
by the virtual timer code. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Marc Zyngier <marc.zyng...@arm.com> Cc: Gleb Natapov <g...@kernel.org> Cc: Paolo Bonzini <pbonz...@redhat.com> Changes in v3:

[PATCH v3 8/9] KVM: arm/arm64: vgic: Rely on the GIC driver to parse the firmware tables

2016-03-08 Thread Julien Grall
information about the virtual GIC. With this change, the virtual GIC becomes agnostic to the firmware table and KVM will be able to initialize the vGIC on ACPI. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Marc Zyngier <marc.

[PATCH v3 0/9] arm64: Add support of KVM with ACPI

2016-03-08 Thread Julien Grall
, Julien Grall (9): clocksource: arm_arch_timer: Gather KVM specific information in a structure clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ irqchip/gic-v2: Gather ACPI specific data in a single structure irqchip/gic-v2: Parse and export virtual GIC

[PATCH v3 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure

2016-03-08 Thread Julien Grall
Even though all the variables aren't marked with __initdata, they are only used during initialization. So the structure is marked with __initdata. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemo

[PATCH v3 2/9] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ

2016-03-08 Thread Julien Grall
in a subsequent patch. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v3: - Move the KVM changes in a separate pa

[PATCH v3 9/9] clocksource: arm_arch_timer: Remove arch_timer_get_timecounter

2016-03-08 Thread Julien Grall
The only call of arch_timer_get_timecounter (in KVM) has been removed. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Changes in v3: - Patch added --- d

Re: [PATCH v2 2/6] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables

2016-03-04 Thread Julien Grall
Hi Christoffer, On 03/03/16 19:38, Christoffer Dall wrote: On Thu, Feb 11, 2016 at 03:33:20PM +, Julien Grall wrote: [...] diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c index 6eb2c5d..3cdbefd 100644 --- a/drivers/clocksource/arm_arch_timer.c

Re: [RFC v5 03/17] iommu: introduce a reserved iova cookie

2016-03-03 Thread Julien Grall
, domain->ops = bus->iommu_ops; domain->type = type; + mutex_init(>reserved_mutex); For consistency, the RB-tree reserved_binding_list should be initialized too: domain->reserved_binding_list = RB_ROOT; Cheers, -- Julien Grall ___

[PATCH v5 7/9] KVM: arm/arm64: arch_timer: Rely on the arch timer to parse the firmware tables

2016-04-04 Thread Julien Grall
by the virtual timer code. Signed-off-by: Julien Grall <julien.gr...@arm.com> Acked-by: Christoffer Dall <christoffer.d...@linaro.org> --- Cc: Christoffer Dall <christoffer.d...@linaro.org> Cc: Marc Zyngier <marc.zyng...@arm.com> Cc: Gleb Natapov <g...@kernel.org> Cc: Paol

[PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information

2016-04-04 Thread Julien Grall
information. Also fill up the structure for GICv2. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v4: - Change the flow

[PATCH v5 5/9] irqchip/gic-v3: Gather all ACPI specific data in a single structure

2016-04-04 Thread Julien Grall
the initialization. Therefore, the new variable, which hold the structure, can be marked with __initdata. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.co

[PATCH v5 0/9] arm64: Add support for KVM with ACPI

2016-04-04 Thread Julien Grall
are merged via the clocksource tree Patches #2-#6 are merged via the irqchip tree 2) Patches #7-#8 are merge via the KVM tree 3) Patch #9 is merged via the clocksource tree. For all the changes see in each patch. Regards, Cc: daniel.lezc...@linaro.org Julien Grall (9): clocksource

[PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-04-04 Thread Julien Grall
Fill up the recently introduced gic_kvm_info with the hardware information used for virtualization. Signed-off-by: Julien Grall <julien.gr...@arm.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Jason Cooper <ja...@lakedaemon.net> Cc: Marc Zyngier <marc.zyng...@arm.com>

[PATCH v5 1/9] clocksource: arm_arch_timer: Gather KVM specific information in a structure

2016-04-04 Thread Julien Grall
and ARM32. The function arch_timer_get_timecounter is kept for the time being and will be dropped in a subsequent patch. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Marc

[PATCH v5 2/9] clocksource: arm_arch_timer: Extend arch_timer_kvm_info to get the virtual IRQ

2016-04-04 Thread Julien Grall
in a subsequent patch. Signed-off-by: Julien Grall <julien.gr...@arm.com> --- Cc: Daniel Lezcano <daniel.lezc...@linaro.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: Marc Zyngier <marc.zyng...@arm.com> Changes in v4: - Move the initializ

[PATCH v5 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure

2016-04-04 Thread Julien Grall
The ACPI code requires to use global variables in order to collect information from the tables. For now, a single global variable is used, but more will be added in a subsequent patch. To make clear they are ACPI specific, gather all the information in a single structure. Signed-off-by: Julien

Re: [PATCH v4 6/9] irqchip/gic-v3: Parse and export virtual GIC information

2016-04-04 Thread Julien Grall
Hi Christoffer, On 01/04/2016 11:13, Christoffer Dall wrote: On Thu, Mar 24, 2016 at 05:53:40PM +, Julien Grall wrote: diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 50e87e6..b5ed8be 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3

Re: [PATCH v6 05/10] irqchip/gic-v3: Prefix all pr_* messages by "GICv3: "

2016-04-26 Thread Julien Grall
Hi Hanjun, Sorry for the late answer. On 13/04/16 11:01, Hanjun Guo wrote: On 2016/4/11 23:32, Julien Grall wrote: Currently, most of the pr_* messages in the GICv3 driver don't have a prefix. Add one to make clear where the messages come from. Signed-off-by: Julien Grall <julien

Re: [PULL 00/29] KVM/ARM Changes for v4.7

2016-05-17 Thread Julien Grall
Hello, On 17/05/2016 00:28, Itaru Kitayama wrote: The new v4.6 upstream kernel gets to the prompt on Mustang (Rev A3). I would recommend you to bissect Linux and finger one or multiple commits which break booting on your board. Regards, -- Julien Grall

Re: [PATCH v4 49/56] KVM: arm/arm64: vgic-new: vgic_init: implement kvm_vgic_hyp_init

2016-05-17 Thread Julien Grall
ns an error code otherwise + */ +int vgic_v3_probe(const struct gic_kvm_info *info) Regards, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PULL 00/29] KVM/ARM Changes for v4.7

2016-05-15 Thread Julien Grall
ld recommend you to try Linux-next. Regards, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v2 05/17] arm64: Helper for parange to PASize

2018-04-27 Thread Julien Grall
On 27/04/18 16:18, Suzuki K Poulose wrote: On 26/04/18 11:58, Julien Grall wrote: Hi Suzuki, On 27/03/18 14:15, Suzuki K Poulose wrote: Add a helper to convert ID_AA64MMFR0_EL1:PARange to they physical size shift. Limit the size to the maximum supported by the kernel. We are about to move

Re: [PATCH v2 08/17] kvm: arm/arm64: Prepare for VM specific stage2 translations

2018-04-27 Thread Julien Grall
Hi Suzuki, On 27/04/18 16:58, Suzuki K Poulose wrote: On 27/04/18 16:22, Suzuki K Poulose wrote: On 26/04/18 14:35, Julien Grall wrote: Hi Suzuki, On 27/03/18 14:15, Suzuki K Poulose wrote: Right now the stage2 page table for a VM is hard coded, assuming an IPA of 40bits. As we are about

Re: [PATCH 04/14] arm64: Add ARCH_WORKAROUND_2 probing

2018-05-23 Thread Julien Grall
29 +#define ARM64_SSBD 30 NIT: Could you indent 30 the same way as the other number? Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https

Re: [PATCH 02/14] arm64: Call ARCH_WORKAROUND_2 on transitions between EL0 and EL1

2018-05-23 Thread Julien Grall
NIT: Shouldn't you use /* ... */ for multi-line comments? Regardless that: Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 03/14] arm64: Add per-cpu infrastructure to call ARCH_WORKAROUND_2

2018-05-23 Thread Julien Grall
Hi Marc, On 05/22/2018 04:06 PM, Marc Zyngier wrote: In a heterogeneous system, we can end up with both affected and unaffected CPUs. Let's check their status before calling into the firmware. Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Reviewed-by: Julien Grall <julien.gr..

Re: [PATCH 05/14] arm64: Add 'ssbd' command-line option

2018-05-23 Thread Julien Grall
permanently on or off instead of switching it on exception entry/exit. In any case, default to the mitigation being enabled. Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- Documentation/admin-guide/kernel-paramete

Re: [PATCH 07/14] arm64: ssbd: Skip apply_ssbd if not using dynamic mitigation

2018-05-23 Thread Julien Grall
mitigation. Think of it as a poor man's static key... Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- arch/arm64/kernel/cpu_errata.c | 14 ++ arch/arm64/kernel/entry.S | 3 +++ 2 files

Re: [PATCH 08/14] arm64: ssbd: Disable mitigation on CPU resume if required by user

2018-05-23 Thread Julien Grall
ine option, let's enforce it by calling into the firmware again to disable it. Signed-off-by: Marc Zyngier <marc.zyng...@arm.com> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- arch/arm64/include/asm/cpufeature.h | 6 ++ arch/arm64/kernel/cpu_errata.c | 8

Re: [PATCH 06/14] arm64: ssbd: Add global mitigation state accessor

2018-05-23 Thread Julien Grall
<marc.zyng...@arm.com> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- arch/arm64/include/asm/cpufeature.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h index 9bc548e22784..

Re: [kvmtool PATCH 21/17] kvmtool: arm: Add support for creating VM with PA size

2018-04-30 Thread Julien Grall
) +{ + unsigned max_ipa; + + max_ipa = ioctl(kvm->sys_fd, KVM_ARM_GET_MAX_VM_PHYS_SHIFT); + if (max_ipa < 0) Another issues spotted while doing some testing. This will always be false because max_ipa is unsigned. I think we want to turn max_ipa to signed. Cheers, -- Julien

Re: [PATCH v2 03/17] arm64: Make page table helpers reusable

2018-04-26 Thread Julien Grall
ve.cap...@arm.com> Cc: Marc Zyngier <marc.zyng...@arm.com> Cc: Christoffer Dall <cd...@kernel.org> Signed-off-by: Suzuki K Poulose <suzuki.poul...@arm.com> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- arch/arm64/include/asm/pgalloc.h | 34 ++

Re: [PATCH v2 04/17] arm64: Refactor pud_huge for reusability

2018-04-26 Thread Julien Grall
talin.mari...@arm.com> Cc: Christoffer Dall <cd...@kernel.org> Signed-off-by: Suzuki K Poulose <suzuki.poul...@arm.com> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- arch/arm64/include/asm/pgtable.h | 5 + arch/arm64/mm/hugetlbpage.c | 2 +- 2

Re: [PATCH v2 05/17] arm64: Helper for parange to PASize

2018-04-26 Thread Julien Grall
arange); + val |= 64 - (phys_shift > 40 ? 40 : phys_shift); /* * Check the availability of Hardware Access Flag / Dirty Bit @@ -86,5 +68,5 @@ u32 __hyp_text __init_stage2_translation(void) write_sysreg(val, vtcr_el2); - return parange; +

Re: [PATCH v3 01/41] KVM: arm/arm64: Avoid vcpu_load for other vcpu ioctls than KVM_RUN

2018-02-05 Thread Julien Grall
actually going to run the vcpu. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia

Re: [PATCH v3 02/41] KVM: arm/arm64: Move vcpu_load call after kvm_vcpu_first_run_init

2018-02-05 Thread Julien Grall
. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, --- virt/kvm/arm/arch_timer.c | 7 --- virt/kvm/arm/arm.c| 22 -- virt/kvm/arm/vgic/vgic-init.c | 11 --- 3 file

Re: [PATCH v3 03/41] KVM: arm64: Avoid storing the vcpu pointer on the stack

2018-02-05 Thread Julien Grall
is also touching this code (see https://patchwork.kernel.org/patch/10190297/). Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3 04/41] KVM: arm64: Rework hyp_panic for VHE and non-VHE

2018-02-05 Thread Julien Grall
(spsr, elr, par, host_ctxt); + else + __hyp_call_panic_vhe(spsr, elr, par, host_ctxt); unreachable(); } Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3 04/41] KVM: arm64: Rework hyp_panic for VHE and non-VHE

2018-02-05 Thread Julien Grall
On 05/02/18 18:04, Julien Grall wrote: On 12/01/18 12:07, Christoffer Dall wrote: @@ -436,37 +446,31 @@ static void __hyp_text __hyp_call_panic_nvhe(u64 spsr, u64 elr, u64 par, read_sysreg(hpfar_el2), par, vcpu);   } -static void __hyp_text __hyp_call_panic_vhe(u64 spsr, u64

Re: [PATCH v3 04/41] KVM: arm64: Rework hyp_panic for VHE and non-VHE

2018-02-09 Thread Julien Grall
Hi Christoffer, On 02/08/2018 01:24 PM, Christoffer Dall wrote: On Mon, Feb 05, 2018 at 06:04:25PM +, Julien Grall wrote: On 12/01/18 12:07, Christoffer Dall wrote: + panic(__hyp_panic_string, spsr, elr, read_sysreg_el2(esr), read_sysreg_el2(far

Re: [PATCH v3 09/41] KVM: arm64: Defer restoring host VFP state to vcpu_put

2018-02-09 Thread Julien Grall
nvhe, __fpsimd_enabled_vhe, - ARM64_HAS_VIRT_HOST_EXTN); - -bool __hyp_text __fpsimd_enabled(void) Now that __fpsimd_enabled is removed, I think you need to remove the prototype in arch/arm64/include/kvm_hyp.h too. -{ - return __fpsimd_is_enabled()(); -}

Re: [PATCH v3 17/41] KVM: arm64: Remove noop calls to timer save/restore from VHE switch

2018-02-09 Thread Julien Grall
* Disallow physical timer access for the guest +* Physical counter access is allowed +*/ + val = read_sysreg(cnthctl_el2); + val &= ~CNTHCTL_EL1PCEN; + val |= CNTHCTL_EL1PCTEN; + write_sysreg(val, cnthctl_el2); } C

Re: [PATCH v3 18/41] KVM: arm64: Move userspace system registers into separate function

2018-02-09 Thread Julien Grall
ysreg(actlr_el1); I am a bit confused, the comment on top of the function says the host must save ACTLR_EL1 in the VHE case. But AFAICT, after this patch the register will not get saved in the host context. Did I miss anything? Cheers, -- Julien Grall ___

Re: [PATCH v3 14/41] KVM: arm64: Introduce VHE-specific kvm_vcpu_run

2018-02-09 Thread Julien Grall
ret = kvm_vcpu_run_vhe(vcpu); + else + ret = kvm_call_hyp(__kvm_vcpu_run_nvhe, vcpu); vcpu->mode = OUTSIDE_GUEST_MODE; vcpu->stat.exits++; Cheers, -- Julien Grall ___

Re: [PATCH v3 08/41] KVM: arm/arm64: Introduce vcpu_el1_is_32bit

2018-02-09 Thread Julien Grall
r.d...@linaro.org> Reviewed-by: Julien Grall <julien.gr...@arm.com> Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v3 05/41] KVM: arm64: Move HCR_INT_OVERRIDE to default HCR_EL2 guest flag

2018-02-09 Thread Julien Grall
,6 @@ static void __hyp_text __vgic_restore_state(struct kvm_vcpu *vcpu) u64 val; val = read_sysreg(hcr_el2); - val |= HCR_INT_OVERRIDE; val |= vcpu->arch.irq_lines; write_sysreg(val, hcr_el2); Cheers, -- Julien Grall

Re: [PATCH v4 03/40] KVM: arm64: Avoid storing the vcpu pointer on the stack

2018-02-19 Thread Julien Grall
to remove this paragraph as you don't seem to have rework that part of the code in this version. Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v4 28/40] KVM: arm64: Defer saving/restoring 64-bit sysregs to vcpu load/put on VHE

2018-02-22 Thread Julien Grall
, -- Julien Grall ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH v4 28/40] KVM: arm64: Defer saving/restoring 64-bit sysregs to vcpu load/put on VHE

2018-02-22 Thread Julien Grall
On 22/02/18 18:30, Julien Grall wrote: Hi Christoffer, On 15/02/18 21:03, Christoffer Dall wrote: Some system registers do not affect the host kernel's execution and can therefore be loaded when we are about to run a VCPU and we don't have to restore the host state to the hardware before

Re: [PATCH v4 17/40] KVM: arm64: Move userspace system registers into separate function

2018-02-19 Thread Julien Grall
it would be possible to have hardware where ACTLR_EL1 would still have an effect on host EL0. I also read the comments on the version 2 of this patch but I wasn't able to find what I missing. Cheers, -- Julien Grall ___ kvmarm mailing list kvmarm

Re: [PATCH v4 24/40] KVM: arm64: Rewrite system register accessors to read/write functions

2018-02-19 Thread Julien Grall
0) = + p->regval & ARMV8_PMU_USERENR_MASK; + } else { NIT: There is a double space between else and {. + p->regval = __vcpu_sys_reg(vcpu, PMUSERENR_EL0) & ARMV8_PMU_USERENR_MASK; } Cheers, -- Julien G

Re: [PATCH v3 17/41] KVM: arm64: Remove noop calls to timer save/restore from VHE switch

2018-02-19 Thread Julien Grall
Hi Christoffer, Sorry for the late reply. On 13/02/18 22:31, Christoffer Dall wrote: On Fri, Feb 09, 2018 at 05:53:43PM +, Julien Grall wrote: Hi Christoffer, On 01/12/2018 12:07 PM, Christoffer Dall wrote: The VHE switch function calls __timer_enable_traps and __timer_disable_traps

  1   2   3   >