Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 2:26:36 PM UTC-4 Edward K. Ream wrote: On Mon, Jun 26, 2023 at 12:50 PM Thomas Passin wrote: 2. Both the bookmark manager and the zettelkasten apps partially work but not completely. I will look at using these new "legacy" methods next. Let me know if I can

Status bar behavior, especially with PR 3215

2023-06-26 Thread Thomas Passin
In the status bar, a right-click brings up a two-item context menu: *Select All* and *Copy*. I have always found this a little confusing. *Copy* implies that it will copy the contents (usually the UNL), but actually you have to select it first before *Copy* will do anything. It's possible to

Re: Execute-script in leojs

2023-06-26 Thread Thomas Passin
Lovely! Felix, I have to applaud all this hard and creative work you've been doing! On Monday, June 26, 2023 at 10:26:09 PM UTC-4 Félix wrote: > People have asked about live scripting in leojs in the past (cant remember > who exactly, perhaps Thomas, but I'm not sure) > > That person inquired

Execute-script in leojs

2023-06-26 Thread Félix
People have asked about live scripting in leojs in the past (cant remember who exactly, perhaps Thomas, but I'm not sure) That person inquired about javascript live scripting execution in leojs possibility.. along with the global Leo variables that are expected to be in the global script

Re: Code Review, Requirements, and Community Particiation

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 5:15:45 PM UTC-4 mys...@gmail.com wrote: On Mon, Jun 26, 2023, 13:34 Thomas Passin wrote: In the announcement about the proposed PR 3215 that massively affects UNLs, @Edward wrote "I won't wait for a code review. The code involved is too tricky to understand in

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Monday, June 26, 2023 at 1:50:28 PM UTC-5 tbp1...@gmail.com wrote: > Furthermore, having the path visible in the status bar could be really useful. Let's not argue about preferences. I've just added this checklist item to the PR: Add a setting that determines whether the status area will

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 2:01 PM Thomas Passin wrote: Something close to seven plugins use unls, including mod-http and > quickMove. They should all be checked to see if they will still work. Good idea. I've added this item to the PRs list. Edward -- You received this message because you

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 1:50 PM Thomas Passin wrote: Yes, since the UNL contained the path to the outline, Leo could open a > non-open outline and navigate to the right node. I always thought that was > a wonderful, even almost miraculous, capability. We shouldn't lose it. > I've just added

Re: leojs alpha

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 2:38 PM jkn wrote: I agree with Thomas that maintaining two codebases in sync is probably and > impossible job in practice. I'm not worried. Leo on the desktop is complete as it is. I trust Félix to bring the Leonine world to vs-code. Edward -- You received this

Re: Code Review, Requirements, and Community Particiation

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 2:34 PM Thomas Passin wrote: If we had a proposed set of requirements for a change to fix a well-defined > problem, we probably wouldn't be in the fix we're in right now about this > PR. > We aren't in a fix. We just need to find the least disruptive way of transitioning

Re: Code Review, Requirements, and Community Particiation

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 2:34 PM Thomas Passin wrote: > In the announcement about the proposed PR 3215 that massively affects > UNLs, @Edward wrote > > "I won't wait for a code review. The code involved is too tricky to > understand in an hour or five." > I'll retract this statement. There have

Re: Code Review, Requirements, and Community Particiation

2023-06-26 Thread Mike Hodson
On Mon, Jun 26, 2023, 13:34 Thomas Passin wrote: > In the announcement about the proposed PR 3215 that massively affects > UNLs, @Edward wrote > > "I won't wait for a code review. The code involved is too tricky to > understand in an hour or five." > > This statement contains two red flags. > I

Re: leojs alpha

2023-06-26 Thread Félix
haha! don't worry - Leo is Leo and LeoJS is it's own thing :) But who knows what the future holds for Leo, LeoInteg and LeoJS? Thanks again for your input! People's ideas and suggestions on this forum are what fueled my motivation to code all of this! Félix On Monday, June 26, 2023 at

Re: Code Review, Requirements, and Community Particiation

2023-06-26 Thread jkn
I'm not going to go too far down this rabbit hole - I have a day job - but in general I would agree that 'too tricky to understand' code is a red flag. On Monday, June 26, 2023 at 8:34:47 PM UTC+1 tbp1...@gmail.com wrote: > In the announcement about the proposed PR 3215 that massively affects

Re: leojs alpha

2023-06-26 Thread jkn
Hi Félix Thanks for the extra information. That does sound like a lot of work, I (too) am impressed with your dedication. But I agree with Thomas that maintaining two codebases in sync is probably and impossible job in practice. I would kinda-hate Leo to end up as a javascript (/typescript)

Code Review, Requirements, and Community Particiation

2023-06-26 Thread Thomas Passin
In the announcement about the proposed PR 3215 that massively affects UNLs, @Edward wrote "I won't wait for a code review. The code involved is too tricky to understand in an hour or five." This statement contains two red flags. If it's too tricky for a code review, there's something out of

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Thomas Passin
Something close to seven plugins use unls, including mod-http and quickMove. They should all be checked to see if they will still work (I don't know which of them still work apart from unl changes). -- You received this message because you are subscribed to the Google Groups "leo-editor"

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 2:26:36 PM UTC-4 Edward K. Ream wrote: On Mon, Jun 26, 2023 at 12:50 PM Thomas Passin wrote: g.findGNX searches all *open* windows. The legacy version of g.handleUnl contained Leo-specific code which I deleted. Afterwards, the code called g.openWithFileName to

Re: leojs alpha

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 10:09:17 AM UTC-4 jkn wrote: If the former, I'm wondering how 'upstream' work on Leo gets incorporated. If the latter, I'm curious about the process... Keeping two code bases synchronized is nearly impossible in the long run. Each one evolves in its own way, and

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 12:57 PM Thomas Passin wrote: Oh ye of little faith. In the PR the call to g.app.selectLeoWindow appears > in both g.findUNL and g.findGNX. So these calls have already been done when > g.handleUnl returns. > > > That's not the point. This bit of code returns the focus to

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 12:56 PM Thomas Passin wrote: 1.I was probably thinking that g.findUNL (the legacy unl-finding function) might return a position in another outline. To my knowledge, that has never been true. > > Yes it has. Here's the docstring from the (unreplaced) g.findUNL: > >

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 12:50 PM Thomas Passin wrote: 1. CTRL-clicking on an old-style unl pointing into the same outline > navigates to the right node; for a unl pointing into a different outline it > does not navigate to the right place or even the right outline. > Thanks for testing. We'll

Re: leojs alpha

2023-06-26 Thread Félix
Hi jkn! :D Thanks for your interest and questions! I've translated/transliterated (not sure which is appropriate!) about 99% myself manually, and I've used chatGPT for small parts (e.g. some regular expressions, some small quirky methods) which I would estimate to be 1% of the code. (anyways

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 1:47:07 PM UTC-4 Edward K. Ream wrote: On Sun, Jun 25, 2023 at 10:22 AM Thomas Passin wrote: > Great! And if you want to do the same for a UNL in another outline, you can add these two lines (at least until that PR gets merged; I don't know about after that): #

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 1:29:24 PM UTC-4 Edward K. Ream wrote: On Sun, Jun 25, 2023 at 7:51 AM Thomas Passin wrote: "Remove support for cross-file UNLs" - WTF??? This will break some of my scripts. How are we going to navigate to other outlines by UNL? Wasn't that half of the point of

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Thomas Passin
After checking out the branch for this PR: 1. CTRL-clicking on an old-style unl pointing into the same outline navigates to the right node; for a unl pointing into a different outline it does not navigate to the right place or even the right outline. 2. Both the bookmark manager and the

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Edward K. Ream
On Sun, Jun 25, 2023 at 10:22 AM Thomas Passin wrote: > Great! And if you want to do the same for a UNL in another outline, you can add these two lines (at least until that PR gets merged; I don't know about after that): # Add this after the "content =" line. if c2 is not c0:

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 12:32 PM Edward K. Ream wrote: > Oops! In the PR g.handleUNL returns None. I'll restore the legacy operation immediately. Done. g.handleUNL returns a commander or None, exactly as in devel. Edward -- You received this message because you are subscribed to the Google

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Edward K. Ream
On Sun, Jun 25, 2023 at 8:05 AM Thomas Passin wrote: > Assuming that these commands will continue to work after the PR: c0, p0 = c, c.p c2 = g.handleUnl(unl, c) Oops! In the PR g.handleUNL returns None. I'll restore the legacy operation immediately. Edward -- You received this message

Re: Leo active file bug and how to get the content of unl

2023-06-26 Thread Edward K. Ream
On Sun, Jun 25, 2023 at 7:51 AM Thomas Passin wrote: > "Remove support for cross-file UNLs" - WTF??? This will break some of my > scripts. How are we going to navigate to other outlines by UNL? Wasn't > that half of the point of having UNLs in the first place? This conversation is likely

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Monday, June 26, 2023 at 10:02:40 AM UTC-5 Edward K. Ream wrote: > I'll add p.get_legacy_UNL and p.get_short_legacy_UNL. > I'll add expanded searching to g.findUNL, just as in g.findGNX. Both done. *Notes* 1. *Warning*: Plugins that call g.findUNL directly must *not *assume that the

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Mon, Jun 26, 2023 at 9:21 AM Thomas Passin wrote: The bookmark manager needs to 1) flatten the paths of nested nodes (to > provide labels like "software/python/frameworks") and 2) make each step of > those flattened labels clickable so that a user can navigate to their > node. Gnxs can't

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Thomas Passin
On Monday, June 26, 2023 at 7:34:57 AM UTC-4 Edward K. Ream wrote: On Sun, Jun 25, 2023 at 10:44 PM Thomas Passin wrote: Actually, bookmarks and zettelkasten should work *better* than before, provided: - they use the *new* p.get_UNL() and - they work with both legacy and new unls, which they

Re: leojs alpha

2023-06-26 Thread jkn
Hi Felix - something I've missed in the exciting mentions re. leojs here. Is the 'transliteration' done manually ('after coding for a few years'...) or via some (semi'?)-automated process? If the former, I'm wondering how 'upstream' work on Leo gets incorporated. If the latter, I'm curious

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Monday, June 26, 2023 at 6:34:57 AM UTC-5 Edward K. Ream wrote: > I'm going to restore g.findUNL() and hook it back into g.handleUnl(). Done, and fairly cleanly too in g.handleUnl(). Please test the ekr-3181-mypy-links branch and report any problems. test.leo now contains working clickable

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Sun, Jun 25, 2023 at 10:44 PM Thomas Passin wrote: > However, I feel strongly that p.get_GNX() should return the position's actual gnx string, which is what the name says it does. p.gnx is p's gnx. That hasn't changed. p.get_GNX() is something completely different. The name is not as

Re: About PR #3215: unbreakable unls!

2023-06-26 Thread Edward K. Ream
On Sun, Jun 25, 2023 at 10:44 PM Thomas Passin wrote: > > I have just completed taking the currently-existing unl handling functions > p.get_UNL(), g.findUNL(), and g.handleUnl() from the core - the ones > scheduled to go to the attic or be changed - and turned them into > stand-alone functions