Hi Oliver,
nice! I had introduced this method, but this move was still on todo.
Thanks for doing this :)
Thomas
On 12/10/2011 01:29 AM, Olivier Hallot wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Please find attached a partial fix for Easy Hack FDO43460,
Part II
Module basctl
- --
From 83c6e1d5ab69429fcae33bda26fcbdb6dbd97099 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Sun, 16 Jan 2011 20:55:22 +0100
Subject: [PATCH] Correct bracket closing.
---
sc/source/ui/vba/vbahelper.cxx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
()) {...}
if (!aStr.isEmpty()) {...}
I think this would make the code more readable.
-Thomas
From fdf1e69730457763778f5735bb5709f5fc227327 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Fri, 21 Jan 2011 13:43:52 +0100
Subject: [PATCH] New method: isEmpty() - Checks if a string
On 01/21/2011 03:08 PM, Michael Meeks wrote:
Hi Thomas,
On Fri, 2011-01-21 at 14:54 +0100, Thomas Arnhold wrote:
won't do this without your approval.
Looks fine to me - no point in duplicating license headers.
Michael K was writing a nice lint tool, that may be able to find
Hopefully this is fixed now. I accidently removed a 'premac.h' and
'postmac.h' definition.
-Thomas
On 01/23/2011 07:51 AM, Norbert Thiebaud wrote:
components:6ea1497263e15e212d6c42c23e9e8b76d6dc1470
breaks the MacOS build:
Compiling: extensions/source/plugin/base/service.cxx
2001
From: Thomas Arnhold tho...@arnhold.org
Date: Tue, 25 Jan 2011 14:34:37 +0100
Subject: [PATCH 3/3] Don't build ww1.
---
sw/prj/build.lst |3 +--
sw/source/filter/makefile.mk |1 -
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/sw/prj/build.lst b/sw/prj
Hi,
does anyone need this macros? I removed them completely.
-Thomas
From dfe6fbe864926c8ef29c34681b0425f7aacdca75 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Mon, 31 Jan 2011 09:52:51 +0100
Subject: [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx
Thanks.
On 01/31/2011 12:32 PM, Cedric Bosdonnat wrote:
Hi Thomas,
On Mon, 2011-01-31 at 09:58 +0100, Thomas Arnhold wrote:
does anyone need this macros? I removed them completely.
I just pushed your patch here:
http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id
Hi,
I'm not really sure about this.
There are some files lying around with StarDivision or StarOffice
copyright notes. They could be removed, could they?
-Thomas
From b93f098328afb2cf3ad420bfef45dacbdd7d5181 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Mon, 31 Jan 2011
Ok, I wondered because this copyright notice is only inside two files of
hwpfilter. But you're right, they have to the rights on it.
-Thomas
On 01/31/2011 07:30 PM, Norbert Thiebaud wrote:
On 1/31/11, Thomas Arnhold tho...@arnhold.org wrote:
Hi,
I'm not really sure about
Thanks. Filed a bug #33782.
-Thomas
On 01/31/2011 09:44 PM, Caolán McNamara wrote:
On Mon, 2011-01-31 at 19:20 +0100, Thomas Arnhold wrote:
There are some files lying around with StarDivision or StarOffice
copyright notes. They could be removed, could they?
Heh, probably not. In this case
Hi,
I just found out, that settings.mk resets all CDEFS which were defined
in some makefiles. For example:
sc/source/ui/vba/makefile.mk defines:
CDEFS+=-DVBA_OOBUILD_HACK
But some lines later settings.mk is included (which is
solenv/inc/settings.mk)
.INCLUDE : settings.mk
In this file CDEFS
Thanks, didn't see that. I fixed it that way.
-Thomas
On 02/02/2011 12:48 AM, Norbert Thiebaud wrote:
On Tue, Feb 1, 2011 at 5:05 PM, Thomas Arnhold tho...@arnhold.org wrote:
Hi,
I just found out, that settings.mk resets all CDEFS which were defined
in some makefiles. For example:
sc
I have no idea how the compiler parses that block of code as it is
indeed ambiguous. But I'm more in favor of interpreting it based on the
indent levels than how the compiler might be parsing it.
Kohei
From 088714d49235976ff04a0ac0f8f37e32120810b6 Mon Sep 17 00:00:00 2001
From: Thomas
Thanks ;)
On 02/02/2011 11:44 PM, Kohei Yoshida wrote:
On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote:
Oh, I think this was a mistake o mine. I removed the brackets, didn't
really thought, that the else statement could be associated with the
inner if. I attached the patch to bring
.
Regards,
On Thu, 2011-02-03 at 17:41 +0100, Thomas Arnhold wrote:
In addition to this:
There's the possibility to define multiple return values with \retval.
So we would get a nice formatted list like with param.
From the doxyfile documentation:
-
\retval return value
Hi,
as I understand this, it would be nice to have this method in OString,
too. I've attached the patch.
Thomas
On 01/21/2011 05:55 PM, Michael Meeks wrote:
Hi Thomas,
On Fri, 2011-01-21 at 13:52 +0100, Thomas Arnhold wrote:
New method: isEmpty() - Checks if a string is empty.
I
I think the problem is, that without resize the hash map could be
overfilled.
I did fix this like commit 6ecdae26517b89ee670.
Think problem is like in PspKernInfo::Initialize() [in
vcl/unx/source/gdi/salgdi3.cxx]:
maUnicodeKernPairs.insert( aKernPair );
maUnicodeKernPairs is
Hi Christina,
I started to remove double includes. These could be identified by a
script (if you want to have that write me a mail). But there is one
problem within this task - called forward includes. I think removing
doubled includes and removing double line spacing within them will be
more
Hi Guilaume,
you can request a git account an push the patches by your own:
http://freedesktop.org/wiki/AccountRequests
Thomas
On 02/08/2011 08:57 AM, Guillaume Poussel wrote:
I have edited the wiki to show I'm currently working on it.
Please find attached again new patches to remove this
Gna, sorry for this. Didn't update the wiki page, as these clean up was
incidendental to some other cleaning. I'll update the wiki page.
Thomas
On 02/08/2011 09:56 PM, Caolán McNamara wrote:
On Sun, 2011-02-06 at 11:59 -0500, spad...@sover.net wrote:
Now with fewer blank lines!
Thanks for
To have that log on the web would be nice (not all persons have a big
mail account - some mail providers only give you a few megabytes at all).
I did a fresh build with a git clone from the morning and there were no
errors at all.
Thomas
On 02/10/2011 02:55 PM, Tor Lillqvist wrote:
Would it be
Oh, didn't see the link. Didn't know that it's already on the web! I'm
not sure if everybody knows that there are logs on the web, maybe you
could add this link to the tinderbox mails :)
Thomas
On 02/10/2011 04:38 PM, Thomas Arnhold wrote:
To have that log on the web would be nice (not all
Hi,
I removed these two variables this afternoon ;) I'll push the rest in
some hours. Thanks, didn't see that at all!
Thomas
On 02/10/2011 06:11 PM, Takeshi Abe wrote:
Hi,
This is an easy hack against calc.
Cheers,
-- Takeshi Abe
___
I pushed it. Thanks!
On 02/10/2011 07:03 PM, Thomas Arnhold wrote:
Hi,
I removed these two variables this afternoon ;) I'll push the rest in
some hours. Thanks, didn't see that at all!
Thomas
On 02/10/2011 06:11 PM, Takeshi Abe wrote:
Hi,
This is an easy hack against calc.
Cheers
Hi,
looks nice. But that doesn't replace manual overlooking what was
deleted. For example in dmake/dmake.c was the following left:
/* Uncomment the following line to pass commands to the DBUG engine
* before the command line switches (-#..) are evaluated. */
This comment was related to
Hi,
what the heck do we do with Tools - Media Player? Do we need this
within an office suite? Is anyone using this?!
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi,
I've removed gjc aot from the build system. I grep'd for occurances
inside other repos, but it doesn't match anything. Looks like this is
all. LibO builds an runs fine on Linux.
Thomas
From a67a2555a34b07babfc809e7d58e9ee6c8f3 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho
Hi Luke,
thanks for that. But could you please use git format-patch for the next
patches? Would be easier.
Thanks for the patch!
Thomas
On 02/12/2011 06:15 PM, L P wrote:
Deleted some more commented-out code in xmerge.
Code is contributed under the LGPLv3+ / MPL.
Luke
Hi Luke,
I applied patchfile one only partially. These @param and @autor tags are
important for javadoc.
Thanks!
Thomas
On 02/12/2011 06:36 PM, Luke Petrolekas wrote:
First patch deletes two commented lines out and removes four bogus comments.
The second patch deletes some commented out
Pushed.
On 02/12/2011 06:57 PM, Thomas Arnhold wrote:
Hi Luke,
I applied patchfile one only partially. These @param and @autor tags are
important for javadoc.
Thanks!
Thomas
On 02/12/2011 06:36 PM, Luke Petrolekas wrote:
First patch deletes two commented lines out and removes four
This one got obsolete by one of your other patches.
Thomas
On 02/12/2011 05:56 PM, L P wrote:
Deleted some more commented-out code in xmerge.
code is contributed under the LGPLv3+ / MPL.
Luke
___
LibreOffice mailing list
Hi,
thanks, looks nice! Pushed it!
Thomas
On 02/12/2011 09:12 PM, Antoine Proulx wrote:
Hi,
Here's a patch who removes bogus comments. It's released under the
LGPLv3+ / MPL.
Antoine
___
LibreOffice mailing list
Hi,
looks nice! I've build and run it without any problems. And I didn't
find any references, too.
Thomas
On 02/12/2011 06:07 PM, Julien Nabet wrote:
Hello,
Here is a patch to remove xine.
I didn't want to push it myself cause perhaps it needs to be reviewed.
I just removed unxlng
Thanks for all of them! I pushed them all.
I deleted one additional line in cui/source/tabpages/numfmt.cxx: //@
aEdFormat.SetText( aLbFormat.GetSelectEntry() ); as this also belong to
a deleted comment.
Thomas
On 02/13/2011 02:08 PM, Guillaume Poussel wrote:
Second part.
Hi,
nice, thanks for this! I pushed it. As far as I know there is no need to
reformat the code, because this should be done by a script some time
later (and we want to be compatible to diffs from OOo).
Thomas
On 02/13/2011 03:29 PM, Arnaud Versini wrote:
Hi,
Remove some comments from
Looks good. Thanks! I pushed it.
Didn't know that there are bug numbers like this #b449874#.
Thomas
On 02/13/2011 01:57 AM, Antoine Proulx wrote:
Hi,
Here's a patch (another one) who removes bogus comments. It's released under
the
LGPLv3+ / MPL.
Antoine
Thanks! I pushed it all.
Thomas
On 02/13/2011 01:26 AM, Michael Münch wrote:
Hi,
first attempt so I will take any advise (split the patch into smaller files?).
License is LGPLv3+/MPL.
I would have edited the wiki that I am working on this directory but the
registration is disabled.
Christoph thanks for the discussion link and the specs!
On 02/12/2011 10:01 PM, Michael Meeks wrote:
On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote:
what the heck do we do with Tools - Media Player? Do we need this
within an office suite? Is anyone using this?!
:-) My
I did this already, as the registration for the wiki doesn't work at the
moment.
Thomas
On 02/13/2011 10:19 PM, Caolán McNamara wrote:
On Sat, 2011-02-12 at 18:07 +0100, Julien Nabet wrote:
Hello,
Here is a patch to remove xine.
I think that was an Easy Hack, can you remove it from that
I pushed it now. Wanted that someone had a look at it ;)
On 02/13/2011 10:38 PM, Caolán McNamara wrote:
On Sat, 2011-02-12 at 17:02 +0100, Thomas Arnhold wrote:
And I removed configure.cmd as it's a personal file (local paths and so on).
Yeah, remove that, and the aot removal looks good too
Thanks!
On 02/14/2011 02:01 PM, Thorsten Behrens wrote:
Thomas Arnhold wrote:
Didn't know that there are bug numbers like this #b449874#.
Those are from the old Sun-internal bugtracker (in contrast to the
old StarDivision-internal bugtracker, which is w/o letter prefix) -
and can be elided
I've updated the wiki.
On 02/14/2011 10:40 AM, Michael Meeks wrote:
Hi Christina,
On Sat, 2011-02-12 at 21:07 +0100, Christina Roßmanith wrote:
binfilter/bf_svtools/source/config/svt_menuoptions.cxx and
svtools/source/config/menuoptions.cxx
So - as Tor says, binfilter is
Hi Balint,
looks good. I've pushed the second one. I slightly changed your patch -
removed the newlines for the empty methods and didn't remove the
description in writerfilter/inc/doctok/WW8Document.hxx as this is some
kind of doxygen code.
For the first patch, which removes the method, I'm not
, Thomas Arnhold wrote:
Hi Balint,
looks good. I've pushed the second one. I slightly changed your patch -
removed the newlines for the empty methods and didn't remove the
description in writerfilter/inc/doctok/WW8Document.hxx as this is some
kind of doxygen code.
For the first patch, which
Hi,
I stumbled across some files w/o any copyright notice in
writerfilter/source/dmapper. So I grep'ed around and found are more or
less long list of files with copyright notice missing. I've attached it
to the mail. I've only searched for cxx and hxx files.
I filed a bug at OOo:
Thanks! Pushed it.
Thomas
On 02/14/2011 07:54 PM, Kevin Hunter wrote:
Hullo List,
One, likely final, cppcheck-found post- to pre-iterator patch.
Cheers,
Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
On 02/14/2011 09:32 PM, Caolán McNamara wrote:
On Mon, 2011-02-14 at 19:45 +0100, Thomas Arnhold wrote:
Hi,
I stumbled across some files w/o any copyright notice in
writerfilter/source/dmapper. So I grep'ed around and found are more or
less long list of files with copyright notice missing
Hi,
i stumbled across some precompiler checks for several (deprecated?) arches:
HP9000 (already removed some parts of this)
SINIX
RM400
...
And another thing, in combination with GCC: C272 (occurs with GCC)
i.e. at impress/sd/source/ui/view/zoomlist.cxx:#if ( defined GCC
defined C272 ) .
Hi,
On 02/12/2011 10:01 PM, Michael Meeks wrote:
On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote:
what the heck do we do with Tools - Media Player? Do we need this
within an office suite? Is anyone using this?!
:-) My suspicion is that ~no-one is using it.
I think the same.
Hi Julien,
I've compiled and tested it. Works fine. I read the bug description and
there was said, that on Windows Alt works as F6 on Linux - to set focus
on the menubar. Now we completely got rid of this with Alt on Linux. Is
this intentionally, say that Alt alone has no effect at all?
I
Yeah, thanks for fixing them :)
Thomas
On 02/16/2011 09:36 AM, Noel Power wrote:
Hi Thomas,
On 14/02/11 21:02, Thomas Arnhold wrote:
On 02/14/2011 09:32 PM, Caolán McNamara wrote:
On Mon, 2011-02-14 at 19:45 +0100, Thomas Arnhold wrote:
Yes, some of them. I've corrected the list. Many
Hi Caolán,
I'm looking ahead this at the weekend. Maybe it's worth a task to write
a little lint script which checks if new files have a copyright header.
Thomas
On 02/14/2011 10:10 PM, Caolán McNamara wrote:
On Mon, 2011-02-14 at 22:02 +0100, Thomas Arnhold wrote:
You're right
Hi,
And another thing, in combination with GCC: C272 (occurs with GCC)
i.e. at impress/sd/source/ui/view/zoomlist.cxx:#if ( defined GCC
defined C272 ) . Doesn't look that this is set anymore.
Yeah, you got me there. No idea where C272 came from. I strongly suspect
it was set to indicate
On 02/15/2011 10:28 PM, Caolán McNamara wrote:
On Tue, 2011-02-15 at 22:22 +0100, Francois Tigeot wrote:
Of the ports listed on http://porting.openoffice.org/ , Tru64 is dead and
I would be surprised if VMS and Linux/m68k were much alive.
Yeah, only take the completed one, VMS and Tru64
Great! Pushed it! Thanks.
Thomas
On 02/16/2011 07:16 PM, Bálint Dózsa wrote:
Hi,
I have removed some dead code form //xml2cmp, /xmlhelp/ and //xmloff/.
My code is under the LGPLv3+/MPL dual license.
Regards,
Balint Dozsa
___
Hi Francois,
in the meantime I removed HPUX and SCO support. Found out, that
osarch.pm is pretty unused ;)
I didn't touch libs-extern(-sys) and dmake, too.
Your patchset looks good.
Thomas
On 02/16/2011 08:49 PM, Francois Tigeot wrote:
The attached patches remove OSF/1 support from the build
On 02/16/2011 03:40 PM, Francois Tigeot wrote:
On Wed, Feb 16, 2011 at 01:06:47PM +, Caolán McNamara wrote:
On Wed, 2011-02-16 at 13:03 +0100, Francois Tigeot wrote:
On Wed, Feb 16, 2011 at 08:55:12AM +, Caolán McNamara wrote:
Are the UUID_SYSTEM_TIME_RESOLUTION_100NS_TICKS defines in
On 02/16/2011 09:53 PM, Francois Tigeot wrote:
On Wed, Feb 16, 2011 at 09:15:37PM +0100, Thomas Arnhold wrote:
in the meantime I removed HPUX and SCO support.
Looking at your diffs for the SCO stuff, I found a _WIN16 test.
It seems many files are infected with WIN16 references, most
On 02/16/2011 09:53 PM, Francois Tigeot wrote:
On Wed, Feb 16, 2011 at 09:15:37PM +0100, Thomas Arnhold wrote:
in the meantime I removed HPUX and SCO support.
Looking at your diffs for the SCO stuff, I found a _WIN16 test.
It seems many files are infected with WIN16 references, most
ce9dd25c9b5383daa6259a1e328d3409a0b60778 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Thu, 17 Feb 2011 10:21:47 +0100
Subject: [PATCH] Remove TCPP
Seems to be an old compiler
---
rsc/source/prj/gui.cxx |2 +-
rsc/source/prj/start.cxx |4 ++--
rsc/source/rscpp
Ah, forgot one.
On 02/17/2011 10:31 AM, Thomas Arnhold wrote:
Hi,
TCPP seems to be an old compiler. Google doesn't know anything about it,
but there were some comments in the source which let me conclude that
this a compiler. I've removed it from filter and writer. For libs-gui I
need
Nice. I let those files untouched, thought they came from X. I'll remove
hpux and this other stuff soon.
Thomas
On 02/21/2011 05:19 PM, Francois Tigeot wrote:
The attached patch a 386BSD #defined test (the only one ?)
If nobody objects, I'll push it in a few hours.
I have left the MACH
On 02/17/2011 01:02 PM, Francois Tigeot wrote:
On Thu, Feb 17, 2011 at 10:08:58AM +, Caolán McNamara wrote:
CSET is probably also complete foo IIRC. Though I don't know to what it
referred.
I don't know if these cleanups are the reason, but my builds are now faster
by a few minutes.
On 02/17/2011 10:39 AM, Tor Lillqvist wrote:
TCPP seems to be an old compiler.
Turbo C++ ?
--tml
Yes, thanks :)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 02/17/2011 11:08 AM, Caolán McNamara wrote:
On Thu, 2011-02-17 at 10:34 +0100, Thomas Arnhold wrote:
Ah, forgot one.
All looks good, go for it.
CSET is probably also complete foo IIRC. Though I don't know to what it
referred.
C.
IBM CSet C- Compiler - I'll remove this one, too
Hi,
I've recently replaced all ASSERT_ID() macros with OSL_ASSERT().
Therefore errhdl.[hc]xx became obsolete. So I removed these files.
There was a line in errhdl.hxx:
SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* );
With this removed I changed the API, right?
There is one file left
On 02/21/2011 06:37 PM, Caolán McNamara wrote:
On Mon, 2011-02-21 at 18:20 +0100, Thomas Arnhold wrote:
SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* );
With this removed I changed the API, right?
Sure, but only an internal API, the external API, i.e. the bits that
extensions link
Hi Martin,
I've pushed it. Please could you attach such a diff as patch next time?
Would be easier to commit it :) Thanks!
Thomas
On 02/21/2011 10:28 PM, Martin Kepplinger wrote:
This translates the few german code comments in the cctrl directory to
english.
This is contributed under the
I've pushed it. Thanks!
Thomas
On 02/21/2011 10:03 PM, Martin Kepplinger wrote:
This fixes a typo that occured during translation. thanks.
This is contributed under the terms of the LGPLv3+/MPL dual license.
---
sw/source/ui/app/docsh2.cxx |2 +-
1 files changed, 1 insertions(+), 1
Hi Albert,
thanks! I've pushed it. But could you please separate your dead code
removal and translation? It makes it hard to review this and if some
dead looking code should come back later it's harder to do this (with
translations in one diff). :)
Thanks for your patches!
Thomas
On 02/21/2011
Yeah, thanks! Had some trouble with the diff - at the end of file there
were some accidentally redos of some prior changes. I removed them (CSET
and tools/list.h). And there were lots of trailing whitespaces. But now
it's all fine. Thanks!
Thomas
On 02/21/2011 09:14 PM, Albert Thuswaldner wrote:
Hi Rogerio,
you could grep for it in the command line with grep '\$MINLEN' * -R or
you could search the source with http://opengrok.libreoffice.org. Then
you'll get
libs-core/sfx2/source/dialog/password.* as result :)
You've already done some contribution with this email! Would be nice if
you
On 02/22/2011 01:52 AM, Kohei Yoshida wrote:
On Mon, 2011-02-21 at 21:14 +0100, Albert Thuswaldner wrote:
Hi,
Translated German comments in libs-core/svx/source/dialog.
Made a few other fixes (removed out commented code) along the way.
Albert,
@@ -515,9 +501,7 @@ void SvxRectCtl::Paint(
On 02/22/2011 12:06 AM, Martin Kepplinger wrote:
Am 21.02.2011 23:08, schrieb Thomas Arnhold:
Hi Martin,
I've pushed it. Please could you attach such a diff as patch next time?
Would be easier to commit it :) Thanks!
Thomas
On 02/21/2011 10:28 PM, Martin Kepplinger wrote:
This translates
On 02/22/2011 11:38 AM, Thomas Arnhold wrote:
On 02/22/2011 12:06 AM, Martin Kepplinger wrote:
Am 21.02.2011 23:08, schrieb Thomas Arnhold:
Hi Martin,
I've pushed it. Please could you attach such a diff as patch next time?
Would be easier to commit it :) Thanks!
Thomas
On 02/21/2011 10
Hi,
I've finally removed the menu entry from calc, writer and draw.
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Yeah right, but on writer, calc and draw? It's still in impress. Or are
you using it from the other apps?
Thomas
On 02/22/2011 09:47 PM, Kálmán „KAMI” Szalai wrote:
Sometimes Mediaplayer is useful.
Inserting video, preview, etc.
KAMI
___
On 02/23/2011 05:46 AM, Jean-Baptiste Faure wrote:
Perhaps you should ask end-users. Some users are using Draw or Writer as
a replacement of MS-Publisher. Or Writer to edit their website. Maybe it
is useful in these cases ?
Right, the website thing came to my mind later, too. But as I said: I
Hi Sébastien,
On 02/23/2011 08:46 AM, Sébastien Le Ray wrote:
This patch removes an include which prevent debug build of sw (the
file has been deleted in commit
6aa93c291d18c7db6dbee73adc6c4aa1bdc88eda.
I removed the whole except directory with dbgloop.cxx in it. Maybe your
tree is out of
Hi Yifan,
On 02/23/2011 10:47 AM, Yifan Jiang wrote:
I guess end-users could still bring the menu item back using the menu
customization UI (Tools-Customize...-Menus). Is that right?
That's possible. But for writer and calc the background calls are gone.
So it won't work. Maybe I re-enable
Hi Balint,
not all of them are unused. getDropDownEntries() and getDropDownResult()
are used at FormControlHelper.cxx. But the rest is fine. I applied the
rest. Thanks!
Thomas
On 02/22/2011 05:11 PM, Bálint Dózsa wrote:
Hi,
I have removed some unused methods.
Regards,
Balint Dozsa
Hi Christina,
thanks, pushed this! Why don't you commit this by your self? Your
patches look good! :)
Thomas
On 02/24/2011 01:37 PM, Christina Roßmanith wrote:
Hi,
continued to remove commented code lines.
As usual under LGPLv3+ / MPL
Christina
Hi,
pushed this. Thanks!
Thomas
On 02/23/2011 10:47 PM, Michael Lefevre wrote:
---
writerfilter/source/dmapper/PropertyMap.cxx |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
Thanks, pushed this, too :)
Thomas
On 02/23/2011 11:11 PM, Michael Lefevre wrote:
Still code cleaning.
---
sc/source/ui/view/gridwin.cxx |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index
Pushed this. Thanks!
Thomas
On 02/23/2011 11:03 PM, Michael Lefevre wrote:
Keep cleaning the code, line by line.
---
filter/source/flash/swfwriter.hxx |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/filter/source/flash/swfwriter.hxx
Hi,
the latest build fails on sal cppunit tests, because I have no gdb
installed. This dependency is new, maybe because some tests got enabled.
I think configure should check for gdb and turn this test on/off.
---
--
- start unit test #1 on
On 02/24/2011 10:37 PM, Caolán McNamara wrote:
It only does this if the environmental variables DEBUGCPPUNIT or
debugcppunit are set. Those aren't automatically set, they have to be
set manually when trying to debug a unit test, at which point its
reasonable to expect gdb to be installed. Did
Hi,
On 02/25/2011 12:07 PM, Fernand Vanrie wrote:
Please consider: We are living and working in a Multi Media world:
Not only who is working with Impress needs a media player, all content
can have mixed content and LO must be the one stop place to handle
all multi media stuff.
I partially
Nice, thanks :) Pushed it.
Thomas
On 02/28/2011 11:21 PM, Michael Lefevre wrote:
ACCESSIBLE_EVENT_NOTIFICATION_ENABLED was never define. So the #ifdef #endif
brackets could go away.
---
.../extended/accessibleiconchoicectrlentry.hxx | 16
Thanks, pushed the first one. The second didn't apply (0002-..).
Thomas
On 02/27/2011 10:26 PM, Xisco Faulí wrote:
Remode all dead code from /libs-core/sfx2/source
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi Antoine,
pushed this, thanks!
Probably your name isn't set in the gitconfig, only your mail address
was given as author.
You could set this with: git config --global user.name Your Name
Thomas
On 02/28/2011 12:06 AM, Antoine Proulx wrote:
Hi,
Here's a patch who removes bogus comments.
Thanks! I've pushed it. Deleted three additional comments as they belong
to the deleted code. Nice work :)
Thomas
On 02/27/2011 04:17 PM, Xisco Faulí wrote:
Greetings
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
Hi Khaled,
On 03/01/2011 05:10 PM, Khaled Hosny wrote:
In locally built libreoffice master I can't get full justification; text
is kept left aligned. I tested with the distro packaged 3.3.1 and
justification is fine. Can anyone confirm this, or it is just me?
Yes, I can confirm this! I've
Hi,
On 03/01/2011 06:29 PM, Fernand Vanrie wrote:
Video in PDF can been done but it must be Flash-video :-)
So: or: we need a on the fly conversion, or you havbe accept Flash
video in the LO documents. I can help to do some research but i am not a
coder, just a bit off a avandced user.
That
On 03/01/2011 02:07 PM, Caolán McNamara wrote:
#n123456# bugids are Novell bugids, typically publically available, e.g.
#n672421# - https://bugzilla.novell.com/show_bug.cgi?id=672421
So they're typically useful information.
I've added this information to the Easy Hacks page, under Translate
Hi Fernand,
On 03/02/2011 11:48 AM, Fernand Vanrie wrote:
2 Corrections:
- I was wrong, in PDF documents we can now embed most off the Video-formats
- LO - (windows) still not accept flash video
Use Insert - Media and Sound - Select 'All files' as filter, so you
are able to add flv videos,
On 03/12/2011 11:46 PM, Miklos Vajna wrote:
So far we have 4 .gitattributes files in the root of 4 repos with the
same contents. To have them in the rest of the repos and avoid
duplication, it's better to have a single one in the bootstrap repo and
configure the rest of the repos to use that
On 03/17/2011 11:26 PM, Jacek Wolszczak wrote:
Easy hacks align ASSERT ( friends) macro foo patch.
Yeah, this looks nice. Did you build this once with --enable-debug and
--enable-dbgutil?
Thomas
___
LibreOffice mailing list
Hi Jacek,
On 03/18/2011 09:14 AM, Jacek Wolszczak wrote:
I did compile it with --enable-debug as it's OSL_ specific and it
compiled correctly. Haven't used --enable-dbgutil as there are no #ifdef
DBG_UTIL in the files I touched.
But for the future I will recompile LibreO with both flags
1 - 100 of 1027 matches
Mail list logo
