[PATCH] Ensure $OBJDUMP is defined

2008-05-05 Charles Wilson ... Yaakov Selkowitz ... Ensure $OBJDUMP is defined * libltdl/m4/libtool.m4 (_LT_DECL_OBJDUMP): new macro ensures that $OBJDUMP is always defined sanely. (_LT_SYS_DYNAMIC_LINKER): call it. (_LT_CHECK_MAGIC_METHOD

[PATCH] Ensure cwrapper compiles without warnings under -std=c99.

2008-05-05 Charles Wilson ... Ensure cwrapper compiles without warnings under -std=c99. * libltdl/config/ltmain.m4sh (func_emit_wrapper_part1): new function. (func_emit_wrapper_part2): new function. (func_emit_wrapper): delegate to new functions

[PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

2008-05-05 Charles Wilson ... * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto, for :-separated

[PATCH] Ensure $OBJDUMP is defined

2008-05-05 Charles Wilson ... Yaakov Selkowitz ... Ensure $OBJDUMP is defined * libltdl/m4/libtool.m4 (_LT_DECL_OBJDUMP): new macro ensures that $OBJDUMP is always defined sanely. (_LT_SYS_DYNAMIC_LINKER): call it. (_LT_CHECK_MAGIC_METHOD

Re: [PATCH] Ensure $OBJDUMP is defined

Ralf Wildenhues wrote: * Charles Wilson wrote on Tue, May 06, 2008 at 02:23:05AM CEST: 2008-05-05 Charles Wilson ... Yaakov Selkowitz ... Ensure $OBJDUMP is defined * libltdl/m4/libtool.m4 (_LT_DECL_OBJDUMP): new macro ensures that $OBJDUMP is always

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Eric Blake wrote: According to Charles Wilson on 5/5/2008 6:23 PM: | -# func_emit_wrapper arg | +# func_emit_wrapper_part1 arg Since you provide a default, I'd show that arg is optional, as in: # func_emit_wrapper_part1 [arg=no] Ack. Is func_emit_wrapper_part1_arg1 even used? Why not just

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Ralf Wildenhues wrote: In addition to Eric's review, here's some extremely picky nits: -# func_emit_wrapper arg +# func_emit_wrapper_part1 arg Isn't that .libs/_libs aka $objdir here? This is not new here, but further below. Capitalization, period at end of the sentence. #

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Eric Blake wrote: According to Charles Wilson on 5/5/2008 6:23 PM: | 2008-05-05 Charles Wilson ... | | * libltdl/config/ltmain.m4sh (func_to_native_path): I've become accustomed to using a 1-line summary in my ChangeLog messages prior to the first '* file:' line; that way, the summary can

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Ralf Wildenhues wrote: Hi Charles, You can simplify the remaining part of the ChangeLog entry: or even to this: (func_emit_cwrapperexe_src) [lt_setenv, lt_extend_str] [lt_split_name_value, lt_opt_process_env_set] [lt_opt_process_env_prepend, lt_opt_process_env_append]

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Charles Wilson wrote: 2008-05-05 Charles Wilson ... * libltdl/config/ltmain.m4sh (func_to_native_path): new function. If $host is mingw, and $build is mingw or cygwin, convert path to mingw native format. (func_to_native_pathlist): new function. Ditto

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Roumen Petrov wrote: libtool 2.2.4 patched with both patches still fail: ... (lt_setenv) setting 'PATH' to

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Roumen Petrov wrote: Hi Charles, About following comment: /* execv doesn't actually work on mingw as expected on unix */ Actually execXXX on microsoft windows create a new process and it is not mingw problem. What about to substitute mingw with windows ? Disagree. The FSF discourages to

Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

Gary V. Vaughan wrote: On 6 May 2008, at 22:47, Charles Wilson wrote: Unresolved: (1) whether func_emit_wrapper_part1 should even TAKE an argument (2) whether the cwrapper src, when printing a const char*, should use puts() in preference to printf(%s,...) Please go ahead and choose however

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Charles Wilson wrote: Cygwin: passes 115 (9 skip) on old test suite only two unexpected failures on new test suite -- but 25 and 72 are actually expected on cygwin. Mingw (msys): no regressions over previous results: old test suite: fails demo-exec after demo-shared (helldl) fails the fortran

[PATCH] [mingw] Add cross-compile support to cwrapper

[mingw] Add cross-compile support to cwrapper * libltdl/config/ltmain.m4sh (func_to_host_path): If present, use winepath to convert from $build to $host if $host is mingw and $build is neither mingw (msys) nor cygwin. Also update comments. (func_to_host_pathlist): Ditto. --- This is a follow-on

Re: [PATCH] [mingw] Add cross-compile support to cwrapper

Roumen Petrov wrote: Charles Wilson wrote: [mingw] Add cross-compile support to cwrapper May be the patch can be more simple. In a previous post I confirm that for the wine emulator is enough items in path list, where every item is absolute path from build system, to be separated by DOS

Re: [PATCH] [mingw] Add cross-compile support to cwrapper

your proposed modifications are optimizations. Lets go upstream. By this do you mean 'push to the git repo'? I'd rather wait for Ralf to get back and comment; should be later this week I think. Roumen Petrov wrote: Charles Wilson wrote: But I'm not sure that supporting changing the mapping

Re: [PATCH] [mingw|cygwin] Modify cwrapper to invoke target directly.

Eric Blake wrote: Eric Blake ebb9 at byu.net writes: | + /* otherwise ... */ | + newargz[++newargc] = xstrdup (argv[i]); Shouldn't you handle -- as the end of wrapper options, in case the user really wants to pass --lt-env-* as the first option to the wrapped executable? This

[PATCH] Cwrapper should not eat -- arguments

* libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [file scope]: Defined all option strings in terms of macro LTWRAPPER_OPTION_PREFIX. Similarly defined all option string lengths in terms of macro LTWRAPPER_OPTION_PREFIX_LENGTH. [main]: Modified option parsing algorithm to pass -- on to

Re: [PATCH] [mingw] Add cross-compile support to cwrapper

Roumen Petrov wrote: Charles Wilson wrote: By this do you mean 'push to the git repo'? yes (push/commit/put/add in head/trunk/origin/master/main branch) Attached see additional patch that implements the workaround for winepath's shortcomings. This patch should be applied on top

Re: [PATCH] Cwrapper should not eat -- arguments

Ralf Wildenhues wrote: As discussed here: http://lists.gnu.org/archive/html/libtool-patches/2008-05/msg00067.html ... this message specifies that the first argument not matching --lt- should end parsing, whereas your patch parses all arguments. Last message in the thread, at the very

Re: [PATCH] Cwrapper should not eat -- arguments

Ralf Wildenhues wrote: Other than that, the only thing this patch is missing is a testsuite test ensuring that -- really is passed through. (Such an addition is preapproved.) I tested this manually using -DDEBUGWRAPPER, but I don't know diddly about writing tests for the testsuite -- and

Re: [PATCH] Simplify argument parsing in cwrapper.

Ralf Wildenhues wrote: * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src): Use NULL where appropriate. Do not compute length of arguments needlessly. --- Let's make this a bit less redundant. Testsuite is still running (linux - mingw cross). OK to commit if it passes? Looks ok to

Re: [PATCH] [mingw] Add cross-compile support to cwrapper

* libltdl/config/ltmain.m4sh (func_to_host_path) [$host=mingw]: If present, use winepath to convert from $build to $host if $build is neither mingw (msys) nor cygwin. Use unconverted path as fallback when conversion fails. Also update comments. (func_to_host_pathlist) [$host=mingw]: Ditto. For

Re: [PATCH] Simplify argument parsing in cwrapper.

Charles Wilson wrote: Ralf Wildenhues wrote: * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src): Use NULL where appropriate. Do not compute length of arguments needlessly. --- Let's make this a bit less redundant. Testsuite is still running (linux - mingw cross). OK

Re: [PATCH] Cwrapper should not eat -- arguments

Olly Betts wrote: On 2008-05-25, Charles Wilson [EMAIL PROTECTED] wrote: +#define LTWRAPPER_OPTION_PREFIX --lt- +#define LTWRAPPER_OPTION_PREFIX_LENGTH 5 If the idea is that the user can change LTWRAPPER_OPTION_PREFIX, then hard-coding the length risks a mismatch if they fail

[PATCH] [mingw] fix cross-compile-with-wine case

* libltdl/config/ltmain.m4sh (func_to_host_path) [host=mingw, build!=mingw|cygwin]: check that winepath stdout is non-empty and exit code is 0, instead of checking stderr. Reported by: Roumen Petrov --- Following the discussion here:

Re: [PATCH] Check for only regular files, not devices

Stas Maximov wrote: +if test -f $1 -a -r $1 exec 50 $1; then I don't think -a is portable... -- Chuck

Re: [PATCH] [mingw] fix cross-compile-with-wine case

... (tiny change) +2008-06-01 Charles Wilson ... + + [mingw] fix cross-compile-with-wine case + * libltdl/config/ltmain.m4sh (func_to_host_path) + [host=mingw, build!=mingw|cygwin]: check that winepath + stdout is non-empty and exit code is 0, instead of checking

Re: [PATCH] [mingw] fix cross-compile-with-wine case

Ralf Wildenhues wrote: Hi Charles, * Charles Wilson wrote on Sat, May 31, 2008 at 07:11:58PM CEST: * libltdl/config/ltmain.m4sh (func_to_host_path) [host=mingw, build!=mingw|cygwin]: check that winepath stdout is non-empty and exit code is 0, instead of checking stderr. Reported by: Roumen

Re: Two small libltdl patches.

Peter O'Gorman wrote: On systems without argz we were exporting unmangled symbols argz_count and argz_add from libltdl. Not really a good idea. Rather than mangle the names, since we do not use either function, they were removed. But wasn't there a thread back in June where we explicitly added

Re: Two small libltdl patches.

Peter O'Gorman wrote: So, with the functions also removed from the header, ok? Fine by me -- but I can't give official approval. g -- Chuck

Re: [patch #6448] [MSVC 7/7] Add MSVC Support

Markus Duft wrote: IMHO mingw produces code that is very different from what MSVC produces - not only performance wise (in some cases). And remember, you can only link code generated by mingw and by msvc together if you're using C. Not C++ or any other symbol-mangled ABI. PLUS, if you're

Re: [patch #6448] [MSVC 7/7] Add MSVC Support

Peter Rosin wrote: That may not work, if Charles statements about dlls requiring different patchlevels of msvcr80 holds. But that appears to not be the case: I created a simple dll, exporting one function doing a printf (some random libc function). When building this dll, MSVC8 generated a

Re: [patch #6448] [MSVC 7/7] Add MSVC Support

Peter Rosin wrote: Do you remember if anything C++ was built with the offending patchlevel? Or was it the open-source C libraries and nothing else that was built differently? Looks like there was also xerces-c, which is open-source but C++. So, the root of the problem might not, in fact,

Re: [patch #6448] [MSVC 7/7] Add MSVC Support

Peter Rosin wrote: Charles Wilson skrev: I also think that -winnt is too broad; and I'd really hate to see the massive uglification of the libtool code -- and thousands of configure.ac's out there -- that would ensue if -mingw* were /officially/ overloaded to also represent the msvc-toolchain

Re: libtool(20080421), mingw-cross, check-local fail for DESTDIR tests

Roumen Petrov wrote: With attached patch now I get for libtool 2.2.4: DESTDIR tests 38: Simple DESTDIR install ok 39: DESTDIR with in-package deplibs ok Ping? http://lists.gnu.org/archive/html/bug-libtool/2008-05/msg00023.html Seems like an

Re: executable wrapper on mingw mangles arguments

Bruno Haible wrote: This is a severe regression in libtool 2.x w.r.t. 1.5.26. On mingw, several of the gettext tests fail because the executable wrapper created by the libtool script does two bad things: 1) It converts argv[0] from a filename with backslashes to a filename with slashes.

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

* libltdl/config/ltmain.m4sh (func_enable_tag): allow --verbose to set opt_verbose (func_win32_dllname_for_implib): New function. (func_mode_link) [cygwin|mingw]: Use linklib (that is, import lib) as dlpreopen file, rather than DLL. (func_generate_dlsyms) [cygwin|mingw]: Use

Re: executable wrapper on mingw mangles arguments

Ralf Wildenhues wrote: I haven't finished the testsuite addition yet. This fix requires such an addition. Ack. I think instead of Bruno's patch a much simpler fix is possible by including a different header: http://thread.gmane.org/gmane.comp.gnu.mingw.user/27968/focus=28033 But that

Re: executable wrapper on mingw mangles arguments

Ralf Wildenhues wrote: with all deliberate speed. Not sure what you mean here. If you mean applying the patch without a testsuite addition, then my humble reply is: if we had abandoned that strategy just longer ago, we'd have avoided a few embarrassing regressions. Not this. Rushing ahead

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

Ralf Wildenhues wrote: Hello Charles, thanks for the patch! Quoting a bit out of order: * Charles Wilson wrote on Sat, May 31, 2008 at 07:01:45PM CEST: * libltdl/config/ltmain.m4sh (func_enable_tag): allow --verbose to set opt_verbose [...] A) libtool --verbose does not actually set

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

Ralf Wildenhues wrote: The point is, we perhaps STARTED with the .la file, but the whole point of the dlpreopen $pass is to replace each .la file in $dlprefiles with the name of the object from which the symbols should be extracted, to build the symbol table. So, pick one: either the DLL, or

[PATCH] Fix --verbose option and add new --no-silent option

* libltdl/config/ltmain.m4sh (usage): Document new --no-silent/--no-quiet options. Spacing changes. (func_enable_tag): Handle --no-silent/--no-quiet options. Modified --verbose to actually activate opt_verbose. New behavior: --silent disables both normal output and func_verbose output. --verbose

[PATCH] Add func_win32_import_lib_p

* libltdl/config/ltmain.m4sh (func_win32_import_lib_p): New function. --- The second of several smaller patches broken out of, or arising from discussion involving, my original [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static one:

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

Charles Wilson wrote: Of course, first I need to revise the dlltool patch and get it accepted; there have been some comments on the binutils list. Done. Yay! http://sourceware.org/ml/binutils/2008-11/msg00180.html Well, that, and it fixes a test that currently fails. Which one, and can you

Re: [PATCH] Fix --verbose option and add new --no-silent option

Charles Wilson wrote: Ralf Wildenhues wrote: Hi Charles, * Charles Wilson wrote on Sat, Nov 15, 2008 at 10:40:26AM CET: * libltdl/config/ltmain.m4sh (usage): Document new --no-silent/--no-quiet options. Spacing changes. (func_enable_tag): Handle --no-silent/--no-quiet options. Modified

[PATCH] Fix --verbose option; add new --no-{silent|quiet|verbose} options.

++- libltdl/config/ltmain.m4sh | 16 +++- 4 files changed, 81 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index b1582fd..cd1b1fa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,22 @@ +2008-11-21 Charles Wilson ... + + Fix --verbose option; add new --no-{silent

Re: [PATCH] Fix --verbose option and add new --no-silent option

Ralf Wildenhues wrote: If you agree, then go ahead and commit with needed changes. Pushed: see new thread: [PATCH] Fix --verbose option; add new --no-{silent|quiet|verbose} options. -- Chuck

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static

Brian Dessent wrote: Ralf Wildenhues wrote: Did GCC change since then, or is this system-dependent? Interesting. I'd be curious to see if powerpc-ibm-aix5.3.0.0-c++filt recognises the FI/FD encoding, and if so then it would be reasonable to conclude that this is in fact system-dependent

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

* libltdl/config/general.m4sh: Adjust copyright date. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh: Adjust copyright date. (func_dlltool_identify): New function. (func_win32_dllname_for_implib): New function. (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Charles Wilson wrote: bootstrapped on cygwin, tested the demo-{conf|shared|static} + demo-make + demo-exec test cases with success. Full test suite in progress. And...4.5 hours later, test suite results on cygwin (1.7.0-37, but that shouldn't matter. The good news is, cygwin-1.7 now

[PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

* libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Charles Wilson wrote: Spot checked some regression tests on cygwin (all passed). Running full regression suite on mingw. OK to push, pending testsuite results? No regressions on msys/mingw from the last time I ran the testsuite on that platform (2.2.5a). IOW: Old testsuite results

[PATCH] [cygwin]: Add cross-compile support to cwrapper

libltdl/config/ltmain.m4sh: (func_cygpath): New function. (func_wine_to_win32_path): New function. Refactored from... (func_msys_to_win32): New function supports converting both paths and pathlists. Refactored from... (func_to_host_path): ...here. [msys-mingw]: Use refactored func_msys_to_win32.

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Peter Rosin wrote: I'm primarily trying to determine what impact this has on my MSVC branch... Den 2009-01-03 02:39 skrev Charles Wilson: *snip* +*cygwin* | *mingw* | *cegcc* ) We should strive to have fewer of these in ltmain.m4sh, not more. Yep. But the problem

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Roumen Petrov wrote: Charles Wilson wrote: [SNIP] This patch attempts to correct the issues raised in this thread: msys/mingw warnings about string length and putenv absence with gcc -Wall -ansi http://lists.gnu.org/archive/html/bug-libtool/2008-12/msg00038.html [SNIP] Patch fail

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Charles Wilson wrote: Peter Rosin wrote: I'm primarily trying to determine what impact this has on my MSVC branch... Ran some experiments on the libraries shipped with the Windows SDK. The attached script worked ok on most of them. After eliminating the static libraries and the import

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Charles Wilson wrote: Charles Wilson wrote: Peter Rosin wrote: I'm primarily trying to determine what impact this has on my MSVC branch... Ran some experiments on the libraries shipped with the Windows SDK. The attached script worked ok on most of them. After eliminating the static

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Peter Rosin wrote: Den 2009-01-05 06:24 skrev Charles Wilson: Interesting! Meanwhile, I have done some experiments on my own, as I don't like the dependence on anything that comes with MinGW when dealing with libtool and MSVC. I kind of suspected that. What about the attached? This version

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Peter Rosin wrote: Den 2009-01-06 02:06 skrev Charles Wilson: Maybe under that name. But a libbfd-ified version of impgen (as a replacement for the IMO totally broken -- but part of mingw-utils-0.3 -- reimp program), that happens to also supply an --identify foo --identify-ms functionality

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3

* libltdl/m4/libtool.m4 (_LT_CHECK_SHAREDLIB_FROM_LINKLIB): New macro sets sharedlib_from_linklib_cmd variable. (_LT_DECL_DLLTOOL): New macro ensures DLLTOOL is always set. * libltdl/config/ltmain.m4sh (func_generate_dlsyms): Use $sharedlib_from_linklib_cmd instead of directly invoking

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 3

Charles Wilson wrote: Full test suite on cygwin in progress. Assuming it passes, ok for squash and push? Results: old test suite: === All 113 tests passed (11 tests were not run) === New test suite: ERROR: 76 tests were run, 4 failed (3 expected

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here. (func_emit_cwrapperexe_src) [file scope]: re-organized includes

Re: spaces

Bob Friesenhahn wrote: For many years I have had my editor configured to always use spaces. This ensures WYSIWYG for everyone involved. Agree 100%. I try to manually match whatever sp/tab convention is in place -- using vi if I have to -- but much prefer all spaces. -- Chuck

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 2

Ralf Wildenhues wrote: +# func_tr_sh +# turn $1 into a string suitable for a shell variable name +# result is stored in $func_tr_sh_result +func_tr_sh () +{ + func_tr_sh_result=`echo $1 | $SED -e 's/[^A-Za-z0-9_]/_/g'` + # ensure result begins with non-digit + case $func_tr_sh_result in

[PATCH] Minor cygwin cleanup

libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct case pattern for cygwin. --- Ok to push? libltdl/config/ltmain.m4sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh index 6be529a..760f647 100644 ---

Re: [PATCH] Minor cygwin cleanup

Ralf Wildenhues wrote: * Charles Wilson wrote on Tue, Jan 20, 2009 at 11:31:43PM CET: libltdl/config/ltmain.m4sh (func_generate_dlsyms): Correct case pattern for cygwin. --- Ok to push? Yes, thanks! Pushed. -- Chuck

[PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

* libltdl/config/general.m4sh: Update copyright year. (func_tr_sh): New function. * libltdl/config/ltmain.m4sh (func_generate_dlsyms) [cygwin|mingw]: Obtain DLL name corresponding to import library by using value stored in unique variable libfile_$(transliterated implib name). If that fails, use

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Peter Rosin wrote: Den 2009-01-16 15:15 skrev Charles Wilson: Charles Wilson wrote: Charles Wilson wrote: * libltdl/config/ltmain.m4sh: Update copyright date. (func_emit_wrapper_part1): move contents to... (func_emit_wrapper_part2): move contents to... (func_emit_wrapper): here

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

Charles Wilson wrote: Test suite on cygwin/native in progress. Assumming test suite passes, OK? Comments, Review, Discussion? All tests pass (cygwin/native): Old suite: === All 113 tests passed (11 tests were not run) === New suite: 76 tests behaved

Re: [PATCH] [cygwin|mingw] fix dlpreopen with --disable-static take 4

Charles Wilson wrote: Reviewing my own submission... (func_cygming_dll_for_implib_core): New function. This function is actually called func_cygming_dll_for_implib_fallback_core Need to correct log history. (func_cygming_implib_p): New function. Confusing. There is already

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: Part of my tendency to include minor -- easy to review -- changes with larger ones is due to (a) see it, fix it, otherwise it'll be forgotten and (b) EVERY separate patchset requires an independent full

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

LT_DEBUGWRAPPER # define LTWRAPPER_DEBUGPRINTF(args) ltwrapper_debugprintf args static void ltwrapper_debugprintf (const char *fmt, ...) diff --git a/ChangeLog b/ChangeLog index b702907..8d83a7b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,17 @@ 2009-01-21 Charles Wilson libt...@cwilson.fastmail.fm

Re: Run tests with low max_cmd_len on MSYS/MSVC

Ralf Wildenhues wrote: We may need to think about speeding up func_to_host_path, e.g., by not forking for arguments that don't need conversion, or by converting several paths with a constant amount of forks. But that can be done separately. FWIW, as part of re-writing this: [PATCH]

Re: spaces

Ralf Wildenhues wrote: OK so it seems there are more voices for spaces. Can we agree to make the switch only after 2.2.8 though, I would like to avoid unnecessary churn ATM. Works for me. -- Chuck

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

/c89.at 2009-01-21 21:32:01.79210 -0500 @@ -0,0 +1,85 @@ +# c89.at -- test compliance with c89 standard -*- Autotest -*- + +# Copyright (C) 2009 Free Software Foundation, Inc. +# Written by Charles Wilson, 2009 +# +# This file is part of GNU Libtool. +# +# GNU Libtool is free software

[PATCH] Add tests for cwrapper with -std=c89 and -std=c99

@@ +# cwrapper.at -- test compliance with c89 standard -*- Autotest -*- + +# Copyright (C) 2009 Free Software Foundation, Inc. +# Written by Charles Wilson, 2009 +# +# This file is part of GNU Libtool. +# +# GNU Libtool is free software; you can redistribute it and/or +# modify it under the terms

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.

Charles Wilson wrote: The bits removed from this commit are attached as cygwin-cwrapper-cleanups.patch. Will start a new thread with these cleanups. -- Chuck

Re: testsuite performance

Ralf Wildenhues wrote: * Charles Wilson wrote on Wed, Jan 21, 2009 at 08:47:42PM CET: [...] EVERY separate patchset requires an independent full testsuite run. Until recently, that was 5 hours of sitting in front of my computer waiting for popups, while that computer was completely useless

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

Charles Wilson wrote: + sed s/LTCFAGS=.*/' $restrictive_flags'/ $orig_LIBTOOL ./libtool I've already fixed this typo s/LTCFAGS/LTCFLAGS/ -- Chuck

[PATCH] [cygwin|mingw] cwrapper cleanups.

libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src) [file scope]: re-organized includes and portability macros. Avoid oldnames on MINGW32 and MSVC for setmode/stat/chmod/getcwd/putenv. Declare _putenv on MINGW32 when -ansi. Use namespaced macro LT_DEBUGWRAPPER. --- This patch contains the parts

Re: [PATCH] Add tests for cwrapper with -std=c89 and -std=c99

Ralf Wildenhues wrote: Please go ahead and push with these changes. Pushed. -- Chuck

[PATCH] Add -Wall to cwrapper tests.

* tests/cwrapper.at: Add -Wall existing tests. Add additional round of tests with -Wall alone. --- Preapproved. As pushed... tests/cwrapper.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/cwrapper.at b/tests/cwrapper.at index 30e591e..ce4572e 100644 ---

[PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

* tests/cwrapper.test: Add new test for -DLT_DEBUGWRAPPER. * doc/libtool.texi [Linking executables]: Mention wrapper executables, in addition to wrapper scripts. Add menu referencing subsection 'Wrapper executables for programs'. [Wrapper executables for programs]: New subsection. Documents

Re: Add lib prefix to library name in the ltdl preloaded symbol lookup

Peter Rosin wrote: This is from need-lib-prefix.at: main.exeS.c when the test is run on the tip of the pr-msvc-support branch. lt__PROGRAM__LTX_preloaded_symbols[] = { { @PROGRAM@, (void *) 0 }, {foo1.lib, (void *) 0}, {libfoo1_LTX_i, (void *) foo1_LTX_i},

Re: [PATCH] [cygwin]: Add cross-compile support to cwrapper

Peter Rosin wrote: First off, your patch works like a charm on MSYS/MSVC, and I generally like it. But a couple of questions are open, when did native MinGW ar enter the picture when $build = cygwin and why is there a problem with leakage of paths from the other environment? I thought the

Re: Status of the MSYS/MSVC port

Peter Rosin wrote: On MSYS/MinGW, stresstest.at now passes when Run tests with low max_cmd_len, that fails on git master. On the other hand, cwrapper for uninstalled executables fails at cwrapper.at:78 (both with and without low max_cmd_len). It's the second time through the loop that fails,

Re: Status of the MSYS/MSVC port

Peter Rosin wrote: Maybe, here are the errors: So, I guess these declarations should do it (untested): int _setmode (int, int); int _spawnv (int, const char *, const char * const *); #ifndef _P_WAIT /* just in case */ # define _P_WAIT0 #endif _P_WAIT is guarded in MSVC's

Re: Status of the MSYS/MSVC port

Roumen Petrov wrote: Peter Rosin wrote: [SNIP] This was all inside #ifdef __MINGW32__, which assumes msvcrt.dll, i.e. compatible with MSVC 6, so we're safe. I think. Famous last words... It seems to me that I misunderstood report failure and the case. It start for ms compiler why #ifdef

Re: Status of the MSYS/MSVC port

Peter Rosin wrote: I have: $ gcc -v Reading specs from C:/MinGW/bin/../lib/gcc/mingw32/3.4.2/specs Configured with: ../gcc/configure --with-gcc --with-gnu-ld --with-gnu-as --host=mingw32 --target=mingw32 --prefix=/mingw --enable-threads --disable-nls

Re: Status of the MSYS/MSVC port

Peter Rosin wrote: Den 2009-01-29 11:49 skrev Charles Wilson: What version of mingw-runtime are you using? (I'm not sure which version I have; its from a bundle I put together about a year ago; I can get to the docu for that bundler later today. It's probably mingw-runtime-3.14). Something

Re: Status of the MSYS/MSVC port

Bob Friesenhahn wrote: My own MinGW install dates from the 2002/2003 time frame. :-) At the time MinGW/MSYS was a simple install. Nowadays it seems to be all jumbled up so I have not tried to cross the hurdle of an update. Yes, the MinGW download site is a disaster, thanks to SF

Re: Status of the MSYS/MSVC port

Roumen Petrov wrote: I think that we has to be careful about structure _stat and version of msvcrt (=8.0) - it depend from definition of time_t 32/64 bit and the size is deferent depending from an another macro. May be wrapper has to include MSVC headers. This is all moot. We (libtool's

Re: Pings

Akim Demaille wrote: Le 29 janv. 09 à 19:22, Ralf Wildenhues a écrit : For this one I'd prefer if Charles and/or Peter took care of it, they have a bunch of changes in this area and some discussion going on. Actually, I'd prefer to just be able to say go! once y'all have agreed on a common

Re: Pings

a bunch of changes in this area and some discussion going on. Actually, I'd prefer to just be able to say go! once y'all have agreed on a common set of changes. :-) My set of changes were already pushed (0aef3579..6631e515) 2009-01-24 Charles Wilson ... [cygwin|mingw] cwrapper cleanups

Re: Status of the MSYS/MSVC port

Ralf Wildenhues wrote: * Peter Rosin wrote on Thu, Jan 29, 2009 at 06:53:48PM CET: But maybe, just maybe, you don't have a desperate need to do -std=c89 -Werror :-) Guys, if all you're working around is -Werror, then stop right now. Just eliminate -Werror from $LTCC $LTCFLAGS and be done

Re: [PATCH] [cygwin]: Add cross-compile support to cwrapper

Charles Wilson wrote: In fact, maybe I should add $opt_debug to the new func_to_host_path[list] functions... Addressed in the attached revision. cygwin-native testsuite behavior is as expected.q still true. mingw-native (e.g. msys-mingw) testsuite behavior is as expected. still true

Re: [PATCH] Document and test LT_DEBUGWRAPPER cwrapper macro

Charles Wilson wrote: * tests/cwrapper.test: Add new test for -DLT_DEBUGWRAPPER. * doc/libtool.texi [Linking executables]: Mention wrapper executables, in addition to wrapper scripts. Add menu referencing subsection 'Wrapper executables for programs'. [Wrapper executables for programs]: New

<    1   2   3   4   5   6   >