Re: RFC: rethink horizontal alignment of mid-staff bar numbers

2020-11-15 Thread David Nalesnik
On Sun, Nov 15, 2020 at 6:11 AM Michael Käppler wrote: > > Am 15.11.2020 um 12:36 schrieb Werner LEMBERG: > >> I will be the first responder and say that, of the options in the > >> pdf, I think Gould is the most appropriate. > > Yep. > +1 > > > > > > Werner > > > > Another vote for Gould.

Re: 2.21.0 released

2020-04-09 Thread David Nalesnik
On Thu, Apr 9, 2020 at 1:42 PM Valentin Villenave wrote: > > On 4/9/20, Carl Sorensen wrote: > > Thank you so much for your dedication! > > Ditto; Phil, you and James may both have the most thankless and yet > crucial jobs in the LilyPond community, so praises to you both! (And > obviously to

website issue

2020-03-25 Thread David Nalesnik
I'm getting some spurious characters at http://lilypond.org/manuals.html. Screenshot attached. Here's some of the page source: bLearning: a must-read gentle introduction to LilyPond. (details of Learning) Thanks, David

Re: Add Code of Conduct (issue 575620043 by janek.lilyp...@gmail.com)

2020-02-05 Thread David Nalesnik
On Wed, Feb 5, 2020 at 7:37 PM Thomas Morley wrote: > > Hi all, > > Being on the lists for many years now I remember only a few posts > which were inappropriate: > > Long time ago. there was a user with a post others felt uncomfortable > with. But Graham denied a problem. But there was a followup

Re: Add Code of Conduct (issue 575620043 by janek.lilyp...@gmail.com)

2020-02-05 Thread david . nalesnik
On 2020/02/05 18:17:25, c_sorensen wrote: > > On 2/5/20, 7:40 AM, "lilypond-devel on behalf of David Kastrup" > > wrote: > > Mike Solomon writes: > > > Janek

Re: Janek is coming back to LilyPond! :-)

2020-01-20 Thread David Nalesnik
On Mon, Jan 20, 2020 at 10:37 AM Janek Warchoł wrote: > > Hi everyone, > > for those who don't know me: I was an active member of the community > several years ago, contributed patches, co-authored LilyPond blog, and > together > with Urs Liska

Re: [Notensatz im 21. Jahrhundert] Lily+Scheme bootcamp?

2020-01-15 Thread David Nalesnik
On Tue, Jan 14, 2020 at 10:38 PM Kieren MacMillan wrote: > > Hi Harm, > > > my talk would be probably of some interest for you. > > It absolutely is. =) > > > Alas, it will be in german, so I can't imagine how helpful it would be for > > you. > > Ja, es ist so lange her, dass ich Deutsch

Re: shepherd a patch?

2019-12-02 Thread David Nalesnik
Hi Trevor, On Sun, Dec 1, 2019 at 9:24 PM Trevor Bača wrote: > > Hi David (and Kieren and Urs), > > Awesome. I'll look forward to using measure-attached spanners, too. > > Trevor. > If you build from current master, you can use them now. Patch has been pushed! David

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

2019-11-21 Thread david . nalesnik
Reviewers: lemzwerg, carl.d.sorensen_gmail.com, Dan Eble, thomasmorley651, t.daniels_treda.co.uk, kieren_kierenmacmillan.info, c_sorensen, checkma, Message: Name has been changed to MeasureSpanner, and all references (including file names) have been adjusted. Thanks for the reviews!

Re: problem with git pull -r

2019-11-21 Thread David Nalesnik
On Thu, Nov 21, 2019 at 9:45 AM Jonas Hahnfeld wrote: > > Am Donnerstag, den 21.11.2019, 16:30 +0100 schrieb Werner LEMBERG: > > > Below is the console output. Any ideas? > > > > > > Clone the repository anew, and everything should be fine again. > > This works of course but is pretty

problem with git pull -r

2019-11-21 Thread David Nalesnik
Below is the console output. Any ideas? Thanks, David [dev@lilydev:lilypond-git]$ git pull -r error: cannot lock ref 'refs/remotes/origin/dev/jmandereau/merge-make-and-stepmake': 'refs/remotes/origin/dev/jmandereau' exists; cannot create

Re: shepherd a patch?

2019-11-16 Thread David Nalesnik
Thanks, James! On Sat, Nov 16, 2019 at 4:07 AM James wrote: > > David, > > On 15/11/2019 13:31, David Nalesnik wrote: > > On Fri, Nov 15, 2019 at 4:31 AM James Lowe wrote: > >> David et al. > >> > >> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska &

Re: shepherd a patch?

2019-11-15 Thread David Nalesnik
James and all, On Fri, Nov 15, 2019 at 7:31 AM David Nalesnik wrote: > > On Fri, Nov 15, 2019 at 4:31 AM James Lowe wrote: > > > > David et al. > > > > > > Am 15.11.19 um 04:10 schrieb David Nalesnik: > > > > Would someone be willing to shepherd

Re: shepherd a patch?

2019-11-15 Thread David Nalesnik
Federico, On Fri, Nov 15, 2019 at 6:39 AM Federico Bruni wrote: > > This is what's recommended in the README: > https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container > I saw this, but I'm running LilyDev from a Win10 host. David

Re: shepherd a patch?

2019-11-15 Thread David Nalesnik
On Fri, Nov 15, 2019 at 12:33 AM Urs Liska wrote: > > Hi David, > > I feel responsible for this because I know where this is coming from ;-) Hah! :) (Seriously, though, this is something that I've wanted and Kieren has clamored for...) > > You can send me the patch. However, it's a long time

Re: shepherd a patch?

2019-11-15 Thread David Nalesnik
the patch. However, it's a long time since I uploaded > > anything, so I'm not sure my set-up still works. But I'll try. > > > > Best > > Urs > > > > Am 15.11.19 um 04:10 schrieb David Nalesnik: > > > Hi all, > > > > > > I have a patch whic

Re: shepherd a patch?

2019-11-15 Thread David Nalesnik
On Fri, Nov 15, 2019 at 2:19 AM Jonas Hahnfeld wrote: > > Hi David, > > Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik: > > Hi all, > > > I have a patch which implements measure-attached spanners. I am > > having a devil of a time getting t

shepherd a patch?

2019-11-14 Thread David Nalesnik
Hi all, I have a patch which implements measure-attached spanners. I am having a devil of a time getting the patch up for review. I simply can't get git-cl to upload it. (I suspect this has something to do with the number of files it touches--my system times out before everything can be

Re: git-cl command not found

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 7:05 PM David Kastrup wrote: > > David Nalesnik writes: > > > Trying to get git-cl going I run into an interesting problem. I've > > installed LilyDev, so I should have git-cl. > > > > I update: > > [dev@lilydev:lilypond-git]$ cd

git-cl command not found

2019-11-14 Thread David Nalesnik
Trying to get git-cl going I run into an interesting problem. I've installed LilyDev, so I should have git-cl. I update: [dev@lilydev:lilypond-git]$ cd ~/git-cl/ [dev@lilydev:git-cl]$ git pull remote: Enumerating objects: 4, done. remote: Counting objects: 100% (4/4), done. remote: Compressing

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 9:58 PM David Nalesnik wrote: > > On Thu, Nov 14, 2019 at 9:49 PM Werner LEMBERG wrote: > > > > > > >> There is git-fsck . > > >> > > > > > > [dev@lilydev:lilypond-git]$ git fsck > > > Segmentation

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 9:49 PM Werner LEMBERG wrote: > > > >> There is git-fsck . > >> > > > > [dev@lilydev:lilypond-git]$ git fsck > > Segmentation faultrectories: 45% (116/256) > > Ouch. I've never experienced such a thing with git. Maybe something > is broken with your installation? Does

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
Good god On Thu, Nov 14, 2019 at 6:36 PM David Kastrup wrote: > > There is git-fsck . > [dev@lilydev:lilypond-git]$ git fsck Segmentation faultrectories: 45% (116/256)

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 10:21 AM Federico Bruni wrote: > > > Il giorno gio 14 nov 2019 alle 10:17, David Nalesnik > ha scritto: > > On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik > > wrote: > >> > >> On Thu, Nov 14, 2019 at 9:23 AM David Kastrup

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 10:19 AM David Nalesnik wrote: > > On Thu, Nov 14, 2019 at 10:17 AM David Nalesnik > wrote: > > > > On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik > > wrote: > > > > > > On Thu, Nov 14, 2019 at 9:23 AM David Kastrup wrote: &

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 10:17 AM David Nalesnik wrote: > > On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik > wrote: > > > > On Thu, Nov 14, 2019 at 9:23 AM David Kastrup wrote: > > > > > > Rather sounds like a different problem like a dead server/connectio

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik wrote: > > On Thu, Nov 14, 2019 at 9:23 AM David Kastrup wrote: > > > > Rather sounds like a different problem like a dead server/connection. > > Try again? > > Same result And in fact any git command I try yields

Re: problems with SSH key

2019-11-14 Thread David Nalesnik
On Thu, Nov 14, 2019 at 9:23 AM David Kastrup wrote: > > David Nalesnik writes: > > > Hi all, > > > > I'm having difficulty getting my LilyDev machine to work with SSH. > > I've followed the steps in the Contributor's Guide. Below is what > > happ

problems with SSH key

2019-11-14 Thread David Nalesnik
@lilydev:lilypond-git]$ git config --list user.name=David Nalesnik user.email=david.nales...@gmail.com color.ui=auto rietveld.server=codereview.appspot.com rietveld.cc=lilypond-devel@gnu.org branch.staging.remote=origin branch.staging.merge=refs/heads/staging core.repositoryformatversion=0

Re: can't update makeinfo from 5.1

2019-11-01 Thread David Nalesnik
On Fri, Nov 1, 2019 at 5:12 AM Werner LEMBERG wrote: > > > > When I run configure, an error is returned saying that makeinfo is > > too old (5,2). When I run sudo apt-get install texinfo, I'm told > > that I have the latest version. makeinfo --version still returns > > 5.2. > > Ouch.

can't update makeinfo from 5.1

2019-10-31 Thread David Nalesnik
Hi all, I've been out of the loop for a while, and recently decided to finish work on a patch I had put off. When I run configure, an error is returned saying that makeinfo is too old (5,2). When I run sudo apt-get install texinfo, I'm told that I have the latest version. makeinfo --version

Re: Can alternateTextSpannerEngraver now completely replace Text_spanner_engraver in a public release?

2019-02-13 Thread David Nalesnik
David, On Wed, Feb 13, 2019 at 8:35 AM David Kastrup wrote: > > David Nalesnik writes: > > > On Wed, Feb 13, 2019 at 7:49 AM Trevor Bača wrote: > >> > >> Could somebody else possibly provide James a patch of David N.'s > >> alternateTextSpannerEng

Re: Can alternateTextSpannerEngraver now completely replace Text_spanner_engraver in a public release?

2019-02-13 Thread David Nalesnik
On Wed, Feb 13, 2019 at 7:49 AM Trevor Bača wrote: > > On Wed, Feb 13, 2019 at 4:58 AM James Lowe wrote: > > > Hello Trevor, > > > > On Tue, 12 Feb 2019 16:45:35 -0600, Trevor Bača > > wrote: > > > > > > > > > > Question: is it now possible to replace Text_spanner_engraver with David > > > N.'s

Re: Anybody has a good explanation for _this_ use of grob-transformer?

2018-01-29 Thread David Nalesnik
Hi, On Mon, Jan 29, 2018 at 6:10 PM, David Kastrup wrote: > David Kastrup writes: > >>> %% no fail >>> \override TupletNumber.Y-offset = >>>#(ly:make-unpure-pure-container >>> (lambda (grob) (+ (ly:tuplet-number::calc-y-offset grob) 1)) >>>

Re: Issue 5187 Add command for Thin Aiken noteheads (issue 326510043 by karlinh...@gmail.com)

2017-09-22 Thread David Nalesnik
Hi Karlin, On Fri, Sep 22, 2017 at 5:29 PM, Karlin High wrote: > On Fri, Sep 22, 2017 at 2:37 PM, Karlin High wrote: >> All right, I'm giving up and asking for help. > > I got good help from Carl Sorenson; thanks! Changed patch for review, > now

Re: rest/mm-rest-markup

2017-08-10 Thread David Nalesnik
On Mon, Jul 31, 2017 at 11:53 AM, Thomas Morley <thomasmorle...@gmail.com> wrote: > 2017-07-31 18:09 GMT+02:00 David Kastrup <d...@gnu.org>: >> David Nalesnik <david.nales...@gmail.com> writes: >> >>> On Mon, Jul 31, 2017 at 9:08 AM, David Kastru

Re: rest/mm-rest-markup

2017-07-31 Thread David Nalesnik
new thread, because this one will be about rest-markups only. >> >> rest-by-number-markup and rest-markup were impemented by myself >> commit ffa21bb1a55d2436bb432c4dff7ec04df95dc6f0 >> My second patch at all. > > Ah, I thought that it wasn't quite in the line of code I

Re: Should we have a from-barline property in analogy to to-barline ?

2017-07-24 Thread David Nalesnik
On Jul 24, 2017 10:50 AM, "Kieren MacMillan" wrote: Hi Simon, > On 24.07.2017 13:58, David Kastrup wrote: >> Seems like an obvious addition. Would make stuff (like slurs, hairpins >> and so on) starting at the bar move backwards to the bar line. Probably >> also

Re: lyrics hyphens question

2017-06-13 Thread David Nalesnik
On Jun 13, 2017 9:55 PM, "Kieren MacMillan" wrote: Hi David (et al.), > It's not suitable as is, but easily remedied. The grob LyricWord is > defined in a hackish way so that it can fit in an LY file. So in C++, it would be non-hackish…? No, just parceling out

Re: lyrics hyphens question

2017-06-13 Thread David Nalesnik
Hi Kieren, On Tue, Jun 13, 2017 at 3:21 PM, Kieren MacMillan wrote: > Hi David (et al.), > > These are questions regarding the "lyric-word-reconstituter" in the thread > which includes the post >

Fix typos in \offset documentation (issue 322040043 by david.nales...@gmail.com)

2017-06-07 Thread david . nalesnik
Reviewers: , Description: Fix typos in \offset documentation - Fix errors in description of OttavaBracket example - Minor improvements in wording Please review this at https://codereview.appspot.com/322040043/ Affected files (+5, -4 lines): M Documentation/notation/changing-defaults.itely

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

2017-05-23 Thread david . nalesnik
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167 scm/scheme-engravers.scm:167: (lambda (rest) (ly:grob-set-property! rest 'Y-offset

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

2017-05-20 Thread david . nalesnik
Looks much better -- see comments below. https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167 scm/scheme-engravers.scm:167: (lambda (rest)

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

2017-05-18 Thread david . nalesnik
https://codereview.appspot.com/321930043/diff/60001/ly/init.ly File ly/init.ly (right): https://codereview.appspot.com/321930043/diff/60001/ly/init.ly#newcode36 ly/init.ly:36: #(use-modules (scm merge-rests-engraver)) I'm not sure why you are defining a separate module. The usual procedure

Re: Calling in for sickness

2017-05-17 Thread David Nalesnik
David, On Mon, May 15, 2017 at 11:42 AM, David Kastrup wrote: > l > Hi folks, > > had a sort of apoplexy and will not be able to do anything while > recovering. I am hospitalized at the moment, CRT and MRT did not show > any specific anomalies but my right side is hampered and I

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 22:49:25, thomasmorley651 wrote: On 2017/04/28 22:27:12, david.nalesnik wrote: > On 2017/04/28 22:24:57, david.nalesnik wrote: > > On 2017/04/28 16:15:42, david.nalesnik wrote: > > > On 2017/04/28 15:50:52, dak wrote: > > > > Does an extra-offset in X direction even make sense when

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 22:24:57, david.nalesnik wrote: On 2017/04/28 16:15:42, david.nalesnik wrote: > On 2017/04/28 15:50:52, dak wrote: > > Does an extra-offset in X direction even make sense when the systems are > spaced > > according to their skylines _before_ the extra-offset is applied? > > Well,

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 16:15:42, david.nalesnik wrote: On 2017/04/28 15:50:52, dak wrote: > Does an extra-offset in X direction even make sense when the systems are spaced > according to their skylines _before_ the extra-offset is applied? Well, X-offset of line-break-system-details is applied in

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
On 2017/04/28 15:50:52, dak wrote: Does an extra-offset in X direction even make sense when the systems are spaced according to their skylines _before_ the extra-offset is applied? Well, X-offset of line-break-system-details is applied in make-page-stencil, too.

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-28 Thread david . nalesnik
Also added a "Changes" entry. Thanks! https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly File input/regression/page-layout-extra-offset.ly (right): https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly#newcode7

Re: Removing 2sd intervals

2017-04-27 Thread David Nalesnik
On Thu, Apr 27, 2017 at 5:43 PM, nycgdf wrote: > I don't know how to for-each on a music object. > > There are a number of useful functions: musicMap (defined in ly/music-functions-init.ly); for-some-music, map-some-music, fold-some-music (in scm/music-functions.scm). Maybe

Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-27 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Implement extra-offset for system positioning Add the property 'extra-offset to 'line-break-system-details. It is possible to position systems absolutely using the properties 'X-offset and 'Y-offset of 'line-break-system-details.

Re: Improve elbowed-hairpin (issue 324800043 by thomasmorle...@gmail.com)

2017-04-25 Thread david . nalesnik
LGTM. (Aside from docstring change which you could make when pushing.) https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm#newcode1170 scm/output-lib.scm:1170: Returns a

Re: Improve elbowed-hairpin (issue 324800043 by thomasmorle...@gmail.com)

2017-04-24 Thread david . nalesnik
LGTM. I've pointed out two minor issues, but I don't believe they should hold up the review process. By the way, applying \override Hairpin.style = #'dashed-line to the regtest input/regression/ferneyhough-hairpins.ly looks great!

Re: Fix not scaling stem in note-by-number-markup (issue 324780043 by thomasmorle...@gmail.com)

2017-04-20 Thread david . nalesnik
LGTM. https://codereview.appspot.com/324780043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: pdf changes every few compilations, although changing nothing

2017-04-10 Thread David Nalesnik
On Mon, Apr 10, 2017 at 7:43 AM, David Nalesnik <david.nales...@gmail.com> wrote: > On Mon, Apr 10, 2017 at 7:21 AM, Thomas Morley <thomasmorle...@gmail.com> > wrote: >> 2017-04-10 14:09 GMT+02:00 David Nalesnik <david.nales...@gmail.com>: >>> On Mon,

Re: pdf changes every few compilations, although changing nothing

2017-04-10 Thread David Nalesnik
On Mon, Apr 10, 2017 at 7:21 AM, Thomas Morley <thomasmorle...@gmail.com> wrote: > 2017-04-10 14:09 GMT+02:00 David Nalesnik <david.nales...@gmail.com>: >> On Mon, Apr 10, 2017 at 5:36 AM, Thomas Morley <thomasmorle...@gmail.com> >> wrote: > >

Re: pdf changes every few compilations, although changing nothing

2017-04-10 Thread David Nalesnik
On Mon, Apr 10, 2017 at 5:36 AM, Thomas Morley wrote: > Hi all, > > with the code below I experienced some pretty strange behaviour. > > The visual output changes every few compilations, although I changed > _nothing_!! > In average two times in 10 compilations. > > >

Re: Add scriptExceptions property/convenience functions (issue 324740043 by david.nales...@gmail.com)

2017-04-07 Thread david . nalesnik
On 2017/04/07 17:30:25, dak wrote: On 2017/04/05 15:55:38, david.nalesnik wrote: > On 2017/04/05 15:47:19, pkx166h wrote: > > Do you want this tested? > > > > I cannot see any tracker issue for this. > > > > Or is this just some work-in-progress design before you have a patch for > testing > >

Re: Add scriptExceptions property/convenience functions (issue 324740043 by david.nales...@gmail.com)

2017-04-05 Thread david . nalesnik
On 2017/04/05 15:47:19, pkx166h wrote: Do you want this tested? I cannot see any tracker issue for this. Or is this just some work-in-progress design before you have a patch for testing proper? James It's associated with Issue 4276. It would be great if you could test this. I do

Add scriptExceptions property/convenience functions (issue 324740043 by david.nales...@gmail.com)

2017-04-04 Thread david . nalesnik
Reviewers: , Message: I've noticed that setting some properties with this patch doesn't have an effect: for example, rotation and staff-padding. Is the best way to approach this issue through the tweak method linked to in the description on the issue tracker? Description: Add scriptExceptions

Implement spacing-pair for MeasureCounter (issue 319610043 by david.nales...@gmail.com)

2017-03-30 Thread david . nalesnik
Reviewers: , Message: Please review -- thanks! Description: Implement spacing-pair for MeasureCounter Since MeasureCounter grobs are bounded by columns, sophisticated horizontal positioning is available relative to "prefatory materials" (such as barlines, clefs, and key signatures) at the

Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

2017-03-29 Thread david . nalesnik
On 2017/03/29 22:00:12, pkx166h wrote: > > Sorry, I mean the *first* snippet. (The count that begins with two could be > pushed further from the staff possibly.) Yes that is probably a good idea (if you could add something that would normally collide - would a slur/tie *over* one of the

Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

2017-03-29 Thread david . nalesnik
On 2017/03/29 12:40:32, david.nalesnik wrote: On 2017/03/29 11:08:17, simon.albrecht wrote: > I’m not sure if a doc snippet is really necessary. Using staff-padding is > explained in > and >

Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

2017-03-29 Thread david . nalesnik
On 2017/03/29 11:08:17, simon.albrecht wrote: I’m not sure if a doc snippet is really necessary. Using staff-padding is explained in and

Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

2017-03-28 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Allow 'staff-padding to work with MeasureCounter -Set 'Y-offset in the grob description to the appropriate callback. (This is required for the default setting of 'staff-padding to have any effect.) -Provide a doc snippet to

Re: PATCHES - Countdown for Wednesday March 22nd

2017-03-23 Thread David Nalesnik
On Thu, Mar 23, 2017 at 3:17 PM, James <p...@gnu.org> wrote: > Hello, > > > On 22/03/17 15:32, Phil Holmes wrote: >> >> - Original Message - From: "David Nalesnik" >> <david.nales...@gmail.com> >> To: "James" <p...@gnu.

Re: PATCHES - Countdown for Wednesday March 22nd

2017-03-22 Thread David Nalesnik
Hi James, On Wed, Mar 22, 2017 at 2:27 AM, James wrote: > Hello, > > Here is the current patch countdown list. The next countdown will be on > March 25th > > > A quick synopsis of all patches currently in the review process can be > found here: > >

Issue 5097: reach HorizontalBracketText through directed tweak (issue 317460043 by david.nales...@gmail.com)

2017-03-21 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Issue 5097: reach HorizontalBracketText through directed tweak HorizontalBracketText is now caused by HorizontalBracket, rather than the same note-grouping event. Fix a number of programming errors caused by commit for Issue 5064.

Re: checking grob type

2017-03-17 Thread David Nalesnik
On Fri, Mar 17, 2017 at 9:50 AM, Paul <p...@paulwmorris.com> wrote: > cc'ing lilypond-devel to move discussion there. > > On 03/17/2017 09:38 AM, David Nalesnik wrote: > >> You can get more info about public functions with the attached file. >> I was pla

Fix dashed line errors (issue 320320043 by david.nales...@gmail.com)

2017-03-06 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Fix dashed line errors There are two errors in lily/line-interface.cc which cause dashed lines to be drawn inaccurately. (1) Line-thickness is improperly subtracted from the "off" value in Line_interface::make_dashed_line. This was

Create Bracket class (issue 314610043 by david.nales...@gmail.com)

2017-03-06 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Create Bracket class Code involving brackets suffers from two confusing organizational issues: (1) Tuplet_bracket::make_bracket is used to create brackets for a number of grobs: BassFigureBracket, HorizontalBracket, OttavaBracket,

Re: can't upload a patch

2017-03-06 Thread David Nalesnik
On Mon, Mar 6, 2017 at 8:56 AM, David Kastrup <d...@gnu.org> wrote: > David Nalesnik <david.nales...@gmail.com> writes: > >> On Mon, Mar 6, 2017 at 8:29 AM, Federico Bruni <f...@inventati.org> wrote: >>> >>> >>> Il giorno lun 6 mar 2017 all

Re: can't upload a patch

2017-03-06 Thread David Nalesnik
On Mon, Mar 6, 2017 at 8:29 AM, Federico Bruni <f...@inventati.org> wrote: > > > Il giorno lun 6 mar 2017 alle 14:50, David Nalesnik > <david.nales...@gmail.com> ha scritto: >> >> Hi Federico, >> >> On Mon, Mar 6, 2017 at 1:15 AM, Federico Bruni <

Re: can't upload a patch

2017-03-06 Thread David Nalesnik
Hi Federico, On Mon, Mar 6, 2017 at 1:15 AM, Federico Bruni <f...@inventati.org> wrote: > Do you have ca-certificates installed? Yes, the newest version: ca-certificates/now 20141019+deb8u1 all [installed,local] > > Il 6 marzo 2017 01:23:26 CET, David Nalesnik <david.nale

can't upload a patch

2017-03-05 Thread David Nalesnik
Not too long ago, I wrote to the list about an inability to upload patches. A Rietveld tracker issue is created, but the process terminates before all of the base files can be uploaded. An Allura issue is never created. I was using a VirtualBox VM on a Windows 10 system. Now, on a different

Re: trouble uploading a patch

2017-02-20 Thread David Nalesnik
Hi Harm, On Feb 20, 2017 3:19 PM, "Thomas Morley" wrote: 2017-02-15 22:39 GMT+01:00 Thomas Morley : > 2017-02-15 0:53 GMT+01:00 Thomas Morley : > >>> OK--I've made a patch update based on the review comments so far.

Re: trouble uploading a patch

2017-02-14 Thread David Nalesnik
Hi Harm, On Thu, Feb 9, 2017 at 8:10 AM, David Nalesnik <david.nales...@gmail.com> wrote: > On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley <thomasmorle...@gmail.com> > wrote: >> 2017-02-08 14:37 GMT+01:00 David Nalesnik <david.nales...@gmail.com>: >> >>

Re: trouble uploading a patch

2017-02-09 Thread David Nalesnik
On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley <thomasmorle...@gmail.com> wrote: > 2017-02-08 14:37 GMT+01:00 David Nalesnik <david.nales...@gmail.com>: > >> I notice that the patch has gotten swept up into the review process. >> If you like, I will tell Ja

Re: trouble uploading a patch

2017-02-08 Thread David Nalesnik
Hi Harm, On Tue, Feb 7, 2017 at 7:46 PM, Thomas Morley <thomasmorle...@gmail.com> wrote: > 2017-02-08 0:08 GMT+00:00 David Nalesnik <david.nales...@gmail.com>: >> Harm, >> >> On Tue, Feb 7, 2017 at 5:57 PM, Thomas Morley <thomasmorle...@gmail.com> >&g

Re: trouble uploading a patch

2017-02-04 Thread David Nalesnik
On Sat, Feb 4, 2017 at 7:02 PM, David Nalesnik <david.nales...@gmail.com> wrote: > On Sat, Feb 4, 2017 at 6:45 PM, David Kastrup <d...@gnu.org> wrote: >> David Nalesnik <david.nales...@gmail.com> writes: >> >>> On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup

Re: trouble uploading a patch

2017-02-04 Thread David Nalesnik
On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup <d...@gnu.org> wrote: > David Nalesnik <david.nales...@gmail.com> writes: > >> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik <david.nales...@gmail.com> >> wrote: >>> On Fri, Feb 3, 2017 at 7:27 PM, David

Re: trouble uploading a patch

2017-02-04 Thread David Nalesnik
On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik <david.nales...@gmail.com> wrote: > On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik <david.nales...@gmail.com> > wrote: >> Hi, >> >> I'm trying to upload a patch for review, and I'm running into difficulties. &

Re: trouble uploading a patch

2017-02-03 Thread David Nalesnik
On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik <david.nales...@gmail.com> wrote: > Hi, > > I'm trying to upload a patch for review, and I'm running into difficulties. > > Using git-cl, I get this output: > > Issue created. URL: http://codereview.appspot.com/3201

trouble uploading a patch

2017-02-03 Thread David Nalesnik
Hi, I'm trying to upload a patch for review, and I'm running into difficulties. Using git-cl, I get this output: Issue created. URL: http://codereview.appspot.com/320140043 Uploading base file for Documentation/changes.tely Uploading base file for scm/define-grob-properties.scm Uploading base

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-26 Thread david . nalesnik
https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely#newcode2777

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-25 Thread david . nalesnik
On 2017/01/25 20:43:23, david.nalesnik wrote: diagram syntax, other improvements This is as clear as I can make this I think, so I will resist the temptation to post a follow-up patch in case reviewers would like to comment! https://codereview.appspot.com/319150043/

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
On 2017/01/24 23:32:51, t.daniels_treda.co.uk wrote: mailto:david.nales...@gmail.com wrote Tuesday, January 24, 2017 10:57 PM > Question: > > How do I get a backslash in @subsubsubheading{} ? > > The literal symbol doesn't show up, and @backslashchar{} displays > @backslashchar{} From

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
Question: How do I get a backslash in @subsubsubheading{} ? The literal symbol doesn't show up, and @backslashchar{} displays @backslashchar{} https://codereview.appspot.com/319150043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
I've posted an extensive rewrite which hopefully addresses all the concerns. I think the result is a lot more user-friendly. Note that I did not change the argument-name "offsets". My preference would be to use "displacements" here, because I think it is exactly expressive of its use. The

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
Thanks so such for the detailed review! Will post a patch update in the near future. https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right):

Re: PATCHES - Countdown for Tuesday January 24

2017-01-24 Thread David Nalesnik
On Tue, Jan 24, 2017 at 7:38 AM, James <p...@gnu.org> wrote: > Hello David, > > On Tue, 24 Jan 2017 07:05:24 -0600 > David Nalesnik <david.nales...@gmail.com> wrote: > >> > >> >> Would you add >> >> 3830 Documentation for \offset is requ

Re: PATCHES - Countdown for Tuesday January 24

2017-01-24 Thread David Nalesnik
s/5034 > http://codereview.appspot.com/313380043 > > > 185 RhythmicStaff squishing chords should produce single notes - Trevor > Daniels https://sourceforge.net/p/testlilyissues/issues/185 > http://codereview.appspot.com/6495107 > > > Review: > > > 5040 Let \alterBroke

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-24 Thread david . nalesnik
https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik
On 2017/01/23 19:00:43, david.nalesnik wrote: No problem. https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik
No problem. https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107 ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item

Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Let \alterBroken tweak ties again When tweaking Tie grobs, the music function \alterBroken has incorrectly rejected them since 2.17.6 as not being spanners. The method of spanner recognition is at fault: 'span-direction is not used by

Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-22 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Issue 3830: Document \offset command Please review this at https://codereview.appspot.com/319150043/ Affected files (+142, -0 lines): M Documentation/notation/changing-defaults.itely

Re: Can someone run makelsr on staging please?

2017-01-22 Thread David Nalesnik
On Sun, Jan 22, 2017 at 8:33 AM, David Nalesnik <david.nales...@gmail.com> wrote: > On Sun, Jan 22, 2017 at 8:20 AM, David Kastrup <d...@gnu.org> wrote: >> David Nalesnik <david.nales...@gmail.com> writes: >> >>> On Sun, Jan 22, 2017 at 7:45

Re: Can someone run makelsr on staging please?

2017-01-22 Thread David Nalesnik
On Sun, Jan 22, 2017 at 8:20 AM, David Kastrup <d...@gnu.org> wrote: > David Nalesnik <david.nales...@gmail.com> writes: > >> On Sun, Jan 22, 2017 at 7:45 AM, James <p...@gnu.org> wrote: >>> Hello, >>> >>> David Nalesnik checked in a co

  1   2   3   4   5   >