Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-10 Thread thomasmorley65
On 2017/04/09 20:30:45, dak wrote: Fix the error behavior, rename \voicify to \voices Error handling is nice now. { \voices 1 << e''2 \\ a \\ c'' \\ a' >> \voices 1,2 << e'' \\ a \\ c'' \\ a' >> \voices 1,2,3 << e'' \\ a \\ c'' \\ a' >> } returns appropriate warnings. The visual

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread David Kastrup
David Kastrup writes: > thomasmorle...@gmail.com writes: > >> I then would have expected the following to work (with a warning): >> >> { \voicify 1 << a' \\ c' >> } >> >> instead I get: >> >> $ lilypond-git atest-54.ly >> GNU LilyPond 2.19.59 >> Processing `atest-54.ly' >>

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread David Kastrup
thomasmorle...@gmail.com writes: > I then would have expected the following to work (with a warning): > > { \voicify 1 << a' \\ c' >> } > > instead I get: > > $ lilypond-git atest-54.ly > GNU LilyPond 2.19.59 > Processing `atest-54.ly' >

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread thomasmorley65
On 2017/04/09 15:13:32, dak wrote: mailto:thomasmorle...@gmail.com writes: > Great! > > Two thoughts: > > (1) > it's a common request on the user list how to continue a tie into the << > \\ >> - construct. > I'm aware we explain it at the lines of "don't use the > double-backslash". > Also,

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread thomasmorley65
On 2017/04/09 15:15:47, dak wrote: mailto:thomasmorle...@gmail.com writes: > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm > File scm/music-functions.scm (right): > > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm#newcode968 >

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread Thomas Morley
2017-04-09 18:23 GMT+02:00 Trevor Daniels : > > David Kastrup wrote Sunday, April 09, 2017 5:14 PM >> >> Harm brought a few points, one concerning different warning/error >> behavior (and with regard to the _text_ of the existing warning, I will >> cede the point thought

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread Werner LEMBERG
> So how to proceed? [...] +1 for \voices. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread Trevor Daniels
David Kastrup wrote Sunday, April 09, 2017 5:14 PM > > Harm brought a few points, one concerning different warning/error > behavior (and with regard to the _text_ of the existing warning, I will > cede the point thought there isn't yet a proposal for \voices as far as > I can see). He also

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread David Kastrup
What now? I have a few suggestions I don't agree with really and don't know whether there is more of a discussion warranted now. Harm brought a few points, one concerning different warning/error behavior (and with regard to the _text_ of the existing warning, I will cede the point thought there

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread David Kastrup
thomasmorle...@gmail.com writes: > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm > File scm/music-functions.scm (right): > > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm#newcode968 > scm/music-functions.scm:968: > On 2017/04/08

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread David Kastrup
thomasmorle...@gmail.com writes: > Great! > > Two thoughts: > > (1) > it's a common request on the user list how to continue a tie into the << > \\ >> - construct. > I'm aware we explain it at the lines of "don't use the > double-backslash". > Also, how to use named voices is explained, iirc. > >

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-09 Thread David Kastrup
Carl Sorensen writes: > How about > > \voiceOrder > > and > > \defaultVoiceOrder > > ? The first is even less likely to suggest that it applies only to the following single music expression rather than several ones than just \voices would be. -- David Kastrup

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-08 Thread thomasmorley65
https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm#newcode968 scm/music-functions.scm:968: On 2017/04/08 12:02:45, thomasmorley651 wrote: Why not throw an

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-08 Thread thomasmorley65
Great! Two thoughts: (1) it's a common request on the user list how to continue a tie into the << \\ >> - construct. I'm aware we explain it at the lines of "don't use the double-backslash". Also, how to use named voices is explained, iirc. Though, I'd like to see an explicit example like

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-07 Thread Carl Sorensen
On 4/7/17 2:15 PM, "lilypond-devel on behalf of David Kastrup" wrote: >"Trevor Daniels" writes: > >>One argument in favor of \voicify would be that \voices sounds like >setting a state rather

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-07 Thread Trevor Daniels
David Kastrup wrote Friday, April 07, 2017 9:07 PM > "Trevor Daniels" writes: > >> David, you wrote Thursday, April 06, 2017 4:54 PM >> >>> You could try separate commands \voicifyUp and \voicifyDown . I am not >>> sure whether or not \voicify should not be \voices or

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-07 Thread Urs Liska
Am 07.04.2017 um 22:07 schrieb David Kastrup: > "Trevor Daniels" writes: > >> David, you wrote Thursday, April 06, 2017 4:54 PM >> >>> You could try separate commands \voicifyUp and \voicifyDown . I am not >>> sure whether or not \voicify should not be \voices or

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-07 Thread David Kastrup
"Trevor Daniels" writes: > David, you wrote Thursday, April 06, 2017 4:54 PM > >> You could try separate commands \voicifyUp and \voicifyDown . I am not >> sure whether or not \voicify should not be \voices or \voicing or >> \voicings instead, possibly making for nicer

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-07 Thread David Kastrup
"Trevor Daniels" writes: > David, you wrote Thursday, April 06, 2017 4:54 PM > >> You could try separate commands \voicifyUp and \voicifyDown . I am not >> sure whether or not \voicify should not be \voices or \voicing or >> \voicings instead, possibly making for nicer

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-07 Thread Trevor Daniels
David, you wrote Thursday, April 06, 2017 4:54 PM > You could try separate commands \voicifyUp and \voicifyDown . I am not > sure whether or not \voicify should not be \voices or \voicing or > \voicings instead, possibly making for nicer compounds like that. > > I mean, something like > >

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-06 Thread David Kastrup
David Kastrup writes: > Urs Liska writes: > >> I've only read the documentation, and I agree with Trevor that this is a >> real improvement. >> >> One question/suggestion: Would it be possible to have \voicify accept a >> single symbol with a "pattern", which

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-06 Thread David Kastrup
Urs Liska writes: > I've only read the documentation, and I agree with Trevor that this is a > real improvement. > > One question/suggestion: Would it be possible to have \voicify accept a > single symbol with a "pattern", which should allow two entries like > #'top-bottom

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-06 Thread Urs Liska
I've only read the documentation, and I agree with Trevor that this is a real improvement. One question/suggestion: Would it be possible to have \voicify accept a single symbol with a "pattern", which should allow two entries like #'top-bottom and #'bottom-top? This could count the number of

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-06 Thread tdanielsmusic
LGTM David, you've found an excellent way of squaring the circle! Trevor https://codereview.appspot.com/320820043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-03 Thread dak
On 2017/04/03 17:39:55, pkx166h wrote: Fails make doc. https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly#newcode2007

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-03 Thread pkx166h
Fails make doc. https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly#newcode2007 ly/music-functions-init.ly:2007: \\voicify 1,2,3 << @dots {}

Re: Add a \voicify command (issue 320820043 by d...@gnu.org)

2017-04-03 Thread lemzwerg
Very nice! https://codereview.appspot.com/320820043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel