Re: RFC: rethink horizontal alignment of mid-staff bar numbers

[David Nalesnik]

On Sun, Nov 15, 2020 at 6:11 AM Michael Käppler  wrote:
>
> Am 15.11.2020 um 12:36 schrieb Werner LEMBERG:
> >> I will be the first responder and say that, of the options in the
> >> pdf, I think Gould is the most appropriate.
> > Yep.
> +1
> >
> >
> >  Werner
> >
>
>

Another vote for Gould.  (Though does she have anything to say about
the normally unshown measure numbers which are stranded beyond the
line here?)

David

Re: 2.21.0 released

[David Nalesnik]

On Thu, Apr 9, 2020 at 1:42 PM Valentin Villenave
 wrote:
>
> On 4/9/20, Carl Sorensen  wrote:
> > Thank you so much for your dedication!
>
> Ditto; Phil, you and James may both have the most thankless and yet
> crucial jobs in the LilyPond community, so praises to you both! (And
> obviously to Jonas, David, Han-Wen & al.).
>

Yay!!

website issue

[David Nalesnik]

I'm getting some spurious characters at
http://lilypond.org/manuals.html.  Screenshot attached.

Here's some of the page source:
  bLearning:
a must-read gentle introduction to LilyPond.
(details of Learning)

Thanks,
David

Re: Add Code of Conduct (issue 575620043 by janek.lilyp...@gmail.com)

[David Nalesnik]

On Wed, Feb 5, 2020 at 7:37 PM Thomas Morley  wrote:
>
> Hi all,
>
> Being on the lists for many years now I remember only a few posts
> which were inappropriate:
>
> Long time ago. there was a user with a post others felt uncomfortable
> with. But Graham denied a problem. But there was a followup which
> definitely was.
> And Graham told the user that it was not appropriate. As a result the
> problem was cured.
>
> I once told a user myself not to write about politics. As a result the
> problem was solved.
>
> There was a user definitely offending all, especially developers.
> Several complaints were posted, even the list-admin was called, but he
> didn't ban him. Iirc, he recommended everyone who can't bear him, to
> set him on a blacklist. I may recall wrongly, but that's what I
> finally did.
> Sometime later this user stopped posting...
>
> If I remember correctly these are _all_ problematic posts (ofcourse I
> may have missed some)
> Do we need a CoC for them?
> I doubt.
> While I think that the proposed CoC-behaviour should be naturally, I'm
> uncomfortable with the proposed consequences for violating it. At
> least in the past we got back on track more or less pretty easily,
> without CoC.
>
> Now to David and his communication.
> I'm aware people often feel offended by him.
> Though, we all know or at least should know about his communication
> problems, I'm absolutely sure he knows about them, likely better than
> we.
>
> I always found that most of the bad feelings resulted of misunderstandings.
> Sometimes David misunderstood, and replied strange. Once his
> misunderstanding is cleared he usually corrects his post.
> Sometimes the recipient of his post _misunderstands_ a post as
> offending, while it is meant most simply as a description or
> recommendation.
>
> As an example look at the review of one of my own patches
> https://codereview.appspot.com/270640043
> Quoting dak:
> "This looks like a total mess."
> "Total waste of effort."
> "Aaand another one."
>
> Ofcourse quotation is without any context (you may red it up, if you want)
> You can _interpret_ this as trashing my patch at the worst, but  I'm
> used to take his posts literal, i.e.:
> It _was_ a "total mess" -> I improved the patch
> I argued against "waste of effort" -> convinced him
> And there _was_ another issue -> I improved the patch
>
> Finally the patch came through.
>
> I'd like to recommend that everyone argues with him, if you think he is wrong.
> Otherwise take his posts literal and _not_ offending.
>
>
>
>
> Am Do., 6. Feb. 2020 um 00:32 Uhr schrieb Janek Warchoł
> :
>
> > śr., 5 lut 2020 o 14:41 David Kastrup  napisał(a):
> >
> > > Janek Warchoł  writes:
> > > > In short, it's been found (I think Mike will be able to give you 
> > > > specific
> > > > examples) that having code of conduct encourages contributions from
> > > > newcomers.
> > >
> > > I rather think that a friendly atmosphere encourages contributions from
> > > newcomers.  Whether an upfront requirement to commit to a set of rules
> > > with an enforcement team is perceived as a guarantee of a friendly
> > > atmosphere is debatable. [...]
> > > the principal impact [of Code of Conduct] to be expected on
> > > LilyPond development appears to have an official body entitled to
> > > censure my behavior and eventually, out of a sense of duty, remove me.
> > >
> >
> > Do you think that approaching other people with suspicion like this (i.e.
> > expecting they have worst intentions, which is getting close to a
> > conspiracy theory) contributes to a friendly atmosphere? I don't think so.
>
> I would take David post _literal_
> He simply told us from his previous bad experiences and his feelings
> it may happen again here, now based on the proposed CoC.
>
> I would be very sad to loose him.
>
> > And honestly, I'm very sorry to read something like this from you. It made
> > me regret coming back to the project, and almost made me want to resign
> > again.
>
> I would be very sad to loose you (again) as well!
> Janek, I always had the feeling you love a community with all people
> "on the same track", though David is "special".
>
> So to repeat myself, everyone should take his post literal, not offending!
>
>
> I'd love to see a community bearing different personalities, even
> personalities with problematic conversation skills.
> For me it's like strange english from a non-native speaker (like me).
> It's sometimes difficult and/or tedious to understand but mostly worth
> the attention.
>
>
> Well, long mail for a non-native speaker, and I still have the feeling
> I didn't express myself very well.
> Though, I did the best I could.
>

+1

Thank you, Harm.

The other David

Re: Add Code of Conduct (issue 575620043 by janek.lilyp...@gmail.com)

[david . nalesnik]

On 2020/02/05 18:17:25, c_sorensen wrote:
> 
> On 2/5/20, 7:40 AM, "lilypond-devel on behalf of David Kastrup"
> 
> wrote:
> 
> Mike Solomon  writes:
> 
> > Janek Warchoł  writes:
> >
> >> Hi,
> >>
> >> śr., 5 lut 2020, 00:34 użytkownik  napisał:
> >>
> >>> What problem are we trying to solve here?
> >>>
> >>
> >> In short, it's been found (I think Mike will be able to give
you 
> >> specific
> >> examples) that having code of conduct encourages contributions
from 
> >> newcomers.
> >
> >> I rather think that a friendly atmosphere encourages
contributions
> >> from newcomers.  Whether an upfront requirement to commit to a
set
> >> of rules with an enforcement team is perceived as a guarantee
of a
> >> friendly atmosphere is debatable.
> >
> > I personally would feel more comfortable if there were a code of
> > conduct, and I know within my company one employee will not
attend a
> > conference or participate in a project unless there is a code of
> > conduct.  I don't have any hard stats to prove this, but have a
gut
> > feeling that a code of conduct opens more doors than it closes.
> 
> My gut feeling is the opposite.  Upon reading the Code of Conduct, it
felt to me
> like it was proposing a private channel for a mean-spirited
passive-aggressive
> person to wreak havoc on the community.
> 
> Now, I do not feel like we have any such individuals in our community.
 So in
> the best of all possible worlds, there is no harm to a code of
conduct.  But in
> the best of all possible worlds, there is also no need for a code of
conduct.
> 
> In the worst of all worlds, the lack of a Code of Conduct can lead to
individual
> bullying. In the worst of all worlds, a Code of Conduct can lead to
systematic
> bullying, where an anonymous complainer gets the weight of a
bureaucracy behind
> the bullying.
> 
> I don't believe we have the worst of all worlds.  I don't believe that
any
> individual behind the proposal for the Code of Conduct has anything
but the best
> intentions.  I want to see the LilyPond community be a friendly,
welcoming place
> for all.  I believe that it largely is a friendly, welcoming place for
all.
> 
> For me, personally, I find the Code of Conduct approach with its
implied threat
> (if you don't obey, we'll punish you -- in fact, we've spelled out the
> punishments in the document) to be much less friendly than a public
statement
> that we value an open, respectful, and friendly environment and we
call on all
> to participate in it.  The Code of Conduct approach feels like taking
a
> sledgehammer to squash a fly.

A statement about community values would be an excellent idea, but
channels for reporting and meting out punishment?  This makes me
uncomfortable.

And is this really such a large organization that we have room for
committees? 



https://codereview.appspot.com/575620043/

Re: Janek is coming back to LilyPond! :-)

[David Nalesnik]

On Mon, Jan 20, 2020 at 10:37 AM Janek Warchoł  wrote:
>
> Hi everyone,
>
> for those who don't know me: I was an active member of the community
> several years ago, contributed patches, co-authored LilyPond blog, and 
> together
> with Urs Liska 
> typeset
> an award-winning publication
> 
> with
> LilyPond. Since then I've pursued a career in software development.
>
> I just came back from music engraving conference organized by Werner and
> Urs (kudos to them!!), and - inspired by the people present there (most
> importantly Han-Wen, Mike Solomon and Kieren MacMillan) - I decided to get
> involved in the project again :-) I should be able to spend about 5-10
> hours a week on LilyPond.
>
> One of the topics discussed in Salzburg was making it easier to contribute
> to LilyPond. I have proposed to lead that effort, and the people present
> agreed to it. I would like to ask the full developer community for your
> trust*,* too. I will share my plans in a separate thread.
>
> cheers,
> Janek

Welcome back, Janek!

David

Re: [Notensatz im 21. Jahrhundert] Lily+Scheme bootcamp?

[David Nalesnik]

On Tue, Jan 14, 2020 at 10:38 PM Kieren MacMillan
 wrote:
>
> Hi Harm,
>
> > my talk would be probably of some interest for you.
>
> It absolutely is.  =)
>
> > Alas, it will be in german, so I can't imagine how helpful it would be for 
> > you.
>
> Ja, es ist so lange her, dass ich Deutsch gesprochen habe, dass ich fast 
> alles vergessen habe!! Doch ich werde da sein.

Ich auch, but oh, I wish I could be there!  Good luck to you and all!

Best,
David

Re: shepherd a patch?

[David Nalesnik]

Hi Trevor,

On Sun, Dec 1, 2019 at 9:24 PM Trevor Bača  wrote:
>
> Hi David (and Kieren and Urs),
>
> Awesome. I'll look forward to using measure-attached spanners, too.
>
> Trevor.
>

If you build from current master, you can use them now.  Patch has been pushed!

David

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: lemzwerg, carl.d.sorensen_gmail.com, Dan Eble, thomasmorley651,  
t.daniels_treda.co.uk, kieren_kierenmacmillan.info, c_sorensen, checkma,


Message:
Name has been changed to MeasureSpanner, and all references (including
file names) have been adjusted. Thanks for the reviews!


https://codereview.appspot.com/571180043/diff/565230043/input/regression/measure-spanner.ly
File input/regression/measure-spanner.ly (right):

https://codereview.appspot.com/571180043/diff/565230043/input/regression/measure-spanner.ly#newcode5
input/regression/measure-spanner.ly:5: Measure attached spanners can
span single and multiple
On 2019/11/15 17:49:24, lemzwerg wrote:

Shouldn't this be rather



   Measure-attached spanners ...



?


Changed to reflect new name

https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh
File lily/include/measure-attached-spanner.hh (right):

https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh#newcode4
lily/include/measure-attached-spanner.hh:4: Copyright (C) 1997--2015 Jan
Nieuwenhuizen 
On 2019/11/16 18:07:37, Dan Eble wrote:

When you add a new file, I think you're supposed to use (C) 
year> 
name>.  At least, that's what I was once told.


Done.

https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh#newcode20
lily/include/measure-attached-spanner.hh:20: #ifndef
Measure_attached_spanner_HH
On 2019/11/16 18:07:37, Dan Eble wrote:

all caps, please


Done.

https://codereview.appspot.com/571180043/diff/565230043/lily/include/measure-attached-spanner.hh#newcode24
lily/include/measure-attached-spanner.hh:24: #include "std-vector.hh"
On 2019/11/16 18:07:37, Dan Eble wrote:

I don't see anything in this header that uses a vector.  Unless I'm

wrong, this

should be moved to whichever cc files require it.  Same goes for any

other

unnecessary headers.


Done.  (Unnecessary includes pruned from lily/measure-spanner.cc as
well.)

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc
File lily/measure-attached-spanner.cc (right):

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode45
lily/measure-attached-spanner.cc:45: //Direction dir =
get_grob_direction (me);
On 2019/11/16 18:07:37, Dan Eble wrote:

remove


Done.

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode53
lily/measure-attached-spanner.cc:53: Spanner *orig_spanner =
dynamic_cast (me->original ());
On 2019/11/16 18:07:37, Dan Eble wrote:

If I understand correctly, me->original () can only ever be either

null or

another instance of the same type as me; therefore, use static_cast

here.


Also, if it's logically possible for me->original () to be null in

this case,

check for it before dereferencing below.


Done.  (Updated according to your recently pushed patch.)

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode93
lily/measure-attached-spanner.cc:93: : ly_symbol2scm ("staff-bar"));
On 2019/11/16 18:41:00, thomasmorley651 wrote:

If I understand correctly (and I may be wrong, because my knowledge

about c++ is

more or less zero), then "staff-bar" is a fall-back.
I'd create an entry for 'spacing-pair' in define-grobs.scm, too.

Similar to

MeasureCounter, MultiMeasure Rest and PercentRepeat.


Done.

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode96
lily/measure-attached-spanner.cc:96: }
On 2019/11/15 17:49:24, lemzwerg wrote:

The `}' is not aligned with `{'.  Maybe incorrect use of tabs?


Done.

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode141
lily/measure-attached-spanner.cc:141: "break-overshoot "
On 2019/11/16 18:41:00, thomasmorley651 wrote:

Probably add a regtest for break-overshoot.
Or extent input/regression/spanner-break-overshoot.ly


break-overshoot is not a supported property; removed from interface list

https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly
File ly/spanners-init.ly (right):

https://codereview.appspot.com/571180043/diff/565230043/ly/spanners-init.ly#newcode25
ly/spanners-init.ly:25:
On 2019/11/16 14:42:02, thomasmorley651 wrote:

"View side-by-side diff with in-line comments" is broken for this

file.

Yeah, this happened to me in the past.  Not sure what to do about it.

https://codereview.appspot.com/571180043/diff/565230043/scm/define-grobs.scm
File scm/define-grobs.scm (right):

https://codereview.appspot.com/571180043/diff/565230043/scm/define-grobs.scm#newcode1457
scm/define-grobs.scm:1457: ;(font-size . -2)
On 2019/11/16 14:42:02, thomasmorley651 wrote:

Mmh, this is commented. Why?
Same below.


Just some test code.  Removed.

https://codereview.appspot.com/571180043/diff/565230043/scm/define-music-types.scm
File scm/define-music-types.scm (right):

Re: problem with git pull -r

[David Nalesnik]

On Thu, Nov 21, 2019 at 9:45 AM Jonas Hahnfeld  wrote:
>
> Am Donnerstag, den 21.11.2019, 16:30 +0100 schrieb Werner LEMBERG:
> > > Below is the console output.  Any ideas?
> >
> >
> > Clone the repository anew, and everything should be fine again.
>
> This works of course but is pretty destructive. A simple
>  $ git fetch --prune
> did the job for me. T
> Regards,
> Jonas

Did the trick for me too.  Thanks!

David N

problem with git pull -r

[David Nalesnik]

Below is the console output.  Any ideas?

Thanks,
David

[dev@lilydev:lilypond-git]$ git pull -r
error: cannot lock ref
'refs/remotes/origin/dev/jmandereau/merge-make-and-stepmake':
'refs/remotes/origin/dev/jmandereau' exists; cannot create
'refs/remotes/origin/dev/jmandereau/merge-make-and-stepmake'
>From ssh://git.sv.gnu.org/srv/git/lilypond
 ! [new branch]dev/jmandereau/merge-make-and-stepmake ->
origin/dev/jmandereau/merge-make-and-stepmake  (unable to update local
ref)
error: cannot lock ref
'refs/remotes/origin/dev/jmandereau/stable-2.20-201902':
'refs/remotes/origin/dev/jmandereau' exists; cannot create
'refs/remotes/origin/dev/jmandereau/stable-2.20-201902'
 ! [new branch]dev/jmandereau/stable-2.20-201902 ->
origin/dev/jmandereau/stable-2.20-201902  (unable to update local ref)

Re: shepherd a patch?

[David Nalesnik]

Thanks, James!

On Sat, Nov 16, 2019 at 4:07 AM James  wrote:
>
> David,
>
> On 15/11/2019 13:31, David Nalesnik wrote:
> > On Fri, Nov 15, 2019 at 4:31 AM James Lowe  wrote:
> >> David et al.
> >>
> >> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska  
> >> wrote:
> >>
> >>> Hi David,
> >>>
> >>> I feel responsible for this because I know where this is coming from  ;-)
> >>>
> >>> You can send me the patch. However, it's a long time since I uploaded
> >>> anything, so I'm not sure my set-up still works. But I'll try.
> >>>
> >>> Best
> >>> Urs
> >>>
> >>> Am 15.11.19 um 04:10 schrieb David Nalesnik:
> >>>> Hi all,
> >>>>
> >>>> I have a patch which implements measure-attached spanners.  I am
> >>>> having a devil of a time getting the patch up for review.  I simply
> >>>> can't get git-cl to upload it.  (I suspect this has something to do
> >>>> with the number of files it touches--my system times out before
> >>>> everything can be uploaded.)
> >>>>
> >>>> Would someone be willing to shepherd the patch for me?
> >>>>
> >>>> Attached is a PNG which shows the output of one of the regtests.
> >>>>
> >>>> This would _really_ be appreciated.  Thanks!
> >>>>
> >>>> David
> >> What I would suggest (generally to anyone on this list that ever needs a 
> >> patch shepherding) is to make sure a tracker exists - @David, as I know 
> >> you have access to create tickets you can at least do this - and then 
> >> attach your patch to that and set the tracker to 'started' so that at the 
> >> very least if (for example) Urs forgets, goes on holiday, has some 
> >> emergency, that I can at least pick it up/detect it on the countdown and 
> >> put it up for review myself.
> >>
> >> I do this all the time for 'drive by' patches.
> >>
> >> James
> >>
> > Thanks for this explanation.  I discovered that my patch had gone to
> > Rietveld, only no ticket was created.  So the error has to do with the
> > issue tracker.  Here's hoping that it's possible to do what's left
> > manually without too much trouble!
>
> Status = 'started'
>
> Patch = 'new'
>
> Those two things will get it on the radar.
>
>
> James
>

Re: shepherd a patch?

[David Nalesnik]

James and all,

On Fri, Nov 15, 2019 at 7:31 AM David Nalesnik  wrote:
>
> On Fri, Nov 15, 2019 at 4:31 AM James Lowe  wrote:
> >
> > David et al.

> > >
> > > Am 15.11.19 um 04:10 schrieb David Nalesnik:

> > > > Would someone be willing to shepherd the patch for me?

> >
> > What I would suggest (generally to anyone on this list that ever needs a 
> > patch shepherding) is to make sure a tracker exists - @David, as I know you 
> > have access to create tickets you can at least do this - and then attach 
> > your patch to that and set the tracker to 'started' so that at the very 
> > least if (for example) Urs forgets, goes on holiday, has some emergency, 
> > that I can at least pick it up/detect it on the countdown and put it up for 
> > review myself.
> >
> > I do this all the time for 'drive by' patches.
> >
> > James
> >
>
> Thanks for this explanation.  I discovered that my patch had gone to
> Rietveld, only no ticket was created.  So the error has to do with the
> issue tracker.  Here's hoping that it's possible to do what's left
> manually without too much trouble!
>
> Best,
> David

OK, I _think_ all is well.  I created this issue
https://sourceforge.net/p/testlilyissues/issues/5602/
and provided a link to the Rietveld issue.

Best,
David

Re: shepherd a patch?

[David Nalesnik]

Federico,

On Fri, Nov 15, 2019 at 6:39 AM Federico Bruni  wrote:

>
> This is what's recommended in the README:
> https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container
>

I saw this, but I'm running LilyDev from a Win10 host.

David

Re: shepherd a patch?

[David Nalesnik]

On Fri, Nov 15, 2019 at 12:33 AM Urs Liska  wrote:
>
> Hi David,
>
> I feel responsible for this because I know where this is coming from  ;-)

Hah! :)  (Seriously, though, this is something that I've wanted and
Kieren has clamored for...)

>
> You can send me the patch. However, it's a long time since I uploaded
> anything, so I'm not sure my set-up still works. But I'll try.
>
> Best
> Urs

I appreciate this very much!  Turns out, I may be able to do this
manually.  (A Rietveld issue is
created--https://codereview.appspot.com/571180043/  just no tracker
issue.)

I will let you know!

David

Re: shepherd a patch?

[David Nalesnik]

On Fri, Nov 15, 2019 at 4:31 AM James Lowe  wrote:
>
> David et al.
>
> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska  wrote:
>
> > Hi David,
> >
> > I feel responsible for this because I know where this is coming from  ;-)
> >
> > You can send me the patch. However, it's a long time since I uploaded
> > anything, so I'm not sure my set-up still works. But I'll try.
> >
> > Best
> > Urs
> >
> > Am 15.11.19 um 04:10 schrieb David Nalesnik:
> > > Hi all,
> > >
> > > I have a patch which implements measure-attached spanners.  I am
> > > having a devil of a time getting the patch up for review.  I simply
> > > can't get git-cl to upload it.  (I suspect this has something to do
> > > with the number of files it touches--my system times out before
> > > everything can be uploaded.)
> > >
> > > Would someone be willing to shepherd the patch for me?
> > >
> > > Attached is a PNG which shows the output of one of the regtests.
> > >
> > > This would _really_ be appreciated.  Thanks!
> > >
> > > David
>
> What I would suggest (generally to anyone on this list that ever needs a 
> patch shepherding) is to make sure a tracker exists - @David, as I know you 
> have access to create tickets you can at least do this - and then attach your 
> patch to that and set the tracker to 'started' so that at the very least if 
> (for example) Urs forgets, goes on holiday, has some emergency, that I can at 
> least pick it up/detect it on the countdown and put it up for review myself.
>
> I do this all the time for 'drive by' patches.
>
> James
>

Thanks for this explanation.  I discovered that my patch had gone to
Rietveld, only no ticket was created.  So the error has to do with the
issue tracker.  Here's hoping that it's possible to do what's left
manually without too much trouble!

Best,
David

Re: shepherd a patch?

[David Nalesnik]

On Fri, Nov 15, 2019 at 2:19 AM Jonas Hahnfeld  wrote:
>
> Hi David,
>
> Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:
>
> Hi all,
>
>
> I have a patch which implements measure-attached spanners.  I am
>
> having a devil of a time getting the patch up for review.  I simply
>
> can't get git-cl to upload it.  (I suspect this has something to do
>
> with the number of files it touches--my system times out before
>
> everything can be uploaded.)
>
>
> based on your other messages, you're using LilyDev when running git-cl? If 
> you say it times out, I would guess that git-cl waiting for you to authorize 
> the tool. Usually, it opens a browser for that, but that's probably not going 
> to work under a headless VM / container?
> Did you try running git-cl from your host system?
>
> Jonas

Ugh.  My failing memory.  Several years ago I did need to upload the
patch from git-cl on an Ubuntu machine outside of LilyDev.  The output
I got on the Win10 machine that hosts LilyDev would give me output
similar to the following:

[dev@lilydev:lilypond-git]$ git-cl upload origin/master
 input/regression/measure-spanner-spacing-pair.ly |  33 +
 input/regression/measure-spanner.ly  |  30 +
 lily/bracket.cc  |  10 +-
 lily/enclosing-bracket.cc|   4 +-
 lily/include/bracket.hh  |   3 +-
 lily/include/measure-attached-spanner.hh |  34 +
 lily/measure-attached-spanner.cc | 151 +++
 ly/spanners-init.ly  |   4 +
 scm/define-event-classes.scm |   1 +
 scm/define-grobs.scm |  22 
 scm/define-music-types.scm   |   6 +
 scm/scheme-engravers.scm |  63 ++
 12 files changed, 353 insertions(+), 8 deletions(-)
Upload server: codereview.appspot.com (change with -s/--server)
Your browser has been opened to visit:

https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser

Issue created. URL: http://codereview.appspot.com/566970043
Uploading base file for input/regression/measure-spanner-spacing-pair.ly
Uploading base file for scm/define-event-classes.scm
Uploading base file for scm/scheme-engravers.scm
Uploading base file for scm/define-grobs.scm
Traceback (most recent call last):
  File "/home/dev/git-cl/git-cl", line 628, in 
sys.exit(main(sys.argv))
  File "/home/dev/git-cl/git-cl", line 622, in main
return func(argv[2:])
  File "/home/dev/git-cl/git-cl", line 335, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/dev/git-cl/upload.py", line 2693, in RealMain
vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File "/home/dev/git-cl/upload.py", line 1220, in UploadBaseFiles
print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 567, in get
raise self._value
urllib2.URLError: 
[dev@lilydev:lilypond-git]$

--

I see now that a Rietveld issue is created with all my changes present.
https://codereview.appspot.com/571180043/
However, no issue is created on the Allura tracker.

I presume that it is possible to do what remains in the issue tracker
without having to run git-cl successfully?

Thanks for your help!
David

shepherd a patch?

[David Nalesnik]

Hi all,

I have a patch which implements measure-attached spanners.  I am
having a devil of a time getting the patch up for review.  I simply
can't get git-cl to upload it.  (I suspect this has something to do
with the number of files it touches--my system times out before
everything can be uploaded.)

Would someone be willing to shepherd the patch for me?

Attached is a PNG which shows the output of one of the regtests.

This would _really_ be appreciated.  Thanks!

David

Re: git-cl command not found

[David Nalesnik]

On Thu, Nov 14, 2019 at 7:05 PM David Kastrup  wrote:
>
> David Nalesnik  writes:
>
> > Trying to get git-cl going I run into an interesting problem.  I've
> > installed LilyDev, so I should have git-cl.
> >
> > I update:
> > [dev@lilydev:lilypond-git]$ cd ~/git-cl/
> > [dev@lilydev:git-cl]$ git pull
> > remote: Enumerating objects: 4, done.
> > remote: Counting objects: 100% (4/4), done.
> > remote: Compressing objects: 100% (2/2), done.
> > remote: Total 4 (delta 2), reused 3 (delta 2), pack-reused 0
> > Unpacking objects: 100% (4/4), done.
> > From git://github.com/gperciva/git-cl
> >9511426..1994c03  master -> origin/master
> > Updating 9511426..1994c03
> > Fast-forward
> >  allura_issues.py | 15 ---
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> >
> >
> > Make sure ca-certificates is there:
> >
> > [dev@lilydev:~]$ apt --installed list | grep ca-certificates
> >
> > WARNING: apt does not have a stable CLI interface. Use with caution in 
> > scripts.
> >
> > ca-certificates/oldstable,oldstable,now 20161130+nmu1+deb9u1 all [installed]
> >
> > But then I can't use git-cl:
> >
> > [dev@lilydev:~]$ cd $LILYPOND_GIT
> > [dev@lilydev:lilypond-git]$ git-cl config
> > bash: git-cl: command not found
> >
> > 
> > What am I doing wrong?
>
> It's not in your PATH ?
>
Ah yes.  Duh.  Didn't think to check b/c I figured this would just
work out of the box.

Thanks...

git-cl command not found

[David Nalesnik]

Trying to get git-cl going I run into an interesting problem.  I've
installed LilyDev, so I should have git-cl.

I update:
[dev@lilydev:lilypond-git]$ cd ~/git-cl/
[dev@lilydev:git-cl]$ git pull
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 4 (delta 2), reused 3 (delta 2), pack-reused 0
Unpacking objects: 100% (4/4), done.
>From git://github.com/gperciva/git-cl
   9511426..1994c03  master -> origin/master
Updating 9511426..1994c03
Fast-forward
 allura_issues.py | 15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)


Make sure ca-certificates is there:

[dev@lilydev:~]$ apt --installed list | grep ca-certificates

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

ca-certificates/oldstable,oldstable,now 20161130+nmu1+deb9u1 all [installed]

But then I can't use git-cl:

[dev@lilydev:~]$ cd $LILYPOND_GIT
[dev@lilydev:lilypond-git]$ git-cl config
bash: git-cl: command not found


What am I doing wrong?

Thanks!
David

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 9:58 PM David Nalesnik  wrote:
>
> On Thu, Nov 14, 2019 at 9:49 PM Werner LEMBERG  wrote:
> >
> >
> > >> There is git-fsck .
> > >>
> > >
> > > [dev@lilydev:lilypond-git]$ git fsck
> > > Segmentation faultrectories:  45% (116/256)
> >
> > Ouch.  I've never experienced such a thing with git.  Maybe something
> > is broken with your installation?  Does removing and installing again
> > help?
> >
> >
> > Werner
>
> Do you mean removing git itself?  I'd like to be able to get back to
> the work I just did, if at all possible.
>
> I deleted the empty object that git commands complained about, and now
> git fsck works.
>
> I get this output
> :
> [dev@lilydev:lilypond-git]$ git fsck
> Checking object directories: 100% (256/256), done.
> Checking objects: 100% (402883/402883), done.
> error: HEAD: invalid sha1 pointer 76008183503d70d4b37a73f19e60c2438112a5a8
> error: refs/heads/dev/measure_spanner: invalid sha1 pointer
> 76008183503d70d4b37a73f19e60c2438112a5a8
> Checking connectivity: 401781, done.
>
> (dev/measure_spanner is the name of my branch)
>
> By the way, git reflog gives me this:
>
> [dev@lilydev:lilypond-git]$ git reflog
> fatal: bad object HEAD
>
> Any ideas how to fix this?
>
> Thanks,
> David

OK, I think I got things operational again, through Googling and blind faith...

I manually checked the reflog for my branch:
[dev@lilydev:lilypond-git]$ tail -n 2 .git/logs/refs/heads/dev/measure_spanner
de92385d89cfbbe5f0aa95a907c5fb98496fcb28
e949231cdff5d174e76af47c49e0b2fd60e912eb Federico Bruni
 1573594713 +0100reset: moving to HEAD^
e949231cdff5d174e76af47c49e0b2fd60e912eb
ec0f38486e4aedcd28a89cca28464ef4f226b7bb David Nalesnik
 1573595114 +0100commit: Add regression
tests

(Note: both commits above are authored by me; I was just a little late
in updating my config.)

I reset HEAD to point to the last commit on my branch:
git update-ref HEAD ec0f38486e4aedcd28a89cca28464ef4f226b7bb

git fsck then gave this:

[dev@lilydev:lilypond-git]$ git fsck
Checking object directories: 100% (256/256), done.
Checking objects: 100% (402883/402883), done.
error: refs/heads/dev/measure_spanner: invalid reflog entry
76008183503d70d4b37a73f19e60c2438112a5a8
error: HEAD: invalid reflog entry 76008183503d70d4b37a73f19e60c2438112a5a8
Checking connectivity: 401781, done.

I then did:

[dev@lilydev:lilypond-git]$ git reflog expire --stale-fix --all
[dev@lilydev:lilypond-git]$ git fsck
Checking object directories: 100% (256/256), done.
Checking objects: 100% (402883/402883), done.
Checking connectivity: 401781, done.

___
Something must have happened when I attempted to use git rebase -i to
squash those two commits.  That rebase is gone.

Ugh.  I hope this does the trick...

Thanks,
David

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 9:49 PM Werner LEMBERG  wrote:
>
>
> >> There is git-fsck .
> >>
> >
> > [dev@lilydev:lilypond-git]$ git fsck
> > Segmentation faultrectories:  45% (116/256)
>
> Ouch.  I've never experienced such a thing with git.  Maybe something
> is broken with your installation?  Does removing and installing again
> help?
>
>
> Werner

Do you mean removing git itself?  I'd like to be able to get back to
the work I just did, if at all possible.

I deleted the empty object that git commands complained about, and now
git fsck works.

I get this output
:
[dev@lilydev:lilypond-git]$ git fsck
Checking object directories: 100% (256/256), done.
Checking objects: 100% (402883/402883), done.
error: HEAD: invalid sha1 pointer 76008183503d70d4b37a73f19e60c2438112a5a8
error: refs/heads/dev/measure_spanner: invalid sha1 pointer
76008183503d70d4b37a73f19e60c2438112a5a8
Checking connectivity: 401781, done.

(dev/measure_spanner is the name of my branch)

By the way, git reflog gives me this:

[dev@lilydev:lilypond-git]$ git reflog
fatal: bad object HEAD

Any ideas how to fix this?

Thanks,
David

Re: problems with SSH key

[David Nalesnik]

Good god

On Thu, Nov 14, 2019 at 6:36 PM David Kastrup  wrote:

>
> There is git-fsck .
>

[dev@lilydev:lilypond-git]$ git fsck
Segmentation faultrectories:  45% (116/256)

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 10:21 AM Federico Bruni  wrote:

>
>
> Il giorno gio 14 nov 2019 alle 10:17, David Nalesnik
>  ha scritto:
> > On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik
> >  wrote:
> >>
> >>  On Thu, Nov 14, 2019 at 9:23 AM David Kastrup  wrote:
> >>  >
> >>  > Rather sounds like a different problem like a dead
> >> server/connection.
> >>  > Try again?
> >>
> >>  Same result
> >
> > And in fact any git command I try yields these fatal errors.  (I tried
> > to create a patch to back up my work, to no avail.)
> >
>
> git format-patch doesn't work either?
>
> Perhaps you need to upgrade the system? In particular the package
> ca-certificates
>

Nor did git log.  I will see about updates, but I imagine I need to clean
up the empty objects manually.

Thanks,
David

>
>
>
>

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 10:19 AM David Nalesnik
 wrote:
>
> On Thu, Nov 14, 2019 at 10:17 AM David Nalesnik
>  wrote:
> >
> > On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik  
> > wrote:
> > >
> > > On Thu, Nov 14, 2019 at 9:23 AM David Kastrup  wrote:
> > > >
> > > > Rather sounds like a different problem like a dead server/connection.
> > > > Try again?
> > >
> > > Same result
> >
> > And in fact any git command I try yields these fatal errors.  (I tried
> > to create a patch to back up my work, to no avail.)
>
> I think I will try the upvoted solution here later today:
> https://stackoverflow.com/questions/11706215/how-to-fix-git-error-object-file-is-empty

Unless you can think of a better idea!

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 10:17 AM David Nalesnik
 wrote:
>
> On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik  
> wrote:
> >
> > On Thu, Nov 14, 2019 at 9:23 AM David Kastrup  wrote:
> > >
> > > Rather sounds like a different problem like a dead server/connection.
> > > Try again?
> >
> > Same result
>
> And in fact any git command I try yields these fatal errors.  (I tried
> to create a patch to back up my work, to no avail.)

I think I will try the upvoted solution here later today:
https://stackoverflow.com/questions/11706215/how-to-fix-git-error-object-file-is-empty

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 9:34 AM David Nalesnik  wrote:
>
> On Thu, Nov 14, 2019 at 9:23 AM David Kastrup  wrote:
> >
> > Rather sounds like a different problem like a dead server/connection.
> > Try again?
>
> Same result

And in fact any git command I try yields these fatal errors.  (I tried
to create a patch to back up my work, to no avail.)

Re: problems with SSH key

[David Nalesnik]

On Thu, Nov 14, 2019 at 9:23 AM David Kastrup  wrote:
>
> David Nalesnik  writes:
>
> > Hi all,
> >
> > I'm having difficulty getting my LilyDev machine to work with SSH.
> > I've followed the steps in the Contributor's Guide.  Below is what
> > happens.  I've included my config file, too.
> >
> > If anyone can help, I'd be very grateful.  I've got a patch to submit
> > but I've been struggling for days to reinstall LilyDev.
> >
> > Thanks,
> > David
> >
> > BTW: ssh is not installed in the latest LilyDev release; perhaps a
> > note is needed in the manual
> >
> > [dev@lilydev:lilypond-git]$ git pull --verbose
> > The authenticity of host 'git.sv.gnu.org (209.51.188.201)' can't be 
> > established.
> > ECDSA key fingerprint is SHA256:qRLLJ4w/GAeiDyYnbx4yWJbZXwGiYYxgNty7lAfUyuM.
> > Are you sure you want to continue connecting (yes/no)? yes
>
> I read "yes" so this does not look like a problem with the key.

Well, the Contributor's Guide description doesn't match what I got (an
ECDSA instead of an RSA fingerprint), so my "yes" may have been
wishful thinking?

Here's the output the CG quotes:

The authenticity of host 'git.sv.gnu.org (140.186.70.72)' can't
be established.
RSA key fingerprint is
80:5a:b0:0c:ec:93:66:29:49:7e:04:2b:fd:ba:2c:d5.
Are you sure you want to continue connecting (yes/no)?

>
> > Warning: Permanently added 'git.sv.gnu.org,209.51.188.201' (ECDSA) to
> > the list of known hosts.
>
> Again, this looks like the right reaction.  Should work without this
> prompt next time.
>
> > error: object file
> > .git/objects/76/008183503d70d4b37a73f19e60c2438112a5a8 is empty
> > error: object file
> > .git/objects/76/008183503d70d4b37a73f19e60c2438112a5a8 is empty
> > fatal: loose object 76008183503d70d4b37a73f19e60c2438112a5a8 (stored
> > in .git/objects/76/008183503d70d4b37a73f19e60c2438112a5a8) is corrupt
> > [dev@lilydev:lilypond-git]$ fatal: The remote end hung up unexpectedly
>
> Rather sounds like a different problem like a dead server/connection.
> Try again?

Same result

problems with SSH key

[David Nalesnik]

Hi all,

I'm having difficulty getting my LilyDev machine to work with SSH.
I've followed the steps in the Contributor's Guide.  Below is what
happens.  I've included my config file, too.

If anyone can help, I'd be very grateful.  I've got a patch to submit
but I've been struggling for days to reinstall LilyDev.

Thanks,
David

BTW: ssh is not installed in the latest LilyDev release; perhaps a
note is needed in the manual

[dev@lilydev:lilypond-git]$ git pull --verbose
The authenticity of host 'git.sv.gnu.org (209.51.188.201)' can't be established.
ECDSA key fingerprint is SHA256:qRLLJ4w/GAeiDyYnbx4yWJbZXwGiYYxgNty7lAfUyuM.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'git.sv.gnu.org,209.51.188.201' (ECDSA) to
the list of known hosts.
error: object file
.git/objects/76/008183503d70d4b37a73f19e60c2438112a5a8 is empty
error: object file
.git/objects/76/008183503d70d4b37a73f19e60c2438112a5a8 is empty
fatal: loose object 76008183503d70d4b37a73f19e60c2438112a5a8 (stored
in .git/objects/76/008183503d70d4b37a73f19e60c2438112a5a8) is corrupt
[dev@lilydev:lilypond-git]$ fatal: The remote end hung up unexpectedly


__CONFIG___
[dev@lilydev:lilypond-git]$ git config --list
user.name=David Nalesnik
user.email=david.nales...@gmail.com
color.ui=auto
rietveld.server=codereview.appspot.com
rietveld.cc=lilypond-devel@gnu.org
branch.staging.remote=origin
branch.staging.merge=refs/heads/staging
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=ssh://dnales...@git.sv.gnu.org/srv/git/lilypond.git
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
allura.tracker=https://sourceforge.net/p/testlilyissues/issues/

Re: can't update makeinfo from 5.1

[David Nalesnik]

On Fri, Nov 1, 2019 at 5:12 AM Werner LEMBERG  wrote:
>
>
> > When I run configure, an error is returned saying that makeinfo is
> > too old (5,2).  When I run sudo apt-get install texinfo, I'm told
> > that I have the latest version.  makeinfo --version still returns
> > 5.2.
>
> Ouch.  `makeinfo` is part of texinfo.  Version 5.2 was published
> September 2013!
>
> The current version is 6.6, published February 2019.
>
> So please either use an add-on repository for your GNU/Linux
> distribution to get a newer texinfo version, or install it directly
> from the tarball.
>

Will try and report back.

Thanks!

can't update makeinfo from 5.1

[David Nalesnik]

Hi all,

I've been out of the loop for a while, and recently decided to finish
work on a patch I had put off.  When I run configure, an error is
returned saying that makeinfo is too old (5,2).  When I run sudo
apt-get install texinfo, I'm told that I have the latest version.
makeinfo --version still returns 5.2.

I realize that there is a thread devoted to this topic.  However, I
find that I will need a little more guidance.

In ~/,bashrc, I find

# This is useful when installing the LilyPond binary
if [ -d $HOME/bin ]; then
export PATH="$HOME/bin:$PATH"
fi

Is this what needs altering?

Thanks, and sorry for what must be a basic question

Best,
David

Re: Can alternateTextSpannerEngraver now completely replace Text_spanner_engraver in a public release?

[David Nalesnik]

David,

On Wed, Feb 13, 2019 at 8:35 AM David Kastrup  wrote:
>
> David Nalesnik  writes:
>
> > On Wed, Feb 13, 2019 at 7:49 AM Trevor Bača  wrote:
> >>
> >> Could somebody else possibly provide James a patch of David N.'s
> >> alternateTextSpannerEngraver?
> >>
> >> Trevor.
> >
> > The issue which would come up is that it is written in Scheme, rather
> > than C++.  This has implications for documentation.
>
> It does?  What kind of documentation cannot be achieved in Scheme that
> would be possible in C++?
>
> Here is some page from the Internals reference:
>
> File: lilypond-internals.info,  Node: Merge_rests_engraver,  Next: 
> Metronome_mark_engraver,  Prev: Mensural_ligature_engraver,  Up: Engravers 
> and Performers
>
> 2.2.71 Merge_rests_engraver
> ---
>
> Engraver to merge rests in multiple voices on the same staff.  This
> works by gathering all rests at a time step.  If they are all of the
> same length and there are at least two they are moved to the correct
> location as if there were one voice.
>
>Properties (read)
>
>  ‘suspendRestMerging’ (boolean)
>   When using the Merge_rest_engraver do not merge rests when
>   this is set to true.
>
>‘Merge_rests_engraver’ is not part of any context.
>
>
> This is an engraver written in Scheme.

Ah, OK, thanks for the update.  I must be thinking of a past state of affairs.

David N

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Can alternateTextSpannerEngraver now completely replace Text_spanner_engraver in a public release?

[David Nalesnik]

On Wed, Feb 13, 2019 at 7:49 AM Trevor Bača  wrote:
>
> On Wed, Feb 13, 2019 at 4:58 AM James Lowe  wrote:
>
> > Hello Trevor,
> >
> > On Tue, 12 Feb 2019 16:45:35 -0600, Trevor Bača 
> > wrote:
> >
> >
> > >
> > > Question: is it now possible to replace Text_spanner_engraver with David
> > > N.'s extended implementation, in a coming public release of LilyPond?
> > >
> > >
> > > Trevor.
> > >
> >
> >
> > If you have a patch based on current master I can at least test that for
> > you.]
> >
> > James
> >
>
> Hi James,
>
> I have no patch.
>
> Could somebody else possibly provide James a patch of David N.'s
> alternateTextSpannerEngraver?
>
> Trevor.

The issue which would come up is that it is written in Scheme, rather
than C++.  This has implications for documentation.  I could work this
into the existing C++ code and present a patch, if that's best.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Anybody has a good explanation for _this_ use of grob-transformer?

[David Nalesnik]

Hi,

On Mon, Jan 29, 2018 at 6:10 PM, David Kastrup  wrote:
> David Kastrup  writes:
>
>>>   %% no fail
>>>   \override TupletNumber.Y-offset =
>>>#(ly:make-unpure-pure-container
>>>   (lambda (grob) (+ (ly:tuplet-number::calc-y-offset grob) 1))
>>>   (lambda (grob start end) 1))
>>>   \tuplet 3/2 4 {
>>> c,,8 d e f g a b c d e f g
>>> c,,8^> d e f^> g a b^> c d e^> f g }
>>> }
>>
>> Ok, this means that at pure time, ly:tuplet-number::calc-y-offset must
>> not be called at all or it will ride roughshod over the X offset.  We'll
>> get the hang of it yet.
>
> At any rate, one point of grob-transformer is that it should work for
> any kind of value/callback, and it clearly doesn't here.  So either the
> theory underlying it is wrong, or the implementation.
>


I don't have time to look into the details at the moment, just to go
by my memory, having worked on TupletNumber's interaction with kneed
beams.  The callbacks for X-offset and Y-offset are not independent.
I forget which callback calls the other.  The rationale for this
yuckiness was tuplet number/accidental collision avoidance, for which
both axes are necessary,

I don't know whether this entanglement is the culprit, but I have my
strong suspicions...

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5187 Add command for Thin Aiken noteheads (issue 326510043 by karlinh...@gmail.com)

[David Nalesnik]

Hi Karlin,

On Fri, Sep 22, 2017 at 5:29 PM, Karlin High  wrote:
> On Fri, Sep 22, 2017 at 2:37 PM, Karlin High  wrote:
>> All right, I'm giving up and asking for help.
>
> I got good help from Carl Sorenson; thanks! Changed patch for review,
> now contains both code and documentation.
> --

Glad you got this squared away!  Just for reference you might look at
the email I got when I had a similar problem myself:

https://www.mail-archive.com/lilypond-devel@gnu.org/msg51407.html

Best,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: rest/mm-rest-markup

[David Nalesnik]

On Mon, Jul 31, 2017 at 11:53 AM, Thomas Morley
<thomasmorle...@gmail.com> wrote:
> 2017-07-31 18:09 GMT+02:00 David Kastrup <d...@gnu.org>:
>> David Nalesnik <david.nales...@gmail.com> writes:
>>
>>> On Mon, Jul 31, 2017 at 9:08 AM, David Kastrup <d...@gnu.org> wrote:
>>>> Thomas Morley <thomasmorle...@gmail.com> writes:
>>>>
>>>>> Hi David,
>>>>>
>>>>> this refers to
>>>>> http://lists.gnu.org/archive/html/lilypond-devel/2017-07/msg00144.html
>>>>> I opened a new thread, because this one will be about rest-markups only.
>>>>>
>>>>> rest-by-number-markup and rest-markup were impemented by myself
>>>>> commit ffa21bb1a55d2436bb432c4dff7ec04df95dc6f0
>>>>> My second patch at all.
>>>>
>>>> Ah, I thought that it wasn't quite in the line of code I see you doing
>>>> these days.  A few corners looked like copying idioms of David Nalesnik
>>>> in cases for which they appeared overengineered.
>>>
>>> Goodness!  Hopefully, I'm not as guilty of "open coding" these days.
>>
>> Anybody else needs his toes stepped on while I'm on a run?
>
>
> rofl

I laughed too.

>
> More seriously. I learned a lot studying your code, David N and David
> K and from several others.
> And I plan to continue this behaviour ;)
>

Can't say how much I've learned from studying code on the lists and
from feedback.  Best computer course I've had.

Best,
DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: rest/mm-rest-markup

[David Nalesnik]

On Mon, Jul 31, 2017 at 9:08 AM, David Kastrup <d...@gnu.org> wrote:
> Thomas Morley <thomasmorle...@gmail.com> writes:
>
>> Hi David,
>>
>> this refers to
>> http://lists.gnu.org/archive/html/lilypond-devel/2017-07/msg00144.html
>> I opened a new thread, because this one will be about rest-markups only.
>>
>> rest-by-number-markup and rest-markup were impemented by myself
>> commit ffa21bb1a55d2436bb432c4dff7ec04df95dc6f0
>> My second patch at all.
>
> Ah, I thought that it wasn't quite in the line of code I see you doing
> these days.  A few corners looked like copying idioms of David Nalesnik
> in cases for which they appeared overengineered.

Goodness!  Hopefully, I'm not as guilty of "open coding" these days.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Should we have a from-barline property in analogy to to-barline ?

[David Nalesnik]

On Jul 24, 2017 10:50 AM, "Kieren MacMillan" 
wrote:

Hi Simon,

> On 24.07.2017 13:58, David Kastrup wrote:
>> Seems like an obvious addition.  Would make stuff (like slurs, hairpins
>> and so on) starting at the bar move backwards to the bar line.  Probably
>> also useful for non-spanners like a \fermata ?
>
> I have difficulty imagining use cases.

Measure-attached spanners (e.g. "<--  Safety -->" ) comes to mind
immediately.


I've got a patch for these.  I can post it but it ought to wait for 2.20 to
be locked in.


> Is to-barline really used for anything else than hairpins?

Pedals?

> I certainly can imagine that _attaching_ spanners

Ah… there it is.  =)

Cheers,
Kieren.


Kieren MacMillan, composer
‣ website: www.kierenmacmillan.info
‣ email: i...@kierenmacmillan.info


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lyrics hyphens question

[David Nalesnik]

On Jun 13, 2017 9:55 PM, "Kieren MacMillan" 
wrote:

Hi David (et al.),

> It's not suitable as is, but easily remedied.  The grob LyricWord is
> defined in a hackish way so that it can fit in an LY file.

So in C++, it would be non-hackish…?


No, just parceling out the chunks to various .scm files.  Not hard at all.


> it's potentially useful to have a grob which organizes whole Lyric words,
> so lyrics are not simply a collection of isolated syllables.

Agreed.

> I can't say what problems there are with the compression routine.
> I know there have been complaints, but I haven't looked into them.

I’ve just discovered that using lyric-word-compressor makes the last line
of my score unexpectedly (and unpredictably) shorter, as if I had set
ragged-last = ##t. I'll see if I can make an MWE that demonstrates this
issue; in the meantime, I'll have to crank out this score without it…

Thanks,
Kieren.


Kieren MacMillan, composer
‣ website: www.kierenmacmillan.info
‣ email: i...@kierenmacmillan.info
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lyrics hyphens question

[David Nalesnik]

Hi Kieren,

On Tue, Jun 13, 2017 at 3:21 PM, Kieren MacMillan
 wrote:
> Hi David (et al.),
>
> These are questions regarding the "lyric-word-reconstituter" in the thread 
> which includes the post 
> .
>
> I'd love to use it (or something like it) in my engravings going forward.
>
> 1. It doesn't seem to work with 2.19.61 (at least), and convert-ly doesn't 
> seem to help. The error is
>
> warning: type check for `LyricWord' failed; value `#' 
> must be of type `list'
>
> My instinct (and a quick search on -user) led me to believe that changing
>
> (set-object-property! grob-name 'translation-type? list?)
>
> to
>
> (set-object-property! grob-name 'translation-type? ly:grob-properties?)
>
> might fix the problem. The file/example now compiles without error. Did I fix 
> it correctly?

Yes, that's right.

>
> 2. This is a workaround/hack/fix from 2014. At the time, there was some 
> question as to whether Janek might roll this (or similar) into the GSoC Lyric 
> project… but that is, I believe, dead in the water. Is there any hope of 
> getting this into the codebase? I'm happy to take this "stub" (much more than 
> a stub, of course!) and shepherd it through the dev process to the goal line 
> — but I don't want to start down a track that will ultimately lead to 
> frustration or nowhere at all.
>

>

It's not suitable as is, but easily remedied.  The grob LyricWord is
defined in a hackish way so that it can fit in an LY file.

In my opinion, it's potentially useful to have a grob which organizes
whole Lyric words, so lyrics are not simply a collection of isolated
syllables.  (Makes short work of the compression in this instance.)

I can't say what problems there are with the compression routine.  I
know there have been complaints, but I haven't looked into them.  (See
openlilylib, I believe.)

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix typos in \offset documentation (issue 322040043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Description:
Fix typos in \offset documentation

- Fix errors in description of OttavaBracket example
- Minor improvements in wording

Please review this at https://codereview.appspot.com/322040043/

Affected files (+5, -4 lines):
  M Documentation/notation/changing-defaults.itely


Index: Documentation/notation/changing-defaults.itely
diff --git a/Documentation/notation/changing-defaults.itely  
b/Documentation/notation/changing-defaults.itely
index  
7fad344bb6ee3cc4d281e36d49e55bbf77363115..5373e4f399fa3fcb17d7775032be5b7d801894c6  
100644

--- a/Documentation/notation/changing-defaults.itely
+++ b/Documentation/notation/changing-defaults.itely
@@ -2783,10 +2783,11 @@ The following example displaces the @q{broken}  
@code{OttavaBracket}

 object through its @code{staff-padding} property.  Since the property
 takes a @code{number}, @var{offsets} is provided with a list of
 @code{number}s to account for the two segments created by the line
-break.  The slur piece on the first line is effectively untouched since
-@code{0} is added to its default value.  The segment on the second
-line is raised two staff-spaces from its default height.  The default
-height happens to be @code{2}, though it is not necesssary to know this.
+break.  The bracket piece on the first line is effectively untouched
+since @code{0} is added to its default value of @code{staff-padding}.
+The segment on the second line is raised three staff-spaces from its
+default height.  The default height happens to be @code{2}, though it is
+not necessary to know this to achieve the desired positioning.

 @lilypond[quote,verbatim]
 {



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

[david . nalesnik]

https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167
scm/scheme-engravers.scm:167: (lambda (rest) (ly:grob-set-property! rest
'Y-offset (rest-offset rest)))
On 2017/05/21 04:27:33, horndude77 wrote:

On 2017/05/20 14:33:15, david.nalesnik wrote:
> Just moving one rest on top of the other might cause offsets with

some

printers.
>  This happened at one time with flags on chords: see
> http://lists.gnu.org/archive/html/bug-lilypond/2015-08/msg00080.html
>
> Would it work to set 'stencil of all of the cdr to point-stencil?



Using point-stencil causes odd alignment issues with text connected to
multimeasure rests. Making them invisible doesn't have this issue.

Would that

solve the above potential problem?


I'm not so sure now that I identified an actual problem, but this an
improvement b/c it will cut down on PDF file size.


Related to this, is there a way to re-parent grobs onto the surviving

rest? If

so we could then use point-stencil (or possibly fully destroy) the

other rests.

I'd have to look into this, but as a first observation I think it would
help if MultiMeasureRest stored pointers to associated
MultiMeasureRestText and MultiMeasureRestNumber grobs.  (This would be
done in the Multi_measure_rest_engraver.)

I don't think that this is something that needs to be tackled in this
patch.

https://codereview.appspot.com/321930043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

[david . nalesnik]

Looks much better -- see comments below.


https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167
scm/scheme-engravers.scm:167: (lambda (rest) (ly:grob-set-property! rest
'Y-offset (rest-offset rest)))
Just moving one rest on top of the other might cause offsets with some
printers.  This happened at one time with flags on chords: see
http://lists.gnu.org/archive/html/bug-lilypond/2015-08/msg00080.html

Would it work to set 'stencil of all of the cdr to point-stencil?

https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode193
scm/scheme-engravers.scm:193: ((eq? 'MultiMeasureRest (grob::name grob))
The only two grobs you could get are Rest and MultiMeasureRest, so you
could just write

(else
  (set! [...]


[I think looking at the grob name is fine.]

https://codereview.appspot.com/321930043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

[david . nalesnik]

https://codereview.appspot.com/321930043/diff/60001/ly/init.ly
File ly/init.ly (right):

https://codereview.appspot.com/321930043/diff/60001/ly/init.ly#newcode36
ly/init.ly:36: #(use-modules (scm merge-rests-engraver))
I'm not sure why you are defining a separate module.  The usual
procedure would be to add your functionality to an existing file in the
load list or add your new file to the load list (in scm/lily.scm -- see
init-scheme-files-body).

The Span_stem_engraver, for example, puts the bulk of its code in
scm/music-functions-init.scm.  (There is also some code in
scm.scheme-engravers.scm -- I'm not sure if you ought to add something
there.)

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm
File scm/merge-rests-engraver.scm (right):

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode14
scm/merge-rests-engraver.scm:14: (eq?
Here (and elsewhere) use eqv? to compare numbers.

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode23
scm/merge-rests-engraver.scm:23: (define-public merge-rests-engraver
Here (and below) use the scheme-engraver macro for consistency.  As far
as I'm aware, all Scheme engravers in the code base use this now.  See
scm/scheme-engravers.scm or input/regression/scheme-text-spanner.ly for
examples.

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode35
scm/merge-rests-engraver.scm:35: (if (eq? 'Rest (assoc-ref
(ly:grob-property grob 'meta) 'name))
(See comment about recognizing grobs below.)

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode39
scm/merge-rests-engraver.scm:39: (eq?
eqv?

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode44
scm/merge-rests-engraver.scm:44: (eq? (ly:grob-property mmrest
'measure-count) 1))
eqv?

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode70
scm/merge-rests-engraver.scm:70: (let* ((curr-rests '())
let* not needed -- use let

https://codereview.appspot.com/321930043/diff/60001/scm/merge-rests-engraver.scm#newcode81
scm/merge-rests-engraver.scm:81: (if (eq? 'MultiMeasureRest (assoc-ref
(ly:grob-property grob 'meta) 'name))
You could use grob::name here.  Ordinarily, though, objects are
recognized by their interfaces.  So, here you should try

(if (grob::has-interface grob 'multi-measure-rest-interface)
  [...]

https://codereview.appspot.com/321930043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Calling in for sickness

[David Nalesnik]

David,

On Mon, May 15, 2017 at 11:42 AM, David Kastrup  wrote:
> l
> Hi folks,
>
> had a sort of apoplexy and will not be able to do anything while
> recovering.  I am hospitalized at the moment, CRT and MRT did not show
> any specific anomalies but my right side is hampered and I cannot yet
> swallow or cough which is sort of inconvenient.
>
> Hope this gets to you.
>
> Hopefully I can be back soonish.
>

So sorry to hear about this!  I hope you are doing better.

Please take your time before even thinking about returning to Lilypond
work -- your health is so much more important.

All my wishes for a speedy recovery--

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/04/28 22:49:25, thomasmorley651 wrote:

On 2017/04/28 22:27:12, david.nalesnik wrote:
> On 2017/04/28 22:24:57, david.nalesnik wrote:
> > On 2017/04/28 16:15:42, david.nalesnik wrote:
> > > On 2017/04/28 15:50:52, dak wrote:
> > > > Does an extra-offset in X direction even make sense when the

systems are

> > > spaced
> > > > according to their skylines _before_ the extra-offset is

applied?

> > >
> > > Well, X-offset of line-break-system-details is applied in
make-page-stencil,
> > > too.
> >
> > In any case, having an extra-offset in the Y direction is

obviously much

more
> > useful.  Extra-offset in the X direction seems a bit superfluous,

since it's

> > easy enough to set 'X-offset based on the left edge of the

printing space.

>
> Or, rather, I would imagine that the extra-offset setting for X

would be the

> same as X-offset
>
> > My
> > original code created an extra-Y-offset, and I'm happy to go back

to this.

> >
> > Opinions?



If I understand correctly the default systems X/Y-offset is calculated
elsewhere, I like the possibility to offset those values.


Yes, but 'X-offset already acts as an offset from default values.  Try
the following example.  Any setting of 'X-offset is obviously in
relation to what's on your screen.  Set indent, short indent,
left-margin to what you like.

\version "2.19.59"

\paper {
  left-margin = 40
  indent = 30
  short-indent = 30
}

\book {
  \score {
<<
  \new Staff <<
\new Voice {
  \overrideProperty
Score.NonMusicalPaperColumn.line-break-system-details
#'((X-offset . 0))
  s1*5 \break
  \overrideProperty
Score.NonMusicalPaperColumn.line-break-system-details
#'((X-offset . 1))
  s1*5 \break
}
\new Voice { \repeat unfold 15 { c'4 c' c' c' } }
  >>
  \new Staff {
\repeat unfold 15 { d'4 d' d' d' }
  }
>>
  }
}

In contrast 'Y-offset is always an offset from the top of the page.  If
you don't set it, LilyPond calculates it.  If you set it, Lilypond uses
that instead.  extra-Y-offset will then modify whatever's in Y-offset,
default or user-specified.

So what I'm saying is that 'X-offset already acts as an offset of the
default, so an extra-X-offset is not needed.

The only reasons I can see for keeping it are: you can offset your own
setting of X-offset (why?), and you can set X and Y together.


So I'd vote for keeping extra-offset as in your last patch-set.
Although I'm aware David K's point is important, I think a user doing

manual

positioning, is responsible to deal with possible problems

(collisions), too.

X-offset and Y-offset don't check for collisions.  You can put systems
on top of each other, and move them right off the page.  (That's another
attraction of "extra-offset" for a name--there are plenty of warnings
about potential collisions.)



https://codereview.appspot.com/324810043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/04/28 22:24:57, david.nalesnik wrote:

On 2017/04/28 16:15:42, david.nalesnik wrote:
> On 2017/04/28 15:50:52, dak wrote:
> > Does an extra-offset in X direction even make sense when the

systems are

> spaced
> > according to their skylines _before_ the extra-offset is applied?
>
> Well, X-offset of line-break-system-details is applied in

make-page-stencil,

> too.



In any case, having an extra-offset in the Y direction is obviously

much more

useful.  Extra-offset in the X direction seems a bit superfluous,

since it's

easy enough to set 'X-offset based on the left edge of the printing

space.

Or, rather, I would imagine that the extra-offset setting for X would be
the same as X-offset


My
original code created an extra-Y-offset, and I'm happy to go back to

this.


Opinions?




https://codereview.appspot.com/324810043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/04/28 16:15:42, david.nalesnik wrote:

On 2017/04/28 15:50:52, dak wrote:
> Does an extra-offset in X direction even make sense when the systems

are

spaced
> according to their skylines _before_ the extra-offset is applied?



Well, X-offset of line-break-system-details is applied in

make-page-stencil,

too.


In any case, having an extra-offset in the Y direction is obviously much
more useful.  Extra-offset in the X direction seems a bit superfluous,
since it's easy enough to set 'X-offset based on the left edge of the
printing space.  My original code created an extra-Y-offset, and I'm
happy to go back to this.

Opinions?

https://codereview.appspot.com/324810043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/04/28 15:50:52, dak wrote:

Does an extra-offset in X direction even make sense when the systems

are spaced

according to their skylines _before_ the extra-offset is applied?


Well, X-offset of line-break-system-details is applied in
make-page-stencil, too.

https://codereview.appspot.com/324810043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

[david . nalesnik]

Also added a "Changes" entry.

Thanks!


https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly
File input/regression/page-layout-extra-offset.ly (right):

https://codereview.appspot.com/324810043/diff/1/input/regression/page-layout-extra-offset.ly#newcode7
input/regression/page-layout-extra-offset.ly:7: printable area of the
page or the absolute position pecified by
On 2017/04/28 09:26:33, thomasmorley651 wrote:

typo
pecified->specified


Done.

https://codereview.appspot.com/324810043/diff/1/scm/page.scm
File scm/page.scm (right):

https://codereview.appspot.com/324810043/diff/1/scm/page.scm#newcode246
scm/page.scm:246: (extra-offset (ly:prob-property system 'extra-offset
(cons 0 0)))
On 2017/04/28 09:26:33, thomasmorley651 wrote:

Why not directly '(0 . 0) instead of constructing it?
Admittedly, starting with guile-2.2 set-car! (and similiar) will error

on

literals, though this is not the case here.


Done.

https://codereview.appspot.com/324810043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Removing 2sd intervals

[David Nalesnik]

On Thu, Apr 27, 2017 at 5:43 PM, nycgdf  wrote:
> I don't know how to for-each on a music object.
>
>

There are a number of useful functions: musicMap (defined in
ly/music-functions-init.ly); for-some-music, map-some-music,
fold-some-music (in scm/music-functions.scm).  Maybe you can get use
out of one of these, either directly or as inspiration.

The lists should have a few examples of at least one or two of these.

Hope this helps a little.

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!



Description:
Implement extra-offset for system positioning

Add the property 'extra-offset to 'line-break-system-details.

It is possible to position systems absolutely using the properties
'X-offset and 'Y-offset of 'line-break-system-details.  Placement,
however, is relative to the top left of the usable space, and can
be difficult to gauge without considerable trial and error.

An 'extra-offset property allows easy movement of systems relative
to where they currently are on the page--either through their
default positioning, or as a result of absolute positioning through
'X-offset and/or 'Y-offset.

System separators will be properly positioned. (Thanks go to Thomas
Morley.)

Please review this at https://codereview.appspot.com/324810043/

Affected files (+89, -6 lines):
  M Documentation/notation/spacing.itely
  A input/regression/page-layout-extra-offset.ly
  M scm/page.scm


Index: Documentation/notation/spacing.itely
diff --git a/Documentation/notation/spacing.itely  
b/Documentation/notation/spacing.itely
index  
fb455c1fdd55f52c4e03459eef336c44f0a6f2e5..9bb7eacca239cf59f9f7e206f6526e57d8d689f0  
100644

--- a/Documentation/notation/spacing.itely
+++ b/Documentation/notation/spacing.itely
@@ -2440,11 +2440,12 @@ padding,  
@code{NonMusicalPaperColumn.line-break-system-details}

 can specify exact vertical positions on the page.

 @code{NonMusicalPaperColumn.line-break-system-details} accepts
-an associative list of three different settings:
+an associative list of four different settings:

 @itemize
 @item @code{X-offset}
 @item @code{Y-offset}
+@item @code{extra-offset}
 @item @code{alignment-distances}
 @end itemize

@@ -2557,6 +2558,41 @@ potentially many values, but that we set only one  
value here.  Note,

 too, that the @code{Y-offset} property here determines the exact vertical
 position on the page at which each new system will render.

+In contrast to the absolute positioning available through
+@code{Y-offset} and @code{X-offset}, relative positioning is possible
+with the @code{extra-offset} property of
+@code{line-break-system-details}.  Placement is relative to the
+default layout or to the absolute positioning created by setting
+@code{X-offset} and @code{Y-offset}.  The property @code{extra-offset}
+accepts a @code{pair} consisting of displacements along the X-axis and
+Y-axis.
+
+@lilypond[verbatim,quote,staffsize=16]
+\header { tagline = ##f }
+\paper { left-margin = 0\mm }
+\book {
+  \score {
+<<
+  \new Staff <<
+\new Voice {
+  s1*5 \break
+  \overrideProperty  
Score.NonMusicalPaperColumn.line-break-system-details

+#'((extra-offset . (0 . 10)))
+  s1*5 \break
+  \overrideProperty  
Score.NonMusicalPaperColumn.line-break-system-details

+#'((extra-offset . (0 . 10)))
+  s1*5 \break
+}
+\new Voice { \repeat unfold 15 { c'4 c' c' c' } }
+  >>
+  \new Staff {
+\repeat unfold 15 { d'4 d' d' d' }
+  }
+>>
+  }
+}
+@end lilypond
+
 Now that we have set the vertical startpoint of each system
 explicitly, we can also set the vertical distances between staves
 within each system manually.  We do this using the  
@code{alignment-distances}

Index: input/regression/page-layout-extra-offset.ly
diff --git a/input/regression/page-layout-extra-offset.ly  
b/input/regression/page-layout-extra-offset.ly

new file mode 100644
index  
..3cc52e1b751736ff3401563f671d034393a6

--- /dev/null
+++ b/input/regression/page-layout-extra-offset.ly
@@ -0,0 +1,45 @@
+\version "2.19.60"
+
+\header {
+  texidoc = "By setting @code{extra-offset} within the
+@code{line-break-system-details} of @code{NonMusicalPaperColumn},
+systems may be moved in relation either to their default position on the
+printable area of the page or the absolute position pecified by
+@code{X-offset} or @code{Y-offset} within
+@code{line-break-system-details}."
+
+}
+
+#(set-default-paper-size "a6" 'portrait)
+
+\paper {
+  indent = 0.0
+  oddHeaderMarkup = "header"
+  oddFooterMarkup = "footer"
+  system-separator-markup = \slashSeparator
+  ragged-right = ##t
+}
+
+\book {
+  \score {
+{
+  \overrideProperty
+  Score.NonMusicalPaperColumn.line-break-system-details
+  #'((extra-offset . (8.0 . 0.0)))
+  c1 c1 \break
+
+  \overrideProperty
+  Score.NonMusicalPaperColumn.line-break-system-details
+  #'((extra-offset . (12.0 . 8.0)))
+  c1 c1 \break
+
+  \overrideProperty
+  Score.NonMusicalPaperColumn.line-break-system-details
+  #'((X-offset . 8.0)
+ (Y-offset . 36.0)
+ (extra-offset . (-8.0 . 30.0))
+  )
+  c1 c1
+}
+  }
+}
Index: scm/page.scm
diff --git a/scm/page.scm b/scm/page.scm
index  
c6e69658cea45b8c1cfac5f770b7b9ce10c0a3e9..910ace902d41a330a8b7be0d735cc6ea212b95de  
100644

--- a/scm/page.scm
+++ b/scm/page.scm
@@ -227,7 +227,7 @@
 

Re: Improve elbowed-hairpin (issue 324800043 by thomasmorle...@gmail.com)

[david . nalesnik]

LGTM.

(Aside from docstring change which you could make when pushing.)


https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm#newcode1170
scm/output-lib.scm:1170: Returns a line connecting @var{pts}, using
@code{ly:line-interface::line}, gets
Should be @var{points} now.

https://codereview.appspot.com/324800043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve elbowed-hairpin (issue 324800043 by thomasmorle...@gmail.com)

[david . nalesnik]

LGTM.

I've pointed out two minor issues, but I don't believe they should hold
up the review process.

By the way, applying

\override Hairpin.style = #'dashed-line to the regtest
input/regression/ferneyhough-hairpins.ly looks great!


https://codereview.appspot.com/324800043/diff/1/scm/output-lib.scm
File scm/output-lib.scm (right):

https://codereview.appspot.com/324800043/diff/1/scm/output-lib.scm#newcode1171
scm/output-lib.scm:1171: (if (not (pair? (cdr pts)))
Note that this will fail if pts is '().  Perhaps you should check the
length of pts in elbowed-hairpin -- there must be at least two pairs in
the pts alist for a viable line.

https://codereview.appspot.com/324800043/diff/1/scm/output-lib.scm#newcode1172
scm/output-lib.scm:1172: (apply ly:stencil-add empty-stencil ls)
Why not use reduce here.

https://codereview.appspot.com/324800043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix not scaling stem in note-by-number-markup (issue 324780043 by thomasmorle...@gmail.com)

[david . nalesnik]

LGTM.

https://codereview.appspot.com/324780043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: pdf changes every few compilations, although changing nothing

[David Nalesnik]

On Mon, Apr 10, 2017 at 7:43 AM, David Nalesnik
<david.nales...@gmail.com> wrote:
> On Mon, Apr 10, 2017 at 7:21 AM, Thomas Morley <thomasmorle...@gmail.com> 
> wrote:
>> 2017-04-10 14:09 GMT+02:00 David Nalesnik <david.nales...@gmail.com>:
>>> On Mon, Apr 10, 2017 at 5:36 AM, Thomas Morley <thomasmorle...@gmail.com> 
>>> wrote:
>>
>>>> Here the best minimal I can come up with:
>>>>
>>>> \version "2.19.60"
>>>>
>>>> tst = {
>>>> \override TupletBracket.stencil =
>>>> #(lambda (grob)
>>>>(let* ((orig (ly:grob-original grob))
>>>>   (siblings (if (ly:grob? orig) (ly:spanner-broken-into orig) 
>>>> '()))
>>>>   (tuplet-number (ly:grob-object grob 'tuplet-number)))
>>>>  (if (or (and (pair? siblings)
>>>>   (equal? grob (car siblings)))
>>>>  (null? siblings))
>>>>  (ly:grob-set-property! tuplet-number 'X-offset 0))
>>>>  (ly:tuplet-bracket::print grob)))
>>>> }
>>>>
>>>> %%{
>>>> \new Staff { \tst \tuplet 1/1 { \repeat unfold 30 c'1 } }
>>>> %}
>>>> %%{
>>>> \new Staff { \tst \tuplet 1/1 { c'1 c'1 c' c' c' } }
>>>> %}
>>>>
>>>>
>>>
>>> I notice the same variability with 2.19.56 and 2.18.2.  I'll see if I
>>> can figure out more.
>>
>>
>> Hi David,
>>
>> many thanks for caring.
>>
>> I meanwhile found using 'after-line-breaking and setting the final
>> stencil via ly:grob-set-property! ensures stable behaviour.
>>
>> Nevertheless I stay highly interested why this happens during a direct
>> stencil-override.
>>
>
> Here's an even more minimal example:
>
>
> tst = \override TupletBracket.stencil =
> #(lambda (grob)
>(let ((tuplet-number (ly:grob-object grob 'tuplet-number)))
>  (ly:grob-set-property! tuplet-number 'X-offset 0)
>  (ly:tuplet-bracket::print grob)))
>
> %%{
> \new Staff { \tst \tuplet 1/1 { \repeat unfold 30 c'1 } }
> %}
> %%{
> \new Staff { \tst \tuplet 1/1 { c'1 c'1 c' c' c' } }
>
> %%
>
> It's strange -- it seems that the value of
> ly:tuplet-bracket::calc-x-offset is used sometimes regardless of the
> ly:grob-set-property! and there's no predictability to it.
>
> No idea :(
>

Sorry, ly:tuplet-number::calc-x-offset ...

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: pdf changes every few compilations, although changing nothing

[David Nalesnik]

On Mon, Apr 10, 2017 at 7:21 AM, Thomas Morley <thomasmorle...@gmail.com> wrote:
> 2017-04-10 14:09 GMT+02:00 David Nalesnik <david.nales...@gmail.com>:
>> On Mon, Apr 10, 2017 at 5:36 AM, Thomas Morley <thomasmorle...@gmail.com> 
>> wrote:
>
>>> Here the best minimal I can come up with:
>>>
>>> \version "2.19.60"
>>>
>>> tst = {
>>> \override TupletBracket.stencil =
>>> #(lambda (grob)
>>>(let* ((orig (ly:grob-original grob))
>>>   (siblings (if (ly:grob? orig) (ly:spanner-broken-into orig) 
>>> '()))
>>>   (tuplet-number (ly:grob-object grob 'tuplet-number)))
>>>  (if (or (and (pair? siblings)
>>>   (equal? grob (car siblings)))
>>>  (null? siblings))
>>>  (ly:grob-set-property! tuplet-number 'X-offset 0))
>>>  (ly:tuplet-bracket::print grob)))
>>> }
>>>
>>> %%{
>>> \new Staff { \tst \tuplet 1/1 { \repeat unfold 30 c'1 } }
>>> %}
>>> %%{
>>> \new Staff { \tst \tuplet 1/1 { c'1 c'1 c' c' c' } }
>>> %}
>>>
>>>
>>
>> I notice the same variability with 2.19.56 and 2.18.2.  I'll see if I
>> can figure out more.
>
>
> Hi David,
>
> many thanks for caring.
>
> I meanwhile found using 'after-line-breaking and setting the final
> stencil via ly:grob-set-property! ensures stable behaviour.
>
> Nevertheless I stay highly interested why this happens during a direct
> stencil-override.
>

Here's an even more minimal example:


tst = \override TupletBracket.stencil =
#(lambda (grob)
   (let ((tuplet-number (ly:grob-object grob 'tuplet-number)))
 (ly:grob-set-property! tuplet-number 'X-offset 0)
 (ly:tuplet-bracket::print grob)))

%%{
\new Staff { \tst \tuplet 1/1 { \repeat unfold 30 c'1 } }
%}
%%{
\new Staff { \tst \tuplet 1/1 { c'1 c'1 c' c' c' } }

%%

It's strange -- it seems that the value of
ly:tuplet-bracket::calc-x-offset is used sometimes regardless of the
ly:grob-set-property! and there's no predictability to it.

No idea :(

-David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: pdf changes every few compilations, although changing nothing

[David Nalesnik]

On Mon, Apr 10, 2017 at 5:36 AM, Thomas Morley  wrote:
> Hi all,
>
> with the code below I experienced some pretty strange behaviour.
>
> The visual output changes every few compilations, although I changed 
> _nothing_!!
> In average two times in 10 compilations.
>
>
> Furthermore:
> While uncommenting the second example things change again:
> First example prints correct, second always wrong.
> Then commenting first example causes always correct output for the second.
>
>
> I use self-compiled 2.19.60 from
> commit 777ce245ecf9041a98d977f017c10b4edabaec04
> Author: Phil Holmes 
> Date:   Mon Apr 10 08:28:15 2017 +0100
>
> Release: bump VERSION.
>
>
> I'm aware there were some recent changes to the bracket code and the
> dependencies of TupletBracket/TupletNumber.
> Admittedly my own code is a brute-force override. Something wrong
> there or with the recent changes?

I strongly doubt this.  The changes I made to any bracket code this
touches are purely organizational.

On Mon, Apr 10, 2017 at 6:20 AM, Thomas Morley  wrote:
> 2017-04-10 12:36 GMT+02:00 Thomas Morley :
>> Hi all,
>>
>> with the code below I experienced some pretty strange behaviour.
>>
>> The visual output changes every few compilations, although I changed 
>> _nothing_!!
>> In average two times in 10 compilations.
>
>> Also, my code is not a minimal example, sorry for that, I keep trying
>> to reduce it.
>
>
> Here the best minimal I can come up with:
>
> \version "2.19.60"
>
> tst = {
> \override TupletBracket.stencil =
> #(lambda (grob)
>(let* ((orig (ly:grob-original grob))
>   (siblings (if (ly:grob? orig) (ly:spanner-broken-into orig) 
> '()))
>   (tuplet-number (ly:grob-object grob 'tuplet-number)))
>  (if (or (and (pair? siblings)
>   (equal? grob (car siblings)))
>  (null? siblings))
>  (ly:grob-set-property! tuplet-number 'X-offset 0))
>  (ly:tuplet-bracket::print grob)))
> }
>
> %%{
> \new Staff { \tst \tuplet 1/1 { \repeat unfold 30 c'1 } }
> %}
> %%{
> \new Staff { \tst \tuplet 1/1 { c'1 c'1 c' c' c' } }
> %}
>
>

I notice the same variability with 2.19.56 and 2.18.2.  I'll see if I
can figure out more.

Best,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add scriptExceptions property/convenience functions (issue 324740043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/04/07 17:30:25, dak wrote:

On 2017/04/05 15:55:38, david.nalesnik wrote:
> On 2017/04/05 15:47:19, pkx166h wrote:
> > Do you want this tested?
> >
> > I cannot see any tracker issue for this.
> >
> > Or is this just some work-in-progress design before you have a

patch for

> testing
> > proper?
> >
> > James
>
> It's associated with Issue 4276.
>
> It would be great if you could test this.
>
> I do think that some discussion is in order over the relative merits

of this

> context-property approach vs. the tweaking approach linked to in the
description
> of 4276.
>
> Thanks!



My personal take on this would be to allow overriding, say, \override
Script.accent.padding = #2.0 .  And maybe that's where all of the

script

definitions should be in the first place.


Yes, I've considered just this syntax and believe it would be best.

The context-property method breaks down because of the way
create_script_from_event in lily/script-engraver.cc negotiates between
properties listed in scriptDefinitions (or, by extension, in the
property scriptExceptions added by the patch) on the one hand, and
properties from the grob-definition of Script/possibly introduced by
user overrides on the other.

The user expectation would be that any property they put in
scriptExceptions should have an effect, but that's not the case because
of the fragile way create_script_from_event creates its property lists.
Values for 'staff-padding are thrown out, because the value in the
grob-description of Script (0.15) is an acceptable value
(ly:dimension?).  Values for 'rotation are also thrown out -- here
because the default value is unset, meaning '(), which is an acceptable
value for 'rotation because the property takes a list!

I see no way to make a context property holding exceptions work with the
system in place.  (Which is why I set the patch to needs work.)

I'll work on putting an override system in place.

https://codereview.appspot.com/324740043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add scriptExceptions property/convenience functions (issue 324740043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/04/05 15:47:19, pkx166h wrote:

Do you want this tested?



I cannot see any tracker issue for this.



Or is this just some work-in-progress design before you have a patch

for testing

proper?



James


It's associated with Issue 4276.

It would be great if you could test this.

I do think that some discussion is in order over the relative merits of
this context-property approach vs. the tweaking approach linked to in
the description of 4276.

Thanks!

https://codereview.appspot.com/324740043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Add scriptExceptions property/convenience functions (issue 324740043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
I've noticed that setting some properties with this patch doesn't have
an effect: for example, rotation and staff-padding.

Is the best way to approach this issue through the tweak method linked
to in the description on the issue tracker?

Description:
Add scriptExceptions property/convenience functions

These is currently no convenient way to change default
settings for a specific articulation-type.

 -- This commit adds a new context property, scriptExceptions,
which holds custom user settings to modify the default
scriptDefinitions.  The data structure is modeled after
scriptDefinitions and the public variable
default-script-alist.

The settings in scriptExceptions are simply added to the
head of the property-value alists of the indicated scripts.
New settings will be used by virtue of appearing before the
default settings, and there is no need to include settings
of untouched properties because the defaults are still present.

 -- Add two convenience functions for easily modifying settings
for a single articulation type: \addScriptExceptions and
\removeScriptExceptions

 -- Add two regtests and a Changes entry.

Please review this at https://codereview.appspot.com/324740043/

Affected files (+180, -0 lines):
  M Documentation/changes.tely
  A input/regression/script-exceptions.ly
  A input/regression/script-exceptions-adding-removing.ly
  M lily/script-engraver.cc
  M ly/music-functions-init.ly
  M scm/define-context-properties.scm



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Implement spacing-pair for MeasureCounter (issue 319610043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review -- thanks!

Description:
Implement spacing-pair for MeasureCounter

Since MeasureCounter grobs are bounded by columns, sophisticated
horizontal positioning is available relative to "prefatory
materials" (such as barlines, clefs, and key signatures) at the
beginning and end of measures.  This allows numbers to be
placed above full-measure rests which have been similarly adjusted
with 'spacing-pair.

The previous default is established in the grob description: count
objects are centered between BreakAlignment grobs.

Paper_column::break_align_width is made available to Scheme as
ly:paper-column:break-align-width.

Please review this at https://codereview.appspot.com/319610043/

Affected files (+39, -26 lines):
  M lily/paper-column.cc
  M scm/define-grob-interfaces.scm
  M scm/define-grobs.scm
  M scm/output-lib.scm


Index: lily/paper-column.cc
diff --git a/lily/paper-column.cc b/lily/paper-column.cc
index  
5462027928693c15aa9a85d00ccca134b8945173..85b60909c1bdb1fb6cf926c79da8bf42d2497f56  
100644

--- a/lily/paper-column.cc
+++ b/lily/paper-column.cc
@@ -226,6 +226,22 @@ Paper_column::break_align_width (Grob *me, SCM  
align_syms)

   return align->extent (p, X_AXIS);
 }

+LY_DEFINE  
(ly_paper_column__break_align_width, "ly:paper-column::break-align-width",

+   2, 0, 0, (SCM col, SCM align_syms),
+   "Determine the extent along the X-axis of a grob used for"
+   " break-alignment organized by column @var{col}. The grob is"
+   " specified by @code{align-syms}, which contains either a"
+   " single @code{break-align-symbol} or a list of such"
+   " symbols.")
+{
+  LY_ASSERT_SMOB (Grob, col, 1);
+  SCM_ASSERT_TYPE (scm_is_symbol (align_syms) || ly_is_list (align_syms),
+   align_syms, SCM_ARG2, __FUNCTION__, "symbol or list");
+
+  Interval ext = Paper_column::break_align_width (unsmob (col),  
align_syms);

+  return ly_interval2scm (ext);
+}
+
 /*
   Loop through elements of a PaperColumn, find all grobs implementing  
specified

   interface and return their combined extent.
Index: scm/define-grob-interfaces.scm
diff --git a/scm/define-grob-interfaces.scm b/scm/define-grob-interfaces.scm
index  
ffcfc355113af36777ec91bb8bce72930e5a870b..31188d0d8ea8156e1b762a7512522fbc39f120de  
100644

--- a/scm/define-grob-interfaces.scm
+++ b/scm/define-grob-interfaces.scm
@@ -204,7 +204,8 @@ accidentals)."
  'measure-counter-interface
  "A counter for numbering measures."
  '(columns
-   count-from))
+   count-from
+   spacing-pair))

 (ly:add-interface
  'metronome-mark-interface
Index: scm/define-grobs.scm
diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index  
45cac04bd3d65b1146beec8acdf89b42bcf8be7c..d3b4b9f06e42b73be7219067a80c9406261a2820  
100644

--- a/scm/define-grobs.scm
+++ b/scm/define-grobs.scm
@@ -1453,6 +1453,7 @@
 (outside-staff-priority . 750)
 (self-alignment-X . ,CENTER)
 (side-axis . ,Y)
+(spacing-pair . (break-alignment . break-alignment))
 (staff-padding . 0.5)
 (stencil . ,measure-counter-stencil)
 (meta . ((class . Spanner)
Index: scm/output-lib.scm
diff --git a/scm/output-lib.scm b/scm/output-lib.scm
index  
8df9b56ef2489c4bcbd6737c71523016bf405d27..2f74918bdc7c3b292710bf170634128b23e7393f  
100644

--- a/scm/output-lib.scm
+++ b/scm/output-lib.scm
@@ -1508,43 +1508,38 @@ parent or the parent has no setting."
 ;; measure counter

 (define-public (measure-counter-stencil grob)
-  "Print a number for a measure count.  The number is centered using
-the extents of @code{BreakAlignment} grobs associated with the left and
-right bounds of a @code{MeasureCounter} spanner.  Broken measures are
-numbered in parentheses."
+  "Print a number for a measure count.  Broken measures are numbered in
+parentheses."
   (let* ((num (make-simple-markup
-   (number->string (ly:grob-property grob 'count-from
+(number->string (ly:grob-property grob 'count-from
  (orig (ly:grob-original grob))
  (siblings (ly:spanner-broken-into orig)) ; have we been split?
  (num
-  (if (or (null? siblings)
-  (eq? grob (car siblings)))
+   (if (or (null? siblings)
+   (eq? grob (car siblings)))
   num
   (make-parenthesize-markup num)))
  (num (grob-interpret-markup grob num))
- (num (ly:stencil-aligned-to num X (ly:grob-property  
grob 'self-alignment-X)))

+ (num (ly:stencil-aligned-to
+   num X (ly:grob-property grob 'self-alignment-X)))
  (left-bound (ly:spanner-bound grob LEFT))
  (right-bound (ly:spanner-bound grob RIGHT))
- (elts-L (ly:grob-array->list (ly:grob-object  
left-bound 'elements)))
- (elts-R (ly:grob-array->list (ly:grob-object  
right-bound 'elements)))

- (break-alignment-L
-   (filter
- (lambda (elt) 

Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/03/29 22:00:12, pkx166h wrote:

>
> Sorry, I mean the *first* snippet.  (The count that begins with two

could be

> pushed further from the staff possibly.)



Yes that is probably a good idea (if you could add something that

would normally

collide - would a slur/tie *over* one of the group of notes work? - to

give such

an 'excuse' to use the padding?


There won't be any collisions -- the numbers will automatically avoid
them.

{
  \startMeasureCount
  c''4( c-\accent-\staccato-\marcato g'' d)
  \stopMeasureCount
}

The only good excuse to use staff-padding would be in an example such as
in the snippet I provided with the patch: getting all numbers at the
same level where different content in one measure would ordinarily push
the number higher than the number in another measure.  But as Simon
points out, the usage of staff-padding for this purpose is already well
documented.  There's no need for a new snippet, and I see no convenient
way to slip staff-padding into one of the existing snippets without it
being an "unjustified" change.



Also we should have a changes.tely entry as well - use your original

snippet as

the example there to use the work you have already done.



This is a simple bugfix of something that should have worked since the
MeasureCounter was introduced in 2.17.something.  As such, I don't think
a Changes entry is warranted.

I would propose simply that I fix that bug only, nothing else -- no
extra snippet, no changes to the existing snippets (which are already
dense enough with information).  So I am inclined to upload a patch just
with the scm/define-grobs.scm alterations.



https://codereview.appspot.com/312580043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/03/29 12:40:32, david.nalesnik wrote:

On 2017/03/29 11:08:17, simon.albrecht wrote:
> I’m not sure if a doc snippet is really necessary.  Using

staff-padding is

> explained in
>


and

>


,


> IIRC we want to be careful about extending the NR, don’t we?



I have no particular attachment to the snippet, so if it's redundant

I'll remove

it.



> so maybe a verbal remark in the section on Measure counts with a

link there

> might suffice.



Besides its IR page, MeasureCounter is documented right now through

two

snippets:



http://lilypond.org/doc/v2.19/Documentation/snippets/repeats#repeats-numbering-groups-of-measures


http://lilypond.org/doc/v2.19/Documentation/snippets/repeats#repeats-centered-measure-numbers


I could amend the second snippet to use staff-padding?  Other than

that, I don't

see a convenient way to mention it.


Sorry, I mean the *first* snippet.  (The count that begins with two
could be pushed further from the staff possibly.)


https://codereview.appspot.com/312580043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/03/29 11:08:17, simon.albrecht wrote:

I’m not sure if a doc snippet is really necessary.  Using

staff-padding is

explained in


and

,


IIRC we want to be careful about extending the NR, don’t we?


I have no particular attachment to the snippet, so if it's redundant
I'll remove it.


so maybe a verbal remark in the section on Measure counts with a link

there

might suffice.


Besides its IR page, MeasureCounter is documented right now through two
snippets:

http://lilypond.org/doc/v2.19/Documentation/snippets/repeats#repeats-numbering-groups-of-measures

http://lilypond.org/doc/v2.19/Documentation/snippets/repeats#repeats-centered-measure-numbers

I could amend the second snippet to use staff-padding?  Other than that,
I don't see a convenient way to mention it.


https://codereview.appspot.com/312580043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Allow 'staff-padding to work with MeasureCounter (issue 312580043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!


Description:
Allow 'staff-padding to work with MeasureCounter

 -Set 'Y-offset in the grob description to the appropriate
callback.  (This is required for the default setting of
'staff-padding to have any effect.)

 -Provide a doc snippet to illustrate vertical alignment.

Please review this at https://codereview.appspot.com/312580043/

Affected files (+41, -0 lines):
  A Documentation/snippets/new/measure-counter-vertical-alignment.ly
  M scm/define-grobs.scm


Index: Documentation/snippets/new/measure-counter-vertical-alignment.ly
diff --git  
a/Documentation/snippets/new/measure-counter-vertical-alignment.ly  
b/Documentation/snippets/new/measure-counter-vertical-alignment.ly

new file mode 100644
index  
..6c20f509f394558fbc696e3c03eb206f32064e4f

--- /dev/null
+++ b/Documentation/snippets/new/measure-counter-vertical-alignment.ly
@@ -0,0 +1,40 @@
+\version "2.19.59"
+
+\header {
+  lsrtags = "repeats"
+
+  texidoc = "
+The @code{staff-padding} property may be used to align
+@code{MeasureCounter} objects vertically.  A group of such objects
+are aligned when @code{staff-padding} has a value greater or equal to
+the distance of the object furthest from the staff.  In the following
+example @code{staff-padding} is increased from the default (shown first)
+to align the first two numbers and finally all three.
+
+"
+  doctitle = "Measure counter vertical alignment"
+}
+
+music = {
+  \startMeasureCount
+  c''2 c''
+  c'''2 c'''
+  c2 c
+  \bar "||"
+  \stopMeasureCount
+}
+
+{
+  \music
+  \override Staff.MeasureCounter.staff-padding = 4
+  \music
+  \override Staff.MeasureCounter.staff-padding = 8
+  \music
+}
+
+\layout {
+  \context {
+\Staff
+\consists #Measure_counter_engraver
+  }
+}
Index: scm/define-grobs.scm
diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm
index  
45cac04bd3d65b1146beec8acdf89b42bcf8be7c..cdea705c4d6f186122ed164e84b72f0a7079359f  
100644

--- a/scm/define-grobs.scm
+++ b/scm/define-grobs.scm
@@ -1455,6 +1455,7 @@
 (side-axis . ,Y)
 (staff-padding . 0.5)
 (stencil . ,measure-counter-stencil)
+(Y-offset . ,side-position-interface::y-aligned-side)
 (meta . ((class . Spanner)
  (interfaces . (font-interface
 measure-counter-interface



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES - Countdown for Wednesday March 22nd

[David Nalesnik]

On Thu, Mar 23, 2017 at 3:17 PM, James <p...@gnu.org> wrote:
> Hello,
>
>
> On 22/03/17 15:32, Phil Holmes wrote:
>>
>> - Original Message - From: "David Nalesnik"
>> <david.nales...@gmail.com>
>> To: "James" <p...@gnu.org>
>> Cc: "Dev" <lilypond-devel@gnu.org>
>> Sent: Wednesday, March 22, 2017 1:11 PM
>> Subject: Re: PATCHES - Countdown for Wednesday March 22nd
>>
>>
>>> Hi James,
>>>
>>> On Wed, Mar 22, 2017 at 2:27 AM, James <p...@gnu.org> wrote:
>>>>
>>>> Hello,
>>>>
>>>> Here is the current patch countdown list. The next countdown will be on
>>>> March 25th
>>>>
>>>>
>>>> A quick synopsis of all patches currently in the review process can be
>>>> found here:
>>>>
>>>> http://philholmes.net/lilypond/allura/
>>>>
>>>> 
>>>>
>>>
>>> Just remembered to update an issue for which I supplied a patch to
>>> "Started" (https://sourceforge.net/p/testlilyissues/issues/5097/).
>>> Checking the philholmes site, it's been associated with a Rietveld
>>> issue not mine.  The Allura link points to the right patchset, however
>>> (http://codereview.appspot.com/317460043).
>>>
>>> David
>>
>>
>>
>> My page was designed as a helper for James and it obviously struggles to
>> parse which is the correct Rietveld cited on that issue.  I tried to edit
>> Thomas's post but the edit wasn't successful.  Don't really know what to do
>> but bring it to James's attention and ignore it apart from that.
>
>
> OK I just edited the 'main description' part (I don't know what that field
> is officially called) so that the correct Rietveld is seen right at the
> start.
>
> This is good enough for Phil's scraper.
>
> I'll watch out for that in future.
>
> Thanks
>

Appreciate it!

Thank you,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES - Countdown for Wednesday March 22nd

[David Nalesnik]

Hi James,

On Wed, Mar 22, 2017 at 2:27 AM, James  wrote:
> Hello,
>
> Here is the current patch countdown list. The next countdown will be on
> March 25th
>
>
> A quick synopsis of all patches currently in the review process can be
> found here:
>
> http://philholmes.net/lilypond/allura/
>
> 
>

Just remembered to update an issue for which I supplied a patch to
"Started" (https://sourceforge.net/p/testlilyissues/issues/5097/).
Checking the philholmes site, it's been associated with a Rietveld
issue not mine.  The Allura link points to the right patchset, however
(http://codereview.appspot.com/317460043).

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 5097: reach HorizontalBracketText through directed tweak (issue 317460043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!

Description:
Issue 5097: reach HorizontalBracketText through directed tweak

HorizontalBracketText is now caused by HorizontalBracket, rather
than the same note-grouping event.

Fix a number of programming errors caused by commit for Issue
5064.

Please review this at https://codereview.appspot.com/317460043/

Affected files (+12, -11 lines):
  M Documentation/changes.tely
  M Documentation/snippets/new/analysis-brackets-with-labels.ly
  M input/regression/horizontal-bracket-broken-texted.ly
  M input/regression/horizontal-bracket-texted.ly
  M lily/horizontal-bracket-engraver.cc


Index: Documentation/changes.tely
diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index  
f205d0014cb270556d9d6c1bf52de721d4d0e13b..b9782edbb85486b12fc6cc9575408c4564771b0f  
100644

--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -75,7 +75,7 @@ It is now possible to add text to analysis brackets  
through the

 {
   \once \override HorizontalBracketText.text = "a"
   c''\startGroup d''\stopGroup
-  e''-\tweak text "a'" \startGroup d''\stopGroup
+  e''-\tweak HorizontalBracketText.text "a'" \startGroup d''\stopGroup
 }
 @end lilypond

Index: Documentation/snippets/new/analysis-brackets-with-labels.ly
diff --git a/Documentation/snippets/new/analysis-brackets-with-labels.ly  
b/Documentation/snippets/new/analysis-brackets-with-labels.ly
index  
30ae349b05bfc5960454af299f53ed464afa8a4f..93f65ea49d413b9853c63684242653b28f298824  
100644

--- a/Documentation/snippets/new/analysis-brackets-with-labels.ly
+++ b/Documentation/snippets/new/analysis-brackets-with-labels.ly
@@ -27,12 +27,12 @@ Bracket text will be parenthesized after a line break.
   \once\override HorizontalBracketText.text = "a'"
   e''\startGroup d''\stopGroup
   c''
-  -\tweak text \markup \bold \huge "b" \startGroup
-  -\tweak text "a" \startGroup
+  -\tweak HorizontalBracketText.text \markup \bold \huge "b" \startGroup
+  -\tweak HorizontalBracketText.text "a" \startGroup
   d''\stopGroup
-  e''-\tweak text "a'" \startGroup
+  e''-\tweak HorizontalBracketText.text "a'" \startGroup
   d''\stopGroup\stopGroup
-  c''-\tweak text foo \startGroup d'' e'' f''
+  c''-\tweak HorizontalBracketText.text foo \startGroup d'' e'' f''
   \break
   g'' a'' b'' c'''\stopGroup
 }
Index: input/regression/horizontal-bracket-broken-texted.ly
diff --git a/input/regression/horizontal-bracket-broken-texted.ly  
b/input/regression/horizontal-bracket-broken-texted.ly
index  
1f8455261e169d2273c480908bd48e986c7ac5e5..00bcac987f38a33e759cb3d981f3d3432e466dbd  
100644

--- a/input/regression/horizontal-bracket-broken-texted.ly
+++ b/input/regression/horizontal-bracket-broken-texted.ly
@@ -15,11 +15,12 @@ breaks.

 {
   c''
-  -\tweak text \markup \draw-circle #1 #0.5 ##f \startGroup
-  -\tweak text "a" \startGroup
+  -\tweak HorizontalBracketText.text \markup \draw-circle #1 #0.5 ##f
+  \startGroup
+  -\tweak HorizontalBracketText.text "a" \startGroup
   d'' e'' f''
   g'' a'' b'' c'''\stopGroup
-  c'''-\tweak text "a'" \startGroup b'' a'' g''
+  c'''-\tweak HorizontalBracketText.text "a'" \startGroup b'' a'' g''
   \break
   f'' e'' d'' c''\stopGroup\stopGroup
 }
Index: input/regression/horizontal-bracket-texted.ly
diff --git a/input/regression/horizontal-bracket-texted.ly  
b/input/regression/horizontal-bracket-texted.ly
index  
dc1a673a08423ec037cb2a4c30f44a7c73845327..0ab4520236bb2240b89af8f7b3473dbfe3dcee8d  
100644

--- a/input/regression/horizontal-bracket-texted.ly
+++ b/input/regression/horizontal-bracket-texted.ly
@@ -21,8 +21,8 @@ usual nesting order of brackets.
   \time 3/4
   \key f \major
   c4
-  -\tweak text "contrasting period" \startGroup
-  -\tweak text "a" \startGroup
+  -\tweak HorizontalBracketText.text "contrasting period" \startGroup
+  -\tweak HorizontalBracketText.text "a" \startGroup
   a8( bes c f)
   f4( e d)
   c d8( c bes c)
Index: lily/horizontal-bracket-engraver.cc
diff --git a/lily/horizontal-bracket-engraver.cc  
b/lily/horizontal-bracket-engraver.cc
index  
1f176a321591a5c18b5446e506ed8182c3266199..860495750ad4124c5cff1c9c0b432800b668dfb6  
100644

--- a/lily/horizontal-bracket-engraver.cc
+++ b/lily/horizontal-bracket-engraver.cc
@@ -94,7 +94,7 @@ Horizontal_bracket_engraver::process_music ()
 {
   Spanner *sp = make_spanner ("HorizontalBracket",  
events_[k]->self_scm ());


-  Spanner *hbt = make_spanner ("HorizontalBracketText",  
events_[k]->self_scm ());
+  Spanner *hbt = make_spanner ("HorizontalBracketText", sp->self_scm  
());


   sp->set_object ("bracket-text", hbt->self_scm ());




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: checking grob type

[David Nalesnik]

On Fri, Mar 17, 2017 at 9:50 AM, Paul <p...@paulwmorris.com> wrote:
> cc'ing lilypond-devel to move discussion there.
>
> On 03/17/2017 09:38 AM, David Nalesnik wrote:
>
>> You can get more info about public functions with the attached file.
>> I was planning on getting documentation into the manuals somehow, but
>> I got hung up with getting the parameters of curried functions.
>
>
> Hi David,  Thanks for your work on this.  Is there an easy way to just omit
> any curried functions in a first-pass at this?  (I wonder what percentage
> are curried?)

I never found it.

The problem is that a parameter isn't shown:

#(define ((curried arg) grob) '())
#(display curried)

==> #

>
>> Also, of course, publicizing a number of these probably won't do
>> anybody a bit of good.
>
>
> Maybe we could just have a list of functions to document publicly (or to not
> document)?

I suppose a metric could be usage in the code base, but I'd hate to
get into a function-by-function discussion for the rest!

>
>> In lieu of actual documentation, I could add a Scheme function?
>
>
> Seems like actual docs would be better in the long run, but I guess it
> depends on how much they would take to implement.
>

Yes, real documentation would certainly be best.  Shouldn't have
implied "instead of": I meant in the meantime (and later, in addition)
it would be nice to have a convenience function to return everything
available.  And it would need to be in C++ so it wouldn't need to be
invoked to reveal itself :)

David.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix dashed line errors (issue 320320043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!

Description:
Fix dashed line errors

There are two errors in lily/line-interface.cc which cause
dashed lines to be drawn inaccurately.

(1) Line-thickness is improperly subtracted from the "off"
value in Line_interface::make_dashed_line.  This was done,
presumably, to account for the line cap of each dash.  In fact,
PostScript discounts the line cap when constructing the pattern.

(2) Dashed lines are constructed so that they begin and end
with a dash.  Thus, a dashed line is built of dash + whitespace
units and a last lone dash.  Period is not adjusted in
Line_interface::line for this last dash, which can lead to a
noticeable difference in its length compared to other dashes.

Correcting these flaws ensures that dashed lines end with a
dash rather than whitespace, and that terminating dashes are
not clipped.  Also, the number of dashes drawn reflects the
number calculated.

Please review this at https://codereview.appspot.com/320320043/

Affected files (+13, -8 lines):
  M lily/line-interface.cc


Index: lily/line-interface.cc
diff --git a/lily/line-interface.cc b/lily/line-interface.cc
index  
bc0895339fea3c996e08a71891c0090cbea2e96c..9c16ece4106f956af5cb3a30cb4fc667065abab8  
100644

--- a/lily/line-interface.cc
+++ b/lily/line-interface.cc
@@ -123,8 +123,8 @@ Line_interface::make_dashed_line (Real thick, Offset  
from, Offset to,

   Real dash_period, Real dash_fraction)
 {
   dash_fraction = min (max (dash_fraction, 0.0), 1.0);
-  Real on = dash_fraction * dash_period;
-  Real off = max (0.0, dash_period - on - thick);
+  Real on = dash_fraction * dash_period;
+  Real off = max (0.0, dash_period - on);

   SCM at = scm_list_n (ly_symbol2scm ("dashed-line"),
scm_from_double (thick),
@@ -226,16 +226,21 @@ Line_interface::line (Grob *me, Offset from, Offset  
to)

 return Stencil ();

   Real len = (to - from).length ();
-
-  int n = (int) rint ((len - period * fraction) / period);
-  n = max (0, n);
-  if (n > 0)
+  /*
+Dashed lines should begin and end with a dash.  Therefore,
+there will be one more dash than complete dash + whitespace
+units (full periods).
+  */
+  int full_period_count =
+(int) rint ((len - period * fraction) / period);
+  full_period_count = max (0, full_period_count);
+  if (full_period_count > 0)
 {
   /*
 TODO: figure out something intelligent for really short
 sections.
-   */
-  period = ((to - from).length () - period * fraction) / n;
+  */
+  period = len / (fraction + full_period_count);
 }
   stencil = make_dashed_line (thick, from, to, period, fraction);
 }



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Create Bracket class (issue 314610043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!

Description:
Create Bracket class

Code involving brackets suffers from two confusing
organizational issues:

(1) Tuplet_bracket::make_bracket is used to create brackets
for a number of grobs: BassFigureBracket, HorizontalBracket,
OttavaBracket, PianoPedalBracket, VoltaBracket, along with
TupletBracket

(2) Methods belonging to Horizontal_bracket are used to draw
both horizonal brackets (HorizontalBracket) and vertical
brackets (BassFigureBracket)

To remedy this, a new Bracket class is created.

This new class contains the old Tuplet_bracket::make_bracket,
Horizontal_bracket::make_bracket, and
Horizontal_bracket::make_enclosing_bracket.

These methods have been renamed to clarify their purpose.

Please review this at https://codereview.appspot.com/314610043/

Affected files (+199, -178 lines):
  A lily/bracket.cc
  M lily/enclosing-bracket.cc
  M lily/horizontal-bracket.cc
  A + lily/include/bracket.hh
  M lily/include/horizontal-bracket.hh
  M lily/include/tuplet-bracket.hh
  M lily/ottava-bracket.cc
  M lily/piano-pedal-bracket.cc
  M lily/tuplet-bracket.cc
  M lily/volta-bracket.cc



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: can't upload a patch

[David Nalesnik]

On Mon, Mar 6, 2017 at 8:56 AM, David Kastrup <d...@gnu.org> wrote:
> David Nalesnik <david.nales...@gmail.com> writes:
>
>> On Mon, Mar 6, 2017 at 8:29 AM, Federico Bruni <f...@inventati.org> wrote:
>>>
>>>
>>> Il giorno lun 6 mar 2017 alle 14:50, David Nalesnik
>>> <david.nales...@gmail.com> ha scritto:
>>>>
>>>> Hi Federico,
>>>>
>>>> On Mon, Mar 6, 2017 at 1:15 AM, Federico Bruni <f...@inventati.org> wrote:
>>>>>
>>>>>  Do you have ca-certificates installed?
>>>>
>>>>
>>>> Yes, the newest version:
>>>>
>>>> ca-certificates/now 20141019+deb8u1 all [installed,local]
>>>
>>> Ok. Even though it seems an out-of-date package. Shouldn't it be version
>>> 20160104 as shown here?
>>> http://packages.ubuntu.com/yakkety/ca-certificates
>>
>> Strange.  The package did strike me as old, but running
>>
>> sudo apt-get install ca-certificates
>>
>> gets me
>>
>> Reading package lists... Done
>> Building dependency tree
>> Reading state information... Done
>> ca-certificates is already the newest version.
>> 0 upgraded, 0 newly installed, 0 to remove and 69 not upgraded.
>
> Maybe it's pinned or the version number is spelled in a manner where it
> is considered newer.
>
> Try removing and reinstalling it if possible without having other
> packages removed.  Otherwise, try forcing the update.
>

The version in Ubuntu is the one from 2016; the one in the Debian
machine is the older one, from 2014.  I'm not sure what to install to
bring the Debian version more up-to-date, without screwing the system
up.

I managed to upload the patch successfully
(https://sourceforge.net/p/testlilyissues/issues/5084/) by installing
git-cl in Ubuntu -- thanks Federico!

So, I haven't verified whether the problem is the ca-certificates
version or the VM's network interface.  I'll try an Ethernet cable
instead of the wireless adapter next.

Thanks so much,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: can't upload a patch

[David Nalesnik]

On Mon, Mar 6, 2017 at 8:29 AM, Federico Bruni <f...@inventati.org> wrote:
>
>
> Il giorno lun 6 mar 2017 alle 14:50, David Nalesnik
> <david.nales...@gmail.com> ha scritto:
>>
>> Hi Federico,
>>
>> On Mon, Mar 6, 2017 at 1:15 AM, Federico Bruni <f...@inventati.org> wrote:
>>>
>>>  Do you have ca-certificates installed?
>>
>>
>> Yes, the newest version:
>>
>> ca-certificates/now 20141019+deb8u1 all [installed,local]
>>
>
> Ok. Even though it seems an out-of-date package. Shouldn't it be version
> 20160104 as shown here?
> http://packages.ubuntu.com/yakkety/ca-certificates

Strange.  The package did strike me as old, but running

sudo apt-get install ca-certificates

gets me

Reading package lists... Done
Building dependency tree
Reading state information... Done
ca-certificates is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 69 not upgraded.


> Did you try uploading the patch with git-cl from the host (ubuntu)?
> Does it work?
>
> If it does, I'd start debugging the network connection in the guest.
>

Will try this.

Thanks!

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: can't upload a patch

[David Nalesnik]

Hi Federico,

On Mon, Mar 6, 2017 at 1:15 AM, Federico Bruni <f...@inventati.org> wrote:
> Do you have ca-certificates installed?

Yes, the newest version:

ca-certificates/now 20141019+deb8u1 all [installed,local]


>
> Il 6 marzo 2017 01:23:26 CET, David Nalesnik <david.nales...@gmail.com> ha
> scritto:
>>
>> Not too long ago, I wrote to the list about an inability to upload
>> patches.  A Rietveld tracker issue is created, but the process
>> terminates before all of the base files can be uploaded.  An Allura
>> issue is never created.
>>
>> I was using a VirtualBox VM on a Windows 10 system.
>>
>> Now, on a different machine, no Windows, with Ubuntu 16.10 and LilyDev
>> 4.1 running (also in VirtualBox), I get the same result.
>>
>> Here is what happens when I attempt to upload a patch:
>>
>> [lilypond-git (dev/bracket_reorganization)]$ git-cl upload origin/master
>>  lily/bracket.cc| 151
>> +
>>  lily/enclosing-bracket.cc  |  16 ++--
>>  lily/horizontal-bracket.cc |  73 +-
>>  lily/include/bracket.hh|  40 ++
>>  lily/include/horizontal-bracket.hh |   5 --
>>  lily/include/tuplet-bracket.hh |   4 -
>>  lily/ottava-bracket.cc |  11 ++-
>>  lily/piano-pedal-bracket.cc|  10 +--
>>  lily/tuplet-bracket.cc |  78 +++
>>  lily/volta-bracket.cc  |   9 +--
>>  10 files changed, 227 insertions(+), 170 deletions(-)
>> Upload server: codereview.appspot.com (change with -s/--server)
>> Your browser has been opened to visit:
>>
>> https://codereview.appspot.com/get-access-token?port=8001
>>
>> If your browser is on a different machine then exit and re-run
>> upload.py with the command-line parameter
>>
>>   --no_oauth2_webbrowser
>>
>> Issue created. URL: http://codereview.appspot.com/313670043
>> Uploading base file for lily/include/horizontal-bracket.hh
>> Uploading base file for lily/include/tuplet-bracket.hh
>> Traceback (most recent call last):
>>   File "/home/david/git-cl/git-cl", line 628, in 
>> sys.exit(main(sys.argv))
>>   File "/home/david/git-cl/git-cl", line 622, in main
>> return func(argv[2:])
>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options,
>> files)
>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>> print t.get(timeout=60)
>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>> raise self._value
>> urllib2.URLError: 
>> [lilypond-git (dev/bracket_reorganization)]$
>>
>> _
>>
>> Does anybody have an idea of what could be happening?  Has anybody
>> experienced this problem?
>>
>> At my wit's end :(
>>
>> David
>>
>> 
>>
>> lilypond-devel mailing list
>> lilypond-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>
>
> --
> Inviato dal mio dispositivo Android con K-9 Mail. Perdonate la brevità.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

can't upload a patch

[David Nalesnik]

Not too long ago, I wrote to the list about an inability to upload
patches.  A Rietveld tracker issue is created, but the process
terminates before all of the base files can be uploaded.  An Allura
issue is never created.

I was using a VirtualBox VM on a Windows 10 system.

Now, on a different machine, no Windows, with Ubuntu 16.10 and LilyDev
4.1 running (also in VirtualBox), I get the same result.

Here is what happens when I attempt to upload a patch:

[lilypond-git (dev/bracket_reorganization)]$ git-cl upload origin/master
 lily/bracket.cc| 151 +
 lily/enclosing-bracket.cc  |  16 ++--
 lily/horizontal-bracket.cc |  73 +-
 lily/include/bracket.hh|  40 ++
 lily/include/horizontal-bracket.hh |   5 --
 lily/include/tuplet-bracket.hh |   4 -
 lily/ottava-bracket.cc |  11 ++-
 lily/piano-pedal-bracket.cc|  10 +--
 lily/tuplet-bracket.cc |  78 +++
 lily/volta-bracket.cc  |   9 +--
 10 files changed, 227 insertions(+), 170 deletions(-)
Upload server: codereview.appspot.com (change with -s/--server)
Your browser has been opened to visit:

https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser

Issue created. URL: http://codereview.appspot.com/313670043
Uploading base file for lily/include/horizontal-bracket.hh
Uploading base file for lily/include/tuplet-bracket.hh
Traceback (most recent call last):
  File "/home/david/git-cl/git-cl", line 628, in 
sys.exit(main(sys.argv))
  File "/home/david/git-cl/git-cl", line 622, in main
return func(argv[2:])
  File "/home/david/git-cl/git-cl", line 335, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/david/git-cl/upload.py", line 2693, in RealMain
vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
raise self._value
urllib2.URLError: 
[lilypond-git (dev/bracket_reorganization)]$

_

Does anybody have an idea of what could be happening?  Has anybody
experienced this problem?

At my wit's end :(

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

Hi Harm,

On Feb 20, 2017 3:19 PM, "Thomas Morley"  wrote:

2017-02-15 22:39 GMT+01:00 Thomas Morley :
> 2017-02-15 0:53 GMT+01:00 Thomas Morley :
>
>>> OK--I've made a patch update based on the review comments so far.
>>> (See attachment.)
>>
>> I'll upload it asap, which will likely be tomorrow evening.
>
> Done.
> I extended the commit message with the issue number.
>
> Cheers,
>   Harm

Hi David,

your patch has push-status.
https://sourceforge.net/p/testlilyissues/issues/5064/
Any changings/additions you want to have included?


No, it should be good to go.  Thanks again!

Best,
David
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

Hi Harm,

On Thu, Feb 9, 2017 at 8:10 AM, David Nalesnik <david.nales...@gmail.com> wrote:
> On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley <thomasmorle...@gmail.com> 
> wrote:
>> 2017-02-08 14:37 GMT+01:00 David Nalesnik <david.nales...@gmail.com>:
>>
>>> I notice that the patch has gotten swept up into the review process.
>>> If you like, I will tell James to remove it, or maybe put it into
>>> waiting so I can figure out how to fix my machine?  (It's already
>>> gotten a review!) I don't want to put you or anybody to extra trouble.
>>
>
> Hi Harm,
>
>>
>> Hi David,
>>
>> I'd happily shepherd this issue.
>> It would be a pitty to waste the already started review.
>>
>> I doubt I can help figuring out whats wrong with your VB, though, if
>> you think I can check/test anything from my end, please shout.
>>
>
> Thanks--I appreciate this!  I'll wait to collect a good number of
> review comments before submitting any updates.
>

OK--I've made a patch update based on the review comments so far.
(See attachment.)

Maybe the solution to the problem is to scrap Win10 altogether.  The
insidious updates seem to have messed up my permissions, so I can't
update VirtualBox -- even running the installer as an administrator.
(Was hoping that a newer version would correct the problem I'm
having.)

Anyway, thanks!

David
From 0fd5890a32e9cb298853b6b8187a51d6ef7bfbc4 Mon Sep 17 00:00:00 2001
From: David Nalesnik <david.nales...@gmail.com>
Date: Sat, 4 Feb 2017 19:13:31 -0600
Subject: [PATCH] Let analysis brackets support text

Ability to add labels to brackets is essential for musical analysis.

This patch introduces a new grob, "HorizontalBracketText," a spanner
created along with "HorizontalBracket" by Horizontal_bracket_engraver.

Repeated text of broken brackets is parenthesized.
---
 Documentation/changes.tely | 18 ++
 Documentation/notation/editorial.itely | 13 ++--
 .../snippets/new/analysis-brackets-with-labels.ly  | 38 ++
 .../regression/horizontal-bracket-broken-texted.ly | 25 ++
 input/regression/horizontal-bracket-texted.ly  | 36 
 lily/horizontal-bracket-engraver.cc| 31 +++---
 lily/horizontal-bracket.cc |  6 +---
 scm/define-grob-interfaces.scm |  5 +++
 scm/define-grob-properties.scm |  1 +
 scm/define-grobs.scm   | 18 ++
 scm/output-lib.scm | 27 +++
 11 files changed, 206 insertions(+), 12 deletions(-)
 create mode 100644 Documentation/snippets/new/analysis-brackets-with-labels.ly
 create mode 100644 input/regression/horizontal-bracket-broken-texted.ly
 create mode 100644 input/regression/horizontal-bracket-texted.ly

diff --git a/Documentation/changes.tely b/Documentation/changes.tely
index 2a64778..f205d00 100644
--- a/Documentation/changes.tely
+++ b/Documentation/changes.tely
@@ -62,6 +62,24 @@ which scares away people.
 @end ignore
 
 @item
+It is now possible to add text to analysis brackets through the
+@code{HorizontalBracketText} object.
+@lilypond[quote,verbatim]
+\layout {
+  \context {
+\Voice
+\consists "Horizontal_bracket_engraver"
+  }
+}
+
+{
+  \once \override HorizontalBracketText.text = "a"
+  c''\startGroup d''\stopGroup
+  e''-\tweak text "a'" \startGroup d''\stopGroup
+}
+@end lilypond
+
+@item
 The ends of hairpins may now be fine-tuned using the @code{shorten-pair}
 grob property, which previously only affected text-spanners like
 @code{TupletBracket} and @code{OttavaBracket}.  Positive values offset
diff --git a/Documentation/notation/editorial.itely b/Documentation/notation/editorial.itely
index 458fce1..8dc3ac9 100644
--- a/Documentation/notation/editorial.itely
+++ b/Documentation/notation/editorial.itely
@@ -879,12 +879,19 @@ Analysis brackets may be nested.
 }
 @end lilypond
 
-@seealso
-Snippets:
-@rlsr{Editorial annotations}.
+@snippets
 
+@lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
+{analysis-brackets-above-the-staff.ly}
+
+@lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
+{analysis-brackets-with-labels.ly}
+
+@seealso
 Internals Reference:
 @rinternals{Horizontal_bracket_engraver},
 @rinternals{HorizontalBracket},
 @rinternals{horizontal-bracket-interface},
+@rinternals{HorizontalBracketText},
+@rinternals{horizontal-bracket-text-interface},
 @rinternals{Staff}.
diff --git a/Documentation/snippets/new/analysis-brackets-with-labels.ly b/Documentation/snippets/new/analysis-brackets-with-labels.ly
new file mode 100644
index 000..30ae349
--- /dev/null
+++ b/Documentation/snippets/new/analysis-brackets-with-labels.ly
@@ -0,0 +1,38 @@
+\version "2.19.55

Re: trouble uploading a patch

[David Nalesnik]

On Wed, Feb 8, 2017 at 3:46 PM, Thomas Morley <thomasmorle...@gmail.com> wrote:
> 2017-02-08 14:37 GMT+01:00 David Nalesnik <david.nales...@gmail.com>:
>
>> I notice that the patch has gotten swept up into the review process.
>> If you like, I will tell James to remove it, or maybe put it into
>> waiting so I can figure out how to fix my machine?  (It's already
>> gotten a review!) I don't want to put you or anybody to extra trouble.
>

Hi Harm,

>
> Hi David,
>
> I'd happily shepherd this issue.
> It would be a pitty to waste the already started review.
>
> I doubt I can help figuring out whats wrong with your VB, though, if
> you think I can check/test anything from my end, please shout.
>

Thanks--I appreciate this!  I'll wait to collect a good number of
review comments before submitting any updates.

I'll do some more digging into the VM setup.  Hopefully, I'll be able
to fix this.

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

Hi Harm,

On Tue, Feb 7, 2017 at 7:46 PM, Thomas Morley <thomasmorle...@gmail.com> wrote:
> 2017-02-08 0:08 GMT+00:00 David Nalesnik <david.nales...@gmail.com>:
>> Harm,
>>
>> On Tue, Feb 7, 2017 at 5:57 PM, Thomas Morley <thomasmorle...@gmail.com> 
>> wrote:
>>> 2017-02-08 0:26 GMT+01:00 David Nalesnik <david.nales...@gmail.com>:
>>>
>>>>
>>>> I don't want to put anyone to the trouble of shepherding this for me,
>>>> since I can't predict how drawn out the review process will be.
>>>
>>>
>>> Nevertheless, how about sending me a git-formated patch?
>>> I could try to to upload. At least we could check whether it's a
>>> general git-cl problem or whether it's related to your setup.
>>> Though, I'll not able to do anything before tomorrow evening.
>>>
>>
>> OK, that would be much appreciated.  Patch attached.
>>
>> Thanks,
>> David
>
> Hi David,
>
> I found some time and had no problems uploading it.
>
> Although, I needed to do
> sudo /sbin/vboxconfig
> on my VirtualBox, which is $ uname -a
> Linux my-host 3.16.0-4-686-pae #1 SMP Debian 3.16.7-ckt11-1+deb8u3
> (2015-08-04) i686 GNU/Linux
>
> Here the terminal output for the upload
>
>
> [lilypond-git (dev/david-patch-test)]$ git cl upload origin/master
>  Documentation/changes.tely  | 18
> ++
>  Documentation/notation/editorial.itely  | 13 
> ++---
>  Documentation/snippets/new/analysis-brackets-with-labels.ly | 38
> ++
>  input/regression/horizontal-bracket-broken-texted.ly| 25
> +
>  input/regression/horizontal-bracket-texted.ly   | 33
> +
>  lily/horizontal-bracket-engraver.cc | 31
> +++
>  lily/horizontal-bracket.cc  |  6 +-
>  scm/define-grob-interfaces.scm  |  5 +
>  scm/define-grob-properties.scm  |  1 +
>  scm/define-grobs.scm| 18
> ++
>  scm/output-lib.scm  | 27
> +++
>  11 files changed, 203 insertions(+), 12 deletions(-)
> Upload server: codereview.appspot.com (change with -s/--server)
> Your browser has been opened to visit:
>
> https://codereview.appspot.com/get-access-token?port=8001
>
> If your browser is on a different machine then exit and re-run
> upload.py with the command-line parameter
>
>   --no_oauth2_webbrowser
>
> Issue created. URL: http://codereview.appspot.com/315570043
> Uploading base file for Documentation/changes.tely
> Uploading base file for scm/define-grob-properties.scm
> Uploading base file for scm/define-grobs.scm
> Uploading base file for
> Documentation/snippets/new/analysis-brackets-with-labels.ly
> Uploading base file for input/regression/horizontal-bracket-broken-texted.ly
> Uploading base file for lily/horizontal-bracket.cc
> Uploading base file for input/regression/horizontal-bracket-texted.ly
> Uploading base file for scm/define-grob-interfaces.scm
> Uploading base file for Documentation/notation/editorial.itely
> Uploading base file for lily/horizontal-bracket-engraver.cc
> Uploading base file for scm/output-lib.scm
> We were not able to associate this patch with a tracker issue.
> Please enter a valid tracker issue number
> (or enter nothing to create a new issue):
> Ticket created at: https://sourceforge.net/p/testlilyissues/issues/5064/
> Tracker issue done: 5064
>

Thanks for testing this!  It confirms what I was thinking--that this
is a problem on my end.

Though I do have an internet connection in my VirtualBox VM (on a
Win10 system), I seem not to be able to maintain a connection to
https://codereview.appspot.com for long enough for the uploads of all
the base files to happen.  Maybe something to do with a VirtualBox
configuration, maybe I have to figure out a way to request another
connection authomatically when one fails, I'm afraid I'm way out of my
depth here.

I notice that the patch has gotten swept up into the review process.
If you like, I will tell James to remove it, or maybe put it into
waiting so I can figure out how to fix my machine?  (It's already
gotten a review!) I don't want to put you or anybody to extra trouble.

Thanks again--
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Sat, Feb 4, 2017 at 7:02 PM, David Nalesnik <david.nales...@gmail.com> wrote:
> On Sat, Feb 4, 2017 at 6:45 PM, David Kastrup <d...@gnu.org> wrote:
>> David Nalesnik <david.nales...@gmail.com> writes:
>>
>>> On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup <d...@gnu.org> wrote:
>>>> David Nalesnik <david.nales...@gmail.com> writes:
>>>>
>>>>> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik
>>>>> <david.nales...@gmail.com> wrote:
>>>>>> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik
>>>>>> <david.nales...@gmail.com> wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> I'm trying to upload a patch for review, and I'm running into 
>>>>>>> difficulties.
>>>>>>>
>>>>>>> Using git-cl, I get this output:
>>>>>>>
>>>>>>> Issue created. URL: http://codereview.appspot.com/320140043
>>>>>>> Uploading base file for Documentation/changes.tely
>>>>>>> Uploading base file for scm/define-grob-properties.scm
>>>>>>> Uploading base file for scm/define-grobs.scm
>>>>>>> Uploading base file for
>>>>>>> Documentation/snippets/new/analysis-brackets-with-labels.ly
>>>>>>> Traceback (most recent call last):
>>>>>>>   File "/home/david/git-cl/git-cl", line 628, in 
>>>>>>> sys.exit(main(sys.argv))
>>>>>>>   File "/home/david/git-cl/git-cl", line 622, in main
>>>>>>> return func(argv[2:])
>>>>>>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>>>>>>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>>>>>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>>>>>>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, 
>>>>>>> files)
>>>>>>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>>>>>>> print t.get(timeout=60)
>>>>>>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>>>>>>> raise self._value
>>>>>>> urllib2.URLError: 
>>>>>>>
>>>>>>> The patch is visible here: https://codereview.appspot.com/320140043/
>>>>>>> but no issue has been created.
>>>>>>
>>>>>> Except that two files show "Error: old chunk mismatch":
>>>>>> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc
>>>>>
>>>>> I've tried uploading this a number of times, always the same results.
>>>>> The base files aren't uploaded for these two files.  (Current attempt:
>>>>> https://codereview.appspot.com/316280043/)
>>>>>
>>>>> Is the patch simply too large, and I'm losing the connection before
>>>>> all of the base files have been uploaded?
>>>>>
>>>>> If this is so, is there any way to get all of this uploaded and
>>>>> associated with a single issue?
>>>>
>>>> What command line have you been using for the upload attempt?
>>>>
>>>
>>> git-cl upload origin/master
>>>
>>> Has worked with all recent patches I've done.  They've all been
>>> noticeably smaller, though.
>>
>> Have you tried
>>
>> git rebase origin/master
>>
>> before calling git-cl?  I could imagine problems due to master not being
>> in your ancestry.
>
> Yes, I've run it a number of times.
>
> All I can think is that somewhere during the upload process I lose my
> authenticated connection with www.google.com.
>
> Hmmm.  I've rebased everything to a single commit, and that's what I'm
> uploading.  Maybe I should break it down into several commits?

Nope.  Broke it up into 4 commits.  Same result.

Always the same two files lead to "error: old chunk mismatch"--so the
base files aren't getting uploaded.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup <d...@gnu.org> wrote:
> David Nalesnik <david.nales...@gmail.com> writes:
>
>> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik <david.nales...@gmail.com> 
>> wrote:
>>> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik
>>> <david.nales...@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> I'm trying to upload a patch for review, and I'm running into difficulties.
>>>>
>>>> Using git-cl, I get this output:
>>>>
>>>> Issue created. URL: http://codereview.appspot.com/320140043
>>>> Uploading base file for Documentation/changes.tely
>>>> Uploading base file for scm/define-grob-properties.scm
>>>> Uploading base file for scm/define-grobs.scm
>>>> Uploading base file for
>>>> Documentation/snippets/new/analysis-brackets-with-labels.ly
>>>> Traceback (most recent call last):
>>>>   File "/home/david/git-cl/git-cl", line 628, in 
>>>> sys.exit(main(sys.argv))
>>>>   File "/home/david/git-cl/git-cl", line 622, in main
>>>> return func(argv[2:])
>>>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>>>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>>>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, 
>>>> files)
>>>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>>>> print t.get(timeout=60)
>>>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>>>> raise self._value
>>>> urllib2.URLError: 
>>>>
>>>> The patch is visible here: https://codereview.appspot.com/320140043/
>>>> but no issue has been created.
>>>
>>> Except that two files show "Error: old chunk mismatch":
>>> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc
>>
>> I've tried uploading this a number of times, always the same results.
>> The base files aren't uploaded for these two files.  (Current attempt:
>> https://codereview.appspot.com/316280043/)
>>
>> Is the patch simply too large, and I'm losing the connection before
>> all of the base files have been uploaded?
>>
>> If this is so, is there any way to get all of this uploaded and
>> associated with a single issue?
>
> What command line have you been using for the upload attempt?
>

git-cl upload origin/master

Has worked with all recent patches I've done.  They've all been
noticeably smaller, though.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik <david.nales...@gmail.com> wrote:
> On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik <david.nales...@gmail.com> 
> wrote:
>> Hi,
>>
>> I'm trying to upload a patch for review, and I'm running into difficulties.
>>
>> Using git-cl, I get this output:
>>
>> Issue created. URL: http://codereview.appspot.com/320140043
>> Uploading base file for Documentation/changes.tely
>> Uploading base file for scm/define-grob-properties.scm
>> Uploading base file for scm/define-grobs.scm
>> Uploading base file for
>> Documentation/snippets/new/analysis-brackets-with-labels.ly
>> Traceback (most recent call last):
>>   File "/home/david/git-cl/git-cl", line 628, in 
>> sys.exit(main(sys.argv))
>>   File "/home/david/git-cl/git-cl", line 622, in main
>> return func(argv[2:])
>>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
>> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
>> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
>>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
>> print t.get(timeout=60)
>>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
>> raise self._value
>> urllib2.URLError: 
>>
>> The patch is visible here: https://codereview.appspot.com/320140043/
>> but no issue has been created.
>
> Except that two files show "Error: old chunk mismatch":
> scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc

I've tried uploading this a number of times, always the same results.
The base files aren't uploaded for these two files.  (Current attempt:
https://codereview.appspot.com/316280043/)

Is the patch simply too large, and I'm losing the connection before
all of the base files have been uploaded?

If this is so, is there any way to get all of this uploaded and
associated with a single issue?

Thanks,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: trouble uploading a patch

[David Nalesnik]

On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik <david.nales...@gmail.com> wrote:
> Hi,
>
> I'm trying to upload a patch for review, and I'm running into difficulties.
>
> Using git-cl, I get this output:
>
> Issue created. URL: http://codereview.appspot.com/320140043
> Uploading base file for Documentation/changes.tely
> Uploading base file for scm/define-grob-properties.scm
> Uploading base file for scm/define-grobs.scm
> Uploading base file for
> Documentation/snippets/new/analysis-brackets-with-labels.ly
> Traceback (most recent call last):
>   File "/home/david/git-cl/git-cl", line 628, in 
> sys.exit(main(sys.argv))
>   File "/home/david/git-cl/git-cl", line 622, in main
> return func(argv[2:])
>   File "/home/david/git-cl/git-cl", line 335, in CmdUpload
> issue, patchset = upload.RealMain(['upload'] + upload_args + args)
>   File "/home/david/git-cl/upload.py", line 2693, in RealMain
> vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
>   File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
> print t.get(timeout=60)
>   File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
> raise self._value
> urllib2.URLError: 
>
> The patch is visible here: https://codereview.appspot.com/320140043/
> but no issue has been created.

Except that two files show "Error: old chunk mismatch":
scm/define-grob-interfaces.scm and lily/horizontal-bracket.cc

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

trouble uploading a patch

[David Nalesnik]

Hi,

I'm trying to upload a patch for review, and I'm running into difficulties.

Using git-cl, I get this output:

Issue created. URL: http://codereview.appspot.com/320140043
Uploading base file for Documentation/changes.tely
Uploading base file for scm/define-grob-properties.scm
Uploading base file for scm/define-grobs.scm
Uploading base file for
Documentation/snippets/new/analysis-brackets-with-labels.ly
Traceback (most recent call last):
  File "/home/david/git-cl/git-cl", line 628, in 
sys.exit(main(sys.argv))
  File "/home/david/git-cl/git-cl", line 622, in main
return func(argv[2:])
  File "/home/david/git-cl/git-cl", line 335, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/david/git-cl/upload.py", line 2693, in RealMain
vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File "/home/david/git-cl/upload.py", line 1220, in UploadBaseFiles
print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
raise self._value
urllib2.URLError: 

The patch is visible here: https://codereview.appspot.com/320140043/
but no issue has been created.

Any help would be appreciated!

Thanks,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/319150043/diff/80001/Documentation/notation/changing-defaults.itely#newcode2777
Documentation/notation/changing-defaults.itely:2777: The @code{\offset}
command used in this manner is similiar to the
On 2017/01/25 22:33:32, simon.albrecht wrote:

s/similiar/similar


Yup--thanks.  Will bundle that with whatever changes may come.

https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/01/25 20:43:23, david.nalesnik wrote:

diagram syntax, other improvements


This is as clear as I can make this I think, so I will resist the
temptation to post a follow-up patch in case reviewers would like to
comment!



https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/01/24 23:32:51, t.daniels_treda.co.uk wrote:

mailto:david.nales...@gmail.com wrote Tuesday, January 24, 2017 10:57

PM


> Question:
>
> How do I get a backslash in @subsubsubheading{} ?
>
> The literal symbol doesn't show up, and @backslashchar{} displays
> @backslashchar{}



 From memory it's @bs{}.



Trevor


Thaat's it!

Thanks, Trevor.

David

https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

Question:

How do I get a backslash in @subsubsubheading{} ?

The literal symbol doesn't show up, and @backslashchar{} displays
@backslashchar{}

https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

I've posted an extensive rewrite which hopefully addresses all the
concerns.  I think the result is a lot more user-friendly.

Note that I did not change the argument-name "offsets".

My preference would be to use "displacements" here, because I think it
is exactly expressive of its use.  The documentation of \shape in the NR
uses displacements.

In second place would be "offsets."  (Interestingly, the listing of
"shape" in Available Music Functions uses "offsets," in contrast with
the NR documentation.  I suppose I'm responsible for the function
docstring.  IIRC, Trevor wrote the \shape documentation.)

I've left it as-is for the moment, to invite other opinions.





https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

Thanks so such for the detailed review!  Will post a patch update in the
near future.


https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2514
Documentation/notation/changing-defaults.itely:2514: Properties can be
set to new values with the @code{\override},
On 2017/01/24 14:36:08, pkx166h wrote:

Bearing in mind my not-very-deep understanding of LP, the preceding

paragraphs

talk about both context and grob properties as being distinct from one

another

and how 'grob properties' are just properties of a context's own 'grob
definition'. Then explains how 'grob definitions' and 'context

properties' are

manipulated using different commands - i.e. \override and \revert -

where as

'context properties' are manipulated with \set and \unset.



Which is the \offset for? One, the other, both?



This matters only because a user just looking up the \offset command

just get's

the explanation that it is just 'Properties' and it is ambiguous (at

least to

me). While we can show with examples, I think we can improve this

opening para.


I think, therefore it would be helpful to imply this in the opening

para (with

words like 'Both Grob properties and context definitions can be set to

new ...

etc.' or 'While it is possible to set [Grob definitions|Context

properties] with

the @code{\overrride} ... etc.'



Will clarify that it's _grob_ properties only.  I like the "while..."
construction.

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522
Documentation/notation/changing-defaults.itely:2522: [-]\offset
@var{property} @var{offsets} @var{item}
On 2017/01/24 14:36:08, pkx166h wrote:

'Displacements' is not the right word - you 'displace' one

object/thing by

imposing on it (in it) another 'object/thing' - both things have to

exist at

once for the displacement to happen, this is as distinct from

'replace'). We're

not doing that here. We're simply moving the 'thing' to

another/different

location from it's expected location.


Though see here
(https://www.merriam-webster.com/dictionary/displacement):

"the difference between the initial position of something (as a body or
geometric figure) and any later position"



I think 'offset-value' works, that implies a number or 'group' of

numbers (to us

lesser mortals who don't know what alists and those things with dots

in between

the two numbers and/or hash signs are called :).


I'm happy to use "offset-value" though!

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2535
Documentation/notation/changing-defaults.itely:2535: The leading hyphen
may only be used with the @code{\tweak} form of the
On 2017/01/24 14:36:08, pkx166h wrote:

'The leading ... ' or 'A leading ...' - again pardon my limited LP

knowledge if

it is obvious.



However, I think this one sentence needs to be moved to an

@knownissues as this

seems like some limitation that maybe able to be improved in the

future? Again,

users look at @knownissues for these kinds of 'funnies'. Also it would

be useful

to show an @example of the '\tweak' form, as - unless I missed it -

you don't

show a '\tweak' example with '\offset' in this edit at all.


Yes, I give a number of examples with the "tweak" form.  The "tweak"
form doesn't explicitly use "\tweak".  As I explained above, the effect
of the \offset command is to create a tweak when the last argument is a
musical expression.

The presence/absence of the leading hyphen is exactly analogous to the
actual \tweak command.  So I can't consider it a known limitation unless
it is a known limitation of \tweak.

I'll add a comment which stresses that the syntax of \offset in its
"tweak" form is modeled after \tweak itself.

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2539
Documentation/notation/changing-defaults.itely:2539: @code{\once} or
@code{\temporary} and reverted by using @code{\revert}
On 2017/01/23 23:52:54, thomasmorley651 wrote:

Does \undo work?
If so, please mention it as well.


Will check that out.  Thanks!

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2544
Documentation/notation/changing-defaults.itely:2544:
On 2017/01/24 14:36:09, pkx166h wrote:

I am a bit worried that, thinking about users like me, that we're

starting to be

a bit 'programmerish' in some of these following bullets.


Yeah, sorry.  I'll try to clarify. But at the end of the day, this is
always going to be somewhat technical -- which is why it doesn't belong
in the LM :)



I also think that, with a bit more insight for me, I may be able to

help you

incorporate the bullets in the text with some examples.

Re: PATCHES - Countdown for Tuesday January 24

[David Nalesnik]

On Tue, Jan 24, 2017 at 7:38 AM, James <p...@gnu.org> wrote:
> Hello David,
>
> On Tue, 24 Jan 2017 07:05:24 -0600
> David Nalesnik <david.nales...@gmail.com> wrote:
>
>> >
>>
>> Would you add
>>
>> 3830 Documentation for \offset is required
>> https://sourceforge.net/p/testlilyissues/issues/3830/
>> https://codereview.appspot.com/319150043/
>
>
>
> For anything to appear on my PATCH countdown (and test) 'radar' the
> Status field == 'Started' and Patch == 'New'.
>
> In this case Issue 3830 had a Status == 'Accepted'.
>
> I have changed this Status manually, although if you use git-cl this
> does (should do) this for you automatically, else you just need to
> change this 'Status' field to 'Started' manually if you are entering
> issues manually.
>

It wasn't done for me by git-cl, so I'll make a note to check in the future.

Thanks!

David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES - Countdown for Tuesday January 24

[David Nalesnik]

James,

On Tue, Jan 24, 2017 at 4:43 AM, James <p...@gnu.org> wrote:
> Hello,
>
> Here is the current patch countdown list. The next countdown will be on
> January 27
>
>
> A quick synopsis of all patches currently in the review process can be
> found here:
>
> http://philholmes.net/lilypond/allura/
>
> 
>
> Push: No patches to push at this time
>
>
> Countdown:
>
> 5037 web: GSoC page: Add SMuFL project - Urs Liska
> https://sourceforge.net/p/testlilyissues/issues/5037
> http://codereview.appspot.com/318330043
>
>
> 5035 Remove midi.c - Graham Percival
> https://sourceforge.net/p/testlilyissues/issues/5035
> http://codereview.appspot.com/7016046
>
>
> 5034 Fully document the short forms of the mode-changing commands -
> Trevor Daniels https://sourceforge.net/p/testlilyissues/issues/5034
> http://codereview.appspot.com/313380043
>
>
> 185 RhythmicStaff squishing chords should produce single notes - Trevor
> Daniels https://sourceforge.net/p/testlilyissues/issues/185
> http://codereview.appspot.com/6495107
>
>
> Review:
>
>
> 5040 Let \alterBroken tweak ties again - David Nalesnik
> https://sourceforge.net/p/testlilyissues/issues/5040
> http://codereview.appspot.com/319160043
>
>
> 5039 Replace \set Staff.instrumentName with \with form in doc examples
> - James Lowe https://sourceforge.net/p/testlilyissues/issues/5039
> http://codereview.appspot.com/313400043
>
>
> 4509 Enhancement: automatically engrave lyric extenders - Alexander
> Kobel https://sourceforge.net/p/testlilyissues/issues/4509
> http://codereview.appspot.com/313240043
>
>
> New:
>
>
> 5042 Web: GSoC: Add openLilyLib project suggestion - Urs Liska
> https://sourceforge.net/p/testlilyissues/issues/5042
> http://codereview.appspot.com/311570043
>
>
> 5041 Using eq? on numbers is undefined behavior - David Kastrup
> https://sourceforge.net/p/testlilyissues/issues/5041
> http://codereview.appspot.com/314300043
>
>
> 5038 Web: Review GSoC page introduction - Urs Liska
> https://sourceforge.net/p/testlilyissues/issues/5038
> http://codereview.appspot.com/315410043
>
>
> Waiting:
>
>
> 4600 Let notes/rests suppress multi-measure rest grobs - Dan Eble
> https://sourceforge.net/p/testlilyissues/issues/4600
> http://codereview.appspot.com/265160043
>

Would you add

3830 Documentation for \offset is required
https://sourceforge.net/p/testlilyissues/issues/3830/
https://codereview.appspot.com/319150043/

Thanks,
David

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522
Documentation/notation/changing-defaults.itely:2522: [-]\offset
@var{property} @var{offsets} @var{item}
On 2017/01/23 23:52:54, thomasmorley651 wrote:

Would it be even more clear to have instead of @var{offsets} something

like

@var{offset-value} or @var{property-value}?
(Same below and in the docstring for the offset-command in
music-functions-init.ly)



Please keep in mind I'm not a native speaker, so I may be wrong here.


"offsets" works, but I could change this to "displacements" -- you know,
sort of like not using a word in its own definition.  There would also
be no confusion between noun and verb senses, since "displacements" is
only a noun.

But maybe, since the docs are supposed to be clear to native and
non-native speakers, "offset-values" or "offset-amounts" would be best?

https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

[david . nalesnik]

On 2017/01/23 19:00:43, david.nalesnik wrote:

No problem.



https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly

File ly/music-functions-init.ly (right):



https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107

ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item
'span-direction) START)
On 2017/01/23 18:24:29, dak wrote:
> This may be stupid, but as long as we are touching the code, we

might as well

> make it correct.  Numbers may not reliably be compared with eq? but

require

use
> of eqv? instead.



Done.


I get 18 instances with the following (misses variables storing numbers,
of course):

git grep
"(eq?\s\+\((.\+)\|[A-Za-z-]\+\)\s\+\(-\?[[:digit:]]\+\|X\|Y\|LEFT\|RIGHT\| 
UP\|DOWN\))"


Probably worth a patch.


https://codereview.appspot.com/319160043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

[david . nalesnik]

No problem.


https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107
ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item
'span-direction) START)
On 2017/01/23 18:24:29, dak wrote:

This may be stupid, but as long as we are touching the code, we might

as well

make it correct.  Numbers may not reliably be compared with eq? but

require use

of eqv? instead.


Done.

https://codereview.appspot.com/319160043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!

Description:
Let \alterBroken tweak ties again

When tweaking Tie grobs, the music function \alterBroken has
incorrectly rejected them since 2.17.6 as not being spanners.
The method of spanner recognition is at fault: 'span-direction
is not used by TieEvent.

Please review this at https://codereview.appspot.com/319160043/

Affected files (+2, -1 lines):
  M ly/music-functions-init.ly


Index: ly/music-functions-init.ly
diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly
index  
1f94319bce743ca1e6994eebdff7daa672db0e12..901c7429129e5a2de4b5d27ac94a41da64a4a9a2  
100644

--- a/ly/music-functions-init.ly
+++ b/ly/music-functions-init.ly
@@ -104,7 +104,8 @@ a starting spanner event, or a symbol list in the form
 form of a spanner event, @var{property} may also have the form
 @samp{Grob.property} for specifying a directed tweak.")
   (if (ly:music? item)
-  (if (eq? (ly:music-property item 'span-direction) START)
+  (if (or (eq? (ly:music-property item 'span-direction) START)
+  (music-is-of-type? item 'tie-event))
   (tweak property (value-for-spanner-piece arg) item)
   (begin
 (ly:music-warning item (_ "not a spanner"))



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

[david . nalesnik]

Reviewers: ,

Message:
Please review.  Thanks!

Description:
Issue 3830:  Document \offset command

Please review this at https://codereview.appspot.com/319150043/

Affected files (+142, -0 lines):
  M Documentation/notation/changing-defaults.itely



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Can someone run makelsr on staging please?

[David Nalesnik]

On Sun, Jan 22, 2017 at 8:33 AM, David Nalesnik
<david.nales...@gmail.com> wrote:
> On Sun, Jan 22, 2017 at 8:20 AM, David Kastrup <d...@gnu.org> wrote:
>> David Nalesnik <david.nales...@gmail.com> writes:
>>
>>> On Sun, Jan 22, 2017 at 7:45 AM, James <p...@gnu.org> wrote:
>>>> Hello,
>>>>
>>>> David Nalesnik checked in a commit with a new snippet but forgot to push a
>>>> separate makelsr checkin to go with it so merge fails.
>>>>
>>>> Could someone do that as I currently at work today (lucky me) and won't 
>>>> have
>>>> time to do it myself for at least another 3 or 4 hours.
>>>>
>>>
>>> I didn't forget.  I didn't think it was necessary:
>>>
>>> The snippet I recently corrected
>>> (https://sourceforge.net/p/testlilyissues/issues/5030/) was never in
>>> Documentation/snippets/ just Documentation/snippets/new.  So makelsr
>>> hadn't been run.
>>
>> That does not even make sense.  The whole purpose of the makelsr
>> procedure is to copy Documentation/snippets/new over the material from
>> Documentation/snippets where the documentation will get built.
>
> What I don't understand is how the merge of the original commit should
> have succeeded when there was no checkin of the results of a makelsr
> on the using-marklines-... snippet.
>

Well, I see that the original commit includes no documentation
reference to the new snippet, so I suppose I can answer my question.

DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Can someone run makelsr on staging please?

[David Nalesnik]

On Sun, Jan 22, 2017 at 8:20 AM, David Kastrup <d...@gnu.org> wrote:
> David Nalesnik <david.nales...@gmail.com> writes:
>
>> On Sun, Jan 22, 2017 at 7:45 AM, James <p...@gnu.org> wrote:
>>> Hello,
>>>
>>> David Nalesnik checked in a commit with a new snippet but forgot to push a
>>> separate makelsr checkin to go with it so merge fails.
>>>
>>> Could someone do that as I currently at work today (lucky me) and won't have
>>> time to do it myself for at least another 3 or 4 hours.
>>>
>>
>> I didn't forget.  I didn't think it was necessary:
>>
>> The snippet I recently corrected
>> (https://sourceforge.net/p/testlilyissues/issues/5030/) was never in
>> Documentation/snippets/ just Documentation/snippets/new.  So makelsr
>> hadn't been run.
>
> That does not even make sense.  The whole purpose of the makelsr
> procedure is to copy Documentation/snippets/new over the material from
> Documentation/snippets where the documentation will get built.

What I don't understand is how the merge of the original commit should
have succeeded when there was no checkin of the results of a makelsr
on the using-marklines-... snippet.

>
>> - Running makelsr on that (original) snippet should have caused merge
>> to fail as well.
>>
>> I simply don't understand.
>
> I'll take a look at what's left to do.
>

I appreciate this.

Thanks,
DN

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel