[PATCH 16/20] ide: check BUSY and ERROR status bits before reading data in drive_cmd_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |7 +++ 1 file changed, 7 insertions(+) Index: b/drivers/ide/ide-io.c === --- a/drivers/ide/ide-io.c +++ b/drivers/ide/ide-io.c @@ -643,6

[PATCH 17/20] ide: fix final status check in drive_cmd_intr()

Don't check for READY_STAT bit being set for PIO-in protocol (makes the final status check in drive_cmd_intr() match the one in task_in_intr()). Also fix function name reported by ide_error() call while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c

[PATCH 18/20] ide: switch set_xfer_rate() to use REQ_TYPE_ATA_TASKFILE requests

Based on the earlier work by Tejun Heo. Switch set_xfer_rate() to use REQ_TYPE_ATA_TASKFILE requests and make ide_wait_cmd() static. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 19/20] ide: switch ide_cmd_ioctl() to use REQ_TYPE_ATA_TASKFILE requests

Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |4 +- drivers/ide/ide-taskfile.c | 63

[PATCH 20/20] ide: remove REQ_TYPE_ATA_CMD

Based on the earlier work by Tejun Heo. All users are gone so we can finally remove it. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 98 ++--- drivers/ide/ide-lib.c | 25

Re: [PATCH 3/20] dtc2278: -io_32bit setting don't have to be identical for master/slave

On Sunday 09 December 2007, Alan Cox wrote: drive-io_32bit is used per PIO transfer so there is no reason to require it to be identical for master/slave. Sure about that ? The driver has always gone to great pains to ensure that occurs and that suggests the author had a good reason for

Re: [PATCH 3/20] dtc2278: -io_32bit setting don't have to be identical for master/slave

On Monday 10 December 2007, Alan Cox wrote: There is absolutely no hardware setup done by IDE subsystem or dtc2278 host driver when -io_32bit setting is changed and since -io_32bit setting So ? The original author went to great trouble to specifically enforce the behaviour in question

Re: [PATCH 15/20] ide: don't enable local IRQs for PIO-in in driver_cmd_intr()

On Monday 10 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Don't enable local IRQs for PIO-in protocol in driver_cmd_intr(). While at it: * Remove redundant rq-cmd_type check. * Read status register after enabling local IRQs for no-data protocol

Re: [PATCH 12/20] ide: use wait_drive_not_busy() in drive_cmd_intr()

On Monday 10 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-taskfile.c

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

On Tuesday 11 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename init_hwif_data() to ide_init_port_data() and export it. * For all users of ide_register_hw() with 'initializing' argument set hwif-present and hwif-hold are always zero so convert these host

Re: [PATCH 19/30] blk_end_request: changing ide-scsi (take 4)

On Tuesday 11 December 2007, Kiyoshi Ueda wrote: This patch converts ide-scsi to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi

Re: [PATCH 20/21] ide: fix host drivers depending on ide_generic to probe for interfaces

On Wednesday 12 December 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Add mpc8xx_ide_probe() to mpc8xx.c and call it from probe_for_hwifs(). * Convert ide_arm, ide-cris, ide-h8300, ide-pnp, buddha, falconide, gayle, macide, q40ide, cmd640 and mpc8xx host

[git patches] IDE fixes

+ drivers/scsi/ide-scsi.c| 17 + include/linux/ide.h|6 ++-- 14 files changed, 191 insertions(+), 189 deletions(-) Bartlomiej Zolnierkiewicz (13): ide-scsi: add ide_scsi_hex_dump() helper ide: add missing checks for control register existence ide

Re: [PATCH 17/21] ide: drop 'initializing' argument from ide_register_hw()

Hi, On Thursday 13 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename init_hwif_data() to ide_init_port_data() and export it. * For all users of ide_register_hw() with 'initializing' argument set hwif-present and hwif-hold are always zero so convert

Re: [PATCH 14/20] ide: convert empty REQ_TYPE_ATA_CMD requests to use REQ_TYPE_ATA_TASKFILE

On Thursday 13 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Based on the previous work by Tejun Heo. There should be no functionality changes caused by this patch. I didn't get the point. Why do you consider them empty? These requests don't have command

Re: [PATCH] Fix build break caused by ide: remove ideprobe_init()

[EMAIL PROTECTED] applied but... --- On Sun, Nov 18, 2007 at 11:25:09PM +0100, Bartlomiej Zolnierkiewicz wrote: * Rename ide_device_add() to ide_device_add_all() and make it accept 'u8 idx[MAX_HWIFS]' instead of 'u8 idx[4]' as an argument. * Add ide_device_add() wrapper

Re: [PATCH] drivers/ide/: Spelling fixes

On Monday 17 December 2007, Joe Perches wrote: Signed-off-by: Joe Perches [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH pata-2.6] hpt366: merge set_dma_mode() methods

On Friday 14 December 2007, Sergei Shtylyov wrote: Group the array of pointers to the timing tables with the timing register masks which allows us to merge HPT36x/HPT37x set_dma_mode() methods into one. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this

[PATCH 00/63] ide-cd: redux

Hi, This patch series is a major rework of the ide-cd driver. The motivations behind it are twofold: * ide-cd is still in use but because it has been out of luck for maintainers lately the code become quite hard to debug and maintain - this puts it back into the shape * aid efforts of

[PATCH 02/63] ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines

* Fix ACER/AOpen 24X CDROM speed reporting on big-endian machines by adding missing le16_to_cpu() calls. While at it: * Replace ntohs() by be16_to_cpu(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 1 file changed, 4 insertions(+), 4

[PATCH 01/63] ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk

cdi-mask is cleared by ide_cdrom_register() which is called after the quirk. Fix it by adding new -no_speed_select flag to struct ide_cd_config_flags and using it in ide_cdrom_register() to set CDC_SELECT_SPEED flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide

[PATCH 03/63] ide-cd: use ide_cd_release() in ide_cd_probe()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -164 bytes drivers/ide/ide-cd.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers

[PATCH 04/63] ide-cd: fix error messages in cdrom_{read,write}_check_ireason()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers

[PATCH 08/63] ide-cd: fix error message in cdrom_pc_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c

[PATCH 10/63] ide-cd: use xfer_func_t in cdrom_pc_intr()

Unify writing and reading handling in cdrom_pc_intr() using xfer_func_t. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 47 +-- 1 file changed, 17

[PATCH 09/63] ide-cd: fix 'ireason' reporting in cdrom_pc_intr()

Mask 'ireason' variable so only the valid interrupt reason bits will be reported on drive appears confused error. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 13/63] ide-cd: fix DMA error handling in cdrom_newpc_intr()

Make cdrom_newpc_intr() match cdrom_{read,write}_intr() w.r.t. handling DMA errors: * disable DMA before cdrom_decode_status() call * log the device name and the type of the request (read/write) Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 10

[PATCH 15/63] ide-cd: move historical changelog to Documentation/ide/ChangeLog.ide-cd.1994-2004

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- Documentation/ide/ChangeLog.ide-cd.1994-2004 | 268 ++ drivers/ide/ide-cd.c | 274 --- 2 files changed, 272 insertions(+), 270 deletions(-) Index: b

[PATCH 16/63] ide-cd: remove stale cdrom_transfer_packet_command() comment

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |4 1 file changed, 4 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -684,10

[PATCH 18/63] ide-cd: remove dead code from cdrom_pc_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |7 --- 1 file changed, 7 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -1201,13

[PATCH 19/63] ide-cd: remove unused struct atapi_cdrom_subchnl

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.h | 32 1 file changed, 32 deletions(-) Index: b/drivers/ide/ide-cd.h === --- a/drivers/ide/ide-cd.h +++ b/drivers

[PATCH 12/63] ide-cd: fix missing data handling in cdrom_pc_intr()

If drive still wants to transfer the data we need to pad the transfer instead of just finishing the request. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 20/63] ide-cd: remove needless zeroing of 'info' fields from ide_cdrom_setup()

ide_cd_probe() zeroes 'info' prior to calling ide_cdrom_setup() so there is no need to explicitly zero 'info' fields in the latter function. Ditto for fields of CDROM_STATE_FLAGS(), CDROM_CONFIG_FLAGS() and 'cdi' (all are embedded in 'info'). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 21/63] ide-cd: remove unused and write-only struct ide_cd_config_flags fields

unused fields: * -writing * -reserved write-only fields: * -playmsf_as_bcd * -subchan_as_bcd * -test_write * -supp_disc_present Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -120 bytes drivers/ide/ide-cd.c | 18 ++ drivers/ide/ide-cd.h |7 --- 2 files

[PATCH 22/63] ide-cd: remove struct atapi_{mechstat_header,changer_info,slot}

* Remove -changer_info from struct cdrom_info (it is never allocated). * Remove unused struct atapi_{mechstat_header,changer_info,slot}. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -11 bytes drivers/ide/ide-cd.c |1 drivers/ide/ide-cd.h | 55

[PATCH 23/63] ide-cd: cleanup ide_cdrom_update_speed()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -39 bytes drivers/ide/ide-cd.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 25/63] ide-cd: remove redundant config flags

* Use CDC_* flags directly and remove redundant flags from -config_flags. While at it: * Add KERN_CONT to printk()-s in ide_cdrom_probe_capabilities(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -294 bytes drivers/ide/ide-cd.c | 102

[PATCH 27/63] ide-cd: kill CDROM_STATE_FLAGS() macro

While at it rename 'info' variable to 'cd' in cdrom_saw_media_change(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -49 bytes drivers/ide/ide-cd.c | 44 drivers/ide/ide-cd.h |2 -- 2 files changed, 24 insertions(+), 22

[PATCH 30/63] ide-cd: remove NO_DOOR_LOCKING define

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |3 --- drivers/ide/ide-cd.h |7 --- 2 files changed, 10 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 31/63] ide-cd: remove STANDARD_ATAPI define

Remove STANDARD_ATAPI define + drive-by coding style fixes. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 43 ++- drivers/ide/ide-cd.h | 10 -- 2 files changed, 10 insertions(+), 43 deletions(-) Index

[PATCH 33/63] ide-cd: re-organize handling of quirky devices

by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 138 --- drivers/ide/ide-cd.h | 10 ++- 2 files changed, 84 insertions(+), 64 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 36/63] ide-cd: move VERBOSE_IDE_CD_ERRORS code to ide-cd_verbose.c

after the patch w/ CONFIG_BLK_DEV_IDECD_VERBOSE_ERRORS=n: textdata bss dec hex filename 15091 3601056 16507407b drivers/ide/ide-cd_mod.o Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig |9 + drivers/ide/Makefile

[PATCH 38/63] ide-cd: merge cdrom_play_audio() into ide_cd_fake_play_trkind()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 39/63] ide-cd: merge cdrom_read_subchannel() into ide_cdrom_get_mcn()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -19 bytes drivers/ide/ide-cd.c | 53 --- 1 file changed, 21 insertions(+), 32 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 11/63] ide-cd: add ide_cd_pad_transfer() helper

Add ide_cd_pad_transfer() helper and use it in cdrom_[new]pc_intr() and cdrom_{read,write}_check_ireason(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -39 bytes drivers/ide/ide-cd.c | 51

[PATCH 44/63] ide-cd: move code handling cdrom.c IOCTLs to ide-cd_ioctl.c

There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Makefile |2 drivers/ide/ide-cd.c | 271 + drivers/ide/ide-cd.h | 17 ++ drivers/ide

[PATCH 46/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_newpc_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide

[PATCH 63/63] ide-cd: update driver version, comments and copyrights

* Bump driver version. * Remove filename and stale TODO from comments. * Add my copyrights. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 61/63] ide-cd: merge cdrom_write_check_ireason() and cdrom_read_check_ireason()

Add 'rw' parameter to cdrom_read_check_ireason(), make it handle both read and write checking, rename it to ide_cd_check_ireason(), finally remove no longer needed cdrom_write_check_ireason(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej

[PATCH 60/63] ide-cd: merge cdrom_rw_intr() and cdrom_newpc_intr()

Add handling of fs read/write requests to cdrom_nepwc_intr() and remove no longer needed cdrom_rw_intr(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -496 bytes drivers/ide/ide-cd.c | 272

[PATCH 59/63] ide-cd: call blk_dump_rq_flags() on missing data in cdrom_rw_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c

[PATCH 58/63] ide-cd: prepare cdrom_rw_intr() and cdrom_newpc_intr() to be merged

' in 'ptr' variable * check for 'rq-bio' before setting 'ptr' and 'blen' * check for 'ptr' instead of 'rq-current_nr_sectors' There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +54 bytes drivers/ide/ide-cd.c | 45

[PATCH 57/63] ide-cd: unify moving to the next buffer in cdrom_rw_intr()

Use the fact that for the first loop rq-current_nr_sectors is always set and unify moving to the next buffer for read/write requests. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -46 bytes drivers/ide/ide-cd.c

[PATCH 56/63] ide-cd: merge cdrom_start_read() and cdrom_start_write()

Add handling of read requests to cdrom_start_write(), rename it to cdrom_start_rw() and remove no longer needed cdrom_start_read(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -20 bytes drivers/ide/ide-cd.c

[PATCH 55/63] ide-cd: merge cdrom_start_read_continuation() and cdrom_start_rw_cont()

. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -51 bytes drivers/ide/ide-cd.c | 74 --- 1 file changed, 35 insertions(+), 39 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 54/63] ide-cd: merge cdrom_read_intr() and cdrom_write_intr()

Add handling of read requests to cdrom_write_intr(), rename it to cdrom_rw_intr() and remove no longer needed cdrom_read_intr(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -368 bytes drivers/ide/ide-cd.c | 207

[PATCH 53/63] ide-cd: factor out transfer size checking from cdrom_read_intr()

This is a preparation for cdrom_read_intr() and cdrom_write_intr() merge. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +26 bytes drivers/ide/ide-cd.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 52/63] ide-cd: add ide_cd_drain_data() helper

Add ide_cd_drain_data() and use it in cdrom_{buffer_sectors,read_intr}() (as a nice side-effect this cuts 0.5kB of code from ide-cd.o). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -511 bytes drivers/ide/ide-cd.c

[PATCH 50/63] ide-cd: remove cdrom_do_pc_continuation()

cdrom_do_pc_continuation() is now identical to cdrom_do_newpc_cont() so just always use the latter function. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -49 bytes drivers/ide/ide-cd.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) Index: b/drivers

[PATCH 49/63] ide-cd: merge cdrom_pc_intr() and cdrom_newpc_intr()

-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -264 bytes drivers/ide/ide-cd.c | 159 +-- 1 file changed, 55 insertions(+), 104 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide

[PATCH 48/63] ide-cd: unify request end exit path in cdrom_pc_intr()

This is a preparation for cdrom_pc_intr() and cdrom_newpc_intr() merge. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +10 bytes drivers/ide/ide-cd.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 47/63] ide-cd: factor out request sense fixup from cdrom_pc_intr()

This is a preparation for cdrom_pc_intr() and cdrom_newpc_intr() merge. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 45/63] ide-cd: remove BUG_ON() from cdrom_newpc_intr()

There is no need for it anylonger and ide_set_handler() complains if -handler is not NULL anyway. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 43/63] ide-cd: rename cdrom_* functions to ide_cd_*

-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 83 +++ 1 file changed, 44 insertions(+), 39 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 14/63] ide-cd: fix trailing whitespaces in changelog

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c

[PATCH 42/63] ide-cd: coding style fixes for cdrom_get_toc_entry()

This is a preparation to move code handling cdrom.c IOCTLs out of ide-cd.c. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 41/63] ide-cd: move lba_to_msf() and msf_to_lba() to linux/cdrom.h

* Move lba_to_msf() and msf_to_lba() to linux/cdrom.h (use 'u8' type instead of 'byte' while at it). * Remove msf_to_lba() copy from drivers/cdrom/cdrom.c. Cc: Jens Axboe [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/cdrom/cdrom.c |6

[PATCH 40/63] ide-cd: merge cdrom_select_speed() into ide_cdrom_select_speed()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -13 bytes drivers/ide/ide-cd.c | 66 ++- 1 file changed, 29 insertions(+), 37 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 37/63] ide-cd: factor out ioctl handlers from ide_cdrom_audio_ioctl()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 142 ++- 1 file changed, 75 insertions(+), 67 deletions(-) Index: b/drivers/ide/ide-cd.c

[PATCH 35/63] ide-cd: coding style fixes for VERBOSE_IDE_CD_ERRORS code

* Coding style fixes for VERBOSE_IDE_CD_ERRORS code. * Add KERN_{ERR,CONT} printk() levels where needed. This is a preparation for moving this code out of ide-cd.[c,h]. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 65

[PATCH 32/63] ide-cd: use BCD2BIN()/BIN2BCD() macros from linux/bcd.h

Use BCD2BIN()/BIN2BCD() macros from linux/bcd.h and remove the local bcd2bin()/bin2bcd() inlines. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +15 bytes :( drivers/ide/ide-cd.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) Index

[PATCH 07/63] ide-cd: add error message for DMA error to cdrom_read_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide

[PATCH 29/63] ide-cd: remove struct ide_cd_{config,state}_flags

' to struct cdrom_info and use -cd_flags instead of -{config,state}_flags. * Remove no longer needed struct ide_cd_{config,state}_flags. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -45 bytes drivers/ide/ide-cd.c | 106

[PATCH 06/63] ide-cd: fix error messages in cdrom_write_intr()

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) Index: b/drivers/ide/ide-cd.c === --- a/drivers/ide/ide-cd.c +++ b/drivers

[PATCH 26/63] ide-cd: kill CDROM_CONFIG_FLAGS() macro

While at it rename 'info' variable to 'cd' in ide_cdrom_probe_capabilities() and ide_cdrom_setup(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -47 bytes drivers/ide/ide-cd.c | 96 ++- drivers/ide/ide-cd.h |2 - 2 files

[PATCH 24/63] ide-cd: add IDE_CD_CAPABILITIES define

While at it remove stale/incorrect comment. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) Index: b/drivers/ide/ide-cd.c

Re: [PATCH 00/63] ide-cd: redux

On Thursday 20 December 2007, Borislav Petkov wrote: On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, Hi all, PS ide-cd Maintainer position is still open... i'd like to take that position if nobody objects. I've done some work around the kernel here

Re: [PATCH 00/63] ide-cd: redux

On Thursday 20 December 2007, Phillip Susi wrote: Bartlomiej Zolnierkiewicz wrote: Hi, This patch series is a major rework of the ide-cd driver. Hi, in the future could you please post big patchbombs like this as replies to the first one so they fold nicely into one thread? IIRC

[PATCH 1/2] ide: add ide_dump_identify() debug helper

* Add ide_dump_identify() debug helper for dumping raw identify data in the hdparm friendly format (== the identify data can be extracted from dmesg output and passed to hdparm --Istdin). * Dump identify data in ide-probe.c::do_identify() if DEBUG is enabled. Signed-off-by: Bartlomiej

[PATCH 2/2] ide-{floppy,tape}: remove debug code for dumping identify data

IDE core supports dumping raw identify data in hdparm friendly format now so verbose identify dumping in ide-{floppy,tape}.c device drivers (done iff IDE{FLOPPY,TAPE}_DEBUG_INFO is defined to '1' and it is '0' by default) is no longer nedeed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH 00/63] ide-cd: redux

On Sunday 23 December 2007, Borislav Petkov wrote: On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote: On Thursday 20 December 2007, Borislav Petkov wrote: On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote: Hi Bart, Hi all, PS ide

[PATCH] cmd64x: fix hwif-chipset setup

are identical except for 'name' field). Fix it and bump driver version. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/pci/cmd64x.c

[git patches] IDE fixes

(-) Bartlomiej Zolnierkiewicz (10): ide-cd: fix SAMSUNG CD-ROM SCR-3231 quirk ide-cd: fix ACER/AOpen 24X CDROM speed reporting on big-endian machines ide-cd: use ide_cd_release() in ide_cd_probe() ide-cd: fix error messages in cdrom_{read,write}_check_ireason() ide-cd: add

Re: [git patches] IDE fixes

[ added Linus to Cc: ] On Monday 24 December 2007, Bartlomiej Zolnierkiewicz wrote: cmd64x regression bugfix, few obvious ide-cd fixes from the redux patch peries and ide-cd MAINTAINERS entry update (Borislav, welcome on board!). Oh yes, I would forget... Merry Christmas! Well, I

Re: [PATCH] ide-cd: move the remaining cdrom.c ioctl handling code to ide-cd_ioctl.c

On Wednesday 26 December 2007, Borislav Petkov wrote: On Wed, Dec 26, 2007 at 09:50:14PM +0100, Borislav Petkov wrote: Actually you should drop the previous one for it wasn't incomplete. Here's, hopefully, a better one :). -- From: Borislav Petkov [EMAIL PROTECTED] There should be no

Re: [PATCH] trm290: do hook dma_host_{on,off} methods (take 2)

On Thursday 27 December 2007, Sergei Shtylyov wrote: Using default methods caused the chip's DMA PRD count registers, inadvertently starting DMA! While fixing it, also do: nasty, this could possibly explain the following trm290.c hack: ... #if 0 /* play it safe for now */

[PATCH 1/3] amd74xx: remove amd_ide_chips table

-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -305 bytes drivers/ide/pci/amd74xx.c | 275 -- 1 file changed, 124 insertions(+), 151 deletions(-) Index: b/drivers/ide/pci/amd74xx.c

[PATCH 2/3] ide: add IDE_HFLAG_CLEAR_SIMPLEX host flag

Device IDs was used by some other vendor for PCI IDE controller). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c|7 ++- drivers/ide/pci/amd74xx.c |1 drivers/ide/pci/cmd64x.c |4 +- drivers/ide/pci/generic.c |3 + drivers

[PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

* Add IDE_HFLAG_NO_DSC host flag for hosts that doesn't support DSC overlap. * Set it in aec62xx (for ATP850UF only) and hpt34x host drivers. * Convert ide-tape device driver to check for IDE_HFLAG_NO_DSC flag. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide

[PATCH 9/9] ide: use ide_build_sglist() and ide_destroy_dmatable() in non-PCI host drivers

by this patch. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c | 21 ++--- drivers/ide/ide-dma.c |4 +++- drivers/ide/mips/au1xxx-ide.c | 28 +++- include/linux/ide.h

[PATCH 8/9] ide: switch to DMA-mapping API

] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- It seems like blackfin arch should be using asm-generic/pci-dma-compat.h in asm-blackfin/pci.h or drivers still using PCI DMA-mapping API instead of the generic one won't work but I'll leave this to blackfin gurus... [ Bryan, could you

[PATCH 2/9] ide: fix ide_intr() for non-PCI devices and CONFIG_BLK_DEV_IDEPCI=y

'hwif-pci_dev !hwif-pci_dev-vendor' condition is never true, check for 'hwif-chipset != ide_pci' instead. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-io.c

[PATCH 0/9] ide: switch to generic DMA-mapping API

Make IDE core PCI independent by replacing hwif-pci_dev (struct pci_dev *) with hwif-dev (struct device *) and switch to using generic DMA-mapping API. This is on top of IDE quilt tree + 3 patches posted today. diffstat: drivers/ide/arm/icside.c | 52

[PATCH 1/9] piix: remove stale comments

Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/piix.c | 47 +-- 1 file changed, 1 insertion(+), 46 deletions(-) Index: b/drivers/ide/pci/piix.c

[PATCH 3/9] ide: remove BUG_ON() from ide_build_sglist()

do_rw_taskfile() has been fixed to check the return value of -dma_setup method so this BUG_ON() is no longer needed. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide-dma.c

[PATCH 4/9] ide: use ide_destroy_dmatable() instead of pci_unmap_sg()

Use ide_destroy_dmatable() in: * ide-dma.c::ide_build_dmatable() * sgiioc4.c::sgiioc4_build_dma_table() * pmac.c::pmac_ide_{build,destroy}_dmatable() There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide

[PATCH 6/9] au1xxx-ide: use hwif-dev

* Setup hwif-dev in au_ide_probe(). * Use hwif-dev instead of ahwif-dev in auide_build_sglist(), auide_build_dmatable(), auide_dma_end() and auide_ddma_init(). * Remove no longer needed 'dev' field from _auide_hwif type. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers

[PATCH 7/9] icside: use hwif-dev

* Setup hwif-dev in icside_setup(). * Use hwif-dev instead of state-dev in icside_build_sglist(), icside_dma_end(), icside_dma_start() and icside_dma_setup(). * Remove no longer needed 'dev' field from struct icside_state. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej

Re: [PATCH 3/3] ide: add IDE_HFLAG_NO_DSC host flag

On Saturday 29 December 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_NO_DSC host flag for hosts that doesn't support DSC overlap. * Set it in aec62xx (for ATP850UF only) and hpt34x host drivers. * Convert ide-tape device driver to check

[PATCH 1/3] au1xxx-ide: device tree bugfix

Add missing hw.dev setup (so hwif-gendev.parent will be set by ide_init_port_hw() to point to the parent device). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/mips/au1xxx-ide.c

<    5   6   7   8   9   10   11   12   13   14   >