[PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-02 Thread Sergei Shtylyov
Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Alas, the previous version of the patch wasn't even worth signing it off -- the code

[PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-02 Thread Sergei Shtylyov
with his consent, also adding the method callout to ide_rate_filter(); - installed the method for all chips to only return empty mask if a SATA drive is detected onHPT372{AN]/374 chips... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- This patch against the current Linus' tree

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-02 Thread Sergei Shtylyov
... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- This patch against the current Linus' tree and unfortunately I was able to only compile test it since that tree gives MODPOST warning and dies early on bootup. Will hopefully try to test if/when I have time... :-) Index: linux-2.6

Re: hda: set_drive_speed_status: status=0x51 { DriveReady SeekComplete Error }

2007-09-03 Thread Sergei Shtylyov
Hello. John Sigler wrote: When my system boots, I get several set_drive_speed_status errors. (Please see attached dmesg output.) Can someone explain what they mean? How do I get rid of them? IDE code attempts to autotune PIO mode and fails at that because your device is too old (or

Re: [PATCH 3/4] sis5513: clear prefetch and postwrite for ATAPI devices

2007-09-03 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Clear prefetch and postwrite for ATAPI devices instead of depending on BIOS. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/pci/sis5513.c

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-08 Thread Sergei Shtylyov
Hello, I wrote: Sergei Shtylyov wrote: The patch was 4/4 of course. :- Probably I was too esctatic about the code. ;-) Or rarher me. :-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-08 Thread Sergei Shtylyov
got something much better then uour original approach (AKA Occam's razor :-). Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] Farewell! - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 5/10] hpt366: remove -init_setup

2007-09-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Split off hpt{374,371,366}_init() helper from init_setup_hpt{374,371,366}(). * Merge init_setup_{374,372n,371,372a,302,366}() into hpt366_init_one(). While at it: * Use HPT36x name for HPT366/HPT368 chipsets. * Add .chip_name to struct hpt_info and

Re: [PATCH 5/10] hpt366: remove -init_setup

2007-09-14 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Split off hpt{374,371,366}_init() helper from init_setup_hpt{374,371,366}(). * Merge init_setup_{374,372n,371,372a,302,366}() into hpt366_init_one(). While at it: * Use HPT36x name for HPT366/HPT368 chipsets. * Add .chip_name to struct

[PATCH] ide: call udma_filter() before resorting to the UltraDMA mask

2007-09-15 Thread Sergei Shtylyov
Give the udma_filter() method call taking precedence over using the mode masks. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- Posting this change separately as have been asked. Should apply to the current Linus' tree... drivers/ide/ide-dma.c |7 +++--- 1 files changed, 4 insertions

Re: [PATCH 1/10] cmd64x: always set hwif-chipset for CMD646

2007-09-15 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: hwif-chipset should be set to ide_cmd646 also when DMA base is invalid. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 3/10] rz1000: set serialized flag only if mate interface exists

2007-09-15 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Setting hwif-serialized makes sense only if the mate interface exists. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 6/10] ide: remove unused -next field from ide_pci_device_t

2007-09-15 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] ide: call udma_filter() before resorting to the UltraDMA mask

2007-09-15 Thread Sergei Shtylyov
I wrote: Give the udma_filter() method call taking precedence over using the mode masks. I definitely need to be talking less (and doing more :-). Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH 7/10] ide: add -chipset field to ide_pci_device_t

2007-09-15 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add -chipset field to ide_pci_device_t and use it in ide_hwif_configure() to set hwif-chipset. Convert cmd64x, cy82c693, rz1000 and trm290 host drivers to use this new ability. While at it define hwif_chipset_t as u8 to save some space in hw_regs_t,

Re: [PATCH] ahci: Add MCP79 support to AHCI driver

2007-09-24 Thread Sergei Shtylyov
Hello. Peer Chen wrote: Code change, remove some Device IDs. Signed-off-by: Peer Chen [EMAIL PROTECTED] --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0 -0400 +++ linux-2.6.23-rc7/drivers/ata/ahci.c 2007-09-24 10:08:03.0 -0400 @@ -472,6 +472,14 @@

Re: [PATCH] ide: remove -ide_dma_check (take 2)

2007-09-24 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_TRUST_BIOS_FOR_DMA host flag for host drivers that depend on BIOS for programming device/controller for DMA. Set it in cy82c693, generic, ns87415, opti621 and trm290 host drivers. * Add IDE_HFLAG_VDMA host flag for host drivers using

Re: [patch] SB700 contains more than one IDE channel

2007-09-27 Thread Sergei Shtylyov
patch adding SB700 IDE device ID only support one IDE channel, which contains bug. The attached patch fix the bug. Signed-off-by: [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] -- diff -ruN linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c

Re: [PATCH 9/8] pdc202xx_old: remove broken SWDMA support

2007-09-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Documentation doesn't mention SWDMA and moreover all timings used for SWDMA modes were over-clocked when compared to ATA spec. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 1/8] amd74xx/via82cxxx: don't initialize drive-dn

2007-09-28 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: drive-dn is initialized by ide-probe.c::probe_hwif() so no need to do it in -init_hwif method. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 8/8] ata: add ATA_MWDMA* and ATA_SWDMA* defines

2007-09-28 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/include/linux/ata.h === --- a/include/linux/ata.h +++ b/include/linux/ata.h

Re: [PATCH 1/13] aec62xx: no need to disable UDMA in -init_hwif method for ATP850UF

2007-09-29 Thread Sergei Shtylyov
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-09-29 Thread Sergei Shtylyov
with his consent, also adding the method callout to ide_rate_filter(); - install the method for all chips to only return empty mask if a SATA drive is detected on HPT372{AN]/374 chips... Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] --- This patch is against the current Linus' tree. It has

Re: [PATCH] pata_hpt3x2n: Clean up DPLL stuff

2007-10-01 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Nobody commented when I asked for review earlier so it must be ok 8) It's not that I've seen this before so it must be ok 8) Not by me at least, so let me NAK it. 8-) Lets stick it in -mm to be sure Now let's unstick it. :-) Signed-off-by: Alan Cox

Re: [PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-10-02 Thread Sergei Shtylyov
-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied Thanks, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/15] ali14xx: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
at the code trying to understand how this can happen, and was unable to figure out. Probably was not hard enough... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Index:

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 5/15] slc90e66: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
to this in the kernel.org code, I haven't carried the fix to slc90e66... * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body

Re: [PATCH 15/15] ide: remove stale comments from ide-taskfile.c

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 10/15] ide: enhance ide_setup_pci_noise()

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Print PCI device Vendor ID, Device ID and revision in ide_setup_pci_noise(). * Remove no longer needed PCI device revision printing from ide_setup_pci_controller(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei

Re: [PATCH 14/15] ide: remove dead code from ide_driveid_update()

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Remove dead code from ide_driveid_update(). While at it: * Remove useless comment. * s/HWIF(drive)/drive-hwif/ Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe

Re: [PATCH 3/3] ide: add CONFIG_IDE_ARCH_OBSOLETE_INIT

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add CONFIG_IDE_ARCH_OBSOLETE_INIT to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_INIT in arch/ide.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] include/asm-arm26/ide.h |1 - No such file

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-03 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len() to ensure it is the appropriate size. It would

Re: [PATCH 11/15] ide: PCI BMDMA initialization fixes

2007-10-03 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Set hwif-dma_base only if allocation of extra ports succeeds. * Allocate hwif-dmatable_cpu before reserving I/O ports. Looks like a bit of teardown code was missed with that change... While at it: * Move setting of hwif-dma_{base,master}

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-04 Thread Sergei Shtylyov
Hello, I wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len() to ensure it is the appropriate size. It would be very wise to ensure

Re: [PATCH 5/10] ide: add hwif_register_devices() helper

2007-10-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add hwif_register_devices() helper to fix code duplication between probe_hwif_init_with_fixup() and ideprobe_init(). Also remove stale comment while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 6/8] ide: remove -init_setup_dma from ide_pci_device_t

2007-10-08 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/12] ide: check -dma_setup() return value in flagged_taskfile()

2007-10-09 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 7/13] ide: add IDE_HFLAG_LEGACY_IRQS host flag

2007-10-09 Thread Sergei Shtylyov
IDE_HFLAGS_PIIX define and don't use -init_hwif for MPIIX. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-15 Thread Sergei Shtylyov
Martin Rogge wrote: Hi Sergei and Bartlomiej, I have read in the changelog that both of you got linux kernel patches into 2.6.22-rc1 for the cmd64x driver. I found that some patches introduced in 2.6.22-rc1 break the CMD648 operation of one of my machines. (Actually I discovered it in

Re: [PATCH] libata-core: Drop in the final bit of IORDY handling

2007-10-15 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c linux-2.6.23-mm1/drivers/ata/libata-core.c --- linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c 2007-10-15

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Sergei Shtylyov
Alan Cox wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u

Re: [PATCH] libata-core: Don't have screaming fits over DF/ERR combinations

2007-10-15 Thread Sergei Shtylyov
Jeff Garzik wrote: Some hardware seems to get this wrong in a non-harmful way, and there are some devices that seem to do it deliberately for various reasons. Just take it as a device error not a catastrophic state machine explosion. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u

Re: [PATCH] libata-core: Drop in the final bit of IORDY handling

2007-10-15 Thread Sergei Shtylyov
Alan Cox wrote: + /* Ancient devices may need us to avoid IORDY */ + if (ata_pio_need_iordy(dev)) + tf.nsect = dev-xfer_mode; + else + tf.nsect = 0x01; This is wrong logic as I've alredy pointed out: according to the ATA-2 setting *any* PIO

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-16 Thread Sergei Shtylyov
Martin Rogge wrote: Could you git-bisect this? Although I have a couple of patch suspects (dealing with interrupts), all worked fine with PCI-649 just fine. PCI-648 is not really much different from 649 according to specs... Yes, I found the same when I managed to send the CMD 648 into

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-16 Thread Sergei Shtylyov
Hello. Mark Lord wrote: Could you git-bisect this? Although I have a couple of patch suspects (dealing with interrupts), all worked fine with PCI-649 just fine. PCI-648 is not really much different from 649 according to specs... Yes, I found the same when I managed to send the CMD

Re: [PATCH 6/12] ide: add struct ide_taskfile

2007-10-17 Thread Sergei Shtylyov
PROTECTED] Nearly-acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c [...] + if ((tf-command 0x01) == 0) { + u32 high, low

Re: [PATCH 5/12] ide: remove task_ioreg_t typedef

2007-10-17 Thread Sergei Shtylyov
] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/include/linux/hdreg.h === --- a/include/linux/hdreg.h +++ b/include/linux/hdreg.h [...] @@ -116,8 +116,8 @@ typedef union ide_reg_valid_s { } ide_reg_valid_t; typedef struct

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-17 Thread Sergei Shtylyov
Hello. Martin Rogge wrote: Martin, could you run git-bisect (http://kerneltrap.org/node/11753 - sorry for not explaining the procudure myself but Linus did it really well) starting with: git bisect good 688a87d145e04f6761c63e7f2e19fd9b3e4ca060 git bisect bad

Re: [PATCH 0/3] ide: Fix use of paired device

2007-10-18 Thread Sergei Shtylyov
Hello. Benjamin Herrenschmidt wrote: At least 2 drivers (siimage and cs5535) have a bug where they use the construct: ide_drive_t *pair = hwif-drives[drive-dn ^ 1]; To access the other drive in a master/slave pair. This is bogus because drive-dn is not the unit number, but

Re: [PATCH 0/3] ide: Fix use of paired device

2007-10-18 Thread Sergei Shtylyov
Hello, I wrote: At least 2 drivers (siimage and cs5535) have a bug where they use the construct: ide_drive_t *pair= hwif-drives[drive-dn ^ 1]; To access the other drive in a master/slave pair. This is bogus because drive-dn is not the unit number, but the global drive number, thus

Re: [PATCH 1/3] ide: Add ide_get_paired_drive() helper

2007-10-18 Thread Sergei Shtylyov
Benjamin Herrenschmidt wrote: This adds a helper to get to the other drive on a pair connected to a given hwif. Maibe mate drive would've been a better name that paired... Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 2/3] ide: Fix siimage driver accessing beyond array boundary

2007-10-18 Thread Sergei Shtylyov
PROTECTED] Please update the driver version in the driver's heading comment. Otherwise Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 3/3] ide: Fix cs5535 driver accessing beyond array boundary

2007-10-18 Thread Sergei Shtylyov
PROTECTED] Please update the driver version in the driver's heading comment. It also would be preferrable to fold this patch together with siimage path, or even fold all three together. Otherwise Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 9/12] ide-disk: use struct ide_taskfile in __ide_do_rw_disk()

2007-10-18 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR

Re: [PATCH 9/12] ide-disk: use struct ide_taskfile in __ide_do_rw_disk()

2007-10-18 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-19 Thread Sergei Shtylyov
Hello. Martin Rogge wrote: BTW, can you try adding #define DEBUG to the driver meanwhile?.. Yoda said: Try not. Do or do not. There is no try. :-) So I did it. To be precise, I #defined both DEBUG and CMD_DEBUG. However, I am not sure the result is conclusive. On a good kernel

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-20 Thread Sergei Shtylyov
Hello. Martin Rogge wrote: 00:04.1 IDE interface: Intel Corporation 82371AB/EB/MB PIIX4 IDE (rev 01) (prog-if 80 [Master]) Flags: medium devsel [virtual] Memory at 01f0 (32-bit, non-prefetchable) [disabled] [size=8] [virtual] Memory at 03f0 (type 3,

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-20 Thread Sergei Shtylyov
Martin Rogge wrote: 00:04.1 IDE interface: Intel Corporation 82371AB/EB/MB PIIX4 IDE (rev 01) (prog-if 80 [Master]) Flags: medium devsel [virtual] Memory at 01f0 (32-bit, non-prefetchable) [disabled] [size=8] [virtual] Memory at 03f0 (type 3, non-prefetchable)

Re: [PATCH 10/12] ide: add ide_tf_load() helper

2007-10-20 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide-taskfile.c @@ -62,6 +62,37 @@ static void taskfile_output_data(ide_dri

Re: [PATCH 4/12] ide-disk: add get_smart_data() helper

2007-10-20 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Merge get_smart_values() and get_smart_thresholds() into get_smart_data() helper. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] drivers/ide/Kconfig IDEPCI_SHARE_IRQ and IDEDISK_MULTI_MODE

2007-10-22 Thread Sergei Shtylyov
Matti Linnanvuori wrote: Correct IDEPCI_SHARE_IRQ description to keeping interrupts enabled when calling the PCI IDE action handler. Add IDEPCI_SHARE_IRQ and IDEDISK_MULTI_MODE help text from hdparm manual page. Signed-off-by: Matti Linnanvuori [EMAIL PROTECTED] NAK. @@ -154,6 +154,18

Re: [PATCH 11/15] ide: PCI BMDMA initialization fixes

2007-10-24 Thread Sergei Shtylyov
this change is actually unnecessary so revert it in v2. * Make ide_release_dma_engine() void and remove needless comment. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 12/12] ide: use do_rw_taskfile() in flagged_taskfile()

2007-10-24 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Based on the earlier work by Tejun Heo. * Move setting IDE_TFLAG_LBA48 taskfile flag from do_rw_taskfile() function to the callers. * Add IDE_TFLAG_FLAGGED taskfile flag for flagged taskfiles coming from ide_taskfile_ioctl(). Check it instead of

Re: Regression: commit ide: constify struct ide_port_info causes breakage

2007-10-26 Thread Sergei Shtylyov
Hello. Russell King wrote: commit 8562043606430185cad26d085d46adcc7ad67fd1 is broken, causing: CC drivers/ide/pci/cmd64x.o CC drivers/ide/pci/hpt366.o drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type conflict and therefore should be reverted.

Re: [PATCH] ide: remove stale ide.h configuration options

2007-10-27 Thread Sergei Shtylyov
for CRIS and FRV, otherwise to 1) for now but disallow overriding it by asm/ide.h. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from

Re: [PATCH 8/9] ide: replace ide_pci_device_t by struct ide_port_info

2007-10-27 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Rename struct ide_pci_device_s to struct ide_port_info. I'm not sure that ide_port_info name fits the data indeed, as those are not applicable only to the ports but to a chip as a whole, so ide_chip_info would seem a better name... but well, it's too

Re: [PATCH 5/15] ide: fix registers loading order for WIN_SMART in execute_drive_cmd()

2007-10-28 Thread Sergei Shtylyov
to separate changes which change the way in which hardware is accessed from code cleanups). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH 2/15] ide: CPU endianness doesn't matter for special_t

2007-10-31 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: special_t is used only internally by the IDE subsystem (it isn't related to hardware registers and isn't exported to the user-space). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei

Re: [PATCH 13/15] ide: remove hwif-intrproc

2007-10-31 Thread Sergei Shtylyov
for drive-quirk_list == 1 in ide_do_request(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] --- Handling of quirky drives (problems with nIEN) by hpt366 and pdc202xx_* looks suspicious... are the problems really dependent on the host

Re: [PATCH 4/15] ide: remove atapi_error_t

2007-11-01 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Remove atapi_error_t. While at it: * replace 'HWIF(drive)' by 'drive-hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-floppy.c |3 +-- drivers/ide/ide-lib.c| 21 ++---

Re: [PATCH 2/9] ide-disk: guarantee 400ns delay after writing command register

2007-11-04 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++ b/drivers/ide

Re: [PATCH 1/9] ide-disk: fix __ide_do_rw_disk() to use -OUTBSYNC

2007-11-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Fix __ide_do_rw_disk() to use -OUTBSYNC instead of -OUTB (needed for pmac and scc_pata host drivers). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 4/15] ide: remove atapi_error_t

2007-11-04 Thread Sergei Shtylyov
Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/ide-lib.c === --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c

Re: [PATCH 11/15] ide: remove QUIRK_LIST()

2007-11-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 9/15] ide-{floppy,tape,scsi}: fix register loading order when issuing packet command

2007-11-04 Thread Sergei Shtylyov
Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/15] ide: remove SELECT_INTERRUPT()

2007-11-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/15] ide-floppy: remove dead code

2007-11-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 7/15] ide: remove atapi_ireason_t

2007-11-04 Thread Sergei Shtylyov
. You're reading my mind. :-) Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Index: b/drivers/ide/ide-floppy.c === --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c

Re: [PATCH 5/15] ide: remove atapi_feature_t

2007-11-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove atapi_feature_t. While at it: * replace 'HWIF(drive)' by 'hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 6/15] ide: remove ata_nsector_t, ata_data_t and atapi_bcount_t

2007-11-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove ata_nsector_t, ata_data_t (unused) and atapi_bcount_t. While at it: * replace 'HWIF(drive)' by 'hwif' Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from

Re: [PATCH 8/15] ide-cd: fix register loading order in cdrom_start_packet_command()

2007-11-04 Thread Sergei Shtylyov
comment in the right place. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/18] ide: fix ide_find_dma_mode() to print human-readable info

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Problem reported by Mikael. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED

Re: [PATCH 2/18] ide-pmac: skip conservative PIO downgrade

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: We can skip conservative PIO downgrade (PIO3 becomes PIO2 etc.) on PMAC. Problem reported by Mikael. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send

Re: [PATCH 13/18] ide: don't BUG() on unsupported transfer modes

2007-11-06 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/18] ide: make 'extra' field in struct ide_port_info u8

2007-11-06 Thread Sergei Shtylyov
is 1 byte). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 5/18] ide: add missing HOB bit clearing to ide_dump_ata_status()

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 3/18] ide: add missing #ifdef/#endif CONFIG_IDE_TASK_IOCTL

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 4/18] ide: move ide_fixstring() documentation to ide-iops.c from ide.h

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 16/18] ide: remove redundant -ide_dma_on call from set_using_dma()

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: ide_set_dma() calls -ide_dma_on method itself and returns zero only if -ide_dma_on call succeeded. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH 18/18] ide: remove redundant DMA blacklist check from __ide_dma_on()

2007-11-06 Thread Sergei Shtylyov
'). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED

Re: [PATCH 1/2] sl82c105: program DMA/PIO timings in -dma_start/-ide_dma_end

2007-11-06 Thread Sergei Shtylyov
but unfinished version by now. :-| Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 2/2] sl82c105: remove no longer needed -selectproc method

2007-11-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Program register 0x40 in sl82c105_resetproc(). * Remove no longer needed sl82c105_selectproc() and pci_set_drvdata() calls. Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov

Re: [PATCH] pata_hpt37x: Fix outstanding bug reports on the HPT374 and 37x cable detect

2007-11-06 Thread Sergei Shtylyov
Alan Cox wrote: - Read frequency correctly - Correct cable detect handling I'm still not sure it's correct... - Fix wrong filter test Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH 11/18] pdc202xx_new: move PIO programming code to pdcnew_set_pio_mode()

2007-11-06 Thread Sergei Shtylyov
] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/15] ide: remove atapi_ireason_t

2007-11-06 Thread Sergei Shtylyov
] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 17/18] ide: cleanup ide_set_dma()

2007-11-08 Thread Sergei Shtylyov
returned by ide_dma_check() so remove dead code for other cases. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 15/18] sc1200: move DMA timings to timing tables

2007-11-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Based on pata_sc1200.c. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 7/18] ide: add ide_tf_read() helper

2007-11-09 Thread Sergei Shtylyov
[EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -913,6 +913,27 @@ enum { IDE_TFLAG_IN_DATA = (1 17

<    1   2   3   4   5   6   7   8   >