Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Jmondi, On Thu, Jun 15, 2017 at 7:11 PM, jmondi wrote: > Hi Dong, > > On Tue, Jun 13, 2017 at 02:25:08PM +0800, Dong Aisheng wrote: >> On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote: >> > Fair enough :) >> > >> > I'll try to keep this short: I don't like

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Jmondi, On Thu, Jun 15, 2017 at 7:11 PM, jmondi wrote: > Hi Dong, > > On Tue, Jun 13, 2017 at 02:25:08PM +0800, Dong Aisheng wrote: >> On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote: >> > Fair enough :) >> > >> > I'll try to keep this short: I don't like "output-enable", and at the >> > same

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Dong, On Tue, Jun 13, 2017 at 02:25:08PM +0800, Dong Aisheng wrote: > On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote: > > Fair enough :) > > > > I'll try to keep this short: I don't like "output-enable", and at the > > same time I don't think "output-high" and "output-low"

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Dong, On Tue, Jun 13, 2017 at 02:25:08PM +0800, Dong Aisheng wrote: > On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote: > > Fair enough :) > > > > I'll try to keep this short: I don't like "output-enable", and at the > > same time I don't think "output-high" and "output-low" fit well for > >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote: > Hi Linus, > > On Sun, Jun 11, 2017 at 11:45:49PM +0200, Linus Walleij wrote: >> On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote: >> > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: >> >> >> > I see

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, Jun 12, 2017 at 5:44 PM, jmondi wrote: > Hi Linus, > > On Sun, Jun 11, 2017 at 11:45:49PM +0200, Linus Walleij wrote: >> On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote: >> > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: >> >> >> > I see three options here: >> >> > >> >> >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Sun, Jun 11, 2017 at 11:45:49PM +0200, Linus Walleij wrote: > On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote: > > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: > > >> > I see three options here: > >> > > >> > 1) Add "output-buffer-enable" and

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Sun, Jun 11, 2017 at 11:45:49PM +0200, Linus Walleij wrote: > On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote: > > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: > > >> > I see three options here: > >> > > >> > 1) Add "output-buffer-enable" and "input-buffer-enable" > >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote: > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: >> > I see three options here: >> > >> > 1) Add "output-buffer-enable" and "input-buffer-enable" >> > we end up with >> > "output-high" >> > "output-low" >> >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Jun 9, 2017 at 9:50 AM, jmondi wrote: > On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: >> > I see three options here: >> > >> > 1) Add "output-buffer-enable" and "input-buffer-enable" >> > we end up with >> > "output-high" >> > "output-low" >> > "input-enable" >> >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Dong, On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: > Hi Linus & j, > > >> > >> I just want to know if "output-enable" is the right name? > >> "output-buffer-enable"? > > > > Great! Thanks! > > > > On naming: if we need "output-buffer-enable" should we add > >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Dong, On Fri, Jun 09, 2017 at 03:26:57PM +0800, Dong Aisheng wrote: > Hi Linus & j, > > >> > >> I just want to know if "output-enable" is the right name? > >> "output-buffer-enable"? > > > > Great! Thanks! > > > > On naming: if we need "output-buffer-enable" should we add > >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus & j, On Mon, May 29, 2017 at 6:42 PM, jmondi wrote: > Hi Linus, > > On Mon, May 29, 2017 at 10:45:44AM +0200, Linus Walleij wrote: >> On Tue, May 23, 2017 at 8:37 PM, jmondi wrote: >> >> >> I did not follow too much. >> >> But it seems

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus & j, On Mon, May 29, 2017 at 6:42 PM, jmondi wrote: > Hi Linus, > > On Mon, May 29, 2017 at 10:45:44AM +0200, Linus Walleij wrote: >> On Tue, May 23, 2017 at 8:37 PM, jmondi wrote: >> >> >> I did not follow too much. >> >> But it seems IMX7ULP/Vybrid to be also a fan of generic >> >>

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hello Jacopo and Linus, On Monday, May 29, 2017, jmondi wrote: > > > We can handle 'bi-directional' pins with static tables in our pin > > > controller driver and not have it anywhere in DT. > > > > This sounds like a viable approach. > > > > I just want to know if "output-enable" is the right

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hello Jacopo and Linus, On Monday, May 29, 2017, jmondi wrote: > > > We can handle 'bi-directional' pins with static tables in our pin > > > controller driver and not have it anywhere in DT. > > > > This sounds like a viable approach. > > > > I just want to know if "output-enable" is the right

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Mon, May 29, 2017 at 10:45:44AM +0200, Linus Walleij wrote: > On Tue, May 23, 2017 at 8:37 PM, jmondi wrote: > > >> I did not follow too much. > >> But it seems IMX7ULP/Vybrid to be also a fan of generic > >> output-enable/input-enable > >> property. > >> > >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Mon, May 29, 2017 at 10:45:44AM +0200, Linus Walleij wrote: > On Tue, May 23, 2017 at 8:37 PM, jmondi wrote: > > >> I did not follow too much. > >> But it seems IMX7ULP/Vybrid to be also a fan of generic > >> output-enable/input-enable > >> property. > >> > >> See: > >> Figure 5-2.

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 23, 2017 at 8:37 PM, jmondi wrote: >> I did not follow too much. >> But it seems IMX7ULP/Vybrid to be also a fan of generic >> output-enable/input-enable >> property. >> >> See: >> Figure 5-2. GPIO PAD in Page 241 >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 23, 2017 at 8:37 PM, jmondi wrote: >> I did not follow too much. >> But it seems IMX7ULP/Vybrid to be also a fan of generic >> output-enable/input-enable >> property. >> >> See: >> Figure 5-2. GPIO PAD in Page 241 >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Tue, May 23, 2017 at 06:08:31PM +0800, Dong Aisheng wrote: > On Tue, May 9, 2017 at 5:19 AM, Linus Walleij > wrote: > > On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: > > > >> From my perspective these flags are configurations internal

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Tue, May 23, 2017 at 06:08:31PM +0800, Dong Aisheng wrote: > On Tue, May 9, 2017 at 5:19 AM, Linus Walleij > wrote: > > On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: > > > >> From my perspective these flags are configurations internal to the pin > >> controller hardware used to

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 5:19 AM, Linus Walleij wrote: > On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: > >> From my perspective these flags are configurations internal to the pin >> controller hardware used to enable/disable input buffers when a pin

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 5:19 AM, Linus Walleij wrote: > On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: > >> From my perspective these flags are configurations internal to the pin >> controller hardware used to enable/disable input buffers when a pin needs to >> perform in both direction. >> The

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Geert, On Friday, May 12, 2017, Geert Uytterhoeven wrote: > 12 x 16 = 192, not 384. Opps, my math was off! (I think I need another cup of coffee this morning) > Do you need all possible combinations of input, output, and bi-dir? > I assumed they're mutually exclusive. If not, you need 3

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Geert, On Friday, May 12, 2017, Geert Uytterhoeven wrote: > 12 x 16 = 192, not 384. Opps, my math was off! (I think I need another cup of coffee this morning) > Do you need all possible combinations of input, output, and bi-dir? > I assumed they're mutually exclusive. If not, you need 3

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Chris, On Fri, May 12, 2017 at 2:13 PM, Chris Brandt wrote: > On Friday, May 12, 2017, Geert Uytterhoeven wrote: >> Jacopo, Chris: Would two bits per pin/function (none, input, output, >> bidir) >> be sufficient? >> That makes one u16 per pin. So roughtly 12 ports x

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Chris, On Fri, May 12, 2017 at 2:13 PM, Chris Brandt wrote: > On Friday, May 12, 2017, Geert Uytterhoeven wrote: >> Jacopo, Chris: Would two bits per pin/function (none, input, output, >> bidir) >> be sufficient? >> That makes one u16 per pin. So roughtly 12 ports x 16 pins => 384 bytes. >>

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Geert and Linus, On Friday, May 12, 2017, Geert Uytterhoeven wrote: > Jacopo, Chris: Would two bits per pin/function (none, input, output, > bidir) > be sufficient? > That makes one u16 per pin. So roughtly 12 ports x 16 pins => 384 bytes. > Plus code to handle it. After all not that bad...

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Geert and Linus, On Friday, May 12, 2017, Geert Uytterhoeven wrote: > Jacopo, Chris: Would two bits per pin/function (none, input, output, > bidir) > be sufficient? > That makes one u16 per pin. So roughtly 12 ports x 16 pins => 384 bytes. > Plus code to handle it. After all not that bad...

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, May 12, 2017, linux-renesas-soc-ow...@vger.kernel.org wrote: > As you say this is actually fixing hardware bugs, we can expect these > quirky tables to be gone in the next hardware generation, right? I see this particular pin controller as a one shot deal. For the next part in this

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, May 12, 2017, linux-renesas-soc-ow...@vger.kernel.org wrote: > As you say this is actually fixing hardware bugs, we can expect these > quirky tables to be gone in the next hardware generation, right? I see this particular pin controller as a one shot deal. For the next part in this

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Fri, May 12, 2017 at 11:04 AM, Linus Walleij wrote: > On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven > wrote: > > Oops missed this: > >> Hence I think we should not use generic pin properties, but consider these >> settings to be

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Fri, May 12, 2017 at 11:04 AM, Linus Walleij wrote: > On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven > wrote: > > Oops missed this: > >> Hence I think we should not use generic pin properties, but consider these >> settings to be part of pinmux configuration. >> As having

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: Oops missed this: > Hence I think we should not use generic pin properties, but consider these > settings to be part of pinmux configuration. > As having large tables in the driver is undesirable, I think storing

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: Oops missed this: > Hence I think we should not use generic pin properties, but consider these > settings to be part of pinmux configuration. > As having large tables in the driver is undesirable, I think storing the > settings in the

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: > The question I'm asking myself is: are these settings related to pin > configuration (i.e. depending on the use of the pin, and several settings > are valid, depending on the use case), or are they related to

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven wrote: > The question I'm asking myself is: are these settings related to pin > configuration (i.e. depending on the use of the pin, and several settings > are valid, depending on the use case), or are they related to pinmux > (i.e. defined by

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus et al, On Mon, May 8, 2017 at 11:19 PM, Linus Walleij wrote: > On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: >> From my perspective these flags are configurations internal to the pin >> controller hardware used to enable/disable input

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus et al, On Mon, May 8, 2017 at 11:19 PM, Linus Walleij wrote: > On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: >> From my perspective these flags are configurations internal to the pin >> controller hardware used to enable/disable input buffers when a pin needs to >> perform in both

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Andy, On Mon, May 08, 2017 at 08:47:17PM +0300, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 8:25 PM, jmondi wrote: > > Andy, > > > > On Mon, May 08, 2017 at 07:08:32PM +0300, Andy Shevchenko wrote: > >> On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: >

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Andy, On Mon, May 08, 2017 at 08:47:17PM +0300, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 8:25 PM, jmondi wrote: > > Andy, > > > > On Mon, May 08, 2017 at 07:08:32PM +0300, Andy Shevchenko wrote: > >> On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > >> > On Sun, May 07, 2017 at

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: > From my perspective these flags are configurations internal to the pin > controller hardware used to enable/disable input buffers when a pin needs to > perform in both direction. > The level of detail I can provide on this is the

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 7:25 PM, jmondi wrote: > From my perspective these flags are configurations internal to the pin > controller hardware used to enable/disable input buffers when a pin needs to > perform in both direction. > The level of detail I can provide on this is the logical diagram we

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hello Andy, On Monday, May 08, 2017, Andy Shevchenko wrote: > > Bi-Directional: > > > > For any pin that needs to drive (send) or sense (receive) signals, the > pin > > mux controller can only enable 1 direction of buffers (in this case, it > > only the output buffers). Therefore the appropriate

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hello Andy, On Monday, May 08, 2017, Andy Shevchenko wrote: > > Bi-Directional: > > > > For any pin that needs to drive (send) or sense (receive) signals, the > pin > > mux controller can only enable 1 direction of buffers (in this case, it > > only the output buffers). Therefore the appropriate

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 8:02 PM, Chris Brandt wrote: > On Monday, May 08, 2017, Andy Shevchenko wrote: >> On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: >> > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: >> >> On Fri, Apr 28, 2017 at

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 8:02 PM, Chris Brandt wrote: > On Monday, May 08, 2017, Andy Shevchenko wrote: >> On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: >> > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: >> >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko >> >> wrote: >> >> >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 8:25 PM, jmondi wrote: > Andy, > > On Mon, May 08, 2017 at 07:08:32PM +0300, Andy Shevchenko wrote: >> On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: >> > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: >> >> On Fri, Apr

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 8:25 PM, jmondi wrote: > Andy, > > On Mon, May 08, 2017 at 07:08:32PM +0300, Andy Shevchenko wrote: >> On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: >> > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: >> >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Andy, On Mon, May 08, 2017 at 07:08:32PM +0300, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: > >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko > >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Andy, On Mon, May 08, 2017 at 07:08:32PM +0300, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: > >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko > >> wrote: > >> > >> > Linus, for me it looks like

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Monday, May 08, 2017, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: > >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko > >> wrote: > >> > >> > Linus,

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Monday, May 08, 2017, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: > >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko > >> wrote: > >> > >> > Linus, for me it looks like better to revert that

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko >> wrote: >> >> > Linus, for me it looks like better to revert that change, until we >>

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Mon, May 8, 2017 at 7:01 PM, jmondi wrote: > On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: >> On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko >> wrote: >> >> > Linus, for me it looks like better to revert that change, until we >> > will have clear picture why existing

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: > On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko > wrote: > > > Linus, for me it looks like better to revert that change, until we > > will have clear picture why existing configuration

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Sun, May 07, 2017 at 09:52:49AM +0200, Linus Walleij wrote: > On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko > wrote: > > > Linus, for me it looks like better to revert that change, until we > > will have clear picture why existing configuration parameters can't > > work. > > Yeah

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko wrote: > Linus, for me it looks like better to revert that change, until we > will have clear picture why existing configuration parameters can't > work. Yeah I'll revert the binding for fixes. Yours, Linus Walleij

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 4:53 PM, Andy Shevchenko wrote: > Linus, for me it looks like better to revert that change, until we > will have clear picture why existing configuration parameters can't > work. Yeah I'll revert the binding for fixes. Yours, Linus Walleij

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 12:09 PM, Geert Uytterhoeven wrote: >> You can certainly call it whatever the datasheet calls it >> in your driver #defines but for the DT bindings we would >> ideally have the physical world things. > > FWIW, you have already applied v4. Yeah I

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 12:09 PM, Geert Uytterhoeven wrote: >> You can certainly call it whatever the datasheet calls it >> in your driver #defines but for the DT bindings we would >> ideally have the physical world things. > > FWIW, you have already applied v4. Yeah I noticed when sending pull

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Andy Shevchenko wrote: > > We were using "input-enable" to signal when the pin function that we set > also needs to be forcible set to input by the software (once again, > because the HW is not smart enough to do it on its own), but is different > than the bi-directional

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Andy Shevchenko wrote: > > We were using "input-enable" to signal when the pin function that we set > also needs to be forcible set to input by the software (once again, > because the HW is not smart enough to do it on its own), but is different > than the bi-directional

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 6:16 PM, Chris Brandt wrote: > On Friday, April 28, 2017, Andy Shevchenko wrote: >> Had you read the following, esp. Note there? >> >> * @PIN_CONFIG_INPUT_ENABLE: enable the pin's input. Note that this does >> not >> * affect the pin's

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 6:16 PM, Chris Brandt wrote: > On Friday, April 28, 2017, Andy Shevchenko wrote: >> Had you read the following, esp. Note there? >> >> * @PIN_CONFIG_INPUT_ENABLE: enable the pin's input. Note that this does >> not >> * affect the pin's ability to drive output. 1

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Andy Shevchenko wrote: > Had you read the following, esp. Note there? > > * @PIN_CONFIG_INPUT_ENABLE: enable the pin's input. Note that this does > not > * affect the pin's ability to drive output. 1 enables input, 0 > disables > * input. > > For me manual

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Andy Shevchenko wrote: > Had you read the following, esp. Note there? > > * @PIN_CONFIG_INPUT_ENABLE: enable the pin's input. Note that this does > not > * affect the pin's ability to drive output. 1 enables input, 0 > disables > * input. > > For me manual

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 4:18 PM, Chris Brandt wrote: > On Friday, April 28, 2017, Andy Shevchenko wrote: >> > In the RZ/A1 HW manual you can kind of see that in 54.18 Port Control >> Logical Diagram (but that wasn't obvious to me at first). >> >> Please, post a link to

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 4:18 PM, Chris Brandt wrote: > On Friday, April 28, 2017, Andy Shevchenko wrote: >> > In the RZ/A1 HW manual you can kind of see that in 54.18 Port Control >> Logical Diagram (but that wasn't obvious to me at first). >> >> Please, post a link to it or copy essential parts.

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Andy Shevchenko wrote: > > In the RZ/A1 HW manual you can kind of see that in 54.18 Port Control > Logical Diagram (but that wasn't obvious to me at first). > > Please, post a link to it or copy essential parts. This board the RZ/A1 GENMAI board.

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Andy Shevchenko wrote: > > In the RZ/A1 HW manual you can kind of see that in 54.18 Port Control > Logical Diagram (but that wasn't obvious to me at first). > > Please, post a link to it or copy essential parts. This board the RZ/A1 GENMAI board.

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 3:07 PM, Chris Brandt wrote: > On Friday, April 28, 2017, Linus Walleij wrote: >> > For me it looks like you are trying to alias open-drain + bias or >> > alike. Don't actually see the benefit of it. >> >> Andy is bringing up a valid point. And I

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Fri, Apr 28, 2017 at 3:07 PM, Chris Brandt wrote: > On Friday, April 28, 2017, Linus Walleij wrote: >> > For me it looks like you are trying to alias open-drain + bias or >> > alike. Don't actually see the benefit of it. >> >> Andy is bringing up a valid point. And I remember asking about this

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Linus Walleij wrote: > > For me it looks like you are trying to alias open-drain + bias or > > alike. Don't actually see the benefit of it. > > Andy is bringing up a valid point. And I remember asking about this before. > > What does "bi-directional" really mean,

RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Friday, April 28, 2017, Linus Walleij wrote: > > For me it looks like you are trying to alias open-drain + bias or > > alike. Don't actually see the benefit of it. > > Andy is bringing up a valid point. And I remember asking about this before. > > What does "bi-directional" really mean,

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Fri, Apr 28, 2017 at 10:32 AM, Linus Walleij wrote: > On Thu, Apr 27, 2017 at 4:56 PM, Andy Shevchenko > wrote: >> On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi >> wrote: >>> Add bi-directional and

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

Hi Linus, On Fri, Apr 28, 2017 at 10:32 AM, Linus Walleij wrote: > On Thu, Apr 27, 2017 at 4:56 PM, Andy Shevchenko > wrote: >> On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi >> wrote: >>> Add bi-directional and output-enable pin configuration properties. >>> >>> bi-directional allows to

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Thu, Apr 27, 2017 at 4:56 PM, Andy Shevchenko wrote: > On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi > wrote: >> Add bi-directional and output-enable pin configuration properties. >> >> bi-directional allows to specify when a pin shall

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Thu, Apr 27, 2017 at 4:56 PM, Andy Shevchenko wrote: > On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi > wrote: >> Add bi-directional and output-enable pin configuration properties. >> >> bi-directional allows to specify when a pin shall operate in input and >> output mode at the same time.

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi wrote: > Add bi-directional and output-enable pin configuration properties. > > bi-directional allows to specify when a pin shall operate in input and > output mode at the same time. This is particularly useful in platforms

Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable

On Thu, Apr 27, 2017 at 11:19 AM, Jacopo Mondi wrote: > Add bi-directional and output-enable pin configuration properties. > > bi-directional allows to specify when a pin shall operate in input and > output mode at the same time. This is particularly useful in platforms > where input and output