Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-29 Thread Michał Orzeł
On 29.04.2020 10:57, Jani Nikula wrote: > On Tue, 28 Apr 2020, Michal Orzel wrote: >> As suggested by the TODO list for the kernel DRM subsystem, replace >> the deprecated functions that take/drop modeset locks with new helpers. >> >> Signed-off-by: Michal Orzel >> --- >>

Re: [RFC 1/3] powernv/cpuidle : Support for pre-entry and post exit of stop state in firmware

2020-04-29 Thread Abhishek
Hi Nick, Have you posted out the kernel side of "opal v4" patchset? I could only find the opal patchset. Thanks, Abhishek On 04/28/2020 06:38 AM, Nicholas Piggin wrote: Thanks for picking this up and pushing it along. I do plan to come back and take another look at it all, but what we do need

Re: [PATCH v3 1/1] scsi: pm: Balance pm_only counter of request queue during system resume

2020-04-29 Thread Can Guo
Hi Bart, On 2020-04-30 13:08, Bart Van Assche wrote: On 2020-04-29 21:10, Can Guo wrote: During system resume, scsi_resume_device() decreases a request queue's pm_only counter if the scsi device was quiesced before. But after that, if the scsi device's RPM status is RPM_SUSPENDED, the pm_only

Re: [PATCH 8/9] perf intel-pt: Update documentation about itrace G and L options

2020-04-29 Thread Adrian Hunter
On 30/04/20 2:03 am, Andi Kleen wrote: >> +One caveat with the G and L options is that they work poorly with "Large >> PEBS". >> +Large PEBS means PEBS records will be accumulated by hardware and the >> written >> +into the event buffer in one go. That reduces interrupts, but can give very >>

Re: [PATCH] crypto: bcm - Fix unused assignment

2020-04-29 Thread Herbert Xu
On Sat, Apr 25, 2020 at 10:24:14PM +0800, Tang Bin wrote: > Delete unused initialized value in cipher.c file. > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/crypto/bcm/cipher.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Patch applied.

Re: [PATCH] crypto: bcm - Remove the unnecessary cast for PTR_ERR().

2020-04-29 Thread Herbert Xu
On Sat, Apr 25, 2020 at 10:22:58PM +0800, Tang Bin wrote: > It's not necessary to specify 'int' casting for PTR_ERR(). > > Signed-off-by: Zhang Shengju > Signed-off-by: Tang Bin > --- > drivers/crypto/bcm/cipher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks.

Re: [PATCH -next] hwrng: cctrng - Make some symbols static

2020-04-29 Thread Herbert Xu
Zou Wei wrote: > Fix the following sparse warnings: > > drivers/char/hw_random/cctrng.c:316:6: warning: symbol > 'cc_trng_compwork_handler' was not declared. Should it be static? > drivers/char/hw_random/cctrng.c:451:6: warning: symbol > 'cc_trng_startwork_handler' was not declared. Should it be

Re: [PATCH v3 0/3] crypto: fix some DRBG Kconfig deps

2020-04-29 Thread Herbert Xu
On Fri, Apr 24, 2020 at 01:40:44PM +, Corentin Labbe wrote: > Hello > > Fix serie try to fix some DRBG depencies in Kconfig > > Change since v2: > - added patch #2 > > Changes since v1: > - Updated commit message with recursive dependency > > Corentin Labbe (3): > crypto: drbg: DRBG

Re: [PATCH crypto-stable v3 1/2] crypto: arch/lib - limit simd usage to 4k chunks

2020-04-29 Thread Herbert Xu
On Wed, Apr 22, 2020 at 05:18:53PM -0600, Jason A. Donenfeld wrote: > The initial Zinc patchset, after some mailing list discussion, contained > code to ensure that kernel_fpu_enable would not be kept on for more than > a 4k chunk, since it disables preemption. The choice of 4k isn't totally >

Re: [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static

2020-04-29 Thread Herbert Xu
On Thu, Apr 23, 2020 at 10:22:36AM +0800, Zou Wei wrote: > Fix the following sparse warning: > > drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset' > was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- >

Re: [PATCH] padata: add separate cpuhp node for CPUHP_PADATA_DEAD

2020-04-29 Thread Herbert Xu
On Tue, Apr 21, 2020 at 12:34:55PM -0400, Daniel Jordan wrote: > Removing the pcrypt module triggers this: > > general protection fault, probably for non-canonical > address 0xdead0122 > CPU: 5 PID: 264 Comm: modprobe Not tainted 5.6.0+ #2 > Hardware name: QEMU Standard PC >

Re: [PATCH] lib/mpi: Fix 64-bit MIPS build with Clang

2020-04-29 Thread Herbert Xu
On Tue, Apr 21, 2020 at 02:47:04PM -0700, Nathan Chancellor wrote: > When building 64r6_defconfig with CONFIG_MIPS32_O32 disabled and > CONFIG_CRYPTO_RSA enabled: > > lib/mpi/generic_mpih-mul1.c:37:24: error: invalid use of a cast in a > inline asm context requiring an l-value: remove the cast >

Re: [PATCH v2] crypto: ccp: Add support for SEV-ES to the PSP driver

2020-04-29 Thread Herbert Xu
On Tue, Apr 21, 2020 at 12:44:49PM -0500, Tom Lendacky wrote: > To provide support for SEV-ES, the hypervisor must provide an area of > memory to the PSP. Once this Trusted Memory Region (TMR) is provided to > the PSP, the contents of this area of memory are no longer available to > the x86. > >

Re: [PATCH v7 4/7] OPP: Add support for parsing interconnect bandwidth

2020-04-29 Thread Viresh Kumar
On 24-04-20, 12:20, Matthias Kaehlcke wrote: > On Fri, Apr 24, 2020 at 06:54:01PM +0300, Georgi Djakov wrote: > > + for (i = 0; i < num_paths; i++) { > > + opp_table->paths[i] = of_icc_get_by_index(dev, i); > > + if (IS_ERR(opp_table->paths[i])) { > > + ret

Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

2020-04-29 Thread Leon Romanovsky
On Tue, Apr 28, 2020 at 11:23:47PM +0200, Arnd Bergmann wrote: > Moving the mlx5_ifc_query_qp_out_bits structure on the stack was a bit > excessive and now causes the compiler to complain on 32-bit architectures: > > drivers/net/ethernet/mellanox/mlx5/core/debugfs.c: In function >

Re: [PATCH v7 2/7] OPP: Add helpers for reading the binding properties

2020-04-29 Thread Viresh Kumar
On 24-04-20, 10:30, Matthias Kaehlcke wrote: > Hi Georgi, > > On Fri, Apr 24, 2020 at 06:53:59PM +0300, Georgi Djakov wrote: > > From: Saravana Kannan > > > > The opp-hz DT property is not mandatory and we may use another property > > as a key in the OPP table. Add helper functions to simplify

Re: [PATCH v7 1/7] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings

2020-04-29 Thread Viresh Kumar
On 24-04-20, 18:53, Georgi Djakov wrote: > From: Saravana Kannan > > Interconnects often quantify their performance points in terms of > bandwidth. So, add opp-peak-kBps (required) and opp-avg-kBps (optional) to > allow specifying Bandwidth OPP tables in DT. > > opp-peak-kBps is a required

Re: [PATCH v3 1/1] scsi: pm: Balance pm_only counter of request queue during system resume

2020-04-29 Thread Bart Van Assche
On 2020-04-29 21:10, Can Guo wrote: > During system resume, scsi_resume_device() decreases a request queue's > pm_only counter if the scsi device was quiesced before. But after that, > if the scsi device's RPM status is RPM_SUSPENDED, the pm_only counter is > still held (non-zero). Current scsi

Re: [PATCH net-next v3 2/2] net: phy: tja11xx: add support for master-slave configuration

2020-04-29 Thread Oleksij Rempel
On Wed, Apr 29, 2020 at 08:20:53PM +0200, Andrew Lunn wrote: > > +static int tja11xx_config_aneg(struct phy_device *phydev) > > +{ > > + u16 ctl = 0; > > + int ret; > > + > > + switch (phydev->master_slave_set) { > > + case PORT_MODE_CFG_MASTER_FORCE: > > + case

Re: [PATCH] misc: fastrpc: fix memory leak

2020-04-29 Thread Bjorn Andersson
On Wed 29 Apr 08:29 PDT 2020, Srinivas Kandagatla wrote: > if misc_register() fails, previously allocated data is left without freeing, > this could result in memory leak. s/could/will/ > > So fix it! > As Markus pointed out, a Fixes: tag would be in order to make sure this is backported

Re: [PATCH] arm: mm: use __pfn_to_section() to get mem_section

2020-04-29 Thread Anshuman Khandual
On 04/30/2020 09:34 AM, Guixiong Wei wrote: > Use __pfn_to_section() to get mem_section, instead of open-coding it. There is no open coding here. __pfn_to_section() helper which already wraps around __nr_to_section(pfn_to_section_nr(pfn)), should be used directly instead. > No semantic

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-29 Thread Oleksij Rempel
Hi Michal, On Wed, Apr 29, 2020 at 09:52:22PM +0200, Michal Kubecek wrote: > On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: > > This UAPI is needed for BroadR-Reach 100BASE-T1 devices. Due to lack of > > auto-negotiation support, we needed to be able to configure the > >

Re: [RFC 1/5] soundwire: bus_type: add sdw_master_device support

2020-04-29 Thread Vinod Koul
On 30-04-20, 11:24, Bard liao wrote: > > On 4/28/2020 3:51 PM, Vinod Koul wrote: > > On 28-04-20, 08:55, Greg KH wrote: > > > On Tue, Apr 28, 2020 at 12:19:51PM +0530, Vinod Koul wrote: > > > > On 28-04-20, 08:37, Greg KH wrote: > > > > > On Tue, Apr 28, 2020 at 10:01:44AM +0530, Vinod Koul

Re: [PATCH 10/10] efi/libstub: Check return value of efi_parse_options

2020-04-29 Thread kbuild test robot
Hi Arvind, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on efi/next] [also build test WARNING on next-20200429] [cannot apply to v5.7-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest

Re: [PATCH v3 1/3] crypto: drbg: DRBG should select SHA512

2020-04-29 Thread Herbert Xu
On Fri, Apr 24, 2020 at 01:40:45PM +, Corentin Labbe wrote: > Since DRBG could use SHA384/SHA512, it should select it. > > Signed-off-by: Corentin Labbe > --- > crypto/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index

Re: BPF vs objtool again

2020-04-29 Thread Josh Poimboeuf
On Wed, Apr 29, 2020 at 09:24:00PM -0700, Alexei Starovoitov wrote: > > This would actually be contingent on RETPOLINE, not FRAME_POINTER. > > > > (FRAME_POINTER was the other issue with the "optimize" attribute, which > > we're reverting so it'll no longer be a problem.) > > > > So if you're

Re: [PATCH net-next v3 1/2] ethtool: provide UAPI for PHY master/slave configuration.

2020-04-29 Thread Oleksij Rempel
Hi Andrew, On Wed, Apr 29, 2020 at 08:16:14PM +0200, Andrew Lunn wrote: > On Tue, Apr 28, 2020 at 09:53:07AM +0200, Oleksij Rempel wrote: > > Hi Oleksij > > Sorry for taking a while to review this. I was busy fixing the FEC > driver which i broke :-( Not problem. Interesting, what is wrong

Re: [PATCH] sound:hdmi:fix without unlocked before return

2020-04-29 Thread Wu Bo
On 2020/4/29 15:27, Takashi Iwai wrote: On Sun, 26 Apr 2020 15:17:22 +0200, Wu Bo wrote: Fix the following coccicheck warning: sound/pci/hda/patch_hdmi.c:1852:2-8: preceding lock on line 1846 After add sanity check to pass klockwork check, The spdif_mutex should be unlock before return true

Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

2020-04-29 Thread Sam Ravnborg
On Wed, Apr 29, 2020 at 11:27:22PM -0300, Vitor Massaru Iha wrote: > On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > > Add missed ":" on kernel-doc function parameter. > > > > > > This patch fixes this warnings from `make htmldocs`: > >

[PATCH v2 0/2] Add support for MaxLinear/Exar USB to serial converters

2020-04-29 Thread mani
From: Manivannan Sadhasivam Hello, This series adds support for MaxLinear/Exar USB to serial converters. This driver only supports XR21V141X series but provision has been made to support other series in future. This driver is inspired from the initial one submitted by Patong Yang:

[PATCH v2 2/2] usb: serial: xr_serial: Add gpiochip support

2020-04-29 Thread mani
From: Manivannan Sadhasivam Add gpiochip support for Maxlinear/Exar USB to serial converter for controlling the available gpios. Cc: Linus Walleij Cc: linux-g...@vger.kernel.org Reviewed-by: Linus Walleij Signed-off-by: Manivannan Sadhasivam --- drivers/usb/serial/xr_serial.c | 197

[PATCH v2 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver

2020-04-29 Thread mani
From: Manivannan Sadhasivam Add support for MaxLinear/Exar USB to Serial converters. This driver only supports XR21V141X series but provision has been made to support other series in future. This driver is inspired from the initial one submitted by Patong Yang:

[PATCH v4 12/16] powerpc/watchpoint: Use builtin ALIGN*() macros

2020-04-29 Thread Ravi Bangoria
Currently we calculate hw aligned start and end addresses manually. Replace them with builtin ALIGN_DOWN() and ALIGN() macros. So far end_addr was inclusive but this patch makes it exclusive (by avoiding -1) for better readability. Suggested-by: Christophe Leroy Signed-off-by: Ravi Bangoria

[PATCH v4 11/16] powerpc/watchpoint: Introduce is_ptrace_bp() function

2020-04-29 Thread Ravi Bangoria
Introduce is_ptrace_bp() function and move the check inside the function. We will utilize it more in later set of patches. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/kernel/hw_breakpoint.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH v4 13/16] powerpc/watchpoint: Prepare handler to handle more than one watcnhpoint

2020-04-29 Thread Ravi Bangoria
Currently we assume that we have only one watchpoint supported by hw. Get rid of that assumption and use dynamic loop instead. This should make supporting more watchpoints very easy. With more than one watchpoint, exception handler need to know which DAWR caused the exception, and hw currently

[PATCH v4 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable

2020-04-29 Thread Ravi Bangoria
Instead of disabling only first watchpoint, disable all available watchpoints while clearing dawr_force_enable. Callback function is used only for disabling watchpoint, rename it to disable_dawrs_cb(). And null_brk parameter is not really required while disabling watchpoint, remove it.

[PATCH v4 07/16] powerpc/watchpoint: Get watchpoint count dynamically while disabling them

2020-04-29 Thread Ravi Bangoria
Instead of disabling only one watchpoint, get num of available watchpoints dynamically and disable all of them. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/include/asm/hw_breakpoint.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v4 05/16] powerpc/watchpoint: Provide DAWR number to set_dawr

2020-04-29 Thread Ravi Bangoria
Introduce new parameter 'nr' to set_dawr() which indicates which DAWR should be programed. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/include/asm/hw_breakpoint.h | 4 ++-- arch/powerpc/kernel/dawr.c | 15 ++-

[PATCH v4 14/16] powerpc/watchpoint: Don't allow concurrent perf and ptrace events

2020-04-29 Thread Ravi Bangoria
With Book3s DAWR, ptrace and perf watchpoints on powerpc behaves differently. Ptrace watchpoint works in one-shot mode and generates signal before executing instruction. It's ptrace user's job to single-step the instruction and re-enable the watchpoint. OTOH, in case of perf watchpoint, kernel

[PATCH v4 15/16] powerpc/watchpoint/xmon: Don't allow breakpoint overwriting

2020-04-29 Thread Ravi Bangoria
Xmon allows overwriting breakpoints because it's supported by only one dawr. But with multiple dawrs, overwriting becomes ambiguous or unnecessary complicated. So let's not allow it. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/xmon/xmon.c | 4 1 file

[PATCH v4 16/16] powerpc/watchpoint/xmon: Support 2nd dawr

2020-04-29 Thread Ravi Bangoria
Add support for 2nd DAWR in xmon. With this, we can have two simultaneous breakpoints from xmon. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/xmon/xmon.c | 101 ++- 1 file changed, 69 insertions(+), 32 deletions(-) diff --git

[PATCH v4 09/16] powerpc/watchpoint: Convert thread_struct->hw_brk to an array

2020-04-29 Thread Ravi Bangoria
So far powerpc hw supported only one watchpoint. But Future Power architecture is introducing 2nd DAWR. Convert thread_struct->hw_brk into an array. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/include/asm/processor.h | 2 +- arch/powerpc/kernel/process.c

[PATCH v4 10/16] powerpc/watchpoint: Use loop for thread_struct->ptrace_bps

2020-04-29 Thread Ravi Bangoria
ptrace_bps is already an array of size HBP_NUM_MAX. But we use hardcoded index 0 while fetching/updating it. Convert such code to loop over array. ptrace interface to use multiple watchpoint remains same. eg: two PPC_PTRACE_SETHWDEBUG calls will create two watchpoint if hw underneath supports it.

[PATCH v4 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint

2020-04-29 Thread Ravi Bangoria
Introduce new parameter 'nr' to __set_breakpoint() which indicates which DAWR should be programed. Also convert current_brk variable to an array. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/include/asm/debug.h | 2 +-

[PATCH v4 04/16] powerpc/watchpoint/ptrace: Return actual num of available watchpoints

2020-04-29 Thread Ravi Bangoria
User can ask for num of available watchpoints(dbginfo.num_data_bps) using ptrace(PPC_PTRACE_GETHWDBGINFO). Return actual number of available watchpoints on the machine rather than hardcoded 1. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling ---

[PATCH v4 01/16] powerpc/watchpoint: Rename current DAWR macros

2020-04-29 Thread Ravi Bangoria
Future Power architecture is introducing second DAWR. Use real register names from ISA for current macros: s/SPRN_DAWR/SPRN_DAWR0/ s/SPRN_DAWRX/SPRN_DAWRX0/ Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/include/asm/reg.h | 4 ++--

Re: [PATCH v2 2/3] powerpc/numa: Prefer node id queried from vphn

2020-04-29 Thread Srikar Dronamraju
* Gautham R Shenoy [2020-04-29 12:22:29]: > Hello Srikar, > > > > + if (nid == NUMA_NO_NODE) { > > + cpu = of_get_cpu_node(i, NULL); > > + if (cpu) { > > Why are we not retaining the BUG_ON(!cpu) assert here ? > > > +

[PATCH v4 00/16] powerpc/watchpoint: Preparation for more than one watchpoint

2020-04-29 Thread Ravi Bangoria
So far, powerpc Book3S code has been written with an assumption of only one watchpoint. But future power architecture is introducing second watchpoint register (DAWR). Even though this patchset does not enable 2nd DAWR, it make the infrastructure ready so that enabling 2nd DAWR should just be a

[PATCH v4 03/16] powerpc/watchpoint: Introduce function to get nr watchpoints dynamically

2020-04-29 Thread Ravi Bangoria
So far we had only one watchpoint, so we have hardcoded HBP_NUM to 1. But future Power architecture is introducing 2nd DAWR and thus kernel should be able to dynamically find actual number of watchpoints supported by hw it's running on. Introduce function for the same. Also convert HBP_NUM macro

[PATCH v4 02/16] powerpc/watchpoint: Add SPRN macros for second DAWR

2020-04-29 Thread Ravi Bangoria
Future Power architecture is introducing second DAWR. Add SPRN_ macros for the same. Signed-off-by: Ravi Bangoria Reviewed-by: Michael Neuling --- arch/powerpc/include/asm/reg.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/include/asm/reg.h

Re: [PATCH V2] fs/ceph:fix double unlock in handle_cap_export()

2020-04-29 Thread Wu Bo
On 2020/4/30 10:50, Yan, Zheng wrote: On Wed, Apr 29, 2020 at 8:49 AM Wu Bo wrote: On 2020/4/28 22:48, Jeff Layton wrote: On Tue, 2020-04-28 at 21:13 +0800, Wu Bo wrote: if the ceph_mdsc_open_export_target_session() return fails, should add a lock to avoid twice unlocking. Because the lock

linux-next: manual merge of the driver-core tree with the driver-core.current tree

2020-04-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the driver-core tree got a conflict in: drivers/base/dd.c between commits: ce68929f07de ("driver core: Revert default driver_deferred_probe_timeout value to 0") 4ccc03e28ec3 ("driver core: Use dev_warn() instead of dev_WARN() for

Re: BPF vs objtool again

2020-04-29 Thread Alexei Starovoitov
On Wed, Apr 29, 2020 at 10:53:15PM -0500, Josh Poimboeuf wrote: > On Wed, Apr 29, 2020 at 07:10:52PM -0700, Alexei Starovoitov wrote: > > > For example: > > > > > > #define GOTO({ goto *jumptable[insn->code]; }) > > > > > > and then replace all 'goto select_insn' with 'GOTO;' > > > > > >

Re: [PATCH] hw_breakpoint: Remove unused '__register_perf_hw_breakpoint' declaration

2020-04-29 Thread Bhupesh Sharma
Hi Mark, Thanks for the review. On Tue, Apr 28, 2020 at 3:37 PM Mark Rutland wrote: > > Hi Bhupesh, > > On Tue, Apr 28, 2020 at 02:22:17PM +0530, Bhupesh Sharma wrote: > > commit b326e9560a28 ("hw-breakpoints: Use overflow handler instead of > > the event callback") removed

Re: [PATCH 3/5] swiotlb: Add alloc and free APIs

2020-04-29 Thread kbuild test robot
Hi Srivatsa, Thank you for the patch! Yet something to improve: [auto build test ERROR on vhost/linux-next] [also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3 next-20200429] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH v5 0/5] Track and expose idle PURR and SPURR ticks

2020-04-29 Thread Gautham R Shenoy
Hello Michael, On Thu, Apr 30, 2020 at 12:34:52PM +1000, Michael Ellerman wrote: > Gautham R Shenoy writes: > > On Mon, Apr 20, 2020 at 03:46:35PM -0700, Tyrel Datwyler wrote: > >> On 4/7/20 1:47 AM, Gautham R. Shenoy wrote: > >> > From: "Gautham R. Shenoy" > >> > > >> > Hi, > >> > > >> >

Re: [Nouveau] [PATCH] drm/nouveau: Fix regression by audio component transition

2020-04-29 Thread Ben Skeggs
Good catch! The OR is definitely a far better choice than the head here, as it's what we use to select the GPU-side HDA registers too. Merged. On Thu, 16 Apr 2020 at 17:54, Takashi Iwai wrote: > > Since the commit 742db30c4ee6 ("drm/nouveau: Add HD-audio component > notifier support"), the

Re: [PATCH 0/2] Build ORC fast lookup table in scripts/sorttable tool

2020-04-29 Thread Josh Poimboeuf
On Wed, Apr 29, 2020 at 11:06:58PM -0500, Josh Poimboeuf wrote: > On Thu, Apr 30, 2020 at 10:32:17AM +0800, changhuaixin wrote: > > > > > > > On Apr 29, 2020, at 4:49 PM, Peter Zijlstra wrote: > > > > > > On Wed, Apr 29, 2020 at 02:46:24PM +0800, Huaixin Chang wrote: > > >> Move building of

[PATCH v3 1/1] scsi: pm: Balance pm_only counter of request queue during system resume

2020-04-29 Thread Can Guo
During system resume, scsi_resume_device() decreases a request queue's pm_only counter if the scsi device was quiesced before. But after that, if the scsi device's RPM status is RPM_SUSPENDED, the pm_only counter is still held (non-zero). Current scsi resume hook only sets the RPM status of the

Re: [PATCH 0/2] Build ORC fast lookup table in scripts/sorttable tool

2020-04-29 Thread Josh Poimboeuf
On Thu, Apr 30, 2020 at 10:32:17AM +0800, changhuaixin wrote: > > > > On Apr 29, 2020, at 4:49 PM, Peter Zijlstra wrote: > > > > On Wed, Apr 29, 2020 at 02:46:24PM +0800, Huaixin Chang wrote: > >> Move building of fast lookup table from boot to sorttable tool. This saves > >> us > >> 6380us

[PATCH] arm: mm: use __pfn_to_section() to get mem_section

2020-04-29 Thread Guixiong Wei
Use __pfn_to_section() to get mem_section, instead of open-coding it. No semantic changes. Signed-off-by: Guixiong Wei --- arch/arm64/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index e42727e3568e..d2df416b840e 100644

Re: [PATCH] efi/tpm: fix section mismatch warning

2020-04-29 Thread Jarkko Sakkinen
On Wed, Apr 29, 2020 at 09:01:08PM +0200, Arnd Bergmann wrote: > Building with gcc-10 causes a harmless warning about a section mismatch: > > WARNING: modpost: vmlinux.o(.text.unlikely+0x5e191): Section mismatch in > reference from the function tpm2_calc_event_log_size() to the function >

[PATCH v2] dt-bindings: arm-smmu: Add sc7180 compatible string and mem_iface clock

2020-04-29 Thread Sharat Masetty
This patch adds a new compatible string for sc7180 and also an additional clock listing needed to power the TBUs and the TCU. Signed-off-by: Sharat Masetty --- v2: Addressed review comments from Doug Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 8 1 file changed, 8

Re: [PATCH 1/1] drm/nouveau: Use generic helper to check _PR3 presence

2020-04-29 Thread Ben Skeggs
Thanks! On Thu, 23 Apr 2020 at 17:37, Kai-Heng Feng wrote: > > Replace nouveau_pr3_present() in favor of a more generic one, > pci_pr3_present(). > > Also the presence of upstream bridge _PR3 doesn't need to go hand in > hand with device's _DSM, so check _PR3 before _DSM. > > Signed-off-by:

Re: [PATCH v29 00/20] Intel SGX foundations

2020-04-29 Thread Jarkko Sakkinen
On Wed, Apr 29, 2020 at 08:14:59AM -0700, Sean Christopherson wrote: > On Wed, Apr 29, 2020 at 08:23:29AM +0300, Jarkko Sakkinen wrote: > > On Sun, Apr 26, 2020 at 11:57:53AM -0500, Dr. Greg wrote: > > > On Wed, Apr 22, 2020 at 12:52:56AM +0300, Jarkko Sakkinen wrote: > > > > > > Good day, I hope

Re: [PATCH -next] KVM: MIPS/VZ: Remove unneeded semicolon

2020-04-29 Thread Huacai Chen
Reviewed-by: Huacai Chen On Thu, Apr 30, 2020 at 11:08 AM Zou Wei wrote: > > Fixes coccicheck warnings: > > arch/mips/kvm/vz.c:1186:4-5: Unneeded semicolon > arch/mips/kvm/vz.c:1195:3-4: Unneeded semicolon > arch/mips/kvm/vz.c:1949:3-4: Unneeded semicolon > arch/mips/kvm/vz.c:1121:2-3: Unneeded

Re: [PATCH -next] drm/nouveau/acr: Use kmemdup instead of kmalloc and memcpy

2020-04-29 Thread Ben Skeggs
Thanks! On Wed, 22 Apr 2020 at 16:56, Zou Wei wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:103:23-30: WARNING opportunity > for kmemdup > drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:113:22-29: WARNING opportunity > for kmemdup > > Fixes:

Re: [PATCH -next] KVM: MIPS/Emulate: Remove unneeded semicolon

2020-04-29 Thread Huacai Chen
Reviewed-by: Huacai Chen On Thu, Apr 30, 2020 at 11:13 AM Zou Wei wrote: > > Fixes coccicheck warnings: > > arch/mips/kvm/emulate.c:1793:3-4: Unneeded semicolon > arch/mips/kvm/emulate.c:1968:3-4: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- >

Re: BPF vs objtool again

2020-04-29 Thread Josh Poimboeuf
On Wed, Apr 29, 2020 at 07:10:52PM -0700, Alexei Starovoitov wrote: > > For example: > > > > #define GOTO({ goto *jumptable[insn->code]; }) > > > > and then replace all 'goto select_insn' with 'GOTO;' > > > > The problem is that with RETPOLINE=y, the function text size grows from > > 5k to

[PATCH -next] drm/amd/display: Fix unsigned comparison to zero

2020-04-29 Thread Zou Wei
Fixes coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c:1398:60-61: WARNING: Unsigned expression compared with zero: j >= 0 Fixes: 238387774232 ("drm/amd/display: fix rn soc bb update") Reported-by: Hulk Robot Signed-off-by: Zou Wei ---

Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1

2020-04-29 Thread Linus Torvalds
On Wed, Apr 29, 2020 at 8:41 PM Jann Horn wrote: > > | So a ptrace() user (or [...] wouldn't even see the impossible EAGAIN error. > > So I assumed you explicitly wanted ptrace() to restart, too. I was > just pointing out that that didn't make sense to me. I'm actually ok with the restart

Re: [PATCH v29 00/20] Intel SGX foundations

2020-04-29 Thread Jarkko Sakkinen
On Wed, Apr 29, 2020 at 05:27:48PM +0200, Jethro Beekman wrote: > On 2020-04-21 23:52, Jarkko Sakkinen wrote: > > Intel(R) SGX is a set of CPU instructions that can be used by applications > > to set aside private regions of code and data. The code outside the enclave > > is disallowed to access

Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1

2020-04-29 Thread Jann Horn
On Thu, Apr 30, 2020 at 5:26 AM Linus Torvalds wrote: > On Wed, Apr 29, 2020 at 8:00 PM Jann Horn wrote: > > > > But if we go with Bernd's approach together with your restart > > suggestion, > > So repeat after me: Bernd's approach _without_ the restart is unacceptable. > > It's unacceptable

Re:Re: [PATCH] clk/meson: fixes memleak issue in init err branch

2020-04-29 Thread 赵军奎
From: Martin Blumenstingl Date: 2020-04-30 01:43:55 To: Jerome Brunet Cc: Bernard Zhao ,Neil Armstrong ,Stephen Boyd ,Kevin Hilman ,linux-amlo...@lists.infradead.org,linux-...@vger.kernel.org,linux-kernel@vger.kernel.org,opensource.ker...@vivo.com Subject: Re: [PATCH] clk/meson: fixes

Re: rcu_barrier() + membarrier() + scheduler deadlock?

2020-04-29 Thread Qian Cai
inux-mm/master/x86.config [53294.651754][T149877] futex_wake_op: trinity-c25 tries to shift op by -17; fix this program [53323.947396][T150988] futex_wake_op: trinity-c6 tries to shift op by -5; fix this program [53458.295837][ T215] INFO: task kworker/u64:0:8 blocked for more than 122 second

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-29 Thread Xin Ji
On Tue, Apr 28, 2020 at 12:05:08PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 08:12:04PM +0800, Nicolas Boichat wrote: > > On Fri, Apr 24, 2020 at 2:51 PM Xin Ji wrote: > > > > > > On Thu, Apr 23, 2020 at 07:55:15PM +0800, Nicolas Boichat wrote: > > > > Hi, > > > > > > > > Just

Re: rcu_barrier() + membarrier() + scheduler deadlock?

2020-04-29 Thread Paul E. McKenney
fix this program > > [52896.369779][T151054] futex_wake_op: trinity-c23 tries to shift op by > > 710; fix this program > > [52901.770688][ T310] INFO: task kworker/36:2:142207 blocked for more than > > 122 seconds. > > [52901.811471][ T310] Tainted: G

[RFC PATCH] fs: Move @f_count to different cacheline with @f_mode

2020-04-29 Thread Shaokun Zhang
From: Yuqi Jin __fget_files does check the @f_mode with mask variable and will do some atomic operations on @f_count while both are on the same cacheline. Many CPU cores do file access and it will cause much conflicts on @f_count. If we could make the two members into different cachelines, it

Re: How to upload fpga firmware

2020-04-29 Thread Moritz Fischer
On Mon, Apr 27, 2020 at 08:44:33AM +0200, Sascha Hauer wrote: > On Fri, Apr 24, 2020 at 08:59:49PM -0700, Moritz Fischer wrote: > > Hi Sascha, > > > > On Thu, Apr 23, 2020 at 08:23:31AM +0200, Sascha Hauer wrote: > > > Hi Moritz, > > > > > > On Wed, Apr 22, 2020 at 06:36:48PM -0700, Moritz

Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1

2020-04-29 Thread Linus Torvalds
On Wed, Apr 29, 2020 at 8:00 PM Jann Horn wrote: > > But if we go with Bernd's approach together with your restart > suggestion, So repeat after me: Bernd's approach _without_ the restart is unacceptable. It's unacceptable because it breaks things that currently work, and returns EAGAIN in

Re: [PATCH v6] MIPS: Loongson: Add DMA support for LS7A

2020-04-29 Thread Jiaxun Yang
于 2020年4月30日 GMT+08:00 上午10:31:07, Tiezhu Yang 写到: >In the current market, the most used bridge chip on the Loongson >platform are RS780E and LS7A, the RS780E bridge chip is already >supported by the mainline kernel. > >In order to use the default implementation of __phys_to_dma() and

Re: [LTP] [PATCH v4 3/3] syscalls/pipe2_03: Add new test for pipe2 O_DIRECT flag

2020-04-29 Thread Yang Xu
Hi Linus On Sun, Apr 26, 2020 at 4:59 AM Li Wang wrote: From kernel code seems you are right. The pipe indeed takes use of PAGE_SIZE(ppc64le: 64kB) to split the writes data in the packetized mode (marked by O_DIRECT). But in the manual page, O_DIRECT indicates us the PIPE_BUF is the

Re: rcu_barrier() + membarrier() + scheduler deadlock?

2020-04-29 Thread Paul E. McKenney
to shift op by 710; > fix this program > [52901.770688][ T310] INFO: task kworker/36:2:142207 blocked for more than > 122 seconds. > [52901.811471][ T310] Tainted: G L > 5.7.0-rc3-next-20200429 #2 > [52901.849148][ T310] "echo 0 > /proc/sys/ker

Beantragen Sie eine dringende Gutschrift

2020-04-29 Thread Morgan Stanley
-- Sind Sie ein Geschftsmann oder eine Geschftsfrau? Befinden Sie sich in einer Finanzkrise oder bentigen Sie Mittel, um ein eigenes Unternehmen zu grnden? Bentigen Sie einen Kredit, um Ihre Schulden zu begleichen, Ihre Rechnungen zu bezahlen oder ein gutes Geschft zu erffnen? Haben Sie

[PATCH -next] KVM: MIPS/Emulate: Remove unneeded semicolon

2020-04-29 Thread Zou Wei
Fixes coccicheck warnings: arch/mips/kvm/emulate.c:1793:3-4: Unneeded semicolon arch/mips/kvm/emulate.c:1968:3-4: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Zou Wei --- arch/mips/kvm/emulate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 3/4] MIPS: VDSO: Use $(LD) instead of $(CC) to link VDSO

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 06:46:33PM +0100, Maciej W. Rozycki wrote: > On Mon, 27 Apr 2020, Nathan Chancellor wrote: > > > > Can you actually record in the change description what the difference in > > > the relevant link command is, as shown where `V=1' has been used with > > > `make'

Re: How to update a piece of flash for FPGA firmware?

2020-04-29 Thread Moritz Fischer
Hi Matthew, Yilun On Tue, Apr 28, 2020 at 03:06:07PM -0700, matthew.gerl...@linux.intel.com wrote: > Hi Yilun, > > You raise some very interesting questions. Please see > my comments below. > > Matthew > > On Tue, 28 Apr 2020, Xu Yilun wrote: > > > Hi, > > > > I wonder if an updating of FPGA

[PATCH 0/2] perf stat: Support overall statistics for interval mode

2020-04-29 Thread Jin Yao
Currently perf-stat supports to print counts at regular interval (-I), but it's not very easy for user to get the overall statistics. With this patchset, it supports to report the summary at the end of interval output. For example, root@kbl-ppc:~# perf stat -e cycles -I1000 --interval-count 2

[PATCH 1/2] perf evsel: Create counts for collecting summary data

2020-04-29 Thread Jin Yao
It would be useful to support the overall statistics for perf-stat interval mode. For example, report the summary at the end of "perf-stat -I" output. But since perf-stat can support many aggregation modes, such as --per-thread, --per-socket, -M and etc, we need a solution which doesn't bring

[PATCH 2/2] perf stat: Report summary for interval mode

2020-04-29 Thread Jin Yao
Currently perf-stat supports to print counts at regular interval (-I), but it's not very easy for user to get the overall statistics. The patch uses 'evsel->summary_counts' to sum up the per interval counts and copy the counts to 'evsel->counts' after printing the interval results. Next, we just

[PATCH -next] KVM: MIPS/VZ: Remove unneeded semicolon

2020-04-29 Thread Zou Wei
Fixes coccicheck warnings: arch/mips/kvm/vz.c:1186:4-5: Unneeded semicolon arch/mips/kvm/vz.c:1195:3-4: Unneeded semicolon arch/mips/kvm/vz.c:1949:3-4: Unneeded semicolon arch/mips/kvm/vz.c:1121:2-3: Unneeded semicolon arch/mips/kvm/vz.c:2188:3-4: Unneeded semicolon Reported-by: Hulk Robot

Re: [PATCH v5 0/5] Allow ld.lld to link the MIPS VDSO

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 09:04:42AM +0200, Sedat Dilek wrote: > On Wed, Apr 29, 2020 at 12:14 AM Nathan Chancellor > wrote: > > > Patch 1 adds ld.lld support to Kconfig so that we can avoid certain > > ld.bfd checks. > > > > Is it possible to introduce and add LD_IS_BFD Kconfig for ld.bfd in

Re: [PATCH v4 1/5] kbuild: add CONFIG_LD_IS_LLD

2020-04-29 Thread Nathan Chancellor
On Wed, Apr 29, 2020 at 09:13:40AM +0200, Sedat Dilek wrote: > On Wed, Apr 29, 2020 at 12:14 AM Nathan Chancellor > wrote: > > > > From: Sami Tolvanen > > > > Similarly to the CC_IS_CLANG config, add LD_IS_LLD to avoid GNU ld > > specific logic such as ld-version or ld-ifversion and gain the > >

[PATCH v2] dt-bindings: thermal: Convert UniPhier thermal monitor to json-schema

2020-04-29 Thread Kunihiko Hayashi
Convert the UniPhier thermal monitor binding to DT schema format. Signed-off-by: Kunihiko Hayashi --- Changes since v1: - Add maxItems to "socionext,tmod-calibration" property - Fix indents in examples .../thermal/socionext,uniphier-thermal.yaml| 59

Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1

2020-04-29 Thread Jann Horn
On Thu, Apr 30, 2020 at 4:20 AM Linus Torvalds wrote: > On Wed, Apr 29, 2020 at 6:08 PM Bernd Edlinger > wrote: > > > > I added the BIG FAT WARNNIG comments as a mitigation for that. > > Did you like those comments? > > No. > > What's the point olf saying "THIS CODE IS GARBAGE" and then

rcu_barrier() + membarrier() + scheduler deadlock?

2020-04-29 Thread Qian Cai
; fix this program [52896.369779][T151054] futex_wake_op: trinity-c23 tries to shift op by 710; fix this program [52901.770688][ T310] INFO: task kworker/36:2:142207 blocked for more than 122 seconds. [52901.811471][ T310] Tainted: G L 5.7.0-rc3-next-20200429 #2 [52901.849148

Re: [PATCH V2 00/16] arm64/cpufeature: Introduce ID_PFR2, ID_DFR1, ID_MMFR5 and other changes

2020-04-29 Thread Anshuman Khandual
On 04/30/2020 02:56 AM, Will Deacon wrote: > Hi Anshuman, > > On Wed, Apr 29, 2020 at 03:07:15PM +0530, Anshuman Khandual wrote: >> On 04/14/2020 03:18 PM, Anshuman Khandual wrote: >>> This series is primarily motivated from an adhoc list from Mark Rutland >>> during our previous ID_ISAR6

Re: [PATCH] dt-bindings: thermal: Convert UniPhier thermal monitor to json-schema

2020-04-29 Thread Kunihiko Hayashi
Hi Rob, On 2020/04/29 1:20, Rob Herring wrote: On Thu, Apr 16, 2020 at 02:12:15PM +0900, Kunihiko Hayashi wrote: Convert the UniPhier thermal monitor binding to DT schema format. Signed-off-by: Kunihiko Hayashi --- .../thermal/socionext,uniphier-thermal.yaml| 57 +++

Re: [PATCH V2] fs/ceph:fix double unlock in handle_cap_export()

2020-04-29 Thread Yan, Zheng
On Wed, Apr 29, 2020 at 8:49 AM Wu Bo wrote: > > On 2020/4/28 22:48, Jeff Layton wrote: > > On Tue, 2020-04-28 at 21:13 +0800, Wu Bo wrote: > >> if the ceph_mdsc_open_export_target_session() return fails, > >> should add a lock to avoid twice unlocking. > >> Because the lock will be released at

[PATCH -next] dlm: Remove unneeded semicolon

2020-04-29 Thread Zou Wei
Fixes coccicheck warning: fs/dlm/rcom.c:566:2-3: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Zou Wei --- fs/dlm/rcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c index e3d9f72..4daf5dc 100644 --- a/fs/dlm/rcom.c +++

  1   2   3   4   5   6   7   8   9   10   >