Re: [ANNOUNCE] libtraceevent.git

2020-10-12 Thread Tony Jones
On Mon, Oct 12, 2020 at 11:19:50AM -0400, Steven Rostedt wrote: > Once it's shown that it works for all the package maintainers, I will tag > it which should create the tarballs automatically on the above link. Hi. It builds fine for me after manually creating the tarball from git. Once there

Re: [PATCH 1/2] perf script python: integrate page reclaim analyze script

2019-09-25 Thread Tony Jones
On 9/25/19 6:56 PM, Tony Jones wrote: > On 9/18/19 7:38 AM, Yafang Shao wrote: >> A new perf script page-reclaim is introduced in this patch. This new script >> is used to report the page reclaim details. The possible usage of this >> script is as bellow, >> - id

Re: [PATCH 1/2] perf script python: integrate page reclaim analyze script

2019-09-25 Thread Tony Jones
On 9/18/19 7:38 AM, Yafang Shao wrote: > A new perf script page-reclaim is introduced in this patch. This new script > is used to report the page reclaim details. The possible usage of this > script is as bellow, > - identify latency spike caused by direct reclaim > - whehter the latency spike is

Re: [PATCH 2/2] tracing, vmscan: add comments for perf script page-reclaim

2019-09-25 Thread Tony Jones
On 9/18/19 7:38 AM, Yafang Shao wrote: > Currently there's no easy way to make perf scripts in sync with > tracepoints. One possible way is to run perf's tests regularly, another way > is once we changes the definitions of tracepoints we must keep in mind that > the perf scripts which are using

[tip:perf/urgent] perf script python: Add Python3 support to export-to-sqlite.py

2019-03-22 Thread tip-bot for Tony Jones
Commit-ID: ebf6c5c181abe9309788c6241d39602a1ce18723 Gitweb: https://git.kernel.org/tip/ebf6c5c181abe9309788c6241d39602a1ce18723 Author: Tony Jones AuthorDate: Fri, 8 Mar 2019 16:05:17 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 11 Mar 2019 16:12:59 -0300 perf script

[tip:perf/urgent] perf script python: Add Python3 support to exported-sql-viewer.py

2019-03-22 Thread tip-bot for Tony Jones
Commit-ID: beda0e725e5f06aca27eda2434ea9447dad88e36 Gitweb: https://git.kernel.org/tip/beda0e725e5f06aca27eda2434ea9447dad88e36 Author: Tony Jones AuthorDate: Fri, 8 Mar 2019 16:05:15 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 11 Mar 2019 16:12:52 -0300 perf script

[tip:perf/urgent] perf script python: Add printdate function to SQL exporters

2019-03-22 Thread tip-bot for Tony Jones
Commit-ID: 49f93bbf17e6267eb34e0c12a9813f3a8723749e Gitweb: https://git.kernel.org/tip/49f93bbf17e6267eb34e0c12a9813f3a8723749e Author: Tony Jones AuthorDate: Fri, 8 Mar 2019 16:05:18 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 11 Mar 2019 16:13:02 -0300 perf script

[tip:perf/urgent] perf script python: Add Python3 support to export-to-postgresql.py

2019-03-22 Thread tip-bot for Tony Jones
Commit-ID: 1937b0560c3ea43b1b0f7d3617949ca50de8f8c0 Gitweb: https://git.kernel.org/tip/1937b0560c3ea43b1b0f7d3617949ca50de8f8c0 Author: Tony Jones AuthorDate: Fri, 8 Mar 2019 16:05:16 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 11 Mar 2019 16:12:57 -0300 perf script

Re: [PATCH 1/8] perf/x86/intel: Fix memory corruption

2019-03-21 Thread Tony Jones
On 3/21/19 11:20 AM, Peter Zijlstra wrote: > Might be best to have someone test this.. someone with ucode and a > machine etc.. :-) If your own company can't oblige you here Peter :-) I'm sure I can make some time to test it.

[tip:perf/urgent] perf script python: Add Python3 support to intel-pt-events.py

2019-03-09 Thread tip-bot for Tony Jones
Commit-ID: fdf2460c297f1bb2f3bd20b3b52903b267af9050 Gitweb: https://git.kernel.org/tip/fdf2460c297f1bb2f3bd20b3b52903b267af9050 Author: Tony Jones AuthorDate: Tue, 5 Mar 2019 08:19:02 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Mar 2019 18:12:33 -0300 perf script

[tip:perf/urgent] perf script python: add Python3 support to check-perf-trace.py

2019-03-09 Thread tip-bot for Tony Jones
Commit-ID: 57e604b16362273af6a517abaa6cd1133a7fc732 Gitweb: https://git.kernel.org/tip/57e604b16362273af6a517abaa6cd1133a7fc732 Author: Tony Jones AuthorDate: Fri, 1 Mar 2019 17:18:59 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Mar 2019 18:10:46 -0300 perf script

[tip:perf/urgent] perf script python: Add Python3 support to event_analyzing_sample.py

2019-03-09 Thread tip-bot for Tony Jones
Commit-ID: c253c72e9d6723c8b078beb362f050059ef5de39 Gitweb: https://git.kernel.org/tip/c253c72e9d6723c8b078beb362f050059ef5de39 Author: Tony Jones AuthorDate: Fri, 1 Mar 2019 17:19:00 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Mar 2019 18:11:11 -0300 perf script

[tip:perf/urgent] perf script python: Add Python3 support to futex-contention.py

2019-03-09 Thread tip-bot for Tony Jones
Commit-ID: de2ec16bd438945813198d4de2339a396904c206 Gitweb: https://git.kernel.org/tip/de2ec16bd438945813198d4de2339a396904c206 Author: Tony Jones AuthorDate: Fri, 1 Mar 2019 17:18:58 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Mar 2019 18:10:43 -0300 perf script

[tip:perf/urgent] perf script python: Remove mixed indentation

2019-03-09 Thread tip-bot for Tony Jones
Commit-ID: b504d7f6876515b74c8e27a44ccdb22372616d97 Gitweb: https://git.kernel.org/tip/b504d7f6876515b74c8e27a44ccdb22372616d97 Author: Tony Jones AuthorDate: Fri, 1 Mar 2019 17:18:57 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Mar 2019 18:09:14 -0300 perf script

[tip:perf/urgent] tools lib traceevent: Fix buffer overflow in arg_eval

2019-03-09 Thread tip-bot for Tony Jones
Commit-ID: 7c5b019e3a638a5a290b0ec020f6ca83d2ec2aaa Gitweb: https://git.kernel.org/tip/7c5b019e3a638a5a290b0ec020f6ca83d2ec2aaa Author: Tony Jones AuthorDate: Wed, 27 Feb 2019 17:55:32 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 28 Feb 2019 16:06:47 -0300 tools lib

[PATCH v3 4/4] perf script python: add printdate function to SQL exporters

2019-03-08 Thread Tony Jones
Introduce a printdate function to eliminate the repetitive use of datetime.datetime.today() in the SQL exporting scripts. Signed-off-by: Tony Jones Acked-by: Adrian Hunter --- tools/perf/scripts/python/export-to-postgresql.py | 19 +++ tools/perf/scripts/python/export

[PATCH v3 2/4] perf script python: add Python3 support to export-to-postgresql.py

2019-03-08 Thread Tony Jones
Support both Python2 and Python3 in the export-to-postgresql.py script. The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Adrian Hunter Signed-off-by: Seeteena Thoufeek --- tools/perf/scripts/python/export

[PATCH v3 3/4] perf script python: add Python3 support to export-to-sqlite.py

2019-03-08 Thread Tony Jones
Support both Python2 and Python3 in the export-to-sqlite.py script The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/export-to-sqlite.py | 23

[PATCH v3 1/4] perf script python: add Python3 support to exported-sql-viewer.py

2019-03-08 Thread Tony Jones
Support both Python2 and Python3 in the exported-sql-viewer.py script. The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/exported-sql-viewer.py | 42

[PATCH v3 0/4] perf script python: add Python3 support

2019-03-08 Thread Tony Jones
This is v3 of my version of the patchset. The exporter and viewer changes were all in one patch for V2. For V3 I split them into 3 patches for the reasons below. Patch#1 adds Python3 support to exported-sql-viewer Patch#2 adds Python3 support to export-to-postgresql Patch#3 adds Python3

Re: [PATCH v2 6/7] perf script python: add Python3 support to sql scripts

2019-03-06 Thread Tony Jones
On 3/6/19 1:26 AM, Adrian Hunter wrote: > On 2/03/19 3:19 AM, Tony Jones wrote: >> Support both Python2 and Python3 in the exported-sql-viewer.py, >> export-to-postgresql.py and export-to-sqlite.py scripts >> >> There may be differences in the ordering of output

Re: [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py

2019-03-05 Thread Tony Jones
On 3/5/19 8:10 AM, Tony Jones wrote: > > Sure enough, I managed to attach the wrong patch. Sorry. I'll attach revised > (v3) > to this thread as the change is trivial. From: Tony Jones Date: Tue, 05 Mar 2019 08:31:30 -0800 Subject: [PATCH v3] perf script python: add Python3 suppo

Re: [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py

2019-03-05 Thread Tony Jones
On 3/5/19 7:02 AM, Tony Jones wrote: > I tested the patch on a Skylake system but it was not connected to our > standard > network so I had to move files manually. It seems I managed to somehow mess > up > and not attach the correct patch :( Sure enough, I managed to attach

Re: [PATCH v2 0/7] perf script python: add Python3 support

2019-03-05 Thread Tony Jones
On 3/5/19 6:53 AM, Tony Jones wrote: > On 3/5/19 1:55 AM, Adrian Hunter wrote: > >> perf tools link against python2 so have the scripts been tested with python3? > > Not if PYTHON=python3 is specified on the build line. Yes, of course they > were tested. See below for

Re: [PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py

2019-03-05 Thread Tony Jones
On 3/5/19 2:16 AM, Adrian Hunter wrote: > On 2/03/19 3:19 AM, Tony Jones wrote: >> Support both Python2 and Python3 in the intel-pt-events.py script >> >> There may be differences in the ordering of output lines due to >> differences in dictionary ordering etc. Howe

Re: [PATCH v2 0/7] perf script python: add Python3 support

2019-03-05 Thread Tony Jones
On 3/5/19 1:55 AM, Adrian Hunter wrote: > perf tools link against python2 so have the scripts been tested with python3? Not if PYTHON=python3 is specified on the build line. Yes, of course they were tested.

[PATCH v2 6/7] perf script python: add Python3 support to sql scripts

2019-03-01 Thread Tony Jones
__future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/export-to-postgresql.py | 65 +++ tools/perf/scripts/python/export-to-sqlite.py | 23

[PATCH v2 5/7] perf script python: add Python3 support to intel-pt-events.py

2019-03-01 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/intel-pt-events.py | 30 +--- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools

[PATCH v2 4/7] perf script python: add Python3 support to event_analyzing_sample.py

2019-03-01 Thread Tony Jones
Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Feng Tang --- .../perf/scripts/python/event_analyzing_sample.py | 48 +++--- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/tools/perf/scripts/python/event_analyzing_sample.py

[PATCH v2 7/7] perf script python: add printdate function to SQL exporters

2019-03-01 Thread Tony Jones
Introduce a printdate function to eliminate the repetitive use of datetime.datetime.today() in the SQL exporting scripts. Signed-off-by: Tony Jones Cc: Adrian Hunter --- tools/perf/scripts/python/export-to-postgresql.py | 19 +++ tools/perf/scripts/python/export-to-sqlite.py

[PATCH v2 3/7] perf script python: add Python3 support to check-perf-trace.py

2019-03-01 Thread Tony Jones
of Python2 is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Tom Zanussi --- tools/perf/scripts/python/check-perf-trace.py | 31 +++ 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/tools/perf/scripts/python/check-perf-trace.py b

[PATCH v2 0/7] perf script python: add Python3 support

2019-03-01 Thread Tony Jones
This is v2 of my version of the patchset. Incorporating the previous feedback. Some changes from v1 were already merged. Patch 1/7 deals with the existing inconsistent indentation. Indentation is now consistent per file but varying styles (tabs, 4 spaces and 8 spaces). I will followup at a

[PATCH v2 2/7] perf script python: add Python3 support to futex-contention.py

2019-03-01 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/futex-contention.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/futex-contention.py b/tools/perf

[PATCH v2 1/7] perf script python: remove mixed indentation

2019-03-01 Thread Tony Jones
-by: Tony Jones --- tools/perf/scripts/python/check-perf-trace.py | 65 +++--- tools/perf/scripts/python/compaction-times.py | 8 +-- .../perf/scripts/python/event_analyzing_sample.py | 6 +- .../perf/scripts/python/failed-syscalls-by-pid.py | 38 ++--- tools/perf

[tip:perf/core] perf script python: Add Python3 support to syscall-counts-by-pid.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: de667cce7f4f96b6e22da8fd9c065b961f355080 Gitweb: https://git.kernel.org/tip/de667cce7f4f96b6e22da8fd9c065b961f355080 Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:18 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:17:13 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to syscall-counts.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: 1d1b0dbb859d175eb512a9f0e1ca7e44bd0192cd Gitweb: https://git.kernel.org/tip/1d1b0dbb859d175eb512a9f0e1ca7e44bd0192cd Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:17 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:17:10 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to stat-cpi.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: e985bf761db7646cebcd236249da08bd264069de Gitweb: https://git.kernel.org/tip/e985bf761db7646cebcd236249da08bd264069de Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:16 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:17:07 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to stackcollapse.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: 6d22d9991cf37edfe861569e2433342ad56206a7 Gitweb: https://git.kernel.org/tip/6d22d9991cf37edfe861569e2433342ad56206a7 Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:15 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:17:05 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to net_dropmonitor.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: 8c42b9600e561666233b9c557a5209d0dc853ba1 Gitweb: https://git.kernel.org/tip/8c42b9600e561666233b9c557a5209d0dc853ba1 Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:12 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:16:55 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to sctop.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: ee75a896ae535d4219a82cc361be96394536f3ba Gitweb: https://git.kernel.org/tip/ee75a896ae535d4219a82cc361be96394536f3ba Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:14 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:17:03 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to powerpc-hcalls.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: 118af5bf799bd1876c3999766d1d2f845d45f019 Gitweb: https://git.kernel.org/tip/118af5bf799bd1876c3999766d1d2f845d45f019 Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:13 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:16:57 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to mem-phys-addr.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: e4d053ddb4c48cbde27b4c5edd3cc8f957684e4f Gitweb: https://git.kernel.org/tip/e4d053ddb4c48cbde27b4c5edd3cc8f957684e4f Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:11 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:16:51 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to failed-syscalls-by-pid.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: 9b2700efc57f46fe63beee5f64fcfe2746936b4e Gitweb: https://git.kernel.org/tip/9b2700efc57f46fe63beee5f64fcfe2746936b4e Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:08 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:16:48 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to netdev-times.py

2019-02-28 Thread tip-bot for Tony Jones
Commit-ID: 02b03ec383e0c79d73aa4b402b3427a8b490ef9f Gitweb: https://git.kernel.org/tip/02b03ec383e0c79d73aa4b402b3427a8b490ef9f Author: Tony Jones AuthorDate: Fri, 22 Feb 2019 15:06:05 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 25 Feb 2019 17:16:42 -0300 perf script

[PATCH] tools lib traceevent: Fix buffer overflow in arg_eval

2019-02-27 Thread Tony Jones
checked in: See: https://www.spinics.net/lists/linux-perf-users/msg07714.html Cc: Arnaldo Carvalho de Melo Cc: linux-perf-us...@vger.kernel.org Cc: Steven Rostedt Signed-off-by: Tony Jones --- tools/lib/traceevent/event-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH 02/15] perf script python: add Python3 support to check-perf-trace.py

2019-02-25 Thread Tony Jones
On 2/25/19 6:05 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Feb 22, 2019 at 03:06:06PM -0800, Tony Jones escreveu: >> Support both Python 2 and Python 3 in the check-perf-trace.py script. >> >> There may be differences in the ordering of output lines due to >> differe

Re: [PATCH 15/15] perf script python: add Python3 support to sql scripts

2019-02-25 Thread Tony Jones
On 2/25/19 6:54 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 25, 2019 at 11:51:19AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Feb 22, 2019 at 03:06:19PM -0800, Tony Jones escreveu: >>> Support both Python2 and Python3 in the exported-sql-viewer.py, >>&

Re: [PATCH 06/15] perf script python: add Python3 support to intel-pt-events.py

2019-02-25 Thread Tony Jones
On 2/25/19 6:03 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Feb 25, 2019 at 09:07:03AM +0200, Adrian Hunter escreveu: >> On 23/02/19 1:06 AM, Tony Jones wrote: >>> Support both Python2 and Python3 in the intel-pt-events.py script >>> >>> There may be differe

Re: [PATCH 00/15] perf script python: add Python3 support

2019-02-23 Thread Tony Jones
On 2/22/19 3:06 PM, Tony Jones wrote: > The following patches add Python3 support to the remainder of > the scripts under scripts/python. I should possibly have labeled this V3. Seeteena had submitted prior patches but they had issues and since I already had (better tested) patches in Op

[PATCH 08/15] perf script python: add Python3 support to net_dropmonitor.py

2019-02-22 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Neil Horman --- tools/perf/scripts/python/net_dropmonitor.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/net_dropmonitor.py b/tools/perf/scripts/python

[PATCH 09/15] perf script python: add Python3 support to powerpc-hcalls.py

2019-02-22 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Ravi Bangoria --- tools/perf/scripts/python/powerpc-hcalls.py | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/perf/scripts/python/powerpc-hcalls.py b/tools/perf/scripts

[PATCH 14/15] perf script python: add Python3 support to syscall-counts-by-pid.py

2019-02-22 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek --- .../scripts/python/syscall-counts-by-pid.py | 22 ++- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tools/perf/scripts/python/syscall-counts-by-pid.py b/tools/perf/scripts

[PATCH 15/15] perf script python: add Python3 support to sql scripts

2019-02-22 Thread Tony Jones
__future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek --- .../scripts/python/export-to-postgresql.py| 31 ++ tools/perf/scripts/python/export-to-sqlite.py | 26 ++--- .../scripts/python/exported-sql

[PATCH 02/15] perf script python: add Python3 support to check-perf-trace.py

2019-02-22 Thread Tony Jones
by Python3. The use of from __future__ implies the minimum supported version of Python2 is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Tom Zanussi --- tools/perf/scripts/python/check-perf-trace.py | 68 ++- 1 file changed, 36 insertions(+), 32 deletions

[PATCH 10/15] perf script python: add Python3 support to sctop.py

2019-02-22 Thread Tony Jones
v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Tom Zanussi --- tools/perf/scripts/python/sctop.py | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/tools/perf/scripts/python/sctop.py b/tools/perf/scripts/python/sctop.py index

[PATCH 04/15] perf script python: add Python3 support to failed-syscalls-by-pid.py

2019-02-22 Thread Tony Jones
Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Tom Zanussi --- .../scripts/python/failed-syscalls-by-pid.py | 21 ++- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/tools/perf/scripts/python/failed-syscalls-by-pid.py b

[PATCH 11/15] perf script python: add Python3 support to stackcollapse.py

2019-02-22 Thread Tony Jones
is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Paolo Bonzini --- tools/perf/scripts/python/stackcollapse.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/perf/scripts/python/stackcollapse.py b/tools/perf/scripts/python

[PATCH 01/15] perf script python: add Python3 support to netdev-times.py

2019-02-22 Thread Tony Jones
is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Koki Sanagi --- tools/perf/scripts/python/netdev-times.py | 82 --- 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/tools/perf/scripts/python/netdev-times.py b/tools/perf/scripts

[PATCH 00/15] perf script python: add Python3 support

2019-02-22 Thread Tony Jones
The following patches add Python3 support to the remainder of the scripts under scripts/python. Minimum supported Python version is now v2.6 I tested everything against v2.7 (no patch), v2.7 (patch) and v3.7 (patch). Seeteena also tested a subset (no SQL, no IPT) against v2.6 There are

[PATCH 05/15] perf script python: add Python3 support to futex-contention.py

2019-02-22 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/futex-contention.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/futex-contention.py b/tools/perf

[PATCH 07/15] perf script python: add Python3 support to mem-phys-addr.py

2019-02-22 Thread Tony Jones
is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek --- tools/perf/scripts/python/mem-phys-addr.py | 24 +- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/tools/perf/scripts/python/mem-phys-addr.py b/tools/perf/scripts/python/mem-phys

[PATCH 06/15] perf script python: add Python3 support to intel-pt-events.py

2019-02-22 Thread Tony Jones
of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Adrian Hunter --- tools/perf/scripts/python/intel-pt-events.py | 138 ++- 1 file changed, 70 insertions(+), 68 deletions(-) diff --git

[PATCH 13/15] perf script python: add Python3 support to syscall-counts.py

2019-02-22 Thread Tony Jones
version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek --- tools/perf/scripts/python/syscall-counts.py | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/perf/scripts/python/syscall-counts.py b/tools/perf/scripts/python/syscall

[PATCH 03/15] perf script python: add Python3 support to event_analyzing_sample.py

2019-02-22 Thread Tony Jones
Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek --- .../scripts/python/event_analyzing_sample.py | 48 ++- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/tools/perf/scripts/python/event_analyzing_sample.py b/tools/perf/scripts

[PATCH 12/15] perf script python: add Python3 support to stat-cpi.py

2019-02-22 Thread Tony Jones
is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Jiri Olsa --- tools/perf/scripts/python/stat-cpi.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/stat-cpi.py b/tools/perf/scripts/python/stat-cpi.py index

[tip:perf/urgent] perf script python: Add Python3 support to tests/attr.py

2019-02-09 Thread tip-bot for Tony Jones
Commit-ID: 8f2f350cbdb2c2fbff654cb778139144b48a59ba Gitweb: https://git.kernel.org/tip/8f2f350cbdb2c2fbff654cb778139144b48a59ba Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:29 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 5 Feb 2019 10:31:08 -0300 perf script

[tip:perf/core] perf script python: Add Python3 support to tests/attr.py

2019-01-26 Thread tip-bot for Tony Jones
Commit-ID: 35ea7e4bbb89ecd32057f5f6a2a8feb0d7224e51 Gitweb: https://git.kernel.org/tip/35ea7e4bbb89ecd32057f5f6a2a8feb0d7224e51 Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:29 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 25 Jan 2019 15:12:10 +0100 perf script

[tip:perf/core] perf script python: Remove explicit shebang from Python scripts

2019-01-26 Thread tip-bot for Tony Jones
Commit-ID: a38352de4495a6a4662609a560b2db4b03d6b352 Gitweb: https://git.kernel.org/tip/a38352de4495a6a4662609a560b2db4b03d6b352 Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:28 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 25 Jan 2019 15:12:10 +0100 perf script

[tip:perf/core] perf script python: Remove explicit shebang from tests/attr.c

2019-01-26 Thread tip-bot for Tony Jones
Commit-ID: d72eadbc1d2866fc047edd4535ffb0298fe240be Gitweb: https://git.kernel.org/tip/d72eadbc1d2866fc047edd4535ffb0298fe240be Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:27 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 25 Jan 2019 15:12:10 +0100 perf script

[tip:perf/core] perf script python: Remove explicit shebang from setup.py

2019-01-26 Thread tip-bot for Tony Jones
Commit-ID: 099b79ca25c507ecbb25fb04f434e10415b68de0 Gitweb: https://git.kernel.org/tip/099b79ca25c507ecbb25fb04f434e10415b68de0 Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:26 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 25 Jan 2019 15:12:10 +0100 perf script

[tip:perf/core] perf script python: Use PyBytes for attr in trace-event-python

2019-01-26 Thread tip-bot for Tony Jones
Commit-ID: 72e0b15cb24a497d7d0d4707cf51ff40c185ae8c Gitweb: https://git.kernel.org/tip/72e0b15cb24a497d7d0d4707cf51ff40c185ae8c Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:25 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 25 Jan 2019 15:12:10 +0100 perf script

[tip:perf/core] perf script python: Add trace_context extension module to sys.modules

2019-01-26 Thread tip-bot for Tony Jones
Commit-ID: cc437642255224e4140fed1f3e3156fc8ad91903 Gitweb: https://git.kernel.org/tip/cc437642255224e4140fed1f3e3156fc8ad91903 Author: Tony Jones AuthorDate: Wed, 23 Jan 2019 16:52:24 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 25 Jan 2019 15:12:10 +0100 perf script

Re: [PATCH 0/6] Fix issues with Python3 scripting

2019-01-25 Thread Tony Jones
On 1/25/19 5:57 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 25, 2019 at 01:31:19PM +0100, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Jan 23, 2019 at 04:52:23PM -0800, Tony Jones escreveu: >>> Seeteena posted, earlier this week, some patches to add Python3 support >

[PATCH 4/6] perf script python: remove explicit shebang from tests/attr.c

2019-01-23 Thread Tony Jones
tests/attr.c invokes attr.py via an explicit invocation of Python ($PYTHON) so there is therefore no need for an explicit shebang. Also most distros follow pep-0394 which recommends that /usr/bin/python refer only to v2 and so may not exist on the system (if PYTHON=python3). Signed-off-By: Tony

[PATCH 6/6] perf script python: add Python3 support to tests/attr.py

2019-01-23 Thread Tony Jones
Support both Python 2 and Python 3 in tests/attr.py The use of "except as" syntax implies the minimum supported Python2 version is now v2.6 Signed-off-By: Tony Jones Cc: Jiri Olsa --- tools/perf/tests/attr.py | 32 +++- 1 file changed, 19 inserti

[PATCH 3/6] perf script python: remove explicit shebang from setup.py

2019-01-23 Thread Tony Jones
-By: Tony Jones Cc: Arnaldo Carvalho de Melo --- tools/perf/util/setup.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py index 64d1f36dee99..d3ffc18424b5 100644 --- a/tools/perf/util/setup.py +++ b/tools/perf/util/setup.py @@ -1,5 +1,3

[PATCH 5/6] perf script python: remove explicit shebang from Python scripts

2019-01-23 Thread Tony Jones
). - Remove the explicit shebang - Install the scripts as mode 644 Signed-off-by: Tony Jones Cc: Frederic Weisbecker Cc: Adrian Hunter Cc: Jiri Olsa --- tools/perf/Makefile.perf | 4 ++-- tools/perf/scripts/python/exported-sql-viewer.py | 1 - tools/perf/scripts/python/sched

[PATCH 1/6] perf script python: Add trace_context extension module to sys,modules

2019-01-23 Thread Tony Jones
erf-script.py Traceback (most recent call last): File "./perf-script.py", line 18, in from perf_trace_context import * ModuleNotFoundError: No module named 'perf_trace_context' Error running python script ./perf-script.py Signed-off-By: Tony Jones Cc: Jaroslav Šk

[PATCH 0/6] Fix issues with Python3 scripting

2019-01-23 Thread Tony Jones
ut didn't want to hold up Seeteena's resubmit. Tony Jones (6): perf script python: Add trace_context extension module to sys,modules perf script python: Use PyBytes for attr in trace-event-python perf script python: remove explicit shebang from setup.py perf script python: remove explicit she

[PATCH 2/6] perf script python: Use PyBytes for attr in trace-event-python

2019-01-23 Thread Tony Jones
erf script -g python | cat generated Python script: perf-script.py # perf script -s ./perf-script.py in trace_begin Segmentation fault (core dumped) Signed-off-By: Tony Jones Cc: Jaroslav Škarvada Fixes: 66dfdff03d196e51322c6a85c0d8db8bb2bdd655 --- tools/perf/util/scripting-engines/trace-ev

[tip:perf/urgent] perf script: Fix crash when processing recorded stat data

2019-01-22 Thread tip-bot for Tony Jones
Commit-ID: 8bf8c6da53c2265aea365a1de6038f118f522113 Gitweb: https://git.kernel.org/tip/8bf8c6da53c2265aea365a1de6038f118f522113 Author: Tony Jones AuthorDate: Sun, 20 Jan 2019 11:14:14 -0800 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 21 Jan 2019 11:29:07 -0300 perf script

Re: [PATCH] perf scripts python: Add Python 3 support to mem-phys-addr.py

2019-01-21 Thread Tony Jones
On 1/17/19 1:48 AM, seeteena wrote: > I have added >> You have not added "from __future__ import print_function", so you're >> relying on a Python 2 parsing oddity to make this work. I didn't see Jon's comment earlier. Sorry to have given conflicting advice. I'd not considered it a parsing

Re: [PATCH v3] perf scripts python: Add Python 3 support to export-to-sqlite.py

2019-01-21 Thread Tony Jones
On 1/21/19 2:39 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in export-to-sqlite.py. ``print`` is > now a function rather than a statement. This should have no functional > change. > > Also, handles the conversion of "print >> sys.stderr". > > Signed-off-by: Seeteena

Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-20 Thread Tony Jones
On 1/20/19 11:27 AM, Jonathan Corbet wrote: > On Fri, 18 Jan 2019 16:45:04 -0800 > Tony Jones wrote: > >> On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: >> >>> +if sys.version_info[0] < 3: >>> +import cPickle >>> +else: >>&g

[PATCH] perf script: fix crash when processing recorded stat data

2019-01-20 Thread Tony Jones
;perf stat: Update per-thread shadow stats") Signed-off-by: Tony Jones --- tools/perf/builtin-script.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index d079f36d342d..9a6dd86e606f 100644 --- a/tools/pe

Re: [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

2019-01-18 Thread Tony Jones
On 1/18/19 5:12 PM, Tony Jones wrote: > On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > >> +from __future__ import print_function > > You don't need this unless you're actually requiring functionality that only > exists in v3. > For example, you need it to han

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/18/19 4:29 PM, Tony Jones wrote: > I'd been simultaneously working on a patch set to fix up Python3. > > It's actually already in our Factory and SLE15-SP1 releases as we had a > deadline to kill Python2 usage for internal rpms. > > I was going to post once I'd fixed

Re: [PATCH v2] perf scripts python: Add Python 3 support to stackcollapse.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in stackcollapse.py. ``print`` is now a > function rather than a statement. This should have no functional change. > > Signed-off-by: Seeteena Thoufeek > Reviewed-by: Ravi Bangoria > --- >

Re: [PATCH v2] perf scripts python: Add Python 3 support to sctop.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +from __future__ import print_function Again, you don't need this. > - print "\nsyscall events for %s:\n\n" % (for_comm), > + print("\nsyscall events for %s:\n\n" % (for_comm)), same comments regarding

Re: [PATCH v2] perf scripts python: Add Python 3 support to netdev-times.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:> Support both Python 2 and Python 3 in netdev-times.py. ``print`` > is now a function rather than a statement. This should have no > functional change. Same feedback as all the other patches applies. In addition: $ git annotate

Re: [PATCH v2] perf scripts python: Add Python 3 support to intel-pt-events.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in intel-pt-events.py.``print`` > is now a function rather than a statement. This should have no > functional change. > > Fixes indentation issue, replace spaces with tab. Again, trailing comma use is incorrect.

Re: [PATCH v2] perf scripts python: Add Python 3 support to failed-syscalls-by-pid.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +from __future__ import print_function You don't need this unless you're actually requiring functionality that only exists in v3. For example, you need it to handle the suppress newline functionality such as "end=". > def print_error_totals(): >

Re: [PATCH v2] perf scripts python: Add Python 3 support to export-to-sqlite.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in export-to-sqlite.py. ``print`` is > now a function rather than a statement. This should have no functional > change. I don't see any changes handling the following: $ git annotate

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > - print "vec=%s\n" % \ > - (symbol_str("irq__softirq_entry", "vec", vec)), > + print("vec=%s\n" % \ > + (symbol_str("irq__softirq_entry", "vec", vec))), Again, check the trailing comma usage: $ echo

Re: [PATCH v2] perf scripts python: Add Python 3 support to syscall-counts-by-pid.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > - print "\nsyscall events for %s:\n\n" % (for_comm), > + print("\nsyscall events for %s:\n\n" % (for_comm)), > else: > - print "\nsyscall events by comm/pid:\n\n", > + print("\nsyscall events by comm/pid:\n\n"), >

Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +if sys.version_info[0] < 3: > +import cPickle > +else: > +import _pickle as cPickle Do you really need this? pickle is already in Python2. Also, did you test these changes on Python3? I think you'll find you also need the following

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
mes to write data ] [ perf record: Captured and wrote 187.177 MB perf.data (1581501 samples) ] # perf script -g python | cat generated Python script: perf-script.py # perf script -s ./perf-script.py Traceback (most recent call last): File "./perf-script.py", line 18, in from perf_tra

Re: [PATCH] apparmor: Fix network performance issue in aa_label_sk_perm

2018-09-07 Thread Tony Jones
On 09/07/2018 09:37 AM, John Johansen wrote: > hey Tony, > > thanks for the patch, I am curious did you're investigation look > into what parts of DEFINE_AUDIT_SK are causing the issue? Hi JJ. Attached are the perf annotations for DEFINE_AUDIT_SK (percentages are relative to the fn). Our

Re: [PATCH] apparmor: Fix network performance issue in aa_label_sk_perm

2018-09-07 Thread Tony Jones
On 09/07/2018 09:37 AM, John Johansen wrote: > hey Tony, > > thanks for the patch, I am curious did you're investigation look > into what parts of DEFINE_AUDIT_SK are causing the issue? Hi JJ. Attached are the perf annotations for DEFINE_AUDIT_SK (percentages are relative to the fn). Our

[PATCH] apparmor: Fix network performance issue in aa_label_sk_perm

2018-09-06 Thread Tony Jones
%) Stddev4096 100.25 ( 0.00%) 88.50 ( 11.72%) Stddev8192 358.13 ( 0.00%) 169.99 ( 52.54%) Stddev16384 43.99 ( 0.00%) 141.82 (-222.39%) Signed-off-by: Tony Jones Fixes: 56974a6fcfef ("apparmor: add base infastructure for socket medi

  1   2   3   >