Re: [REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-03-12 Thread Mauro Carvalho Chehab
Em Mon, 17 Feb 2014 10:57:29 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Add core support for matrices. Again, this patch has negative values for array index. I'll stop analyzing here, as it is hard to keep the mind in a sane state seeing those

Re: [REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-03-12 Thread Hans Verkuil
On 03/12/14 11:42, Mauro Carvalho Chehab wrote: Em Mon, 17 Feb 2014 10:57:29 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Add core support for matrices. Again, this patch has negative values for array index. I'll stop analyzing here, as it

Re: [REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-03-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Mar 2014 13:21:41 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On 03/12/14 11:42, Mauro Carvalho Chehab wrote: Em Mon, 17 Feb 2014 10:57:29 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Add core support for matrices.

Re: [REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-03-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Mar 2014 13:21:41 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On 03/12/14 11:42, Mauro Carvalho Chehab wrote: Em Mon, 17 Feb 2014 10:57:29 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil hans.verk...@cisco.com Add core support for matrices.

Re: [REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-03-12 Thread Hans Verkuil
On 03/12/2014 02:00 PM, Mauro Carvalho Chehab wrote: Em Wed, 12 Mar 2014 13:21:41 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: On 03/12/14 11:42, Mauro Carvalho Chehab wrote: Em Mon, 17 Feb 2014 10:57:29 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: From: Hans Verkuil

Re: [REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-03-12 Thread Sylwester Nawrocki
Hi Mauro, On 12/03/14 14:00, Mauro Carvalho Chehab wrote: [...] As I commented before: those complex API changes should ideally be discussed during our mini-summits, as it allows us to better understand the hole proposal and the taken approach. We discussed this in a dedicated brainstorming

[REVIEWv3 PATCH 14/35] v4l2-ctrls: prepare for matrix support.

2014-02-17 Thread Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com Add core support for matrices. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/v4l2-ctrls.c | 54 +++- include/media/v4l2-ctrls.h | 8 -- 2 files changed, 39 insertions(+), 23