[PATCH 17/20] ARM: OMAP3+: SmartReflex: misc cleanups

-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 103 +--- 1 files changed, 71 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index

[PATCH 18/20] ARM: OMAP3+: SmartReflex: micro-optimization for sanity check

From: Felipe Balbi ba...@ti.com val (val != 1) == val 1 Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch

[PATCH 19/20] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API

The debugfs_create_* API returns a return code or NULL in the return ptr in case of problem. Fix the smartreflex code to take this into account. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 20/20] ARM: OMAP3+: SmartReflex: fix error handling

Fix the code to correctly use IS_ERR and PTR_ERR on the return values pointers Reported-by: Sergei Shtylyov sshtyl...@ru.mvista.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [PATCH v2 00/19] ARM: OMAP3+: SmartReflex: bugfixes

On Wed, Feb 1, 2012 at 12:58 AM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@ti.com [120131 13:28]: ... OK, let's plan on putting all the smartreflex stuff into a separate branch then. If some changes are needed to the PM code, those should probably be applied first into

Re: [RFC 1/1] omap3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE

Hi Kevin, Paul, On Fri, Jan 27, 2012 at 3:03 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Jean, Thanks for you quick reply. On Fri, Jan 27, 2012 at 12:06:37PM +0100, Jean Pihet wrote: Hi, On Fri, Jan 27, 2012 at 11:00 AM, Sakari Ailus sakari.ai...@iki.fi wrote: MPU and CORE should

[PATCH v2 00/19] ARM: OMAP3+: SmartReflex: bugfixes

+: SmartReflex: micro-optimization for sanity check Jean Pihet (1): ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API Julia Lawall (1): ARM: OMAP3+: SmartReflex: add missing error-handling code Nishanth Menon (12): ARM: OMAP3+: SmartReflex: fix err interrupt disable sequence ARM

[PATCH 01/19] ARM: OMAP3+: SmartReflex: Layer Cleanup [V4]

by: Nishanth Menon n...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 17 + arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 19 --- arch/arm/mach-omap2

[PATCH 02/19] ARM: OMAP3+: SmartReflex: add missing error-handling code

...; } ) // /smpl Signed-off-by: Julia Lawall ju...@diku.dk Acked-by: Kevin Hilman khil...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach

[PATCH 03/19] ARM: OMAP3+: SmartReflex: fix err interrupt disable sequence

From: Nishanth Menon n...@ti.com sr_modify_mask takes mask, value as parameters, the usage currently is value, mask which is wrong, as a result vpboundint_st which was supposed to have been disabled, does not get disabled. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi

[PATCH 04/19] ARM: OMAP3+: SmartReflex Class3: disable errorgen before disable VP

...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex-class3.c |1 + arch/arm/mach-omap2/smartreflex.c| 44 ++ arch/arm/mach-omap2/smartreflex.h|1 + 3 files changed, 46 insertions(+), 0 deletions(-) diff --git

[PATCH 05/19] ARM: OMAP3+: SmartReflex: Add a shutdown hook

in an indeterminate sequence when reboot is triggered, leaving the next reboot behavior to be unpredictable. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 24 1 files changed, 24 insertions(+), 0

[PATCH 06/19] ARM: OMAP3+: SmartReflex: Fix status masking in ERRCONFIG register

-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 21 - 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index f384c19..ba6ad09 100644 --- a/arch/arm/mach-omap2/smartreflex.c

[PATCH 07/19] ARM: OMAP3+: SmartReflex: clear ERRCONFIG_VPBOUNDINTST only on a need

is invoked. To prevent this situation, check if status is set before clearing the status as this needs to be done only on a need basis. Reported-by: Vincent Bour v-b...@ti.com Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c

[PATCH 08/19] ARM: OMAP3+: hwmod: add SmartReflex IRQs

-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c index a201ff5..b224ea2 100644 --- a/arch/arm/mach

[PATCH 09/19] ARM: OMAP3+: SmartReflex: introduce class init, deinit and priv data

by the SmartReflex core driver to enable disable the class operation. When autocomp is set to 0 - class drivers' deinit is called, signaling the end of usage for that domain. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 15

[PATCH 10/19] ARM: OMAP3+: SmartReflex: introduce notifiers flags

a match with the notifier flags that the class driver requested. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 78 - arch/arm/mach-omap2/smartreflex.h |6 +++ 2 files changed, 82

[PATCH 13/19] ARM: OMAP3+: SmartReflex: introduce class private data per voltage domain

on silicon. It also makes the life of such class drivers to be faster without having to do a double lookup to get to their voltage domain specific private data Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex-class3.c | 10

[PATCH 15/19] ARM: OMAP3+: SmartReflex: add missing platform_set_drvdata()

From: Felipe Balbi ba...@ti.com That's very useful to fetch the correct struct sr_info from the PM handlers. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH 14/19] ARM: OMAP3+: SmartReflex Class3: restrict CPU to run on

From: Nishanth Menon n...@ti.com Use SmartReflex AVS Class3 initialization only for OMAP343x family of processors. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex-class3.c |5 + 1 files changed, 5 insertions(+), 0

[PATCH 17/19] ARM: OMAP3+: SmartReflex: misc cleanups

-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 103 +--- 1 files changed, 71 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index

[PATCH 16/19] ARM: OMAP3+: SmartReflex: move late_initcall() closer to its argument

From: Felipe Balbi ba...@ti.com no functional changes, trivial patch. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 19/19] ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API

The debugfs_create_* API returns a NULL ptr in case of problem. Fix the smartreflex code to take this into account. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 18/19] ARM: OMAP3+: SmartReflex: micro-optimization for sanity check

From: Felipe Balbi ba...@ti.com val (val != 1) == val 1 Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch

[PATCH 11/19] ARM: OMAP3+: SmartReflex: introduce notifier_control

drivers. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 65 + arch/arm/mach-omap2/smartreflex.h |8 2 files changed, 73 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach

[PATCH 12/19] ARM: OMAP3+: SmartReflex: disable spamming interrupts

. Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index a24a228

Re: [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP

Sergei, On Thu, Jan 26, 2012 at 12:26 PM, Sergei Shtylyov sshtyl...@ru.mvista.com wrote: Hello. On 25-01-2012 19:16, Jean Pihet wrote: ... Change-Id: Id0145adacfa63d7652a29859ad6c95cc2ac61cc8   Please remove this line. Done! ... +int sr_disable_errgen(struct voltagedomain *voltdm

[PATCH] ARM: OMAP3+: PM debug: fix the use of debugfs_create_* API

The debugfs_create_* API returns a NULL ptr in case of problem. Fix the PM debug code to take this into account. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/pm-debug.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/pm-debug.c

Re: [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP

Sergei, On Tue, Jan 31, 2012 at 12:37 PM, Sergei Shtylyov sshtyl...@ru.mvista.com wrote: Hello. On 31-01-2012 14:06, Jean Pihet wrote: ... +int sr_disable_errgen(struct voltagedomain *voltdm) +{ +       u32 errconfig_offs, vpboundint_en; +       u32 vpboundint_st; +       struct

Re: [PATCH v2 00/19] ARM: OMAP3+: SmartReflex: bugfixes

On Tue, Jan 31, 2012 at 6:20 PM, Tony Lindgren t...@atomide.com wrote: * Pihet-XID, Jean j-pi...@ti.com [120131 08:44]: Hi Tony, On Tue, Jan 31, 2012 at 6:08 PM, Tony Lindgren t...@atomide.com wrote: * Jean Pihet jean.pi...@newoldbits.com [120131 01:28]: Integrate the latest SmartReflex

Re: [RFC 1/1] omap3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE

Hi, On Fri, Jan 27, 2012 at 11:00 AM, Sakari Ailus sakari.ai...@iki.fi wrote: MPU and CORE should stay awake if there is CAM domain ACTIVE. This is because that module doesn't have wake-up capability. The original patch was written by Jouni Högander in 2008 and this is the last part left of

Re: [PATCH 17/21] OMAP3430: SR: class3: restrict CPU to run on

Sergei, On Thu, Jan 26, 2012 at 12:33 PM, Sergei Shtylyov sshtyl...@ru.mvista.com wrote: Hello. On 25-01-2012 19:16, Jean Pihet wrote: From: Nishanth Menonn...@ti.com Use SmartReflex AVS Class3 initialization only for OMAP343x family of processors. Change-Id

[PATCH 00/21] OMAP3+: SR: bugfixes

Integrate the latest SmartReflex bufixes from Felipe Balbi [1] and Nishant Menon [2]. Based on latest master branch of the mainline git tree (3.3.0-rc1) [3], commit f8275f9694b8adf9f3498e747ea4c3e8b984499b. [1] http://marc.info/?l=linux-omapm=132134699423547w=2 [2]

[PATCH 01/21] OMAP3+: SR Layer Cleanup [V4]

by: Nishanth Menon n...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 17 + arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 19 --- arch/arm/mach-omap2

[PATCH 02/21] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code

...; } ) // /smpl Signed-off-by: Julia Lawall ju...@diku.dk Acked-by: Kevin Hilman khil...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach

[PATCH 03/21] OMAP3+: PM: SR: add suspend/resume handlers

-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 87 + 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 7e755bb..fca8df69 100644 --- a/arch/arm/mach

[PATCH 04/21] ARM: omap2+: smartreflex: move smartreflex suspend to suspend_noirq

and omap_sr_disable. Change-Id: Ia3c1e707bb1022ec102f506dc3ad48906e8890da Signed-off-by: Colin Cross ccr...@android.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b

[PATCH 05/21] Revert OMAP3+: PM: SR: add suspend/resume handlers

: I236b0e8259cfb371899dd0c93875739a21358e33 Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 90 - 1 files changed, 0 insertions(+), 90 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach

[PATCH 06/21] OMAP3+: Smartreflex: fix err interrupt disable sequence

-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 7e755bb..ee224df 100644 --- a/arch/arm/mach

[PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP

: Id0145adacfa63d7652a29859ad6c95cc2ac61cc8 Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex-class3.c |1 + arch/arm/mach-omap2/smartreflex.c| 44 ++ arch/arm/mach-omap2/smartreflex.h|1 + 3 files

[PATCH 08/21] OMAP3+: Smartreflex: Add a shutdown hook

in an indeterminate sequence when reboot is triggered, leaving the next reboot behavior to be unpredictable. Change-Id: I7f8c66cc45f8785394cce1fdde3cfda15ecc1fbc Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 24

[PATCH 09/21] OMAP3+: Smartreflex: Fix status masking in ERRCONFIG register

-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 21 - 1 files changed, 8 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index f384c19

[PATCH 10/21] OMAP3+: Smartreflex: clear ERRCONFIG_VPBOUNDINTST only on a need

as this needs to be done only on a need basis. Change-Id: Ic8065d7d79df143bf46877c50f5b6b19ed105a70 Reported-by: Vincent Bour v-b...@ti.com Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 22 -- 1 files

[PATCH 11/21] OMAP3: hwmod: add SmartReflex IRQs

-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c

[PATCH 15/21] OMAP3+: SR: disable spamming interrupts

. Change-Id: I2eeb25ef18e4465f41b2462d13bfd60e1b1e8d7c Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 21 +++-- 1 files changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 16/21] OMAP3+: SR: introduce class private data per voltage domain

on silicon. It also makes the life of such class drivers to be faster without having to do a double lookup to get to their voltage domain specific private data Change-Id: Icfcd7b229e56cfc1179d2aad1dbf09bb503e292a Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com

[PATCH 14/21] OMAP3+: SR: introduce notifier_control

drivers. Change-Id: Id5187a7631d4743c928ad20da31919e6fd71ce2e Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 65 + arch/arm/mach-omap2/smartreflex.h |8 2 files changed, 73

[PATCH 17/21] OMAP3430: SR: class3: restrict CPU to run on

From: Nishanth Menon n...@ti.com Use SmartReflex AVS Class3 initialization only for OMAP343x family of processors. Change-Id: I660326bf265541ba4e0feb52853ff6cb9b293aed Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex-class3.c

[PATCH 20/21] arm: omap: smartreflex: clean ups all over

-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 103 +--- 1 files changed, 71 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index

[PATCH 18/21] arm: omap: smartreflex: add missing platform_set_drvdata()

From: Felipe Balbi ba...@ti.com that's very useful to fetch the correct struct sr_info from PM handlers. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH 19/21] arm: omap: smartreflex: move late_initcall() closer to its argument

From: Felipe Balbi ba...@ti.com no functional changes, trivial patch. Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 21/21] arm: omap: smartreflex: micro-optimization for sanity check

From: Felipe Balbi ba...@ti.com val (val != 1) == val 1 Signed-off-by: Felipe Balbi ba...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch

[PATCH 13/21] OMAP3+: SR: introduce notifiers flags

a match with the notifier flags that the class driver requested. Change-Id: I431e1047b11ca93528fa669b34e5059368471bf6 Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 78 - arch/arm

[PATCH 12/21] OMAP3+: SR: introduce class init,deinit and priv data

by the SmartReflex core driver to enable disable the class operation. When autocomp is set to 0 - class drivers' deinit is called, signaling the end of usage for that domain. Change-Id: Ie6a4b163d52af4931a4506ed7a3a6b752173a674 Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Jean Pihet j-pi...@ti.com

Re: [PATCH 05/21] Revert OMAP3+: PM: SR: add suspend/resume handlers

Hi Benoit, On Wed, Jan 25, 2012 at 6:53 PM, Cousson, Benoit b-cous...@ti.com wrote: Salut Jean, On 1/25/2012 4:16 PM, Jean Pihet wrote: From: Nishanth Menonn...@ti.com This reverts commit b6be18f0bab68ed304ebbb2d787d1c36237eda62. That weird, because you revert a patch you introduced

Re: [PATCH 05/21] Revert OMAP3+: PM: SR: add suspend/resume handlers

Hi Nishant, On Wed, Jan 25, 2012 at 10:29 PM, Menon, Nishanth n...@ti.com wrote: On Wed, Jan 25, 2012 at 12:49, Kevin Hilman khil...@ti.com wrote: Cousson, Benoit b-cous...@ti.com writes: On 1/25/2012 7:13 PM, Jean Pihet wrote: [...] I guess that path #3 and #5 should just be removed. I

Re: PM(?) problems on v3.3-rc1 on OMAP3

Govindraj, On Fri, Jan 20, 2012 at 12:21 PM, Govindraj govindraj...@gmail.com wrote: On Fri, Jan 20, 2012 at 4:37 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 16:19 +0530, Govindraj wrote: On Fri, Jan 20, 2012 at 4:03 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote:

Re: PM(?) problems on v3.3-rc1 on OMAP3

Tomi, On Fri, Jan 20, 2012 at 1:01 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 17:26 +0530, Govindraj wrote: On Fri, Jan 20, 2012 at 4:03 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Is there a way to lock the OPP to the full power OPP? btw, I think

Re: PM(?) problems on v3.3-rc1 on OMAP3

Tomi, On Fri, Jan 20, 2012 at 1:40 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 13:34 +0100, Jean Pihet wrote: Tomi, On Fri, Jan 20, 2012 at 1:01 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 17:26 +0530, Govindraj wrote: On Fri, Jan 20

Re: [PATCH v6 0/6] PM QoS: implement the OMAP low level constraints management code

Paul, Kevin, On Mon, Dec 19, 2011 at 10:02 PM, Paul Walmsley p...@pwsan.com wrote: Hi Jean I'm really sorry it's taken me so long to do detailed review of these patches for merging... anyway - On Wed, 14 Dec 2011, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com

Re: [PATCH v6 0/6] PM QoS: implement the OMAP low level constraints management code

Hi Paul, On Mon, Jan 16, 2012 at 9:04 PM, Paul Walmsley p...@pwsan.com wrote: Hi On Mon, 16 Jan 2012, Jean Pihet wrote: Speaking of the locking, currently a spinlock is used and it could be replaced by a more efficient mutex. This is ok at the condition that this code is not called from

Re: [PATCH 25/26] OMAP: PM: convert the SmartReflex code into the AVS driver framework

Kevin, Todd, On Thu, Jan 12, 2012 at 1:55 AM, Kevin Hilman khil...@ti.com wrote: Todd Poynor toddpoy...@google.com writes: +static irqreturn_t _interrupt(int irq, void *data) +{ +    struct smartreflex *sr = (struct smartreflex *)data; +    u32 status = 0; + +    /* Read the status bits

Re: [PATCH 25/26] OMAP: PM: convert the SmartReflex code into the AVS driver framework

Kevin, On Thu, Jan 12, 2012 at 1:52 AM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: if you already decide in runtime the correct initialization to call, why do you add ifdefs ? There is no #ifdef with CONFIG_POWER_AVS_OMAP_V[12], those options are used

Re: [RFC/PATCH 00/26] PM: Create the AVS class of drivers

Hi Kevin, On Thu, Jan 12, 2012 at 2:04 AM, Kevin Hilman khil...@ti.com wrote: Hi Jean, jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com The following patches are in RFC state; the code is still WIP and has been compile tested only. Feedback on the code organization

Re: [RFC/PATCH 3/7] ARM: OMAP3: clock data: treat all AM35x devices the same

Hi Kevin, On Thu, Jan 5, 2012 at 2:16 AM, Kevin Hilman khil...@ti.com wrote: The init for 3505/3517 specific clocks depends on the ordering of cpu_is checks, is error prone and confusing (there are 2 separate checks for cpu_is_omap3505()). Remove the 3505-specific checking since CK_3505 flag

Re: [linux-pm] [PATCH 1/3] cpuidle: refactor out cpuidle_enter_state

Hi Colin, On Wed, Dec 21, 2011 at 1:09 AM, Colin Cross ccr...@android.com wrote: Split the code to enter a state and update the stats into a helper function, cpuidle_enter_state, and export it.  This function will be called by the coupled state code to handle entering the safe state and the

Re: [PATCH 1/4] cpupower: Add cpupower-idle-info manpage

Hi Thomas, On Fri, Dec 16, 2011 at 3:35 PM, Thomas Renninger tr...@suse.de wrote: The last missing manpage for cpupower tools. Great! More info about other architecture's sleep state specialities would be great. I wonder if it is the right place for some arch specific information about the

[PATCH v6 0/6] PM QoS: implement the OMAP low level constraints management code

From: Jean Pihet j-pi...@ti.com . Implement the devices wake-up latency constraints using the global device PM QoS notification handler which applies the constraints to the underlying layer . Implement the low level code which controls the power domains next power states, through the hwmod

[PATCH 1/6] OMAP2+: powerdomain: control power domains next state

From: Jean Pihet j-pi...@ti.com When a PM QoS device latency constraint is requested or removed the PM QoS layer notifies the underlying layer with the updated aggregated constraint value. The constraint is stored in the powerdomain constraints list and then applied to the corresponding power

[PATCH 2/6] OMAP2+: omap_hwmod: manage the wake-up latency constraints

From: Jean Pihet j-pi...@ti.com The OMAP PM code implements a handler for the per-device PM QoS framework. The handler queries the omap_hwmod layer in order to manage the power domains wake-up latency constraints. Hwmod retrieves the correct power domain and if it exists it calls

[PATCH 3/6] OMAP: PM: register to the per-device PM QoS framework

From: Jean Pihet j-pi...@ti.com Implement the devices wake-up latency constraints using the global device PM QoS notification handler which applies the constraints to the underlying layer by calling the corresponding function at hwmod level. Tested on OMAP3 Beagleboard and OMAP4 Pandaboard

[PATCH 4/6] OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints

From: Jean Pihet j-pi...@ti.com The MPU latency figures for cpuidle include the MPU itself and also the peripherals needed for the MPU to execute instructions (e.g. main memory, caches, IRQ controller, MMU etc). On OMAP3 those peripherals belong to the MPU and CORE power domains and so

[PATCH 5/6] OMAP3: update cpuidle latency and threshold figures

From: Jean Pihet j-pi...@ti.com Update the data from the measurements performed at HW and SW levels. Cf. http://www.omappedia.org/wiki/Power_Management_Device_Latencies_Measurement for a detailed explanation on where are the numbers coming from. ToDo: - Measure the wake-up latencies for all

[PATCH 6/6] OMAP3: powerdomain data: add wake-up latency figures

From: Jean Pihet j-pi...@ti.com Figures are added to the power domains structs for RET and OFF modes. Note: the latency figures for MPU, PER, CORE, NEON have been obtained from actual measurements. The latency figures for the other power domains are preliminary and shall be added. Cf. http

Re: [PATCH v5 0/6] PM QoS: implement the OMAP low level constraints management code

Hi Kevin, On Wed, Dec 14, 2011 at 12:53 AM, Kevin Hilman khil...@ti.com wrote: Hi Jean, jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com . Implement the devices wake-up latency constraints using the global   device PM QoS notification handler which applies the constraints

Re: [PATCH 0/2] OMAP: PM: switch from omap_pm_ functions to PM QoS

Hi Paul, Kevin, This patch series is depending on the latest constraints stuff for OMAP [1], which has been reviewed by Kevin. [1] http://marc.info/?l=linux-omapm=132387443205028w=2 Regards, Jean On Mon, Dec 12, 2011 at 5:27 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Kevin, Paul

[PATCH v5 0/6] PM QoS: implement the OMAP low level constraints management code

From: Jean Pihet j-pi...@ti.com . Implement the devices wake-up latency constraints using the global device PM QoS notification handler which applies the constraints to the underlying layer . Implement the low level code which controls the power domains next power states, through the hwmod

[PATCH 1/6] OMAP2+: powerdomain: control power domains next state

From: Jean Pihet j-pi...@ti.com When a PM QoS device latency constraint is requested or removed the PM QoS layer notifies the underlying layer with the updated aggregated constraint value. The constraint is stored in the powerdomain constraints list and then applied to the corresponding power

[PATCH 2/6] OMAP2+: omap_hwmod: manage the wake-up latency constraints

From: Jean Pihet j-pi...@ti.com Hwmod is queried from the OMAP_PM layer to manage the power domains wake-up latency constraints. Hwmod retrieves the correct power domain and if it exists it calls the corresponding power domain function. Tested on OMAP3 Beagleboard and OMAP4 Pandaboard in RET/OFF

[PATCH 3/6] OMAP: PM: register to the per-device PM QoS framework

From: Jean Pihet j-pi...@ti.com Implement the devices wake-up latency constraints using the global device PM QoS notification handler which applies the constraints to the underlying layer by calling the corresponding function at hwmod level. Tested on OMAP3 Beagleboard and OMAP4 Pandaboard

[PATCH 4/6] OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints

From: Jean Pihet j-pi...@ti.com The MPU latency figures for cpuidle include the MPU itself and also the peripherals needed for the MPU to execute instructions (e.g. main memory, caches, IRQ controller, MMU etc). On OMAP3 those peripherals belong to the MPU and CORE power domains and so

[PATCH 5/6] OMAP3: update cpuidle latency and threshold figures

From: Jean Pihet j-pi...@ti.com Update the data from the measurements performed at HW and SW levels. Cf. http://www.omappedia.org/wiki/Power_Management_Device_Latencies_Measurement for a detailed explanation on where are the numbers coming from. ToDo: - Measure the wake-up latencies for all

[PATCH 6/6] OMAP3: powerdomain data: add wake-up latency figures

From: Jean Pihet j-pi...@ti.com Figures are added to the power domains structs for RET and OFF modes. Note: the latency figures for MPU, PER, CORE, NEON have been obtained from actual measurements. The latency figures for the other power domains are preliminary and shall be added. Cf. http

Re: [linux-pm] [PATCH 4/6] OMAP3: cpuidle: next C-state decision depends on the PM QoS MPU and CORE constraints

Hi Kevin, On Wed, Nov 23, 2011 at 8:43 PM, Kevin Hilman khil...@ti.com wrote: Jean Pihet jean.pi...@newoldbits.com writes: On Thu, Nov 17, 2011 at 10:29 PM, Kevin Hilman khil...@ti.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com The MPU latency figures

Re: [PATCH 0/2] OMAP: PM: switch from omap_pm_ functions to PM QoS

Hi Kevin, Paul, ping on this series Thanks, Jean On Wed, Oct 19, 2011 at 4:28 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com . Convert the OMAP I2C driver to the PM QoS API for MPU latency constraints . Remove the latency related functions from OMAP PM in favor

[PATCH] OMAP2+: hwmod: remove unused voltagedomain pointer from kerneldoc

From: Jean Pihet j-pi...@ti.com Commit fa17f20f (OMAP2+: hwmod: remove unused voltagedomain pointer) did remove the voltdm field from the struct omap_hwmod. Remove it from the kerneldoc as well. Signed-off-by: Jean Pihet j-pi...@ti.com Acked-by: Kevin Hilman khil...@ti.com --- arch/arm/plat

Re: [PATCH] OMAP2+: hwmod: remove unused voltagedomain pointer from kerneldoc

On Fri, Dec 9, 2011 at 11:26 PM, Kevin Hilman khil...@ti.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Commit fa17f20f (OMAP2+: hwmod: remove unused voltagedomain pointer) did remove the voltdm field from the struct omap_hwmod. Remove it from the kerneldoc

[PATCH] OMAP2+: hwmod: remove unused voltagedomain pointer from kerneldoc

From: Jean Pihet j-pi...@ti.com Commit fa17f20f (OMAP2+: hwmod: remove unused voltagedomain pointer) did remove the voltdm field from the struct omap_hwmod. Remove it from the kerneldoc as well. Signed-off-by: Jean Pihet j-pi...@ti.com Cc: Kevin Hilman khil...@ti.com --- arch/arm/plat-omap

Re: [PATCHv4 11/15] omap3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking

Hi Tero, On Fri, Nov 25, 2011 at 4:49 PM, Tero Kristo t-kri...@ti.com wrote: This patch fixes the usecount tracking for omap3+, previously the usecount numbers were rather bogus and were not really useful for any purpose. Now usecount numbers track the number of really active clients on each

Re: [PATCHv4 00/15] voltdm cleanup + auto-ret / auto-off support

Hi Tero, On Fri, Nov 25, 2011 at 4:49 PM, Tero Kristo t-kri...@ti.com wrote: Hi, Changes compared to previous version: - merged most of the voltagedomain cleanup fixes to patch 2 - moved pmic latencies to omap_voltdm_pmic struct - renamed omap_lp_params to omap2_oscillator as it only

Re: [PATCHv4 02/15] omap3+: voltage: parameter segregation

Tero, On Fri, Nov 25, 2011 at 4:49 PM, Tero Kristo t-kri...@ti.com wrote: -static void __init omap3_vfsm_init(struct voltagedomain *voltdm) +static void omap3_set_i2c_timings(struct voltagedomain *voltdm, int off_mode)  { +       unsigned long voltsetup1; +       u32 tgt_volt; + +       if

Re: [PATCH 25/26] OMAP: PM: convert the SmartReflex code into the AVS driver framework

Hi Felipe, On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote: +config POWER_AVS_OMAP_V1 +     tristate AVS support for the OMAP IP version 1 +     depends on ARCH_OMAP3 PM +     help +       Say Y to

Re: [PATCH 25/26] OMAP: PM: convert the SmartReflex code into the AVS driver framework

Felipe, On Wed, Nov 23, 2011 at 12:04 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 23, 2011 at 11:22:42AM +0100, Jean Pihet wrote: Hi Felipe, On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote

[RFC/PATCH 00/26] PM: Create the AVS class of drivers

From: Jean Pihet j-pi...@ti.com The following patches are in RFC state; the code is still WIP and has been compile tested only. Feedback on the code organization is welcome! AVS is a power management technique which controls the operating voltage of a device in order to optimize (i.e. reduce

[PATCH 01/26] OMAP2+: smartreflex: use sane default values

From: Paul Walmsley p...@pwsan.com Use sane values for the smartreflex data from the e-fuses. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/sr_device.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git

[PATCH 03/26] OMAP3/4: SmartReflex: API should use struct omap_sr *, not struct voltagedomain *

From: Jean Pihet j-pi...@ti.com The SmartReflex API should take pointers to a SmartReflex instance-specific structure record, not pointers to a OMAP subarchitecture-specific struct voltagedomain *. The SmartReflex drivers should not be tightly coupled to the SoC subarchitecture; these IP blocks

[PATCH 02/26] OMAP3/4: SmartReflex: class drivers should use struct omap_sr *

From: Jean Pihet j-pi...@ti.com Convert SmartReflex class functions to take a struct omap_sr *, rather than a struct voltagedomain *. SmartReflex code should be driver code and not tightly coupled to OMAP subarchitecture-specific structures. Based on Paul's original code for the SmartReflex

[PATCH 04/26] OMAP: SmartReflex: drop _sr_lookup()

From: Jean Pihet j-pi...@ti.com Drop the _sr_lookup() function that returns a struct omap_sr from a struct voltagedomain. Instead, retain a pointer to the struct omap_sr * in the driver platform data. This removes another struct voltagedomain * dependency in the SmartReflex driver code. Based

[PATCH 05/26] OMAP: hwmod/SmartReflex: remove IP block instance-specific data from the driver code

until the clkdev entries for SmartReflex can be removed. ToDo: . this patch needs to be reviewed to determine the correct SmartReflex omap_sr_dev_attr values for OMAP4. . kerneldoc needed in smartreflex.h Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch

[PATCH 06/26] OMAP3+: Pass SmartReflex instance-specific data via hwmod dev_attr

From: Jean Pihet j-pi...@ti.com Based on Paul's original code for the SmartReflex driver conversion. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/smartreflex.c | 28 +--- arch/arm/mach-omap2/smartreflex.h

<    1   2   3   4   5   6   7   8   9   10   >