Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Bart Van Assche
On Thu, Sep 22, 2011 at 8:29 PM, Hefty, Sean sean.he...@intel.com wrote: Signed-off-by: Sean Hefty sean.he...@intel.com ---  libibnetdisc/src/ibnetdisc.c |    2 +-  src/ibportstate.c            |    4 ++--  2 files changed, 3 insertions(+), 3 deletions(-)  mode change 100644 = 100755

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hal Rosenstock
On 9/22/2011 2:36 PM, Bart Van Assche wrote: libibnetdisc/src/ibnetdisc.c |2 +- src/ibportstate.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) mode change 100644 = 100755 libibnetdisc/src/ibnetdisc.c mode change 100644 = 100755 src/ibportstate.c A minor

RE: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
 libibnetdisc/src/ibnetdisc.c |    2 +-  src/ibportstate.c            |    4 ++--  2 files changed, 3 insertions(+), 3 deletions(-)  mode change 100644 = 100755 libibnetdisc/src/ibnetdisc.c  mode change 100644 = 100755 src/ibportstate.c A minor nit: is this mode change really

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Jason Gunthorpe
On Thu, Sep 22, 2011 at 08:20:54PM +, Hefty, Sean wrote: The entire windows tree is built using the WinDDK compiler. I haven't found a way to disable that warning that works. Since the warning is real, an explicit cast at least lets someone reading the code know that the author took

RE: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
Adding a cast is just pointless noise, doesn't fix or prove anything. It fixes the build on windows. You can call that pointless, but I do not. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Jason Gunthorpe
On Thu, Sep 22, 2011 at 09:33:24PM +, Hefty, Sean wrote: Adding a cast is just pointless noise, doesn't fix or prove anything. It fixes the build on windows. You can call that pointless, but I do not. It supresses a warning, warnings are not build failures. Jason -- To unsubscribe from

RE: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
It supresses a warning, warnings are not build failures. Actually, on windows the build fails. No executables are built. mad_[get|set]_field[8|16|32] should work fine. But those are exported from ibmad, which would require ib-diags to either check for them as a requirement or implement them

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Jason Gunthorpe
On Thu, Sep 22, 2011 at 11:03:24PM +, Hefty, Sean wrote: It supresses a warning, warnings are not build failures. Actually, on windows the build fails. No executables are built. Seriously? I hope this is because you've got the warnings are errors flag set..