[PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

2011-09-22 Thread Yong Zhang
Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled], We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]). So now

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

2011-09-22 Thread Roland Dreier
Is someone taking this whole series, or should I take the ehca part? (I know the ehca guys already acked this) - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] opensm/osmtest/osmt_multicast.c: Fix an unrealistic rate case

2011-09-22 Thread Hal Rosenstock
56 Gbps is really faster than 60 Gbps due to the link encoding difference so use 56 Gbps rather than 60 Gbps here 300 Gbps rather than 120 Gbps is now the max rate Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/osmtest/osmt_multicast.c b/osmtest/osmt_multicast.c index

[PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
Signed-off-by: Sean Hefty sean.he...@intel.com --- libibnetdisc/src/ibnetdisc.c |2 +- src/ibportstate.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) mode change 100644 = 100755 libibnetdisc/src/ibnetdisc.c mode change 100644 = 100755 src/ibportstate.c diff

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Bart Van Assche
On Thu, Sep 22, 2011 at 8:29 PM, Hefty, Sean sean.he...@intel.com wrote: Signed-off-by: Sean Hefty sean.he...@intel.com ---  libibnetdisc/src/ibnetdisc.c |    2 +-  src/ibportstate.c            |    4 ++--  2 files changed, 3 insertions(+), 3 deletions(-)  mode change 100644 = 100755

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hal Rosenstock
On 9/22/2011 2:36 PM, Bart Van Assche wrote: libibnetdisc/src/ibnetdisc.c |2 +- src/ibportstate.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) mode change 100644 = 100755 libibnetdisc/src/ibnetdisc.c mode change 100644 = 100755 src/ibportstate.c A minor

RE: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
 libibnetdisc/src/ibnetdisc.c |    2 +-  src/ibportstate.c            |    4 ++--  2 files changed, 3 insertions(+), 3 deletions(-)  mode change 100644 = 100755 libibnetdisc/src/ibnetdisc.c  mode change 100644 = 100755 src/ibportstate.c A minor nit: is this mode change really

RE: [PATCH v2] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
Signed-off-by: Sean Hefty sean.he...@intel.com --- changes from v1: reset mode back to 644 libibnetdisc/src/ibnetdisc.c |2 +- src/ibportstate.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libibnetdisc/src/ibnetdisc.c b/libibnetdisc/src/ibnetdisc.c

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Jason Gunthorpe
On Thu, Sep 22, 2011 at 08:20:54PM +, Hefty, Sean wrote: The entire windows tree is built using the WinDDK compiler. I haven't found a way to disable that warning that works. Since the warning is real, an explicit cast at least lets someone reading the code know that the author took

RE: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
Adding a cast is just pointless noise, doesn't fix or prove anything. It fixes the build on windows. You can call that pointless, but I do not. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Jason Gunthorpe
On Thu, Sep 22, 2011 at 09:33:24PM +, Hefty, Sean wrote: Adding a cast is just pointless noise, doesn't fix or prove anything. It fixes the build on windows. You can call that pointless, but I do not. It supresses a warning, warnings are not build failures. Jason -- To unsubscribe from

Re: [PATCH v2] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Ira Weiny
On Thu, 22 Sep 2011 13:37:23 -0700 Hefty, Sean sean.he...@intel.com wrote: Signed-off-by: Sean Hefty sean.he...@intel.com Thanks applied. Ira --- changes from v1: reset mode back to 644 libibnetdisc/src/ibnetdisc.c |2 +- src/ibportstate.c|4 ++-- 2 files changed,

RE: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Hefty, Sean
It supresses a warning, warnings are not build failures. Actually, on windows the build fails. No executables are built. mad_[get|set]_field[8|16|32] should work fine. But those are exported from ibmad, which would require ib-diags to either check for them as a requirement or implement them

[PATCH] infiniband-diags: ibqueryerrors add query failure count

2011-09-22 Thread Ira Weiny
Report query failure count as part of summary Signed-off-by: Ira Weiny wei...@llnl.gov --- src/ibqueryerrors.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/ibqueryerrors.c b/src/ibqueryerrors.c index 8e0b336..fa116a9 100644 --- a/src/ibqueryerrors.c +++

Re: [PATCH] ib-diags: Add cast to fix build on windows

2011-09-22 Thread Jason Gunthorpe
On Thu, Sep 22, 2011 at 11:03:24PM +, Hefty, Sean wrote: It supresses a warning, warnings are not build failures. Actually, on windows the build fails. No executables are built. Seriously? I hope this is because you've got the warnings are errors flag set..

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

2011-09-22 Thread Yong Zhang
On Thu, Sep 22, 2011 at 09:56:07AM -0700, Roland Dreier wrote: Is someone taking this whole series, or should I take the ehca part? You could take it and Thomas will take the leftovers. (I know the ehca guys already acked this) Yeah, so I mentioned it in the cover letter :) Thanks, Yong --

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

2011-09-22 Thread Yong Zhang
On Fri, Sep 23, 2011 at 9:40 AM, Yong Zhang yong.zha...@gmail.com wrote: On Thu, Sep 22, 2011 at 09:56:07AM -0700, Roland Dreier wrote: Is someone taking this whole series, or should I take the ehca part? You could take it and Thomas will take the leftovers. (I know the ehca guys already