Re: [PATCH 1/3] clk: exynos: register audio subsystem clocks using common clock framework

2013-04-05 Thread Sylwester Nawrocki
On 04/05/2013 08:23 AM, Padmavathi Venna wrote: Audio subsystem is introduced in exynos platforms. This has seperate clock controller which can control i2s0 and pcm0 clocks. This patch registers the audio subsystem clocks with the common clock framework. Signed-off-by: Padmavathi Venna

[PATCH] clk: exynos4: export clocks required for fimc-is

2013-04-05 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/ kgene/linux-samsung.git for-next .../devicetree/bindings/clock/exynos4-clock.txt| 42 +--- drivers/clk/samsung

Re: [PATCH 1/2] ARM: dts: Add MFC clock entries for exynos4

2013-04-04 Thread Sylwester Nawrocki
On 04/04/2013 08:26 AM, Sachin Kamat wrote: Added MFC related clock entries in exynos4.dtsi file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- Based on Kukjin's for-next. Dependent on the below patch: https

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-04-03 Thread Sylwester Nawrocki
Hi Arun, On 03/13/2013 05:09 AM, Arun Kumar K wrote: Hi Sylwester, /* Interrupt mask */ #define S5PCSIS_INTMSK 0x10 -#define S5PCSIS_INTMSK_EN_ALL0xf000103f +#define S5PCSIS_INTMSK_EN_ALL0xfc00103f Do you know what interrupts are

Re: EXYNOS will support only DT from v3.10

2013-04-02 Thread Sylwester Nawrocki
On 03/25/2013 12:01 PM, Kukjin Kim wrote: Hi all, As we discussed before, it's time to decide to support non-DT for EXYNOS SoCs. If everybody else agrees to drop non-DT support from v3.10, I will. Feel free to talk your opinion about that. I'm fine with supporting Exynos as dt-only from

Re: [PATCH 10/23] [media] exynos: remove unnecessary header inclusions

2013-04-02 Thread Sylwester Nawrocki
On 03/05/2013 06:42 PM, Arnd Bergmann wrote: In multiplatform configurations, we cannot include headers provided by only the exynos platform. Fortunately a number of drivers that include those headers do not actually need them, so we can just remove the inclusions. Signed-off-by: Arnd

[PATCH] exynos4-is: Remove dependency on SYSCON for non-dt platforms

2013-04-02 Thread Sylwester Nawrocki
on OF. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/Kconfig |7 ++- drivers/media/platform/exynos4-is/fimc-core.c |3 +-- drivers/media/platform/exynos4-is/fimc-core.h | 10

[PATCH] exynos4-is: Correct clock properties description at the DT binding documentation

2013-04-02 Thread Sylwester Nawrocki
is needed to have e.g. clocks driver setting all required parent clocks, before clock consumers start using the clocks. Currently this binding doesn't describe the parent clocks setup, it needs to be specified and handled somewhere else. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com

[PATCH v4 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-04-02 Thread Sylwester Nawrocki
of futures this patch series addresses. Others include input/output DMA support for the DRC and FD blocks, support for more ISP controls, etc. Full git tree with all dependencies can be found at: http://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is-v2 -- Sylwester

[PATCH v4 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-04-02 Thread Sylwester Nawrocki
CPU. The image sensor drivers can be standard I2C client driver, as in case of most existing image sensor driver. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v3: - corrected I2C bus driver remove() function

[PATCH v4 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-04-02 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo yhwan@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v3: - dropped unused headers, - removed get_is_cfg

[PATCH v4 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-04-02 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v3: - dropped unused headers. --- drivers/media/platform/exynos4-is/Kconfig | 11 + drivers/media/platform/exynos4-is/Makefile |3 + drivers/media/platform

[PATCH v4 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree binding documentation

2013-04-02 Thread Sylwester Nawrocki
This patch adds DT binding documentaton for the Imaging Subsystem (camera ISP) found on Samsung Exynos4x12 SoCs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v3: - specified order of the interrupts, - added

[PATCH v4 7/7] exynos4-is: Create media links for the FIMC-IS entities

2013-04-02 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/media-dev.c | 79

Re: [PATCH v10 2/3] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts

2013-04-01 Thread Sylwester Nawrocki
decide to keep it, then this node should contain 'reg' property AFAICT. Otherwise the series looks good to me. With the above issue addressed feel free to add Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com + clock-frequency =5; + hactive

[PATCH v3 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-29 Thread Sylwester Nawrocki
for more ISP controls, etc. Full git tree with all dependencies can be found at: http://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is-v2 -- Sylwester Nawrocki (7): exynos4-is: Add Exynos4x12 FIMC-IS driver exynos4-is: Add FIMC-IS ISP I2C bus driver exynos4

[PATCH v3 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-03-29 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo yhwan@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v3: - fixed a few issues found with checkpatch.pl

[PATCH v3 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-03-29 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v2: - added delay needed for sensor initialization in s_power callback, this delay was actually moved from fimc-isp.c from sensor/IS initialization function

[PATCH v3 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree binding documentation

2013-03-29 Thread Sylwester Nawrocki
This patch adds DT binding documentaton for the Imaging Subsystem (camera ISP) found on Samsung Exynos4x12 SoCs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v2: - added missing clocks at the binding

[PATCH v3 6/7] exynos4-is: Add FIMC-IS subdevs registration

2013-03-29 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH v3 7/7] exynos4-is: Create media links for the FIMC-IS entities

2013-03-29 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v2: - none. --- drivers/media/platform/s5p-fimc

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-28 Thread Sylwester Nawrocki
Hi Arun, On 03/28/2013 06:10 AM, Arun Kumar K wrote: On Wed, Mar 27, 2013 at 7:17 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 03/27/2013 05:31 AM, Arun Kumar K wrote: On Wed, Mar 27, 2013 at 4:21 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/26/2013 01:17 PM

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-27 Thread Sylwester Nawrocki
On 03/27/2013 05:31 AM, Arun Kumar K wrote: On Wed, Mar 27, 2013 at 4:21 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/26/2013 01:17 PM, Arun Kumar K wrote: [...] Only issue is with the context sharing. Right now you can see that the fimc-is context is shared between all

Re: [PATCH] [media] s5p-mfc: Change MFC clock reference w.r.t Common Clock Framework

2013-03-27 Thread Sylwester Nawrocki
are not really supposed to care about differences like this. Such differences could be easily handled in the device tree. The DT binding documentation just needs to specify the meaning of each clock name. [1] http://www.spinics.net/lists/arm-kernel/msg233521.html Regards, -- Sylwester Nawrocki

[PATCH v2] ARM: dts: Add SYSREG block node for S5P/Exynos4 SoC series

2013-03-26 Thread Sylwester Nawrocki
is to be associated with mfd syscon driver and all SYSREG clients should use regmap interface it provides. It allows to eliminate any possible races and conflicts should different drivers attempt to concurrently access same register. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off

[REVIEW PATCH 0/3] s5p-fimc driver updates

2013-03-26 Thread Sylwester Nawrocki
This patch series contains mostly conversion of the video capture node drivers to videobuf2 ioctl/fop helpers. Sylwester Nawrocki (3): s5p-fimc: Use video entity for marking media pipeline as streaming s5p-fimc: Use vb2 ioctl/fop helpers in FIMC capture driver s5p-fimc: Use vb2 ioctl

[REVIEW PATCH 1/3] s5p-fimc: Use video entity for marking media pipeline as streaming

2013-03-26 Thread Sylwester Nawrocki
entity pipeline operations when vb2_streamon() function fails. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-capture.c | 27 +++- drivers/media/platform/s5p-fimc/fimc

[REVIEW PATCH 2/3] s5p-fimc: Use vb2 ioctl/fop helpers in FIMC capture driver

2013-03-26 Thread Sylwester Nawrocki
mmap/poll file operation and several ioctl handlers are replaced with the vb2 helper functions. Some helpers are used indirectly to maintain the buffer queue ownership. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers

[REVIEW PATCH 3/3] s5p-fimc: Use vb2 ioctl helpers in fimc-lite

2013-03-26 Thread Sylwester Nawrocki
Replace some ioctl, file and video buffer queue operation handlers with the videobuf2 helpers. This allows to get rid of significant amount of boilerplate. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform

[PATCH v5 0/6] Device tree support for Exynos SoC camera subsystem

2013-03-26 Thread Sylwester Nawrocki
and these patches at end of this week. This patch series with all dependencies can be found at: http://git.linuxtv.org/snawrocki/samsung.git/devicetree-fimc-v5 Sylwester Nawrocki (6): s5p-csis: Add device tree support s5p-fimc: Add device tree support for FIMC device driver s5p-fimc: Add device

[PATCH v5 1/6] s5p-csis: Add device tree support

2013-03-26 Thread Sylwester Nawrocki
This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and parsing the SoC and board specific properties. The MIPI CSI-2 channel is determined by the value of reg property placed in csis' port subnode. Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH v5 2/6] s5p-fimc: Add device tree support for FIMC device driver

2013-03-26 Thread Sylwester Nawrocki
will all be removed from the driver. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v5: - Added clocks/clock-names properties to the binding documentation. Changes since v4: - Added parsing of FIMC features

[PATCH v5 3/6] s5p-fimc: Add device tree support for FIMC-LITE device driver

2013-03-26 Thread Sylwester Nawrocki
This patch adds the device tree support for FIMC-LITE device driver. The bindings include compatible property for the Exynos5 SoC series, however the actual implementation for these SoCs will be added in a separate patch. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off

[PATCH v5 6/6] s5p-fimc: Use pinctrl API for camera ports configuration

2013-03-26 Thread Sylwester Nawrocki
Before the camera ports can be used the pinmux needs to be configured properly. This patch adds a function to set the camera ports pinctrl to a default state within the media driver's probe(). The camera port(s) are then configured for the video bus operation. Signed-off-by: Sylwester Nawrocki

Re: [PATCH v5 0/6] Device tree support for Exynos SoC camera subsystem

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 05:39 PM, Sylwester Nawrocki wrote: Changes in this iteration include mostly adaptation to changes at the V4L2 OF parser lib and an addition of clocks/clock-names properties in the bindings of the IP blocks. If there is no more comments I intend to send a pull request including

[PATCH v2 00/10] s5p-fimc: Exynos4x12 FIMC-IS support prerequisite

2013-03-26 Thread Sylwester Nawrocki
to drivers/media/platform/exynos4-is. This series, including dependencies, can be browsed at: http://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is-v2 Andrzej Hajda (1): s5p-fimc: Add error checks for pipeline stream on callbacks Sylwester Nawrocki (9): V4L: Add MATRIX option

[PATCH v2 01/10] V4L: Add MATRIX option to V4L2_CID_EXPOSURE_METERING control

2013-03-26 Thread Sylwester Nawrocki
This patch adds a menu option to the V4L2_CID_EXPOSURE_METERING control for multi-zone metering. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml |7 +++ drivers/media/v4l2

[PATCH v2 02/10] s5p-fimc: Add error checks for pipeline stream on callbacks

2013-03-26 Thread Sylwester Nawrocki
From: Andrzej Hajda a.ha...@samsung.com set_stream error for pipelines is logged or reported to user space if possible. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers

[PATCH v2 04/10] s5p-fimc: Add support for PIXELASYNCMx clocks

2013-03-26 Thread Sylwester Nawrocki
This patch ads handling of clocks for the CAMBLK subsystem which is a glue logic for FIMC-IS or LCD controller and FIMC IP. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v1: - Do not keep PXLASYNC clocks always

[PATCH v2 06/10] s5p-fimc: Ensure CAMCLK clock can be enabled by FIMC-LITE devices

2013-03-26 Thread Sylwester Nawrocki
. This affect processing pipelines like: - sensor - FIMC-LITE - memory - sensor - MIPI-CSIS - FIMC-LITE - memory Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 18

[PATCH v2 07/10] s5p-fimc: Ensure proper s_stream() call order in the ISP datapaths

2013-03-26 Thread Sylwester Nawrocki
, rather than doing the op call based on increasing/decreasing indexes. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 22 +++--- 1 file changed, 15 insertions(+), 7

[PATCH v2 08/10] s5p-fimc: Ensure proper s_power() call order in the ISP datapaths

2013-03-26 Thread Sylwester Nawrocki
from a table, rather than doing the op call based on increasing/decreasing indexes. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 26 1 file changed, 18

[PATCH v2 09/10] s5p-fimc: Remove dependency on fimc-core.h in fimc-lite driver

2013-03-26 Thread Sylwester Nawrocki
Drop fimc-lite.h header inclusion to make the exynos-fimc-lite module independent on other modules. Move struct fimc_fmt declaration to the driver's private headers as it is used in multiple modules. Reported-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH v2 10/10] s5p-fimc: Change the driver directory name to exynos4-is

2013-03-26 Thread Sylwester Nawrocki
modules will find their home in drivers/media/platform/exynos5-is. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/Kconfig |2 +- drivers/media/platform/Makefile|2

[PATCH v2 03/10] s5p-fimc: Update graph traversal for entities with multiple source pads

2013-03-26 Thread Sylwester Nawrocki
handling of FIMC, FIMC-LITE and FIMC-IS-ISP subdevs that have more than one sink and one source pad. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 24 +++- 1

[PATCH v2 05/10] s5p-fimc: Add support for ISP Writeback data input bus type

2013-03-26 Thread Sylwester Nawrocki
Interface (FIMC) driver * - * Copyright (C) 2010 - 2012 Samsung Electronics Co., Ltd. - * Sylwester Nawrocki, s.nawro...@samsung.com + * Copyright (C) 2010 - 2013 Samsung Electronics Co., Ltd. + * Sylwester Nawrocki s.nawro...@samsung.com * * This program is free software; you can redistribute

[PATCH v2 0/7] V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-26 Thread Sylwester Nawrocki
/exynos4-fimc-is-v2 Sylwester Nawrocki (7): exynos4-is: Add Exynos4x12 FIMC-IS driver exynos4-is: Add FIMC-IS ISP I2C bus driver exynos4-is: Add FIMC-IS parameter region definitions exynos4-is: Add common FIMC-IS image sensor driver exynos4-is: Add Exynos4x12 FIMC-IS device tree bindings

[PATCH v2 2/7] exynos4-is: Add FIMC-IS ISP I2C bus driver

2013-03-26 Thread Sylwester Nawrocki
CPU. The image sensor drivers can be standard I2C client driver, as in case of most existing image sensor driver. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-is-i2c.c | 81

[PATCH v2 3/7] exynos4-is: Add FIMC-IS parameter region definitions

2013-03-26 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Younghwan Joo yhwan@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-is-param.c | 971

[PATCH v2 4/7] exynos4-is: Add common FIMC-IS image sensor driver

2013-03-26 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/Kconfig | 13 + drivers/media/platform/exynos4-is/Makefile |3 + drivers/media/platform/exynos4-is/fimc-is-sensor.c | 307

[PATCH v2 5/7] exynos4-is: Add Exynos4x12 FIMC-IS device tree bindings documentation

2013-03-26 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/exynos4-fimc-is.txt | 45 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/exynos4

[PATCH v2 7/7] s5p-fimc: Create media links for the FIMC-IS entities

2013-03-26 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/media-dev.c | 83

[PATCH v2 6/7] s5p-fimc: Add fimc-is subdevs registration

2013-03-26 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH v2 0/4] exynos4-is updates

2013-03-26 Thread Sylwester Nawrocki
are available at: git://linuxtv.org/snawrocki/samsung.git exynos4-fimc-is-v2 Sylwester Nawrocki (5): exynos4-is: Remove static driver data for Exynos4210 FIMC variants exynos4-is: Use common driver data for all FIMC-LITE IP instances exynos4-is: Allow colorspace conversion at fimc-lite

[PATCH v2 1/5] exynos4-is: Remove static driver data for Exynos4210 FIMC variants

2013-03-26 Thread Sylwester Nawrocki
All Exynos4210 based boards files using FIMC are going to be removed in 3.10 and corresponding device trees are to be used instead. The FIMC variant data will be parsed directly form the device tree for those SoCs as well. Hence now unused static data is removed. Signed-off-by: Sylwester Nawrocki

[PATCH v2 2/4] exynos4-is: Allow colorspace conversion at fimc-lite

2013-03-26 Thread Sylwester Nawrocki
| CB| Y YCRYCB | CB| Y | CR| Y CBYCRY | Y | CR| Y | CB CRYCBY | Y | CB| Y | CR Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-lite-reg.c

[PATCH v2 2/5] exynos4-is: Use common driver data for all FIMC-LITE IP instances

2013-03-26 Thread Sylwester Nawrocki
There is no need to use separate variant data structure for each FIMC-LITE IP instance. According to my knowledge there are no differences across them on Exynos4 as well as Exynos5 SoCs. Drop flite_variant data structure and use struct flite_drvdata instead. Signed-off-by: Sylwester Nawrocki

[PATCH v2 3/5] exynos4-is: Allow colorspace conversion at fimc-lite

2013-03-26 Thread Sylwester Nawrocki
| CB| Y YCRYCB | CB| Y | CR| Y CBYCRY | Y | CR| Y | CB CRYCBY | Y | CB| Y | CR Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-lite-reg.c

[PATCH v2 3/4] exynos4-is: Correct input DMA YUV order configuration

2013-03-26 Thread Sylwester Nawrocki
| CR Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-core.c | 16 drivers/media/platform/exynos4-is/fimc-reg.c |3 ++- drivers/media/platform/exynos4-is/fimc-reg.h

[PATCH v2 4/5] exynos4-is: Correct input DMA YUV order configuration

2013-03-26 Thread Sylwester Nawrocki
| CR Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-core.c | 16 drivers/media/platform/exynos4-is/fimc-reg.c |3 ++- drivers/media/platform/exynos4-is/fimc-reg.h

[PATCH v2 4/4] exynos4-is: Ensure proper media pipeline state on device close

2013-03-26 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/exynos4-is/fimc-capture.c | 18 +- drivers/media/platform/exynos4-is/fimc-core.h|1 + drivers/media/platform/exynos4-is/fimc-lite.c| 18

Re: [PATCH v2 0/4] exynos4-is updates

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 07:38 PM, Sylwester Nawrocki wrote: This patch series includes YUV order handling fix for the FIMC and FIMC-LITE, a fix for media entity ref_count issue, minor refactoring and removal of some static data that will no longer be needed since starting from 3.10 Exynos platform

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-26 Thread Sylwester Nawrocki
On 03/26/2013 01:17 PM, Arun Kumar K wrote: +Sensor sub-nodes: + +FIMC-IS IP supports custom built sensors to be controlled exclusively by +the FIMC-IS firmware. These sensor properties are to be defined here. [snip] Defining image sensor nodes in a standard way as ISP I2C bus controller

Re: [PATCH v9 4/4] ARM: dts: Add FIMD DT binding Documentation

2013-03-25 Thread Sylwester Nawrocki
On 03/25/2013 12:10 PM, Thomas Abraham wrote: --- /dev/null +++ b/Documentation/devicetree/bindings/video/samsung-fimd.txt @@ -0,0 +1,68 @@ +Device-Tree bindings for Samsung SoC display controller (FIMD) [...] +- interrupts : should contain a list of all FIMD IP block interrupts: + FIFO

[PATCH] ARM: dts: Add SYSREG block node for Exynos4 SoC series

2013-03-25 Thread Sylwester Nawrocki
with the mfd syscon driver and all SYSREG clients should use the regmap interface it provides. It allows to eliminate any possible races and conflicts should different drivers attempt to concurrently access same register. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

Re: [RFC 11/12] media: m5mols: Adding dt support to m5mols driver

2013-03-23 Thread Sylwester Nawrocki
Hi Shaik, On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the dt support to m5mols driver. Signed-off-by: Shaik Ameer Bashashaik.am...@samsung.com --- drivers/media/i2c/m5mols/m5mols_core.c | 54 +++- 1 file changed, 53 insertions(+), 1

Re: [RFC 12/12] ARM: dts: Add camera node to exynos5250-smdk5250.dts

2013-03-23 Thread Sylwester Nawrocki
On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Signed-off-by: Shaik Ameer Bashashaik.am...@samsung.com --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 43 - 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts

Re: [RFC 01/12] exynos-fimc-is: Adding device tree nodes

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: Add the fimc-is node and the required pinctrl nodes for fimc-is driver for Exynos5. Also adds the DT binding documentation for the new fimc-is node. Signed-off-by: Arun Kumar Karun...@samsung.com Signed-off-by: Kilyeon Imkilyeon...@samsung.com ---

Re: [RFC 03/12] exynos-fimc-is: Adds fimc-is driver core files

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: This driver is for the FIMC-IS IP available in Samsung Exynos5 SoC onwards. This patch adds the core files for the new driver. Signed-off-by: Arun Kumar Karun...@samsung.com Signed-off-by: Kilyeon Imkilyeon...@samsung.com ---

Re: [RFC 04/12] exynos-fimc-is: Adds common driver header files

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: This patch adds all the common header files used by the fimc-is driver. It includes the commands for interfacing with the firmware and error codes from IS firmware, metadata and command parameter definitions. Signed-off-by: Arun Kumar

Re: [RFC 05/12] exynos-fimc-is: Adds the register definition and context header

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: This patch adds the register definition file for the fimc-is driver and also the header file containing the main context for the driver. Signed-off-by: Arun Kumar Karun...@samsung.com Signed-off-by: Kilyeon Imkilyeon...@samsung.com ---

Re: [RFC 06/12] exynos-fimc-is: Adds the sensor subdev

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: FIMC-IS uses certain sensors which are exclusively controlled from the IS firmware. This patch adds the sensor subdev for the fimc-is sensors. Signed-off-by: Arun Kumar Karun...@samsung.com Signed-off-by: Kilyeon Imkilyeon...@samsung.com ---

Re: [RFC 07/12] exynos-fimc-is: Adds isp subdev

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: fimc-is driver takes video data input from the ISP video node which is added in this patch. This node accepts Bayer input buffers which is given from the IS sensors. Signed-off-by: Arun Kumar Karun...@samsung.com Signed-off-by: Kilyeon

Re: [RFC 11/12] exynos-fimc-is: Adds the Kconfig and Makefile

2013-03-23 Thread Sylwester Nawrocki
On 03/08/2013 03:59 PM, Arun Kumar K wrote: Modifies the exynos5-is Makefile and Kconfig to include the new fimc-is driver. Signed-off-by: Arun Kumar Karun...@samsung.com Signed-off-by: Kilyeon Imkilyeon...@samsung.com --- drivers/media/platform/exynos5-is/Kconfig | 12

Re: [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name

2013-03-19 Thread Sylwester Nawrocki
On 03/18/2013 04:50 PM, Rob Herring wrote: On 03/13/2013 05:42 PM, Sylwester Nawrocki wrote: On 03/13/2013 03:39 PM, Rob Herring wrote: I fail to see what the hack is. The order of interrupt properties must be defined by the binding. interrupt-names is auxiliary data and must not be required

Re: [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name

2013-03-19 Thread Sylwester Nawrocki
On 03/19/2013 12:05 AM, Stephen Warren wrote: On 03/18/2013 04:27 PM, Rob Herring wrote: On 03/18/2013 01:11 PM, Stephen Warren wrote: On 03/18/2013 09:50 AM, Rob Herring wrote: On 03/13/2013 05:42 PM, Sylwester Nawrocki wrote: Rob, On 03/13/2013 03:39 PM, Rob Herring wrote: I fail to see

Re: [PATCH] ARM: SAMSUNG: Set clock parent if provided

2013-03-18 Thread Sylwester Nawrocki
Hi Shaik, On 03/15/2013 10:00 AM, Shaik Ameer Basha wrote: On Thu, Mar 7, 2013 at 9:05 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: ... May I ask what do you need this for ? This code won't be used for Exynos4 and Exynos5 SoCs starting from 3.10. And it is going to be removed once

[PATCH] [media] Add a V4L2 OF parser

2013-03-18 Thread Sylwester Nawrocki
the initial version] Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Geunnadi, I have made couple further changes to this parsing library, mostly addressing your review comments. Hopefully it looks better now. It would be good

Re: [RFC PATCH 1/8] s5p-fimc: Add Exynos4x12 FIMC-IS driver

2013-03-17 Thread Sylwester Nawrocki
Hi Hans, On 03/12/2013 03:27 PM, Hans Verkuil wrote: On Mon 11 March 2013 20:44:45 Sylwester Nawrocki wrote: [...] + +/* Supported manual ISO values */ +static const s64 iso_qmenu[] = { + 50, 100, 200, 400, 800, +}; + +static int __ctrl_set_iso(struct fimc_is *is, int value

Re: [RFC PATCH 5/8] s5p-fimc: Add ISP video capture driver stubs

2013-03-17 Thread Sylwester Nawrocki
On 03/12/2013 03:44 PM, Hans Verkuil wrote: On Mon 11 March 2013 20:44:49 Sylwester Nawrocki wrote: [...] +static int isp_video_capture_open(struct file *file) +{ + struct fimc_isp *isp = video_drvdata(file); + int ret = 0; + + if (mutex_lock_interruptible(isp-video_lock

Re: [PATCH] ARM: dts: add interrupt-names property to get interrupt resource by name

2013-03-13 Thread Sylwester Nawrocki
Rob, On 03/13/2013 03:39 PM, Rob Herring wrote: I fail to see what the hack is. The order of interrupt properties must be defined by the binding. interrupt-names is auxiliary data and must not be required by an OS. It is clear that the order of the interrupts must be defined by the bindings.

Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-13 Thread Sylwester Nawrocki
it was posted early. I will remove this patch from the exynos5-mdev series and will send this as a separate patch from next time. OK. please find my review comments inline.. On Mon, Mar 11, 2013 at 3:30 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Sylwester Nawrocki
Hi, On 03/12/2013 10:54 AM, Thomas Abraham wrote: This change is fine but one point that should be considered is that on non-dt platforms, the memory allocation of clk_table cannot really be justified just because few clocks require two or more aliases. Instead, the optional alias passed for

Re: [PATCH 1/7] clk: samsung: add plls used in s3c2416 and s3c2443

2013-03-12 Thread Sylwester Nawrocki
On 03/12/2013 01:21 PM, Heiko Stübner wrote: Thanks for the hint ... this is what I rightfully get for mindlessly copying from the other plls in the file;-) . :) What about the other plls in the pll-file, they should be affected in the same way, right? Yes, they're of course also

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Sylwester Nawrocki
On 03/12/2013 12:46 PM, Thomas Abraham wrote: And, you mentioned Exynos4 will be dt-only from 3.10. Does that mean we just drop support for universal and nuri non-dt board support? Or, will there be a equivalent dt support added for these boards? I think Tomasz has some initial dts files for

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-12 Thread Sylwester Nawrocki
Hi Shaik, On 03/11/2013 07:58 AM, Shaik Ameer Basha wrote: Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-03-12 Thread Sylwester Nawrocki
Hi Arun, On 03/08/2013 03:59 PM, Arun Kumar K wrote: FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled. This patch enables all those MIPI interrupts. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-fimc/mipi-csis.c |2 +- 1 file changed,

[PATCH RFC 00/11] s5p-fimc: Exynos4x12 FIMC-IS support prerequisite

2013-03-11 Thread Sylwester Nawrocki
This patch series contains couple fixes to the s5p-fimc driver and changes necessary for the Exynos4x12 FIMC-IS support. Andrzej Hajda (1): s5p-fimc: Added error checks for pipeline stream on callbacks Sylwester Nawrocki (10): s5p-fimc: Add parent clock setup s5p-csis: Add parent clock

[PATCH RFC 01/11] s5p-fimc: Added error checks for pipeline stream on callbacks

2013-03-11 Thread Sylwester Nawrocki
From: Andrzej Hajda a.ha...@samsung.com set_stream error for pipelines is logged or reported to user space if possible. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers

[PATCH RFC 02/11] s5p-fimc: Add parent clock setup

2013-03-11 Thread Sylwester Nawrocki
it is ensured the SCLK_FIMC clock has correct parent clock set, and the parent clock can be selected per each board if required. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-core.c | 63

[PATCH RFC 03/11] s5p-csis: Add parent clock setup

2013-03-11 Thread Sylwester Nawrocki
it is ensured the SCLK_CSIS has correct parent clock set, and the parent clock can be selected per each board if required. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/mipi-csis.c | 66

[PATCH RFC 04/11] s5p-fimc: Update graph traversal for entities with multiple source pads

2013-03-11 Thread Sylwester Nawrocki
handling of FIMC, FIMC-LITE and FIMC-IS-ISP subdevs that have more than one sink and one source pad. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 22 ++ 1

[PATCH RFC 06/11] s5p-fimc: Add the FIMC ISP writeback input support

2013-03-11 Thread Sylwester Nawrocki
subdev. - Implement an interface for CAMBLK registers, the CAMBLK glue logic registers are shared by multiple drivers so this probably belongs to the platform at arch/arm/mach-exynos/. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH RFC 07/11] s5p-fimc: Ensure CAMCLK clock can be enabled by FIMC-LITE devices

2013-03-11 Thread Sylwester Nawrocki
. This affect processing pipelines like: - sensor - FIMC-LITE - memory - sensor - MIPI-CSIS - FIMC-LITE - memory Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 18

[PATCH RFC 09/11] s5p-fimc: Ensure proper s_power() call order in the ISP datapaths

2013-03-11 Thread Sylwester Nawrocki
from a table, rather than doing the op call based on increasing/decreasing indexes. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 26 1 file changed, 18

[PATCH RFC 10/11] s5p-fimc: Remove dependency on fimc-core.h in fimc-lite driver

2013-03-11 Thread Sylwester Nawrocki
Drop fimc-lite.h header inclusion to make the exynos-fimc-lite module independent on other modules. Move struct fimc_fmt declaration to the driver's private headers as it is used in multiple modules. Reported-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH RFC 11/11] V4L: Add MATRIX option to V4L2_CID_EXPOSURE_METERING control

2013-03-11 Thread Sylwester Nawrocki
This patch adds a menu option to the V4L2_CID_EXPOSURE_METERING control for multi-zone metering. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml |9 - drivers/media/v4l2

[RFC PATCH 0/8] A V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-11 Thread Sylwester Nawrocki
be found at: git://linuxtv.org/snawrocki/samsung.git http://git.linuxtv.org/snawrocki/samsung.git/exynos4-fimc-is Sylwester Nawrocki (8): s5p-fimc: Add Exynos4x12 FIMC-IS driver s5p-fimc: Add FIMC-IS ISP I2C bus driver s5p-fimc: Add FIMC-IS parameter region definitions s5p-fimc: Add common FIMC

[RFC PATCH 2/8] s5p-fimc: Add FIMC-IS ISP I2C bus driver

2013-03-11 Thread Sylwester Nawrocki
CPU. The image sensor drivers can be standard I2C client driver, as in case of most existing image sensor driver. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-is-i2c.c | 81

[RFC PATCH 3/8] s5p-fimc: Add FIMC-IS parameter region definitions

2013-03-11 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-is-param.c | 971 + drivers/media/platform/s5p-fimc/fimc

<    4   5   6   7   8   9   10   11   12   13   >