Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-08 Thread James Bottomley
On Mon, 2007-05-07 at 14:06 -0700, Andrew Morton wrote: On Mon, 07 May 2007 14:50:19 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Richard Knutsson [EMAIL PROTECTED] Convert: FALSE - false TRUE - true

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-08 Thread Andrew Morton
On Tue, 08 May 2007 14:24:32 -0500 James Bottomley [EMAIL PROTECTED] wrote: However, could we compromise and just add TRUE = true, FALSE = false to the enum? That sounds sane. But I don't recall all the details of the discussion and perhaps I'm missing something. I think the whole

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-08 Thread James Bottomley
On Tue, 2007-05-08 at 13:11 -0700, Andrew Morton wrote: On Tue, 08 May 2007 14:24:32 -0500 James Bottomley [EMAIL PROTECTED] wrote: However, could we compromise and just add TRUE = true, FALSE = false to the enum? That sounds sane. But I don't recall all the details of the discussion

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-08 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 8 May 2007 13:11:52 -0700 On Tue, 08 May 2007 14:24:32 -0500 James Bottomley [EMAIL PROTECTED] wrote: However, could we compromise and just add TRUE = true, FALSE = false to the enum? That sounds sane. But I don't recall all the details

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-08 Thread James Bottomley
On Tue, 2007-05-08 at 14:44 -0700, David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 8 May 2007 13:11:52 -0700 On Tue, 08 May 2007 14:24:32 -0500 James Bottomley [EMAIL PROTECTED] wrote: However, could we compromise and just add TRUE = true, FALSE = false to the

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-07 Thread James Bottomley
On Thu, 2007-04-26 at 00:35 -0700, [EMAIL PROTECTED] wrote: From: Richard Knutsson [EMAIL PROTECTED] Convert: FALSE - false TRUE - true NAK'd by maintainer. James - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-07 Thread Andrew Morton
On Mon, 7 May 2007 14:06:56 -0700 Andrew Morton [EMAIL PROTECTED] wrote: so I'll drop it on those grounds, not on the bogus ones. However it will come back again. All subsystem-private implementations of TRUE and FALSE are in the firing line now. - To unsubscribe from this list: send the line

Re: [patch 16/30] drivers/scsi/aic7xxx_old: Convert to generic boolean-values

2007-05-07 Thread Richard Knutsson
Andrew Morton wrote: On Mon, 7 May 2007 14:06:56 -0700 Andrew Morton [EMAIL PROTECTED] wrote: so I'll drop it on those grounds, not on the bogus ones. However it will come back again. All subsystem-private implementations of TRUE and FALSE are in the firing line now. Amen. But