Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

Quoting Bart Van Assche : On 05/24/2016 06:52 AM, Bryant G. Ly wrote: +config SCSI_IBMVSCSIS + tristate "IBM Virtual SCSI Server support" + depends on PPC_PSERIES && SCSI_SRP && TARGET_CORE + help + This is the IBM POWER Virtual SCSI

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Tue, May 24, 2016 at 09:44:43AM -0700, Bart Van Assche wrote: > On 05/24/2016 09:34 AM, Greg KH wrote: > > On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > > > + u64 word1, u64

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On 05/24/2016 09:34 AM, Greg KH wrote: On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, + u64 word1, u64 word2) +{ + long rc; + struct vio_dev *vdev = adapter->dma_dev; + +

Re: [PATCHv2] libfc: Update rport reference counting

On Tue, 2016-05-24 at 08:11 +0200, Hannes Reinecke wrote: > Originally libfc would just be initializing the refcount to '1', > and using the disc_mutex to synchronize if and when the final put > should be happening. > This has a race condition as the mutex might be delayed, causing > other threads

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > + u64 word1, u64 word2) > > +{ > > + long rc; > > + struct vio_dev *vdev = adapter->dma_dev; > > + > > + pr_debug("ibmvscsis:

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On 05/24/2016 06:52 AM, Bryant G. Ly wrote: +config SCSI_IBMVSCSIS + tristate "IBM Virtual SCSI Server support" + depends on PPC_PSERIES && SCSI_SRP && TARGET_CORE + help + This is the IBM POWER Virtual SCSI Target Server + + The userspace component needed to

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Tue, May 24, 2016 at 08:52:58AM -0500, Bryant G. Ly wrote: > From: bgly Really? Please go get a proper review from the other internal IBM developers to fix this, and the other obvious problems with your patch, before you send it publically and force us to tell you these

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

On Tue, 2016-05-24 at 08:52 -0500, Bryant G. Ly wrote: > From: bgly > > This initial commit contains WIP of the IBM VSCSI Target Fabric > Module. It currently supports read/writes, and I have tested > the ability to create a file backstore with the driver and install > RHEL VIA

[PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

From: bgly This initial commit contains WIP of the IBM VSCSI Target Fabric Module. It currently supports read/writes, and I have tested the ability to create a file backstore with the driver and install RHEL VIA NIM and then boot up the partition via filio backstore through the

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

On Tue, 2016-05-24 at 08:53 +0200, Hans de Goede wrote: > Hi, > > On 23-05-16 19:36, James Bottomley wrote: > > On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: > > > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host > > > level") > > > removed the scsi_change_queue_depth()

[PATCH] scsi/qla2xxx: Remove erroneous macro qla82xx_get_temp_val1()

That macros uses logical "&&" instead of bit-wise "&" which is apparently wrong. Since the macro is completely unused, simply remove it, so that nobody can accidentially use it anymore. Signed-off-by: Thomas Huth --- drivers/scsi/qla2xxx/qla_nx.h | 1 - 1 file changed, 1

Re: [uas/scsi] untagged commands?

Hi, On 24-05-16 10:18, Tom Yan wrote: In this commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb There is the following comment: 1 tag is reserved for untagged commands So my question is, what

[uas/scsi] untagged commands?

In this commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/storage/uas.c?id=198de51dbc3454d95b015ca0a055b673f85f01bb There is the following comment: > 1 tag is reserved for untagged commands So my question is, what exactly are "untagged commands"? If we

[Bug 118081] open-iscsi Ping timeout erro

https://bugzilla.kernel.org/show_bug.cgi?id=118081 --- Comment #4 from Liu zhengyuan --- Hi, nab: Did you mean doing iozone test on a local disk LUN not a iscsi LUN from the word "are you seeing something different wrt iozone on a Linux host..?"? If so, I didn`t

[Bug 118081] open-iscsi Ping timeout erro

https://bugzilla.kernel.org/show_bug.cgi?id=118081 --- Comment #3 from nab --- Hey Mike & Co, Apologies for missing this bug-report. Comments below. (Adding target-devel CC') On Fri, 2016-05-13 at 11:19 -0500, Mike Christie wrote: > On 05/11/2016 10:34 PM,

Re: [Bug 118081] New: open-iscsi Ping timeout erro

Hey Mike & Co, Apologies for missing this bug-report. Comments below. (Adding target-devel CC') On Fri, 2016-05-13 at 11:19 -0500, Mike Christie wrote: > On 05/11/2016 10:34 PM, bugzilla-dae...@bugzilla.kernel.org wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=118081 > > > >

Re: [PATCH v2 1/1] uas: remove can_queue set in host template

Hi, On 23-05-16 21:28, tom.t...@gmail.com wrote: From: Tom Yan Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made qdepth limit set in host template (`.can_queue = MAX_CMNDS`) redundant. Removing it to avoid confusion. Signed-off-by: Tom Yan

Re: [PATCH] USB: uas: Fix slave queue_depth not being set

Hi, On 23-05-16 19:36, James Bottomley wrote: On Mon, 2016-05-23 at 13:49 +0200, Hans de Goede wrote: Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") removed the scsi_change_queue_depth() call from uas_slave_configure() assuming that the slave would inherit the host's

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

Hi Or & Co, On Wed, 2016-05-18 at 14:45 +0300, Or Gerlitz wrote: > On Sat, Apr 30, 2016 at 6:54 PM, Or Gerlitz wrote: > > On Tue, Apr 19, 2016 at 9:30 PM, Varun Prakash wrote: > >> cxgbit.h - This file contains data structure > >> definitions for

[PATCHv2] libfc: Update rport reference counting

Originally libfc would just be initializing the refcount to '1', and using the disc_mutex to synchronize if and when the final put should be happening. This has a race condition as the mutex might be delayed, causing other threads to access an invalid structure. This patch updates the rport