Re: [PREEMPT-RT] [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-17 Thread Sebastian Andrzej Siewior
On 2017-05-17 17:07:34 [+0200], To Chad Dupuis wrote: > > > Sebastian, can you add this change to your patch set? > > > > Are sure that you can reliably reproduce the issue and fix it with the > > patch above? Because this patch: > > oh. Okay. Now it clicked. It can fix the issue but it is still

Re: [PREEMPT-RT] [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-17 Thread Sebastian Andrzej Siewior
On 2017-05-17 17:01:53 [+0200], To Chad Dupuis wrote: > On 2017-05-12 11:55:52 [-0400], Chad Dupuis wrote: > > Ok, I believe I've found the issue here. The machine that the test has > > performed on had many more possible CPUs than active CPUs. We calculate > > which CPU to the work time on in

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-17 Thread Chad Dupuis
On Wed, 17 May 2017, 11:01am, Sebastian Andrzej Siewior wrote: > On 2017-05-12 11:55:52 [-0400], Chad Dupuis wrote: > > Ok, I believe I've found the issue here. The machine that the test has > > performed on had many more possible CPUs than active CPUs. We calculate > > which CPU to the work

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-17 Thread Sebastian Andrzej Siewior
On 2017-05-12 11:55:52 [-0400], Chad Dupuis wrote: > Ok, I believe I've found the issue here. The machine that the test has > performed on had many more possible CPUs than active CPUs. We calculate > which CPU to the work time on in bnx2fc_process_new_cqes() like this: > > unsigned int cpu =

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-12 Thread Chad Dupuis
On Tue, 9 May 2017, 11:18am, James Bottomley wrote: > On Tue, 2017-05-09 at 10:17 -0400, Chad Dupuis wrote: > > On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > > > > > > > Sebastian, > > > > > > > Martin, do you see any chance to get this merged? Chad replied to > > the > > > >

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-09 Thread Martin K. Petersen
Chad, > To be honest, I'm reluctant to merge these patches on bnx2fc as the > I/O path on this driver has been stable for quite some time and given > that it's an older driver I'm not looking to make changes there. I understand that the driver is in maintenance mode. However, the Linux kernel

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-09 Thread James Bottomley
On Tue, 2017-05-09 at 10:17 -0400, Chad Dupuis wrote: > On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > > > > Sebastian, > > > > > Martin, do you see any chance to get this merged? Chad replied to > the > > > list that he is going to test it on 2017-04-10, didn't respond to > the > >

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-09 Thread Chad Dupuis
On Mon, 8 May 2017, 10:04pm, Martin K. Petersen wrote: > > Sebastian, > > > Martin, do you see any chance to get this merged? Chad replied to the > > list that he is going to test it on 2017-04-10, didn't respond to the > > ping 10 days later. The series stalled last time in the same way. > >

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-08 Thread Martin K. Petersen
Sebastian, > Martin, do you see any chance to get this merged? Chad replied to the > list that he is going to test it on 2017-04-10, didn't respond to the > ping 10 days later. The series stalled last time in the same way. I am very reluctant to merge something when a driver has an active

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-05-04 Thread Sebastian Andrzej Siewior
On 2017-04-10 19:12:49 [+0200], To Martin K . Petersen wrote: > This is a repost to get the patches applied against v4.11-rc6. mkp's scsi > for-next tree can be merged with no conflicts. … Martin, do you see any chance to get this merged? Chad replied to the list that he is going to test it on

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-04-20 Thread Sebastian Andrzej Siewior
On 2017-04-10 14:20:41 [-0400], Chad Dupuis wrote: > Sebastian, will take a look. This [0] commit in tip's smp/hotplug branch is staged for the next merge window. It will trigger a lockdep warning on the recursive get_online_cpus() invocation in the two drivers. It is fixed/avoided by the

Re: [REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-04-10 Thread Chad Dupuis
On Mon, 10 Apr 2017, 5:12pm -, Sebastian Andrzej Siewior wrote: > This is a repost to get the patches applied against v4.11-rc6. mkp's scsi > for-next tree can be merged with no conflicts. > > The last repost [0] was not merged and stalled after Martin pinged Chad > [1]. He didn't even

[REEEEPOST] bnx2i + bnx2fc: convert to generic workqueue (#3)

2017-04-10 Thread Sebastian Andrzej Siewior
This is a repost to get the patches applied against v4.11-rc6. mkp's scsi for-next tree can be merged with no conflicts. The last repost [0] was not merged and stalled after Martin pinged Chad [1]. He didn't even reply after tglx pinged him approx two weeks later. Johannes Thumshirn was so kind

Re: [PREEMPT-RT] bnx2i + bnx2fc: convert to generic workqueue (#2)

2016-12-09 Thread Johannes Thumshirn
[ +Lee and Chris ] On Fri, Dec 09, 2016 at 12:33:11PM +0100, Thomas Gleixner wrote: > On Tue, 29 Nov 2016, Martin K. Petersen wrote: > > > > "Sebastian" == Sebastian Andrzej Siewior > > > writes: > > > > Sebastian> This is the a repost + fixups to get the patches

Re: [PREEMPT-RT] bnx2i + bnx2fc: convert to generic workqueue (#2)

2016-12-09 Thread Thomas Gleixner
On Tue, 29 Nov 2016, Martin K. Petersen wrote: > > "Sebastian" == Sebastian Andrzej Siewior writes: > > Sebastian> This is the a repost + fixups to get the patches applied > Sebastian> against v4.9-rc4. mkp's scsi for-next tree can be merged > Sebastian> with no

Re: bnx2i + bnx2fc: convert to generic workqueue (#2)

2016-11-29 Thread Martin K. Petersen
> "Sebastian" == Sebastian Andrzej Siewior writes: Sebastian> This is the a repost + fixups to get the patches applied Sebastian> against v4.9-rc4. mkp's scsi for-next tree can be merged Sebastian> with no conflicts. Chad? -- Martin K. Petersen Oracle Linux

bnx2i + bnx2fc: convert to generic workqueue (#2)

2016-11-22 Thread Sebastian Andrzej Siewior
This is the a repost + fixups to get the patches applied against v4.9-rc4. mkp's scsi for-next tree can be merged with no conflicts. The last repost was not merged and stalled after Chad Dupuis said to hold on because he is testing but never came back with the results [0]. Johannes confirmed that

bnx2i + bnx2fc: convert to generic workqueue

2016-11-18 Thread Sebastian Andrzej Siewior
This is the second repost + fixups to get the patches applied against v4.9-rc4. mkp's scsi for-next tree can be merged with no conflicts. The last repost was not merged and stalled after Chad Dupuis said to hold on because he is testing but never came back with the results [0]. Johannes confirmed